Paths
| Differential D141572
[C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag ClosedPublic Authored by ChuanqiXu on Jan 12 2023, 12:29 AM.
Details
Summary According to the discussion of https://github.com/llvm/llvm-project/issues/59110, we should deprecate the use of -fcoroutines-ts in LLVM16 and remove it in LLVM17. I've tested this with libcxx and it is fine since we disabled all the warnings for the test of <experimental/coroutine>. See https://github.com/llvm/llvm-project/blob/cefa5cefdce2d5090002c3116403f7e5ca5700b9/libcxx/test/std/experimental/language.support/support.coroutines/lit.local.cfg#L7-L8
Diff Detail
Event TimelineComment Actions Thank you for working on this! I think the Debian CI failure is unrelated, but the libc++ one looks plausibly related: /home/libcxx-builder/.buildkite-agent/builds/e6f11fd202bc-1/llvm-project/libcxx-ci/build/generic-cxx03/include/c++/v1/module.modulemap:773:10: error: module 'std.coroutine' requires feature 'coroutines'
module coroutine {
^
/home/libcxx-builder/.buildkite-agent/builds/e6f11fd202bc-1/llvm-project/libcxx-ci/libcxx/test/libcxx/modules_include.sh.cpp:158:10: note: submodule of top-level module 'std' implicitly imported here
#include <coroutine>
^
1 error generated.adding the libc++ reviewers for awareness.
Comment Actions
Yes, this is related. It should be enough to add "coroutine": "(defined(__cpp_impl_coroutine) && __cpp_impl_coroutine >= 201902L) || (defined(__cpp_coroutines) && __cpp_coroutines >= 201703L)" to libcxx/utils/generate_header_tests.py and run ninja libcxx-generate-files. Comment Actions After failed to reproduce the error locally, try to follow the instructions from @philnik to see if the CI-Bot will break. Comment Actions @philnik when I run ninja libcxx-generate-files locally, it says ninja: error: unknown target 'libcxx-generate-files'. The following off is my configuring command: cmake -G Ninja -S llvm -B build_libcxx_modules -DLLVM_ENABLE_PROJECTS="clang" -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi" -DCMAKE_BUILD_TYPE=Release Do you know if anything goes wrong? Comment Actions
It's probably because you're using the bootstrapping build. Since this invokes another CMake command internally to build libc++, the targets aren't available. It should work with cmake -G Ninja -S runtimes -B <...> -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi". Comment Actions
Got it. It fixed my problem. Comment Actions Now it looks like the failure are not related to the patch. Although there are some clang-format related failures, the related changes are generated automatically and I roughly remember libcxx don't use libcxx. @philnik would you like to take a look to ensure if the failures are related to the patch or not? Comment Actions LGTM from the libc++ side of things % nit. I think @aaron.ballman should take another look at the Clang changes.
This revision is now accepted and ready to land.Jan 16 2023, 10:35 AM Comment Actions Address comments and refine the wording from "use -std=c++20" to "use -std=c++20 or higher". This revision was landed with ongoing or failed builds.Jan 17 2023, 6:27 PM Closed by commit rGf90074274673: [C++] [Coroutines] Deprecates the '-fcoroutines-ts' flag (authored by ChuanqiXu). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 490014 clang/docs/ReleaseNotes.rst
clang/include/clang/Basic/DiagnosticDriverKinds.td
clang/lib/Driver/ToolChains/Clang.cpp
clang/test/Driver/coroutines.cpp
libcxx/test/libcxx/assertions/headers_declare_verbose_abort.sh.cpp
libcxx/test/libcxx/clang_tidy.sh.cpp
libcxx/test/libcxx/double_include.sh.cpp
libcxx/test/libcxx/min_max_macros.compile.pass.cpp
libcxx/test/libcxx/modules_include.sh.cpp
libcxx/test/libcxx/nasty_macros.compile.pass.cpp
libcxx/test/libcxx/no_assert_include.compile.pass.cpp
libcxx/utils/generate_header_tests.py
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||