This is an archive of the discontinued LLVM Phabricator instance.

Differential D140983

[IRBuilder] Use canonical i64 type for insertelement index used by vector splats.
ClosedPublic

Authored by paulwalker-arm on Jan 4 2023, 6:30 AM.

Details

Reviewers
aartbik
ftynse
dcaballe
bollu
sdesmalen
david-arm
Commits
rGeae26b6640af: [IRBuilder] Use canonical i64 type for insertelement index used by vector…
Summary

Instcombine prefers this canonical form (see getPreferredVectorIndex),
as does IRBuilder when passing the index as an integer so we may as
well use the prefered form from creation.

NOTE: All test changes are mechanical with nothing else expected beyond a change of index type from i32 to i64.

Diff Detail

Event Timeline

paulwalker-arm created this revision.Jan 4 2023, 6:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 4 2023, 6:30 AM
Herald added subscribers: frasercrmck, luismarques, apazos and 23 others. · View Herald Transcript
paulwalker-arm requested review of this revision.Jan 4 2023, 6:30 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 4 2023, 6:30 AM
Herald added subscribers: llvm-commits, cfe-commits, • pcwang-thead, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B205682: Diff 486266.Jan 4 2023, 7:05 AM
paulwalker-arm updated this revision to Diff 486284.Jan 4 2023, 7:17 AM

Update MLIR test.

Herald added a reviewer: aartbik. · View Herald TranscriptJan 4 2023, 7:17 AM
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: Moerafaat, zero9178, bzcheeseman and 23 others. · View Herald Transcript
Harbormaster completed remote builds in B205696: Diff 486284.Jan 4 2023, 8:49 AM
paulwalker-arm updated this revision to Diff 486332.Jan 4 2023, 10:03 AM

Update poly tests.

Herald added a reviewer: bollu. · View Herald TranscriptJan 4 2023, 10:03 AM
Harbormaster completed remote builds in B205734: Diff 486332.Jan 4 2023, 11:35 AM
paulwalker-arm added reviewers: sdesmalen, david-arm.Jan 4 2023, 12:11 PM
paulwalker-arm added a child revision: D141056: [SVE][CGBuiltins] Remove need for instcombine from ACLE tests..Jan 5 2023, 7:20 AM
david-arm accepted this revision.Jan 5 2023, 8:44 AM

LGTM! The change seems sensible to me, although perhaps worth waiting a day or two in case anyone else has objections? I noticed that we still create inserts using 32-bit indices in a few other places such as the SLPVectorizer, but I imagine these can be tidied up over time if necessary.

This revision is now accepted and ready to land.Jan 5 2023, 8:44 AM
This revision was landed with ongoing or failed builds.Jan 11 2023, 6:10 AM
Closed by commit rGeae26b6640af: [IRBuilder] Use canonical i64 type for insertelement index used by vector… (authored by paulwalker-arm). · Explain Why
This revision was automatically updated to reflect the committed changes.
paulwalker-arm added a commit: rGeae26b6640af: [IRBuilder] Use canonical i64 type for insertelement index used by vector….

Large Diff

This large diff affects 181 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
clang/
test/
CodeGen/
PowerPC/
4 lines
SystemZ/
64 lines
104 lines
18 lines
64 lines
104 lines
64 lines
arm-mve-intrinsics/
168 lines
12 lines
48 lines
40 lines
12 lines
18 lines
18 lines
24 lines
12 lines
12 lines
8 lines
8 lines
12 lines
12 lines
12 lines
12 lines
92 lines
18 lines
CodeGenCXX/
8 lines
2 lines
32 lines
14 lines
38 lines
2 lines
CodeGenOpenCL/
2 lines
llvm/
lib/
IR/
4 lines
4 lines
test/
CodeGen/
Generic/
8 lines
20 lines
20 lines
Thumb2/
6 lines
Transforms/
CodeGenPrepare/
AArch64/
2 lines
2 lines
ConstraintElimination/
2 lines
InstCombine/
AArch64/
26 lines
10 lines
10 lines
2 lines
4 lines
2 lines
4 lines
4 lines
4 lines
InstSimplify/
ConstProp/
8 lines
8 lines
52 lines
2 lines
2 lines
2 lines
LoopVectorize/
AArch64/
12 lines
8 lines
2 lines
4 lines
2 lines
4 lines
6 lines
2 lines
6 lines
102 lines
4 lines
6 lines
2 lines
18 lines
16 lines
4 lines
2 lines
2 lines
4 lines
8 lines
2 lines
62 lines
4 lines
10 lines
4 lines
22 lines
32 lines
36 lines
4 lines
4 lines
12 lines
24 lines
4 lines
ARM/
4 lines
4 lines
RISCV/
2 lines
68 lines
4 lines
2 lines
16 lines
20 lines
32 lines
8 lines
54 lines
2 lines
128 lines
4 lines
X86/
2 lines
4 lines
8 lines
4 lines
12 lines
4 lines
16 lines
8 lines
6 lines
2 lines
2 lines
12 lines
2 lines
2 lines
18 lines
4 lines
28 lines
2 lines
2 lines
4 lines
16 lines
54 lines
2 lines
2 lines
2 lines
2 lines
24 lines
2 lines
2 lines
2 lines
2 lines
12 lines
2 lines
2 lines
2 lines
6 lines
2 lines
6 lines
4 lines
10 lines
4 lines
2 lines
6 lines
4 lines
4 lines
12 lines
4 lines
8 lines
10 lines
16 lines
LowerMatrixIntrinsics/
108 lines
16 lines
136 lines
24 lines
16 lines
16 lines
60 lines
60 lines
16 lines
16 lines
60 lines
32 lines
60 lines
60 lines
16 lines
40 lines
48 lines
108 lines
8 lines
212 lines
RewriteStatepointsForGC/
12 lines
4 lines
Scalarizer/
6 lines
mlir/
test/
Target/
LLVMIR/
2 lines
polly/
test/
CodeGen/
2 lines
2 lines
2 lines
2 lines

Diff 488185

clang/test/CodeGen/PowerPC/builtins-ppc-p10vector.c

clang/test/CodeGen/SystemZ/zvector.c

clang/test/CodeGen/aarch64-sve-vector-arith-ops.c

clang/test/CodeGen/aarch64-sve-vector-bitwise-ops.c

clang/test/CodeGen/aarch64-sve-vector-shift-ops.c

clang/test/CodeGen/aarch64-sve-vls-arith-ops.c

clang/test/CodeGen/aarch64-sve-vls-shift-ops.c

clang/test/CodeGen/arm-mve-intrinsics/compare.c

clang/test/CodeGen/arm-mve-intrinsics/cplusplus.cpp

clang/test/CodeGen/arm-mve-intrinsics/dup.c

clang/test/CodeGen/arm-mve-intrinsics/ternary.c

clang/test/CodeGen/arm-mve-intrinsics/vaddq.c

clang/test/CodeGen/arm-mve-intrinsics/vhaddq.c

clang/test/CodeGen/arm-mve-intrinsics/vhsubq.c

clang/test/CodeGen/arm-mve-intrinsics/vmulq.c

clang/test/CodeGen/arm-mve-intrinsics/vqaddq.c

clang/test/CodeGen/arm-mve-intrinsics/vqdmulhq.c

clang/test/CodeGen/arm-mve-intrinsics/vqdmullbq.c

clang/test/CodeGen/arm-mve-intrinsics/vqdmulltq.c

clang/test/CodeGen/arm-mve-intrinsics/vqrdmulhq.c

clang/test/CodeGen/arm-mve-intrinsics/vqsubq.c

clang/test/CodeGen/arm-mve-intrinsics/vsubq.c

clang/test/CodeGen/matrix-type-operators-fast-math.c

clang/test/CodeGen/matrix-type-operators.c

clang/test/CodeGen/vecshift.c

clang/test/CodeGenCXX/aarch64-sve-vector-conditional-op.cpp

clang/test/CodeGenCXX/ext-int.cpp

clang/test/CodeGenCXX/ext-vector-type-conditional.cpp

clang/test/CodeGenCXX/matrix-type-operators.cpp

clang/test/CodeGenCXX/vector-size-conditional.cpp

clang/test/CodeGenCXX/vector-splat-conversion.cpp

clang/test/CodeGenOpenCL/bool_cast.cl

llvm/lib/IR/Constants.cpp

llvm/lib/IR/IRBuilder.cpp

llvm/test/CodeGen/Generic/expand-vp-gather-scatter.ll

llvm/test/CodeGen/Generic/expand-vp-load-store.ll

llvm/test/CodeGen/Generic/expand-vp.ll

llvm/test/CodeGen/Thumb2/mve-gather-optimisation-deep.ll

llvm/test/Transforms/CodeGenPrepare/AArch64/gather-scatter-opt-inseltpoison.ll

llvm/test/Transforms/CodeGenPrepare/AArch64/gather-scatter-opt.ll

llvm/test/Transforms/ConstraintElimination/geps-ptrvector.ll

llvm/test/Transforms/InstCombine/AArch64/sve-intrinsic-abs-srshl.ll

llvm/test/Transforms/InstCombine/AArch64/sve-intrinsic-fmul-idempotency.ll

llvm/test/Transforms/InstCombine/AArch64/sve-intrinsic-mul-idempotency.ll

llvm/test/Transforms/InstCombine/div.ll

llvm/test/Transforms/InstCombine/fdiv.ll

llvm/test/Transforms/InstCombine/fmul.ll

llvm/test/Transforms/InstCombine/select.ll

llvm/test/Transforms/InstCombine/sub.ll

llvm/test/Transforms/InstCombine/zext-ctlz-trunc-to-ctlz-add.ll

llvm/test/Transforms/InstSimplify/ConstProp/vscale-inseltpoison.ll

llvm/test/Transforms/InstSimplify/ConstProp/vscale.ll

llvm/test/Transforms/InstSimplify/cmp-vec-fast-path.ll

llvm/test/Transforms/InstSimplify/gep.ll

llvm/test/Transforms/InstSimplify/vscale-inseltpoison.ll

llvm/test/Transforms/InstSimplify/vscale.ll

llvm/test/Transforms/LoopVectorize/AArch64/epilog-vectorization-widen-inductions.ll

llvm/test/Transforms/LoopVectorize/AArch64/extractvalue-no-scalarization-required.ll

llvm/test/Transforms/LoopVectorize/AArch64/first-order-recurrence.ll

llvm/test/Transforms/LoopVectorize/AArch64/gather-do-not-vectorize-addressing.ll

llvm/test/Transforms/LoopVectorize/AArch64/interleaved-store-of-first-order-recurrence.ll

llvm/test/Transforms/LoopVectorize/AArch64/outer_loop_test1_no_explicit_vect_width.ll

llvm/test/Transforms/LoopVectorize/AArch64/scalable-avoid-scalarization.ll

llvm/test/Transforms/LoopVectorize/AArch64/scalable-call.ll

llvm/test/Transforms/LoopVectorize/AArch64/scalable-reduction-inloop-cond.ll

llvm/test/Transforms/LoopVectorize/AArch64/scalable-strict-fadd.ll

llvm/test/Transforms/LoopVectorize/AArch64/strict-fadd.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-basic-vec.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-cond-inv-loads.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-epilog-vect.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-gather-scatter.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-inductions-unusual-types.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-inv-loads.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-inv-store.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-large-strides.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-live-out-pointer-induction.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-low-trip-count.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-select-cmp.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-tail-folding-forced.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-tail-folding-option.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-tail-folding-optsize.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-tail-folding-reductions.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-tail-folding-unroll.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-tail-folding.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-vector-reverse.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-widen-extractvalue.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-widen-gep.ll

llvm/test/Transforms/LoopVectorize/AArch64/sve-widen-phi.ll

llvm/test/Transforms/LoopVectorize/AArch64/tail-fold-uniform-memops.ll

llvm/test/Transforms/LoopVectorize/ARM/mve-gather-scatter-tailpred.ll

llvm/test/Transforms/LoopVectorize/ARM/tail-folding-not-allowed.ll

llvm/test/Transforms/LoopVectorize/RISCV/defaults.ll

llvm/test/Transforms/LoopVectorize/RISCV/divrem.ll

llvm/test/Transforms/LoopVectorize/RISCV/illegal-type.ll

llvm/test/Transforms/LoopVectorize/RISCV/low-trip-count.ll

llvm/test/Transforms/LoopVectorize/RISCV/mask-index-type.ll

llvm/test/Transforms/LoopVectorize/RISCV/masked_gather_scatter.ll

llvm/test/Transforms/LoopVectorize/RISCV/scalable-basics.ll

llvm/test/Transforms/LoopVectorize/RISCV/scalable-tailfold.ll

llvm/test/Transforms/LoopVectorize/RISCV/select-cmp-reduction.ll

llvm/test/Transforms/LoopVectorize/RISCV/short-trip-count.ll

llvm/test/Transforms/LoopVectorize/RISCV/uniform-load-store.ll

llvm/test/Transforms/LoopVectorize/RISCV/zvl32b.ll

llvm/test/Transforms/LoopVectorize/X86/conversion-cost.ll

llvm/test/Transforms/LoopVectorize/X86/epilog-vectorization-inductions.ll

llvm/test/Transforms/LoopVectorize/X86/load-deref-pred.ll

llvm/test/Transforms/LoopVectorize/X86/metadata-enable.ll

llvm/test/Transforms/LoopVectorize/X86/optsize.ll

llvm/test/Transforms/LoopVectorize/X86/outer_loop_test1_no_explicit_vect_width.ll

llvm/test/Transforms/LoopVectorize/X86/pr54634.ll

llvm/test/Transforms/LoopVectorize/X86/tail_loop_folding.ll

llvm/test/Transforms/LoopVectorize/X86/uniform_mem_op.ll

llvm/test/Transforms/LoopVectorize/X86/vect.omp.force.small-tc.ll

llvm/test/Transforms/LoopVectorize/X86/vectorize-interleaved-accesses-gap.ll

llvm/test/Transforms/LoopVectorize/X86/x86-predication.ll

llvm/test/Transforms/LoopVectorize/dont-fold-tail-for-divisible-TC.ll

llvm/test/Transforms/LoopVectorize/epilog-vectorization-reductions.ll

llvm/test/Transforms/LoopVectorize/first-order-recurrence-complex.ll

llvm/test/Transforms/LoopVectorize/first-order-recurrence-multiply-recurrences.ll

llvm/test/Transforms/LoopVectorize/first-order-recurrence.ll

llvm/test/Transforms/LoopVectorize/float-minmax-instruction-flag.ll

llvm/test/Transforms/LoopVectorize/if-pred-non-void.ll

llvm/test/Transforms/LoopVectorize/if-pred-stores.ll

llvm/test/Transforms/LoopVectorize/induction-step.ll

llvm/test/Transforms/LoopVectorize/induction.ll

llvm/test/Transforms/LoopVectorize/instruction-only-used-outside-of-loop.ll

llvm/test/Transforms/LoopVectorize/loop-form.ll

llvm/test/Transforms/LoopVectorize/minmax_reduction.ll

llvm/test/Transforms/LoopVectorize/multiple-strides-vectorization.ll

llvm/test/Transforms/LoopVectorize/optimal-epilog-vectorization.ll

llvm/test/Transforms/LoopVectorize/optsize.ll

llvm/test/Transforms/LoopVectorize/outer-loop-vec-phi-predecessor-order.ll

llvm/test/Transforms/LoopVectorize/outer_loop_test1.ll

llvm/test/Transforms/LoopVectorize/outer_loop_test2.ll

llvm/test/Transforms/LoopVectorize/pr30654-phiscev-sext-trunc.ll

llvm/test/Transforms/LoopVectorize/pr39417-optsize-scevchecks.ll

llvm/test/Transforms/LoopVectorize/pr44488-predication.ll

llvm/test/Transforms/LoopVectorize/pr45259.ll

llvm/test/Transforms/LoopVectorize/pr50686.ll

llvm/test/Transforms/LoopVectorize/pr51614-fold-tail-by-masking.ll

llvm/test/Transforms/LoopVectorize/pr55167-fold-tail-live-out.ll

llvm/test/Transforms/LoopVectorize/reduction-small-size.ll

llvm/test/Transforms/LoopVectorize/scalable-first-order-recurrence.ll

llvm/test/Transforms/LoopVectorize/scalable-inductions.ll

llvm/test/Transforms/LoopVectorize/scalable-lifetime.ll

llvm/test/Transforms/LoopVectorize/scalable-loop-unpredicated-body-scalar-tail.ll

llvm/test/Transforms/LoopVectorize/scalable-reduction-inloop.ll

llvm/test/Transforms/LoopVectorize/scalable-trunc-min-bitwidth.ll

llvm/test/Transforms/LoopVectorize/select-cmp.ll

llvm/test/Transforms/LoopVectorize/select-reduction.ll

llvm/test/Transforms/LoopVectorize/single-value-blend-phis.ll

llvm/test/Transforms/LoopVectorize/uniform-blend.ll

llvm/test/Transforms/LoopVectorize/vplan-widen-select-instruction.ll

llvm/test/Transforms/LowerMatrixIntrinsics/bigger-expressions-double.ll

llvm/test/Transforms/LowerMatrixIntrinsics/const-gep.ll

llvm/test/Transforms/LowerMatrixIntrinsics/dot-product.ll

llvm/test/Transforms/LowerMatrixIntrinsics/multiply-add-sub-double-row-major.ll

llvm/test/Transforms/LowerMatrixIntrinsics/multiply-double-contraction-fmf.ll

llvm/test/Transforms/LowerMatrixIntrinsics/multiply-double-contraction.ll

llvm/test/Transforms/LowerMatrixIntrinsics/multiply-double-row-major.ll

llvm/test/Transforms/LowerMatrixIntrinsics/multiply-double.ll

llvm/test/Transforms/LowerMatrixIntrinsics/multiply-float-contraction-fmf.ll

llvm/test/Transforms/LowerMatrixIntrinsics/multiply-float-contraction.ll

llvm/test/Transforms/LowerMatrixIntrinsics/multiply-float.ll

llvm/test/Transforms/LowerMatrixIntrinsics/multiply-fused-volatile.ll

llvm/test/Transforms/LowerMatrixIntrinsics/multiply-i32-row-major.ll

llvm/test/Transforms/LowerMatrixIntrinsics/multiply-i32.ll

llvm/test/Transforms/LowerMatrixIntrinsics/multiply-left-transpose-row-major.ll

llvm/test/Transforms/LowerMatrixIntrinsics/multiply-right-transpose.ll

llvm/test/Transforms/LowerMatrixIntrinsics/preserve-existing-fast-math-flags.ll

llvm/test/Transforms/LowerMatrixIntrinsics/propagate-backwards-unsupported.ll

llvm/test/Transforms/LowerMatrixIntrinsics/transpose-opts-iterator-invalidation.ll

llvm/test/Transforms/LowerMatrixIntrinsics/transpose-opts.ll

llvm/test/Transforms/RewriteStatepointsForGC/scalar-base-vector.ll

llvm/test/Transforms/RewriteStatepointsForGC/vector-nonlive-clobber.ll

llvm/test/Transforms/Scalarizer/vector-gep.ll

mlir/test/Target/LLVMIR/llvmir.mlir

polly/test/CodeGen/invariant_load_hoist_alignment.ll

polly/test/CodeGen/simple_vec_cast.ll

polly/test/CodeGen/simple_vec_const.ll

polly/test/CodeGen/simple_vec_ptr_ptr_ty.ll