This is an archive of the discontinued LLVM Phabricator instance.

[X86] Support -march=emeraldrapids
ClosedPublic

Authored by FreddyYe on Jan 3 2023, 9:40 PM.

Diff Detail

Event Timeline

FreddyYe created this revision.Jan 3 2023, 9:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2023, 9:40 PM
FreddyYe requested review of this revision.Jan 3 2023, 9:40 PM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptJan 3 2023, 9:40 PM
Herald added subscribers: llvm-commits, Restricted Project, cfe-commits. · View Herald Transcript
craig.topper added inline comments.
clang/docs/ReleaseNotes.rst
806

Can this be on the same link as the other CPUs above?

llvm/docs/ReleaseNotes.rst
191

Incorporate in the line above?

llvm/lib/TargetParser/Host.cpp
850

Should Emeraldrapids be two words here?

llvm/lib/TargetParser/X86TargetParser.cpp
396

Should Emeraldrapids be two words here?

FreddyYe updated this revision to Diff 486163.Jan 3 2023, 10:21 PM
FreddyYe marked 4 inline comments as done.

Address comments. Thanks for review!

pengfei accepted this revision.Jan 5 2023, 2:53 AM

LGTM.

This revision is now accepted and ready to land.Jan 5 2023, 2:53 AM
skan accepted this revision.Jan 5 2023, 3:01 AM

LGTM

This revision was landed with ongoing or failed builds.Jan 5 2023, 4:27 AM
This revision was automatically updated to reflect the committed changes.