The global constant arguments could be in a different address space
than the first argument, so we have to add another overloaded argument.
This patch was originally made for CHERI LLVM (where globals can be in
address space 200), but it also appears to be useful for in-tree targets
as can be seen from the test diffs.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/Bitcode/upgrade-annotation.ll | ||
---|---|---|
14 | New tests should use opaque pointers. For autoupgrade we may want and need both test copies |
Comment Actions
LGTM
llvm/test/Bitcode/upgrade-annotation.ll | ||
---|---|---|
14 | I think this is fine for now. We'll deal with this when we remove the typed pointer auto-detection from the bitcode reader, at which point all existing typed pointer bitcode will get upgraded to opaque pointer bitcode. |
clang/test/CodeGen/annotations-field.c | ||
---|---|---|
5 | All these CHECK lines aren't getting consulted? |
All these CHECK lines aren't getting consulted?