Page MenuHomePhabricator

Tyker
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 16 2019, 2:09 PM (13 w, 5 d)

Recent Activity

Today

Tyker committed rL363920: Revert "[clang] Fixing windows buildbot after D61552".
Revert "[clang] Fixing windows buildbot after D61552"
Thu, Jun 20, 4:00 AM
Tyker committed rGe10a881c2b04: Revert "[clang] Fixing windows buildbot after D61552" (authored by Tyker).
Revert "[clang] Fixing windows buildbot after D61552"
Thu, Jun 20, 3:31 AM
Tyker added a reverting change for rG5d5d2ca69e2b: [clang] Fixing windows buildbot after D61552: rGe10a881c2b04: Revert "[clang] Fixing windows buildbot after D61552".
Thu, Jun 20, 3:31 AM
Tyker committed rG5d5d2ca69e2b: [clang] Fixing windows buildbot after D61552 (authored by Tyker).
[clang] Fixing windows buildbot after D61552
Thu, Jun 20, 3:27 AM
Tyker committed rL363919: [clang] Fixing windows buildbot after D61552.
[clang] Fixing windows buildbot after D61552
Thu, Jun 20, 3:26 AM
Tyker closed D63592: [clang] Fixing windows buildbot after D61552.
Thu, Jun 20, 3:26 AM · Restricted Project
Tyker updated the summary of D63592: [clang] Fixing windows buildbot after D61552.
Thu, Jun 20, 3:23 AM · Restricted Project
Tyker created D63592: [clang] Fixing windows buildbot after D61552.
Thu, Jun 20, 3:20 AM · Restricted Project

Yesterday

Tyker committed rGe1f4ba85e5c2: [clang] Adapt ASTMatcher to explicit(bool) specifier (authored by Tyker).
[clang] Adapt ASTMatcher to explicit(bool) specifier
Wed, Jun 19, 11:26 AM
Tyker committed rL363855: [clang] Adapt ASTMatcher to explicit(bool) specifier.
[clang] Adapt ASTMatcher to explicit(bool) specifier
Wed, Jun 19, 11:25 AM
Tyker closed D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier.
Wed, Jun 19, 11:25 AM · Restricted Project, Restricted Project
Tyker updated the diff for D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier.
Wed, Jun 19, 11:17 AM · Restricted Project, Restricted Project
Tyker added inline comments to D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier.
Wed, Jun 19, 9:03 AM · Restricted Project, Restricted Project
Tyker added inline comments to D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier.
Wed, Jun 19, 8:23 AM · Restricted Project, Restricted Project
Tyker updated the diff for D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier.

i was confuse because the log seemed like an error and it was happening in python2.7 and python3.7
but the actual error that was preventing generating the documentation only occurs in 3.7.

Wed, Jun 19, 8:23 AM · Restricted Project, Restricted Project
Tyker updated the diff for D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier.

fixed requested changes.

Wed, Jun 19, 6:02 AM · Restricted Project, Restricted Project
Tyker added inline comments to D63376: [clang] Small improvments after Adding APValue to ConstantExpr.
Wed, Jun 19, 3:48 AM · Restricted Project

Mon, Jun 17

Tyker updated the diff for D63376: [clang] Small improvments after Adding APValue to ConstantExpr.
Mon, Jun 17, 12:27 AM · Restricted Project

Sat, Jun 15

Tyker updated the diff for D63376: [clang] Small improvments after Adding APValue to ConstantExpr.
Sat, Jun 15, 6:59 AM · Restricted Project
Tyker created D63376: [clang] Small improvments after Adding APValue to ConstantExpr.
Sat, Jun 15, 6:53 AM · Restricted Project
Tyker committed rG83c7b61052bd: [clang] Add storage for APValue in ConstantExpr (authored by Tyker).
[clang] Add storage for APValue in ConstantExpr
Sat, Jun 15, 3:22 AM
Tyker committed rL363493: [clang] Add storage for APValue in ConstantExpr.
[clang] Add storage for APValue in ConstantExpr
Sat, Jun 15, 3:22 AM
Tyker closed D62399: [clang] Add storage for APValue in ConstantExpr.
Sat, Jun 15, 3:22 AM · Restricted Project, Restricted Project
Tyker committed rG0bb4d46b2be5: [clang] perform semantic checking in constant context (authored by Tyker).
[clang] perform semantic checking in constant context
Sat, Jun 15, 1:30 AM
Tyker committed rL363488: [clang] perform semantic checking in constant context.
[clang] perform semantic checking in constant context
Sat, Jun 15, 1:30 AM
Tyker closed D62009: [clang] perform semantic checking in constant context.
Sat, Jun 15, 1:30 AM · Restricted Project, Restricted Project

Fri, Jun 14

Tyker committed rG796ed03b8412: [C++20] add Basic consteval specifier (authored by Tyker).
[C++20] add Basic consteval specifier
Fri, Jun 14, 1:54 AM
Tyker committed rL363362: [C++20] add Basic consteval specifier.
[C++20] add Basic consteval specifier
Fri, Jun 14, 1:53 AM
Tyker closed D61790: [C++20] add Basic consteval specifier.
Fri, Jun 14, 1:53 AM · Restricted Project, Restricted Project
Tyker committed rGb63e577444d3: [clang] Fixing incorrect implicit deduction guides (PR41549) (authored by Tyker).
[clang] Fixing incorrect implicit deduction guides (PR41549)
Fri, Jun 14, 1:39 AM
Tyker committed rL363361: [clang] Fixing incorrect implicit deduction guides (PR41549).
[clang] Fixing incorrect implicit deduction guides (PR41549)
Fri, Jun 14, 1:39 AM
Tyker closed D63072: [clang] Fixing incorrect implicit deduction guides (PR41549).
Fri, Jun 14, 1:38 AM · Restricted Project, Restricted Project
Tyker committed rGef629c7ef8c2: [clang] Don't segfault on incorrect using directive (PR41400) (authored by Tyker).
[clang] Don't segfault on incorrect using directive (PR41400)
Fri, Jun 14, 1:25 AM
Tyker committed rL363360: [clang] Don't segfault on incorrect using directive (PR41400).
[clang] Don't segfault on incorrect using directive (PR41400)
Fri, Jun 14, 1:25 AM
Tyker closed D60523: [clang] Don't segfault on incorrect using directive (PR41400).
Fri, Jun 14, 1:25 AM · Restricted Project, Restricted Project

Tue, Jun 11

Tyker updated the diff for D63134: [clang] improving diagnotics for invalid constexpr defaulted special membres.
Tue, Jun 11, 5:34 AM · Restricted Project
Tyker created D63134: [clang] improving diagnotics for invalid constexpr defaulted special membres.
Tue, Jun 11, 5:30 AM · Restricted Project

Mon, Jun 10

Tyker updated the diff for D63072: [clang] Fixing incorrect implicit deduction guides (PR41549).

fixed the issue.

Mon, Jun 10, 11:03 AM · Restricted Project, Restricted Project
Tyker created D63072: [clang] Fixing incorrect implicit deduction guides (PR41549).
Mon, Jun 10, 3:13 AM · Restricted Project, Restricted Project

Sun, Jun 9

Tyker updated the diff for D61790: [C++20] add Basic consteval specifier.

fixed requested changes.
also adapted lldb to AST change.
I will commit this when i have access.

Sun, Jun 9, 12:41 AM · Restricted Project, Restricted Project
Tyker updated the diff for D62399: [clang] Add storage for APValue in ConstantExpr.

fixed requested changes.
i will commit it when i have access.

Sun, Jun 9, 12:08 AM · Restricted Project, Restricted Project

Fri, Jun 7

Tyker added a comment to D62009: [clang] perform semantic checking in constant context.

@rsmith ping.

Fri, Jun 7, 7:06 AM · Restricted Project, Restricted Project
Tyker updated the diff for D61790: [C++20] add Basic consteval specifier.

fixed requested changes except some i commented upon.

Fri, Jun 7, 7:03 AM · Restricted Project, Restricted Project
Tyker added inline comments to D61790: [C++20] add Basic consteval specifier.
Fri, Jun 7, 7:03 AM · Restricted Project, Restricted Project

Wed, Jun 5

Tyker updated the diff for D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier.

changed as requested.

Wed, Jun 5, 3:53 AM · Restricted Project, Restricted Project

Tue, Jun 4

Tyker reclaimed D59467: [clang] Adding the Likelihood Attribute from C++2a.

I closed it originally because it was inactive and i was working on other reviews. but i learned this is not how it is supposed to be done.

Tue, Jun 4, 12:03 AM · Restricted Project

Mon, Jun 3

Tyker added a comment to D61790: [C++20] add Basic consteval specifier.

@rsmith ping

Mon, Jun 3, 11:49 PM · Restricted Project, Restricted Project

Fri, May 31

Tyker added a comment to D62399: [clang] Add storage for APValue in ConstantExpr.

ping @rsmith

Fri, May 31, 6:06 AM · Restricted Project, Restricted Project

Tue, May 28

Tyker added a comment to D62009: [clang] perform semantic checking in constant context.

@rsmith friendly ping.

Tue, May 28, 11:58 PM · Restricted Project, Restricted Project

Mon, May 27

Tyker added inline comments to D61790: [C++20] add Basic consteval specifier.
Mon, May 27, 8:24 AM · Restricted Project, Restricted Project
Tyker updated the diff for D61790: [C++20] add Basic consteval specifier.

previous revision was spitted in multiple part as requested
consteval specific semantic and code-gen have been removed from the patch.
other parts:

Mon, May 27, 8:24 AM · Restricted Project, Restricted Project

Fri, May 24

Tyker created D62399: [clang] Add storage for APValue in ConstantExpr.
Fri, May 24, 8:55 AM · Restricted Project, Restricted Project

Wed, May 22

Tyker updated the diff for D62009: [clang] perform semantic checking in constant context.

most comments were fixed. but there is a few point on which the direction isn't clear.

Wed, May 22, 2:18 AM · Restricted Project, Restricted Project

May 21 2019

Tyker abandoned D59467: [clang] Adding the Likelihood Attribute from C++2a.
May 21 2019, 8:44 AM · Restricted Project

May 20 2019

Tyker added a comment to D62009: [clang] perform semantic checking in constant context.

I changed the approach in the last revision. the information is now propagated using the expression evaluation context and then via booleans. I should have added a comment to make it clear.

May 20 2019, 2:38 PM · Restricted Project, Restricted Project
Tyker updated the summary of D62009: [clang] perform semantic checking in constant context.
May 20 2019, 3:30 AM · Restricted Project, Restricted Project
Tyker updated the summary of D62009: [clang] perform semantic checking in constant context.
May 20 2019, 3:28 AM · Restricted Project, Restricted Project
Tyker updated the diff for D62009: [clang] perform semantic checking in constant context.
May 20 2019, 3:28 AM · Restricted Project, Restricted Project

May 17 2019

Tyker added a comment to D62009: [clang] perform semantic checking in constant context.

I checked how we can propagate the information about constant context through semantic checking.
there are issues with using ConstantExpr to mark expressions as constant for semantic checking:

  • #1 multpile Expr::Ignore* operation remove ConstantExpr from the expression.
  • #2 Semantic checking Traverses the AST so all methods that only mark the top-level Node not will fail.
  • #3 at short term: adding ConstantExpr modifies the AST structure, so adding it everywhere it is needed for semantic checking will require changing a lot of code that depend closely on the AST structure.

Note: the limitation #2 also applies to the bit in ExprBitfield solution in its current form.

May 17 2019, 4:51 AM · Restricted Project, Restricted Project

May 16 2019

Tyker added a comment to D62009: [clang] perform semantic checking in constant context.

i added this bit because when we eventually store the result of evaluation in ConstantExpr we will probably want to trail-allocate the APValue's possible representations separately to limit memory consumption. but if we do this the ConstantExpr node will need to be created after evaluation of the value, so we cannot use it to mark that the expression should be evaluated in constant context.
if we won't store APValue's possible representations separately in trail-allocate space, wrapping the expression in a ConstantExpr is the right solution.

May 16 2019, 12:17 PM · Restricted Project, Restricted Project
Tyker updated the diff for D62009: [clang] perform semantic checking in constant context.
May 16 2019, 7:58 AM · Restricted Project, Restricted Project
Tyker added a reviewer for D62009: [clang] perform semantic checking in constant context: rsmith.
May 16 2019, 7:25 AM · Restricted Project, Restricted Project
Tyker created D62009: [clang] perform semantic checking in constant context.
May 16 2019, 7:25 AM · Restricted Project, Restricted Project
Tyker updated the summary of D62009: [clang] perform semantic checking in constant context.
May 16 2019, 7:25 AM · Restricted Project, Restricted Project

May 14 2019

Tyker updated the diff for D61790: [C++20] add Basic consteval specifier.

code-gen was adapted to consteval.

May 14 2019, 7:02 AM · Restricted Project, Restricted Project

May 10 2019

Tyker created D61790: [C++20] add Basic consteval specifier.
May 10 2019, 8:45 AM · Restricted Project, Restricted Project
Tyker closed D61731: [clang] fix -Wparentheses in ParseDecl.cpp after D60934.

commited by https://reviews.llvm.org/rGba24f352f4fa47d6caabac3764b8d896d40fb934

May 10 2019, 8:09 AM

May 9 2019

Tyker updated the diff for D61731: [clang] fix -Wparentheses in ParseDecl.cpp after D60934.
May 9 2019, 6:59 AM
Tyker added inline comments to D60934: [clang] adding explicit(bool) from c++2a.
May 9 2019, 6:59 AM · Restricted Project, Restricted Project
Tyker created D61731: [clang] fix -Wparentheses in ParseDecl.cpp after D60934.
May 9 2019, 6:59 AM

May 7 2019

Tyker added a comment to D60934: [clang] adding explicit(bool) from c++2a.

could you commit this for me ?

May 7 2019, 2:03 AM · Restricted Project, Restricted Project

May 6 2019

Tyker updated the diff for D60934: [clang] adding explicit(bool) from c++2a.

fixed

May 6 2019, 3:10 PM · Restricted Project, Restricted Project
Tyker added a comment to rGd2b9fc88c8c4: Revert r359949 "[clang] adding explicit(bool) from c++2a".

i am sorry for this issue.
the patch at https://reviews.llvm.org/D60934 have been updated to fix this.

May 6 2019, 9:15 AM
Tyker updated the diff for D60934: [clang] adding explicit(bool) from c++2a.

Changes:

sorry for the inconvenience.

May 6 2019, 8:57 AM · Restricted Project, Restricted Project
Tyker added a comment to D60934: [clang] adding explicit(bool) from c++2a.

yes i am on it.

May 6 2019, 4:30 AM · Restricted Project, Restricted Project

May 5 2019

Tyker added a comment to D61556: [clang] fixing -ast-print for variadic parameter pack in lambda capture.

could you commit it for me please ?

May 5 2019, 4:22 AM · Restricted Project

May 4 2019

Tyker created D61556: [clang] fixing -ast-print for variadic parameter pack in lambda capture.
May 4 2019, 8:25 PM · Restricted Project
Tyker added a reviewer for D61556: [clang] fixing -ast-print for variadic parameter pack in lambda capture: rsmith.
May 4 2019, 8:25 PM · Restricted Project
Tyker added a reviewer for D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier: rsmith.
May 4 2019, 5:59 AM · Restricted Project, Restricted Project
Tyker created D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier.
May 4 2019, 5:57 AM · Restricted Project, Restricted Project

May 3 2019

Tyker updated the diff for D60934: [clang] adding explicit(bool) from c++2a.

@rsmith i made the last requested few changes. but i can't push the change.

May 3 2019, 1:59 AM · Restricted Project, Restricted Project

May 2 2019

Tyker updated the diff for D60934: [clang] adding explicit(bool) from c++2a.

fixed feedback from @rsmith @Rakete1111.

May 2 2019, 2:20 AM · Restricted Project, Restricted Project
Tyker added inline comments to D60934: [clang] adding explicit(bool) from c++2a.
May 2 2019, 2:20 AM · Restricted Project, Restricted Project

May 1 2019

Tyker added inline comments to D60934: [clang] adding explicit(bool) from c++2a.
May 1 2019, 3:45 AM · Restricted Project, Restricted Project
Tyker updated the diff for D60934: [clang] adding explicit(bool) from c++2a.

fixed feedback from @rsmith @Rakete1111 @xbolva00

May 1 2019, 3:45 AM · Restricted Project, Restricted Project

Apr 30 2019

Tyker added inline comments to D60934: [clang] adding explicit(bool) from c++2a.
Apr 30 2019, 10:58 AM · Restricted Project, Restricted Project
Tyker updated the diff for D60934: [clang] adding explicit(bool) from c++2a.

@rsmith fixed feedbacks

Apr 30 2019, 10:58 AM · Restricted Project, Restricted Project
Tyker added inline comments to D60934: [clang] adding explicit(bool) from c++2a.
Apr 30 2019, 3:54 AM · Restricted Project, Restricted Project

Apr 29 2019

Tyker updated the diff for D60934: [clang] adding explicit(bool) from c++2a.

merged similar code for AST serialization of ExplicitSpecifier in a static function

Apr 29 2019, 4:21 AM · Restricted Project, Restricted Project

Apr 28 2019

Tyker added a comment to D60934: [clang] adding explicit(bool) from c++2a.

Fixed based on Feedback from @rsmith @martong @Rakete1111.

Apr 28 2019, 3:55 PM · Restricted Project, Restricted Project
Tyker updated the diff for D60934: [clang] adding explicit(bool) from c++2a.
Apr 28 2019, 3:55 PM · Restricted Project, Restricted Project
Tyker added a comment to rG8eeb33497cd1: [PowerPC][Clang] Add tests for PowerPC MMX intrinsics.

the llvm-cxxfilt from source wasn't available (i don't know why) so llvm-lit silently fallback on the system one that appear not to support PowerPC.
with llvm-cxxfilt built from source it works correctly.

Apr 28 2019, 7:48 AM
Tyker added a comment to rG8eeb33497cd1: [PowerPC][Clang] Add tests for PowerPC MMX intrinsics.

this test is currently failing on master on my PC. here is the dump of the test failure.

Apr 28 2019, 2:38 AM

Apr 26 2019

Tyker added inline comments to D60934: [clang] adding explicit(bool) from c++2a.
Apr 26 2019, 9:38 AM · Restricted Project, Restricted Project

Apr 24 2019

Tyker updated subscribers of D60523: [clang] Don't segfault on incorrect using directive (PR41400).

@jkooker
i don't think it is possible for ASTContext::getDependentNameType to deal with NSS = nullptr except by reporting the error. we probably don't want to just report the error because the error could have been handled before invoking ASTContext::getDependentNameType.
and i agree that it should be reflected in the interface of those functions because pointer are often used a optional references. but wouldn't an assert + doxygen comment suffice ? instead of changing the interface, implementation and all callsites. Pointers as argument that are required not to be null are used in a lot of places in LLVM. for example DependentNameType::DependentNameType takes NNS as a pointer even thought it requires it to be non-null(calls a method on it). mixing pointers and references adds a lot of & and * which makes the code harder to read.

Apr 24 2019, 1:11 PM · Restricted Project, Restricted Project

Apr 23 2019

Tyker updated the diff for D60934: [clang] adding explicit(bool) from c++2a.

Fixed issues form feedback by @martong

Apr 23 2019, 11:00 AM · Restricted Project, Restricted Project

Apr 21 2019

Tyker updated the diff for D60934: [clang] adding explicit(bool) from c++2a.

@Quuxplusone @riccibruno fixed / answered feedback

Apr 21 2019, 2:01 AM · Restricted Project, Restricted Project

Apr 20 2019

Tyker updated the summary of D60934: [clang] adding explicit(bool) from c++2a.
Apr 20 2019, 2:21 PM · Restricted Project, Restricted Project
Tyker updated the summary of D60934: [clang] adding explicit(bool) from c++2a.
Apr 20 2019, 12:20 PM · Restricted Project, Restricted Project
Tyker updated the diff for D60934: [clang] adding explicit(bool) from c++2a.
Apr 20 2019, 9:51 AM · Restricted Project, Restricted Project