Page MenuHomePhabricator

Tyker
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 16 2019, 2:09 PM (210 w, 1 d)

Recent Activity

Wed, Mar 1

Tyker added a comment to D144814: Add capture of "IRUnits" as context for an MLIR Action.

The data-flow analysis framework has a concept very similar to IRUnit its called ProgramPoint maybe this should be shared ?

Wed, Mar 1, 6:22 PM · Restricted Project, Restricted Project
Tyker added inline comments to D144812: Introduce mlir::tracing::ExecutionContext.
Wed, Mar 1, 6:17 PM · Restricted Project, Restricted Project

Nov 16 2022

Tyker requested review of D138165: [MLIR][NFC] Add annotation printer hook.
Nov 16 2022, 4:51 PM · Restricted Project, Restricted Project

Oct 14 2022

Tyker added a reverting change for rG1a60a35769bc: Remove sign comparaison warning in APFixedPointTest.cpp: rGadf29726108a: Revert "Remove sign comparaison warning in APFixedPointTest.cpp".
Oct 14 2022, 1:42 PM · Restricted Project, Restricted Project
Tyker committed rGadf29726108a: Revert "Remove sign comparaison warning in APFixedPointTest.cpp" (authored by Tyker).
Revert "Remove sign comparaison warning in APFixedPointTest.cpp"
Oct 14 2022, 1:42 PM · Restricted Project, Restricted Project
Tyker committed rG1a60a35769bc: Remove sign comparaison warning in APFixedPointTest.cpp (authored by Tyker).
Remove sign comparaison warning in APFixedPointTest.cpp
Oct 14 2022, 1:39 PM · Restricted Project, Restricted Project
Tyker committed rG2c7b7eca85c2: [ADT] Fix Incorrect rounding for APFixedPoint::getIntPart (authored by Tyker).
[ADT] Fix Incorrect rounding for APFixedPoint::getIntPart
Oct 14 2022, 11:01 AM · Restricted Project, Restricted Project
Tyker closed D135562: [ADT] Fix Incorrect rounding for APFixedPoint::getIntPart.

pushed as 2c7b7eca85c2ccc9b0d5c65169213ce499652f92

Oct 14 2022, 11:01 AM · Restricted Project, Restricted Project

Oct 10 2022

Tyker requested review of D135562: [ADT] Fix Incorrect rounding for APFixedPoint::getIntPart.
Oct 10 2022, 1:38 AM · Restricted Project, Restricted Project

Oct 7 2022

Tyker added inline comments to D134725: [ADT] Add support for more formats in APFixedPoint.
Oct 7 2022, 2:13 PM · Restricted Project, Restricted Project

Oct 6 2022

Tyker closed D134725: [ADT] Add support for more formats in APFixedPoint.

Thank you for the review.

Oct 6 2022, 8:56 AM · Restricted Project, Restricted Project
Tyker committed rG1654b22ac048: [ADT] Add support for more formats in APFixedPoint (authored by Tyker).
[ADT] Add support for more formats in APFixedPoint
Oct 6 2022, 8:56 AM · Restricted Project, Restricted Project

Sep 28 2022

Tyker added a comment to D134725: [ADT] Add support for more formats in APFixedPoint.

Prior to this patch APFixedPoint only support semantics where the LsbWeight is is negative and the Width is at least as large as -LsbWeight.
This patch remove both those requirements.
for example:
with LsbWeight = 2, 12 would be represented as 3.
with LsbWeight = -2, 12 would be represented as 48.

IIUC should the weights have opposite values in this example? Based off the code, it looks like scale is just negative. So with LsbWeight = -2, then the scale is 2, and 0x1100 (12) is actually 0x11.00 (3). Similarly, LsbWeight = 2, then the scale is -2, and 0x1100 (12) is actually 0x1100|00 (48).

Sep 28 2022, 3:03 AM · Restricted Project, Restricted Project
Tyker updated the diff for D134725: [ADT] Add support for more formats in APFixedPoint.
Sep 28 2022, 3:03 AM · Restricted Project, Restricted Project

Sep 27 2022

Tyker requested review of D134725: [ADT] Add support for more formats in APFixedPoint.
Sep 27 2022, 3:38 AM · Restricted Project, Restricted Project

Sep 9 2022

Tyker closed D133384: [MLIR] Improve interaction of TypedValue with BlockAndValueMapping.

pushed as fa40fd40e055630c34890de84eb048796133fe03

Sep 9 2022, 8:56 AM · Restricted Project, Restricted Project
Tyker committed rGfa40fd40e055: [MLIR] Improve interaction of TypedValue with BlockAndValueMapping (authored by Tyker).
[MLIR] Improve interaction of TypedValue with BlockAndValueMapping
Sep 9 2022, 8:55 AM · Restricted Project, Restricted Project

Sep 6 2022

Tyker added inline comments to D132010: [MLIR] Add mlir::TypedValue.
Sep 6 2022, 4:56 PM · Restricted Project, Restricted Project
Tyker requested review of D133384: [MLIR] Improve interaction of TypedValue with BlockAndValueMapping.
Sep 6 2022, 4:55 PM · Restricted Project, Restricted Project
Tyker added inline comments to D132010: [MLIR] Add mlir::TypedValue.
Sep 6 2022, 11:45 AM · Restricted Project, Restricted Project

Aug 28 2022

Tyker closed D132010: [MLIR] Add mlir::TypedValue.

pushed as 688c51a5acc53b456014e53663051476d825e896

Aug 28 2022, 8:27 PM · Restricted Project, Restricted Project
Tyker committed rG688c51a5acc5: [MLIR] Add mlir::TypedValue (authored by Tyker).
[MLIR] Add mlir::TypedValue
Aug 28 2022, 8:27 PM · Restricted Project, Restricted Project

Aug 24 2022

Tyker closed D132009: [NFC][mlir] Add support for llvm style casting for mlir types.

has been committed as bb63d249f8612f87e819071663d81f516a2bec74

Aug 24 2022, 9:34 AM · Restricted Project, Restricted Project
Tyker committed rGbb63d249f861: [NFC][mlir] Add support for llvm style casting for mlir types (authored by Tyker).
[NFC][mlir] Add support for llvm style casting for mlir types
Aug 24 2022, 9:33 AM · Restricted Project, Restricted Project
Tyker updated the diff for D132010: [MLIR] Add mlir::TypedValue.
Aug 24 2022, 9:13 AM · Restricted Project, Restricted Project
Tyker updated the summary of D132009: [NFC][mlir] Add support for llvm style casting for mlir types.
Aug 24 2022, 9:11 AM · Restricted Project, Restricted Project
Tyker added a comment to D132010: [MLIR] Add mlir::TypedValue.
Aug 24 2022, 9:02 AM · Restricted Project, Restricted Project

Aug 22 2022

Tyker added inline comments to D132407: [ADT] Add llvm::popcount to <bit> helper wrapper.
Aug 22 2022, 1:02 PM · Restricted Project, Restricted Project
Tyker added inline comments to D132010: [MLIR] Add mlir::TypedValue.
Aug 22 2022, 9:24 AM · Restricted Project, Restricted Project
Tyker updated the diff for D132010: [MLIR] Add mlir::TypedValue.
Aug 22 2022, 9:24 AM · Restricted Project, Restricted Project

Aug 21 2022

Tyker added a comment to D132009: [NFC][mlir] Add support for llvm style casting for mlir types.

I would still like a comment for what to do about this issue (which i bypassed):

Aug 21 2022, 6:08 PM · Restricted Project, Restricted Project
Tyker added inline comments to D132009: [NFC][mlir] Add support for llvm style casting for mlir types.
Aug 21 2022, 6:01 PM · Restricted Project, Restricted Project
Tyker added inline comments to D132009: [NFC][mlir] Add support for llvm style casting for mlir types.
Aug 21 2022, 5:43 PM · Restricted Project, Restricted Project
Tyker updated the diff for D132009: [NFC][mlir] Add support for llvm style casting for mlir types.
Aug 21 2022, 5:43 PM · Restricted Project, Restricted Project
Tyker abandoned D74130: [clang] fix consteval call in default arguments.
Aug 21 2022, 10:39 AM · Restricted Project, Restricted Project
Tyker abandoned D59467: [clang] Adding the Likelihood Attribute from C++2a.
Aug 21 2022, 10:39 AM · Restricted Project, Restricted Project
Tyker abandoned D85144: [clang] Improve Dumping of APValues.
Aug 21 2022, 10:39 AM · Restricted Project, Restricted Project
Tyker abandoned D77734: [AssumeBundles] Adapt RecursivelyDeleteTriviallyDeadInstructions and depending passes..
Aug 21 2022, 10:38 AM · Restricted Project, Restricted Project
Tyker abandoned D78561: [NFC] Improve Debugging experience with SmallVector.

for the case of SmallVector it is as easy as adding a few used
But for many containers adding used attribute may cause previously new failure because the function annotated cannot be instantiated.

Aug 21 2022, 10:38 AM · Restricted Project, Restricted Project
Tyker abandoned D75009: [Diagnostic] Improve discoverability of ftabstop for misleading indentation.
Aug 21 2022, 10:35 AM · Restricted Project, Restricted Project
Tyker abandoned D63134: [clang] improving diagnotics for invalid constexpr defaulted special membres.
Aug 21 2022, 10:35 AM · Restricted Project, Restricted Project
Tyker abandoned D60561: [clang] fixing diagnostics of constexpr callstack.
Aug 21 2022, 10:35 AM · Restricted Project, Restricted Project

Aug 18 2022

Tyker updated the diff for D132009: [NFC][mlir] Add support for llvm style casting for mlir types.
Aug 18 2022, 6:17 PM · Restricted Project, Restricted Project
Tyker added a comment to D132009: [NFC][mlir] Add support for llvm style casting for mlir types.

I updated to to have the member version of cast/isa/dyn_cast depend on the out of line ones.

Aug 18 2022, 6:17 PM · Restricted Project, Restricted Project

Aug 17 2022

Tyker added a comment to D132009: [NFC][mlir] Add support for llvm style casting for mlir types.

+1 to the concept, many thanks for this! I think it makes more sense to implement the member versions with the llvm-style versions, it should simplify the member style code because then you won't have to manually implement the classof/isa/cast innards it'd just be cast<T>(*this) or something.

Aug 17 2022, 8:23 PM · Restricted Project, Restricted Project
Tyker updated the diff for D132009: [NFC][mlir] Add support for llvm style casting for mlir types.
Aug 17 2022, 8:23 PM · Restricted Project, Restricted Project
Tyker added a comment to D132010: [MLIR] Add mlir::TypedValue.
assert(v2.getType().getWidth() == 8); /// no need to do .cast<IntegerType>()

/// Assuming MyOp is defined to operate on TensorType exclusively
MyOp.getLHS().getType() // is a TensorType

Ah I like this! The API is indeed quite nice when getType does not need to be casted... So I'm supportive here if River is as well :)

:)

(You have a typo in multiple place you wrote IntergerType)

Aug 17 2022, 6:30 PM · Restricted Project, Restricted Project
Tyker added a comment to D132010: [MLIR] Add mlir::TypedValue.

How many places in-tree would benefit from this? It's hard to gauge what the value of this is from the patch as-is.

Aug 17 2022, 6:28 PM · Restricted Project, Restricted Project
Tyker updated the diff for D132010: [MLIR] Add mlir::TypedValue.
Aug 17 2022, 6:28 PM · Restricted Project, Restricted Project
Tyker updated the summary of D132010: [MLIR] Add mlir::TypedValue.
Aug 17 2022, 6:19 PM · Restricted Project, Restricted Project
Tyker updated the summary of D132010: [MLIR] Add mlir::TypedValue.
Aug 17 2022, 8:43 AM · Restricted Project, Restricted Project
Tyker updated the summary of D132010: [MLIR] Add mlir::TypedValue.
Aug 17 2022, 8:42 AM · Restricted Project, Restricted Project
Tyker added a comment to D132010: [MLIR] Add mlir::TypedValue.

Can you elaborate more on the motivation in the description?
Right now you're touching on it with:

I also think TypedValue can be a useful as to express directly what is expected and remove the need for to cast its Values.

But I'm not sure what you mean, if you could also add examples of what kind of API would take advantage of this?

Aug 17 2022, 8:42 AM · Restricted Project, Restricted Project
Tyker updated the summary of D132010: [MLIR] Add mlir::TypedValue.
Aug 17 2022, 8:41 AM · Restricted Project, Restricted Project
Tyker updated the summary of D132010: [MLIR] Add mlir::TypedValue.
Aug 17 2022, 8:41 AM · Restricted Project, Restricted Project

Aug 16 2022

Tyker updated the summary of D132010: [MLIR] Add mlir::TypedValue.
Aug 16 2022, 9:57 PM · Restricted Project, Restricted Project
Tyker requested review of D132010: [MLIR] Add mlir::TypedValue.
Aug 16 2022, 9:50 PM · Restricted Project, Restricted Project
Tyker requested review of D132009: [NFC][mlir] Add support for llvm style casting for mlir types.
Aug 16 2022, 9:42 PM · Restricted Project, Restricted Project

Mar 31 2022

Tyker abandoned D122863: [MLIR][cf] Add branch operand edition function to cf.cond_br.

I didn't realize this existed. thank you for the information.

Mar 31 2022, 9:49 PM · Restricted Project, Restricted Project
Tyker changed the visibility for D122863: [MLIR][cf] Add branch operand edition function to cf.cond_br.
Mar 31 2022, 9:09 PM · Restricted Project, Restricted Project
Tyker added reviewers for D122863: [MLIR][cf] Add branch operand edition function to cf.cond_br: rriddle, mehdi_amini.
Mar 31 2022, 9:08 PM · Restricted Project, Restricted Project
Tyker added a comment to D122863: [MLIR][cf] Add branch operand edition function to cf.cond_br.

is there interest in having this upstream ?
I am not sure how it should be tested upstream ?

Mar 31 2022, 9:07 PM · Restricted Project, Restricted Project
Tyker requested review of D122863: [MLIR][cf] Add branch operand edition function to cf.cond_br.
Mar 31 2022, 9:02 PM · Restricted Project, Restricted Project

Nov 23 2021

Tyker added a comment to D114439: [Annotation] Allow parameter pack expansions and initializer lists in annotate attribute.

This seems like a good change to me. but i don't think my approval is enough

Nov 23 2021, 9:34 AM · Restricted Project

Oct 27 2021

Tyker added inline comments to D74130: [clang] fix consteval call in default arguments.
Oct 27 2021, 10:04 AM · Restricted Project, Restricted Project
Tyker updated the diff for D74130: [clang] fix consteval call in default arguments.

FWIW, I am not seeing double errors on that code. Here's the output I get with this patch applied locally:

F:\source\llvm-project>cat "C:\Users\aballman\OneDrive - Intel Corporation\Desktop\test.cpp"
consteval int f1() { return 0; }
consteval auto g() { return f1; }

constexpr auto e = g();
constexpr auto e1 = f1;

F:\source\llvm-project>llvm\out\build\x64-Debug\bin\clang.exe -fsyntax-only -std=c++2b "C:\Users\aballman\OneDrive - Intel Corporation\Desktop\test.cpp"
C:\Users\aballman\OneDrive - Intel Corporation\Desktop\test.cpp:4:20: error: call to consteval function 'g' is not a
      constant expression
constexpr auto e = g();
                   ^
C:\Users\aballman\OneDrive - Intel Corporation\Desktop\test.cpp:4:20: note: pointer to a consteval declaration is not a
      constant expression
C:\Users\aballman\OneDrive - Intel Corporation\Desktop\test.cpp:1:15: note: declared here
consteval int f1() { return 0; }
              ^
C:\Users\aballman\OneDrive - Intel Corporation\Desktop\test.cpp:4:16: error: constexpr variable 'e' must be initialized
      by a constant expression
constexpr auto e = g();
               ^   ~~~
C:\Users\aballman\OneDrive - Intel Corporation\Desktop\test.cpp:4:16: note: pointer to a consteval declaration is not a
      constant expression
C:\Users\aballman\OneDrive - Intel Corporation\Desktop\test.cpp:1:15: note: declared here
consteval int f1() { return 0; }
              ^
C:\Users\aballman\OneDrive - Intel Corporation\Desktop\test.cpp:5:21: error: cannot take address of consteval function
      'f1' outside of an immediate invocation
constexpr auto e1 = f1;
                    ^
C:\Users\aballman\OneDrive - Intel Corporation\Desktop\test.cpp:1:15: note: declared here
consteval int f1() { return 0; }
              ^
C:\Users\aballman\OneDrive - Intel Corporation\Desktop\test.cpp:5:16: error: constexpr variable 'e1' must be initialized
      by a constant expression
constexpr auto e1 = f1;
               ^    ~~
C:\Users\aballman\OneDrive - Intel Corporation\Desktop\test.cpp:5:16: note: pointer to a consteval declaration is not a
      constant expression
C:\Users\aballman\OneDrive - Intel Corporation\Desktop\test.cpp:1:15: note: declared here
consteval int f1() { return 0; }
              ^
4 errors generated.

These look like valid errors to me, so am I misunderstanding something? Is the concern that we're emitting error: constexpr variable '<whatever>' must be initialized by a constant expression after we already issued a diagnostic on the same line?

Oct 27 2021, 10:01 AM · Restricted Project, Restricted Project

Oct 21 2021

Tyker updated the diff for D74130: [clang] fix consteval call in default arguments.

@Tyker -- are you planning to pick this review back up again sometime in the near future? If not, do you care if the review gets commandeered?

here is an update that i think is close to committable. if it is not i am fine if it gets commandeered.

Oct 21 2021, 4:13 PM · Restricted Project, Restricted Project

Apr 1 2021

Tyker accepted D98759: [AssumeBundles] offset should be added to correctly calculate align.

LGTM

Apr 1 2021, 9:37 AM · Restricted Project
Tyker added a comment to D98684: [LangRef] state that align assume op bundle may take an extra argument.

seems good to me. but maybe other still have comments.

Apr 1 2021, 7:21 AM · Restricted Project, Restricted Project

Mar 15 2021

Tyker accepted D98228: [AssumeBundles] Add nonnull/align to op bundle if noundef exists.

I think the process of checking is a value is noundef needs to be more general than just calls. maybe addKnowledge would be a better place.
because nonnull and align information can also be inferred from loads/stores.

Hi, sorry for my delay in response.
Could you elaborate a bit with an example, please?
Does it mean that the updated analysis may return suboptimal results?

Mar 15 2021, 10:18 AM · Restricted Project
Tyker added a comment to D90529: Allow nonnull/align attribute to accept poison.

A fix in AssumeBundleBuilder to make it comply LangRef: D98228

BTW, I found that "align" can take two operands: "align"(i8* ptr, i64 a, i64 b) What is the meaning of the second index (b)?

the meaning of the second index is the offset of the alignment. so with "align"(i8* ptr, i64 16, i64 12), ptr is aligned on 4 but ptr + 4 is aligned on 16.
I introduced this to support __builtin_assume_aligned which has similar semantics.

Hi, thanks for the info.

But I think an example in Transforms/AlignmentFromAssumptions/simple.ll conflicts with your definition. It has:

28 define i32 @foo2a(i32* nocapture %a) nounwind uwtable readonly {
29 entry:
30   tail call void @llvm.assume(i1 true) ["align"(i32* %a, i32 32, i32 28)]
31   %arrayidx = getelementptr inbounds i32, i32* %a, i64 -1
32   %0 = load i32, i32* %arrayidx, align 4
33   ret i32 %0
34 
35 ; CHECK-LABEL: @foo2a
36 ; CHECK: load i32, i32* {{[^,]+}}, align 32
37 ; CHECK: ret i32
38 }

"align"(i32* %a, i32 32, i32 28) means %a + 4 is 32-bytes aligned, IIUC. Then, %a - 4 cannot be 32-bytes aligned, is it?

Yes, this looks like a bug.

Mar 15 2021, 8:20 AM · Restricted Project

Mar 9 2021

Tyker added a comment to D98228: [AssumeBundles] Add nonnull/align to op bundle if noundef exists.

I think the process of checking is a value is noundef needs to be more general than just calls. maybe addKnowledge would be a better place.
because nonnull and align information can also be inferred from loads/stores.

Mar 9 2021, 1:43 AM · Restricted Project
Tyker added a comment to D90529: Allow nonnull/align attribute to accept poison.

A fix in AssumeBundleBuilder to make it comply LangRef: D98228

BTW, I found that "align" can take two operands: "align"(i8* ptr, i64 a, i64 b) What is the meaning of the second index (b)?

Mar 9 2021, 1:41 AM · Restricted Project

Mar 8 2021

Tyker added a comment to D96646: [NFC] update LangRef for D88645.

I'm not trying to be difficult, but I genuinely still don't understand the additional arguments pointer. Is it intended to allow proprietary extensions? Is there an example somewhere?

If these intrinsics are meant as a general mechanism to enable arbitrary communication between custom front ends and custom optimization passes, that's fine. I'd just like to see something explicitly explaining that.

Mar 8 2021, 9:39 AM · Restricted Project, Restricted Project
Tyker updated the summary of D96646: [NFC] update LangRef for D88645.
Mar 8 2021, 9:39 AM · Restricted Project, Restricted Project

Mar 1 2021

Tyker updated the diff for D96646: [NFC] update LangRef for D88645.

added more details about the storage of additional arguments.

Mar 1 2021, 5:52 AM · Restricted Project, Restricted Project

Feb 23 2021

Tyker updated the diff for D96646: [NFC] update LangRef for D88645.

fixed the sentence.

Feb 23 2021, 1:55 AM · Restricted Project, Restricted Project

Feb 15 2021

Tyker updated the diff for D96646: [NFC] update LangRef for D88645.

addressed comment

Feb 15 2021, 10:15 AM · Restricted Project, Restricted Project

Feb 13 2021

Tyker added inline comments to D95993: Add auto-upgrade support for annotation intrinsics.
Feb 13 2021, 4:33 AM · Restricted Project
Tyker added inline comments to D95993: Add auto-upgrade support for annotation intrinsics.
Feb 13 2021, 4:32 AM · Restricted Project
Tyker added a comment to D95993: Add auto-upgrade support for annotation intrinsics.

This seems good to me but i am not familiar the the auto-upgrader.

Feb 13 2021, 4:30 AM · Restricted Project
Tyker added a comment to D88645: [Annotation] Allows annotation to carry some additional constant arguments..

I added the changes to the langref in https://reviews.llvm.org/D96646

Feb 13 2021, 4:29 AM · Restricted Project, Restricted Project
Tyker requested review of D96646: [NFC] update LangRef for D88645.
Feb 13 2021, 4:28 AM · Restricted Project, Restricted Project
Tyker committed rG642e9225c6e8: reland [InstCombine] convert assumes to operand bundles (authored by Tyker).
reland [InstCombine] convert assumes to operand bundles
Feb 13 2021, 4:03 AM

Feb 9 2021

Tyker added a reverting change for rG5eb2e994f9b3: [InstCombine] convert assumes to operand bundles: rG5652e192fc22: Revert "[InstCombine] convert assumes to operand bundles".
Feb 9 2021, 4:34 PM
Tyker committed rG5652e192fc22: Revert "[InstCombine] convert assumes to operand bundles" (authored by Tyker).
Revert "[InstCombine] convert assumes to operand bundles"
Feb 9 2021, 4:34 PM
Tyker added a reverting change for D82703: [InstCombine] convert assumes to operand bundles: rG5652e192fc22: Revert "[InstCombine] convert assumes to operand bundles".
Feb 9 2021, 4:34 PM · Restricted Project
Tyker committed rG5eb2e994f9b3: [InstCombine] convert assumes to operand bundles (authored by Tyker).
[InstCombine] convert assumes to operand bundles
Feb 9 2021, 10:34 AM
Tyker closed D82703: [InstCombine] convert assumes to operand bundles.
Feb 9 2021, 10:34 AM · Restricted Project

Jan 30 2021

Tyker added inline comments to D82703: [InstCombine] convert assumes to operand bundles.
Jan 30 2021, 1:26 AM · Restricted Project
Tyker updated the diff for D82703: [InstCombine] convert assumes to operand bundles.

rebased, addressed comments. fixed issues.

Jan 30 2021, 1:26 AM · Restricted Project

Jan 16 2021

Tyker added inline comments to D82703: [InstCombine] convert assumes to operand bundles.
Jan 16 2021, 3:39 AM · Restricted Project
Tyker added inline comments to D82703: [InstCombine] convert assumes to operand bundles.
Jan 16 2021, 3:39 AM · Restricted Project
Tyker updated the diff for D82703: [InstCombine] convert assumes to operand bundles.

@Tyker are you going to upstream this? If not, can someone take over?

Jan 16 2021, 3:38 AM · Restricted Project

Nov 11 2020

Tyker added a comment to rGd093401a2617: [NFC] Remove string parameter of annotation attribute from AST childs..

Just an FYI, but this probably should have gotten a review as it's not NFC (it changes what information gets dumped in text and JSON form, impacts AST matching behavior, and other minor effects). That said, overall the direction seems fine to me, though I did question one of the changes.

Nov 11 2020, 7:54 AM
Tyker added a comment to D91239: Update attribute example to fit the new Annotation API.

I recently made it much easier to create AnnotationAttr in this context with https://reviews.llvm.org/rGd093401a2617d3c46aaed9eeaecf877e3ae1a9f1.

Nov 11 2020, 4:58 AM · Restricted Project

Nov 9 2020

Tyker committed rGd093401a2617: [NFC] Remove string parameter of annotation attribute from AST childs. (authored by Tyker).
[NFC] Remove string parameter of annotation attribute from AST childs.
Nov 9 2020, 7:40 AM

Oct 27 2020

Tyker added a comment to D88645: [Annotation] Allows annotation to carry some additional constant arguments..

Looks like this broke tests: http://45.33.8.238/linux/31159/step_12.txt

Please take a look, and revert for now if it takes a while to fix.

this is fixed by 4afa077899b

Oct 27 2020, 2:30 AM · Restricted Project, Restricted Project
Tyker committed rG2618247c61c2: Correct examples after d3205bbca3e0002d76282878986993e7e7994779 (authored by Tyker).
Correct examples after d3205bbca3e0002d76282878986993e7e7994779
Oct 27 2020, 1:50 AM

Oct 26 2020

Tyker committed rG4afa077899b1: Try to fix buildbots after d3205bbca3e0002d76282878986993e7e7994779 (authored by Tyker).
Try to fix buildbots after d3205bbca3e0002d76282878986993e7e7994779
Oct 26 2020, 3:50 AM