- User Since
- Mar 16 2019, 2:09 PM (166 w, 1 d)
Mar 31 2022
I didn't realize this existed. thank you for the information.
is there interest in having this upstream ?
I am not sure how it should be tested upstream ?
Nov 23 2021
This seems like a good change to me. but i don't think my approval is enough
Oct 27 2021
Oct 21 2021
here is an update that i think is close to committable. if it is not i am fine if it gets commandeered.
Apr 1 2021
seems good to me. but maybe other still have comments.
Mar 15 2021
Yes, this looks like a bug.
Mar 9 2021
I think the process of checking is a value is noundef needs to be more general than just calls. maybe addKnowledge would be a better place.
because nonnull and align information can also be inferred from loads/stores.
Mar 8 2021
Mar 1 2021
added more details about the storage of additional arguments.
Feb 23 2021
fixed the sentence.
Feb 15 2021
Feb 13 2021
This seems good to me but i am not familiar the the auto-upgrader.
I added the changes to the langref in https://reviews.llvm.org/D96646
Feb 9 2021
Jan 30 2021
rebased, addressed comments. fixed issues.
Jan 16 2021
Nov 11 2020
I recently made it much easier to create AnnotationAttr in this context with https://reviews.llvm.org/rGd093401a2617d3c46aaed9eeaecf877e3ae1a9f1.
Nov 9 2020
Oct 27 2020
this is fixed by 4afa077899b
Oct 26 2020
Oct 23 2020
Oct 22 2020
Oct 21 2020
Oct 20 2020
Oct 17 2020
Oct 15 2020
rebased and add more fixes
that's blocked on this landing. If you won't have time to address @martong's comments soon, do you mind if I take this over and land it?
try to apply martongs's suggestions.
Oct 12 2020
What about leaving call llvm.assume whenever the load !noundef is moved to somewhere else? I guess this is what LLVM is doing as well.
If --enable-knowledge-retention is set, we should certainly do that if we would otherwise strip the metadata (not only for noundef).
this is not implemented the assume building currently don't look at any metadata.
you probably want to add noundef to isUsefullToPreserve such that it gets preserved automatically when knowledge retention is turned on.
Oct 10 2020
Oct 9 2020
Oct 8 2020
This change makes a lot of sense, but i don't understand all the consequences either.
Oct 1 2020
Sep 26 2020
add cannonicalization of assume bundles
this was a mistake i intended to update D82703
Sep 12 2020
Aug 30 2020
Aug 28 2020
Aug 25 2020
Aug 22 2020
yeah linkage was already changed.
added a test
Aug 17 2020
Aug 14 2020
i agree with both points but all i was trying to do i salvage what can be salvaged.
thanks for this,