Page MenuHomePhabricator

Tyker
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 16 2019, 2:09 PM (83 w, 2 d)

Recent Activity

Sat, Oct 17

Tyker added inline comments to D74130: [clang] fix consteval call in default arguments.
Sat, Oct 17, 2:48 AM · Restricted Project
Tyker updated the diff for D74130: [clang] fix consteval call in default arguments.

addressed comments.

Sat, Oct 17, 2:48 AM · Restricted Project

Thu, Oct 15

Tyker updated the diff for D74130: [clang] fix consteval call in default arguments.

rebased and add more fixes

Thu, Oct 15, 3:53 AM · Restricted Project
Tyker committed rG53122ce2b39f: [NFC] Correct name of profile function to Profile in APValue (authored by Tyker).
[NFC] Correct name of profile function to Profile in APValue
Thu, Oct 15, 1:54 AM
Tyker closed D88643: [NFC] Correct name of profile function to Profile in APValue.
Thu, Oct 15, 1:54 AM · Restricted Project
Tyker added a comment to D63640: [clang] Improve Serialization/Imporing of APValues.

Reverse ping: I have a patch implementing class type non-type template parameters that's blocked on this landing. If you won't have time to address @martong's comments soon, do you mind if I take this over and land it?

It is okay for me to commit this patch in its current state. The changes I suggested could result in a cleaner code, but I can do those changes after we land this.

Thu, Oct 15, 12:28 AM · Restricted Project
Tyker updated the diff for D63640: [clang] Improve Serialization/Imporing of APValues.

try to apply martongs's suggestions.

Thu, Oct 15, 12:27 AM · Restricted Project

Mon, Oct 12

Tyker added a comment to D89050: Add support for !noundef metatdata on loads.

What about leaving call llvm.assume whenever the load !noundef is moved to somewhere else? I guess this is what LLVM is doing as well.

If --enable-knowledge-retention is set, we should certainly do that if we would otherwise strip the metadata (not only for noundef).

this is not implemented the assume building currently don't look at any metadata.

Mon, Oct 12, 1:41 PM · Restricted Project
Tyker added a comment to D89219: [ValueTracking] Use assume's noundef operand bundle.

you probably want to add noundef to isUsefullToPreserve such that it gets preserved automatically when knowledge retention is turned on.

Mon, Oct 12, 1:15 PM · Restricted Project

Sat, Oct 10

Tyker added inline comments to D88645: [Annotation] Allows annotation to carry some additional constant arguments..
Sat, Oct 10, 3:18 PM · Restricted Project, Restricted Project
Tyker updated the diff for D88645: [Annotation] Allows annotation to carry some additional constant arguments..

addressed comments.

Sat, Oct 10, 5:58 AM · Restricted Project, Restricted Project

Fri, Oct 9

Tyker added inline comments to D88645: [Annotation] Allows annotation to carry some additional constant arguments..
Fri, Oct 9, 6:25 AM · Restricted Project, Restricted Project
Tyker updated the diff for D88645: [Annotation] Allows annotation to carry some additional constant arguments..

addressed comments.

Fri, Oct 9, 2:05 AM · Restricted Project, Restricted Project

Thu, Oct 8

Tyker added a comment to D89054: [WIP][IR] Make `llvm.assume` `readnone`.

This change makes a lot of sense, but i don't understand all the consequences either.

Thu, Oct 8, 10:33 AM · Restricted Project

Thu, Oct 1

Tyker added inline comments to D63640: [clang] Improve Serialization/Imporing of APValues.
Thu, Oct 1, 10:56 AM · Restricted Project
Tyker updated the diff for D63640: [clang] Improve Serialization/Imporing of APValues.

addressed comments

Thu, Oct 1, 10:56 AM · Restricted Project
Tyker requested review of D88645: [Annotation] Allows annotation to carry some additional constant arguments..
Thu, Oct 1, 2:40 AM · Restricted Project, Restricted Project
Tyker requested review of D88643: [NFC] Correct name of profile function to Profile in APValue.
Thu, Oct 1, 2:35 AM · Restricted Project

Sat, Sep 26

Tyker updated the diff for D82703: [InstCombine] convert assumes to operand bundles.

rebased
add cannonicalization of assume bundles

Sat, Sep 26, 7:00 AM · Restricted Project
Tyker abandoned D88358: [InstCombine][Assumes] Cannonicalize assumes in instcombine.

this was a mistake i intended to update D82703

Sat, Sep 26, 6:59 AM · Restricted Project
Tyker requested review of D88358: [InstCombine][Assumes] Cannonicalize assumes in instcombine.
Sat, Sep 26, 6:52 AM · Restricted Project
Tyker committed rG8d5b289a4681: [LoopDelete][Assume] Allow deleting loops with assumes (authored by Tyker).
[LoopDelete][Assume] Allow deleting loops with assumes
Sat, Sep 26, 3:34 AM
Tyker added a comment to D86816: [LoopDelete][Assume] Allow deleting loops with assumes.

OK, I think we need to revisit assume but an otherwise empty loop with an assume doesn't seem to be particularly useful. We might want to hoist loop invariant assumes, but that can be revisited. I think this solves a problem and is reasonable until we have time and ideas.

Sat, Sep 26, 3:34 AM · Restricted Project
Tyker closed D86816: [LoopDelete][Assume] Allow deleting loops with assumes.
Sat, Sep 26, 3:34 AM · Restricted Project

Sep 12 2020

Tyker committed rG78de7297abe2: Reland [AssumeBundles] Use operand bundles to encode alignment assumptions (authored by Tyker).
Reland [AssumeBundles] Use operand bundles to encode alignment assumptions
Sep 12 2020, 6:37 AM
Tyker updated the diff for D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions.

rebased

Sep 12 2020, 5:35 AM · Restricted Project, Restricted Project
Tyker added a comment to rG8d09f20798ac: [AssumeBundles] Use operand bundles to encode alignment assumptions.
Sep 12 2020, 5:30 AM
Tyker added a comment to D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions.
Sep 12 2020, 5:13 AM · Restricted Project, Restricted Project

Aug 30 2020

Tyker committed rGdaedfb632d2a: [llvm-reduce] Function body reduction: don't forget to unset comdat (authored by Tyker).
[llvm-reduce] Function body reduction: don't forget to unset comdat
Aug 30 2020, 3:18 AM
Tyker closed D86404: [llvm-reduce] Function body reduction: don't forget to unset comdat.
Aug 30 2020, 3:18 AM · Restricted Project

Aug 28 2020

Tyker added a comment to D86816: [LoopDelete][Assume] Allow deleting loops with assumes.

I'd almost say mayHaveSideEffects could have a boolean parameter to ignore droppable uses. Either way, this is right now the best we can do, teach the things that query mayHaveSideEffects and friends about droppable uses. If we have them as flags to all of them that might be easier to do.

Aug 28 2020, 2:56 PM · Restricted Project
Tyker requested review of D86816: [LoopDelete][Assume] Allow deleting loops with assumes.
Aug 28 2020, 2:17 PM · Restricted Project
Tyker committed rG6d3657417e0c: [SROA] Improve handleling of assumes bundles by SROA (authored by Tyker).
[SROA] Improve handleling of assumes bundles by SROA
Aug 28 2020, 12:57 PM
Tyker closed D86570: [SROA] Improve handleling of assumes bundles by SROA.
Aug 28 2020, 12:56 PM · Restricted Project

Aug 25 2020

Tyker requested review of D86570: [SROA] Improve handleling of assumes bundles by SROA.
Aug 25 2020, 1:06 PM · Restricted Project

Aug 22 2020

Tyker updated the diff for D86404: [llvm-reduce] Function body reduction: don't forget to unset comdat.

yeah linkage was already changed.
added a test

Aug 22 2020, 12:57 PM · Restricted Project
Tyker added a comment to D86404: [llvm-reduce] Function body reduction: don't forget to unset comdat.

Needs two tests - i agree that comdat makes sense, but i'm not sure about linkage.

Aug 22 2020, 12:08 PM · Restricted Project
Tyker requested review of D86404: [llvm-reduce] Function body reduction: don't forget to unset comdat.
Aug 22 2020, 11:52 AM · Restricted Project
Tyker updated the diff for D82703: [InstCombine] convert assumes to operand bundles.

Addressed comments.

Aug 22 2020, 11:02 AM · Restricted Project
Tyker committed rG7fef40d83cbb: [llvm-reduce] make llvm-reduce save the best reduction it has when it crashes (authored by Tyker).
[llvm-reduce] make llvm-reduce save the best reduction it has when it crashes
Aug 22 2020, 10:17 AM
Tyker closed D85996: [llvm-reduce] make llvm-reduce save the best reduction it has when it crashes.
Aug 22 2020, 10:17 AM · Restricted Project

Aug 17 2020

Tyker added a comment to D85996: [llvm-reduce] make llvm-reduce save the best reduction it has when it crashes.

This seems fine to me, thanks.
If you have llvm-reduce crashers, do let me know, i'm interested.

Aug 17 2020, 1:18 PM · Restricted Project
Tyker committed rGa79e604462ea: [AssumeBundles] Fix Bug in Assume Queries (authored by Tyker).
[AssumeBundles] Fix Bug in Assume Queries
Aug 17 2020, 12:37 PM
Tyker closed D83507: [AssumeBundles] Fix Bug in Assume Queries.
Aug 17 2020, 12:37 PM · Restricted Project

Aug 14 2020

Tyker updated the diff for D85996: [llvm-reduce] make llvm-reduce save the best reduction it has when it crashes.
  1. I'm pretty sure it's not okay to allocate memory in crash handler.
  2. We can't know that the internal state is still consistent.

i agree with both points but all i was trying to do i salvage what can be salvaged.

Aug 14 2020, 3:14 PM · Restricted Project
Tyker updated the diff for D83507: [AssumeBundles] Fix Bug in Assume Queries.

Please rebase and update the affected test :)

Aug 14 2020, 2:19 PM · Restricted Project
Tyker requested review of D85996: [llvm-reduce] make llvm-reduce save the best reduction it has when it crashes.
Aug 14 2020, 2:08 PM · Restricted Project
Tyker updated the diff for D85144: [clang] Improve Dumping of APValues.

I agree with you that it's fine to use printPretty for leaves (and additionally it would be annoying to duplicate the LValue case); that's what I was planning to do anyway.

What I am not sure I agree with is the additional complexity to handle the (debugger-only and easy to avoid) case where no context is given.

Aug 14 2020, 1:19 PM · Restricted Project
Tyker added a comment to D85933: Don't track consteval references for dependent members.

thanks for this,

Aug 14 2020, 11:43 AM · Restricted Project

Aug 7 2020

Tyker updated the diff for D82703: [InstCombine] convert assumes to operand bundles.

addressed comments

Aug 7 2020, 12:46 PM · Restricted Project
Tyker updated the diff for D63640: [clang] Improve Serialization/Imporing of APValues.

rebased

Aug 7 2020, 12:19 PM · Restricted Project
Tyker updated the diff for D85144: [clang] Improve Dumping of APValues.

this a patch i had to improve dumping before your improvement to dumping.

Aug 7 2020, 12:18 PM · Restricted Project
Tyker requested review of D83507: [AssumeBundles] Fix Bug in Assume Queries.
Aug 7 2020, 10:26 AM · Restricted Project
Tyker committed rG7d0f69118e61: [NFC] Add utility to sum/merge stats files (authored by Tyker).
[NFC] Add utility to sum/merge stats files
Aug 7 2020, 10:05 AM
Tyker closed D83505: [NFC] Add utility to sum/merge stats files.
Aug 7 2020, 10:05 AM · Restricted Project

Aug 3 2020

Tyker updated the diff for D85144: [clang] Improve Dumping of APValues.

remove unintended code.

Aug 3 2020, 11:14 AM · Restricted Project
Tyker added inline comments to D63640: [clang] Improve Serialization/Imporing of APValues.
Aug 3 2020, 10:57 AM · Restricted Project
Tyker retitled D63640: [clang] Improve Serialization/Imporing of APValues from [clang] Improve Serialization/Imporing/Dumping of APValues to [clang] Improve Serialization/Imporing of APValues.
Aug 3 2020, 10:55 AM · Restricted Project
Tyker requested review of D85144: [clang] Improve Dumping of APValues.
Aug 3 2020, 10:54 AM · Restricted Project
Tyker updated the diff for D63640: [clang] Improve Serialization/Imporing of APValues.

Sorry for the delay

Aug 3 2020, 10:50 AM · Restricted Project

Jul 28 2020

Tyker added inline comments to D84804: [SROA][Mem2Reg] Use efficient droppable use API (after D83976).
Jul 28 2020, 3:25 PM · Restricted Project
Tyker added inline comments to D83976: [Mem2Reg] Teach promote to register about droppable instructions.
Jul 28 2020, 3:24 PM · Restricted Project

Jul 20 2020

Tyker accepted D83978: [SROA] Teach promote to register about droppable instructions.

just one nit

Jul 20 2020, 9:16 PM · Restricted Project
Tyker accepted D83976: [Mem2Reg] Teach promote to register about droppable instructions.

just one nit

Jul 20 2020, 9:16 PM · Restricted Project

Jul 16 2020

Tyker added inline comments to D83978: [SROA] Teach promote to register about droppable instructions.
Jul 16 2020, 12:25 PM · Restricted Project
Tyker added a comment to D83976: [Mem2Reg] Teach promote to register about droppable instructions.

thank you for working on this

Jul 16 2020, 12:17 PM · Restricted Project

Jul 14 2020

Tyker added a comment to D83507: [AssumeBundles] Fix Bug in Assume Queries.

Also, this either needs a rebase, or this isn't against master but the stack doesn't say so.

Jul 14 2020, 4:09 PM · Restricted Project
Tyker committed rG0257ba581ce1: Fix tests after 16f777f4217cfcdcf6ddce8eb1e3525a65563c43 (authored by Tyker).
Fix tests after 16f777f4217cfcdcf6ddce8eb1e3525a65563c43
Jul 14 2020, 1:56 PM
Tyker committed rG16f777f4217c: [NFC] Add debug and stat counters to assume queries and assume builder (authored by Tyker).
[NFC] Add debug and stat counters to assume queries and assume builder
Jul 14 2020, 12:49 PM
Tyker closed D83506: [NFC] Add debug and stat counters to assume queries and assume builder.
Jul 14 2020, 12:49 PM · Restricted Project

Jul 13 2020

Tyker committed rG8d09f20798ac: [AssumeBundles] Use operand bundles to encode alignment assumptions (authored by Tyker).
[AssumeBundles] Use operand bundles to encode alignment assumptions
Jul 13 2020, 4:06 PM
Tyker closed D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions.
Jul 13 2020, 4:06 PM · Restricted Project, Restricted Project

Jul 9 2020

Tyker added a comment to D83507: [AssumeBundles] Fix Bug in Assume Queries.

Test?

Jul 9 2020, 2:35 PM · Restricted Project
Herald added a project to D83507: [AssumeBundles] Fix Bug in Assume Queries: Restricted Project.
Jul 9 2020, 2:11 PM · Restricted Project
Tyker updated the diff for D83506: [NFC] Add debug and stat counters to assume queries and assume builder.

Fixed formating

Jul 9 2020, 2:00 PM · Restricted Project
Tyker added a comment to D83505: [NFC] Add utility to sum/merge stats files.

Is there really no such existing script? (i don't know of one, i've always hacked around with bash)

i tried to find one the first time i needed one and didn't find any. maybe there is one i didn't find.

Jul 9 2020, 1:47 PM · Restricted Project
Herald added a project to D83506: [NFC] Add debug and stat counters to assume queries and assume builder: Restricted Project.
Jul 9 2020, 1:40 PM · Restricted Project
Herald added a project to D83505: [NFC] Add utility to sum/merge stats files: Restricted Project.
Jul 9 2020, 1:32 PM · Restricted Project
Tyker updated the diff for D82703: [InstCombine] convert assumes to operand bundles.

I had to merge the previous patch with other i had laying around and add some more
to make the bundle mode be at least as good as the default. so this revision got
quite a bit bigger.

Jul 9 2020, 1:22 PM · Restricted Project

Jul 8 2020

Tyker updated the diff for D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions.

fixed

Jul 8 2020, 11:36 AM · Restricted Project, Restricted Project
Tyker updated the diff for D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions.

addressed commemt.

Jul 8 2020, 11:32 AM · Restricted Project, Restricted Project
Tyker added a comment to D77734: [AssumeBundles] Adapt RecursivelyDeleteTriviallyDeadInstructions and depending passes..

What is the status on this one? Are there other AssumeBundle patches pending or missing?

Jul 8 2020, 10:49 AM · Restricted Project

Jul 6 2020

Tyker added inline comments to D83177: [llvm-reduce] Reducing call operand bundles.
Jul 6 2020, 3:09 PM · Restricted Project
Tyker added inline comments to D83177: [llvm-reduce] Reducing call operand bundles.
Jul 6 2020, 2:50 PM · Restricted Project
Tyker added inline comments to D83177: [llvm-reduce] Reducing call operand bundles.
Jul 6 2020, 2:21 PM · Restricted Project
Tyker added inline comments to D83177: [llvm-reduce] Reducing call operand bundles.
Jul 6 2020, 2:09 PM · Restricted Project
Tyker added inline comments to D83177: [llvm-reduce] Reducing call operand bundles.
Jul 6 2020, 1:41 PM · Restricted Project
Tyker added a comment to D83177: [llvm-reduce] Reducing call operand bundles.

Thank you for reducing rG7ea46aee3670981827c04df89b2c3a1cbdc7561b
this seems quite useful.

Jul 6 2020, 1:01 PM · Restricted Project

Jul 5 2020

Tyker updated the diff for D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions.

fixed the issue with multiple align in a single assume.

Jul 5 2020, 8:30 AM · Restricted Project, Restricted Project

Jul 4 2020

Tyker added inline comments to D82703: [InstCombine] convert assumes to operand bundles.
Jul 4 2020, 8:03 AM · Restricted Project
Tyker updated the diff for D82703: [InstCombine] convert assumes to operand bundles.

addressed the comments
the previous patch had many stupid mistakes

Jul 4 2020, 8:03 AM · Restricted Project

Jun 27 2020

Tyker updated the diff for D82703: [InstCombine] convert assumes to operand bundles.

there is an NFC change to the test that was excluded from the diff to make it easier to read.

Jun 27 2020, 4:28 AM · Restricted Project
Tyker created D82703: [InstCombine] convert assumes to operand bundles.
Jun 27 2020, 4:23 AM · Restricted Project

Jun 25 2020

Tyker committed rGc95ffadb2474: [AssumeBundles] Use operand bundles to encode alignment assumptions (authored by Tyker).
[AssumeBundles] Use operand bundles to encode alignment assumptions
Jun 25 2020, 4:10 AM
Tyker closed D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions.
Jun 25 2020, 4:10 AM · Restricted Project, Restricted Project
Tyker committed rG8938a6c9ede2: [NFC] update test to make diff of the following commit clear (authored by Tyker).
[NFC] update test to make diff of the following commit clear
Jun 25 2020, 4:10 AM

Jun 24 2020

Tyker updated the diff for D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions.

addressed comments

Jun 24 2020, 4:17 AM · Restricted Project, Restricted Project

Jun 19 2020

Tyker updated the diff for D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions.

sorry for not doing much recently.

Jun 19 2020, 3:14 PM · Restricted Project, Restricted Project
Tyker committed rG67448a8ccc4d: try to fix build bot after b7338fb1a6a464472850211165391983d2c8fdf3 (authored by Tyker).
try to fix build bot after b7338fb1a6a464472850211165391983d2c8fdf3
Jun 19 2020, 3:13 AM
Tyker committed rGb7338fb1a6a4: [AssumeBundles] add cannonicalisation to the assume builder (authored by Tyker).
[AssumeBundles] add cannonicalisation to the assume builder
Jun 19 2020, 1:35 AM