- User Since
- Apr 23 2014, 2:13 AM (300 w, 5 d)
Wed, Jan 22
Maybe we should use the year of issue (2015 instead of 1.2.1) for the -sycl-std version? That would be more stable for the upcoming SYCL versions, and match somehow the C++ versioning.
Tue, Jan 21
Thu, Jan 16
Tue, Jan 14
Mon, Jan 13
Does it make sense to implement such diagnostics in clang Sema, considering that OpenCL does not allow recursion?
We implemented similar diagnostics for SYCL programming model and would be like to upstream it to clang later (https://github.com/intel/llvm/commit/4efe9fcf2dc6f6150b5b477b0f8320ea13a7f596). Can we somehow leverage this work for the compiler?
Sat, Dec 28
Dec 12 2019
Dec 11 2019
LGTM, but I'd like someone who works on OpenCL front-end to approve.
Added LIT test.
Dec 10 2019
I'm looking for test suggestions as I was not able to find tests covering similar changes for OpenMP compiler.
Dec 6 2019
@aaron.ballman, thank you for fixing the problem with documentation generation.
Dec 5 2019
is there a reason this should be clang::opencl_private as opposed to opencl::private?
I'm okay with [[opencl::private]] as well. I have only one problem - currently OpenCL address spaces are exposed as keywords and using them in C++ breaks valid C++ code.
I'm not certain who controls the OpenCL spec, but this seems like it should be a decision that comes from there. Or is this functionality outside of the OpenCL spec?
Dec 4 2019
Change attribute prefix: ocl_ -> opencl_.
Dec 3 2019
Dec 2 2019
Fixed SYCL code example for sycl_kernel attribute documentation and commit message.
Applied @aaron.ballman suggestions to kernel-attribute.cpp test
Nov 30 2019
Applied comments from @Fznamznon.
Nov 29 2019
Minor update adjusting to the recent changes.
Nov 28 2019
Fixed typo in the commit message: complier -> compiler.
Applied code review suggestions.
Nov 27 2019
Nov 20 2019
Applied code review comments from Aaron.
Applied code review comments.
Nov 19 2019
Nov 12 2019
Applied two remaining comments from Aaron.
Nov 7 2019
Applied comments from Aaron.
Thanks a lot for the comments and sorry for the long delay. We've been working on complete implementation of the SYCL 1.2.1 specification.
Now I have more time to work on contributing the implementation to LLVM project.