User Details
- User Since
- Apr 23 2014, 2:13 AM (491 w, 1 d)
Mon, Sep 11
Jul 31 2023
Jul 5 2023
Friendly ping^2.
Jun 27 2023
Ping.
Jun 15 2023
Jun 9 2023
Add an option (dislabed by default) to strip CU with references to non-existing const global expressions.
Mar 30 2023
Mar 29 2023
LGTM. Thanks!
Ping.
Mar 28 2023
@hvdijk, thanks a lot for fixing this.
Mar 3 2023
Feb 9 2023
Jan 26 2023
LGTM. Thanks!
Jan 25 2023
"[SPIR-V] Add support for arithmetic_fence builtin for SYCL targets." -> "[SPIR] Add support for arithmetic_fence builtin for SPIR target."
Jan 23 2023
@beanz, could you help with reviewing this change, please?
Jan 18 2023
Should we generalize and rename clang/test/CodeGenOpenCL/convergent.cl to validate function attributes other than convergent? It's not obvious that presence of nounwind attribute is validated by clang/test/CodeGenOpenCL/convergent.cl.
Jan 10 2023
I expect this to be a common issue for all single-source offloading programming models (i.e. CUDA and HIP in addition to SYCL and OpenMP offload). Probably we can generalize the code patterns used in this patch for all of them.
Jan 5 2023
I can understand the reason for changes in llvm/lib/ExecutionEngine/ExecutionEngine.cpp and tests, but the purpose of changes in llvm/lib/ExecutionEngine/Interpreter/ is not clear. Could you elaborate more on that, please?
Jan 4 2023
@jcranmer-intel, thanks a lot for working on this. I'm so excited to see these changes!
Overall, it looks good to me, but I'd like to avoid some runtime computations if possible.
Nov 18 2022
Thanks for the fix!
Nov 10 2022
Is binary size a concern here? NVIDIA, AMD and Intel GPUs are already have ~ 20 different architectures each, so I want my app/library to run on any GPU from these vendors (which is quite reasonable expectation), I'll need to have/distribute ~ 60 different binaries. libdevice, libm, libc are quite small, but other apps (e.g. ML frameworks) might be quite large, so that distributed binary size is important to consider.
Nov 6 2022
Nov 1 2022
Oct 19 2022
Oct 18 2022
Update commit message.
Oct 12 2022
@urnathan, sorry, we didn't notice that https://reviews.llvm.org/D130909 introduces divergence. @steffenlarsen, @jcranmer-intel, FYI.
Regarding dropping LLVM_ prefix from header guards, it looks like these were removed with some automatic tool (https://github.com/intel/llvm/commit/c13a09a462807936f9eb17cc64f53ad7c9e8ddec), so I would expect someone else will run the tool again and add them back. Any ideas how to prevent this type of changes in the future? Maybe we can keep LLVM_ prefix for sources in llvm/ directory and just ignore this difference. What do you think?
Sep 13 2022
Sep 11 2022
@aprantl, thank you a lot for reviewing this patch. Could you also take a look at the part moved to https://reviews.llvm.org/D131179, please?
Sep 5 2022
Ping.
Ping.
Sep 4 2022
Aug 7 2022
Aug 4 2022
Apply clang-format. No functional changes.
Applied code review suggestions.
Aug 1 2022
Jul 6 2022
Jun 16 2022
The way I understand a bitcast instruction in SPIR-V (OpBitcast in https://www.khronos.org/registry/SPIR-V/specs/unified1/SPIRV.html#_conversion_instructions) is that it can only apply to pointer types which are distinct from function types. Note that I believe that function pointers are illegal, at least we disallow them in OpenCL.
Jun 15 2022
Apr 4 2022
Feb 4 2022
LGTM. Thanks!
Jan 24 2022
LGTM, just one suggestion.
It would be great to get @aaron.ballman approve too.
Dec 20 2021
Dec 8 2021
Dec 7 2021
Dec 3 2021
Nov 25 2021
LGTM, with a couple of minor suggestions.
Nov 18 2021
@tra, ping.
@steffenlarsen, does it make sense to add support for recently released 11.5 as well?
Nov 17 2021
Oct 28 2021
This part looks good to me. Just a couple of minor style comments.
Oct 25 2021
Oct 20 2021
@vlastik, your commit fixes function pointers on AVR - https://github.com/llvm/llvm-project/commit/57fd86de879cf2b4c7001b6d0a09df60877ce24d. I suppose this change is required for fixing lvalue references to function pointers on AVR as well. Right?
Oct 14 2021
Oct 13 2021
Oct 11 2021
Oct 6 2021
Oct 5 2021
Sep 23 2021
LGTM, just one typo in addition to linter reports and I'd like John to take a look.
Sep 22 2021
Sep 21 2021
Sep 20 2021
Sep 13 2021
Aug 26 2021
Aug 25 2021
LGTM.