Page MenuHomePhabricator

bader (Alexey Bader)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 23 2014, 2:13 AM (427 w, 2 d)

Recent Activity

Thu, Jun 16

bader added a comment to D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata.

The way I understand a bitcast instruction in SPIR-V (OpBitcast in https://www.khronos.org/registry/SPIR-V/specs/unified1/SPIRV.html#_conversion_instructions) is that it can only apply to pointer types which are distinct from function types. Note that I believe that function pointers are illegal, at least we disallow them in OpenCL.

Thu, Jun 16, 5:43 AM · Restricted Project, Restricted Project

Wed, Jun 15

bader added a comment to D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata.

@nikic the most important thing you need to know about SPIR-V is that it is a virtual ISA based on LLVM IR. The ISA itself encodes types for pointers just like LLVM IR would.

Wed, Jun 15, 8:10 AM · Restricted Project, Restricted Project

Apr 4 2022

bader committed rG87b28f5092f2: [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member (authored by psamolysov-intel).
[clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member
Apr 4 2022, 5:17 AM · Restricted Project, Restricted Project
bader closed D122587: [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member.
Apr 4 2022, 5:16 AM · Restricted Project, Restricted Project

Feb 4 2022

bader accepted D118935: [SYCL] Disallow explicit casts between mismatching address spaces.

LGTM. Thanks!

Feb 4 2022, 12:32 AM · Restricted Project, Restricted Project

Jan 24 2022

bader accepted D114483: [SYCL] Add support for sycl_special_class attribute.

LGTM, just one suggestion.
It would be great to get @aaron.ballman approve too.

Jan 24 2022, 9:42 AM · Restricted Project
bader added inline comments to D116266: [SPIR-V] Add linking of separate translation units using spirv-link.
Jan 24 2022, 6:20 AM · Restricted Project

Dec 20 2021

bader added a comment to D115708: Disable issue labeler in LLVM forks.

LGTM. I'm not sure the best place to document this.

Dec 20 2021, 2:05 AM · Restricted Project

Dec 8 2021

bader committed rG9ae5810b53c2: [HIPSPV] Convert HIP kernels to SPIR-V kernels (authored by linjamaki).
[HIPSPV] Convert HIP kernels to SPIR-V kernels
Dec 8 2021, 4:18 AM
bader closed D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels.
Dec 8 2021, 4:18 AM · Restricted Project

Dec 7 2021

bader added a comment to D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP.

The patch looks OK for the time being. That said, I do have concerns that we may be organically growing something that will be troublesome to deal with long-term.

TBH, I still can't quite make sense of where/how SPIR-V fits in the offloading nomenclature.

Right now we have multiple levels of offloading-related control points.

  • offload targets, specified by --offload-arch. Determines the ISA of the GPU binary we produce.
  • offload mechanism: OpenMP, CUDA runtime, HSA. Determines how we compile/pack/launch the GPU binaries.
  • front-end: CUDA/HIP/ C/C++ w/ OpenMP.
  • Driver: Determines compilation pipeline to glue everything together,

SPIR-V in these patches appears to be wearing multiple hats.
It changes compilation pipeline, it changes offload mechanism and it changes offload targets.

Dec 7 2021, 3:31 AM · Restricted Project

Dec 3 2021

bader added a comment to D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels.

The patch is ready to land. @Anastasia, @bader, could you commit this patch to the LLVM for us? Thanks.

Dec 3 2021, 9:28 AM · Restricted Project

Nov 25 2021

bader added a comment to D114080: [SYCL] Diagnose uses of zero length arrays.

LGTM, with a couple of minor suggestions.

Nov 25 2021, 1:01 AM · Restricted Project

Nov 18 2021

bader added a comment to D107054: [Clang][CUDA] Add descriptors, mappings, and features for missing CUDA and PTX versions.

@tra, ping.
@steffenlarsen, does it make sense to add support for recently released 11.5 as well?

Nov 18 2021, 1:42 PM · Restricted Project, Restricted Project

Nov 17 2021

bader committed rG49682f14bf3f: [SPIR-V] Add translator tool (authored by linjamaki).
[SPIR-V] Add translator tool
Nov 17 2021, 7:41 PM
bader closed D112404: [SPIR-V] Add translator tool.
Nov 17 2021, 7:41 PM · Restricted Project

Oct 28 2021

bader added a reviewer for D112718: Add intrinsics and builtins for PTX atomics with semantic orders: tra.
Oct 28 2021, 7:30 AM · Restricted Project, Restricted Project, Restricted Project
bader accepted D112404: [SPIR-V] Add translator tool.

This part looks good to me. Just a couple of minor style comments.

Oct 28 2021, 5:07 AM · Restricted Project

Oct 25 2021

bader updated subscribers of D112410: [SPIR-V] Add a toolchain for SPIR-V in clang.
Oct 25 2021, 2:50 AM · Restricted Project

Oct 20 2021

bader accepted D111566: [SYCL] Fix function pointer address space.

@vlastik, your commit fixes function pointers on AVR - https://github.com/llvm/llvm-project/commit/57fd86de879cf2b4c7001b6d0a09df60877ce24d. I suppose this change is required for fixing lvalue references to function pointers on AVR as well. Right?

Oct 20 2021, 8:57 AM · Restricted Project

Oct 14 2021

bader added a comment to D71016: [SYCL] Implement OpenCL kernel function generation.

Would a codegenSYCL directory help you to separate Sema from code generation?

Oct 14 2021, 5:31 AM · Restricted Project
bader added a comment to D71016: [SYCL] Implement OpenCL kernel function generation.

It feels like you are doing codegen(OpenCL kernel) in Sema. Are OpenCL kernels the only approach.

Oct 14 2021, 4:55 AM · Restricted Project

Oct 13 2021

bader added inline comments to D71016: [SYCL] Implement OpenCL kernel function generation.
Oct 13 2021, 7:22 AM · Restricted Project
bader added reviewers for D71016: [SYCL] Implement OpenCL kernel function generation: erichkeane, aaron.ballman.
Oct 13 2021, 3:23 AM · Restricted Project

Oct 11 2021

bader updated subscribers of D110618: [HIPSPV][2/4] Add HIPSPV tool chain.
Oct 11 2021, 1:08 AM · Restricted Project

Oct 6 2021

bader added a comment to D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info.
  1. Implementing SPIR-V target as SPIR target. @bader do you suggest that we add spirv triple to clang and map it into SPIR taget or do you suggest something different?
Oct 6 2021, 10:17 AM · Restricted Project, Restricted Project

Oct 5 2021

bader added inline comments to D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping.
Oct 5 2021, 4:54 AM · Restricted Project, Restricted Project
bader added a comment to D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info.

It would be good to get closure on this asap.

@bader We had related discussions on the other reviews about the approach in this patch. If you have any concerns/suggestions can you please notify asap...

Oct 5 2021, 2:43 AM · Restricted Project, Restricted Project
bader added inline comments to D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping.
Oct 5 2021, 2:41 AM · Restricted Project, Restricted Project

Sep 23 2021

bader added a comment to D110281: Change __builtin_sycl_unique_stable_name to just use an Itanium mangling.

LGTM, just one typo in addition to linter reports and I'd like John to take a look.

Sep 23 2021, 5:08 AM · Restricted Project

Sep 22 2021

bader added inline comments to D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels.
Sep 22 2021, 4:08 AM · Restricted Project

Sep 21 2021

bader added inline comments to D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping.
Sep 21 2021, 8:19 AM · Restricted Project, Restricted Project

Sep 20 2021

bader committed rG15feaaa359c7: Add myself as a code owner for SYCL support (authored by bader).
Add myself as a code owner for SYCL support
Sep 20 2021, 2:33 AM

Sep 13 2021

bader added inline comments to D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping.
Sep 13 2021, 2:14 AM · Restricted Project, Restricted Project

Aug 26 2021

bader added inline comments to D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping.
Aug 26 2021, 7:56 AM · Restricted Project, Restricted Project

Aug 25 2021

bader accepted D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping.

LGTM.

Aug 25 2021, 2:37 AM · Restricted Project, Restricted Project

Aug 13 2021

bader requested review of D108034: [SPIR-V] Add SPIR-V builtin functions and types.
Aug 13 2021, 6:57 AM · Restricted Project
bader committed rGd754b970eddb: [NFC] Drop idle compiler option from the test. (authored by bader).
[NFC] Drop idle compiler option from the test.
Aug 13 2021, 6:21 AM
bader closed D108020: [NFC] Drop idle compiler option from the test..
Aug 13 2021, 6:21 AM · Restricted Project
bader requested review of D108020: [NFC] Drop idle compiler option from the test..
Aug 13 2021, 2:04 AM · Restricted Project
bader committed rGc064ba34c7d8: [NFC] Add commas in code comments. (authored by bader).
[NFC] Add commas in code comments.
Aug 13 2021, 2:01 AM

Jul 28 2021

bader added a reviewer for D104848: [cmake] Handled utils/unittests before projects: beanz.
Jul 28 2021, 3:17 AM · Restricted Project
bader accepted D104848: [cmake] Handled utils/unittests before projects.

LGTM, although it would be good if some else take a look as well.

Jul 28 2021, 3:08 AM · Restricted Project

May 26 2021

bader removed a reviewer for D41699: [OpenCL] Change sampler representation: bader.
May 26 2021, 1:52 AM

May 18 2021

bader closed D28080: [Docs][OpenCL] Added OpenCL feature description to user manual..

Closed by https://reviews.llvm.org/rG18e165f50d8c1ab3afe7098dc00557d5f1a43cfa.

May 18 2021, 6:21 AM
bader removed a reviewer for D51544: [OpenCL] Split opencl-c.h header: bader.
May 18 2021, 6:13 AM
bader closed D98204: [NFC] Fix "unused parameter" error revealed in the Linux self-build..

By commit https://reviews.llvm.org/rGc2006f857d80f54b90ed7d911d3e7acf4f46001b.

May 18 2021, 6:10 AM · Restricted Project
bader accepted D102261: Introduce SYCL 2020 mode.

Sorry for the delay.
LGTM. Thanks!

May 18 2021, 6:04 AM · Restricted Project
bader committed rG2ab513cd3e06: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL (authored by bader).
[SYCL] Enable `opencl_global_[host,device]` attributes for SYCL
May 18 2021, 3:28 AM
bader closed D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL.
May 18 2021, 3:28 AM · Restricted Project

May 17 2021

bader updated the diff for D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL.

Added documentation to cover conversion rules and rebased on ToT.

May 17 2021, 3:08 AM · Restricted Project

May 14 2021

bader committed rG444f02d73c6d: New tag for ittapi - fix an error related to cross-compiling ITTAPI in LLVM… (authored by bader).
New tag for ittapi - fix an error related to cross-compiling ITTAPI in LLVM…
May 14 2021, 1:20 AM
bader closed D102471: New tag for ittapi - fix an error related to cross-compiling ITTAPI in LLVM with mingw.
May 14 2021, 1:19 AM · Restricted Project
bader accepted D102471: New tag for ittapi - fix an error related to cross-compiling ITTAPI in LLVM with mingw.
May 14 2021, 12:55 AM · Restricted Project

May 11 2021

bader updated the diff for D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL.

Added explicit cast checks to Sema tests.

May 11 2021, 7:38 AM · Restricted Project
bader added inline comments to D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL.
May 11 2021, 7:31 AM · Restricted Project
bader updated the diff for D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL.

Apply code review suggestions and rebase on ToT.

May 11 2021, 7:26 AM · Restricted Project

Apr 30 2021

bader committed rG76f84e772978: [Doc] Fix sphinx warnings about wrong code-block format (authored by bader).
[Doc] Fix sphinx warnings about wrong code-block format
Apr 30 2021, 4:41 AM
bader closed D101549: [Doc] Fix sphynx warnings about wrong code-block format.
Apr 30 2021, 4:41 AM · Restricted Project
bader abandoned D80932: [SYCL] Make default address space a superset of OpenCL address spaces..

Committed alternative version - https://reviews.llvm.org/D89909.

Apr 30 2021, 2:35 AM · Restricted Project

Apr 29 2021

bader added a comment to D99488: [SYCL][Doc] Add design document for SYCL mode.

Thanks! I've uploaded this version to https://reviews.llvm.org/D101549.

Apr 29 2021, 10:16 AM · Restricted Project
bader requested review of D101549: [Doc] Fix sphynx warnings about wrong code-block format.
Apr 29 2021, 10:13 AM · Restricted Project
bader added a comment to D99488: [SYCL][Doc] Add design document for SYCL mode.

If I build docs now I get the following output:

llvm-project/build-doc/tools/clang/docs/SYCLSupport.rst:102: WARNING: Error in "code-block" directive:
1 argument(s) required, 0 supplied.

.. code-block::

   TODO: add support for `__attribute__((opencl_global_host))` and
   `__attribute__((opencl_global_device))`.

Is this something already being looked at?

Apr 29 2021, 6:25 AM · Restricted Project

Apr 26 2021

bader committed rGb2bb13a76164: [Doc] Add SYCLSupport.rst to index toctree. (authored by bader).
[Doc] Add SYCLSupport.rst to index toctree.
Apr 26 2021, 9:17 AM
bader updated the diff for D99190: [SYCL] Add design document for SYCL mode.

Rebased on ToT to resolve merge conflicts.

Apr 26 2021, 8:47 AM · Restricted Project
bader committed rGb52e69c42681: [SYCL][Doc] Add design document for SYCL mode (authored by bader).
[SYCL][Doc] Add design document for SYCL mode
Apr 26 2021, 8:41 AM
bader closed D99488: [SYCL][Doc] Add design document for SYCL mode.
Apr 26 2021, 8:40 AM · Restricted Project
bader added reviewers for D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL: Anastasia, aaron.ballman.
Apr 26 2021, 7:59 AM · Restricted Project
bader updated the diff for D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL.

Rebase on ToT

Apr 26 2021, 7:58 AM · Restricted Project
bader retitled D99488: [SYCL][Doc] Add design document for SYCL mode from [SYCL][Doc] Add address space handling section to SYCL documentation to [SYCL][Doc] Add design document for SYCL mode.
Apr 26 2021, 7:49 AM · Restricted Project
bader updated the diff for D99488: [SYCL][Doc] Add design document for SYCL mode.

Rebased patch to unblock commit.

Apr 26 2021, 7:45 AM · Restricted Project
bader committed rG7818906ca134: [SYCL] Implement SYCL address space attributes handling (authored by bader).
[SYCL] Implement SYCL address space attributes handling
Apr 26 2021, 6:45 AM
bader closed D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 26 2021, 6:44 AM · Restricted Project, Restricted Project

Apr 23 2021

bader added a comment to D89909: [SYCL] Implement SYCL address space attributes handling.

@Anastasia, I've updated https://reviews.llvm.org/D99488 and refactored getStringLiteralAddressSpace to handle non-string constants as well. Please, take a look.

Apr 23 2021, 7:02 AM · Restricted Project, Restricted Project
bader updated the diff for D99488: [SYCL][Doc] Add design document for SYCL mode.

Incorporate https://reviews.llvm.org/D89909 review feedback.

Apr 23 2021, 6:59 AM · Restricted Project
bader updated the diff for D89909: [SYCL] Implement SYCL address space attributes handling.

Generalize getStringLiteralAddressSpace to GetGlobalConstantAddressSpace

Apr 23 2021, 3:56 AM · Restricted Project, Restricted Project

Apr 22 2021

bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 22 2021, 10:34 AM · Restricted Project, Restricted Project
bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 22 2021, 2:18 AM · Restricted Project, Restricted Project
bader updated the diff for D89909: [SYCL] Implement SYCL address space attributes handling.

Added SYCL address spaces mangling for targets without address space map

Apr 22 2021, 1:42 AM · Restricted Project, Restricted Project

Apr 21 2021

bader updated the diff for D89909: [SYCL] Implement SYCL address space attributes handling.

Applied more review comments.

Apr 21 2021, 11:29 PM · Restricted Project, Restricted Project

Apr 20 2021

bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 20 2021, 8:37 AM · Restricted Project, Restricted Project

Apr 19 2021

bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 19 2021, 4:06 AM · Restricted Project, Restricted Project
bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 19 2021, 12:34 AM · Restricted Project, Restricted Project

Apr 14 2021

bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 14 2021, 6:59 AM · Restricted Project, Restricted Project
bader updated the diff for D89909: [SYCL] Implement SYCL address space attributes handling.

Applied more comments.

Apr 14 2021, 6:59 AM · Restricted Project, Restricted Project

Apr 13 2021

bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 13 2021, 10:16 AM · Restricted Project, Restricted Project
bader requested review of D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL.
Apr 13 2021, 10:14 AM · Restricted Project
bader updated the summary of D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 13 2021, 9:04 AM · Restricted Project, Restricted Project
bader updated the summary of D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 13 2021, 9:04 AM · Restricted Project, Restricted Project
bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 13 2021, 9:03 AM · Restricted Project, Restricted Project
bader updated the diff for D89909: [SYCL] Implement SYCL address space attributes handling.

Applied more code review suggestions.

Apr 13 2021, 9:02 AM · Restricted Project, Restricted Project
bader committed rG95c614afcd4d: [NFC][SYCL] Drop idle triple component from regression tests. (authored by bader).
[NFC][SYCL] Drop idle triple component from regression tests.
Apr 13 2021, 1:01 AM

Apr 12 2021

bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 12 2021, 10:57 AM · Restricted Project, Restricted Project

Apr 9 2021

bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 9 2021, 12:24 PM · Restricted Project, Restricted Project
bader updated the diff for D89909: [SYCL] Implement SYCL address space attributes handling.

Applied code review suggestions.

Apr 9 2021, 12:24 PM · Restricted Project, Restricted Project

Apr 7 2021

bader added a comment to D99488: [SYCL][Doc] Add design document for SYCL mode.

LGTM! Thanks for working on this. The expected sematic seems fairly clear now.

Apr 7 2021, 6:31 AM · Restricted Project

Apr 6 2021

bader updated the diff for D99488: [SYCL][Doc] Add design document for SYCL mode.

Add ReST marks to hyperlinks.

Apr 6 2021, 11:03 AM · Restricted Project

Apr 2 2021

bader added inline comments to D99488: [SYCL][Doc] Add design document for SYCL mode.
Apr 2 2021, 2:28 AM · Restricted Project
bader updated the diff for D99488: [SYCL][Doc] Add design document for SYCL mode.

Address comments from @Anastasia.

Apr 2 2021, 2:22 AM · Restricted Project

Apr 1 2021

bader added inline comments to D99190: [SYCL] Add design document for SYCL mode.
Apr 1 2021, 11:30 PM · Restricted Project