Page MenuHomePhabricator

bader (Alexey Bader)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 23 2014, 2:13 AM (373 w, 5 d)

Recent Activity

Wed, May 26

bader removed a reviewer for D41699: [OpenCL] Change sampler representation: bader.
Wed, May 26, 1:52 AM

May 18 2021

bader closed D28080: [Docs][OpenCL] Added OpenCL feature description to user manual..

Closed by https://reviews.llvm.org/rG18e165f50d8c1ab3afe7098dc00557d5f1a43cfa.

May 18 2021, 6:21 AM
bader removed a reviewer for D51544: [OpenCL] Split opencl-c.h header: bader.
May 18 2021, 6:13 AM
bader closed D98204: [NFC] Fix "unused parameter" error revealed in the Linux self-build..

By commit https://reviews.llvm.org/rGc2006f857d80f54b90ed7d911d3e7acf4f46001b.

May 18 2021, 6:10 AM · Restricted Project
bader accepted D102261: Introduce SYCL 2020 mode.

Sorry for the delay.
LGTM. Thanks!

May 18 2021, 6:04 AM · Restricted Project
bader committed rG2ab513cd3e06: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL (authored by bader).
[SYCL] Enable `opencl_global_[host,device]` attributes for SYCL
May 18 2021, 3:28 AM
bader closed D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL.
May 18 2021, 3:28 AM · Restricted Project

May 17 2021

bader updated the diff for D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL.

Added documentation to cover conversion rules and rebased on ToT.

May 17 2021, 3:08 AM · Restricted Project

May 14 2021

bader committed rG444f02d73c6d: New tag for ittapi - fix an error related to cross-compiling ITTAPI in LLVM… (authored by bader).
New tag for ittapi - fix an error related to cross-compiling ITTAPI in LLVM…
May 14 2021, 1:20 AM
bader closed D102471: New tag for ittapi - fix an error related to cross-compiling ITTAPI in LLVM with mingw.
May 14 2021, 1:19 AM · Restricted Project
bader accepted D102471: New tag for ittapi - fix an error related to cross-compiling ITTAPI in LLVM with mingw.
May 14 2021, 12:55 AM · Restricted Project

May 11 2021

bader updated the diff for D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL.

Added explicit cast checks to Sema tests.

May 11 2021, 7:38 AM · Restricted Project
bader added inline comments to D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL.
May 11 2021, 7:31 AM · Restricted Project
bader updated the diff for D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL.

Apply code review suggestions and rebase on ToT.

May 11 2021, 7:26 AM · Restricted Project

Apr 30 2021

bader committed rG76f84e772978: [Doc] Fix sphinx warnings about wrong code-block format (authored by bader).
[Doc] Fix sphinx warnings about wrong code-block format
Apr 30 2021, 4:41 AM
bader closed D101549: [Doc] Fix sphynx warnings about wrong code-block format.
Apr 30 2021, 4:41 AM · Restricted Project
bader abandoned D80932: [SYCL] Make default address space a superset of OpenCL address spaces..

Committed alternative version - https://reviews.llvm.org/D89909.

Apr 30 2021, 2:35 AM · Restricted Project

Apr 29 2021

bader added a comment to D99488: [SYCL][Doc] Add design document for SYCL mode.

Thanks! I've uploaded this version to https://reviews.llvm.org/D101549.

Apr 29 2021, 10:16 AM · Restricted Project
bader requested review of D101549: [Doc] Fix sphynx warnings about wrong code-block format.
Apr 29 2021, 10:13 AM · Restricted Project
bader added a comment to D99488: [SYCL][Doc] Add design document for SYCL mode.

If I build docs now I get the following output:

llvm-project/build-doc/tools/clang/docs/SYCLSupport.rst:102: WARNING: Error in "code-block" directive:
1 argument(s) required, 0 supplied.

.. code-block::

   TODO: add support for `__attribute__((opencl_global_host))` and
   `__attribute__((opencl_global_device))`.

Is this something already being looked at?

Apr 29 2021, 6:25 AM · Restricted Project

Apr 26 2021

bader committed rGb2bb13a76164: [Doc] Add SYCLSupport.rst to index toctree. (authored by bader).
[Doc] Add SYCLSupport.rst to index toctree.
Apr 26 2021, 9:17 AM
bader updated the diff for D99190: [SYCL] Add design document for SYCL mode.

Rebased on ToT to resolve merge conflicts.

Apr 26 2021, 8:47 AM · Restricted Project
bader committed rGb52e69c42681: [SYCL][Doc] Add design document for SYCL mode (authored by bader).
[SYCL][Doc] Add design document for SYCL mode
Apr 26 2021, 8:41 AM
bader closed D99488: [SYCL][Doc] Add design document for SYCL mode.
Apr 26 2021, 8:40 AM · Restricted Project
bader added reviewers for D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL: Anastasia, aaron.ballman.
Apr 26 2021, 7:59 AM · Restricted Project
bader updated the diff for D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL.

Rebase on ToT

Apr 26 2021, 7:58 AM · Restricted Project
bader retitled D99488: [SYCL][Doc] Add design document for SYCL mode from [SYCL][Doc] Add address space handling section to SYCL documentation to [SYCL][Doc] Add design document for SYCL mode.
Apr 26 2021, 7:49 AM · Restricted Project
bader updated the diff for D99488: [SYCL][Doc] Add design document for SYCL mode.

Rebased patch to unblock commit.

Apr 26 2021, 7:45 AM · Restricted Project
bader committed rG7818906ca134: [SYCL] Implement SYCL address space attributes handling (authored by bader).
[SYCL] Implement SYCL address space attributes handling
Apr 26 2021, 6:45 AM
bader closed D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 26 2021, 6:44 AM · Restricted Project, Restricted Project

Apr 23 2021

bader added a comment to D89909: [SYCL] Implement SYCL address space attributes handling.

@Anastasia, I've updated https://reviews.llvm.org/D99488 and refactored getStringLiteralAddressSpace to handle non-string constants as well. Please, take a look.

Apr 23 2021, 7:02 AM · Restricted Project, Restricted Project
bader updated the diff for D99488: [SYCL][Doc] Add design document for SYCL mode.

Incorporate https://reviews.llvm.org/D89909 review feedback.

Apr 23 2021, 6:59 AM · Restricted Project
bader updated the diff for D89909: [SYCL] Implement SYCL address space attributes handling.

Generalize getStringLiteralAddressSpace to GetGlobalConstantAddressSpace

Apr 23 2021, 3:56 AM · Restricted Project, Restricted Project

Apr 22 2021

bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 22 2021, 10:34 AM · Restricted Project, Restricted Project
bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 22 2021, 2:18 AM · Restricted Project, Restricted Project
bader updated the diff for D89909: [SYCL] Implement SYCL address space attributes handling.

Added SYCL address spaces mangling for targets without address space map

Apr 22 2021, 1:42 AM · Restricted Project, Restricted Project

Apr 21 2021

bader updated the diff for D89909: [SYCL] Implement SYCL address space attributes handling.

Applied more review comments.

Apr 21 2021, 11:29 PM · Restricted Project, Restricted Project

Apr 20 2021

bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 20 2021, 8:37 AM · Restricted Project, Restricted Project

Apr 19 2021

bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 19 2021, 4:06 AM · Restricted Project, Restricted Project
bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 19 2021, 12:34 AM · Restricted Project, Restricted Project

Apr 14 2021

bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 14 2021, 6:59 AM · Restricted Project, Restricted Project
bader updated the diff for D89909: [SYCL] Implement SYCL address space attributes handling.

Applied more comments.

Apr 14 2021, 6:59 AM · Restricted Project, Restricted Project

Apr 13 2021

bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 13 2021, 10:16 AM · Restricted Project, Restricted Project
bader requested review of D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL.
Apr 13 2021, 10:14 AM · Restricted Project
bader updated the summary of D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 13 2021, 9:04 AM · Restricted Project, Restricted Project
bader updated the summary of D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 13 2021, 9:04 AM · Restricted Project, Restricted Project
bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 13 2021, 9:03 AM · Restricted Project, Restricted Project
bader updated the diff for D89909: [SYCL] Implement SYCL address space attributes handling.

Applied more code review suggestions.

Apr 13 2021, 9:02 AM · Restricted Project, Restricted Project
bader committed rG95c614afcd4d: [NFC][SYCL] Drop idle triple component from regression tests. (authored by bader).
[NFC][SYCL] Drop idle triple component from regression tests.
Apr 13 2021, 1:01 AM

Apr 12 2021

bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 12 2021, 10:57 AM · Restricted Project, Restricted Project

Apr 9 2021

bader added inline comments to D89909: [SYCL] Implement SYCL address space attributes handling.
Apr 9 2021, 12:24 PM · Restricted Project, Restricted Project
bader updated the diff for D89909: [SYCL] Implement SYCL address space attributes handling.

Applied code review suggestions.

Apr 9 2021, 12:24 PM · Restricted Project, Restricted Project

Apr 7 2021

bader added a comment to D99488: [SYCL][Doc] Add design document for SYCL mode.

LGTM! Thanks for working on this. The expected sematic seems fairly clear now.

Apr 7 2021, 6:31 AM · Restricted Project

Apr 6 2021

bader updated the diff for D99488: [SYCL][Doc] Add design document for SYCL mode.

Add ReST marks to hyperlinks.

Apr 6 2021, 11:03 AM · Restricted Project

Apr 2 2021

bader added inline comments to D99488: [SYCL][Doc] Add design document for SYCL mode.
Apr 2 2021, 2:28 AM · Restricted Project
bader updated the diff for D99488: [SYCL][Doc] Add design document for SYCL mode.

Address comments from @Anastasia.

Apr 2 2021, 2:22 AM · Restricted Project

Apr 1 2021

bader added inline comments to D99190: [SYCL] Add design document for SYCL mode.
Apr 1 2021, 11:30 PM · Restricted Project
bader added inline comments to D99190: [SYCL] Add design document for SYCL mode.
Apr 1 2021, 8:48 AM · Restricted Project
bader updated the diff for D99190: [SYCL] Add design document for SYCL mode.

Fixed a typo in the code example.

Apr 1 2021, 8:48 AM · Restricted Project
bader updated the diff for D99190: [SYCL] Add design document for SYCL mode.

Added simplified accessor declaration to the example and TODO section.

Apr 1 2021, 8:46 AM · Restricted Project
bader updated the diff for D99488: [SYCL][Doc] Add design document for SYCL mode.

Applied code review suggestions from @Naghasan.

Apr 1 2021, 7:42 AM · Restricted Project
bader retitled D99190: [SYCL] Add design document for SYCL mode from WIP: [SYCL] Add design document for SYCL mode to [SYCL] Add design document for SYCL mode.
Apr 1 2021, 7:16 AM · Restricted Project
bader added inline comments to D99190: [SYCL] Add design document for SYCL mode.
Apr 1 2021, 7:14 AM · Restricted Project
bader updated the diff for D99190: [SYCL] Add design document for SYCL mode.

Applied code review suggestions from @Naghasan.

Apr 1 2021, 7:14 AM · Restricted Project

Mar 31 2021

bader updated the diff for D99488: [SYCL][Doc] Add design document for SYCL mode.

Convert document to ReST format.

Mar 31 2021, 7:10 AM · Restricted Project
bader updated the diff for D99190: [SYCL] Add design document for SYCL mode.

Convert document from Markdown to ReST format.

Mar 31 2021, 6:43 AM · Restricted Project
bader added inline comments to D99488: [SYCL][Doc] Add design document for SYCL mode.
Mar 31 2021, 5:56 AM · Restricted Project
bader updated the diff for D99488: [SYCL][Doc] Add design document for SYCL mode.

Applied code review suggestions

Mar 31 2021, 5:56 AM · Restricted Project

Mar 30 2021

bader updated subscribers of D99190: [SYCL] Add design document for SYCL mode.
Mar 30 2021, 10:59 AM · Restricted Project
bader updated the diff for D99190: [SYCL] Add design document for SYCL mode.

Apply code review comments from @Naghasan.

Mar 30 2021, 10:58 AM · Restricted Project

Mar 29 2021

bader added a comment to D99190: [SYCL] Add design document for SYCL mode.

@Anastasia, I've addressed the comments for the address space section in https://reviews.llvm.org/D99488. Let's move discussion there.

Mar 29 2021, 6:51 AM · Restricted Project
bader updated the diff for D99488: [SYCL][Doc] Add design document for SYCL mode.

Applied code review comments.

Mar 29 2021, 6:50 AM · Restricted Project
bader added a comment to D99488: [SYCL][Doc] Add design document for SYCL mode.

Thanks. I am guessing you will address relevant review comments from D99190 in here?

Mar 29 2021, 3:38 AM · Restricted Project
bader updated the diff for D99190: [SYCL] Add design document for SYCL mode.

Move address space handling section to https://reviews.llvm.org/D99488 to address https://reviews.llvm.org/D89909#2653452.

Mar 29 2021, 12:44 AM · Restricted Project
bader requested review of D99488: [SYCL][Doc] Add design document for SYCL mode.
Mar 29 2021, 12:39 AM · Restricted Project

Mar 26 2021

bader added a comment to D89909: [SYCL] Implement SYCL address space attributes handling.

Yesterday, we chatted offline and agreed that the main issue is missing documentation for Clang extensions being added for SYCL. To address this issue we are adding SYCL architecture design document, which we are going to update along with adding new features.

Mar 26 2021, 11:24 AM · Restricted Project, Restricted Project
bader updated the diff for D99190: [SYCL] Add design document for SYCL mode.

Add links to SYCL specification with address space behavior description.

Mar 26 2021, 10:06 AM · Restricted Project

Mar 25 2021

bader added a comment to D89909: [SYCL] Implement SYCL address space attributes handling.

Based on the discussion so far, would these be acceptable steps to take?

0) Complete review on this patch for any technical concerns related to it and commit when it's ready (this unblocks some downstream needs quickly, hopefully).

  1. @bader (or someone else on the SYCL team) creates a bare-bones SYCL documentation page that is quickly accepted as a placeholder for us to put more documentation.
  2. Each new SYCL related review that needs user-facing documentation outside of what the SYCL standard documents will update the Clang SYCL doc.
  3. @bader (or someone else on the SYCL team) writes address-space mapping documentation and adds it to the Clang SYCL doc.
  4. @bader (or someone else on the SYCL team) looks at other commits that have already gone into Clang to write missing documentation.

Some of these steps can be done in parallel, of course. I recognize we could have the order be #1 -> #3 -> #0 (so the docs for this change are written as part of this patch), but my concern with that approach is that this patch is blocking other SYCL efforts (@bader can correct me if I'm wrong about this) and no one has identified a definite issue with it yet beyond the lack of Clang documentation.

If those steps seem unreasonable or like I've totally missed the point on something, perhaps we could reach an understanding more quickly via a meeting (we could summarize the decisions from the meeting here so the community is aware of the end results)?

Mar 25 2021, 11:33 PM · Restricted Project, Restricted Project
bader added a comment to D99190: [SYCL] Add design document for SYCL mode.

! In D99190#2650326, @bader wrote:

  1. I'm looking for suggestions on "OpenCL extensions" clarification.

I said that "OpenCL extensions" are misleading because it can be understood as either extensions inside OpenCL (cl_khr_ext...) or extensions to C/C++ with specific OpenCL features (like kernel or global).

Mar 25 2021, 10:50 PM · Restricted Project
bader updated the diff for D99190: [SYCL] Add design document for SYCL mode.

Resolve "OpenCL extensions" ambiguity.

Mar 25 2021, 10:48 PM · Restricted Project
bader added a comment to D99190: [SYCL] Add design document for SYCL mode.

@keryell, thanks for the feedback.

Mar 25 2021, 6:11 AM · Restricted Project
bader updated the diff for D99190: [SYCL] Add design document for SYCL mode.

Apply most of the comments from Ronan.

Mar 25 2021, 6:07 AM · Restricted Project
bader added a comment to D89909: [SYCL] Implement SYCL address space attributes handling.

Let's take a look at compilation output for the following program:

c++
void foo(int *p) {}

OpenCL compiler produces following LLVM IR for SPIR target:

LLVM
define dso_local spir_func void @_Z3fooPU3AS4i(i32 addrspace(4)* nocapture %0) local_unnamed_addr #0 {
  ret void
}

Here is what SYCL device compiler produces:

LLVM
define dso_local spir_func void @_Z3fooPi(i32* nocapture %0) local_unnamed_addr #0 {
  ret void
}

We would like to get equivalent code produced by both compiler for SPIR target.
Currently SYCL device compiler emits pointer to address space 0 instead of expected 4. This lowering is defined by the address space map.
Having multiple maps is not something new to the clang community. Similar approach AMDGPU target applies to customize address space mapping for OpenCL language (https://github.com/llvm/llvm-project/blob/main/clang/lib/Basic/Targets/AMDGPU.cpp#L354).

Mar 25 2021, 5:21 AM · Restricted Project, Restricted Project
bader updated the diff for D89909: [SYCL] Implement SYCL address space attributes handling.

[NFC] Align address space map names with AMDGPU target.

Mar 25 2021, 3:44 AM · Restricted Project, Restricted Project

Mar 24 2021

bader accepted D99258: [OpenCL] Fix AST check in address-space-templates test.

LGTM. Thanks!

Mar 24 2021, 6:20 AM · Restricted Project
bader added reviewers for D99190: [SYCL] Add design document for SYCL mode: keryell, Naghasan.
Mar 24 2021, 6:09 AM · Restricted Project

Mar 23 2021

bader retitled D99190: [SYCL] Add design document for SYCL mode from [SYCL] Add design document for SYCL mode to WIP: [SYCL] Add design document for SYCL mode.
Mar 23 2021, 7:47 AM · Restricted Project
bader requested review of D99190: [SYCL] Add design document for SYCL mode.
Mar 23 2021, 7:45 AM · Restricted Project

Mar 11 2021

bader added inline comments to D95624: [OpenCL][PR48896] Fix default address space in template argument deduction.
Mar 11 2021, 8:42 PM · Restricted Project
bader accepted D98411: [OpenCL] Respect calling convention for builtin .

Thanks! LGTM.
I think we should consider deprecating spir_func calling convention in favor of default calling convention. I don't see much value in having it today.

Mar 11 2021, 4:14 AM · Restricted Project

Mar 10 2021

bader added a comment to D89909: [SYCL] Implement SYCL address space attributes handling.

Just a few minor nits from me, but I'm mostly wondering: where are we at with this and are there still substantive changes required? (I looked through the comments, but there's a lot of back-and-forth since Oct and I'm not certain what's holding the patch back currently.)

To make it short, from my side I am not very clear about the overall design. From the SYCL spec side, there is no indication of what compiler extensions are needed and if at all. As a result, some of the design choices are unclear to me - in particular why SPIR target would need a separate address space map for SYCL. This is not how it was intended originally and I am worried that this will create issues for the consumers of IR to handle two different formats. But in general, if the community is now to maintain this code we should at least have some deeper understanding of it.

I would suggest starting from some high-level documentation that provides the details of the compiler extension being implemented. Perhaps the documentation that @bader has linked earlier could be used as a starting point with some more details that would allow assessing and reviewing the changes.

Mar 10 2021, 9:42 AM · Restricted Project, Restricted Project
bader added a comment to D98204: [NFC] Fix "unused parameter" error revealed in the Linux self-build..

@zahiraam, could you rebase the patch to the tip of the branch, please? It looks like there are merge conflicts.

Mar 10 2021, 2:47 AM · Restricted Project

Mar 4 2021

bader updated the diff for D89909: [SYCL] Implement SYCL address space attributes handling.

Apply suggestions from Aaron.

Mar 4 2021, 3:30 AM · Restricted Project, Restricted Project

Mar 3 2021

bader added a comment to D97717: [SYCL] Rework the SYCL driver options.

@aaron.ballman, it looks like unittests should be updated as well. Please, take a look at failures in pre-merge checks.

Mar 3 2021, 1:52 AM · Restricted Project
bader added a reviewer for D97717: [SYCL] Rework the SYCL driver options: ABataev.
Mar 3 2021, 1:35 AM · Restricted Project
bader updated subscribers of D97717: [SYCL] Rework the SYCL driver options.
Mar 3 2021, 1:32 AM · Restricted Project

Mar 2 2021

bader accepted D97573: [OpenMP] Handle non-function context before checking for diagnostic emission.

LGTM.

Mar 2 2021, 9:55 PM · Restricted Project

Feb 11 2021

bader accepted D96538: [SYCL] Ignore file-scope asm during device-side SYCL compilation..

LGTM. Thanks.

Feb 11 2021, 9:47 PM · Restricted Project

Feb 3 2021

bader added a comment to D89909: [SYCL] Implement SYCL address space attributes handling.

Anastasia added a comment.
In D89909#2536331 https://reviews.llvm.org/D89909#2536331, @bader wrote:

In D89909#2536157 https://reviews.llvm.org/D89909#2536157, @Anastasia wrote:

In D89909#2534790 https://reviews.llvm.org/D89909#2534790, @bader wrote:

Regarding SYCLDevice and SYCLAddrSpaceMap I am still not very convinced about the flow. Have you had any design discussion regarding this already that you could point to?

We discussed this with you in https://github.com/intel/llvm/pull/1039/.

I can't see.

The mapping has been discussed in this comment: https://github.com/intel/llvm/pull/1039/#discussion_r369667791.

The discussion you cite is in the separate Github project, but you should have a discussion using LLVM channels about the design you propose for llvm-project repo. Also I don't think citing resources with many comments and no conclusions is making the review process very productive.

Feb 3 2021, 8:09 AM · Restricted Project, Restricted Project

Feb 2 2021

bader updated the diff for D89909: [SYCL] Implement SYCL address space attributes handling.

Fixed a couple of typos in the comments; NFC.

Feb 2 2021, 5:46 AM · Restricted Project, Restricted Project