Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

bader (Alexey Bader)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 23 2014, 2:13 AM (491 w, 1 d)

Recent Activity

Mon, Sep 11

bader committed rGa2e2f471c51f: [Clang][Docs] Fix typo in clang-offload-packager documentation (authored by bader).
[Clang][Docs] Fix typo in clang-offload-packager documentation
Mon, Sep 11, 4:25 PM · Restricted Project, Restricted Project

Jul 31 2023

bader committed rG1a1a68411dcb: [StripDeadDebugInfo] Drop dead CUs for const global expression (authored by bader).
[StripDeadDebugInfo] Drop dead CUs for const global expression
Jul 31 2023, 4:01 PM · Restricted Project, Restricted Project
bader closed D131179: [StripDeadDebugInfo] Drop dead CUs for const global expression.
Jul 31 2023, 4:00 PM · Restricted Project, Restricted Project

Jul 5 2023

bader added a comment to D131179: [StripDeadDebugInfo] Drop dead CUs for const global expression.

Friendly ping^2.

Jul 5 2023, 1:02 PM · Restricted Project, Restricted Project

Jun 27 2023

bader added a comment to D131179: [StripDeadDebugInfo] Drop dead CUs for const global expression.

Ping.

Jun 27 2023, 5:58 PM · Restricted Project, Restricted Project

Jun 15 2023

bader added inline comments to D151361: [CUDA] bump supported CUDA version to 12.1/11.8.
Jun 15 2023, 2:44 PM · Restricted Project, Restricted Project, Restricted Project
bader added inline comments to D151361: [CUDA] bump supported CUDA version to 12.1/11.8.
Jun 15 2023, 2:19 PM · Restricted Project, Restricted Project, Restricted Project

Jun 9 2023

bader updated the diff for D131179: [StripDeadDebugInfo] Drop dead CUs for const global expression.

Add an option (dislabed by default) to strip CU with references to non-existing const global expressions.

Jun 9 2023, 9:29 PM · Restricted Project, Restricted Project

Mar 30 2023

bader added a comment to D131179: [StripDeadDebugInfo] Drop dead CUs for const global expression.

I think your example makes perfect sense, but it sounds like this should be a feature that only llvm-extract or whatever tool you are using in the described workflow should enable. Generally you don't want "dead" constant's debug info stripped in a normal compilation because you still want to be able to see these constants in the debugger. In your workflow the compiler has special knowledge that this debug info will be available externally, so it makes sense there.

Mar 30 2023, 8:14 PM · Restricted Project, Restricted Project

Mar 29 2023

bader accepted D147097: [SYCL] Always set NoUnwind attribute for SYCL..

LGTM. Thanks!

Mar 29 2023, 11:26 AM · Restricted Project, Restricted Project
bader added a comment to D131179: [StripDeadDebugInfo] Drop dead CUs for const global expression.

Ping.

Mar 29 2023, 10:45 AM · Restricted Project, Restricted Project

Mar 28 2023

bader added a comment to D147097: [SYCL] Always set NoUnwind attribute for SYCL..

@hvdijk, thanks a lot for fixing this.

Mar 28 2023, 5:57 PM · Restricted Project, Restricted Project

Mar 3 2023

bader added inline comments to D129507: [OffloadPackager] Add option to extract files from images.
Mar 3 2023, 10:01 PM · Restricted Project, Restricted Project, Restricted Project
bader committed rGb056c1cb1b4b: [StripDebugInfo] Reuse DebugInfoFinder for findind Live CUs (authored by maksimsab).
[StripDebugInfo] Reuse DebugInfoFinder for findind Live CUs
Mar 3 2023, 4:22 PM · Restricted Project, Restricted Project
bader closed D145239: [StripDebugInfo] Reuse DebugInfoFinder for findind Live CUs.
Mar 3 2023, 4:21 PM · Restricted Project, Restricted Project

Feb 9 2023

bader added a reviewer for D143472: [clang] Cast the pointer to right type with different address space: Anastasia.
Feb 9 2023, 5:07 PM · Restricted Project, Restricted Project

Jan 26 2023

bader accepted D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target..

LGTM. Thanks!

Jan 26 2023, 9:27 AM · Restricted Project, Restricted Project
bader added inline comments to D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target..
Jan 26 2023, 8:21 AM · Restricted Project, Restricted Project

Jan 25 2023

bader added a comment to D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target..

"[SPIR-V] Add support for arithmetic_fence builtin for SYCL targets." -> "[SPIR] Add support for arithmetic_fence builtin for SPIR target."

Jan 25 2023, 2:27 PM · Restricted Project, Restricted Project

Jan 23 2023

bader committed rGb0b4cc18641b: [bugpoint] Fix compilation of bugpoint-passes on Windows (authored by bader).
[bugpoint] Fix compilation of bugpoint-passes on Windows
Jan 23 2023, 5:48 PM · Restricted Project, Restricted Project
bader closed D140609: [bugpoint] Fix compilation of bugpoint-passes on Windows.
Jan 23 2023, 5:48 PM · Restricted Project, Restricted Project
bader updated subscribers of D140609: [bugpoint] Fix compilation of bugpoint-passes on Windows.

@beanz, could you help with reviewing this change, please?

Jan 23 2023, 12:02 PM · Restricted Project, Restricted Project

Jan 18 2023

bader accepted D142033: [OpenCL] Always add nounwind attribute for OpenCL.

Should we generalize and rename clang/test/CodeGenOpenCL/convergent.cl to validate function attributes other than convergent? It's not obvious that presence of nounwind attribute is validated by clang/test/CodeGenOpenCL/convergent.cl.

Jan 18 2023, 9:27 AM · Restricted Project, Restricted Project

Jan 10 2023

bader accepted D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics.

I expect this to be a common issue for all single-source offloading programming models (i.e. CUDA and HIP in addition to SYCL and OpenMP offload). Probably we can generalize the code patterns used in this patch for all of them.

Jan 10 2023, 1:27 PM · Restricted Project, Restricted Project

Jan 5 2023

bader added a comment to D141034: [Interpreter] Added aggregate types support.

I can understand the reason for changes in llvm/lib/ExecutionEngine/ExecutionEngine.cpp and tests, but the purpose of changes in llvm/lib/ExecutionEngine/Interpreter/ is not clear. Could you elaborate more on that, please?

Jan 5 2023, 11:49 AM · Restricted Project, Restricted Project

Jan 4 2023

bader added inline comments to D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V..
Jan 4 2023, 3:14 PM · Restricted Project, Restricted Project, Restricted Project
bader added a comment to D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V..

@jcranmer-intel, thanks a lot for working on this. I'm so excited to see these changes!
Overall, it looks good to me, but I'd like to avoid some runtime computations if possible.

Jan 4 2023, 2:26 PM · Restricted Project, Restricted Project, Restricted Project
bader added a reviewer for D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.: yaxunl.
Jan 4 2023, 2:13 PM · Restricted Project, Restricted Project, Restricted Project

Nov 18 2022

bader accepted D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr.

Thanks for the fix!

Nov 18 2022, 7:58 AM · Restricted Project, Restricted Project
bader added inline comments to D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr.
Nov 18 2022, 7:37 AM · Restricted Project, Restricted Project
bader added inline comments to D138284: Fix incorrect cast in VisitSYCLUniqueStableNameExpr.
Nov 18 2022, 6:58 AM · Restricted Project, Restricted Project

Nov 10 2022

bader added a comment to D137154: Adding nvvm_reflect clang builtin.

Is binary size a concern here? NVIDIA, AMD and Intel GPUs are already have ~ 20 different architectures each, so I want my app/library to run on any GPU from these vendors (which is quite reasonable expectation), I'll need to have/distribute ~ 60 different binaries. libdevice, libm, libc are quite small, but other apps (e.g. ML frameworks) might be quite large, so that distributed binary size is important to consider.

Nov 10 2022, 1:39 AM · Restricted Project, Restricted Project, Restricted Project

Nov 6 2022

bader committed rGe0ed3d5d2e93: Online sync-ups: add SYCL working group sync details. (authored by bader).
Online sync-ups: add SYCL working group sync details.
Nov 6 2022, 8:19 AM · Restricted Project, Restricted Project

Nov 1 2022

bader updated the summary of D137154: Adding nvvm_reflect clang builtin.
Nov 1 2022, 4:31 AM · Restricted Project, Restricted Project, Restricted Project

Oct 19 2022

bader committed rG66bd6074c133: [Attr][Doc] Fix pragma unroll documentation. (authored by bader).
[Attr][Doc] Fix pragma unroll documentation.
Oct 19 2022, 3:55 AM · Restricted Project, Restricted Project
bader closed D136160: [Attr][Doc] Fix pragma unroll documentation..
Oct 19 2022, 3:55 AM · Restricted Project, Restricted Project

Oct 18 2022

bader updated the summary of D136160: [Attr][Doc] Fix pragma unroll documentation..
Oct 18 2022, 4:57 AM · Restricted Project, Restricted Project
bader updated the diff for D136160: [Attr][Doc] Fix pragma unroll documentation..

Update commit message.

Oct 18 2022, 4:57 AM · Restricted Project, Restricted Project
bader requested review of D136160: [Attr][Doc] Fix pragma unroll documentation..
Oct 18 2022, 4:54 AM · Restricted Project, Restricted Project

Oct 12 2022

bader accepted D135446: [libcxxabi] Resync llvm & libcxxabi's demangler.

@urnathan, sorry, we didn't notice that https://reviews.llvm.org/D130909 introduces divergence. @steffenlarsen, @jcranmer-intel, FYI.
Regarding dropping LLVM_ prefix from header guards, it looks like these were removed with some automatic tool (https://github.com/intel/llvm/commit/c13a09a462807936f9eb17cc64f53ad7c9e8ddec), so I would expect someone else will run the tool again and add them back. Any ideas how to prevent this type of changes in the future? Maybe we can keep LLVM_ prefix for sources in llvm/ directory and just ignore this difference. What do you think?

Oct 12 2022, 2:52 AM · Restricted Project, Restricted Project, Restricted Project

Sep 13 2022

bader added a comment to D131179: [StripDeadDebugInfo] Drop dead CUs for const global expression.

I don't think this would end up matching the user expectation. If I'm in the debugger I would expect to be able to access global constants in the expression evaluator.

Sep 13 2022, 6:32 AM · Restricted Project, Restricted Project

Sep 11 2022

bader added a comment to D122163: [StripDeadDebugInfo] Drop dead CUs.

@aprantl, thank you a lot for reviewing this patch. Could you also take a look at the part moved to https://reviews.llvm.org/D131179, please?

Sep 11 2022, 1:37 AM · Restricted Project, Restricted Project
bader committed rG2bb5535b58ed: [StripDeadDebugInfo] Drop dead CUs (authored by bader).
[StripDeadDebugInfo] Drop dead CUs
Sep 11 2022, 1:34 AM · Restricted Project, Restricted Project
bader closed D122163: [StripDeadDebugInfo] Drop dead CUs.
Sep 11 2022, 1:34 AM · Restricted Project, Restricted Project

Sep 5 2022

bader added inline comments to D116266: [SPIR-V] Add linking of separate translation units using spirv-link.
Sep 5 2022, 4:25 AM · Restricted Project, Restricted Project
bader added a comment to D131179: [StripDeadDebugInfo] Drop dead CUs for const global expression.

Ping.

Sep 5 2022, 4:11 AM · Restricted Project, Restricted Project
bader added a comment to D122163: [StripDeadDebugInfo] Drop dead CUs.

Ping.

Sep 5 2022, 4:10 AM · Restricted Project, Restricted Project

Sep 4 2022

bader accepted D132550: Changes to code ownership in clang and clang-tidy.
Sep 4 2022, 4:06 AM · Restricted Project, Restricted Project, Restricted Project

Aug 7 2022

bader committed rGf0f1bcadc74f: [demangler] Add getters for Qual/Vector/Pointer types (authored by bader).
[demangler] Add getters for Qual/Vector/Pointer types
Aug 7 2022, 2:13 AM · Restricted Project, Restricted Project
bader closed D130909: [demangler] Add getters for Qual/Vector/Pointer types.
Aug 7 2022, 2:12 AM · Restricted Project, Restricted Project

Aug 4 2022

bader updated the diff for D122163: [StripDeadDebugInfo] Drop dead CUs.

Apply clang-format. No functional changes.

Aug 4 2022, 9:27 AM · Restricted Project, Restricted Project
bader added inline comments to D122163: [StripDeadDebugInfo] Drop dead CUs.
Aug 4 2022, 9:19 AM · Restricted Project, Restricted Project
bader requested review of D131179: [StripDeadDebugInfo] Drop dead CUs for const global expression.
Aug 4 2022, 9:18 AM · Restricted Project, Restricted Project
bader added a comment to D122163: [StripDeadDebugInfo] Drop dead CUs.

@aprantl, sorry for the delay. I'd like to finish this patch on behalf of @mlychkov.
I've applied all your suggestions. Please, take a look.

Aug 4 2022, 5:41 AM · Restricted Project, Restricted Project
bader updated the diff for D122163: [StripDeadDebugInfo] Drop dead CUs.

Applied code review suggestions.

Aug 4 2022, 5:35 AM · Restricted Project, Restricted Project
bader commandeered D122163: [StripDeadDebugInfo] Drop dead CUs.
Aug 4 2022, 5:34 AM · Restricted Project, Restricted Project

Aug 1 2022

bader retitled D130909: [demangler] Add getters for Qual/Vector/Pointer types from [demangler] Add getters for Qual/Vector/Pointer types These are useful for downstream tool aligning the mangling of data types which differ between different languages/targets. to [demangler] Add getters for Qual/Vector/Pointer types.
Aug 1 2022, 8:33 AM · Restricted Project, Restricted Project
bader requested review of D130909: [demangler] Add getters for Qual/Vector/Pointer types.
Aug 1 2022, 8:33 AM · Restricted Project, Restricted Project

Jul 6 2022

bader committed rG923b56e7ca96: [NFC] Add a TODO comment to apply nounwind attribute in all GPU modes. (authored by bader).
[NFC] Add a TODO comment to apply nounwind attribute in all GPU modes.
Jul 6 2022, 6:21 AM · Restricted Project, Restricted Project

Jun 16 2022

bader added a comment to D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata.

The way I understand a bitcast instruction in SPIR-V (OpBitcast in https://www.khronos.org/registry/SPIR-V/specs/unified1/SPIRV.html#_conversion_instructions) is that it can only apply to pointer types which are distinct from function types. Note that I believe that function pointers are illegal, at least we disallow them in OpenCL.

Jun 16 2022, 5:43 AM · Restricted Project, Restricted Project

Jun 15 2022

bader added a comment to D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata.

@nikic the most important thing you need to know about SPIR-V is that it is a virtual ISA based on LLVM IR. The ISA itself encodes types for pointers just like LLVM IR would.

Jun 15 2022, 8:10 AM · Restricted Project, Restricted Project

Apr 4 2022

bader committed rG87b28f5092f2: [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member (authored by psamolysov-intel).
[clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member
Apr 4 2022, 5:17 AM · Restricted Project, Restricted Project
bader closed D122587: [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member.
Apr 4 2022, 5:16 AM · Restricted Project, Restricted Project

Feb 4 2022

bader accepted D118935: [SYCL] Disallow explicit casts between mismatching address spaces.

LGTM. Thanks!

Feb 4 2022, 12:32 AM · Restricted Project, Restricted Project

Jan 24 2022

bader accepted D114483: [SYCL] Add support for sycl_special_class attribute.

LGTM, just one suggestion.
It would be great to get @aaron.ballman approve too.

Jan 24 2022, 9:42 AM · Restricted Project
bader added inline comments to D116266: [SPIR-V] Add linking of separate translation units using spirv-link.
Jan 24 2022, 6:20 AM · Restricted Project, Restricted Project

Dec 20 2021

bader added a comment to D115708: Disable issue labeler in LLVM forks.

LGTM. I'm not sure the best place to document this.

Dec 20 2021, 2:05 AM · Restricted Project

Dec 8 2021

bader committed rG9ae5810b53c2: [HIPSPV] Convert HIP kernels to SPIR-V kernels (authored by linjamaki).
[HIPSPV] Convert HIP kernels to SPIR-V kernels
Dec 8 2021, 4:18 AM
bader closed D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels.
Dec 8 2021, 4:18 AM · Restricted Project

Dec 7 2021

bader added a comment to D110622: [HIPSPV][3/4] Enable SPIR-V emission for HIP.

The patch looks OK for the time being. That said, I do have concerns that we may be organically growing something that will be troublesome to deal with long-term.

TBH, I still can't quite make sense of where/how SPIR-V fits in the offloading nomenclature.

Right now we have multiple levels of offloading-related control points.

  • offload targets, specified by --offload-arch. Determines the ISA of the GPU binary we produce.
  • offload mechanism: OpenMP, CUDA runtime, HSA. Determines how we compile/pack/launch the GPU binaries.
  • front-end: CUDA/HIP/ C/C++ w/ OpenMP.
  • Driver: Determines compilation pipeline to glue everything together,

SPIR-V in these patches appears to be wearing multiple hats.
It changes compilation pipeline, it changes offload mechanism and it changes offload targets.

Dec 7 2021, 3:31 AM · Restricted Project

Dec 3 2021

bader added a comment to D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels.

The patch is ready to land. @Anastasia, @bader, could you commit this patch to the LLVM for us? Thanks.

Dec 3 2021, 9:28 AM · Restricted Project

Nov 25 2021

bader added a comment to D114080: [SYCL] Diagnose uses of zero length arrays.

LGTM, with a couple of minor suggestions.

Nov 25 2021, 1:01 AM · Restricted Project

Nov 18 2021

bader added a comment to D107054: [Clang][CUDA] Add descriptors, mappings, and features for missing CUDA and PTX versions.

@tra, ping.
@steffenlarsen, does it make sense to add support for recently released 11.5 as well?

Nov 18 2021, 1:42 PM · Restricted Project, Restricted Project

Nov 17 2021

bader committed rG49682f14bf3f: [SPIR-V] Add translator tool (authored by linjamaki).
[SPIR-V] Add translator tool
Nov 17 2021, 7:41 PM
bader closed D112404: [SPIR-V] Add translator tool.
Nov 17 2021, 7:41 PM · Restricted Project

Oct 28 2021

bader added a reviewer for D112718: Add intrinsics and builtins for PTX atomics with semantic orders: tra.
Oct 28 2021, 7:30 AM · Restricted Project, Restricted Project, Restricted Project
bader accepted D112404: [SPIR-V] Add translator tool.

This part looks good to me. Just a couple of minor style comments.

Oct 28 2021, 5:07 AM · Restricted Project

Oct 25 2021

bader updated subscribers of D112410: [SPIR-V] Add a toolchain for SPIR-V in clang.
Oct 25 2021, 2:50 AM · Restricted Project

Oct 20 2021

bader accepted D111566: [SYCL] Fix function pointer address space.

@vlastik, your commit fixes function pointers on AVR - https://github.com/llvm/llvm-project/commit/57fd86de879cf2b4c7001b6d0a09df60877ce24d. I suppose this change is required for fixing lvalue references to function pointers on AVR as well. Right?

Oct 20 2021, 8:57 AM · Restricted Project, Restricted Project

Oct 14 2021

bader added a comment to D71016: [SYCL] Implement OpenCL kernel function generation.

Would a codegenSYCL directory help you to separate Sema from code generation?

Oct 14 2021, 5:31 AM · Restricted Project
bader added a comment to D71016: [SYCL] Implement OpenCL kernel function generation.

It feels like you are doing codegen(OpenCL kernel) in Sema. Are OpenCL kernels the only approach.

Oct 14 2021, 4:55 AM · Restricted Project

Oct 13 2021

bader added inline comments to D71016: [SYCL] Implement OpenCL kernel function generation.
Oct 13 2021, 7:22 AM · Restricted Project
bader added reviewers for D71016: [SYCL] Implement OpenCL kernel function generation: erichkeane, aaron.ballman.
Oct 13 2021, 3:23 AM · Restricted Project

Oct 11 2021

bader updated subscribers of D110618: [HIPSPV][2/4] Add HIPSPV tool chain.
Oct 11 2021, 1:08 AM · Restricted Project

Oct 6 2021

bader added a comment to D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info.
  1. Implementing SPIR-V target as SPIR target. @bader do you suggest that we add spirv triple to clang and map it into SPIR taget or do you suggest something different?
Oct 6 2021, 10:17 AM · Restricted Project, Restricted Project

Oct 5 2021

bader added inline comments to D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping.
Oct 5 2021, 4:54 AM · Restricted Project, Restricted Project
bader added a comment to D109144: [SPIR-V] Add SPIR-V triple architecture and clang target info.

It would be good to get closure on this asap.

@bader We had related discussions on the other reviews about the approach in this patch. If you have any concerns/suggestions can you please notify asap...

Oct 5 2021, 2:43 AM · Restricted Project, Restricted Project
bader added inline comments to D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping.
Oct 5 2021, 2:41 AM · Restricted Project, Restricted Project

Sep 23 2021

bader added a comment to D110281: Change __builtin_sycl_unique_stable_name to just use an Itanium mangling.

LGTM, just one typo in addition to linter reports and I'd like John to take a look.

Sep 23 2021, 5:08 AM · Restricted Project

Sep 22 2021

bader added inline comments to D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels.
Sep 22 2021, 4:08 AM · Restricted Project

Sep 21 2021

bader added inline comments to D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping.
Sep 21 2021, 8:19 AM · Restricted Project, Restricted Project

Sep 20 2021

bader committed rG15feaaa359c7: Add myself as a code owner for SYCL support (authored by bader).
Add myself as a code owner for SYCL support
Sep 20 2021, 2:33 AM

Sep 13 2021

bader added inline comments to D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping.
Sep 13 2021, 2:14 AM · Restricted Project, Restricted Project

Aug 26 2021

bader added inline comments to D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping.
Aug 26 2021, 7:56 AM · Restricted Project, Restricted Project

Aug 25 2021

bader accepted D108621: [HIPSPV] Add CUDA->SPIR-V address space mapping.

LGTM.

Aug 25 2021, 2:37 AM · Restricted Project, Restricted Project

Aug 13 2021

bader requested review of D108034: [SPIR-V] Add SPIR-V builtin functions and types.
Aug 13 2021, 6:57 AM · Restricted Project
bader committed rGd754b970eddb: [NFC] Drop idle compiler option from the test. (authored by bader).
[NFC] Drop idle compiler option from the test.
Aug 13 2021, 6:21 AM
bader closed D108020: [NFC] Drop idle compiler option from the test..
Aug 13 2021, 6:21 AM · Restricted Project
bader requested review of D108020: [NFC] Drop idle compiler option from the test..
Aug 13 2021, 2:04 AM · Restricted Project
bader committed rGc064ba34c7d8: [NFC] Add commas in code comments. (authored by bader).
[NFC] Add commas in code comments.
Aug 13 2021, 2:01 AM