Maybe we should use the year of issue (2015 instead of 1.2.1) for the -sycl-std version? That would be more stable for the upcoming SYCL versions, and match somehow the C++ versioning.

In D72362#1817682, @lebedev.ri wrote:

In D72362#1817599, @bader wrote:

Does it make sense to implement such diagnostics in clang Sema, considering that OpenCL does not allow recursion?
We implemented similar diagnostics for SYCL programming model and would be like to upstream it to clang later (https://github.com/intel/llvm/commit/4efe9fcf2dc6f6150b5b477b0f8320ea13a7f596). Can we somehow leverage this work for the compiler?

Implementing it elsewhere will be more restrictive in the future - somehow i suspect
it will be easier to make clang-tidy CTU-aware rather than clang sema.

That being said, is SYCL inherently single-TU, does it not support
linking multiple separately compiled object files together?

Does it make sense to implement such diagnostics in clang Sema, considering that OpenCL does not allow recursion?
We implemented similar diagnostics for SYCL programming model and would be like to upstream it to clang later (https://github.com/intel/llvm/commit/4efe9fcf2dc6f6150b5b477b0f8320ea13a7f596). Can we somehow leverage this work for the compiler?

LGTM, but I'd like someone who works on OpenCL front-end to approve.
+@AlexeySotkin

Added LIT test.

In D71286#1777894, @ABataev wrote:

Most probably, just missed the testing of the frontend part here

I'm looking for test suggestions as I was not able to find tests covering similar changes for OpenMP compiler.

@aaron.ballman, thank you for fixing the problem with documentation generation.

is there a reason this should be clang::opencl_private as opposed to opencl::private?

I'm okay with [[opencl::private]] as well. I have only one problem - currently OpenCL address spaces are exposed as keywords and using them in C++ breaks valid C++ code.

I'm not certain who controls the OpenCL spec, but this seems like it should be a decision that comes from there. Or is this functionality outside of the OpenCL spec?

In D71005#1770338, @Anastasia wrote:

LGTM! Thanks!

I presume OpenCL addr space logic won't apply in all cases in non-OpenCL compilations i.e. for example C++ because we enclose some of the logic under LangOpts checks.

Change attribute prefix: ocl_ -> opencl_.

I hope all comments from are @Fznamznon and @aaron.ballman are applied.
@ABataev, do you have any other comments?

Fixed SYCL code example for sycl_kernel attribute documentation and commit message.

Applied @aaron.ballman suggestions to kernel-attribute.cpp test

Applied comments from @Fznamznon.

Minor update adjusting to the recent changes.

In D60455#1762804, @Anastasia wrote:

Sorry, I don't have capacity currently to review this and I don't want to be blocking it either.

Fixed typo in the commit message: complier -> compiler.

Applied code review suggestions.

Ping.

Applied code review comments from Aaron.

Applied code review comments.

@aaron.ballman, @Anastasia, could you take a look at new version of the patch, please?

Applied two remaining comments from Aaron.

Applied comments from Aaron.

Thanks a lot for the comments and sorry for the long delay. We've been working on complete implementation of the SYCL 1.2.1 specification.
Now I have more time to work on contributing the implementation to LLVM project.