Page MenuHomePhabricator
People bader

bader (Alexey Bader)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 23 2014, 2:13 AM (269 w, 5 d)

Recent Activity
View All

Today

bader committed rG439073351855: [SYCL] Fix cl::sycl::group get_linear_id API name. (authored by kbobrovs).
[SYCL] Fix cl::sycl::group get_linear_id API name.
Mon, Jun 24, 12:02 PM
bader committed rGdc5124090d8c: [SYCL][NFC] Refactor common code into a helper function (authored by AlexeySachkov).
[SYCL][NFC] Refactor common code into a helper function
Mon, Jun 24, 12:02 PM
bader committed rGc05692e52402: [SYCL] Remove outdated CMake configuration. (authored by bader).
[SYCL] Remove outdated CMake configuration.
Mon, Jun 24, 12:02 PM
bader committed rG4c58035060a4: [SYCL] Avoid declaring unscoped enums in global namespace (authored by AlexeySachkov).
[SYCL] Avoid declaring unscoped enums in global namespace
Mon, Jun 24, 12:02 PM
bader committed rG07358ac176ec: [SYCL] Update documents with recent project changes (authored by Vladimir Lazarev <vladimir.lazarev@intel.com>).
[SYCL] Update documents with recent project changes
Mon, Jun 24, 12:02 PM
bader committed rG3f6c35322964: [Buildbot] migrate build script from shell to python (authored by Kurt Chen <kurt.chen@intel.com>).
[Buildbot] migrate build script from shell to python
Mon, Jun 24, 12:02 PM
bader committed rGc191009f536a: [SYCL] Temporary disable stream LIT test. (authored by romanovvlad).
[SYCL] Temporary disable stream LIT test.
Mon, Jun 24, 12:02 PM
bader committed rGfa4ba4c1b155: [SYCL] Refactor OpenCL kernel generation (#227) (authored by Fznamznon).
[SYCL] Refactor OpenCL kernel generation (#227)
Mon, Jun 24, 12:02 PM
bader committed rGe844b0c3ad24: [SYCL][NFC] Remove dead code (#230) (authored by v-klochkov <34946562+v-klochkov@users.noreply.github.com>).
[SYCL][NFC] Remove dead code (#230)
Mon, Jun 24, 12:02 PM
bader committed rGb2248cce1db3: [SYCL] Add ND-range reduction extension docs (#211) (authored by John Pennycook <john.pennycook@intel.com>).
[SYCL] Add ND-range reduction extension docs (#211)
Mon, Jun 24, 12:02 PM
bader committed rG57ee6e1ddfe7: [SYCL] Remove wrapper headers (authored by ArturGainullin).
[SYCL] Remove wrapper headers
Mon, Jun 24, 12:02 PM
bader committed rG2c9ab05ee71d: [SYCL] Retain OpenCL kernel in SYCL kernel constructor (authored by Fznamznon).
[SYCL] Retain OpenCL kernel in SYCL kernel constructor
Mon, Jun 24, 12:01 PM
bader committed rG54e4ecba2912: fix typo (authored by jeffhammond).
fix typo
Mon, Jun 24, 12:01 PM
bader committed rG6b8be71c6397: [SYCL] Fix warning in half implementation (authored by Fznamznon).
[SYCL] Fix warning in half implementation
Mon, Jun 24, 12:01 PM
bader committed rGdba5f18c0daf: [SYCL] Enable set_final_data for shared_ptr (authored by Vladimir Lazarev <vladimir.lazarev@intel.com>).
[SYCL] Enable set_final_data for shared_ptr
Mon, Jun 24, 12:01 PM
bader committed rG9ff0401eed03: [SYCL] Minor fixes after stream class implementation. (authored by ArturGainullin).
[SYCL] Minor fixes after stream class implementation.
Mon, Jun 24, 12:01 PM
bader committed rG9ceb9e26498c: [SYCL] Check return of Expected<T> when reading section size content (authored by Michael D Toguchi <michael.d.toguchi@intel.com>).
[SYCL] Check return of Expected<T> when reading section size content
Mon, Jun 24, 12:01 PM
bader committed rG65408104f89a: [SYCL] Stream class (authored by ArturGainullin).
[SYCL] Stream class
Mon, Jun 24, 12:01 PM
bader committed rGbc8c55cd897d: [SYCL] Align global_mem_cache_type values with SYCL specification. (authored by romanovvlad).
[SYCL] Align global_mem_cache_type values with SYCL specification.
Mon, Jun 24, 12:01 PM
bader committed rGf4a5a632b7e8: [SYCL] Release notes for June'19 release. (authored by romanovvlad).
[SYCL] Release notes for June'19 release.
Mon, Jun 24, 12:01 PM
bader committed rG76cd23df67f8: [SYCL] Fix build after old scheduler removal (authored by ArturGainullin).
[SYCL] Fix build after old scheduler removal
Mon, Jun 24, 12:01 PM
bader committed rGeb735eeb9d6b: [SYCL] Enable OpenCL diagnostics for sampler in SYCL mode (authored by bader).
[SYCL] Enable OpenCL diagnostics for sampler in SYCL mode
Mon, Jun 24, 12:01 PM
bader committed rG208cd7c57ecc: [SYCL] Update documentation with OpenCL types re-use proposal (authored by bader).
[SYCL] Update documentation with OpenCL types re-use proposal
Mon, Jun 24, 12:01 PM
bader committed rGda9bdd33b2c7: [SYCL][NFC] Remove code from comments. (authored by bader).
[SYCL][NFC] Remove code from comments.
Mon, Jun 24, 12:01 PM
bader committed rG2e480815cb62: [SYCL] Enable sampler support in set_arg(s) method. (authored by Alexey Voronov <alexey.voronov@intel.com>).
[SYCL] Enable sampler support in set_arg(s) method.
Mon, Jun 24, 12:01 PM
bader committed rG76bb25938280: [SYCL] Remove old scheduler (authored by ArturGainullin).
[SYCL] Remove old scheduler
Mon, Jun 24, 12:01 PM
bader committed rGa7188719f29d: [SYCL] Add /bigobj switch to SemaSYCL.cpp on Windows to enable DEBUG build (authored by v_klochkov).
[SYCL] Add /bigobj switch to SemaSYCL.cpp on Windows to enable DEBUG build
Mon, Jun 24, 12:00 PM
bader committed rG5a3a030fe868: [SYCL] Sync with SPIRV-LLVM-Translator 365675f2 (authored by AlexeySachkov).
[SYCL] Sync with SPIRV-LLVM-Translator 365675f2
Mon, Jun 24, 12:00 PM
bader committed rGa72d544791c8: [SYCL] Refactor SYCL clang kernel wrapper tests (authored by Fznamznon).
[SYCL] Refactor SYCL clang kernel wrapper tests
Mon, Jun 24, 12:00 PM
bader committed rG1614b8f91cce: [SYCL] Add SYCL clang frontend doc (authored by Fznamznon).
[SYCL] Add SYCL clang frontend doc
Mon, Jun 24, 12:00 PM
bader committed rG9079001c37bf: [SYCL] Include <algorithm> for std::max, define M_PI macro in builtins (authored by v_klochkov).
[SYCL] Include <algorithm> for std::max, define M_PI macro in builtins
Mon, Jun 24, 12:00 PM
bader committed rG33fabc41f73d: [SYCL] Fix vec and SwizzleOp types on Windows (authored by v_klochkov).
[SYCL] Fix vec and SwizzleOp types on Windows
Mon, Jun 24, 12:00 PM
bader committed rG5adefa389125: [SYCL] Clean up in swizzle macros, prepare them for change of Indexer (authored by v_klochkov).
[SYCL] Clean up in swizzle macros, prepare them for change of Indexer
Mon, Jun 24, 12:00 PM
bader committed rG5713c578ca11: [SYCL][FPGA] Add 'SYCL' lang prefix for loop attributes (authored by sidorovd).
[SYCL][FPGA] Add 'SYCL' lang prefix for loop attributes
Mon, Jun 24, 12:00 PM
bader committed rG637c69b54aa5: [SYCL][NFC] Add 2 private aux types to SwizzleOp class (authored by v_klochkov).
[SYCL][NFC] Add 2 private aux types to SwizzleOp class
Mon, Jun 24, 12:00 PM
bader committed rG8d186a3f7e3e: [SYCL] Remove _Float16 from integration header (authored by Fznamznon).
[SYCL] Remove _Float16 from integration header
Mon, Jun 24, 11:59 AM
bader committed rG4d847c083831: [SYCL] Remove redundant code (authored by Fznamznon).
[SYCL] Remove redundant code
Mon, Jun 24, 11:59 AM
bader committed rG505e19553975: [SYCL] Fix errors caused by unsupported __builtin_expect() on Windows (authored by v_klochkov).
[SYCL] Fix errors caused by unsupported __builtin_expect() on Windows
Mon, Jun 24, 11:59 AM
bader committed rG2dffc683b9d5: [SYCL][Driver]Offloader][Test] Add test case to sycl-offload.c (authored by agozillon).
[SYCL][Driver]Offloader][Test] Add test case to sycl-offload.c
Mon, Jun 24, 11:56 AM
bader committed rG23fd38bbdf83: [SYCL][Driver][Offloader][NFC] Moving invalid SYCL target diagnostic (authored by agozillon).
[SYCL][Driver][Offloader][NFC] Moving invalid SYCL target diagnostic
Mon, Jun 24, 11:56 AM
bader committed rG5361627cc619: [SYCL][Driver][Offloader] Adding appropriate error out on incorrect SYCL target (authored by agozillon).
[SYCL][Driver][Offloader] Adding appropriate error out on incorrect SYCL target
Mon, Jun 24, 11:56 AM
bader committed rG25cd3108011b: [Driver][Offloader] Add getOffloadingDeviceToolChain function (authored by agozillon).
[Driver][Offloader] Add getOffloadingDeviceToolChain function
Mon, Jun 24, 11:55 AM
bader committed rG0ae767fe62bf: [SYCL] Fix the definition of const_reference in accessor (authored by v_klochkov).
[SYCL] Fix the definition of const_reference in accessor
Mon, Jun 24, 11:55 AM
bader committed rGadb9912a5423: add pointer from README to extensions folder (authored by jeffhammond).
add pointer from README to extensions folder
Mon, Jun 24, 11:55 AM
bader committed rG92b4a0834fb0: [SYCL] Added a test for the removal of the const item operator[] overload, and… (authored by pkeir <pkeir@outlook.com>).
[SYCL] Added a test for the removal of the const item operator[] overload, and…
Mon, Jun 24, 11:55 AM

Wed, Jun 19

bader added inline comments to D60455: [SYCL] Implement SYCL device code outlining.
Wed, Jun 19, 2:00 PM · Restricted Project

Tue, Jun 11

bader added reviewers for D60455: [SYCL] Implement SYCL device code outlining: rjmccall, rsmith.
Tue, Jun 11, 9:18 AM · Restricted Project

Thu, May 30

bader committed rG39c82eb835d0: [SYCL] Update SYCL clang tests (authored by Fznamznon).
[SYCL] Update SYCL clang tests
Thu, May 30, 11:10 AM
bader committed rGa5f2fda17ae9: [SYCL] Use SPIRV-friendly built-in naming scheme (authored by Fznamznon).
[SYCL] Use SPIRV-friendly built-in naming scheme
Thu, May 30, 11:10 AM
bader committed rG7db9ce878a08: [SYCL] Add aliases to OpenCL event and sampler types for SYCL (authored by Fznamznon).
[SYCL] Add aliases to OpenCL event and sampler types for SYCL
Thu, May 30, 11:10 AM
bader committed rGcd9de48cc747: [SYCL] Remove re-flower pass from clang (authored by Fznamznon).
[SYCL] Remove re-flower pass from clang
Thu, May 30, 11:10 AM
bader committed rG109cdc5da299: [SYCL] Disable event_profiling_info.cpp on host device. (authored by romanovvlad).
[SYCL] Disable event_profiling_info.cpp on host device.
Thu, May 30, 11:10 AM
bader committed rG5b4a89ea4783: [SYCL][NFC] Remove dead code (authored by bader).
[SYCL][NFC] Remove dead code
Thu, May 30, 11:09 AM
bader committed rGff4e08cf11ca: [SYCL][NFC] Capitalize SYCL specification references (authored by bader).
[SYCL][NFC] Capitalize SYCL specification references
Thu, May 30, 11:09 AM
bader committed rG40ce2a7cef11: [SYCL] Align get_profiling_info behavior with the specification (authored by romanovvlad).
[SYCL] Align get_profiling_info behavior with the specification
Thu, May 30, 11:09 AM
bader committed rG5334afcd33ca: [SYCL] Update scheduler API in event methods (authored by romanovvlad).
[SYCL] Update scheduler API in event methods
Thu, May 30, 11:09 AM
bader committed rGa91d7225617f: [SYCL] Fix several errors in accessor (authored by v_klochkov).
[SYCL] Fix several errors in accessor
Thu, May 30, 11:09 AM
bader committed rG8a95712bcc9a: [SYCL] Get sampler and accessor types without using named fields of kernel… (authored by Sindhu Chittireddy <sindhu.chittireddy@intel.com>).
[SYCL] Get sampler and accessor types without using named fields of kernel…
Thu, May 30, 9:27 AM
bader committed rGa5d763ba286b: [SYCL][NFC] Do not generate temporary files in source tree (authored by AlexeySachkov).
[SYCL][NFC] Do not generate temporary files in source tree
Thu, May 30, 9:27 AM
bader committed rG57d87242a11b: [SYCL] Fix clang/test/Driver/header-module.cpp in Debug (authored by AlexeySachkov).
[SYCL] Fix clang/test/Driver/header-module.cpp in Debug
Thu, May 30, 9:27 AM
bader committed rG852f120d9cf9: [SYCL][NFC] Remove duplicated RUN line (authored by AlexeySachkov).
[SYCL][NFC] Remove duplicated RUN line
Thu, May 30, 9:27 AM
bader committed rG972c75edf062: [SYCL] Enable sub-group load_store test on GPU (authored by Fznamznon).
[SYCL] Enable sub-group load_store test on GPU
Thu, May 30, 9:27 AM
bader committed rG63b5d9c1d828: [SYCL] Fix check of CL_TARGET_OPENCL_VERSION macro value. (authored by bader).
[SYCL] Fix check of CL_TARGET_OPENCL_VERSION macro value.
Thu, May 30, 9:27 AM
bader committed rGe9933a82a6e1: [SYCL] Link gcc_s and gcc libraries for GCC 5+ versions (authored by bader).
[SYCL] Link gcc_s and gcc libraries for GCC 5+ versions
Thu, May 30, 9:27 AM
bader committed rG7cbb916dc4c0: [NFC][SYCL] Remove unused variable (authored by bader).
[NFC][SYCL] Remove unused variable
Thu, May 30, 9:27 AM
bader committed rGc94e34782382: [SYCL] Align with recent changes in ICD loader build (authored by Vladimir Lazarev <vladimir.lazarev@intel.com>).
[SYCL] Align with recent changes in ICD loader build
Thu, May 30, 9:27 AM
bader committed rGb39e5521215a: [SPIR-V] Initial support of FPGA loop attributes/pragmas (authored by sidorovd).
[SPIR-V] Initial support of FPGA loop attributes/pragmas
Thu, May 30, 9:27 AM
bader committed rG02531c497b18: [SYCL] Fix bug in sampler implementation (authored by Fznamznon).
[SYCL] Fix bug in sampler implementation
Thu, May 30, 9:27 AM
bader committed rGc36860514c22: [SYCL] Add SYCL compiler and runtime library design document (authored by bader).
[SYCL] Add SYCL compiler and runtime library design document
Thu, May 30, 9:27 AM
bader committed rG3b0defebace6: [SYCL] Add Windows support for device_info (authored by v_klochkov).
[SYCL] Add Windows support for device_info
Thu, May 30, 9:26 AM
bader committed rG1e05d93ce91a: [SYCL] Update lgamma_r host implementation to independent of a system. (authored by Alexey Voronov <alexey.voronov@intel.com>).
[SYCL] Update lgamma_r host implementation to independent of a system.
Thu, May 30, 9:26 AM
bader committed rGaa1eb941a137: [SYCL] Change uint to uint32_t to avoid build error on Windows (authored by v_klochkov).
[SYCL] Change uint to uint32_t to avoid build error on Windows
Thu, May 30, 8:14 AM
bader committed rG828075679d7e: [SYCL] Enable swizzle_op and kernel_functor tests on non host devices. (authored by Alexey Voronov <alexey.voronov@intel.com>).
[SYCL] Enable swizzle_op and kernel_functor tests on non host devices.
Thu, May 30, 8:08 AM
bader committed rG396bc07c3d0b: [SYCL] Enable parallel build for check-* targets dependencies. (authored by bader).
[SYCL] Enable parallel build for check-* targets dependencies.
Thu, May 30, 8:08 AM
bader committed rGa96849ca1570: [SYCL] Add ND-range sub-group extension docs (authored by John Pennycook <john.pennycook@intel.com>).
[SYCL] Add ND-range sub-group extension docs
Thu, May 30, 8:08 AM
bader committed rGd3bdea1a2e9c: [SYCL] Added a constructor to local accessor, fixed accessor_impl constructors (authored by v_klochkov).
[SYCL] Added a constructor to local accessor, fixed accessor_impl constructors
Thu, May 30, 8:08 AM
bader committed rGb1c9b93295d0: [SYCL] Add support for discard access modes (authored by sidorovd).
[SYCL] Add support for discard access modes
Thu, May 30, 8:08 AM
bader committed rG848fc42758fb: Create extensions directory. Populate it with Ordered Queue and Unified Shared… (authored by jbrodman).
Create extensions directory. Populate it with Ordered Queue and Unified Shared…
Thu, May 30, 8:08 AM
bader committed rGe87838ce7191: [SYCL] Support partially linked fat objects in the bundler. (authored by kbobrovs).
[SYCL] Support partially linked fat objects in the bundler.
Thu, May 30, 8:08 AM
vladimirlaz <vladimir.lazarev@intel.com> committed rG62866cd75605: [SYCL] Remove accuracy test for native implementation of math function. (authored by bader).
[SYCL] Remove accuracy test for native implementation of math function.
Thu, May 30, 8:08 AM
vladimirlaz <vladimir.lazarev@intel.com> committed rG558e95d9e25c: [SYCL] Update build instructions after latest sync with llorg. (authored by bader).
[SYCL] Update build instructions after latest sync with llorg.
Thu, May 30, 8:06 AM
Vladimir Lazarev <vladimir.lazarev@intel.com> committed rGa99d948a57e4: [SYCL] Updated command line options for SYCL compiler. (authored by bader).
[SYCL] Updated command line options for SYCL compiler.
Thu, May 30, 8:05 AM
bader committed rGba999d3db9a3: [SYCL] Fix linking with renamed OpenCL library. (authored by bader).
[SYCL] Fix linking with renamed OpenCL library.
Thu, May 30, 8:03 AM
bader committed rG5af7aa16b532: [SYCL] Work around build issues with GCC 7+. (authored by bader).
[SYCL] Work around build issues with GCC 7+.
Thu, May 30, 8:03 AM
bader committed rGc4e068dfb52e: [SYCL][NFC] Remove a compilation warning with GCC 8.2.0 (authored by keryell).
[SYCL][NFC] Remove a compilation warning with GCC 8.2.0
Thu, May 30, 8:03 AM
bader committed rG41b10a05c0be: Reformatted "Get started guide" to simplify the reading. (authored by bader).
Reformatted "Get started guide" to simplify the reading.
Thu, May 30, 7:57 AM
bader committed rG9b838d963a68: [SYCL][NFC] Fix wrong end-of-line encoding (authored by keryell).
[SYCL][NFC] Fix wrong end-of-line encoding
Thu, May 30, 7:57 AM

Mon, May 27

bader added a comment to D60455: [SYCL] Implement SYCL device code outlining.
In D60455#1513499, @Anastasia wrote:

Design question: since you are not aware what functions are to be run on a device while parsing them, at what point do you plan to diagnose the invalid behavior from the standard C++ i.e. using function pointers in kernel code is likely to cause issues?

Mon, May 27, 7:16 AM · Restricted Project

May 22 2019

bader added inline comments to D60455: [SYCL] Implement SYCL device code outlining.
May 22 2019, 11:37 AM · Restricted Project

Apr 16 2019

bader added a comment to D60455: [SYCL] Implement SYCL device code outlining.
In D60455#1467279, @aaron.ballman wrote:
In D60455#1464324, @Fznamznon wrote:

Applied comments from @aaron.ballman and @keryell

  • Introduced a C++11 and C2x style spelling in the clang namespace. I didn't find path to add two namespaces to attribute (like [[clang::sycl::device]]) so [[clang::sycl_device]] spelling is added.
  • Since both attributes have spellings and possible can be used as some "standard" outlining in Clang/LLVM I added documetation.
  • Added more test cases.
  • As @bader mentioned sycl_device can be used to mark functions, which are called from the different translation units so I added simple handling of this attribute in Sema.

I'm confused -- I thought @bader also said "...SYCL is not supposed to expose any non-standard extensions to a user." -- these attributes are not standards based (WG21 and WG14 have nothing to say about them), so are these attributes considered "non-standard extensions" or not?

Apr 16 2019, 9:01 AM · Restricted Project
bader added a comment to D60455: [SYCL] Implement SYCL device code outlining.
In D60455#1468386, @Fznamznon wrote:

Ok, my question is whether you are planning to duplicate the same logic as for OpenCL kernel which doesn't really seem like an ideal design choice. Is this the only difference then we can simply add an extra check for SYCL compilation mode in this template handling case. The overall interaction between OpenCL and SYCL implementation is still a very big unknown to me so it's not very easy to judge about the implementations details...

Of course, if nothing prevents us to re-use OpenCL kernel attribute for SYCL I assume it would be good idea.
But I'm thinking about the situation with https://reviews.llvm.org/D60454 . If we re-use OpenCL kernel attributes - we affected by OpenCL-related changes and OpenCL-related changes shouldn't violate SYCL semantics. Will it be usable for SYCL/OpenCL clang developers? @bader , what do you think about it?

Apr 16 2019, 8:38 AM · Restricted Project

Apr 15 2019

bader accepted D60455: [SYCL] Implement SYCL device code outlining.
Apr 15 2019, 4:42 AM · Restricted Project
bader accepted D60455: [SYCL] Implement SYCL device code outlining.

LGTM. One minor comment.

Apr 15 2019, 4:34 AM · Restricted Project
bader added inline comments to D60455: [SYCL] Implement SYCL device code outlining.
Apr 15 2019, 2:47 AM · Restricted Project

Apr 12 2019

bader accepted D60455: [SYCL] Implement SYCL device code outlining.
Apr 12 2019, 7:43 AM · Restricted Project

Apr 9 2019

bader added a comment to D60455: [SYCL] Implement SYCL device code outlining.

To give more context to the question, I'd like to clarify the use case of new attributes.

Apr 9 2019, 1:51 PM · Restricted Project

Mar 25 2019

bader added inline comments to D59646: [PR40778][PR41157][OpenCL] Prevent implicit initialization of local address space objects.
Mar 25 2019, 5:50 AM · Restricted Project

Mar 24 2019

bader added inline comments to D59646: [PR40778][PR41157][OpenCL] Prevent implicit initialization of local address space objects.
Mar 24 2019, 1:40 PM · Restricted Project

Mar 19 2019

bader accepted D59544: [OpenCL] Minor improvements in default header testing.

LGTM. Thanks!

Mar 19 2019, 7:10 AM · Restricted Project

Mar 18 2019

bader accepted D59486: [OpenCL] Improve testing of default header in C++ mode.

OpenCL C++ part looks good. Thanks!

Mar 18 2019, 11:18 AM · Restricted Project