- User Since
- Apr 23 2014, 2:13 AM (335 w, 4 d)
Tue, Sep 8
Jul 29 2020
Jun 26 2020
Jun 17 2020
Jun 9 2020
Jun 5 2020
Jun 3 2020
Jun 1 2020
May 30 2020
May 29 2020
May 22 2020
May 21 2020
Fix formatting in clang/test/Sema/address_spaces.c
- Added C test case with address_space attribute.
- Move isAddressSpaceOverlapping from PointerType to QualType.
- Move C++ test case to clang/test/SemaCXX
Thanks for the review.
I've enabled the diagnostics for all the modes.
I also applied the refactoring suggested by @rjmccall. Hopefully I understand it correctly.
Enable diagnostics for non-OpenCL modes and applied refactoring proposed by John.
May 20 2020
Apr 2 2020
Mar 24 2020
Mar 12 2020
Mar 7 2020
Mar 1 2020
Feb 27 2020
Feb 22 2020
Any other comments?
Feb 20 2020
Feb 19 2020
Rebase to ToT and address comments from Ronan.
Feb 18 2020
Address comments from Victor and Alexey.
Feb 17 2020
Feb 11 2020
Applied review commits from Alexey.
Feb 7 2020
Applied code review comments.
Feb 6 2020
Ignore -sycl-std if it used in non-SYCL mode.
Applied Alexey's comments.
Applied suggestions from Alexey and Ruyman and rebased on ToT.
Feb 5 2020
Refactor clang/lib/Driver/ToolChains/Clang.cpp in accordance with Alexey's suggestion.
Thanks for the prompt review.
I've applied your suggestions.
Applied suggestions from Alexey
Rebased on ToT.
Feb 3 2020
Feb 1 2020
Fix clang-format and clang-tidy issues reported by merge_guards_bot
Jan 31 2020
Applied suggestion from Ruyman.
Jan 30 2020
@lebedev.ri, thanks for the suggestion. We will investigate this option when we ready to upload clang diagnostics patch.
Jan 29 2020
Jan 22 2020
Maybe we should use the year of issue (2015 instead of 1.2.1) for the -sycl-std version? That would be more stable for the upcoming SYCL versions, and match somehow the C++ versioning.
Jan 21 2020
Jan 16 2020
Jan 14 2020
Jan 13 2020
Does it make sense to implement such diagnostics in clang Sema, considering that OpenCL does not allow recursion?
We implemented similar diagnostics for SYCL programming model and would be like to upstream it to clang later (https://github.com/intel/llvm/commit/4efe9fcf2dc6f6150b5b477b0f8320ea13a7f596). Can we somehow leverage this work for the compiler?
Dec 28 2019
Dec 12 2019
Dec 11 2019
LGTM, but I'd like someone who works on OpenCL front-end to approve.
Added LIT test.
Dec 10 2019
I'm looking for test suggestions as I was not able to find tests covering similar changes for OpenMP compiler.
Dec 6 2019
@aaron.ballman, thank you for fixing the problem with documentation generation.
Dec 5 2019
is there a reason this should be clang::opencl_private as opposed to opencl::private?
I'm okay with [[opencl::private]] as well. I have only one problem - currently OpenCL address spaces are exposed as keywords and using them in C++ breaks valid C++ code.
I'm not certain who controls the OpenCL spec, but this seems like it should be a decision that comes from there. Or is this functionality outside of the OpenCL spec?