Page MenuHomePhabricator

bader (Alexey Bader)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 23 2014, 2:13 AM (300 w, 5 d)

Recent Activity

Wed, Jan 22

bader added a comment to D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version.

Maybe we should use the year of issue (2015 instead of 1.2.1) for the -sycl-std version? That would be more stable for the upcoming SYCL versions, and match somehow the C++ versioning.

Wed, Jan 22, 5:02 AM · Restricted Project

Tue, Jan 21

bader committed rGdd18729b2a7a: [Attr][Doc][NFC] Fix code snippet formatting for attribute documentation (authored by bader).
[Attr][Doc][NFC] Fix code snippet formatting for attribute documentation
Tue, Jan 21, 10:39 AM
bader closed D73104: [Attr][Doc][NFC] Fix code snippet formatting for attribute documentation.
Tue, Jan 21, 10:39 AM · Restricted Project
bader created D73104: [Attr][Doc][NFC] Fix code snippet formatting for attribute documentation.
Tue, Jan 21, 6:57 AM · Restricted Project

Thu, Jan 16

bader created D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version.
Thu, Jan 16, 10:13 AM · Restricted Project

Tue, Jan 14

bader updated subscribers of D72362: [clang-tidy] misc-no-recursion: a new check.

Does it make sense to implement such diagnostics in clang Sema, considering that OpenCL does not allow recursion?
We implemented similar diagnostics for SYCL programming model and would be like to upstream it to clang later (https://github.com/intel/llvm/commit/4efe9fcf2dc6f6150b5b477b0f8320ea13a7f596). Can we somehow leverage this work for the compiler?

Implementing it elsewhere will be more restrictive in the future - somehow i suspect
it will be easier to make clang-tidy CTU-aware rather than clang sema.

That being said, is SYCL inherently single-TU, does it not support
linking multiple separately compiled object files together?

Tue, Jan 14, 4:09 AM · Restricted Project, Restricted Project

Mon, Jan 13

bader added a comment to D72362: [clang-tidy] misc-no-recursion: a new check.

Does it make sense to implement such diagnostics in clang Sema, considering that OpenCL does not allow recursion?
We implemented similar diagnostics for SYCL programming model and would be like to upstream it to clang later (https://github.com/intel/llvm/commit/4efe9fcf2dc6f6150b5b477b0f8320ea13a7f596). Can we somehow leverage this work for the compiler?

Mon, Jan 13, 10:44 AM · Restricted Project, Restricted Project

Sat, Dec 28

bader committed rG128f39da932b: Fix crash in getFullyQualifiedName for inline namespace (authored by bader).
Fix crash in getFullyQualifiedName for inline namespace
Sat, Dec 28, 8:43 AM
bader closed D71962: Fix crash in getFullyQualifiedName for inline namespace.
Sat, Dec 28, 8:43 AM · Restricted Project
bader created D71962: Fix crash in getFullyQualifiedName for inline namespace.
Sat, Dec 28, 8:29 AM · Restricted Project

Dec 12 2019

bader committed rG2d6a5e4fe45d: [OpenMP][Test] Add check for aux-triple predefined macros (authored by bader).
[OpenMP][Test] Add check for aux-triple predefined macros
Dec 12 2019, 6:42 AM
bader closed D71413: [OpenMP][Test] Add check for aux-triple predefined macros.
Dec 12 2019, 6:42 AM · Restricted Project
bader created D71413: [OpenMP][Test] Add check for aux-triple predefined macros.
Dec 12 2019, 5:01 AM · Restricted Project

Dec 11 2019

bader updated subscribers of D71272: [OpenCL] Pretty print __private addr space.

LGTM, but I'd like someone who works on OpenCL front-end to approve.
+@AlexeySotkin

Dec 11 2019, 5:59 AM · Restricted Project
bader committed rGcb30ad728f0b: [SYCL] Add support for auxiliary triple specification to Frontend (authored by bader).
[SYCL] Add support for auxiliary triple specification to Frontend
Dec 11 2019, 4:55 AM
bader closed D71286: [SYCL] Add support for auxiliary triple specification to Frontend.
Dec 11 2019, 4:55 AM · Restricted Project
bader updated the diff for D71286: [SYCL] Add support for auxiliary triple specification to Frontend.

Added LIT test.

Dec 11 2019, 3:13 AM · Restricted Project

Dec 10 2019

bader added a comment to D71286: [SYCL] Add support for auxiliary triple specification to Frontend.

Most probably, just missed the testing of the frontend part here

Dec 10 2019, 10:55 AM · Restricted Project
bader created D71286: [SYCL] Add support for auxiliary triple specification to Frontend.
Dec 10 2019, 10:37 AM · Restricted Project
bader added a comment to D71286: [SYCL] Add support for auxiliary triple specification to Frontend.

I'm looking for test suggestions as I was not able to find tests covering similar changes for OpenMP compiler.

Dec 10 2019, 10:37 AM · Restricted Project

Dec 6 2019

bader added a comment to D71005: [AST] Enable expression of OpenCL language address spaces an attribute.

@aaron.ballman, thank you for fixing the problem with documentation generation.

Dec 6 2019, 10:12 AM · Restricted Project

Dec 5 2019

bader added a comment to D71005: [AST] Enable expression of OpenCL language address spaces an attribute.

is there a reason this should be clang::opencl_private as opposed to opencl::private?

I'm okay with [[opencl::private]] as well. I have only one problem - currently OpenCL address spaces are exposed as keywords and using them in C++ breaks valid C++ code.

I'm not certain who controls the OpenCL spec, but this seems like it should be a decision that comes from there. Or is this functionality outside of the OpenCL spec?

Dec 5 2019, 6:58 AM · Restricted Project
bader added inline comments to D71005: [AST] Enable expression of OpenCL language address spaces an attribute.
Dec 5 2019, 5:07 AM · Restricted Project
bader committed rG11a9bae8f669: [AST] Enable expression of OpenCL language address spaces an attribute (authored by Naghasan).
[AST] Enable expression of OpenCL language address spaces an attribute
Dec 5 2019, 4:49 AM
bader closed D71005: [AST] Enable expression of OpenCL language address spaces an attribute.
Dec 5 2019, 4:48 AM · Restricted Project
bader added a comment to D71005: [AST] Enable expression of OpenCL language address spaces an attribute.

LGTM! Thanks!

I presume OpenCL addr space logic won't apply in all cases in non-OpenCL compilations i.e. for example C++ because we enclose some of the logic under LangOpts checks.

Dec 5 2019, 3:16 AM · Restricted Project

Dec 4 2019

bader added inline comments to D71005: [AST] Enable expression of OpenCL language address spaces an attribute.
Dec 4 2019, 5:39 AM · Restricted Project
bader updated the diff for D71005: [AST] Enable expression of OpenCL language address spaces an attribute.

Change attribute prefix: ocl_ -> opencl_.

Dec 4 2019, 5:39 AM · Restricted Project
bader created D71005: [AST] Enable expression of OpenCL language address spaces an attribute.
Dec 4 2019, 4:43 AM · Restricted Project

Dec 3 2019

bader committed rGc094e7dc4b3f: [SYCL] Add sycl_kernel attribute for accelerated code outlining (authored by Fznamznon).
[SYCL] Add sycl_kernel attribute for accelerated code outlining
Dec 3 2019, 8:23 AM
bader closed D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Dec 3 2019, 8:23 AM · Restricted Project

Dec 2 2019

bader added a comment to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

I hope all comments from are @Fznamznon and @aaron.ballman are applied.
@ABataev, do you have any other comments?

Dec 2 2019, 5:06 AM · Restricted Project
bader updated the diff for D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

Fixed SYCL code example for sycl_kernel attribute documentation and commit message.

Dec 2 2019, 5:06 AM · Restricted Project
bader updated the diff for D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

Applied @aaron.ballman suggestions to kernel-attribute.cpp test

Dec 2 2019, 12:24 AM · Restricted Project
bader added inline comments to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Dec 2 2019, 12:24 AM · Restricted Project

Nov 30 2019

bader updated the diff for D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

Applied comments from @Fznamznon.

Nov 30 2019, 12:40 PM · Restricted Project

Nov 29 2019

bader updated the diff for D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

Minor update adjusting to the recent changes.

Nov 29 2019, 2:43 AM · Restricted Project

Nov 28 2019

bader added a comment to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

Sorry, I don't have capacity currently to review this and I don't want to be blocking it either.

Nov 28 2019, 3:39 AM · Restricted Project
bader updated the diff for D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

Fixed typo in the commit message: complier -> compiler.

Nov 28 2019, 3:06 AM · Restricted Project
bader retitled D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining from [SYCL] Implement SYCL device code outlining to [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Nov 28 2019, 3:05 AM · Restricted Project
bader updated the diff for D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

Applied code review suggestions.

Nov 28 2019, 2:41 AM · Restricted Project

Nov 27 2019

bader added inline comments to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Nov 27 2019, 9:22 AM · Restricted Project
bader added inline comments to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Nov 27 2019, 7:31 AM · Restricted Project
bader added a comment to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

Ping.

Nov 27 2019, 2:13 AM · Restricted Project

Nov 20 2019

bader added inline comments to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Nov 20 2019, 12:33 PM · Restricted Project
bader updated the diff for D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

Applied code review comments from Aaron.

Nov 20 2019, 12:20 PM · Restricted Project
bader added inline comments to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Nov 20 2019, 9:56 AM · Restricted Project
bader updated subscribers of D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Nov 20 2019, 9:26 AM · Restricted Project
bader updated the diff for D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

Applied code review comments.

Nov 20 2019, 9:26 AM · Restricted Project

Nov 19 2019

bader added a comment to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

@aaron.ballman, @Anastasia, could you take a look at new version of the patch, please?

Nov 19 2019, 6:02 AM · Restricted Project

Nov 12 2019

bader added inline comments to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Nov 12 2019, 4:38 AM · Restricted Project
bader updated the diff for D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

Applied two remaining comments from Aaron.

Nov 12 2019, 4:37 AM · Restricted Project

Nov 7 2019

bader commandeered D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Nov 7 2019, 12:04 PM · Restricted Project
bader added inline comments to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.
Nov 7 2019, 11:55 AM · Restricted Project
bader updated the diff for D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

Applied comments from Aaron.

Nov 7 2019, 11:53 AM · Restricted Project
bader added a comment to D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining.

Thanks a lot for the comments and sorry for the long delay. We've been working on complete implementation of the SYCL 1.2.1 specification.
Now I have more time to work on contributing the implementation to LLVM project.

Nov 7 2019, 3:35 AM · Restricted Project

Aug 20 2019

bader accepted D66512: [OpenCL] Fix declaration of enqueue_marker.
Aug 20 2019, 11:40 PM · Restricted Project

Jul 12 2019

bader committed rG07cbeaa118e8: [LIT] Emit timeout error message only if timeout was reached (authored by bader).
[LIT] Emit timeout error message only if timeout was reached
Jul 12 2019, 5:49 AM
bader committed rL365895: [LIT] Emit timeout error message only if timeout was reached.
[LIT] Emit timeout error message only if timeout was reached
Jul 12 2019, 5:48 AM
bader closed D64240: [LIT] emit timeout error message only if timeout was reached.
Jul 12 2019, 5:48 AM · Restricted Project

Jun 24 2019

bader committed rG439073351855: [SYCL] Fix cl::sycl::group get_linear_id API name. (authored by kbobrovs).
[SYCL] Fix cl::sycl::group get_linear_id API name.
Jun 24 2019, 12:02 PM
bader committed rGdc5124090d8c: [SYCL][NFC] Refactor common code into a helper function (authored by AlexeySachkov).
[SYCL][NFC] Refactor common code into a helper function
Jun 24 2019, 12:02 PM
bader committed rGc05692e52402: [SYCL] Remove outdated CMake configuration. (authored by bader).
[SYCL] Remove outdated CMake configuration.
Jun 24 2019, 12:02 PM
bader committed rG4c58035060a4: [SYCL] Avoid declaring unscoped enums in global namespace (authored by AlexeySachkov).
[SYCL] Avoid declaring unscoped enums in global namespace
Jun 24 2019, 12:02 PM
bader committed rG07358ac176ec: [SYCL] Update documents with recent project changes (authored by Vladimir Lazarev <vladimir.lazarev@intel.com>).
[SYCL] Update documents with recent project changes
Jun 24 2019, 12:02 PM
bader committed rG3f6c35322964: [Buildbot] migrate build script from shell to python (authored by Kurt Chen <kurt.chen@intel.com>).
[Buildbot] migrate build script from shell to python
Jun 24 2019, 12:02 PM
bader committed rGc191009f536a: [SYCL] Temporary disable stream LIT test. (authored by romanovvlad).
[SYCL] Temporary disable stream LIT test.
Jun 24 2019, 12:02 PM
bader committed rGfa4ba4c1b155: [SYCL] Refactor OpenCL kernel generation (#227) (authored by Fznamznon).
[SYCL] Refactor OpenCL kernel generation (#227)
Jun 24 2019, 12:02 PM
bader committed rGe844b0c3ad24: [SYCL][NFC] Remove dead code (#230) (authored by v-klochkov <34946562+v-klochkov@users.noreply.github.com>).
[SYCL][NFC] Remove dead code (#230)
Jun 24 2019, 12:02 PM
bader committed rGb2248cce1db3: [SYCL] Add ND-range reduction extension docs (#211) (authored by John Pennycook <john.pennycook@intel.com>).
[SYCL] Add ND-range reduction extension docs (#211)
Jun 24 2019, 12:02 PM
bader committed rG57ee6e1ddfe7: [SYCL] Remove wrapper headers (authored by ArturGainullin).
[SYCL] Remove wrapper headers
Jun 24 2019, 12:02 PM
bader committed rG2c9ab05ee71d: [SYCL] Retain OpenCL kernel in SYCL kernel constructor (authored by Fznamznon).
[SYCL] Retain OpenCL kernel in SYCL kernel constructor
Jun 24 2019, 12:01 PM
bader committed rG54e4ecba2912: fix typo (authored by jeffhammond).
fix typo
Jun 24 2019, 12:01 PM
bader committed rG6b8be71c6397: [SYCL] Fix warning in half implementation (authored by Fznamznon).
[SYCL] Fix warning in half implementation
Jun 24 2019, 12:01 PM
bader committed rGdba5f18c0daf: [SYCL] Enable set_final_data for shared_ptr (authored by Vladimir Lazarev <vladimir.lazarev@intel.com>).
[SYCL] Enable set_final_data for shared_ptr
Jun 24 2019, 12:01 PM
bader committed rG9ff0401eed03: [SYCL] Minor fixes after stream class implementation. (authored by ArturGainullin).
[SYCL] Minor fixes after stream class implementation.
Jun 24 2019, 12:01 PM
bader committed rG9ceb9e26498c: [SYCL] Check return of Expected<T> when reading section size content (authored by Michael D Toguchi <michael.d.toguchi@intel.com>).
[SYCL] Check return of Expected<T> when reading section size content
Jun 24 2019, 12:01 PM
bader committed rG65408104f89a: [SYCL] Stream class (authored by ArturGainullin).
[SYCL] Stream class
Jun 24 2019, 12:01 PM
bader committed rGbc8c55cd897d: [SYCL] Align global_mem_cache_type values with SYCL specification. (authored by romanovvlad).
[SYCL] Align global_mem_cache_type values with SYCL specification.
Jun 24 2019, 12:01 PM
bader committed rGf4a5a632b7e8: [SYCL] Release notes for June'19 release. (authored by romanovvlad).
[SYCL] Release notes for June'19 release.
Jun 24 2019, 12:01 PM
bader committed rG76cd23df67f8: [SYCL] Fix build after old scheduler removal (authored by ArturGainullin).
[SYCL] Fix build after old scheduler removal
Jun 24 2019, 12:01 PM
bader committed rGeb735eeb9d6b: [SYCL] Enable OpenCL diagnostics for sampler in SYCL mode (authored by bader).
[SYCL] Enable OpenCL diagnostics for sampler in SYCL mode
Jun 24 2019, 12:01 PM
bader committed rG208cd7c57ecc: [SYCL] Update documentation with OpenCL types re-use proposal (authored by bader).
[SYCL] Update documentation with OpenCL types re-use proposal
Jun 24 2019, 12:01 PM
bader committed rGda9bdd33b2c7: [SYCL][NFC] Remove code from comments. (authored by bader).
[SYCL][NFC] Remove code from comments.
Jun 24 2019, 12:01 PM
bader committed rG2e480815cb62: [SYCL] Enable sampler support in set_arg(s) method. (authored by Alexey Voronov <alexey.voronov@intel.com>).
[SYCL] Enable sampler support in set_arg(s) method.
Jun 24 2019, 12:01 PM
bader committed rG76bb25938280: [SYCL] Remove old scheduler (authored by ArturGainullin).
[SYCL] Remove old scheduler
Jun 24 2019, 12:01 PM
bader committed rGa7188719f29d: [SYCL] Add /bigobj switch to SemaSYCL.cpp on Windows to enable DEBUG build (authored by v_klochkov).
[SYCL] Add /bigobj switch to SemaSYCL.cpp on Windows to enable DEBUG build
Jun 24 2019, 12:00 PM
bader committed rG5a3a030fe868: [SYCL] Sync with SPIRV-LLVM-Translator 365675f2 (authored by AlexeySachkov).
[SYCL] Sync with SPIRV-LLVM-Translator 365675f2
Jun 24 2019, 12:00 PM
bader committed rGa72d544791c8: [SYCL] Refactor SYCL clang kernel wrapper tests (authored by Fznamznon).
[SYCL] Refactor SYCL clang kernel wrapper tests
Jun 24 2019, 12:00 PM
bader committed rG1614b8f91cce: [SYCL] Add SYCL clang frontend doc (authored by Fznamznon).
[SYCL] Add SYCL clang frontend doc
Jun 24 2019, 12:00 PM
bader committed rG9079001c37bf: [SYCL] Include <algorithm> for std::max, define M_PI macro in builtins (authored by v_klochkov).
[SYCL] Include <algorithm> for std::max, define M_PI macro in builtins
Jun 24 2019, 12:00 PM
bader committed rG33fabc41f73d: [SYCL] Fix vec and SwizzleOp types on Windows (authored by v_klochkov).
[SYCL] Fix vec and SwizzleOp types on Windows
Jun 24 2019, 12:00 PM
bader committed rG5adefa389125: [SYCL] Clean up in swizzle macros, prepare them for change of Indexer (authored by v_klochkov).
[SYCL] Clean up in swizzle macros, prepare them for change of Indexer
Jun 24 2019, 12:00 PM
bader committed rG5713c578ca11: [SYCL][FPGA] Add 'SYCL' lang prefix for loop attributes (authored by sidorovd).
[SYCL][FPGA] Add 'SYCL' lang prefix for loop attributes
Jun 24 2019, 12:00 PM
bader committed rG637c69b54aa5: [SYCL][NFC] Add 2 private aux types to SwizzleOp class (authored by v_klochkov).
[SYCL][NFC] Add 2 private aux types to SwizzleOp class
Jun 24 2019, 12:00 PM
bader committed rG8d186a3f7e3e: [SYCL] Remove _Float16 from integration header (authored by Fznamznon).
[SYCL] Remove _Float16 from integration header
Jun 24 2019, 11:59 AM
bader committed rG4d847c083831: [SYCL] Remove redundant code (authored by Fznamznon).
[SYCL] Remove redundant code
Jun 24 2019, 11:59 AM
bader committed rG505e19553975: [SYCL] Fix errors caused by unsupported __builtin_expect() on Windows (authored by v_klochkov).
[SYCL] Fix errors caused by unsupported __builtin_expect() on Windows
Jun 24 2019, 11:59 AM
bader committed rG2dffc683b9d5: [SYCL][Driver]Offloader][Test] Add test case to sycl-offload.c (authored by agozillon).
[SYCL][Driver]Offloader][Test] Add test case to sycl-offload.c
Jun 24 2019, 11:56 AM
bader committed rG23fd38bbdf83: [SYCL][Driver][Offloader][NFC] Moving invalid SYCL target diagnostic (authored by agozillon).
[SYCL][Driver][Offloader][NFC] Moving invalid SYCL target diagnostic
Jun 24 2019, 11:56 AM