This is an archive of the discontinued LLVM Phabricator instance.

[llvm-readobj] Use a helper to extract the Other Flags from symbols
ClosedPublic

Authored by paulkirth on Oct 31 2022, 10:47 AM.

Details

Summary

Since all ELFDumper implementations will require the same logic when
dealing with Other Flags, we move the logic into a helper so that it can
be easily reused across implementations.

Diff Detail

Event Timeline

paulkirth created this revision.Oct 31 2022, 10:47 AM
Herald added a project: Restricted Project. · View Herald Transcript
paulkirth requested review of this revision.Oct 31 2022, 10:47 AM
jhenderson accepted this revision.Nov 1 2022, 1:30 AM

Looks good. Please change the tag to llvm-readobj in the commit title.

This revision is now accepted and ready to land.Nov 1 2022, 1:30 AM
paulkirth updated this revision to Diff 472688.Nov 2 2022, 10:46 AM
paulkirth retitled this revision from [readobj] Factor out common ELF code into a helper to [llvm-readobj] Use a helper to extract the Other Flags from symbols.
paulkirth edited the summary of this revision. (Show Details)

Move change higher in the stack and update the description

jhenderson added inline comments.Feb 24 2023, 12:32 AM
llvm/tools/llvm-readobj/ELFDumper.cpp
3255

Whilst moving this line, please fix the "Somones" typo (it should be "Someone").

3256

Same logic as above.

paulkirth updated this revision to Diff 500333.Feb 24 2023, 4:53 PM
paulkirth marked 2 inline comments as done.

Rebase and fix typos in comments.

jhenderson accepted this revision.Mar 1 2023, 12:44 AM

LGTM again.