Page MenuHomePhabricator
Differential D137092

[llvm-readobj] Use a helper to extract the Other Flags from symbols
ClosedPublic
Actions

Authored by paulkirth on Oct 31 2022, 10:47 AM.

Details

Reviewers
jhenderson
Commits
rG552b1b3c44d1: [llvm-readobj] Use a helper to extract the Other Flags from symbols
Summary

Since all ELFDumper implementations will require the same logic when
dealing with Other Flags, we move the logic into a helper so that it can
be easily reused across implementations.

Diff Detail

Event Timeline

paulkirth created this revision.Oct 31 2022, 10:47 AM
Herald added a reviewer: jhenderson. · View Herald TranscriptOct 31 2022, 10:47 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: s.egerton, simoncook. · View Herald Transcript
paulkirth requested review of this revision.Oct 31 2022, 10:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2022, 10:47 AM
Herald added subscribers: llvm-commits, pcwang-thead, MaskRay. · View Herald Transcript
paulkirth added a child revision: D137094: [llvm-readobj] Fix "Section" output when emitting relocations in JSON.Oct 31 2022, 10:52 AM
Harbormaster completed remote builds in B195303: Diff 472068.Oct 31 2022, 11:59 AM
jhenderson accepted this revision.Nov 1 2022, 1:30 AM

Looks good. Please change the tag to llvm-readobj in the commit title.

This revision is now accepted and ready to land.Nov 1 2022, 1:30 AM
paulkirth updated this revision to Diff 472688.Nov 2 2022, 10:46 AM
paulkirth retitled this revision from [readobj] Factor out common ELF code into a helper to [llvm-readobj] Use a helper to extract the Other Flags from symbols.
paulkirth edited the summary of this revision. (Show Details)

Move change higher in the stack and update the description

Harbormaster completed remote builds in B195756: Diff 472688.Nov 2 2022, 12:16 PM
paulkirth removed a parent revision: D137091: [llvm-readobj] Rename JSON Flag fields to be more consistent.Nov 2 2022, 1:44 PM
Prabhuk added a subscriber: Prabhuk.Nov 15 2022, 12:21 PM
paulkirth added a child revision: D137088: [llvm-readobj] Standardize JSON output for `Other` field.Dec 7 2022, 4:48 PM
paulkirth updated this revision to Diff 484099.Dec 19 2022, 3:04 PM

Rebase

paulkirth updated this revision to Diff 484106.Dec 19 2022, 3:31 PM

Rebase

Harbormaster completed remote builds in B204036: Diff 484106.Dec 19 2022, 5:40 PM
paulkirth updated this revision to Diff 492284.Jan 25 2023, 4:11 PM

Rebase.

paulkirth removed a child revision: D137094: [llvm-readobj] Fix "Section" output when emitting relocations in JSON.Jan 25 2023, 4:34 PM
Harbormaster completed remote builds in B209999: Diff 492284.Jan 25 2023, 6:07 PM
paulkirth updated this revision to Diff 496194.Feb 9 2023, 11:30 AM

Rebase.

Harbormaster completed remote builds in B212864: Diff 496194.Feb 9 2023, 12:37 PM
jhenderson added inline comments.Fri, Feb 24, 12:32 AM
llvm/tools/llvm-readobj/ELFDumper.cpp
3260

Whilst moving this line, please fix the "Somones" typo (it should be "Someone").

3261

Same logic as above.

paulkirth updated this revision to Diff 500333.Fri, Feb 24, 4:53 PM
paulkirth marked 2 inline comments as done.

Rebase and fix typos in comments.

Harbormaster completed remote builds in B215857: Diff 500333.Sat, Feb 25, 2:15 AM
jhenderson accepted this revision.Wed, Mar 1, 12:44 AM

LGTM again.

paulkirth updated this revision to Diff 502288.Fri, Mar 3, 3:59 PM

Rebase

Harbormaster completed remote builds in B217296: Diff 502288.Fri, Mar 3, 5:55 PM
Closed by commit rG552b1b3c44d1: [llvm-readobj] Use a helper to extract the Other Flags from symbols (authored by paulkirth). · Explain WhyFri, Mar 17, 4:30 PM
This revision was automatically updated to reflect the committed changes.
paulkirth added a commit: rG552b1b3c44d1: [llvm-readobj] Use a helper to extract the Other Flags from symbols.

Revision Contents
Changeset List

PathSize
llvm/
tools/
llvm-readobj/
82 lines

Diff 472068

View Options

llvm/tools/llvm-readobj/ELFDumper.cpp

Loading...