Details

Reviewers

asb
craig.topper
reames

Commits

rGf4c887c3a840: [RISCV] Add H extension

Summary

h was the prefix of multi-letter extension name, but it become a
extension name in later RISC-V isa spec.

Fortunately we don't have any extension really defined is prefixed
with h, so we can just change that.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

kito-cheng created this revision.Oct 26 2022, 11:27 PM

Herald added a project: Restricted Project. · View Herald TranscriptOct 26 2022, 11:27 PM

Herald added subscribers: sunshaoce, VincentWu, StephenFan and 28 others. · View Herald Transcript

kito-cheng requested review of this revision.Oct 26 2022, 11:27 PM

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 26 2022, 11:27 PM

Herald added subscribers: llvm-commits, cfe-commits, pcwang-thead and 2 others. · View Herald Transcript

Harbormaster completed remote builds in B194562: Diff 471032.Oct 26 2022, 11:28 PM

kito-cheng added a parent revision: D136812: [RISCV] Drop single letter b extension support.Oct 26 2022, 11:28 PM

Thanks for this patch Kito - I'm thinking that perhaps we erred in not treating the hypervisor instructions (e.g. HLV* and HSV*) as being gated on the H extension, so a sensible follow-on to this patch would be to mark those instructions as requiring FeatureStdExtH - what do you think?

Let me do that within this patch :)

Update instructions which are belong H extension now.

kito-cheng added inline comments.Oct 27 2022, 8:48 PM

llvm/test/MC/RISCV/rvi-aliases-valid.s
270	Note: Those testcase are moved to `rv32ih-aliases-valid.s`, not just removed.

Harbormaster completed remote builds in B194824: Diff 471386.Oct 27 2022, 9:36 PM

reames added inline comments.Oct 28 2022, 8:32 AM

llvm/docs/RISCVUsage.rst
54	If I'm reading the code right here, we only have assembly support here. Given that, shouldn't this be Assembly Support?

Changes:

Update doc, H is support assembly only.

kito-cheng marked an inline comment as done.Oct 28 2022, 6:53 PM

kito-cheng added inline comments.

llvm/docs/RISCVUsage.rst
54	Corrected, thanks :)

Harbormaster completed remote builds in B195049: Diff 471701.Oct 28 2022, 7:40 PM

ping :)

Thanks Kito, I think my only remaining request would be to add at least some test coverage for using a H extensions when h isn't included in the ISA string. I don't think such tests are handled very cleanly or consistently right now, but adding something to rv32i-invalid.s alongside similar checks would be better than nothing.

Changes:

Rebase to main
Add negative test.

Harbormaster completed remote builds in B204970: Diff 485360.Dec 27 2022, 2:14 AM

ping :)

LGTM

This revision is now accepted and ready to land.Jan 9 2023, 8:27 AM

This revision was landed with ongoing or failed builds.Mon, Jan 9, 5:52 PM

Closed by commit rGf4c887c3a840: [RISCV] Add H extension (authored by kito-cheng). · Explain Why

This revision was automatically updated to reflect the committed changes.

kito-cheng added a commit: rGf4c887c3a840: [RISCV] Add H extension.

[RISCV] Add H extension
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 487624

clang/test/Preprocessor/riscv-target-features.c

llvm/docs/RISCVUsage.rst

llvm/lib/Support/RISCVISAInfo.cpp

llvm/lib/Target/RISCV/RISCV.td

llvm/lib/Target/RISCV/RISCVInstrInfo.td

llvm/test/CodeGen/RISCV/attributes.ll

llvm/test/MC/RISCV/priv-aliases-valid.s

llvm/test/MC/RISCV/priv-rv64-valid.s

llvm/test/MC/RISCV/priv-valid.s

llvm/test/MC/RISCV/rv32h-invalid.s

llvm/test/MC/RISCV/rv32ih-aliases-valid.s

llvm/test/MC/RISCV/rv32ih-valid.s

llvm/test/MC/RISCV/rv64h-invalid.s

llvm/test/MC/RISCV/rv64ih-valid.s

llvm/test/MC/RISCV/rvi-aliases-valid.s

[RISCV] Add H extensionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 487624

clang/test/Preprocessor/riscv-target-features.c

llvm/docs/RISCVUsage.rst

llvm/lib/Support/RISCVISAInfo.cpp

llvm/lib/Target/RISCV/RISCV.td

llvm/lib/Target/RISCV/RISCVInstrInfo.td

llvm/test/CodeGen/RISCV/attributes.ll

llvm/test/MC/RISCV/priv-aliases-valid.s

llvm/test/MC/RISCV/priv-rv64-valid.s

llvm/test/MC/RISCV/priv-valid.s

llvm/test/MC/RISCV/rv32h-invalid.s

llvm/test/MC/RISCV/rv32ih-aliases-valid.s

llvm/test/MC/RISCV/rv32ih-valid.s

llvm/test/MC/RISCV/rv64h-invalid.s

llvm/test/MC/RISCV/rv64ih-valid.s

llvm/test/MC/RISCV/rvi-aliases-valid.s

[RISCV] Add H extension
ClosedPublic
Actions

Revision Contents
Changeset List