This is an archive of the discontinued LLVM Phabricator instance.

Differential D135935

[X86] Add WRMSRNS instructions.
ClosedPublic

Authored by FreddyYe on Oct 13 2022, 8:05 PM.

Details

Reviewers
RKSimon
pengfei
LuoYuanke
skan
craig.topper
Commits
rG3ee58e2f355f: [X86] Add WRMSRNS instructions.
Summary

For more details about these instructions, please refer to the latest ISE document: https://www.intel.com/content/www/us/en/develop/download/intel-architecture-instruction-set-extensions-programming-reference.html

Diff Detail

Event Timeline

FreddyYe created this revision.Oct 13 2022, 8:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2022, 8:05 PM
Herald added subscribers: pengfei, hiraditya. · View Herald Transcript
FreddyYe requested review of this revision.Oct 13 2022, 8:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2022, 8:05 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
FreddyYe retitled this revision from Add WRMSRNS instructions. to [X86] Add WRMSRNS instructions..Oct 13 2022, 8:16 PM
FreddyYe added reviewers: RKSimon, pengfei, LuoYuanke, skan.Oct 13 2022, 8:31 PM
Harbormaster completed remote builds in B192108: Diff 467670.Oct 13 2022, 9:02 PM
RKSimon added inline comments.Oct 14 2022, 1:21 AM
llvm/docs/ReleaseNotes.rst
139

"Add support for the `WRMSRNS` instruction"?

FreddyYe updated this revision to Diff 468389.Oct 17 2022, 6:48 PM
FreddyYe marked an inline comment as done.

Address comment.

FreddyYe updated this revision to Diff 468390.Oct 17 2022, 6:53 PM

Add ``

craig.topper accepted this revision.Oct 17 2022, 7:02 PM
craig.topper added a subscriber: craig.topper.

LGTM

This revision is now accepted and ready to land.Oct 17 2022, 7:02 PM
Herald added a subscriber: StephenFan. · View Herald TranscriptOct 17 2022, 7:02 PM
Harbormaster completed remote builds in B192632: Diff 468390.Oct 17 2022, 7:34 PM
Closed by commit rG3ee58e2f355f: [X86] Add WRMSRNS instructions. (authored by FreddyYe). · Explain WhyOct 18 2022, 10:06 PM
This revision was automatically updated to reflect the committed changes.
FreddyYe added a commit: rG3ee58e2f355f: [X86] Add WRMSRNS instructions..

Revision Contents

PathSize
llvm/
docs/
1 line
lib/
Target/
X86/
2 lines
test/
MC/
Disassembler/
X86/
8 lines
X86/
8 lines

Diff 468782

llvm/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
* For MinGW, generate embedded ``-exclude-symbols:`` directives for symbols * For MinGW, generate embedded ``-exclude-symbols:`` directives for symbols
with hidden visibility, omitting them from automatic export of all symbols. with hidden visibility, omitting them from automatic export of all symbols.
This roughly makes hidden visibility work like it does for other object This roughly makes hidden visibility work like it does for other object
file formats. file formats.
Changes to the X86 Backend Changes to the X86 Backend
-------------------------- --------------------------
* Add support for the ``RDMSRLIST and WRMSRLIST`` instructions. * Add support for the ``RDMSRLIST and WRMSRLIST`` instructions.
RKSimonUnsubmitted
Done
ReplyInline Actions

"Add support for the `WRMSRNS` instruction"?

RKSimon: "Add support for the ``WRMSRNS`` instruction"?
* Add support for the ``WRMSRNS`` instruction.
Changes to the OCaml bindings Changes to the OCaml bindings
----------------------------- -----------------------------
Changes to the C API Changes to the C API
-------------------- --------------------
▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines

llvm/lib/Target/X86/X86InstrSystem.td

Show First 20 Lines • Show All 419 Lines • ▼ Show 20 Linesdef LLDT16m : I<0x00, MRM2m, (outs), (ins i16mem:$src),
"lldt{w}\t$src", []>, TB, NotMemoryFoldable; "lldt{w}\t$src", []>, TB, NotMemoryFoldable;
} // SchedRW } // SchedRW
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Specialized register support // Specialized register support
let SchedRW = [WriteSystem] in { let SchedRW = [WriteSystem] in {
let Uses = [EAX, ECX, EDX] in let Uses = [EAX, ECX, EDX] in
def WRMSR : I<0x30, RawFrm, (outs), (ins), "wrmsr", []>, TB; def WRMSR : I<0x30, RawFrm, (outs), (ins), "wrmsr", []>, TB;
let Uses = [EAX, ECX, EDX] in
def WRMSRNS : I<0x01, MRM_C6, (outs), (ins), "wrmsrns", []>, PS;
let Defs = [EAX, EDX], Uses = [ECX] in let Defs = [EAX, EDX], Uses = [ECX] in
def RDMSR : I<0x32, RawFrm, (outs), (ins), "rdmsr", []>, TB; def RDMSR : I<0x32, RawFrm, (outs), (ins), "rdmsr", []>, TB;
let Uses = [RSI, RDI, RCX], Predicates = [In64BitMode] in { let Uses = [RSI, RDI, RCX], Predicates = [In64BitMode] in {
def WRMSRLIST : I<0x01, MRM_C6, (outs), (ins), "wrmsrlist", []>, XS; def WRMSRLIST : I<0x01, MRM_C6, (outs), (ins), "wrmsrlist", []>, XS;
def RDMSRLIST : I<0x01, MRM_C6, (outs), (ins), "rdmsrlist", []>, XD; def RDMSRLIST : I<0x01, MRM_C6, (outs), (ins), "rdmsrlist", []>, XD;
} }
▲ Show 20 Lines • Show All 333 Lines • Show Last 20 Lines

llvm/test/MC/Disassembler/X86/wrmsrns.txt

  • This file was added.
# RUN: llvm-mc --disassemble %s -triple=x86_64 | FileCheck %s --check-prefixes=ATT
# RUN: llvm-mc --disassemble %s -triple=x86_64 -x86-asm-syntax=intel --output-asm-variant=1 | FileCheck %s --check-prefixes=INTEL
# RUN: llvm-mc --disassemble %s -triple=i386 | FileCheck %s --check-prefixes=ATT
# RUN: llvm-mc --disassemble %s -triple=i386 -x86-asm-syntax=intel --output-asm-variant=1 | FileCheck %s --check-prefixes=INTEL
# ATT: wrmsrns
# INTEL: wrmsrns
0x0f,0x01,0xc6

llvm/test/MC/X86/wrmsrns.s

  • This file was added.
// RUN: llvm-mc -triple x86_64 --show-encoding %s | FileCheck %s
// RUN: llvm-mc -triple x86_64 -x86-asm-syntax=intel -output-asm-variant=1 --show-encoding %s | FileCheck %s
// RUN: llvm-mc -triple i386 --show-encoding %s | FileCheck %s
// RUN: llvm-mc -triple i386 -x86-asm-syntax=intel -output-asm-variant=1 --show-encoding %s | FileCheck %s
// CHECK: wrmsrns
// CHECK: encoding: [0x0f,0x01,0xc6]
wrmsrns