Page MenuHomePhabricator

[C++20] [Modules] Replace is ModuleMapModule with isHeaderLikeModules
AbandonedPublic

Authored by ChuanqiXu on Aug 16 2022, 11:17 PM.

Details

Reviewers
iains
Summary

I find that many places we should use isHeaderLikeModules instead of isModuleMapModules since the semantics of clang module map modules are similar to header units.

But the downside of the patch is that it misses test cases. Another alternative will be add the test case one by one, which will be more painful and slower but more stable.

Diff Detail

Event Timeline

ChuanqiXu created this revision.Aug 16 2022, 11:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 16 2022, 11:17 PM
ChuanqiXu requested review of this revision.Aug 16 2022, 11:17 PM
ChuanqiXu abandoned this revision.Sun, Aug 28, 7:44 PM