This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] remove useless code
ClosedPublic

Authored by Miss_Grape on May 12 2022, 4:17 AM.

Details

Summary

when legality check for vectoring reduction, hasVInstructions() check be unneeded. RISCV can only loop vectorization with hasVInstructions()

Diff Detail

Event Timeline

Miss_Grape created this revision.May 12 2022, 4:17 AM
Miss_Grape requested review of this revision.May 12 2022, 4:17 AM
Miss_Grape edited the summary of this revision. (Show Details)May 12 2022, 4:20 AM
craig.topper accepted this revision.May 12 2022, 10:58 AM

LGTM, but please fix the description to use hasVInstructions instead of hasStdExtV since that's what's in the code.

This revision is now accepted and ready to land.May 12 2022, 10:58 AM
Miss_Grape edited the summary of this revision. (Show Details)May 12 2022, 7:20 PM

LGTM, but please fix the description to use hasVInstructions instead of hasStdExtV since that's what's in the code.

Done.

hasVInstructions() check be unneeded. RISCV can only loop vectorization with hasVInstructions()

For long term, I think that's not true, P/Packed-SIMD extensions should be able to apply loop vectorization too, but I am not opposite this getting merge, just remind we might need to add back in future.

hasVInstructions() check be unneeded. RISCV can only loop vectorization with hasVInstructions()

For long term, I think that's not true, P/Packed-SIMD extensions should be able to apply loop vectorization too, but I am not opposite this getting merge, just remind we might need to add back in future.

I think we may need another feature to support P/Packed-SIMD extensions. We need to process this before legalization。

This revision was landed with ongoing or failed builds.May 16 2022, 5:55 AM
This revision was automatically updated to reflect the committed changes.