This is an archive of the discontinued LLVM Phabricator instance.

Differential D114842

[lld-macho] Remove old macho darwin lld
ClosedPublic

Authored by keith on Nov 30 2021, 8:58 PM.

Details

Reviewers
int3
MaskRay
oontvoo
thakis
jdoerfert
Group Reviewers
Restricted Project
Commits
rG9e3552523ebd: [lld-macho] Remove old macho darwin lld
Summary

During the llvm round table it was generally agreed that the newer macho
lld implementation is feature complete enough to replace the old
implementation entirely. This will reduce confusion for new users who
aren't aware of the history.

Diff Detail

Event Timeline

keith created this revision.Nov 30 2021, 8:58 PM
Herald added subscribers: ormris, steven_wu, hiraditya, mgorny. · View Herald TranscriptNov 30 2021, 8:58 PM
keith requested review of this revision.Nov 30 2021, 8:58 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 30 2021, 8:58 PM
Herald added subscribers: llvm-commits, cfe-commits, aheejin. · View Herald Transcript
keith updated this revision to Diff 390898.Nov 30 2021, 8:59 PM

Fix format

keith added a comment.Nov 30 2021, 8:59 PM

I chose to remove the darwinnew / darwinold symlinks here as well. Let me know if you all think we should leave those around for a while for some reason

int3 accepted this revision.Nov 30 2021, 9:32 PM

lgtm. Could you make a post to llvm-dev before landing this? Thanks!

This revision is now accepted and ready to land.Nov 30 2021, 9:32 PM
MaskRay accepted this revision.Nov 30 2021, 9:33 PM

Consider moving the clang driver change to a separate change so that the removal is a more pure file deletion (other than some build system changes)

Harbormaster completed remote builds in B136831: Diff 390898.Nov 30 2021, 9:42 PM
keith updated this revision to Diff 390904.Nov 30 2021, 10:05 PM

Remove clang changes to reduce diff

keith added a comment.Nov 30 2021, 10:06 PM
In D114842#3163232, @MaskRay wrote:

Consider moving the clang driver change to a separate change so that the removal is a more pure file deletion (other than some build system changes)

Fair enough, I'll submit as a follow up

keith added a comment.Nov 30 2021, 10:24 PM
In D114842#3163229, @int3 wrote:

lgtm. Could you make a post to llvm-dev before landing this? Thanks!

Sent!

keith updated this revision to Diff 390908.Nov 30 2021, 10:30 PM

More deletions

Herald added a reviewer: jdoerfert. · View Herald TranscriptNov 30 2021, 10:30 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added subscribers: dang, sstefan1, mgrang. · View Herald Transcript
keith updated this revision to Diff 390910.Nov 30 2021, 10:31 PM

Stragglers

keith updated this revision to Diff 390911.Nov 30 2021, 10:31 PM

Formatting

thevinster added a subscriber: thevinster.Nov 30 2021, 10:46 PM
thevinster added inline comments.
lld/lib/CMakeLists.txt
1 ↗(On Diff #390911)

Just wondering, can't we delete this too?

Harbormaster completed remote builds in B136843: Diff 390911.Nov 30 2021, 11:15 PM
keith updated this revision to Diff 391065.Dec 1 2021, 9:52 AM
keith marked an inline comment as done.

Remove lld/lib directory

Harbormaster completed remote builds in B136950: Diff 391065.Dec 1 2021, 11:24 AM
oontvoo accepted this revision.Dec 1 2021, 8:20 PM

LG - thanks!

This revision was landed with ongoing or failed builds.Dec 2 2021, 11:05 AM
Closed by commit rG9e3552523ebd: [lld-macho] Remove old macho darwin lld (authored by keith). · Explain Why
This revision was automatically updated to reflect the committed changes.
keith added a commit: rG9e3552523ebd: [lld-macho] Remove old macho darwin lld.
keith mentioned this in D114976: [Bazel] Remove old macho lld port.Dec 2 2021, 11:24 AM
keith mentioned this in rGbe4e789d214f: [Bazel] Remove old macho lld port.Dec 2 2021, 11:45 AM
thakis mentioned this in D128147: [lld] Remove lld/include/lld/Core.Jun 19 2022, 3:22 PM
thakis mentioned this in rG7cb49996f758: [lld] Remove lld/include/lld/Core.Jun 19 2022, 6:37 PM

Large Diff

This large diff affects 190 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents

PathSize
clang/
include/
clang/
Driver/
5 lines
lib/
Driver/
10 lines
ToolChains/
2 lines
14 lines
test/
Driver/
5 lines
4 lines
4 lines
4 lines
4 lines
lld/
test/
darwin/
Inputs/
mach-o/
Inputs/
MacOSX.sdk/
usr/
lib/
arm64/
armv7/
lib-search-paths/
usr/
lib/
local/
lib/
x86/
x86_64/
tools/
lld/
2 lines
15 lines
llvm/
utils/
gn/
secondary/
lld/
tools/
lld/
2 lines

Diff 390897

clang/include/clang/Driver/ToolChain.h

clang/lib/Driver/ToolChain.cpp

clang/lib/Driver/ToolChains/Darwin.h

clang/lib/Driver/ToolChains/Darwin.cpp

clang/test/Driver/darwin-ld-demangle-lld.c

clang/test/Driver/darwin-ld-platform-version-ios.c

clang/test/Driver/darwin-ld-platform-version-macos.c

clang/test/Driver/darwin-ld-platform-version-tvos.c

clang/test/Driver/darwin-ld-platform-version-watchos.c

lld/test/darwin/Inputs/native-and-mach-o.objtxt

lld/test/darwin/Inputs/native-and-mach-o2.objtxt

lld/test/darwin/cmdline-lto_library.objtxt

lld/test/darwin/cmdline-objc_gc.objtxt

lld/test/darwin/cmdline-objc_gc_compaction.objtxt

lld/test/darwin/cmdline-objc_gc_only.objtxt

lld/test/darwin/native-and-mach-o.objtxt

lld/test/mach-o/Inputs/DependencyDump.py

lld/test/mach-o/Inputs/MacOSX.sdk/usr/lib/libSystem.tbd

lld/test/mach-o/Inputs/PIE.yaml

lld/test/mach-o/Inputs/arm-interworking.yaml

lld/test/mach-o/Inputs/arm-shims.yaml

lld/test/mach-o/Inputs/arm64/libSystem.yaml

lld/test/mach-o/Inputs/armv7/libSystem.yaml

lld/test/mach-o/Inputs/bar.yaml

lld/test/mach-o/Inputs/cstring-sections.yaml

lld/test/mach-o/Inputs/exported_symbols_list.exp

lld/test/mach-o/Inputs/full.filelist

lld/test/mach-o/Inputs/got-order.yaml

lld/test/mach-o/Inputs/got-order2.yaml

lld/test/mach-o/Inputs/hello-world-arm64.yaml

lld/test/mach-o/Inputs/hello-world-armv6.yaml

lld/test/mach-o/Inputs/hello-world-armv7.yaml

lld/test/mach-o/Inputs/hello-world-x86.yaml

lld/test/mach-o/Inputs/hello-world-x86_64.yaml

lld/test/mach-o/Inputs/hw.raw_bytes

lld/test/mach-o/Inputs/interposing-section.yaml

lld/test/mach-o/Inputs/lazy-bind-x86_64-2.yaml

lld/test/mach-o/Inputs/lazy-bind-x86_64-3.yaml

lld/test/mach-o/Inputs/lazy-bind-x86_64.yaml

lld/test/mach-o/Inputs/lib-search-paths/usr/lib/libmyshared.dylib

lld/test/mach-o/Inputs/lib-search-paths/usr/lib/libmystatic.a

lld/test/mach-o/Inputs/lib-search-paths/usr/local/lib/file.o

lld/test/mach-o/Inputs/libbar.a

lld/test/mach-o/Inputs/libfoo.a

lld/test/mach-o/Inputs/no-version-min-load-command-object.yaml

lld/test/mach-o/Inputs/order_file-basic.order

lld/test/mach-o/Inputs/partial.filelist

lld/test/mach-o/Inputs/re-exported-dylib-ordinal.yaml

lld/test/mach-o/Inputs/re-exported-dylib-ordinal2.yaml

lld/test/mach-o/Inputs/re-exported-dylib-ordinal3.yaml

lld/test/mach-o/Inputs/swift-version-1.yaml

lld/test/mach-o/Inputs/unwind-info-simple-arm64.yaml

lld/test/mach-o/Inputs/use-dylib-install-names.yaml

lld/test/mach-o/Inputs/use-simple-dylib.yaml

lld/test/mach-o/Inputs/write-final-sections.yaml

lld/test/mach-o/Inputs/wrong-arch-error.yaml

lld/test/mach-o/Inputs/x86/libSystem.yaml

lld/test/mach-o/Inputs/x86_64/libSystem.yaml

lld/test/mach-o/PIE.yaml

lld/test/mach-o/align_text.yaml

lld/test/mach-o/arm-interworking-movw.yaml

lld/test/mach-o/arm-interworking.yaml

lld/test/mach-o/arm-shims.yaml

lld/test/mach-o/arm-subsections-via-symbols.yaml

lld/test/mach-o/arm64-reloc-negDelta32-fixup.yaml

lld/test/mach-o/arm64-relocs-errors-delta64-offset.yaml

lld/test/mach-o/arm64-section-order.yaml

lld/test/mach-o/bind-opcodes.yaml

lld/test/mach-o/cstring-sections.yaml

lld/test/mach-o/data-in-code-load-command.yaml

lld/test/mach-o/data-only-dylib.yaml

lld/test/mach-o/dead-strip-globals.yaml

lld/test/mach-o/debug-syms.yaml

lld/test/mach-o/demangle.yaml

lld/test/mach-o/dependency_info.yaml

lld/test/mach-o/do-not-emit-unwind-fde-arm64.yaml

lld/test/mach-o/dso_handle.yaml

lld/test/mach-o/dylib-install-names.yaml

lld/test/mach-o/eh-frame-relocs-arm64.yaml

lld/test/mach-o/empty-sections.yaml

lld/test/mach-o/error-simulator-vs-macosx.yaml

lld/test/mach-o/exe-offsets.yaml

lld/test/mach-o/exe-segment-overlap.yaml

lld/test/mach-o/executable-exports.yaml

lld/test/mach-o/export-trie-order.yaml

lld/test/mach-o/exported_symbols_list-dylib.yaml

lld/test/mach-o/exported_symbols_list-obj.yaml

lld/test/mach-o/exported_symbols_list-undef.yaml

lld/test/mach-o/fat-archive.yaml

lld/test/mach-o/filelist.yaml

lld/test/mach-o/flat_namespace_undef_error.yaml

lld/test/mach-o/flat_namespace_undef_suppress.yaml

lld/test/mach-o/force_load-dylib.yaml

lld/test/mach-o/force_load-x86_64.yaml

lld/test/mach-o/framework-user-paths.yaml

lld/test/mach-o/function-starts-load-command.yaml

lld/test/mach-o/gcc_except_tab-got-arm64.yaml

lld/test/mach-o/got-order.yaml

lld/test/mach-o/hello-world-arm64.yaml

lld/test/mach-o/hello-world-armv6.yaml

lld/test/mach-o/hello-world-armv7.yaml

lld/test/mach-o/hello-world-x86.yaml

lld/test/mach-o/hello-world-x86_64.yaml

lld/test/mach-o/image-base.yaml

lld/test/mach-o/infer-arch.yaml

lld/test/mach-o/interposing-section.yaml

lld/test/mach-o/keep_private_externs.yaml

lld/test/mach-o/lazy-bind-x86_64.yaml

lld/test/mach-o/lc_segment_filesize.yaml

lld/test/mach-o/lib-search-paths.yaml

lld/test/mach-o/library-order.yaml

lld/test/mach-o/library-rescan.yaml

lld/test/mach-o/libresolve-bizarre-root-override.yaml

lld/test/mach-o/libresolve-multiple-syslibroots.yaml

lld/test/mach-o/libresolve-one-syslibroot.yaml

lld/test/mach-o/libresolve-simple.yaml

lld/test/mach-o/libresolve-user-paths.yaml

lld/test/mach-o/libresolve-z.yaml

lld/test/mach-o/lit.local.cfg

lld/test/mach-o/load-commands-size.yaml

lld/test/mach-o/mach_header-cpusubtype.yaml

lld/test/mach-o/mh_bundle_header.yaml

lld/test/mach-o/mh_dylib_header.yaml

lld/test/mach-o/objc-category-list-atom.yaml

lld/test/mach-o/objc-image-info-host-vs-simulator.yaml

lld/test/mach-o/objc-image-info-invalid-size.yaml

lld/test/mach-o/objc-image-info-invalid-version.yaml

lld/test/mach-o/objc-image-info-mismatched-swift-version.yaml

lld/test/mach-o/objc-image-info-pass-output.yaml

lld/test/mach-o/objc-image-info-simulator-vs-host.yaml

lld/test/mach-o/objc-image-info-unsupported-gc.yaml

lld/test/mach-o/objc_export_list.yaml

lld/test/mach-o/order_file-basic.yaml

lld/test/mach-o/parse-aliases.yaml

lld/test/mach-o/parse-arm-relocs.yaml

lld/test/mach-o/parse-cfstring32.yaml

lld/test/mach-o/parse-cfstring64.yaml

lld/test/mach-o/parse-compact-unwind32.yaml

lld/test/mach-o/parse-compact-unwind64.yaml

lld/test/mach-o/parse-data-in-code-armv7.yaml

lld/test/mach-o/parse-data-in-code-x86.yaml

lld/test/mach-o/parse-data-relocs-arm64.yaml

lld/test/mach-o/parse-data-relocs-x86_64.yaml

lld/test/mach-o/parse-data.yaml

lld/test/mach-o/parse-eh-frame-relocs-x86_64.yaml

lld/test/mach-o/parse-eh-frame-x86-anon.yaml

lld/test/mach-o/parse-eh-frame-x86-labeled.yaml

lld/test/mach-o/parse-eh-frame.yaml

lld/test/mach-o/parse-function.yaml

lld/test/mach-o/parse-initializers32.yaml

lld/test/mach-o/parse-initializers64.yaml

lld/test/mach-o/parse-literals-error.yaml

lld/test/mach-o/parse-literals.yaml

lld/test/mach-o/parse-non-lazy-pointers.yaml

lld/test/mach-o/parse-relocs-x86.yaml

lld/test/mach-o/parse-section-no-symbol.yaml

lld/test/mach-o/parse-tentative-defs.yaml

lld/test/mach-o/parse-text-relocs-arm64.yaml

lld/test/mach-o/parse-text-relocs-x86_64.yaml

lld/test/mach-o/parse-tlv-relocs-x86-64.yaml

lld/test/mach-o/re-exported-dylib-ordinal.yaml

lld/test/mach-o/rpath.yaml

lld/test/mach-o/run-tlv-pass-x86-64.yaml

lld/test/mach-o/sdk-version-error.yaml

lld/test/mach-o/sectalign.yaml

lld/test/mach-o/sectattrs.yaml

lld/test/mach-o/sectcreate.yaml

lld/test/mach-o/seg-protection-arm64.yaml

lld/test/mach-o/seg-protection-x86_64.yaml

lld/test/mach-o/source-version.yaml

lld/test/mach-o/stack-size.yaml

lld/test/mach-o/string-table.yaml

lld/test/mach-o/stub-link.s

lld/test/mach-o/subsections-via-symbols-default.yaml

lld/test/mach-o/twolevel_namespace_undef_dynamic_lookup.yaml

lld/test/mach-o/twolevel_namespace_undef_warning_suppress.yaml

lld/test/mach-o/unwind-info-simple-arm64.yaml

lld/test/mach-o/unwind-info-simple-x86_64.yaml

lld/test/mach-o/upward-dylib-load-command.yaml

lld/test/mach-o/upward-dylib-paths.yaml

lld/test/mach-o/usage.yaml

lld/test/mach-o/use-dylib.yaml

lld/test/mach-o/use-simple-dylib.yaml

lld/test/mach-o/version-min-load-command-object.yaml

lld/test/mach-o/version-min-load-command.yaml

lld/test/mach-o/write-final-sections.yaml

lld/test/mach-o/wrong-arch-error.yaml

lld/tools/lld/CMakeLists.txt

lld/tools/lld/lld.cpp

llvm/utils/gn/secondary/lld/tools/lld/BUILD.gn