Page MenuHomePhabricator

keith (Keith Smiley)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2018, 2:18 PM (145 w, 5 d)

Recent Activity

Mar 7 2021

keith added a comment to D83152: llvm-nm: add flag to suppress no symbols warning.

Thanks again everyone!

Mar 7 2021, 4:21 PM · Restricted Project
keith committed rG64240f8138f5: llvm-nm: add flag to suppress no symbols warning (authored by keith).
llvm-nm: add flag to suppress no symbols warning
Mar 7 2021, 4:21 PM
keith closed D83152: llvm-nm: add flag to suppress no symbols warning.
Mar 7 2021, 4:20 PM · Restricted Project
keith updated the diff for D83152: llvm-nm: add flag to suppress no symbols warning.

Update help

Mar 7 2021, 4:09 PM · Restricted Project

Mar 5 2021

keith updated the diff for D83152: llvm-nm: add flag to suppress no symbols warning.

Update test and docs

Mar 5 2021, 12:54 PM · Restricted Project

Feb 27 2021

keith updated the diff for D83152: llvm-nm: add flag to suppress no symbols warning.

Add flag to test

Feb 27 2021, 6:35 PM · Restricted Project
keith updated the summary of D83152: llvm-nm: add flag to suppress no symbols warning.
Feb 27 2021, 5:54 PM · Restricted Project
keith added a comment to D83152: llvm-nm: add flag to suppress no symbols warning.

Thanks for driving that! Updated my patch to use --quiet. I did hesitate a bit on specifically saying 'no symbols' in the help string, but I guess we can update that in the future if anything else makes sense to gate with this flag as well.

Feb 27 2021, 5:54 PM · Restricted Project
keith updated the diff for D83152: llvm-nm: add flag to suppress no symbols warning.

Update to --quiet spelling

Feb 27 2021, 5:54 PM · Restricted Project
keith reclaimed D83152: llvm-nm: add flag to suppress no symbols warning.
Feb 27 2021, 5:54 PM · Restricted Project

Feb 25 2021

keith added a comment to D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}.

No worries! Makes sense, I think this is a good change

Feb 25 2021, 3:41 PM · Restricted Project
keith accepted D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}.

I personally prefer this, and this is what I landed in swiftc a while back, but I changed to -fprofile-prefix-map based on feedback from you 😛 https://reviews.llvm.org/D83154?id=275480#2146086

Feb 25 2021, 2:34 PM · Restricted Project

Feb 9 2021

keith added a comment to D83152: llvm-nm: add flag to suppress no symbols warning.

I think it is case by case. For this one, 2> /dev/null is a simple and easy workaround. I find it difficult to argue against this choice. There was an equally good suggestion --quiet we cannot refute.

Feb 9 2021, 8:20 PM · Restricted Project
keith abandoned D83152: llvm-nm: add flag to suppress no symbols warning.

thanks for the review

Feb 9 2021, 9:48 AM · Restricted Project
keith added a comment to D90646: [clang] Add warning when `-include-pch` is passed multiple times.

Yea seems like a reasonable request, looking through the uses nothing immediately pops out as being not supporting multiple PCHs but I guess before I went down that path I'd want someone who knew the code better to agree on that

Feb 9 2021, 9:34 AM · Restricted Project
keith updated the diff for D83152: llvm-nm: add flag to suppress no symbols warning.

Update style in test

Feb 9 2021, 8:39 AM · Restricted Project

Jan 25 2021

keith added a comment to D90646: [clang] Add warning when `-include-pch` is passed multiple times.

Fair question! I think this case is a bit different since it's quite subtle. The strange thing here is that the header you're intending to provide a pch for can still be read successfully, but not getting the benefits of the pch that you were expecting without knowing about it.

Jan 25 2021, 3:19 PM · Restricted Project
keith updated the diff for D90646: [clang] Add warning when `-include-pch` is passed multiple times.

Add group to warning

Jan 25 2021, 3:11 PM · Restricted Project
keith accepted D95393: [lit] Update lit.py shebang for Python3.
Jan 25 2021, 2:00 PM · Restricted Project
keith added a comment to D94734: [lit] Use os.cpu_count() to cleanup TODO.

Looks like this broken a build http://green.lab.llvm.org/green/job/ZorgTests/49794/console

Jan 25 2021, 12:27 PM · Restricted Project
keith added a comment to D95385: Revert "[clangd][NFC] Simplify handing on methods with no params".

No problem, thanks!!

Jan 25 2021, 12:25 PM · Restricted Project
keith added a reverting change for rGf05b492aae4d: [clangd][NFC] Simplify handing on methods with no params: rG9d9ceb37453f: Revert "[clangd][NFC] Simplify handing on methods with no params".
Jan 25 2021, 11:57 AM
keith added a reverting change for D95270: [clangd][NFC] Simplify handing on methods with no params: rG9d9ceb37453f: Revert "[clangd][NFC] Simplify handing on methods with no params".
Jan 25 2021, 11:57 AM · Restricted Project
keith committed rG9d9ceb37453f: Revert "[clangd][NFC] Simplify handing on methods with no params" (authored by keith).
Revert "[clangd][NFC] Simplify handing on methods with no params"
Jan 25 2021, 11:57 AM
keith closed D95385: Revert "[clangd][NFC] Simplify handing on methods with no params".
Jan 25 2021, 11:57 AM · Restricted Project
keith added a reverting change for rGf05b492aae4d: [clangd][NFC] Simplify handing on methods with no params: D95385: Revert "[clangd][NFC] Simplify handing on methods with no params".
Jan 25 2021, 11:56 AM
keith requested review of D95385: Revert "[clangd][NFC] Simplify handing on methods with no params".
Jan 25 2021, 11:56 AM · Restricted Project
keith added a reverting change for D95270: [clangd][NFC] Simplify handing on methods with no params: D95385: Revert "[clangd][NFC] Simplify handing on methods with no params".
Jan 25 2021, 11:56 AM · Restricted Project
keith closed D83154: [clang] Add -fprofile-prefix-map.

Something went wrong with this being attached to the commit (I believe because I committed from a different machine than I originally wrote this on), landed here https://github.com/llvm/llvm-project/commit/c3324450b204392169d4ec7172cb32f74c03e376 thanks for the review!

Jan 25 2021, 10:16 AM · Restricted Project
keith committed rGc3324450b204: [clang] Add -fprofile-prefix-map (authored by keith).
[clang] Add -fprofile-prefix-map
Jan 25 2021, 10:14 AM
keith retitled D83154: [clang] Add -fprofile-prefix-map from clang: Add -fprofile-prefix-map to [clang] Add -fprofile-prefix-map.
Jan 25 2021, 10:06 AM · Restricted Project
keith updated the diff for D83154: [clang] Add -fprofile-prefix-map.

Rebase

Jan 25 2021, 10:04 AM · Restricted Project

Jan 20 2021

keith added a comment to D83154: [clang] Add -fprofile-prefix-map.

Yes sorry, big company reviews month. I will try to land Friday

Jan 20 2021, 10:37 AM · Restricted Project

Dec 1 2020

keith added a comment to D92357: clang/darwin: Don't use response files with ld64.

I'm a bit worried that without a repro case (outside of the missing newline) Apple won't get around to fixing this, and in the meantime I'm wondering if outside of the chromium build system folks will experience this. I wonder if there's an acceptable alternative here such as adding a (ideally temporary) flag to force the old behavior?

Dec 1 2020, 10:01 AM · Restricted Project
keith accepted D92399: clang/darwin: Use response files with ld64.lld.darwinnew.
Dec 1 2020, 8:50 AM · Restricted Project

Nov 30 2020

keith added a comment to D92357: clang/darwin: Don't use response files with ld64.

It looks like at least in the -Wl case clang passes the file through directly, so I'm not surprises that it repros there:

Nov 30 2020, 6:19 PM · Restricted Project
keith added a comment to D92357: clang/darwin: Don't use response files with ld64.

Note in your repro case the issue is that the response file doesn't end in a trailing newline

Nov 30 2020, 5:21 PM · Restricted Project

Nov 20 2020

keith committed rG244022a3cd75: Don’t break before nested block param when prior param is not a block (authored by segiddins).
Don’t break before nested block param when prior param is not a block
Nov 20 2020, 3:20 PM
keith closed D91669: Don’t break before nested block param when prior param is not a block.
Nov 20 2020, 3:19 PM · Restricted Project

Nov 18 2020

keith accepted D91742: [lldb] Add examples and reword source-map help string.
Nov 18 2020, 2:07 PM · Restricted Project
keith added a reviewer for D91669: Don’t break before nested block param when prior param is not a block: djasper.
Nov 18 2020, 2:05 PM · Restricted Project
keith accepted D91669: Don’t break before nested block param when prior param is not a block.
Nov 18 2020, 1:23 PM · Restricted Project

Nov 16 2020

keith abandoned D17922: [clang-format] Don't add a space before Obj-C selector methods that are also clang-format keywords.
Nov 16 2020, 5:03 PM
keith commandeered D17922: [clang-format] Don't add a space before Obj-C selector methods that are also clang-format keywords.

Note the test case shown here passes on master, so we can drop this

Nov 16 2020, 5:03 PM

Nov 9 2020

keith committed rG2319c49339b9: [llvm-cov][NFC] Fix typo in format comment (authored by keith).
[llvm-cov][NFC] Fix typo in format comment
Nov 9 2020, 2:48 PM

Nov 2 2020

keith requested review of D90646: [clang] Add warning when `-include-pch` is passed multiple times.
Nov 2 2020, 1:53 PM · Restricted Project
keith accepted D87928: Provide -fsource-dir flag in Clang.
Nov 2 2020, 8:43 AM · Restricted Project, Restricted Project

Oct 30 2020

keith committed rGbbf02e18f536: [clang][NFC] Remove unused FileCheck prefix (authored by keith).
[clang][NFC] Remove unused FileCheck prefix
Oct 30 2020, 1:33 PM
keith closed D90430: [clang][NFC] Remove unused FileCheck prefix.
Oct 30 2020, 1:32 PM · Restricted Project
keith committed rGe7ada98b56da: [llvm-cov][NFC] Remove unused prefixes from FileCheck usage (authored by keith).
[llvm-cov][NFC] Remove unused prefixes from FileCheck usage
Oct 30 2020, 8:29 AM
keith closed D90423: [llvm-cov][NFC] Remove unused prefixes from FileCheck usage.
Oct 30 2020, 8:28 AM · Restricted Project

Oct 29 2020

keith added a comment to D90427: [llvm-readobj][NFC] Remove unused prefix from FileCheck tests.

Thanks! I actually just requested access so we'll see!

Oct 29 2020, 5:51 PM · Restricted Project
keith added a comment to D90427: [llvm-readobj][NFC] Remove unused prefix from FileCheck tests.

Thanks! I don't have commit access do you mind landing this for me?

Oct 29 2020, 5:35 PM · Restricted Project
keith added a comment to D90423: [llvm-cov][NFC] Remove unused prefixes from FileCheck usage.

Thanks! I don't have merge access do you mind helping me land this?

Oct 29 2020, 3:17 PM · Restricted Project
keith requested review of D90430: [clang][NFC] Remove unused FileCheck prefix.
Oct 29 2020, 2:11 PM · Restricted Project
keith requested review of D90427: [llvm-readobj][NFC] Remove unused prefix from FileCheck tests.
Oct 29 2020, 2:02 PM · Restricted Project
keith retitled D90423: [llvm-cov][NFC] Remove unused prefixes from FileCheck usage from [llvm-cov] Remove unused prefixes from FileCheck usage to [llvm-cov][NFC] Remove unused prefixes from FileCheck usage.
Oct 29 2020, 2:01 PM · Restricted Project
keith added a reviewer for D90423: [llvm-cov][NFC] Remove unused prefixes from FileCheck usage: vsk.
Oct 29 2020, 1:58 PM · Restricted Project
keith requested review of D90423: [llvm-cov][NFC] Remove unused prefixes from FileCheck usage.
Oct 29 2020, 1:54 PM · Restricted Project

Oct 28 2020

keith added a comment to D90080: [llvm-objcopy] Quote passed rpath args in errors.

Thanks all! Can someone land this for me again?

Oct 28 2020, 11:08 AM · Restricted Project

Oct 23 2020

keith added inline comments to D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.
Oct 23 2020, 3:35 PM · Restricted Project
keith requested review of D90080: [llvm-objcopy] Quote passed rpath args in errors.
Oct 23 2020, 3:34 PM · Restricted Project

Oct 21 2020

keith updated the diff for D89713: [llvm-objcopy][NFC] extract arg parsing logic to function.

Make function static

Oct 21 2020, 9:22 AM · Restricted Project
keith retitled D89713: [llvm-objcopy][NFC] extract arg parsing logic to function from [llvm-objcopy] extract arg parsing logic to function to [llvm-objcopy][NFC] extract arg parsing logic to function.
Oct 21 2020, 9:20 AM · Restricted Project
keith added inline comments to D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.
Oct 21 2020, 9:20 AM · Restricted Project

Oct 20 2020

keith added a comment to D89713: [llvm-objcopy][NFC] extract arg parsing logic to function.

Thanks!

Oct 20 2020, 8:32 AM · Restricted Project
keith updated the diff for D89713: [llvm-objcopy][NFC] extract arg parsing logic to function.

Remove unused enum

Oct 20 2020, 8:32 AM · Restricted Project
keith updated the summary of D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.
Oct 20 2020, 8:31 AM · Restricted Project
keith retitled D89713: [llvm-objcopy][NFC] extract arg parsing logic to function from llvm-objcopy: extract arg parsing logic to function to [llvm-objcopy] extract arg parsing logic to function.
Oct 20 2020, 8:30 AM · Restricted Project
keith added a comment to D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

Thanks for the review!

Oct 20 2020, 8:30 AM · Restricted Project
keith retitled D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option from Add -prepend_rpath install-name-tool option to [llvm-objcopy] Add -prepend_rpath install-name-tool option.
Oct 20 2020, 8:30 AM · Restricted Project
keith updated the diff for D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

Address review comments

Oct 20 2020, 8:29 AM · Restricted Project

Oct 19 2020

keith added a comment to D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

I believe my author info was correct, but I've updated it using the command mentioned in the doc. Thanks!

Oct 19 2020, 3:08 PM · Restricted Project
keith updated the diff for D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

Update author

Oct 19 2020, 3:08 PM · Restricted Project
keith added a comment to D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

Thanks! I don't have merge access can you help me land this?

Oct 19 2020, 10:53 AM · Restricted Project
keith updated the diff for D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

Add comment about recalculation

Oct 19 2020, 10:12 AM · Restricted Project
keith requested review of D89713: [llvm-objcopy][NFC] extract arg parsing logic to function.
Oct 19 2020, 10:10 AM · Restricted Project

Oct 16 2020

keith retitled D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option from Add -insert_rpath install-name-tool option to Add -prepend_rpath install-name-tool option.
Oct 16 2020, 8:54 PM · Restricted Project
keith updated the diff for D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

Rename to -prepend_rpath

Oct 16 2020, 8:54 PM · Restricted Project
keith requested review of D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.
Oct 16 2020, 5:10 PM · Restricted Project

Sep 22 2020

keith added a comment to D83154: [clang] Add -fprofile-prefix-map.

Should we wait for that one to land and then pick this one up? Otherwise any thoughts on the outstanding discussion?

Sep 22 2020, 10:52 AM · Restricted Project

Sep 21 2020

keith added a comment to D83154: [clang] Add -fprofile-prefix-map.

With D87928 do you think we would want this flag as well? The only difference I can think of (besides general UX) is if you need to remap paths outside of your source root, I believe having a *-prefix-map style flag makes that a bit more clear (or potentially possible at all). Ideally there wouldn't be issues around that but in the past in the Apple toolchain the Xcode path was embedded in debug info (as an example), so to get a reproducible build we had to pass -fdebug-prefix-map=/path/to/Xcode.app=SOMETHING. Which -fdebug-compilation-dir . couldn't solve. I'm wondering if we should add both flags for this flexibility, or if we should assume this should not happen?

Sep 21 2020, 5:16 PM · Restricted Project
keith added a comment to D87928: Provide -fsource-dir flag in Clang.

This change is trying to address the issues raised in D83154. There are still some open questions:

  • Is -fsource-dir the best name for this flag?
Sep 21 2020, 5:08 PM · Restricted Project, Restricted Project

Sep 15 2020

keith added inline comments to D83154: [clang] Add -fprofile-prefix-map.
Sep 15 2020, 6:02 PM · Restricted Project

Sep 12 2020

keith added inline comments to D83154: [clang] Add -fprofile-prefix-map.
Sep 12 2020, 12:49 PM · Restricted Project

Sep 9 2020

keith added inline comments to D83154: [clang] Add -fprofile-prefix-map.
Sep 9 2020, 5:27 PM · Restricted Project
keith updated the diff for D83154: [clang] Add -fprofile-prefix-map.

Small fixes

Sep 9 2020, 5:27 PM · Restricted Project

Sep 8 2020

keith updated the diff for D83154: [clang] Add -fprofile-prefix-map.

Rename from fcoverage-prefix-map to fprofile-prefix-map

Sep 8 2020, 4:53 PM · Restricted Project
keith retitled D83154: [clang] Add -fprofile-prefix-map from clang: Add -fdebug-prefix-map to clang: Add -fprofile-prefix-map.
Sep 8 2020, 4:53 PM · Restricted Project
keith retitled D83154: [clang] Add -fprofile-prefix-map from clang: Add -fcoverage-prefix-map to clang: Add -fdebug-prefix-map.
Sep 8 2020, 4:52 PM · Restricted Project

Aug 18 2020

keith added a comment to D83154: [clang] Add -fprofile-prefix-map.

Yes I do, sorry I've been a bit busy, I will try to get to this later this week

Aug 18 2020, 7:04 PM · Restricted Project

Jul 16 2020

keith added a comment to D83152: llvm-nm: add flag to suppress no symbols warning.

Is there a build step executing llvm-nm that chokes on this? Can you say more about the use case?

Jul 16 2020, 1:41 PM · Restricted Project

Jul 14 2020

keith committed rG852b4f2dcf46: [llvm-cov] Add support for -skip-functions to lcov (authored by keith).
[llvm-cov] Add support for -skip-functions to lcov
Jul 14 2020, 4:21 PM

Jul 6 2020

keith added a comment to D83154: [clang] Add -fprofile-prefix-map.

I originally implemented this behavior behind -fdebug-prefix-map but there was some pushback, more context: https://lists.llvm.org/pipermail/cfe-dev/2020-June/065668.html

Jul 6 2020, 6:15 PM · Restricted Project
keith added a comment to D83152: llvm-nm: add flag to suppress no symbols warning.

I cannot find any search result about no-warning-for-no-symbols. Is -no-warning-for-no-symbols really an existing option? libtool is an ar like tool.

I found it by looking for underscores instead of hyphens: -no_warning_for_no_symbols.
However, the flag is an ar/ranlib/libtool flag, not nm, AFAICT.

Jul 6 2020, 3:08 PM · Restricted Project

Jul 4 2020

keith updated the diff for D83154: [clang] Add -fprofile-prefix-map.

Fix tests on Windows

Jul 4 2020, 10:12 AM · Restricted Project

Jul 3 2020

keith added a comment to D83154: [clang] Add -fprofile-prefix-map.

Open question: I don't know how all the toolchains fit together, but I noticed that only Clang.cpp handles -fmacro-prefix-map, but Clang.cpp, FreeBSD.cpp, and Gnu.cpp all handle -fdebug-prefix-map. I wasn't sure which pattern I should follow here, so right now this only adds the handling to Clang.cpp, please let me know if that's not appropriate in this case!

Jul 3 2020, 10:42 PM · Restricted Project
keith abandoned D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings.

https://reviews.llvm.org/D83154

Jul 3 2020, 10:42 PM · Restricted Project, Restricted Project
keith created D83154: [clang] Add -fprofile-prefix-map.
Jul 3 2020, 10:42 PM · Restricted Project
keith created D83152: llvm-nm: add flag to suppress no symbols warning.
Jul 3 2020, 9:09 PM · Restricted Project