Awesome, thanks!

wdyt?

Improve name and add comment

friendly ping!

Yea it passes on my M1 machine, I will test on Intel and see if that's the difference, I have reverted since so hopefully everyone is back to green and I'll debug async and post here with the new fix.

Fix comment formatting

Extract previous llvm-ar logic instead of using a new function

Which sections specifically hit this? can you add a test?

Add required target to archive-format.test

Improve tests

Improve tests

Add test for universal object archive copy

Change test strategy to test for timestamps instead of alignment. This gives us the same result knowing that the darwin specific logic is hit, and it's easier to test for than crafting an unaligned binary.

Remove unused import

Move isMacho to Object library

Move format decision to callers

In D124895#3494149, @jyknight wrote:

In D124895#3492632, @keith wrote:

In D124895#3491724, @jyknight wrote:

Of course, if ld64 is ever removed in favor of lld, we could stop worrying about most of these issues

Update to only check new Kind when writing

In D124895#3491724, @jyknight wrote:

I don't think we ought to modify the archive reader like you've done, because we don't need to tell the difference between BSD/DARWIN when reading, only while writing. Thus, going through the trouble of distinguishing them in the reader is wasted work. Instead, please add a separate function, which ar and objcopy can call before constructing an ArchiveWriter, which returns the more "refined" Kind.

Fix spelling

I took this comment from the issue:

Based on the issue it sounds like this should be gated behind a new -fprofile-prefix-map flag? I assume we'd also want -ffile-prefix-map to apply to it as well, similar to the others. And we'll definitely want some tests here!

I doubt they're super common, but I figured the complexity of adding this was so low that it made sense to. In my case I was trying to compare versions of the installed lld on linux systems at /usr/bin/lld, so I found myself trying to do /usr/bin/ld --version and then /usr/bin/lld --version, where the latter didn't print the version. I don't think we have to worry about more folks calling this since the utility of calling it is still very small, and the output is clear that the other shims should be called.

This is purely a convenience addition so users don't have to know about -flavor gnu, or specify one of the other shims

Improve formatting

There were 2 competing revisions for this bug fix, I landed https://reviews.llvm.org/D121663 instead since it sounds like having an empty directory is more correct in this case

You're right it's version 5 not 4, maybe the issue is that some platforms (like macOS) are defaulting to 4 intentionally for now? I guess I thought 6 because passing 6 also reproduces, but I didn't also try 5.

I actually mean dwarf 6, which appears to be partially implemented according to https://lists.llvm.org/pipermail/llvm-dev/2020-April/141055.html

Fix tests with dwarf 6

Bump, I think I've covered everything here, let me know if not!

Update subsitutions with slashes

Update subsitutions with dashes

Update substitutions to use dashes

Ping, all green here, I just had to mess with the test regex a bit

Replace \w with .