Page MenuHomePhabricator

keith (Keith Smiley)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2018, 2:18 PM (106 w, 6 d)

Recent Activity

Mon, Jul 6

keith added a comment to D83154: clang: Add -fcoverage-prefix-map.

I originally implemented this behavior behind -fdebug-prefix-map but there was some pushback, more context: https://lists.llvm.org/pipermail/cfe-dev/2020-June/065668.html

Mon, Jul 6, 6:15 PM · Restricted Project
keith added a comment to D83152: llvm-nm: add flag to suppress no symbols warning.

I cannot find any search result about no-warning-for-no-symbols. Is -no-warning-for-no-symbols really an existing option? libtool is an ar like tool.

I found it by looking for underscores instead of hyphens: -no_warning_for_no_symbols.
However, the flag is an ar/ranlib/libtool flag, not nm, AFAICT.

Mon, Jul 6, 3:08 PM · Restricted Project

Sat, Jul 4

keith updated the diff for D83154: clang: Add -fcoverage-prefix-map.

Fix tests on Windows

Sat, Jul 4, 10:12 AM · Restricted Project

Fri, Jul 3

keith added a comment to D83154: clang: Add -fcoverage-prefix-map.

Open question: I don't know how all the toolchains fit together, but I noticed that only Clang.cpp handles -fmacro-prefix-map, but Clang.cpp, FreeBSD.cpp, and Gnu.cpp all handle -fdebug-prefix-map. I wasn't sure which pattern I should follow here, so right now this only adds the handling to Clang.cpp, please let me know if that's not appropriate in this case!

Fri, Jul 3, 10:42 PM · Restricted Project
keith abandoned D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings.

https://reviews.llvm.org/D83154

Fri, Jul 3, 10:42 PM · Restricted Project, Restricted Project
keith created D83154: clang: Add -fcoverage-prefix-map.
Fri, Jul 3, 10:42 PM · Restricted Project
keith created D83152: llvm-nm: add flag to suppress no symbols warning.
Fri, Jul 3, 9:09 PM · Restricted Project
keith abandoned D80660: clang: Add support for relative linker paths with -fuse-ld.

https://reviews.llvm.org/D83015

Fri, Jul 3, 10:44 AM · Restricted Project

Wed, Jul 1

keith accepted D83015: [Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path.

Awesome!

Wed, Jul 1, 6:23 PM · Restricted Project

Jun 11 2020

keith abandoned D81338: Remove diff file from root of repo.

No problem, thanks!

Jun 11 2020, 11:32 AM · Restricted Project

Jun 8 2020

keith added a comment to D81338: Remove diff file from root of repo.

@fhahn can you help land this? I don't have access. The failure does appear to be related but it seems like just applying this patch is failing, which I don't understand

Jun 8 2020, 4:39 PM · Restricted Project

Jun 6 2020

keith created D81338: Remove diff file from root of repo.
Jun 6 2020, 9:52 PM · Restricted Project
keith added a reviewer for D81338: Remove diff file from root of repo: TWeaver.
Jun 6 2020, 9:52 PM · Restricted Project

Jun 4 2020

keith added a comment to D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings.

FYI I actually removed that piece this morning since I felt like since this now supports -path-equivalence=.,foo which is the "expected" behavior from lldb, that was "good enough". lmk if you want me to add it back!

Jun 4 2020, 11:33 AM · Restricted Project, Restricted Project
keith updated the summary of D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings.
Jun 4 2020, 9:53 AM · Restricted Project, Restricted Project
keith updated the diff for D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings.

Update relative paths to include the leading ./

Jun 4 2020, 9:53 AM · Restricted Project, Restricted Project

Jun 3 2020

keith created D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings.
Jun 3 2020, 4:02 PM · Restricted Project, Restricted Project

Jun 2 2020

keith updated the diff for D80660: clang: Add support for relative linker paths with -fuse-ld.

Fix test on windows

Jun 2 2020, 2:16 PM · Restricted Project

May 28 2020

keith added a comment to D80660: clang: Add support for relative linker paths with -fuse-ld.

The new test failure appears unrelated to my changes

May 28 2020, 5:05 PM · Restricted Project
keith updated the diff for D80660: clang: Add support for relative linker paths with -fuse-ld.

Update tests

May 28 2020, 3:59 PM · Restricted Project
keith added a comment to D80660: clang: Add support for relative linker paths with -fuse-ld.

Thanks I moved them to the bottom and I believe I fixed them on windows!

May 28 2020, 3:59 PM · Restricted Project

May 27 2020

keith added a comment to D80225: [Driver] Recognize -fuse-ld={bfd,gold,lld} but don't prepend "ld." or "ld64." for other values.

I've submitted a related change to accept relative paths for -fuse-ld https://reviews.llvm.org/D80660

May 27 2020, 2:09 PM · Restricted Project
keith created D80660: clang: Add support for relative linker paths with -fuse-ld.
May 27 2020, 2:09 PM · Restricted Project

Jan 22 2020

keith added a comment to D73160: [llvm-cov] Add support for -skip-functions to lcov.

Can someone land this for me? I don't have permissions to do that AFAIK

Jan 22 2020, 12:33 PM · Restricted Project

Jan 21 2020

keith created D73160: [llvm-cov] Add support for -skip-functions to lcov.
Jan 21 2020, 9:27 PM · Restricted Project

Nov 4 2018

keith updated subscribers of D49776: Update framework-header-fix to force system sed.

No worries, thanks!

Nov 4 2018, 8:49 AM

Jul 31 2018

keith created D50114: nm: Add no-file-header to suppress object files.
Jul 31 2018, 4:13 PM

Jul 26 2018

keith added a comment to D49779: Make framework-header-fix process copied headers.

No problem! Yes please! :)

Jul 26 2018, 12:00 PM
keith added inline comments to D49779: Make framework-header-fix process copied headers.
Jul 26 2018, 11:55 AM
keith updated the diff for D49779: Make framework-header-fix process copied headers.
  • Hoist LLDB.framework headers copy out of condition
Jul 26 2018, 11:54 AM
keith added inline comments to D49779: Make framework-header-fix process copied headers.
Jul 26 2018, 11:25 AM
keith added inline comments to D49779: Make framework-header-fix process copied headers.
Jul 26 2018, 11:07 AM
keith added inline comments to D49779: Make framework-header-fix process copied headers.
Jul 26 2018, 10:24 AM
keith updated the diff for D49779: Make framework-header-fix process copied headers.
  • Make headers a post build command
Jul 26 2018, 10:24 AM

Jul 25 2018

keith added inline comments to D49779: Make framework-header-fix process copied headers.
Jul 25 2018, 10:19 AM
keith updated subscribers of D49776: Update framework-header-fix to force system sed.
Jul 25 2018, 12:47 AM
keith updated subscribers of D49776: Update framework-header-fix to force system sed.
Jul 25 2018, 12:46 AM
keith added a comment to D49779: Make framework-header-fix process copied headers.

It seems like if this was a common occurrence, it would've been fixed earlier, so I'm wondering if there's a difference in the way I'm building lldb that causes this. Using cmake:

Jul 25 2018, 12:45 AM
keith created D49779: Make framework-header-fix process copied headers.
Jul 25 2018, 12:43 AM
keith updated the summary of D49776: Update framework-header-fix to force system sed.
Jul 25 2018, 12:22 AM
keith updated the summary of D49776: Update framework-header-fix to force system sed.
Jul 25 2018, 12:22 AM

Jul 24 2018

keith added a reviewer for D49776: Update framework-header-fix to force system sed: beanz.
Jul 24 2018, 11:22 PM
keith removed a reviewer for D49776: Update framework-header-fix to force system sed: lldb-commits.
Jul 24 2018, 11:00 PM
keith added a reviewer for D49776: Update framework-header-fix to force system sed: lldb-commits.
Jul 24 2018, 10:54 PM
keith created D49776: Update framework-header-fix to force system sed.
Jul 24 2018, 10:53 PM

Jul 1 2018

keith updated the diff for D48751: nm: Add -no-weak flag for hiding weak symbols.

Add --no-weak to command guide

Jul 1 2018, 10:44 PM

Jun 29 2018

keith updated the diff for D48751: nm: Add -no-weak flag for hiding weak symbols.

Update help wording

Jun 29 2018, 12:07 PM
keith updated the diff for D48751: nm: Add -no-weak flag for hiding weak symbols.

Revert unnecessary FileCheck prefix

Jun 29 2018, 10:59 AM
keith updated the diff for D48751: nm: Add -no-weak flag for hiding weak symbols.

Use count 0 instead of FileCheck for test

Jun 29 2018, 10:58 AM

Jun 28 2018

keith added reviewers for D48751: nm: Add -no-weak flag for hiding weak symbols: enderby, compnerd.
Jun 28 2018, 3:12 PM
keith created D48751: nm: Add -no-weak flag for hiding weak symbols.
Jun 28 2018, 3:08 PM