Page MenuHomePhabricator

keith (Keith Smiley)
User

Projects

User Details

User Since
Jun 25 2018, 2:18 PM (248 w, 1 d)

Recent Activity

Yesterday

keith committed rGde7639ddb05e: Added instruction to join the llvm discourse and discord group. (authored by Unique_Usman).
Added instruction to join the llvm discourse and discord group.
Mon, Mar 27, 5:02 PM · Restricted Project
keith closed D146877: Added instruction to join the llvm discourse and discord group. .
Mon, Mar 27, 5:02 PM · Restricted Project, Restricted Project
keith added a comment to D146877: Added instruction to join the llvm discourse and discord group. .

Yea sure, what email would you like me to use for the commit author email?

Mon, Mar 27, 4:44 PM · Restricted Project, Restricted Project
keith accepted D146877: Added instruction to join the llvm discourse and discord group. .

I'm not sure if there is special sign off around this file since it's so public facing but this LGTM

Mon, Mar 27, 10:52 AM · Restricted Project, Restricted Project

Fri, Mar 3

keith committed rGa65678b35bbc: [lld-macho] Avoid running LTO pipeline for no files (authored by keith).
[lld-macho] Avoid running LTO pipeline for no files
Fri, Mar 3, 3:49 PM · Restricted Project
keith closed D145273: [lld-macho] Avoid running LTO pipeline for no files.
Fri, Mar 3, 3:49 PM · Restricted Project, Restricted Project, Restricted Project
keith updated the diff for D145273: [lld-macho] Avoid running LTO pipeline for no files.

spacing

Fri, Mar 3, 2:00 PM · Restricted Project, Restricted Project, Restricted Project
keith updated the diff for D145273: [lld-macho] Avoid running LTO pipeline for no files.

Move bool into BitcodeCompiler

Fri, Mar 3, 1:56 PM · Restricted Project, Restricted Project, Restricted Project
keith abandoned D145268: [lld-macho] Fix default LTO triple.

https://reviews.llvm.org/D145273

Fri, Mar 3, 1:52 PM · Restricted Project, Restricted Project, Restricted Project
keith committed rG6578e0d1d0e4: [lld-macho] Remove duplicate minimum version info (authored by keith).
[lld-macho] Remove duplicate minimum version info
Fri, Mar 3, 1:47 PM · Restricted Project
keith closed D145263: [lld-macho] Remove duplicate minimum version info.
Fri, Mar 3, 1:47 PM · Restricted Project, Restricted Project, Restricted Project
keith added a comment to D145268: [lld-macho] Fix default LTO triple.

Huh, I'm surprised that setting -object_path_lto has a functional difference; I thought it was only to make debugging the intermediate object files easier. Did you figure out why?

Also, did you figure out why LLD-ELF doesn't seem to need to set DefaultTriple?

Fri, Mar 3, 1:29 PM · Restricted Project, Restricted Project, Restricted Project
keith requested review of D145273: [lld-macho] Avoid running LTO pipeline for no files.
Fri, Mar 3, 1:28 PM · Restricted Project, Restricted Project, Restricted Project
keith added inline comments to D145263: [lld-macho] Remove duplicate minimum version info.
Fri, Mar 3, 1:04 PM · Restricted Project, Restricted Project, Restricted Project
keith updated the diff for D145263: [lld-macho] Remove duplicate minimum version info.

update function to mutate instead of return

Fri, Mar 3, 1:04 PM · Restricted Project, Restricted Project, Restricted Project
keith retitled D145263: [lld-macho] Remove duplicate minimum version info from [lld-macho] Remove duplicate minimum version info (NFC) to [lld-macho] Remove duplicate minimum version info.
Fri, Mar 3, 12:59 PM · Restricted Project, Restricted Project, Restricted Project
keith requested review of D145268: [lld-macho] Fix default LTO triple.
Fri, Mar 3, 12:39 PM · Restricted Project, Restricted Project, Restricted Project
keith updated the diff for D145263: [lld-macho] Remove duplicate minimum version info.

remove redundent return

Fri, Mar 3, 12:20 PM · Restricted Project, Restricted Project, Restricted Project
keith requested review of D145263: [lld-macho] Remove duplicate minimum version info.
Fri, Mar 3, 12:10 PM · Restricted Project, Restricted Project, Restricted Project
keith committed rGea32351fae65: [lld-macho] Ignore -debug_variant flag (authored by keith).
[lld-macho] Ignore -debug_variant flag
Fri, Mar 3, 9:01 AM · Restricted Project
keith closed D145200: [lld-macho] Ignore -debug_variant flag.
Fri, Mar 3, 9:01 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Mar 2

keith requested review of D145200: [lld-macho] Ignore -debug_variant flag.
Thu, Mar 2, 3:11 PM · Restricted Project, Restricted Project, Restricted Project

Jan 15 2023

Herald added a project to D28758: Fix typos and update "GDB To LLDB Command Map" to be a bit more clear: Restricted Project.
Jan 15 2023, 10:35 AM · Restricted Project, Restricted Project

Jan 14 2023

keith committed rGe46d939c0fe1: [lld-macho] Improve invalid fat binary warning (authored by keith).
[lld-macho] Improve invalid fat binary warning
Jan 14 2023, 3:22 PM · Restricted Project
keith closed D141729: [lld-macho] Improve invalid fat binary warning.
Jan 14 2023, 3:22 PM · Restricted Project, Restricted Project, Restricted Project

Jan 13 2023

keith requested review of D141729: [lld-macho] Improve invalid fat binary warning.
Jan 13 2023, 2:18 PM · Restricted Project, Restricted Project, Restricted Project

Jan 12 2023

keith committed rGd4cf89ad5a37: [lld-macho] Downgrade missing fat arch to warning (authored by keith).
[lld-macho] Downgrade missing fat arch to warning
Jan 12 2023, 4:49 PM · Restricted Project
keith closed D141638: [lld-macho] Downgrade missing fat arch to warning.
Jan 12 2023, 4:49 PM · Restricted Project, Restricted Project, Restricted Project
keith requested review of D141638: [lld-macho] Downgrade missing fat arch to warning.
Jan 12 2023, 2:44 PM · Restricted Project, Restricted Project, Restricted Project

Jan 10 2023

keith abandoned D113166: [CMake] Prefer --ld-path when supported.
Jan 10 2023, 10:11 AM · Restricted Project, Restricted Project
keith abandoned D113645: [clangd] Allow Unix config paths on Darwin.
Jan 10 2023, 10:11 AM · Restricted Project, Restricted Project, Restricted Project
keith abandoned D140244: [lld-macho] Add option for ld64 autolink behavior.

https://reviews.llvm.org/D140491

Jan 10 2023, 10:10 AM · Restricted Project, Restricted Project, Restricted Project

Jan 5 2023

keith accepted D141025: [lld-macho] Don't support relocations in cstring sections.
Jan 5 2023, 8:12 AM · Restricted Project, Restricted Project, Restricted Project

Dec 23 2022

keith accepted D140634: [lld-macho] Standardize error messages.
Dec 23 2022, 3:18 PM · Restricted Project, Restricted Project, Restricted Project

Dec 22 2022

keith committed rGd6cd8d6b1987: [lld-macho] Use ld64's LC_LINKER_OPTIONS behavior by default (authored by keith).
[lld-macho] Use ld64's LC_LINKER_OPTIONS behavior by default
Dec 22 2022, 4:04 PM · Restricted Project
keith closed D140491: [lld-macho] Use ld64's LC_LINKER_OPTIONS behavior by default.
Dec 22 2022, 4:04 PM · Restricted Project, Restricted Project, Restricted Project
keith updated the diff for D140491: [lld-macho] Use ld64's LC_LINKER_OPTIONS behavior by default.

Improve variable naming, require originFile existance

Dec 22 2022, 4:03 PM · Restricted Project, Restricted Project, Restricted Project
keith committed rG2e5989e8140d: [lld-macho] Flip string deduplication default (authored by keith).
[lld-macho] Flip string deduplication default
Dec 22 2022, 3:57 PM · Restricted Project
keith closed D140517: [lld-macho] Flip string deduplication default.
Dec 22 2022, 3:57 PM · Restricted Project, Restricted Project, Restricted Project
keith updated the diff for D140491: [lld-macho] Use ld64's LC_LINKER_OPTIONS behavior by default.

Rename CLI arg, add file path to warning / error

Dec 22 2022, 1:53 PM · Restricted Project, Restricted Project, Restricted Project
keith added inline comments to D140517: [lld-macho] Flip string deduplication default.
Dec 22 2022, 1:39 PM · Restricted Project, Restricted Project, Restricted Project
keith updated the diff for D140517: [lld-macho] Flip string deduplication default.

Remove literal deduping

Dec 22 2022, 1:38 PM · Restricted Project, Restricted Project, Restricted Project
keith committed rG63173d11ecb5: [lld-macho] Fix assert when splitting section (authored by keith).
[lld-macho] Fix assert when splitting section
Dec 22 2022, 1:19 PM · Restricted Project
keith closed D140518: [lld-macho] Fix assert when splitting section.
Dec 22 2022, 1:19 PM · Restricted Project, Restricted Project, Restricted Project

Dec 21 2022

keith requested review of D140518: [lld-macho] Fix assert when splitting section.
Dec 21 2022, 4:03 PM · Restricted Project, Restricted Project, Restricted Project
keith added a comment to D140517: [lld-macho] Flip string deduplication default.

Discussion: https://discord.com/channels/636084430946959380/636732801042874388/1055235620844355595
Previous discussion: https://reviews.llvm.org/D117250

Dec 21 2022, 3:55 PM · Restricted Project, Restricted Project, Restricted Project
keith requested review of D140517: [lld-macho] Flip string deduplication default.
Dec 21 2022, 3:54 PM · Restricted Project, Restricted Project, Restricted Project
keith added a comment to D140491: [lld-macho] Use ld64's LC_LINKER_OPTIONS behavior by default.

Alternatively in this patch we could not include --strict-auto-link-options and we could remove --ignore-auto-link-option

Dec 21 2022, 12:36 PM · Restricted Project, Restricted Project, Restricted Project
keith added a comment to D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

After reading all this discussion, and seeing this well timed issue https://github.com/llvm/llvm-project/issues/59627 which is caused by this as well, I feel like we should take the opportunity to mirror ld64's behavior entirely, and potentially add a flag to opt-in to the more strict behavior that exists today. My opinion changed here since we talked about this last year because at least 5 people who have tried this have asked me about this specific issue. This issue is far more wide-spread than I originally thought in the community, and I don't think there's huge value in fixing these issues if your link succeeds anyways. Overall from this conversation it doesn't seem like anyone feels strongly enough about being strict on this issue that it justifies differing from ld64 and making adoption even just slightly harder.

Dec 21 2022, 12:07 PM · Restricted Project, Restricted Project, Restricted Project
keith requested review of D140491: [lld-macho] Use ld64's LC_LINKER_OPTIONS behavior by default.
Dec 21 2022, 12:06 PM · Restricted Project, Restricted Project, Restricted Project

Dec 16 2022

keith added a comment to D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

The benefit of per library opt outs is you can make sure new violations don't sneak in. But either way we can deal with that part separately from this if we want to add a new flag like that

Dec 16 2022, 12:56 PM · Restricted Project, Restricted Project, Restricted Project
keith added a comment to D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

If we make them warnings, you would actually be able to disable the warning today by passing --ignore-auto-link-option=Foo as well, without any new flags

Dec 16 2022, 12:44 PM · Restricted Project, Restricted Project, Restricted Project
keith added a comment to D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

Here's the ld64 mirroring option: https://reviews.llvm.org/D140244

Dec 16 2022, 12:33 PM · Restricted Project, Restricted Project, Restricted Project
keith added a comment to D140244: [lld-macho] Add option for ld64 autolink behavior.

This is one of the options being discussed on https://reviews.llvm.org/D140225

Dec 16 2022, 12:33 PM · Restricted Project, Restricted Project, Restricted Project
keith requested review of D140244: [lld-macho] Add option for ld64 autolink behavior.
Dec 16 2022, 12:32 PM · Restricted Project, Restricted Project, Restricted Project
keith added a comment to D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

I wonder if at this point we should just implement LD64's behavior with an off-by-default flag to be more strict? Specifically they ignore these failures and collect the missing ones and only print about them in the case the link fails

Dec 16 2022, 10:51 AM · Restricted Project, Restricted Project, Restricted Project

Dec 15 2022

keith accepted D140167: [lld-macho] Don't rewrite -rpath arguments in response file.
Dec 15 2022, 2:04 PM · Restricted Project, Restricted Project, Restricted Project

Dec 13 2022

keith committed rG2e5a0b3d835b: [lld-macho][test] Add test case for section ordering (authored by keith).
[lld-macho][test] Add test case for section ordering
Dec 13 2022, 1:57 PM · Restricted Project
keith closed D139959: [lld-macho][test] Add test case for section ordering.
Dec 13 2022, 1:56 PM · Restricted Project, Restricted Project, Restricted Project
keith updated the diff for D139959: [lld-macho][test] Add test case for section ordering.

Improve test naming

Dec 13 2022, 1:26 PM · Restricted Project, Restricted Project, Restricted Project
keith committed rG3a8c6a3039af: [lld-macho] Fix __objc_stubs ordering (authored by keith).
[lld-macho] Fix __objc_stubs ordering
Dec 13 2022, 1:25 PM · Restricted Project
keith closed D139909: [lld-macho] Fix __objc_stubs ordering.
Dec 13 2022, 1:24 PM · Restricted Project, Restricted Project, Restricted Project
keith requested review of D139959: [lld-macho][test] Add test case for section ordering.
Dec 13 2022, 11:01 AM · Restricted Project, Restricted Project, Restricted Project
keith added inline comments to D139909: [lld-macho] Fix __objc_stubs ordering.
Dec 13 2022, 10:12 AM · Restricted Project, Restricted Project, Restricted Project
keith updated the diff for D139909: [lld-macho] Fix __objc_stubs ordering.

Make tests address independent

Dec 13 2022, 10:11 AM · Restricted Project, Restricted Project, Restricted Project

Dec 12 2022

keith updated the diff for D139909: [lld-macho] Fix __objc_stubs ordering.

Fix test addrs

Dec 12 2022, 9:02 PM · Restricted Project, Restricted Project, Restricted Project
keith requested review of D139909: [lld-macho] Fix __objc_stubs ordering.
Dec 12 2022, 8:48 PM · Restricted Project, Restricted Project, Restricted Project
keith added a comment to D139347: [ORC] Extract hasInitializerSection for testing (NFC).

I landed, thanks all!

Dec 12 2022, 10:58 AM · Restricted Project, Restricted Project
keith committed rG988ab0048daf: [ORC] Extract hasInitializerSection for testing (NFC) (authored by keith).
[ORC] Extract hasInitializerSection for testing (NFC)
Dec 12 2022, 10:26 AM · Restricted Project, Restricted Project
keith closed D139347: [ORC] Extract hasInitializerSection for testing (NFC).
Dec 12 2022, 10:25 AM · Restricted Project, Restricted Project
keith updated the diff for D139347: [ORC] Extract hasInitializerSection for testing (NFC).

rebase to run CI

Dec 12 2022, 9:00 AM · Restricted Project, Restricted Project

Dec 8 2022

keith updated the diff for D139347: [ORC] Extract hasInitializerSection for testing (NFC).

Parameterize tests and add all test cases

Dec 8 2022, 2:49 PM · Restricted Project, Restricted Project
keith committed rGbd570709c06a: [lld-macho] Update -adhoc_codesign default (authored by keith).
[lld-macho] Update -adhoc_codesign default
Dec 8 2022, 1:49 PM · Restricted Project
keith closed D139672: [lld-macho] Update -adhoc_codesign default.
Dec 8 2022, 1:49 PM · Restricted Project, Restricted Project, Restricted Project
keith added a comment to D139672: [lld-macho] Update -adhoc_codesign default.

Yes it does, and it looks like we get that today with lld because of platform == PLATFORM_MACOS

Dec 8 2022, 1:46 PM · Restricted Project, Restricted Project, Restricted Project
keith requested review of D139672: [lld-macho] Update -adhoc_codesign default.
Dec 8 2022, 12:49 PM · Restricted Project, Restricted Project, Restricted Project

Dec 7 2022

keith committed rGa72883b7612f: [bazel] Add fenv_darwin_impl.h to target (authored by keith).
[bazel] Add fenv_darwin_impl.h to target
Dec 7 2022, 3:44 PM · Restricted Project
keith closed D139563: [bazel] Add fenv_darwin_impl.h to target.
Dec 7 2022, 3:44 PM · Restricted Project, Restricted Project
keith committed rGc9b6d641f0d6: Fix @llvm.global_ctors docs (NFC) (authored by keith).
Fix @llvm.global_ctors docs (NFC)
Dec 7 2022, 11:24 AM · Restricted Project, Restricted Project
keith added reviewers for D139563: [bazel] Add fenv_darwin_impl.h to target: bkramer, springerm.
Dec 7 2022, 11:14 AM · Restricted Project, Restricted Project
keith requested review of D139563: [bazel] Add fenv_darwin_impl.h to target.
Dec 7 2022, 11:13 AM · Restricted Project, Restricted Project

Dec 5 2022

keith abandoned D139223: [ORC] Move LinkGraphMaterializationUnit for testing (NFC).

dropping this one and went for the discussed approach in https://reviews.llvm.org/D139347 which has no overlap with this one

Dec 5 2022, 10:23 AM · Restricted Project, Restricted Project
keith requested review of D139347: [ORC] Extract hasInitializerSection for testing (NFC).
Dec 5 2022, 10:22 AM · Restricted Project, Restricted Project

Dec 2 2022

keith abandoned D139215: [ORC][test] Add initial MachOPlatformTest.
Dec 2 2022, 4:28 PM · Restricted Project, Restricted Project
keith added a comment to D139215: [ORC][test] Add initial MachOPlatformTest.

2 thoughts:

Dec 2 2022, 1:42 PM · Restricted Project, Restricted Project
keith accepted D138449: support: fix getProcessTriple in universal builds.

It feels to me like we're defeating the purpose of LLVM_HOST_TRIPLE, but I imagine any other solution to this would require a much bigger hammer, so seems worth a try.

Dec 2 2022, 1:02 PM · Restricted Project, Restricted Project
keith added a comment to D130221: [ORC] Fix macho section name typo.

I submitted https://reviews.llvm.org/D139215 and https://reviews.llvm.org/D139223 based on this discussion. Please check them out!

Dec 2 2022, 12:53 PM · Restricted Project, Restricted Project
keith added a comment to D139223: [ORC] Move LinkGraphMaterializationUnit for testing (NFC).

this isn't exactly what was discussed in https://reviews.llvm.org/D130221 but it seems like making LinkGraphMaterializationUnit accessible is nicer for unit tests where we only care to test its behavior vs the whole system. lmk what you think. Locally I also have a patch to use MachOPlatform::isInitializerSection instead of the local version here but I wanted to prove the tests pass before and after so I didn't include it yet.

Dec 2 2022, 12:52 PM · Restricted Project, Restricted Project
keith requested review of D139223: [ORC] Move LinkGraphMaterializationUnit for testing (NFC).
Dec 2 2022, 12:51 PM · Restricted Project, Restricted Project
keith requested review of D139215: [ORC][test] Add initial MachOPlatformTest.
Dec 2 2022, 10:56 AM · Restricted Project, Restricted Project

Nov 29 2022

keith committed rGc702bf1400fb: [lld-macho] Reject -no_pie for unsupported archs (authored by keith).
[lld-macho] Reject -no_pie for unsupported archs
Nov 29 2022, 11:17 AM · Restricted Project
keith closed D138884: [lld-macho] Reject -no_pie for unsupported archs.
Nov 29 2022, 11:17 AM · Restricted Project, Restricted Project, Restricted Project
keith updated the diff for D138884: [lld-macho] Reject -no_pie for unsupported archs.

Add x86_64 example showing -no_pie isn't rejected in that case

Nov 29 2022, 11:13 AM · Restricted Project, Restricted Project, Restricted Project

Nov 28 2022

keith requested review of D138884: [lld-macho] Reject -no_pie for unsupported archs.
Nov 28 2022, 5:46 PM · Restricted Project, Restricted Project, Restricted Project
keith added a comment to D138449: support: fix getProcessTriple in universal builds.

I'm not super familiar with the history behind LLVM_HOST_TRIPLE, but one thing that definitely worries me about this specific change is there are other consumers of that variable, but only this 1 gets this fixup. I feel like the core issue is the mismatch between having a single LLVM_HOST_TRIPLE, but having cmake build a fat binary.

Nov 28 2022, 5:12 PM · Restricted Project, Restricted Project

Oct 17 2022

keith added a comment to D135531: [github] Update pip deps (NFC).

Looks like this and ( D135532 ) were sent for review, but then committed before that review was attempted/completed?

Could you please wait for reviews to be completed before submitting code.

If code doesn't need pre-commit review (per the guidelines in the LLVM documentation), it's OK/correct to submit it without review - but the general idea is that if something is sent for review, it's because it needed it, and so submitting without that review is problematic (we don't want to encourage folks to submit stuff because they're frustrated with/waiting too long for review - if they felt it needed review in the first place, delayed code review doesn't change that fact)

Oct 17 2022, 6:37 PM · Restricted Project, Restricted Project

Oct 14 2022

keith committed rG14e4d92f8d07: [github] Update pip deps (NFC) (authored by keith).
[github] Update pip deps (NFC)
Oct 14 2022, 3:47 PM · Restricted Project, Restricted Project
keith committed rGc116bd9f607a: [github] Fix minor lint warnings (NFC) (authored by keith).
[github] Fix minor lint warnings (NFC)
Oct 14 2022, 3:47 PM · Restricted Project, Restricted Project
keith closed D135532: [github] Fix minor lint warnings (NFC).
Oct 14 2022, 3:47 PM · Restricted Project, Restricted Project
keith closed D135531: [github] Update pip deps (NFC).
Oct 14 2022, 3:47 PM · Restricted Project, Restricted Project