Page MenuHomePhabricator

keith (Keith Smiley)
User

Projects

User Details

User Since
Jun 25 2018, 2:18 PM (204 w, 4 d)

Recent Activity

Sat, May 21

keith accepted D126133: [llvm-nm][docs] Document -W and -U.

Awesome, thanks!

Sat, May 21, 5:43 PM · Restricted Project, Restricted Project

Thu, May 19

keith committed rG505ddb6b7450: [lld][test] Delete empty Unit test directory (authored by keith).
[lld][test] Delete empty Unit test directory
Thu, May 19, 12:07 PM · Restricted Project
keith closed D125436: [lld][test] Delete empty Unit test directory.
Thu, May 19, 12:06 PM · Restricted Project, Restricted Project
keith committed rGa1cf20f012ba: [llvm-dis][test] Fix error case on Windows (authored by keith).
[llvm-dis][test] Fix error case on Windows
Thu, May 19, 11:31 AM · Restricted Project, Restricted Project
keith committed rG2569f79a4fe4: [llvm-dis] Improve missing file error message (authored by keith).
[llvm-dis] Improve missing file error message
Thu, May 19, 11:10 AM · Restricted Project, Restricted Project
keith closed D121665: [llvm-dis] Improve missing file error message.
Thu, May 19, 11:09 AM · Restricted Project, Restricted Project
keith committed rG6746e6a37284: [docs][tools] Remove old llvm-bcanalyzer options (authored by keith).
[docs][tools] Remove old llvm-bcanalyzer options
Thu, May 19, 11:07 AM · Restricted Project, Restricted Project
keith closed D122361: [docs][tools] Remove old llvm-bcanalyzer options.
Thu, May 19, 11:07 AM · Restricted Project, Restricted Project
keith committed rG066243057fc2: [Object] Fix updating darwin archives (authored by keith).
[Object] Fix updating darwin archives
Thu, May 19, 11:06 AM · Restricted Project, Restricted Project
keith closed D124895: [Object] Fix updating darwin archives.
Thu, May 19, 11:06 AM · Restricted Project, Restricted Project
keith added a reviewer for D125436: [lld][test] Delete empty Unit test directory: MaskRay.

wdyt?

Thu, May 19, 10:58 AM · Restricted Project, Restricted Project
keith updated the diff for D124895: [Object] Fix updating darwin archives.

Improve name and add comment

Thu, May 19, 9:50 AM · Restricted Project, Restricted Project

Wed, May 18

keith added a comment to D124895: [Object] Fix updating darwin archives.

friendly ping!

Wed, May 18, 11:24 AM · Restricted Project, Restricted Project

Tue, May 17

keith added a comment to D125478: [llvm-objcopy][test] Add cmp after copy.

Yea it passes on my M1 machine, I will test on Intel and see if that's the difference, I have reverted since so hopefully everyone is back to green and I'll debug async and post here with the new fix.

Tue, May 17, 11:56 AM · Restricted Project, Restricted Project
keith added a reverting change for rG0d863b5b90a2: [llvm-objcopy][test] Add cmp after copy: rG627928c58bd4: Revert "[llvm-objcopy][test] Add cmp after copy".
Tue, May 17, 9:07 AM · Restricted Project, Restricted Project
keith committed rG627928c58bd4: Revert "[llvm-objcopy][test] Add cmp after copy" (authored by keith).
Revert "[llvm-objcopy][test] Add cmp after copy"
Tue, May 17, 9:07 AM · Restricted Project, Restricted Project
keith added a reverting change for D125478: [llvm-objcopy][test] Add cmp after copy: rG627928c58bd4: Revert "[llvm-objcopy][test] Add cmp after copy".
Tue, May 17, 9:07 AM · Restricted Project, Restricted Project

Mon, May 16

keith accepted D125732: [lld-macho] Demangle symbol name in export error msg when -demangle is specified.
Mon, May 16, 4:28 PM · Restricted Project, Restricted Project, Restricted Project
keith committed rG0d863b5b90a2: [llvm-objcopy][test] Add cmp after copy (authored by keith).
[llvm-objcopy][test] Add cmp after copy
Mon, May 16, 4:05 PM · Restricted Project, Restricted Project
keith closed D125478: [llvm-objcopy][test] Add cmp after copy.
Mon, May 16, 4:05 PM · Restricted Project, Restricted Project

Thu, May 12

keith requested review of D125478: [llvm-objcopy][test] Add cmp after copy.
Thu, May 12, 10:30 AM · Restricted Project, Restricted Project
keith updated the diff for D124895: [Object] Fix updating darwin archives.

Fix comment formatting

Thu, May 12, 10:11 AM · Restricted Project, Restricted Project

Wed, May 11

keith requested review of D125436: [lld][test] Delete empty Unit test directory.
Wed, May 11, 5:12 PM · Restricted Project, Restricted Project
keith committed rGd64bad8ff126: [lld/macho] Fixes the -ObjC flag (authored by tt).
[lld/macho] Fixes the -ObjC flag
Wed, May 11, 5:04 PM · Restricted Project
keith closed D125250: [lld/macho] Fixes the -ObjC flag.
Wed, May 11, 5:03 PM · Restricted Project, Restricted Project, Restricted Project
keith added inline comments to D125250: [lld/macho] Fixes the -ObjC flag.
Wed, May 11, 12:06 PM · Restricted Project, Restricted Project, Restricted Project
keith added inline comments to D124895: [Object] Fix updating darwin archives.
Wed, May 11, 11:53 AM · Restricted Project, Restricted Project
keith updated the diff for D124895: [Object] Fix updating darwin archives.

Extract previous llvm-ar logic instead of using a new function

Wed, May 11, 11:53 AM · Restricted Project, Restricted Project

Tue, May 10

keith accepted D125250: [lld/macho] Fixes the -ObjC flag.
Tue, May 10, 2:40 PM · Restricted Project, Restricted Project, Restricted Project

Mon, May 9

keith added a comment to D125250: [lld/macho] Fixes the -ObjC flag.

Which sections specifically hit this? can you add a test?

Mon, May 9, 12:01 PM · Restricted Project, Restricted Project, Restricted Project
keith updated the diff for D124895: [Object] Fix updating darwin archives.

Add required target to archive-format.test

Mon, May 9, 10:17 AM · Restricted Project, Restricted Project
keith updated the diff for D124895: [Object] Fix updating darwin archives.

Improve tests

Mon, May 9, 9:08 AM · Restricted Project, Restricted Project

Sun, May 8

keith updated the diff for D124895: [Object] Fix updating darwin archives.

Improve tests

Sun, May 8, 8:55 PM · Restricted Project, Restricted Project

Sat, May 7

keith updated the diff for D124895: [Object] Fix updating darwin archives.

Add test for universal object archive copy

Sat, May 7, 12:11 PM · Restricted Project, Restricted Project
keith updated the diff for D124895: [Object] Fix updating darwin archives.

Change test strategy to test for timestamps instead of alignment. This gives us the same result knowing that the darwin specific logic is hit, and it's easier to test for than crafting an unaligned binary.

Sat, May 7, 11:36 AM · Restricted Project, Restricted Project
keith updated the diff for D124895: [Object] Fix updating darwin archives.

Remove unused import

Sat, May 7, 10:47 AM · Restricted Project, Restricted Project
keith updated the diff for D124895: [Object] Fix updating darwin archives.

Move isMacho to Object library

Sat, May 7, 10:46 AM · Restricted Project, Restricted Project

Thu, May 5

keith added inline comments to D124895: [Object] Fix updating darwin archives.
Thu, May 5, 2:28 PM · Restricted Project, Restricted Project
keith updated the diff for D124895: [Object] Fix updating darwin archives.

Move format decision to callers

Thu, May 5, 2:25 PM · Restricted Project, Restricted Project
keith added a comment to D124895: [Object] Fix updating darwin archives.

Of course, if ld64 is ever removed in favor of lld, we could stop worrying about most of these issues

Thu, May 5, 9:14 AM · Restricted Project, Restricted Project

Wed, May 4

keith updated the diff for D124895: [Object] Fix updating darwin archives.

Update to only check new Kind when writing

Wed, May 4, 6:04 PM · Restricted Project, Restricted Project
keith added inline comments to D124895: [Object] Fix updating darwin archives.
Wed, May 4, 5:49 PM · Restricted Project, Restricted Project
keith added a comment to D124895: [Object] Fix updating darwin archives.

I don't think we ought to modify the archive reader like you've done, because we don't need to tell the difference between BSD/DARWIN when reading, only while writing. Thus, going through the trouble of distinguishing them in the reader is wasted work. Instead, please add a separate function, which ar and objcopy can call before constructing an ArchiveWriter, which returns the more "refined" Kind.

Wed, May 4, 5:48 PM · Restricted Project, Restricted Project

Tue, May 3

keith updated the summary of D124895: [Object] Fix updating darwin archives.
Tue, May 3, 8:03 PM · Restricted Project, Restricted Project
keith updated the diff for D124895: [Object] Fix updating darwin archives.

Fix spelling

Tue, May 3, 7:19 PM · Restricted Project, Restricted Project
keith requested review of D124895: [Object] Fix updating darwin archives.
Tue, May 3, 6:51 PM · Restricted Project, Restricted Project

Mon, May 2

keith added a comment to D124767: [Clang] Map .gcda paths according to -fcoverage-prefix-map.

I took this comment from the issue:

Mon, May 2, 3:17 PM · Restricted Project, Restricted Project
keith added a comment to D124767: [Clang] Map .gcda paths according to -fcoverage-prefix-map.

Based on the issue it sounds like this should be gated behind a new -fprofile-prefix-map flag? I assume we'd also want -ffile-prefix-map to apply to it as well, similar to the others. And we'll definitely want some tests here!

Mon, May 2, 11:24 AM · Restricted Project, Restricted Project

Apr 22 2022

keith committed rG2d8cf26d0870: [lld-macho] Fix crash on invalid framework tbd (authored by keith).
[lld-macho] Fix crash on invalid framework tbd
Apr 22 2022, 10:27 AM · Restricted Project
keith closed D124271: [lld-macho] Fix crash on invalid framework tbd.
Apr 22 2022, 10:27 AM · Restricted Project, Restricted Project, Restricted Project
keith added inline comments to D114841: [lld-macho] Fix duplicate symbols with relocatable objects.
Apr 22 2022, 9:43 AM · Restricted Project, Restricted Project, Restricted Project
keith requested review of D124271: [lld-macho] Fix crash on invalid framework tbd.
Apr 22 2022, 9:43 AM · Restricted Project, Restricted Project, Restricted Project

Apr 9 2022

keith added a reviewer for D121667: [llvm-cov] Assume repeat architectures for universal binaries: kastiglione.
Apr 9 2022, 2:57 PM · Restricted Project, Restricted Project
keith added a reviewer for D121665: [llvm-dis] Improve missing file error message: kastiglione.
Apr 9 2022, 2:51 PM · Restricted Project, Restricted Project
keith added a reviewer for D122361: [docs][tools] Remove old llvm-bcanalyzer options: kastiglione.
Apr 9 2022, 2:51 PM · Restricted Project, Restricted Project

Apr 5 2022

keith abandoned D122924: [lld] Add version info to generic driver output.
Apr 5 2022, 5:18 PM · Restricted Project, Restricted Project
keith added a member for lld: keith.
Apr 5 2022, 5:14 PM
keith accepted D123074: [clang-tidy][run-clang-tidy.py] Fix typo in new -config-file option.
Apr 5 2022, 1:26 PM · Restricted Project, Restricted Project

Apr 4 2022

keith added a comment to D122924: [lld] Add version info to generic driver output.

I doubt they're super common, but I figured the complexity of adding this was so low that it made sense to. In my case I was trying to compare versions of the installed lld on linux systems at /usr/bin/lld, so I found myself trying to do /usr/bin/ld --version and then /usr/bin/lld --version, where the latter didn't print the version. I don't think we have to worry about more folks calling this since the utility of calling it is still very small, and the output is clear that the other shims should be called.

Apr 4 2022, 10:14 PM · Restricted Project, Restricted Project
keith added a comment to D122924: [lld] Add version info to generic driver output.

This is purely a convenience addition so users don't have to know about -flavor gnu, or specify one of the other shims

Apr 4 2022, 9:27 PM · Restricted Project, Restricted Project
keith added a reviewer for D122924: [lld] Add version info to generic driver output: MaskRay.
Apr 4 2022, 9:10 PM · Restricted Project, Restricted Project
keith updated the summary of D122924: [lld] Add version info to generic driver output.
Apr 4 2022, 9:10 PM · Restricted Project, Restricted Project
keith updated the diff for D122924: [lld] Add version info to generic driver output.

Improve formatting

Apr 4 2022, 9:09 PM · Restricted Project, Restricted Project
keith added a reviewer for D122361: [docs][tools] Remove old llvm-bcanalyzer options: mehdi_amini.
Apr 4 2022, 8:55 PM · Restricted Project, Restricted Project
keith added reviewers for D121667: [llvm-cov] Assume repeat architectures for universal binaries: phosek, kazu.
Apr 4 2022, 8:55 PM · Restricted Project, Restricted Project
keith added a reviewer for D121665: [llvm-dis] Improve missing file error message: ormris.
Apr 4 2022, 8:54 PM · Restricted Project, Restricted Project

Apr 1 2022

keith requested review of D122924: [lld] Add version info to generic driver output.
Apr 1 2022, 10:56 AM · Restricted Project, Restricted Project

Mar 31 2022

keith accepted D122843: [lld-macho] Include output filename in UUID hash.
Mar 31 2022, 1:49 PM · Restricted Project, Restricted Project, Restricted Project
keith added inline comments to D122843: [lld-macho] Include output filename in UUID hash.
Mar 31 2022, 12:25 PM · Restricted Project, Restricted Project, Restricted Project
keith added inline comments to D122843: [lld-macho] Include output filename in UUID hash.
Mar 31 2022, 12:05 PM · Restricted Project, Restricted Project, Restricted Project

Mar 23 2022

keith requested review of D122361: [docs][tools] Remove old llvm-bcanalyzer options.
Mar 23 2022, 4:30 PM · Restricted Project, Restricted Project
keith added a reverting change for rGfc3cdd0b295a: Revert "[AArch64] Add support for -march=native for Apple M1 CPU": rG955cff803e08: reland: [AArch64] Add support for -march=native for Apple M1 CPU.
Mar 23 2022, 3:19 PM · Restricted Project
keith committed rG955cff803e08: reland: [AArch64] Add support for -march=native for Apple M1 CPU (authored by keith).
reland: [AArch64] Add support for -march=native for Apple M1 CPU
Mar 23 2022, 3:19 PM · Restricted Project
keith added a reverting change for rGfcca10c69aaa: [AArch64] Add support for -march=native for Apple M1 CPU: rGfc3cdd0b295a: Revert "[AArch64] Add support for -march=native for Apple M1 CPU".
Mar 23 2022, 2:27 PM · Restricted Project
keith committed rGfc3cdd0b295a: Revert "[AArch64] Add support for -march=native for Apple M1 CPU" (authored by keith).
Revert "[AArch64] Add support for -march=native for Apple M1 CPU"
Mar 23 2022, 2:27 PM · Restricted Project
keith added a reverting change for D119788: [AArch64] Add support for -march=native for Apple M1 CPU: rGfc3cdd0b295a: Revert "[AArch64] Add support for -march=native for Apple M1 CPU".
Mar 23 2022, 2:27 PM · Restricted Project, Restricted Project, Restricted Project
keith committed rGfcca10c69aaa: [AArch64] Add support for -march=native for Apple M1 CPU (authored by keith).
[AArch64] Add support for -march=native for Apple M1 CPU
Mar 23 2022, 2:07 PM · Restricted Project
keith closed D119788: [AArch64] Add support for -march=native for Apple M1 CPU.
Mar 23 2022, 2:07 PM · Restricted Project, Restricted Project, Restricted Project

Mar 15 2022

keith abandoned D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map.

There were 2 competing revisions for this bug fix, I landed https://reviews.llvm.org/D121663 instead since it sounds like having an empty directory is more correct in this case

Mar 15 2022, 1:43 PM · Restricted Project, Restricted Project
keith committed rGa2db7d5e9c52: reland: [clang] Don't append the working directory to absolute paths (authored by keith).
reland: [clang] Don't append the working directory to absolute paths
Mar 15 2022, 1:43 PM · Restricted Project
keith closed D121663: reland: [clang] Don't append the working directory to absolute paths.
Mar 15 2022, 1:42 PM · Restricted Project, Restricted Project
keith added a comment to D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map.

You're right it's version 5 not 4, maybe the issue is that some platforms (like macOS) are defaulting to 4 intentionally for now? I guess I thought 6 because passing 6 also reproduces, but I didn't also try 5.

Mar 15 2022, 1:37 PM · Restricted Project, Restricted Project
keith added inline comments to D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map.
Mar 15 2022, 9:19 AM · Restricted Project, Restricted Project
keith added a comment to D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map.

I actually mean dwarf 6, which appears to be partially implemented according to https://lists.llvm.org/pipermail/llvm-dev/2020-April/141055.html

Mar 15 2022, 9:18 AM · Restricted Project, Restricted Project

Mar 14 2022

keith requested review of D121667: [llvm-cov] Assume repeat architectures for universal binaries.
Mar 14 2022, 9:59 PM · Restricted Project, Restricted Project
keith requested review of D121665: [llvm-dis] Improve missing file error message.
Mar 14 2022, 9:51 PM · Restricted Project, Restricted Project
keith requested review of D121663: reland: [clang] Don't append the working directory to absolute paths.
Mar 14 2022, 8:55 PM · Restricted Project, Restricted Project
keith updated the diff for D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map.

Fix tests with dwarf 6

Mar 14 2022, 8:42 PM · Restricted Project, Restricted Project
keith committed rGcb22d71806b7: [clang] Fix DIFile directory root on Windows (authored by keith).
[clang] Fix DIFile directory root on Windows
Mar 14 2022, 8:11 PM · Restricted Project
keith closed D111579: [clang] Fix DIFile directory root on Windows.
Mar 14 2022, 8:10 PM · Restricted Project, Restricted Project
keith added a comment to D119788: [AArch64] Add support for -march=native for Apple M1 CPU.

Bump, I think I've covered everything here, let me know if not!

Mar 14 2022, 8:09 PM · Restricted Project, Restricted Project, Restricted Project
keith committed rG6541d3e979c1: [test] Add lit helper for windows paths (authored by keith).
[test] Add lit helper for windows paths
Mar 14 2022, 8:06 PM · Restricted Project
keith closed D111457: [test] Add lit helper for windows paths.
Mar 14 2022, 8:06 PM · Restricted Project, Restricted Project, Restricted Project
keith updated the diff for D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map.

Update subsitutions with slashes

Mar 14 2022, 6:11 PM · Restricted Project, Restricted Project
keith updated the diff for D111579: [clang] Fix DIFile directory root on Windows.

Update subsitutions with dashes

Mar 14 2022, 6:09 PM · Restricted Project, Restricted Project
keith updated the diff for D111457: [test] Add lit helper for windows paths.

Update substitutions to use dashes

Mar 14 2022, 6:08 PM · Restricted Project, Restricted Project, Restricted Project
keith committed rG5da83eeb91ba: clang-tidy: discover binaries in build dir (authored by keith).
clang-tidy: discover binaries in build dir
Mar 14 2022, 9:05 AM · Restricted Project, Restricted Project
keith closed D100692: clang-tidy: discover binaries in build dir.
Mar 14 2022, 9:05 AM · Restricted Project, Restricted Project
keith added a comment to D111579: [clang] Fix DIFile directory root on Windows.

Ping, all green here, I just had to mess with the test regex a bit

Mar 14 2022, 9:03 AM · Restricted Project, Restricted Project

Mar 13 2022

keith updated the diff for D111579: [clang] Fix DIFile directory root on Windows.

Replace \w with .

Mar 13 2022, 10:16 PM · Restricted Project, Restricted Project