Page MenuHomePhabricator

keith (Keith Smiley)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 25 2018, 2:18 PM (126 w, 6 d)

Recent Activity

Fri, Nov 20

keith committed rG244022a3cd75: Don’t break before nested block param when prior param is not a block (authored by segiddins).
Don’t break before nested block param when prior param is not a block
Fri, Nov 20, 3:20 PM
keith closed D91669: Don’t break before nested block param when prior param is not a block.
Fri, Nov 20, 3:19 PM · Restricted Project

Wed, Nov 18

keith accepted D91742: [lldb] Add examples and reword source-map help string.
Wed, Nov 18, 2:07 PM · Restricted Project
keith added a reviewer for D91669: Don’t break before nested block param when prior param is not a block: djasper.
Wed, Nov 18, 2:05 PM · Restricted Project
keith accepted D91669: Don’t break before nested block param when prior param is not a block.
Wed, Nov 18, 1:23 PM · Restricted Project

Mon, Nov 16

keith abandoned D17922: [clang-format] Don't add a space before Obj-C selector methods that are also clang-format keywords.
Mon, Nov 16, 5:03 PM
keith commandeered D17922: [clang-format] Don't add a space before Obj-C selector methods that are also clang-format keywords.

Note the test case shown here passes on master, so we can drop this

Mon, Nov 16, 5:03 PM

Mon, Nov 9

keith committed rG2319c49339b9: [llvm-cov][NFC] Fix typo in format comment (authored by keith).
[llvm-cov][NFC] Fix typo in format comment
Mon, Nov 9, 2:48 PM

Mon, Nov 2

keith requested review of D90646: [clang] Add warning when `-include-pch` is passed multiple times.
Mon, Nov 2, 1:53 PM · Restricted Project
keith accepted D87928: Provide -fsource-dir flag in Clang.
Mon, Nov 2, 8:43 AM · Restricted Project, Restricted Project

Oct 30 2020

keith committed rGbbf02e18f536: [clang][NFC] Remove unused FileCheck prefix (authored by keith).
[clang][NFC] Remove unused FileCheck prefix
Oct 30 2020, 1:33 PM
keith closed D90430: [clang][NFC] Remove unused FileCheck prefix.
Oct 30 2020, 1:32 PM · Restricted Project
keith committed rGe7ada98b56da: [llvm-cov][NFC] Remove unused prefixes from FileCheck usage (authored by keith).
[llvm-cov][NFC] Remove unused prefixes from FileCheck usage
Oct 30 2020, 8:29 AM
keith closed D90423: [llvm-cov][NFC] Remove unused prefixes from FileCheck usage.
Oct 30 2020, 8:28 AM · Restricted Project

Oct 29 2020

keith added a comment to D90427: [llvm-readobj][NFC] Remove unused prefix from FileCheck tests.

Thanks! I actually just requested access so we'll see!

Oct 29 2020, 5:51 PM · Restricted Project
keith added a comment to D90427: [llvm-readobj][NFC] Remove unused prefix from FileCheck tests.

Thanks! I don't have commit access do you mind landing this for me?

Oct 29 2020, 5:35 PM · Restricted Project
keith added a comment to D90423: [llvm-cov][NFC] Remove unused prefixes from FileCheck usage.

Thanks! I don't have merge access do you mind helping me land this?

Oct 29 2020, 3:17 PM · Restricted Project
keith requested review of D90430: [clang][NFC] Remove unused FileCheck prefix.
Oct 29 2020, 2:11 PM · Restricted Project
keith requested review of D90427: [llvm-readobj][NFC] Remove unused prefix from FileCheck tests.
Oct 29 2020, 2:02 PM · Restricted Project
keith retitled D90423: [llvm-cov][NFC] Remove unused prefixes from FileCheck usage from [llvm-cov] Remove unused prefixes from FileCheck usage to [llvm-cov][NFC] Remove unused prefixes from FileCheck usage.
Oct 29 2020, 2:01 PM · Restricted Project
keith added a reviewer for D90423: [llvm-cov][NFC] Remove unused prefixes from FileCheck usage: vsk.
Oct 29 2020, 1:58 PM · Restricted Project
keith requested review of D90423: [llvm-cov][NFC] Remove unused prefixes from FileCheck usage.
Oct 29 2020, 1:54 PM · Restricted Project

Oct 28 2020

keith added a comment to D90080: [llvm-objcopy] Quote passed rpath args in errors.

Thanks all! Can someone land this for me again?

Oct 28 2020, 11:08 AM · Restricted Project

Oct 23 2020

keith added inline comments to D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.
Oct 23 2020, 3:35 PM · Restricted Project
keith requested review of D90080: [llvm-objcopy] Quote passed rpath args in errors.
Oct 23 2020, 3:34 PM · Restricted Project

Oct 21 2020

keith updated the diff for D89713: [llvm-objcopy][NFC] extract arg parsing logic to function.

Make function static

Oct 21 2020, 9:22 AM · Restricted Project
keith retitled D89713: [llvm-objcopy][NFC] extract arg parsing logic to function from [llvm-objcopy] extract arg parsing logic to function to [llvm-objcopy][NFC] extract arg parsing logic to function.
Oct 21 2020, 9:20 AM · Restricted Project
keith added inline comments to D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.
Oct 21 2020, 9:20 AM · Restricted Project

Oct 20 2020

keith added a comment to D89713: [llvm-objcopy][NFC] extract arg parsing logic to function.

Thanks!

Oct 20 2020, 8:32 AM · Restricted Project
keith updated the diff for D89713: [llvm-objcopy][NFC] extract arg parsing logic to function.

Remove unused enum

Oct 20 2020, 8:32 AM · Restricted Project
keith updated the summary of D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.
Oct 20 2020, 8:31 AM · Restricted Project
keith retitled D89713: [llvm-objcopy][NFC] extract arg parsing logic to function from llvm-objcopy: extract arg parsing logic to function to [llvm-objcopy] extract arg parsing logic to function.
Oct 20 2020, 8:30 AM · Restricted Project
keith added a comment to D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

Thanks for the review!

Oct 20 2020, 8:30 AM · Restricted Project
keith retitled D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option from Add -prepend_rpath install-name-tool option to [llvm-objcopy] Add -prepend_rpath install-name-tool option.
Oct 20 2020, 8:30 AM · Restricted Project
keith updated the diff for D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

Address review comments

Oct 20 2020, 8:29 AM · Restricted Project

Oct 19 2020

keith added a comment to D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

I believe my author info was correct, but I've updated it using the command mentioned in the doc. Thanks!

Oct 19 2020, 3:08 PM · Restricted Project
keith updated the diff for D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

Update author

Oct 19 2020, 3:08 PM · Restricted Project
keith added a comment to D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

Thanks! I don't have merge access can you help me land this?

Oct 19 2020, 10:53 AM · Restricted Project
keith updated the diff for D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

Add comment about recalculation

Oct 19 2020, 10:12 AM · Restricted Project
keith requested review of D89713: [llvm-objcopy][NFC] extract arg parsing logic to function.
Oct 19 2020, 10:10 AM · Restricted Project

Oct 16 2020

keith retitled D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option from Add -insert_rpath install-name-tool option to Add -prepend_rpath install-name-tool option.
Oct 16 2020, 8:54 PM · Restricted Project
keith updated the diff for D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.

Rename to -prepend_rpath

Oct 16 2020, 8:54 PM · Restricted Project
keith requested review of D89605: [llvm-objcopy] Add -prepend_rpath install-name-tool option.
Oct 16 2020, 5:10 PM · Restricted Project

Sep 22 2020

keith added a comment to D83154: clang: Add -fcoverage-prefix-map.

Should we wait for that one to land and then pick this one up? Otherwise any thoughts on the outstanding discussion?

Sep 22 2020, 10:52 AM · Restricted Project

Sep 21 2020

keith added a comment to D83154: clang: Add -fcoverage-prefix-map.

With D87928 do you think we would want this flag as well? The only difference I can think of (besides general UX) is if you need to remap paths outside of your source root, I believe having a *-prefix-map style flag makes that a bit more clear (or potentially possible at all). Ideally there wouldn't be issues around that but in the past in the Apple toolchain the Xcode path was embedded in debug info (as an example), so to get a reproducible build we had to pass -fdebug-prefix-map=/path/to/Xcode.app=SOMETHING. Which -fdebug-compilation-dir . couldn't solve. I'm wondering if we should add both flags for this flexibility, or if we should assume this should not happen?

Sep 21 2020, 5:16 PM · Restricted Project
keith added a comment to D87928: Provide -fsource-dir flag in Clang.

This change is trying to address the issues raised in D83154. There are still some open questions:

  • Is -fsource-dir the best name for this flag?
Sep 21 2020, 5:08 PM · Restricted Project, Restricted Project

Sep 15 2020

keith added inline comments to D83154: clang: Add -fcoverage-prefix-map.
Sep 15 2020, 6:02 PM · Restricted Project

Sep 12 2020

keith added inline comments to D83154: clang: Add -fcoverage-prefix-map.
Sep 12 2020, 12:49 PM · Restricted Project

Sep 9 2020

keith added inline comments to D83154: clang: Add -fcoverage-prefix-map.
Sep 9 2020, 5:27 PM · Restricted Project
keith updated the diff for D83154: clang: Add -fcoverage-prefix-map.

Small fixes

Sep 9 2020, 5:27 PM · Restricted Project

Sep 8 2020

keith updated the diff for D83154: clang: Add -fcoverage-prefix-map.

Rename from fcoverage-prefix-map to fprofile-prefix-map

Sep 8 2020, 4:53 PM · Restricted Project
keith retitled D83154: clang: Add -fcoverage-prefix-map from clang: Add -fdebug-prefix-map to clang: Add -fprofile-prefix-map.
Sep 8 2020, 4:53 PM · Restricted Project
keith retitled D83154: clang: Add -fcoverage-prefix-map from clang: Add -fcoverage-prefix-map to clang: Add -fdebug-prefix-map.
Sep 8 2020, 4:52 PM · Restricted Project

Aug 18 2020

keith added a comment to D83154: clang: Add -fcoverage-prefix-map.

Yes I do, sorry I've been a bit busy, I will try to get to this later this week

Aug 18 2020, 7:04 PM · Restricted Project

Jul 16 2020

keith added a comment to D83152: llvm-nm: add flag to suppress no symbols warning.

Is there a build step executing llvm-nm that chokes on this? Can you say more about the use case?

Jul 16 2020, 1:41 PM · Restricted Project

Jul 14 2020

keith committed rG852b4f2dcf46: [llvm-cov] Add support for -skip-functions to lcov (authored by keith).
[llvm-cov] Add support for -skip-functions to lcov
Jul 14 2020, 4:21 PM

Jul 6 2020

keith added a comment to D83154: clang: Add -fcoverage-prefix-map.

I originally implemented this behavior behind -fdebug-prefix-map but there was some pushback, more context: https://lists.llvm.org/pipermail/cfe-dev/2020-June/065668.html

Jul 6 2020, 6:15 PM · Restricted Project
keith added a comment to D83152: llvm-nm: add flag to suppress no symbols warning.

I cannot find any search result about no-warning-for-no-symbols. Is -no-warning-for-no-symbols really an existing option? libtool is an ar like tool.

I found it by looking for underscores instead of hyphens: -no_warning_for_no_symbols.
However, the flag is an ar/ranlib/libtool flag, not nm, AFAICT.

Jul 6 2020, 3:08 PM · Restricted Project

Jul 4 2020

keith updated the diff for D83154: clang: Add -fcoverage-prefix-map.

Fix tests on Windows

Jul 4 2020, 10:12 AM · Restricted Project

Jul 3 2020

keith added a comment to D83154: clang: Add -fcoverage-prefix-map.

Open question: I don't know how all the toolchains fit together, but I noticed that only Clang.cpp handles -fmacro-prefix-map, but Clang.cpp, FreeBSD.cpp, and Gnu.cpp all handle -fdebug-prefix-map. I wasn't sure which pattern I should follow here, so right now this only adds the handling to Clang.cpp, please let me know if that's not appropriate in this case!

Jul 3 2020, 10:42 PM · Restricted Project
keith abandoned D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings.

https://reviews.llvm.org/D83154

Jul 3 2020, 10:42 PM · Restricted Project, Restricted Project
keith created D83154: clang: Add -fcoverage-prefix-map.
Jul 3 2020, 10:42 PM · Restricted Project
keith created D83152: llvm-nm: add flag to suppress no symbols warning.
Jul 3 2020, 9:09 PM · Restricted Project
keith abandoned D80660: clang: Add support for relative linker paths with -fuse-ld.

https://reviews.llvm.org/D83015

Jul 3 2020, 10:44 AM · Restricted Project

Jul 1 2020

keith accepted D83015: [Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path.

Awesome!

Jul 1 2020, 6:23 PM · Restricted Project

Jun 11 2020

keith abandoned D81338: Remove diff file from root of repo.

No problem, thanks!

Jun 11 2020, 11:32 AM · Restricted Project

Jun 8 2020

keith added a comment to D81338: Remove diff file from root of repo.

@fhahn can you help land this? I don't have access. The failure does appear to be related but it seems like just applying this patch is failing, which I don't understand

Jun 8 2020, 4:39 PM · Restricted Project

Jun 6 2020

keith created D81338: Remove diff file from root of repo.
Jun 6 2020, 9:52 PM · Restricted Project
keith added a reviewer for D81338: Remove diff file from root of repo: TWeaver.
Jun 6 2020, 9:52 PM · Restricted Project

Jun 4 2020

keith added a comment to D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings.

FYI I actually removed that piece this morning since I felt like since this now supports -path-equivalence=.,foo which is the "expected" behavior from lldb, that was "good enough". lmk if you want me to add it back!

Jun 4 2020, 11:33 AM · Restricted Project, Restricted Project
keith updated the summary of D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings.
Jun 4 2020, 9:53 AM · Restricted Project, Restricted Project
keith updated the diff for D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings.

Update relative paths to include the leading ./

Jun 4 2020, 9:53 AM · Restricted Project, Restricted Project

Jun 3 2020

keith created D81122: Reland: Use -fdebug-compilation-dir to form absolute paths in coverage mappings.
Jun 3 2020, 4:02 PM · Restricted Project, Restricted Project

Jun 2 2020

keith updated the diff for D80660: clang: Add support for relative linker paths with -fuse-ld.

Fix test on windows

Jun 2 2020, 2:16 PM · Restricted Project

May 28 2020

keith added a comment to D80660: clang: Add support for relative linker paths with -fuse-ld.

The new test failure appears unrelated to my changes

May 28 2020, 5:05 PM · Restricted Project
keith updated the diff for D80660: clang: Add support for relative linker paths with -fuse-ld.

Update tests

May 28 2020, 3:59 PM · Restricted Project
keith added a comment to D80660: clang: Add support for relative linker paths with -fuse-ld.

Thanks I moved them to the bottom and I believe I fixed them on windows!

May 28 2020, 3:59 PM · Restricted Project

May 27 2020

keith added a comment to D80225: [Driver] Recognize -fuse-ld={bfd,gold,lld} but don't prepend "ld." or "ld64." for other values.

I've submitted a related change to accept relative paths for -fuse-ld https://reviews.llvm.org/D80660

May 27 2020, 2:09 PM · Restricted Project
keith created D80660: clang: Add support for relative linker paths with -fuse-ld.
May 27 2020, 2:09 PM · Restricted Project

Jan 22 2020

keith added a comment to D73160: [llvm-cov] Add support for -skip-functions to lcov.

Can someone land this for me? I don't have permissions to do that AFAIK

Jan 22 2020, 12:33 PM · Restricted Project

Jan 21 2020

keith created D73160: [llvm-cov] Add support for -skip-functions to lcov.
Jan 21 2020, 9:27 PM · Restricted Project

Nov 4 2018

keith updated subscribers of D49776: Update framework-header-fix to force system sed.

No worries, thanks!

Nov 4 2018, 8:49 AM

Jul 31 2018

keith created D50114: nm: Add no-file-header to suppress object files.
Jul 31 2018, 4:13 PM

Jul 26 2018

keith added a comment to D49779: Make framework-header-fix process copied headers.

No problem! Yes please! :)

Jul 26 2018, 12:00 PM
keith added inline comments to D49779: Make framework-header-fix process copied headers.
Jul 26 2018, 11:55 AM
keith updated the diff for D49779: Make framework-header-fix process copied headers.
  • Hoist LLDB.framework headers copy out of condition
Jul 26 2018, 11:54 AM
keith added inline comments to D49779: Make framework-header-fix process copied headers.
Jul 26 2018, 11:25 AM
keith added inline comments to D49779: Make framework-header-fix process copied headers.
Jul 26 2018, 11:07 AM
keith added inline comments to D49779: Make framework-header-fix process copied headers.
Jul 26 2018, 10:24 AM
keith updated the diff for D49779: Make framework-header-fix process copied headers.
  • Make headers a post build command
Jul 26 2018, 10:24 AM

Jul 25 2018

keith added inline comments to D49779: Make framework-header-fix process copied headers.
Jul 25 2018, 10:19 AM
keith updated subscribers of D49776: Update framework-header-fix to force system sed.
Jul 25 2018, 12:47 AM
keith updated subscribers of D49776: Update framework-header-fix to force system sed.
Jul 25 2018, 12:46 AM
keith added a comment to D49779: Make framework-header-fix process copied headers.

It seems like if this was a common occurrence, it would've been fixed earlier, so I'm wondering if there's a difference in the way I'm building lldb that causes this. Using cmake:

Jul 25 2018, 12:45 AM
keith created D49779: Make framework-header-fix process copied headers.
Jul 25 2018, 12:43 AM
keith updated the summary of D49776: Update framework-header-fix to force system sed.
Jul 25 2018, 12:22 AM
keith updated the summary of D49776: Update framework-header-fix to force system sed.
Jul 25 2018, 12:22 AM

Jul 24 2018

keith added a reviewer for D49776: Update framework-header-fix to force system sed: beanz.
Jul 24 2018, 11:22 PM
keith removed a reviewer for D49776: Update framework-header-fix to force system sed: lldb-commits.
Jul 24 2018, 11:00 PM
keith added a reviewer for D49776: Update framework-header-fix to force system sed: lldb-commits.
Jul 24 2018, 10:54 PM