This is an archive of the discontinued LLVM Phabricator instance.

Differential D114976

[Bazel] Remove old macho lld port
ClosedPublic

Authored by keith on Dec 2 2021, 11:24 AM.

Details

Reviewers
GMNGeoffrey
rnk
Commits
rGbe4e789d214f: [Bazel] Remove old macho lld port
Summary

This code and cmake was removed in https://reviews.llvm.org/D114842

Diff Detail

Event Timeline

keith requested review of this revision.Dec 2 2021, 11:24 AM
keith created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2021, 11:24 AM
Herald added subscribers: llvm-commits, aheejin. · View Herald Transcript
Harbormaster completed remote builds in B137195: Diff 391407.Dec 2 2021, 11:28 AM
keith added a reviewer: rnk.Dec 2 2021, 11:35 AM

Just saw https://reviews.llvm.org/rG482b6f2a3d4b, I think this gets some things that one didn't

keith updated this revision to Diff 391409.Dec 2 2021, 11:36 AM

Rebase for other changes

GMNGeoffrey added a comment.Dec 2 2021, 11:38 AM

How did that other commit build if it didn't remove references to the deleted targets 🤨

GMNGeoffrey accepted this revision.Dec 2 2021, 11:38 AM
This revision is now accepted and ready to land.Dec 2 2021, 11:38 AM
Harbormaster completed remote builds in B137197: Diff 391409.Dec 2 2021, 11:39 AM
keith added a comment.Dec 2 2021, 11:44 AM

Looks like all these targets are excluded from CI currently

Closed by commit rGbe4e789d214f: [Bazel] Remove old macho lld port (authored by keith). · Explain WhyDec 2 2021, 11:45 AM
This revision was automatically updated to reflect the committed changes.
keith added a commit: rGbe4e789d214f: [Bazel] Remove old macho lld port.
GMNGeoffrey added a comment.Dec 2 2021, 11:45 AM
In D114976#3167682, @keith wrote:

Looks like all these targets are excluded from CI currently

Ah right, duh. Thanks for the fix!

rnk added a comment.Dec 2 2021, 1:18 PM

I think I did confirm that bazel build @llvm-project//lld/... didn't work before my change, and began working afterwards. Thanks for following up on it, though.

GMNGeoffrey added a comment.Dec 2 2021, 1:41 PM
In D114976#3168027, @rnk wrote:

I think I did confirm that bazel build @llvm-project//lld/... didn't work before my change, and began working afterwards. Thanks for following up on it, though.

The target is also manual :-D

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
lld/
8 lines

Diff 391413

utils/bazel/llvm-project-overlay/lld/BUILD.bazel

Show First 20 Lines • Show All 245 Lines • ▼ Show 20 Linescc_binary(
]), ]),
tags = [ tags = [
"manual", # External dependency (libxml through WindowsManifest) "manual", # External dependency (libxml through WindowsManifest)
"nobuildkite", # TODO(gcmn): Remote executors don't have libxml "nobuildkite", # TODO(gcmn): Remote executors don't have libxml
], ],
deps = [ deps = [
":COFF", ":COFF",
":Common", ":Common",
":Core",
":Driver",
":ELF", ":ELF",
":MachOOld",
":MachO", ":MachO",
":MinGW", ":MinGW",
":ReaderWriter",
":Wasm", ":Wasm",
":YAML",
"//llvm:Support", "//llvm:Support",
], ],
) )
# These are the required names for lld running under different environs. # These are the required names for lld running under different environs.
# #
# Unix/Linux require that the binary be named "ld.lld". # Unix/Linux require that the binary be named "ld.lld".
# macOS require that the binary be named "ld64.lld". # macOS require that the binary be named "ld64.lld".
# Windows require that the binary be named "lld-link". # Windows require that the binary be named "lld-link".
# WebAssembly builds require that the binary be named "wasm-ld". # WebAssembly builds require that the binary be named "wasm-ld".
genrule( genrule(
name = "gen_lld", name = "gen_lld",
srcs = [":lld"], srcs = [":lld"],
outs = [ outs = [
"ld.lld", "ld.lld",
"ld64.lld.darwinnew",
"ld64.lld", "ld64.lld",
"lld-link", "lld-link",
"wasm-ld", "wasm-ld",
], ],
cmd = cmd =
"target=$$(basename $<); for n in ld.lld ld64.lld.darwinnew ld64.lld lld-link wasm-ld; do ln -sf $$target $(@D)/$$n; done", "target=$$(basename $<); for n in ld.lld ld64.lld lld-link wasm-ld; do ln -sf $$target $(@D)/$$n; done",
output_to_bindir = 1, output_to_bindir = 1,
tags = [ tags = [
"manual", # External dependency (libxml through WindowsManifest) "manual", # External dependency (libxml through WindowsManifest)
"nobuildkite", # TODO(gcmn): Remote executors don't have libxml "nobuildkite", # TODO(gcmn): Remote executors don't have libxml
], ],
) )