User Details
- User Since
- Apr 11 2019, 1:09 PM (163 w, 1 d)
Wed, May 25
Thanks!
rebase
Tue, May 24
added additional tests
rename variables per suggestion
Mon, May 23
thanks!
consolidate exclude/included patterns set into one
hi, friendly 🔔 :)
Sat, May 21
undo formatting changes
Fri, May 20
add tests for interaction with -exported_symbol
more tests
Mon, May 16
Oh I see - the test is bad because it was expecting the error messages to be in a particular order. (it shouldn't because the export symbol list is processed concurrentlly)
Seemed to fail on windows bot:
Thanks!
rebase
updated diff:
- addressed review comment
- trimmed error msg
nop update to test arc diff
Apr 26 2022
Apr 22 2022
Apr 21 2022
Apr 19 2022
Apr 18 2022
Apr 13 2022
LG thanks!
Apr 12 2022
! In D122922#3446376, @mstorsjo wrote:
Can someone summarize the high level roadmap of this feature? If threadsafe allocation is going to be optional/opt-in, lld can't generally rely on that, right? Or is it meant as a gradual way of merging the code and trying it out, and after it's ready to be enabled unconditionally, it can be relied upon in lld in general?
reverted threadtag back native TLS
put back differet make/saver options:
Apr 11 2022
removed the unneeded helpers and define the cmake option for LLD_THREAD_SAFE_MEMORY
rebase before submitting
Apr 8 2022
LG , except the duplicate structs but then I don't have a better suggestion /shrug
Apr 7 2022
Addressed review comments:
- Use llvm::sys::ThreadLocal instead of native thread_local (potential concern: the pthread_*() functions it uses might be a bit slower?)
- Rename macro to LLD_THREAD_SAFE_MEMORY
LG
thx!
thanks!
Apr 6 2022
rebase
addressed review comments
updated diff
updated diff
fixed windows failures
Apr 5 2022
use thread_local, which is more portable than __thread
Apr 4 2022
keep an atomic incr to avoid locking
remoevd unused includes and rename make() func
Apr 1 2022
abandoning in favour of D122922
squashed
rebase
Mar 31 2022
The crash is fixed forward in https://reviews.llvm.org/rGe6e5e3e025ec1ccb8ebaff6ce4d6212edc491602
rebase