User Details
- User Since
- Apr 11 2019, 1:09 PM (206 w, 2 d)
Thu, Mar 23
(updated diff - forgot to include LLD's requested LLD change)
Updated diff:
- flip the emit-compact-unwind-non-canonical flag's default value back to false
- have all the generateCompactUnwind...() return MODE_DWARF (instead of 0, that was a bug).
Wed, Mar 22
Updated patch:
- added LLD change + test
- flip the new flag's default value to true to preserve current behaviour (easier to flip it to false and do test clean up separately)
Thu, Mar 16
addressed review comment: check for isExternal() symbol
Wed, Mar 15
New change: added a flag (default to OFF) to allow emit compact-unwinds for non-canonical personalities.
Thu, Mar 9
Seems test failures are related :) PTAL
Wed, Mar 8
Seems to cause segfaults in a lot of our builds .... :( Should we possibly revert this while investigating?
Tue, Mar 7
Adding an optional flag to request compact-unwind for non-canonical personalities.
- reverted to original proposal with some modification (only make objc and c++ personality symbols canonical - leaving out gcc)
- addressed review comments
Mon, Mar 6
Fri, Mar 3
Thu, Mar 2
Tue, Feb 28
P.S: Will add tests/whatnot. This is just a draft proposal to get a feel for how folks feel about this change. Thanks
Mon, Feb 27
Feb 23 2023
Feb 16 2023
Thanks!
Jan 23 2023
Jan 11 2023
LG
Jan 5 2023
LG
Jan 4 2023
Jan 3 2023
rescinding this in favour of D140491.
Thanks!
Dec 21 2022
typo
removed redundant whitespaces
Thanks!
addressed review comments:
- put fileloc's at the beginning of the warn msg
- remove ld64.lld from expected warning msgs in tests
- add comments
Dec 20 2022
reformat
added more tests for missing libaries (-l) too. Also included the files where the bad LC_LINKER_OPTION live to help debugging
updated warning msg in test
Updated diff to implement option #2, whic is to make missing frameworks/libraries warnings instead of errors.
Dec 19 2022
Hmm, unfortunately doesn't look like we have a majority here ... I guess how about we go with the option that requires the least API change which is #2 (ie., no new flag):
- not-found-errors from LC_LINKER_OPTION are warnings by default
- you can use the existing -ignore_linker_option to silence the warnings if desired.
Dec 17 2022
Reland #3: temporarily disabled checking cpu type after link due to suspected bug (described above).
(The current test that the link succeeded should be sufficient because
the link would have failed prior to this patch).
Dec 16 2022
reland 2nd attempt
From offline discussions, we have a few options: (in no particular order)
@keith Since you initially implemented these LC_LINKER_OPTION support, perhaps you could help reviewing this?
Thx
Dec 12 2022
Dec 9 2022
updated tests and reland
Thanks for the revert!
Dec 8 2022
Thx!
addressed review comment + rebase
rebase + fix typo
addressed review comments + added missing tests
Dec 7 2022
Dec 1 2022
(Not sure why git-clang-format is failing for the debian build ... probably unrelated?)
Nov 30 2022
Nov 29 2022
updated err msgs and removed a few asserts
Nov 28 2022
addressed review comment:
- refactor code so that the overflow checks can be done in place
- remove redundant check
- fix off-by-one
- updated type
- separate overflow case to different err msg to make debugging easier
Nov 22 2022
thanks!
address review comments + rebase