Page MenuHomePhabricator

oontvoo (Vy Nguyen)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Apr 11 2019, 1:09 PM (80 w, 5 d)

Recent Activity

Yesterday

oontvoo updated the diff for D89924: [llvm-zorg] Use ndk21 for buildbot.

(rebase)

Mon, Oct 26, 9:33 AM
oontvoo updated the diff for D89924: [llvm-zorg] Use ndk21 for buildbot.

updated

Mon, Oct 26, 9:30 AM
oontvoo added inline comments to D89924: [llvm-zorg] Use ndk21 for buildbot.
Mon, Oct 26, 9:29 AM
oontvoo updated the diff for D89924: [llvm-zorg] Use ndk21 for buildbot.

updated diff

Mon, Oct 26, 9:29 AM

Fri, Oct 23

oontvoo updated the diff for D89924: [llvm-zorg] Use ndk21 for buildbot.

Set cmake ndk-version variable

Fri, Oct 23, 5:16 PM
oontvoo added inline comments to D90004: Set default ndk version to 21..
Fri, Oct 23, 5:10 PM · Restricted Project
oontvoo updated the summary of D90004: Set default ndk version to 21..
Fri, Oct 23, 9:36 AM · Restricted Project
oontvoo updated the diff for D89924: [llvm-zorg] Use ndk21 for buildbot.

updated

Fri, Oct 23, 7:25 AM
oontvoo updated the diff for D89924: [llvm-zorg] Use ndk21 for buildbot.

Use the libc++_shared.so under sysroot rather than searching for it.
(In the new NDKs, there are a bunch of libc++_shared.so for different archs)

Fri, Oct 23, 7:20 AM

Thu, Oct 22

oontvoo updated the summary of D90004: Set default ndk version to 21..
Thu, Oct 22, 8:01 PM · Restricted Project
oontvoo requested review of D90004: Set default ndk version to 21..
Thu, Oct 22, 7:59 PM · Restricted Project
oontvoo added a comment to D89924: [llvm-zorg] Use ndk21 for buildbot.

May I ask you to move ANDROID_HAS_ELF_TLS and ANDROID_HAS_ELF_TLS into a separate patch so we can keep ndk upgrade only to see how it works for the bot?

Thu, Oct 22, 7:13 PM
oontvoo updated the diff for D89924: [llvm-zorg] Use ndk21 for buildbot.

updated

Thu, Oct 22, 7:13 PM
oontvoo added a comment to D89924: [llvm-zorg] Use ndk21 for buildbot.

actually I see a lot of test failing with v21 on 93953d411a0fc240e10237fea34aaff43e8f0ff5 on x86 emulator

Thu, Oct 22, 7:05 PM
oontvoo updated the diff for D89924: [llvm-zorg] Use ndk21 for buildbot.

updated

Thu, Oct 22, 3:14 PM
oontvoo updated the diff for D89615: Disable emulated-tls and use LLD for compiler-rt+tests on Android.

Removed the over-align hack, because D89924 is upgrading ndk to 21.

Thu, Oct 22, 3:12 PM · Restricted Project
oontvoo retitled D89924: [llvm-zorg] Use ndk21 for buildbot from [wip][llvm-zorg] Use ndk21 for buildbot to [llvm-zorg] Use ndk21 for buildbot.
Thu, Oct 22, 2:58 PM
oontvoo updated the diff for D89924: [llvm-zorg] Use ndk21 for buildbot.

updated to use the right API, depending on the device and use libc++

Thu, Oct 22, 2:57 PM
oontvoo added inline comments to D89924: [llvm-zorg] Use ndk21 for buildbot.
Thu, Oct 22, 12:53 PM
oontvoo added inline comments to D89924: [llvm-zorg] Use ndk21 for buildbot.
Thu, Oct 22, 7:02 AM

Wed, Oct 21

oontvoo requested review of D89924: [llvm-zorg] Use ndk21 for buildbot.
Wed, Oct 21, 8:33 PM
oontvoo committed rGe2858997abcb: Do not intercept __libc_memalign and cfree on Android because neither of these… (authored by oontvoo).
Do not intercept __libc_memalign and cfree on Android because neither of these…
Wed, Oct 21, 8:22 PM
oontvoo closed D89616: Do not intercept __libc_memalign and cfree on Android because neither of these exists in Bionic..
Wed, Oct 21, 8:22 PM · Restricted Project
oontvoo updated the diff for D89616: Do not intercept __libc_memalign and cfree on Android because neither of these exists in Bionic..

rebase

Wed, Oct 21, 8:19 PM · Restricted Project
oontvoo added inline comments to D89615: Disable emulated-tls and use LLD for compiler-rt+tests on Android.
Wed, Oct 21, 6:11 PM · Restricted Project
oontvoo added inline comments to D89251: Reland [lsan] Enable LSAN for Android.
Wed, Oct 21, 5:56 PM · Restricted Project
oontvoo updated the diff for D89251: Reland [lsan] Enable LSAN for Android.

updated

Wed, Oct 21, 5:56 PM · Restricted Project
oontvoo added inline comments to D89251: Reland [lsan] Enable LSAN for Android.
Wed, Oct 21, 5:52 PM · Restricted Project
oontvoo updated the diff for D89251: Reland [lsan] Enable LSAN for Android.

rebase

Wed, Oct 21, 5:27 PM · Restricted Project
oontvoo added inline comments to D89615: Disable emulated-tls and use LLD for compiler-rt+tests on Android.
Wed, Oct 21, 4:52 PM · Restricted Project
oontvoo added inline comments to D89615: Disable emulated-tls and use LLD for compiler-rt+tests on Android.
Wed, Oct 21, 2:24 PM · Restricted Project
oontvoo retitled D89615: Disable emulated-tls and use LLD for compiler-rt+tests on Android from Disable emulated-tls and use LLD for compiler-rt+tests on Android if ELF_TLS is presence. to Disable emulated-tls and use LLD for compiler-rt+tests on Android .
Wed, Oct 21, 12:38 PM · Restricted Project
oontvoo added a comment to D89615: Disable emulated-tls and use LLD for compiler-rt+tests on Android.

Why we can't just switch to elf TLS?

It seems to me that ideally the NDK clang should be defaulting to -fno-emulated-tls for android with a new enough target platform version, and should also be defaulting to use lld. I think that's been the plan for a while -- do you know if it's going to actually happen soon?

That might then make some of these changes unnecessary.

@danalbert to make sure I don't mix this up. https://android.googlesource.com/platform/ndk/+/master/docs/Roadmap.md#ndk-r22 shows that NDK r22 (which is going to beta soon) does indeed change the default linker to LLD. For TLS, this is indeed sensitive to target API, and Android will still be targeting those older APIs for quite some time (so we can't just remove support for them).

if I read this correctly we can switch Android to lld unconditionally right now now?

Wed, Oct 21, 12:31 PM · Restricted Project
oontvoo updated the diff for D89615: Disable emulated-tls and use LLD for compiler-rt+tests on Android.

<diff>

Wed, Oct 21, 12:29 PM · Restricted Project
oontvoo updated the diff for D89251: Reland [lsan] Enable LSAN for Android.

updated diff

Wed, Oct 21, 8:04 AM · Restricted Project
oontvoo requested review of D89884: [sanitizer]Update tests to be compatible with Android..
Wed, Oct 21, 7:52 AM · Restricted Project
oontvoo added a comment to D89251: Reland [lsan] Enable LSAN for Android.

The patch as is still fails with emulator about 71 tests.

Were all these 71 tests from check-lsan? I was planning on letting D89615 go in first, then this patch. (Otherwise, this patch would have to be submitted with LSAN-on-Android still disabled.)

Wed, Oct 21, 7:44 AM · Restricted Project
oontvoo updated the diff for D89251: Reland [lsan] Enable LSAN for Android.

updated diff

Wed, Oct 21, 7:44 AM · Restricted Project

Tue, Oct 20

oontvoo added a comment to D89615: Disable emulated-tls and use LLD for compiler-rt+tests on Android.

Why we can't just switch to elf TLS?

Tue, Oct 20, 4:43 PM · Restricted Project
oontvoo added inline comments to D89251: Reland [lsan] Enable LSAN for Android.
Tue, Oct 20, 4:38 PM · Restricted Project
oontvoo updated the diff for D89251: Reland [lsan] Enable LSAN for Android.

updated diff

Tue, Oct 20, 4:38 PM · Restricted Project
oontvoo added inline comments to D89251: Reland [lsan] Enable LSAN for Android.
Tue, Oct 20, 9:02 AM · Restricted Project
oontvoo updated the diff for D89251: Reland [lsan] Enable LSAN for Android.

updated diff

Tue, Oct 20, 9:02 AM · Restricted Project

Mon, Oct 19

oontvoo updated the diff for D89615: Disable emulated-tls and use LLD for compiler-rt+tests on Android.

add test

Mon, Oct 19, 3:29 PM · Restricted Project

Sat, Oct 17

oontvoo added a reviewer for D89615: Disable emulated-tls and use LLD for compiler-rt+tests on Android: rprichard.
Sat, Oct 17, 12:12 AM · Restricted Project
oontvoo updated the diff for D89615: Disable emulated-tls and use LLD for compiler-rt+tests on Android.

For arm(64), also need to overalign the TLS segment if tests run with ELF-TLS

Sat, Oct 17, 12:12 AM · Restricted Project

Fri, Oct 16

oontvoo updated the diff for D89251: Reland [lsan] Enable LSAN for Android.

updated

Fri, Oct 16, 11:28 PM · Restricted Project
oontvoo requested review of D89616: Do not intercept __libc_memalign and cfree on Android because neither of these exists in Bionic..
Fri, Oct 16, 11:25 PM · Restricted Project
oontvoo added a comment to D89251: Reland [lsan] Enable LSAN for Android.

I recommend to extract smaller patches which can be landed separately.

Fri, Oct 16, 11:09 PM · Restricted Project
oontvoo requested review of D89615: Disable emulated-tls and use LLD for compiler-rt+tests on Android.
Fri, Oct 16, 11:08 PM · Restricted Project
oontvoo added a comment to D89251: Reland [lsan] Enable LSAN for Android.

A lot of tests fails like:

/usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/test/sanitizer_common/android_commands/android_compile.py  /usr/local/google/home/vitalybuka/slow/bbot/llvm_build64/bin/clang  --driver-mode=g++ -stdlib=libstdc++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only  -pie -fuse-ld=gold --target=i686-linux-android --sysroot=/usr/local/google/home/vitalybuka/slow/bbot/android_ndk/standalone-i686/sysroot -B/usr/local/google/home/vitalybuka/slow/bbot/android_ndk/standalone-i686 -fuse-ld=lld  -shared-libasan -O1 -fsanitize-address-use-after-scope /usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/test/asan/TestCases/use-after-scope-nobug.cpp -o /usr/local/google/home/vitalybuka/slow/bbot/compiler_rt_build_android_i686/test/asan/I386AndroidConfig/TestCases/Output/use-after-scope-nobug.cpp.tmp &&  /usr/local/google/home/vitalybuka/slow/bbot/compiler_rt_build_android_i686/test/asan/I386AndroidConfig/TestCases/Output/use-after-scope-nobug.cpp.tmp
WARNING: linker: /data/local/tmp/Output/usr/local/google/home/vitalybuka/slow/bbot/compiler_rt_build_android_i686/test/asan/I386AndroidConfig/TestCases/Output/use-after-scope-nobug.cpp.tmp: unsupported flags DT_FLAGS_1=0x8000001

CANNOT LINK EXECUTABLE "/data/local/tmp/Output/usr/local/google/home/vitalybuka/slow/bbot/compiler_rt_build_android_i686/test/asan/I386AndroidConfig/TestCases/Output/use-after-scope-nobug.cpp.tmp": unknown reloc type 14 @ 0xa8d63390 (638)
Aborted 
Aborted
Fri, Oct 16, 9:51 AM · Restricted Project

Thu, Oct 15

oontvoo updated the diff for D89251: Reland [lsan] Enable LSAN for Android.

rebase

Thu, Oct 15, 11:37 AM · Restricted Project

Tue, Oct 13

oontvoo added inline comments to D89251: Reland [lsan] Enable LSAN for Android.
Tue, Oct 13, 8:00 PM · Restricted Project
oontvoo added inline comments to D89251: Reland [lsan] Enable LSAN for Android.
Tue, Oct 13, 6:02 PM · Restricted Project
oontvoo updated the diff for D89251: Reland [lsan] Enable LSAN for Android.

updated diff

Tue, Oct 13, 6:01 PM · Restricted Project
oontvoo updated the diff for D89251: Reland [lsan] Enable LSAN for Android.

updated diff

Tue, Oct 13, 2:45 PM · Restricted Project
oontvoo updated the diff for D89251: Reland [lsan] Enable LSAN for Android.

Updated diff.
Also included the previously reverted patch.

Tue, Oct 13, 2:43 PM · Restricted Project
oontvoo retitled D89251: Reland [lsan] Enable LSAN for Android from [lsan] Do not enable leak-sanitizer if api_level is less than 29. to Reland [lsan] Enable LSAN for Android.
Tue, Oct 13, 8:49 AM · Restricted Project
oontvoo added a comment to D89251: Reland [lsan] Enable LSAN for Android.

The build bot is happy with Diff 6! \o/

Tue, Oct 13, 8:42 AM · Restricted Project

Mon, Oct 12

oontvoo added a comment to D89251: Reland [lsan] Enable LSAN for Android.

[EDIT: This is specific to the armv7-linux-android target]

Mon, Oct 12, 9:36 PM · Restricted Project
oontvoo updated the diff for D89251: Reland [lsan] Enable LSAN for Android.

updated diff

Mon, Oct 12, 9:32 PM · Restricted Project
oontvoo added a comment to D89251: Reland [lsan] Enable LSAN for Android.

> What about only doing the compilation? That shouldn't require any real hardware, right?

Mon, Oct 12, 7:42 PM · Restricted Project
oontvoo updated the diff for D89251: Reland [lsan] Enable LSAN for Android.

updated diff

Mon, Oct 12, 7:40 PM · Restricted Project
oontvoo added a comment to D89251: Reland [lsan] Enable LSAN for Android.
Mon, Oct 12, 3:47 PM · Restricted Project
oontvoo updated the diff for D89251: Reland [lsan] Enable LSAN for Android.

Updated diff:

  • use uptr instead of size_t
  • only weak-decl for pre-21 API
Mon, Oct 12, 3:46 PM · Restricted Project
oontvoo added a comment to D89251: Reland [lsan] Enable LSAN for Android.
> 
> Do you have a way to test an API 16 build locally, for faster iteration? Sending patches to our bots is slow because the bots only know how to do a clean build, and there are several points in the pipeline where tasks get delayed due to machine pool capacity.
Mon, Oct 12, 1:45 PM · Restricted Project
oontvoo updated the diff for D89251: Reland [lsan] Enable LSAN for Android.

Move weak decl to header so that it'll be available to users.

Mon, Oct 12, 1:45 PM · Restricted Project
oontvoo added inline comments to D89251: Reland [lsan] Enable LSAN for Android.
Mon, Oct 12, 12:38 PM · Restricted Project
oontvoo added inline comments to D89251: Reland [lsan] Enable LSAN for Android.
Mon, Oct 12, 12:31 PM · Restricted Project
oontvoo added a comment to D85927: Enable LSAN for Android.

Thanks for the report!

This caused a build break in our compiler-rt build for Android: use of undeclared identifier '__interceptor_memalign'

Are you also building with API 16? (From your second comment)

Yes, that's right. The memalign error is still present after D89251.

Mon, Oct 12, 11:49 AM · Restricted Project
oontvoo updated the diff for D89251: Reland [lsan] Enable LSAN for Android.

updated diff

Mon, Oct 12, 11:49 AM · Restricted Project
oontvoo added a comment to D89251: Reland [lsan] Enable LSAN for Android.

This looks wrong. Api level has nothing to do with compile-time support for TLS, and thread-properties API is used with runtime detection (through a weak symbol).

Mon, Oct 12, 11:49 AM · Restricted Project
oontvoo requested review of D89251: Reland [lsan] Enable LSAN for Android.
Mon, Oct 12, 9:39 AM · Restricted Project
oontvoo added a comment to D85927: Enable LSAN for Android.

Thanks for the report!

Mon, Oct 12, 9:16 AM · Restricted Project

Fri, Oct 9

oontvoo closed D85927: Enable LSAN for Android.
Fri, Oct 9, 12:25 PM · Restricted Project
oontvoo committed rGa2291a58bf1c: Enable LSAN for Android (authored by oontvoo).
Enable LSAN for Android
Fri, Oct 9, 12:24 PM
oontvoo updated the diff for D85927: Enable LSAN for Android.

remove use_globals=0 from tests

Fri, Oct 9, 12:18 PM · Restricted Project

Thu, Oct 8

oontvoo updated the diff for D85927: Enable LSAN for Android.

Make test set use_global=1 for Android and add warnings if use_global is turnt off.

Thu, Oct 8, 6:15 PM · Restricted Project
oontvoo added inline comments to D85927: Enable LSAN for Android.
Thu, Oct 8, 5:58 PM · Restricted Project
oontvoo updated the diff for D85927: Enable LSAN for Android.

rebase

Thu, Oct 8, 9:08 AM · Restricted Project

Wed, Oct 7

oontvoo updated the diff for D85927: Enable LSAN for Android.

updated diff

Wed, Oct 7, 8:26 PM · Restricted Project
oontvoo added inline comments to D85927: Enable LSAN for Android.
Wed, Oct 7, 6:18 PM · Restricted Project
oontvoo updated the diff for D85927: Enable LSAN for Android.

updated diff

Wed, Oct 7, 6:18 PM · Restricted Project

Mon, Oct 5

oontvoo added inline comments to D85927: Enable LSAN for Android.
Mon, Oct 5, 10:30 PM · Restricted Project
oontvoo updated the diff for D85927: Enable LSAN for Android.

Updated diff

Mon, Oct 5, 10:30 PM · Restricted Project

Fri, Oct 2

oontvoo added inline comments to D85927: Enable LSAN for Android.
Fri, Oct 2, 3:04 PM · Restricted Project
oontvoo updated the diff for D85927: Enable LSAN for Android.

updated per review comments

Fri, Oct 2, 3:04 PM · Restricted Project

Thu, Oct 1

oontvoo committed rGcb3fd715f324: Reland rG4fcd1a8e6528:[llvm-exegesis] Add option to check the hardware support… (authored by oontvoo).
Reland rG4fcd1a8e6528:[llvm-exegesis] Add option to check the hardware support…
Thu, Oct 1, 9:22 AM
oontvoo closed D88670: Reland rG4fcd1a8e6528:[llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..
Thu, Oct 1, 9:22 AM · Restricted Project
oontvoo accepted D88670: Reland rG4fcd1a8e6528:[llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..
Thu, Oct 1, 9:18 AM · Restricted Project
oontvoo requested review of D88670: Reland rG4fcd1a8e6528:[llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..
Thu, Oct 1, 9:17 AM · Restricted Project
oontvoo added a comment to D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..

Ah, the issue here was that lit.local.cfg , which was supposed to detect if lbr-tests are runnable, didn't use the right arguments . I've updated it and the test should now be skipped on unsupported kernels/architectures..

Thu, Oct 1, 9:16 AM · Restricted Project

Wed, Sep 30

oontvoo committed rG4fcd1a8e6528: [llvm-exegesis] Add option to check the hardware support for a given feature… (authored by oontvoo).
[llvm-exegesis] Add option to check the hardware support for a given feature…
Wed, Sep 30, 9:26 AM
oontvoo closed D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..
Wed, Sep 30, 9:26 AM · Restricted Project
oontvoo updated the diff for D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..

More clean up.

Wed, Sep 30, 9:12 AM · Restricted Project

Tue, Sep 29

oontvoo updated the diff for D85927: Enable LSAN for Android.

(minor cleanup)

Tue, Sep 29, 10:24 AM · Restricted Project

Sep 24 2020

oontvoo updated the diff for D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..

Reduce wait time to 5ms. (not really meaningful - we just use this as a way to prevent unrolling)

Sep 24 2020, 8:21 AM · Restricted Project

Sep 23 2020

oontvoo updated the diff for D85254: [llvm-exegesis] Add option to check the hardware support for a given feature before benchmarking..

reduce wait time

Sep 23 2020, 8:46 PM · Restricted Project

Sep 21 2020

oontvoo updated the diff for D85927: Enable LSAN for Android.

Updated a few tests to work on Android.

Sep 21 2020, 2:44 PM · Restricted Project

Sep 16 2020

oontvoo added a comment to D87754: [Lsan] Use fp registers to search for pointers.

Maybe this is a prove that not all registers fetched.
How exactly this fails?

Sep 16 2020, 10:19 PM · Restricted Project