Page MenuHomePhabricator

oontvoo (Vy Nguyen)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Apr 11 2019, 1:09 PM (163 w, 1 d)

Recent Activity

Wed, May 25

oontvoo committed rGfae6bd7563ca: [lld-macho] Support -non_global_symbols_strip_list… (authored by oontvoo).
[lld-macho] Support -non_global_symbols_strip_list…
Wed, May 25, 5:27 AM · Restricted Project
oontvoo closed D126046: [lld-macho] Support -non_global_symbols_strip_list, -non_global_symbols_no_strip_list, -x.
Wed, May 25, 5:27 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D126046: [lld-macho] Support -non_global_symbols_strip_list, -non_global_symbols_no_strip_list, -x.

Thanks!

Wed, May 25, 5:26 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D126046: [lld-macho] Support -non_global_symbols_strip_list, -non_global_symbols_no_strip_list, -x.

rebase

Wed, May 25, 5:22 AM · Restricted Project, Restricted Project, Restricted Project

Tue, May 24

oontvoo updated the diff for D126046: [lld-macho] Support -non_global_symbols_strip_list, -non_global_symbols_no_strip_list, -x.

added additional tests

Tue, May 24, 5:55 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo added inline comments to D126046: [lld-macho] Support -non_global_symbols_strip_list, -non_global_symbols_no_strip_list, -x.
Tue, May 24, 5:55 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo added inline comments to D126046: [lld-macho] Support -non_global_symbols_strip_list, -non_global_symbols_no_strip_list, -x.
Tue, May 24, 4:22 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D126046: [lld-macho] Support -non_global_symbols_strip_list, -non_global_symbols_no_strip_list, -x.

rename variables per suggestion

Tue, May 24, 4:22 AM · Restricted Project, Restricted Project, Restricted Project

Mon, May 23

oontvoo added a comment to D126262: [lld-macho][nfc] Run clang-format on lld/MachO/*.{h,cpp}.

thanks!

Mon, May 23, 6:37 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo committed rGc0ec1036d653: [lld-macho][nfc] Run clang-format on lld/MachO/*.{h,cpp} (authored by oontvoo).
[lld-macho][nfc] Run clang-format on lld/MachO/*.{h,cpp}
Mon, May 23, 6:37 PM · Restricted Project
oontvoo closed D126262: [lld-macho][nfc] Run clang-format on lld/MachO/*.{h,cpp}.
Mon, May 23, 6:36 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo requested review of D126262: [lld-macho][nfc] Run clang-format on lld/MachO/*.{h,cpp}.
Mon, May 23, 6:01 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D126046: [lld-macho] Support -non_global_symbols_strip_list, -non_global_symbols_no_strip_list, -x.

consolidate exclude/included patterns set into one

Mon, May 23, 4:49 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D126046: [lld-macho] Support -non_global_symbols_strip_list, -non_global_symbols_no_strip_list, -x.

hi, friendly 🔔 :)

Mon, May 23, 4:08 PM · Restricted Project, Restricted Project, Restricted Project

Sat, May 21

oontvoo updated the diff for D126046: [lld-macho] Support -non_global_symbols_strip_list, -non_global_symbols_no_strip_list, -x.

undo formatting changes

Sat, May 21, 4:41 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo added inline comments to D126046: [lld-macho] Support -non_global_symbols_strip_list, -non_global_symbols_no_strip_list, -x.
Sat, May 21, 4:38 PM · Restricted Project, Restricted Project, Restricted Project

Fri, May 20

oontvoo updated the diff for D126046: [lld-macho] Support -non_global_symbols_strip_list, -non_global_symbols_no_strip_list, -x.

add tests for interaction with -exported_symbol

Fri, May 20, 5:59 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D126046: [lld-macho] Support -non_global_symbols_strip_list, -non_global_symbols_no_strip_list, -x.

more tests

Fri, May 20, 2:09 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo requested review of D126046: [lld-macho] Support -non_global_symbols_strip_list, -non_global_symbols_no_strip_list, -x.
Fri, May 20, 12:46 AM · Restricted Project, Restricted Project, Restricted Project

Mon, May 16

oontvoo added a comment to D125732: [lld-macho] Demangle symbol name in export error msg when -demangle is specified.

Linker behavior, including error output order, should be deterministic. (This allows caching results etc)

Mon, May 16, 10:15 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo committed rG3cde6d83f86c: [nfc][lld-macho] Follow up fixes to bd9e46815d73e4236c207bad8b5c54e7188154d7 (authored by oontvoo).
[nfc][lld-macho] Follow up fixes to bd9e46815d73e4236c207bad8b5c54e7188154d7
Mon, May 16, 5:54 PM · Restricted Project
oontvoo committed rGbd9e46815d73: [nfc][lld-macho] Fixed test from https://reviews.llvm.org/D125732 (authored by oontvoo).
[nfc][lld-macho] Fixed test from https://reviews.llvm.org/D125732
Mon, May 16, 5:48 PM · Restricted Project
oontvoo added a comment to D125732: [lld-macho] Demangle symbol name in export error msg when -demangle is specified.

Oh I see - the test is bad because it was expecting the error messages to be in a particular order. (it shouldn't because the export symbol list is processed concurrentlly)

Mon, May 16, 5:45 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo committed rGa997cdc3b798: [lld-macho] Temporarily disable test on windows (authored by oontvoo).
[lld-macho] Temporarily disable test on windows
Mon, May 16, 5:40 PM · Restricted Project
oontvoo added a comment to D125732: [lld-macho] Demangle symbol name in export error msg when -demangle is specified.

Seemed to fail on windows bot:

Mon, May 16, 5:38 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo committed rG4c5b187f2c06: [lld-macho] Demangle symbol names in export-symbol error messages when… (authored by oontvoo).
[lld-macho] Demangle symbol names in export-symbol error messages when…
Mon, May 16, 4:48 PM · Restricted Project
oontvoo closed D125732: [lld-macho] Demangle symbol name in export error msg when -demangle is specified.
Mon, May 16, 4:48 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D125732: [lld-macho] Demangle symbol name in export error msg when -demangle is specified.

Thanks!

Mon, May 16, 4:46 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D125732: [lld-macho] Demangle symbol name in export error msg when -demangle is specified.

rebase

Mon, May 16, 4:46 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D125732: [lld-macho] Demangle symbol name in export error msg when -demangle is specified.

updated diff:

  • addressed review comment
  • trimmed error msg
Mon, May 16, 4:44 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D125732: [lld-macho] Demangle symbol name in export error msg when -demangle is specified.

nop update to test arc diff

Mon, May 16, 4:33 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo requested review of D125732: [lld-macho] Demangle symbol name in export error msg when -demangle is specified.
Mon, May 16, 4:25 PM · Restricted Project, Restricted Project, Restricted Project

Apr 26 2022

oontvoo added a comment to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

I have a chrome build on Linux x86-64. Say /tmp/c/0 has a lld built from main branch. /tmp/c/1 is a lld built with this patch.

Apr 26 2022, 10:13 AM · Restricted Project, Restricted Project
oontvoo added inline comments to D123435: [lld-macho] Initial support for EH Frames.
Apr 26 2022, 7:46 AM · Restricted Project, Restricted Project, Restricted Project

Apr 22 2022

oontvoo added a comment to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

Right, but if the MachO part of lld does allocations from multiple threads, then it's essentially unreliable unless this option is enabled? So anyone building lld wanting to use the MachO part of it would need to enable it.

This question was left unanswered -- how do you plan on using LLD_THREAD_SAFE_MEMORY? Will it be enabled only when building for Darwin? What happens for cross-compilation or if LLD_THREAD_SAFE_MEMORY isn't enabled? The make/makePerThread/makeUnsafe APIs seem a bit error-prone to me. Ideally it is a choice that should be avoided, if possible, by the business logic/driver developer.

Apr 22 2022, 7:56 AM · Restricted Project, Restricted Project

Apr 21 2022

oontvoo added inline comments to D124143: [lld-macho] Allow dead_strip to work with exported private extern symbols.
Apr 21 2022, 12:21 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo added inline comments to D124106: [lld/mac] Warn that writing zippered outputs isn't implemented.
Apr 21 2022, 8:05 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo added inline comments to D124143: [lld-macho] Allow dead_strip to work with exported private extern symbols.
Apr 21 2022, 7:24 AM · Restricted Project, Restricted Project, Restricted Project

Apr 19 2022

Herald added a project to D86351: WIP: llvm-buildozer: Restricted Project.
Apr 19 2022, 12:57 PM · Restricted Project, Restricted Project, Restricted Project

Apr 18 2022

oontvoo added inline comments to D123879: [LLD] Alternate implementation for "Support per-thread allocators and StringSavers".
Apr 18 2022, 6:33 AM · Restricted Project, Restricted Project

Apr 13 2022

oontvoo accepted D123277: [lld-macho][nfc] De-templatize UnwindInfoSection.

LG thanks!

Apr 13 2022, 12:57 PM · Restricted Project, Restricted Project, Restricted Project

Apr 12 2022

oontvoo added a comment to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

! In D122922#3446376, @mstorsjo wrote:

Can someone summarize the high level roadmap of this feature? If threadsafe allocation is going to be optional/opt-in, lld can't generally rely on that, right? Or is it meant as a gradual way of merging the code and trying it out, and after it's ready to be enabled unconditionally, it can be relied upon in lld in general?

Apr 12 2022, 12:44 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

reverted threadtag back native TLS

Apr 12 2022, 12:44 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

put back differet make/saver options:

Apr 12 2022, 11:40 AM · Restricted Project, Restricted Project
oontvoo added a comment to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

In the LLD_THREAD_SAFE_MEMORY code path, make<Foo>(...) now has significantly larger overhead due to the pthread_getspecific call (via llvm/Support/ThreadLocal.h).
A large number of make<...> instantiations in lld do not benefit from per-thread allocation.

Apr 12 2022, 10:28 AM · Restricted Project, Restricted Project
oontvoo added inline comments to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.
Apr 12 2022, 6:35 AM · Restricted Project, Restricted Project
oontvoo added inline comments to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.
Apr 12 2022, 6:28 AM · Restricted Project, Restricted Project

Apr 11 2022

oontvoo updated the diff for D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

removed the unneeded helpers and define the cmake option for LLD_THREAD_SAFE_MEMORY

Apr 11 2022, 1:13 PM · Restricted Project, Restricted Project
oontvoo committed rG14779644133d: [lld][macho]Fix test to sort symbol table before dumping (authored by oontvoo).
[lld][macho]Fix test to sort symbol table before dumping
Apr 11 2022, 9:01 AM · Restricted Project
oontvoo closed D116813: [lld][macho] Fix test to sort symbol table before dumping.
Apr 11 2022, 9:01 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D116813: [lld][macho] Fix test to sort symbol table before dumping.

rebase before submitting

Apr 11 2022, 9:00 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo added inline comments to D123277: [lld-macho][nfc] De-templatize UnwindInfoSection.
Apr 11 2022, 6:32 AM · Restricted Project, Restricted Project, Restricted Project

Apr 8 2022

oontvoo accepted D123276: [lld-macho] Use fewer indirections in UnwindInfo implementation.

LG , except the duplicate structs but then I don't have a better suggestion /shrug

Apr 8 2022, 12:07 PM · Restricted Project, Restricted Project, Restricted Project

Apr 7 2022

oontvoo added a comment to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

We did experimented with using a modern/threadsafe allocator here, specifically tcmalloc internally at google and found that it was pretty good (ie., no slower than the bump-ptr alloc). But conceptually the bump-alloc could be faster in simple cases so we thought it wouldn't hurt to use both when possible. (ie., have a thread safe bump allocator and a fast system malloc).

IIRC you found that tcmalloc-for-everything was at parity with bump ptr alloc + system allocator, but bump ptr allocator + tcmalloc together was still faster than tcmalloc-for-everything, right?

Apr 7 2022, 1:59 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.
Apr 7 2022, 1:02 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

Addressed review comments:

  • Use llvm::sys::ThreadLocal instead of native thread_local (potential concern: the pthread_*() functions it uses might be a bit slower?)
  • Rename macro to LLD_THREAD_SAFE_MEMORY
Apr 7 2022, 12:09 PM · Restricted Project, Restricted Project
oontvoo accepted D123275: [lld-macho][nfc] Remove indirection when looking up common section members.

LG

Apr 7 2022, 11:06 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a reviewer for D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers: jyknight.
Apr 7 2022, 10:02 AM · Restricted Project, Restricted Project
oontvoo added inline comments to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.
Apr 7 2022, 8:05 AM · Restricted Project, Restricted Project
oontvoo added a comment to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

Hello! Thanks for adding me :-) Interesting challenge!
It's a bit sad that we have to do all this high-level/application-level memory management. Most modern allocators already support (lock-free) per-thread memory pools out-of-the-box, along with migration between threads and to the global pool/arena. This patch seems to be needed solely because we use BumpPtrAllocator/SpecificBumpPtrAllocator. I wonder how things would perform with just using malloc() instead + a modern underlying allocator (rpmalloc, mimalloc, ...). Memory locality brought by the bumpalloc is important, but it'd be interesting to compare benchmarks. FWIW there were discussions with @lattner at some point about integrating rpmalloc into the LLVM codebase, but I never got to post a RFC.

Apr 7 2022, 7:27 AM · Restricted Project, Restricted Project
oontvoo added inline comments to D123276: [lld-macho] Use fewer indirections in UnwindInfo implementation.
Apr 7 2022, 7:20 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D123279: [lld-macho][nfc] Give non-text ConcatOutputSections order-independent finalization.

thx!

Apr 7 2022, 7:18 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo accepted D123279: [lld-macho][nfc] Give non-text ConcatOutputSections order-independent finalization.
Apr 7 2022, 7:14 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo accepted D123302: [lld/mac] Add some comments and asserts.

thanks!

Apr 7 2022, 7:06 AM · Restricted Project, Restricted Project, Restricted Project

Apr 6 2022

oontvoo updated the diff for D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

rebase

Apr 6 2022, 1:34 PM · Restricted Project, Restricted Project
oontvoo updated the summary of D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.
Apr 6 2022, 1:31 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.
Apr 6 2022, 1:20 PM · Restricted Project, Restricted Project
oontvoo updated subscribers of D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.
Apr 6 2022, 1:13 PM · Restricted Project, Restricted Project
oontvoo retitled D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers from [lld][common][lld-macho] Support per-thread allocators and StringSavers to [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.
Apr 6 2022, 1:12 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.
Apr 6 2022, 1:11 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

addressed review comments

Apr 6 2022, 1:11 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

updated diff

Apr 6 2022, 12:43 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

updated diff

Apr 6 2022, 12:37 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.
Apr 6 2022, 12:37 PM · Restricted Project, Restricted Project
oontvoo updated the summary of D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.
Apr 6 2022, 8:26 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

fixed windows failures

Apr 6 2022, 8:25 AM · Restricted Project, Restricted Project

Apr 5 2022

oontvoo updated the summary of D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.
Apr 5 2022, 1:22 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

use thread_local, which is more portable than __thread

Apr 5 2022, 1:21 PM · Restricted Project, Restricted Project

Apr 4 2022

oontvoo added inline comments to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.
Apr 4 2022, 1:40 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

keep an atomic incr to avoid locking

Apr 4 2022, 1:38 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.
Apr 4 2022, 10:29 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

remoevd unused includes and rename make() func

Apr 4 2022, 7:28 AM · Restricted Project, Restricted Project

Apr 1 2022

oontvoo abandoned D121635: [lld][macho][elf] Teach the bump-allocator in lld/Common about thread-safetiness..

abandoning in favour of D122922

Apr 1 2022, 11:32 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

squashed

Apr 1 2022, 11:24 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.

rebase

Apr 1 2022, 10:57 AM · Restricted Project, Restricted Project
oontvoo requested review of D122922: [lld][common][lld-macho][lld-coff] Support per-thread allocators and StringSavers.
Apr 1 2022, 10:52 AM · Restricted Project, Restricted Project
oontvoo accepted D122904: [lld/mac] Tweak a few comments.
Apr 1 2022, 7:23 AM · Restricted Project, Restricted Project, Restricted Project

Mar 31 2022

oontvoo committed rG33e197112a21: [llvm-readobj] Support non 64bit platforms too (authored by oontvoo).
[llvm-readobj] Support non 64bit platforms too
Mar 31 2022, 12:40 PM · Restricted Project, Restricted Project
oontvoo added a comment to rG1ae449f9a33b: Reland "[llvm-readobj][MachO] Add option to sort the symbol table before….

The crash is fixed forward in https://reviews.llvm.org/rGe6e5e3e025ec1ccb8ebaff6ce4d6212edc491602

Mar 31 2022, 12:25 PM · Restricted Project, Restricted Project
oontvoo committed rGe6e5e3e025ec: [llvm-readobj] Fix forward build breakages caused by https://reviews.llvm. (authored by oontvoo).
[llvm-readobj] Fix forward build breakages caused by https://reviews.llvm.
Mar 31 2022, 12:23 PM · Restricted Project, Restricted Project
oontvoo added a reverting change for rG33b3c86afab0: Revert "[llvm-readobj][MachO] Add option to sort the symbol table before…: rG1ae449f9a33b: Reland "[llvm-readobj][MachO] Add option to sort the symbol table before….
Mar 31 2022, 11:22 AM · Restricted Project, Restricted Project
oontvoo committed rG1ae449f9a33b: Reland "[llvm-readobj][MachO] Add option to sort the symbol table before… (authored by oontvoo).
Reland "[llvm-readobj][MachO] Add option to sort the symbol table before…
Mar 31 2022, 11:22 AM · Restricted Project, Restricted Project
oontvoo requested review of D122840: [llvm-readobj][nfc] Run clang-format on the directory's .cpp and .h files.
Mar 31 2022, 11:15 AM · Restricted Project, Restricted Project
oontvoo added a reverting change for rGea9cf2dc96c7: [llvm-readobj][MachO] Add option to sort the symbol table before dumping (MachO…: rG33b3c86afab0: Revert "[llvm-readobj][MachO] Add option to sort the symbol table before….
Mar 31 2022, 6:34 AM · Restricted Project, Restricted Project
oontvoo added a reverting change for D116787: [llvm-readobj][MachO] Add option to sort the symbol table before dumping (MachO only, for now).: rG33b3c86afab0: Revert "[llvm-readobj][MachO] Add option to sort the symbol table before….
Mar 31 2022, 6:34 AM · Restricted Project, Restricted Project
oontvoo committed rG33b3c86afab0: Revert "[llvm-readobj][MachO] Add option to sort the symbol table before… (authored by oontvoo).
Revert "[llvm-readobj][MachO] Add option to sort the symbol table before…
Mar 31 2022, 6:33 AM · Restricted Project, Restricted Project
oontvoo committed rGea9cf2dc96c7: [llvm-readobj][MachO] Add option to sort the symbol table before dumping (MachO… (authored by oontvoo).
[llvm-readobj][MachO] Add option to sort the symbol table before dumping (MachO…
Mar 31 2022, 6:16 AM · Restricted Project, Restricted Project
oontvoo closed D116787: [llvm-readobj][MachO] Add option to sort the symbol table before dumping (MachO only, for now)..
Mar 31 2022, 6:16 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D116787: [llvm-readobj][MachO] Add option to sort the symbol table before dumping (MachO only, for now)..

rebase

Mar 31 2022, 6:13 AM · Restricted Project, Restricted Project

Mar 30 2022

oontvoo added inline comments to D116787: [llvm-readobj][MachO] Add option to sort the symbol table before dumping (MachO only, for now)..
Mar 30 2022, 11:38 AM · Restricted Project, Restricted Project