Page MenuHomePhabricator
People oontvoo

oontvoo (Vy Nguyen)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Apr 11 2019, 1:09 PM (104 w, 3 d)

Recent Activity
View All

Thu, Apr 8

oontvoo added inline comments to D100011: [lld-macho] Make time-trace* options more permissive..
Thu, Apr 8, 11:37 AM · Restricted Project, Restricted Project

Wed, Apr 7

oontvoo accepted D100082: [lld-macho][nfc] Extend abs-symbol.s to test for local absolute symbols.

LGTM

Wed, Apr 7, 7:40 PM · Restricted Project, Restricted Project
oontvoo committed rGdb851dfb4958: [lld-macho] Make time-trace* options more permissive. (authored by oontvoo).
[lld-macho] Make time-trace* options more permissive.
Wed, Apr 7, 1:01 PM
oontvoo closed D100011: [lld-macho] Make time-trace* options more permissive..
Wed, Apr 7, 1:00 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D100011: [lld-macho] Make time-trace* options more permissive..

updated diff

Wed, Apr 7, 12:38 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D100011: [lld-macho] Make time-trace* options more permissive..
Wed, Apr 7, 12:38 PM · Restricted Project, Restricted Project
oontvoo committed rGffc65824f0ee: [lld-macho][nfc] Minor refactoring + clang-tidy fixes (authored by oontvoo).
[lld-macho][nfc] Minor refactoring + clang-tidy fixes
Wed, Apr 7, 10:58 AM
oontvoo closed D100019: [lld-macho][nfc] Minor refactoring + clang-tidy fixes.
Wed, Apr 7, 10:58 AM · Restricted Project, Restricted Project
oontvoo added inline comments to D100019: [lld-macho][nfc] Minor refactoring + clang-tidy fixes.
Wed, Apr 7, 10:57 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D100019: [lld-macho][nfc] Minor refactoring + clang-tidy fixes.

rebase

Wed, Apr 7, 10:56 AM · Restricted Project, Restricted Project
oontvoo added a comment to D100019: [lld-macho][nfc] Minor refactoring + clang-tidy fixes.
In D100019#2674137, @int3 wrote:

I actually snuck in a clang-format cleanup yesterday :) https://github.com/llvm/llvm-project/commit/174deb0539ee4af7d20bfead9f73055782e878e3 (so just update the commit title I guess)

Wed, Apr 7, 9:53 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D100019: [lld-macho][nfc] Minor refactoring + clang-tidy fixes.

removed unnecessary braces

Wed, Apr 7, 9:53 AM · Restricted Project, Restricted Project

Tue, Apr 6

oontvoo requested review of D100019: [lld-macho][nfc] Minor refactoring + clang-tidy fixes.
Tue, Apr 6, 10:53 PM · Restricted Project, Restricted Project
oontvoo requested review of D100011: [lld-macho] Make time-trace* options more permissive..
Tue, Apr 6, 8:46 PM · Restricted Project, Restricted Project
oontvoo accepted D99874: [lld-macho][nfc] Remove HelpHidden from aliases to implemented flags.

LGTM

Tue, Apr 6, 11:11 AM · Restricted Project, Restricted Project

Sat, Apr 3

oontvoo accepted D99807: [lld-macho][nfc] Rename some tests.

LGTM!

Sat, Apr 3, 11:15 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D99385: [lld-macho] Add addition debug info.

updated diff:

  • stop excluding debug sessions from reloc-parsing (cos we need the info)
  • added some test
Sat, Apr 3, 11:13 AM · Restricted Project, Restricted Project

Fri, Apr 2

oontvoo accepted D99633: [lld-macho][nfc] Refactor in preparation for 32-bit support.
In D99633#2666577, @int3 wrote:

LGTM = stamp? :)

Fri, Apr 2, 11:07 AM · Restricted Project, Restricted Project
oontvoo added a comment to D99633: [lld-macho][nfc] Refactor in preparation for 32-bit support.

LGTM!

Fri, Apr 2, 9:45 AM · Restricted Project, Restricted Project

Thu, Apr 1

oontvoo planned changes to D99385: [lld-macho] Add addition debug info.
Thu, Apr 1, 10:10 AM · Restricted Project, Restricted Project
oontvoo added inline comments to D99633: [lld-macho][nfc] Refactor in preparation for 32-bit support.
Thu, Apr 1, 9:15 AM · Restricted Project, Restricted Project
oontvoo added inline comments to D99633: [lld-macho][nfc] Refactor in preparation for 32-bit support.
Thu, Apr 1, 8:20 AM · Restricted Project, Restricted Project

Tue, Mar 30

oontvoo accepted D99279: [lld-macho] Parallelize UUID hash computation.

LGTM

Tue, Mar 30, 10:13 AM · Restricted Project, Restricted Project
oontvoo accepted D99215: [lld-macho][nfc] Test that -ObjC will import bitcode with category sections.

Looks fairly straightforward to me

Tue, Mar 30, 9:30 AM · Restricted Project, Restricted Project

Mon, Mar 29

oontvoo accepted D99389: [lld-macho] Implement -segprot.
Mon, Mar 29, 11:05 AM · Restricted Project, Restricted Project
oontvoo accepted D99389: [lld-macho] Implement -segprot.
Mon, Mar 29, 10:09 AM · Restricted Project, Restricted Project

Thu, Mar 25

oontvoo added a comment to D99385: [lld-macho] Add addition debug info.
In D99385#2651954, @int3 wrote:

This is for https://bugs.llvm.org/show_bug.cgi?id=49282 right? For testing you could create a file with an undefined symbol. See e.g. test/ELF/undef.s.

Yeah. Thanks

Thu, Mar 25, 3:52 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D99385: [lld-macho] Add addition debug info.

updated diff to include the whole patch

Thu, Mar 25, 3:50 PM · Restricted Project, Restricted Project
oontvoo added a comment to D99385: [lld-macho] Add addition debug info.

@int3: not sure how to write a good test for this ?

Thu, Mar 25, 3:10 PM · Restricted Project, Restricted Project
oontvoo requested review of D99385: [lld-macho] Add addition debug info.
Thu, Mar 25, 3:10 PM · Restricted Project, Restricted Project
oontvoo closed D99210: [lld-macho][nfc] minor clean up, follow up to D98559.
Thu, Mar 25, 1:48 PM · Restricted Project, Restricted Project
oontvoo committed rGdee5787d3ee5: Reland [lld-macho][nfc] minor clean up, follow up to D98559 (authored by oontvoo).
Reland [lld-macho][nfc] minor clean up, follow up to D98559
Thu, Mar 25, 1:47 PM
oontvoo added a reverting change for rG77b4230ed9be: Revert "[lld-macho][nfc] minor clean up, follow up to D98559": rGdee5787d3ee5: Reland [lld-macho][nfc] minor clean up, follow up to D98559.
Thu, Mar 25, 1:47 PM
oontvoo committed rGe2f34cc330e2: [lld-macho][nfc] Removed unnecessary static_cast (authored by oontvoo).
[lld-macho][nfc] Removed unnecessary static_cast
Thu, Mar 25, 12:08 PM
oontvoo closed D99365: [lld-macho][nfc] Removed unnecessary static_cast.
Thu, Mar 25, 12:08 PM · Restricted Project, Restricted Project
oontvoo requested review of D99365: [lld-macho][nfc] Removed unnecessary static_cast.
Thu, Mar 25, 12:01 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D99210: [lld-macho][nfc] minor clean up, follow up to D98559.

updated diff

Thu, Mar 25, 11:37 AM · Restricted Project, Restricted Project
oontvoo accepted D99311: [lld-macho] Add more TimeTraceScopes.

The detailed graph looks nice! Thanks!

Thu, Mar 25, 11:08 AM · Restricted Project, Restricted Project
oontvoo added inline comments to D99311: [lld-macho] Add more TimeTraceScopes.
Thu, Mar 25, 10:06 AM · Restricted Project, Restricted Project
oontvoo accepted D99318: [lld-macho] Add time tracing for LTO.

Cool!

Thu, Mar 25, 9:59 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D99210: [lld-macho][nfc] minor clean up, follow up to D98559.

rebase

Thu, Mar 25, 8:26 AM · Restricted Project, Restricted Project

Wed, Mar 24

oontvoo committed rGd988ffc34fcb: [lld-macho][nfc] Fixed test so it output to %t/ rather than current directory. (authored by oontvoo).
[lld-macho][nfc] Fixed test so it output to %t/ rather than current directory.
Wed, Mar 24, 1:56 PM
oontvoo closed D99271: [lld-macho][nfc] Fixed test so it output to %t/ rather than current directory..
Wed, Mar 24, 1:56 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D99271: [lld-macho][nfc] Fixed test so it output to %t/ rather than current directory..

updated diff

Wed, Mar 24, 12:55 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D99271: [lld-macho][nfc] Fixed test so it output to %t/ rather than current directory..
Wed, Mar 24, 12:55 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D99279: [lld-macho] Parallelize UUID hash computation.
Wed, Mar 24, 12:49 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D99279: [lld-macho] Parallelize UUID hash computation.
Wed, Mar 24, 10:52 AM · Restricted Project, Restricted Project
oontvoo requested review of D99271: [lld-macho][nfc] Fixed test so it output to %t/ rather than current directory..
Wed, Mar 24, 8:50 AM · Restricted Project, Restricted Project

Tue, Mar 23

oontvoo updated the diff for D99210: [lld-macho][nfc] minor clean up, follow up to D98559.

Updated path-expectations to accept both backslash and forwardslash.

Tue, Mar 23, 8:00 PM · Restricted Project, Restricted Project
oontvoo reopened D99210: [lld-macho][nfc] minor clean up, follow up to D98559.
Tue, Mar 23, 7:59 PM · Restricted Project, Restricted Project
oontvoo added a comment to D99217: [lld-macho] Fixed lld-version expectation in test so it works on Fuchsia. On Fuchsia, it's called Fuchsia LLD.

@smeenai Thanks for the fix!

Tue, Mar 23, 4:44 PM · Restricted Project, Restricted Project
oontvoo committed rGaa6e4cdd7300: [lld-macho] Fixed lld-version expectation in test so it works on Fuchsia. (authored by oontvoo).
[lld-macho] Fixed lld-version expectation in test so it works on Fuchsia.
Tue, Mar 23, 2:57 PM
oontvoo closed D99217: [lld-macho] Fixed lld-version expectation in test so it works on Fuchsia. On Fuchsia, it's called Fuchsia LLD.
Tue, Mar 23, 2:56 PM · Restricted Project, Restricted Project
oontvoo requested review of D99217: [lld-macho] Fixed lld-version expectation in test so it works on Fuchsia. On Fuchsia, it's called Fuchsia LLD.
Tue, Mar 23, 2:52 PM · Restricted Project, Restricted Project
oontvoo added a reverting change for rG1bc33eb6a32b: [lld-macho][nfc] minor clean up, follow up to D98559: rG77b4230ed9be: Revert "[lld-macho][nfc] minor clean up, follow up to D98559".
Tue, Mar 23, 2:16 PM
oontvoo committed rG77b4230ed9be: Revert "[lld-macho][nfc] minor clean up, follow up to D98559" (authored by oontvoo).
Revert "[lld-macho][nfc] minor clean up, follow up to D98559"
Tue, Mar 23, 2:16 PM
oontvoo added a reverting change for D99210: [lld-macho][nfc] minor clean up, follow up to D98559: rG77b4230ed9be: Revert "[lld-macho][nfc] minor clean up, follow up to D98559".
Tue, Mar 23, 2:16 PM · Restricted Project, Restricted Project
oontvoo committed rG1bc33eb6a32b: [lld-macho][nfc] minor clean up, follow up to D98559 (authored by oontvoo).
[lld-macho][nfc] minor clean up, follow up to D98559
Tue, Mar 23, 1:13 PM
oontvoo closed D99210: [lld-macho][nfc] minor clean up, follow up to D98559.
Tue, Mar 23, 1:13 PM · Restricted Project, Restricted Project
oontvoo added a comment to D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

I've sent D99210

Tue, Mar 23, 12:55 PM · Restricted Project, Restricted Project
oontvoo requested review of D99210: [lld-macho][nfc] minor clean up, follow up to D98559.
Tue, Mar 23, 12:55 PM · Restricted Project, Restricted Project
oontvoo closed D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).
Tue, Mar 23, 11:54 AM · Restricted Project, Restricted Project
oontvoo added a reverting change for rG4876ba5b2d6a: Revert "Revert "Revert "Revert "Revert "[lld-macho] Implement -dependency_info…: rGf499b932bfc4: Revert "Revert "Revert "Revert "Revert "Revert "[lld-macho] Implement….
Tue, Mar 23, 11:51 AM
oontvoo committed rGf499b932bfc4: Revert "Revert "Revert "Revert "Revert "Revert "[lld-macho] Implement… (authored by oontvoo).
Revert "Revert "Revert "Revert "Revert "Revert "[lld-macho] Implement…
Tue, Mar 23, 11:51 AM
oontvoo updated the diff for D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

Updated diff. rebase.

Tue, Mar 23, 9:54 AM · Restricted Project, Restricted Project

Mon, Mar 22

oontvoo updated the diff for D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

Updated diff: explicitly specified "signed char" to avoid ambiguity

Mon, Mar 22, 8:26 PM · Restricted Project, Restricted Project
oontvoo added a comment to D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

Thanks for the revert! May be this patch is cursed 😕

Mon, Mar 22, 8:25 PM · Restricted Project, Restricted Project
oontvoo added a reverting change for rG9670d2e4af4c: Revert "Revert "Revert "[lld-macho] Implement -dependency_info (partially…: rG3c21166a94ea: Revert "Revert "Revert "Revert "[lld-macho] Implement -dependency_info….
Mon, Mar 22, 4:35 PM
oontvoo committed rG3c21166a94ea: Revert "Revert "Revert "Revert "[lld-macho] Implement -dependency_info… (authored by oontvoo).
Revert "Revert "Revert "Revert "[lld-macho] Implement -dependency_info…
Mon, Mar 22, 4:35 PM
oontvoo updated the diff for D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).
Mon, Mar 22, 2:06 PM · Restricted Project, Restricted Project
oontvoo planned changes to D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

bot still unhappy ... reverting again: https://reviews.llvm.org/rG9670d2e4af4c996098089e31b03ca138bc8d27e9

Mon, Mar 22, 11:55 AM · Restricted Project, Restricted Project
oontvoo added a reverting change for rG5ad2c225f353: Revert "Revert "[lld-macho] Implement -dependency_info (partially - more…: rG9670d2e4af4c: Revert "Revert "Revert "[lld-macho] Implement -dependency_info (partially….
Mon, Mar 22, 11:54 AM
oontvoo committed rG9670d2e4af4c: Revert "Revert "Revert "[lld-macho] Implement -dependency_info (partially… (authored by oontvoo).
Revert "Revert "Revert "[lld-macho] Implement -dependency_info (partially…
Mon, Mar 22, 11:54 AM
oontvoo added a reverting change for rG2554b95db57c: Revert "[lld-macho] Implement -dependency_info (partially - more opcodes…: rG5ad2c225f353: Revert "Revert "[lld-macho] Implement -dependency_info (partially - more….
Mon, Mar 22, 11:42 AM
oontvoo committed rG5ad2c225f353: Revert "Revert "[lld-macho] Implement -dependency_info (partially - more… (authored by oontvoo).
Revert "Revert "[lld-macho] Implement -dependency_info (partially - more…
Mon, Mar 22, 11:42 AM
oontvoo updated the diff for D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

updated diff

Mon, Mar 22, 11:41 AM · Restricted Project, Restricted Project
oontvoo added inline comments to D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).
Mon, Mar 22, 11:04 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

moved inline functions to header

Mon, Mar 22, 10:20 AM · Restricted Project, Restricted Project
oontvoo reopened D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).
Mon, Mar 22, 10:20 AM · Restricted Project, Restricted Project
oontvoo added a comment to D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).
In D98559#2640336, @thakis wrote:

Reverted in 2554b95db57cfcc13864d9bbb9f4e75892067c14 for now.

Mon, Mar 22, 10:20 AM · Restricted Project, Restricted Project

Sun, Mar 21

oontvoo committed rGc53a1322f329: [lld-macho] Implement -dependency_info (partially - more opcodes needed) (authored by oontvoo).
[lld-macho] Implement -dependency_info (partially - more opcodes needed)
Sun, Mar 21, 11:36 AM
oontvoo closed D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).
Sun, Mar 21, 11:36 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

updated diff

Sun, Mar 21, 11:35 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

rebase

Sun, Mar 21, 11:04 AM · Restricted Project, Restricted Project
oontvoo added inline comments to D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).
Sun, Mar 21, 11:02 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

updated diff

Sun, Mar 21, 11:02 AM · Restricted Project, Restricted Project
oontvoo retitled D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed) from [lld-macho] Implement -dependency_info to [lld-macho] Implement -dependency_info (partially - more opcodes needed).
Sun, Mar 21, 10:35 AM · Restricted Project, Restricted Project

Fri, Mar 19

oontvoo added inline comments to D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).
Fri, Mar 19, 2:12 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D98559: [lld-macho] Implement -dependency_info (partially - more opcodes needed).

updated diff

Fri, Mar 19, 2:12 PM · Restricted Project, Restricted Project
oontvoo committed rG6c1ae8f2dc37: [lld-macho][nfc] Fixed typo in comment (authored by oontvoo).
[lld-macho][nfc] Fixed typo in comment
Fri, Mar 19, 11:20 AM
oontvoo closed D98973: [lld-macho][nfc] Fixed typo in comment.
Fri, Mar 19, 11:20 AM · Restricted Project, Restricted Project
oontvoo requested review of D98973: [lld-macho][nfc] Fixed typo in comment.
Fri, Mar 19, 11:19 AM · Restricted Project, Restricted Project
oontvoo committed rG66f340051ac2: [lld-macho] Define __mh_*_header synthetic symbols. (authored by oontvoo).
[lld-macho] Define __mh_*_header synthetic symbols.
Fri, Mar 19, 11:16 AM
oontvoo closed D97007: [lld-macho] Define __mh_*_header synthetic symbols..
Fri, Mar 19, 11:15 AM · Restricted Project, Restricted Project
oontvoo added a comment to D97007: [lld-macho] Define __mh_*_header synthetic symbols..

Thanks!

Fri, Mar 19, 11:15 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D97007: [lld-macho] Define __mh_*_header synthetic symbols..

addressed review comments + rebase

Fri, Mar 19, 11:15 AM · Restricted Project, Restricted Project

Thu, Mar 18

oontvoo updated the diff for D97007: [lld-macho] Define __mh_*_header synthetic symbols..

fixed map-file test

Thu, Mar 18, 9:56 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D97007: [lld-macho] Define __mh_*_header synthetic symbols..

rebase

Thu, Mar 18, 9:02 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D97007: [lld-macho] Define __mh_*_header synthetic symbols..

Updated diff:

  • give MachHeaderSection a section index of 1.
  • added tests
Thu, Mar 18, 8:59 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D97007: [lld-macho] Define __mh_*_header synthetic symbols..
Thu, Mar 18, 8:59 PM · Restricted Project, Restricted Project