Page MenuHomePhabricator

oontvoo (Vy Nguyen)
Animal

Projects

User does not belong to any projects.

User Details

User Since
Apr 11 2019, 1:09 PM (206 w, 2 d)

Recent Activity

Thu, Mar 23

oontvoo updated the diff for D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..

(updated diff - forgot to include LLD's requested LLD change)

Thu, Mar 23, 8:18 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..

Updated diff:

  • flip the emit-compact-unwind-non-canonical flag's default value back to false
  • have all the generateCompactUnwind...() return MODE_DWARF (instead of 0, that was a bug).
Thu, Mar 23, 8:14 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 22

oontvoo updated the diff for D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..

Updated patch:

  • added LLD change + test
  • flip the new flag's default value to true to preserve current behaviour (easier to flip it to false and do test clean up separately)
Wed, Mar 22, 8:32 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Mar 16

oontvoo updated the summary of D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..
Thu, Mar 16, 11:39 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..

addressed review comment: check for isExternal() symbol

Thu, Mar 16, 11:36 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 15

oontvoo updated the diff for D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..

New change: added a flag (default to OFF) to allow emit compact-unwinds for non-canonical personalities.

Wed, Mar 15, 12:37 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Mar 9

oontvoo added a comment to D142916: [lld-macho] Warn on method name collisions from category definitions.

Reverted. A repro would be helpful!

Thu, Mar 9, 11:44 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D145654: [lld-macho] Don't include zero-size private label symbols in map file.

Seems test failures are related :) PTAL

Thu, Mar 9, 11:12 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 8

oontvoo added a comment to D142916: [lld-macho] Warn on method name collisions from category definitions.

Seems to cause segfaults in a lot of our builds .... :( Should we possibly revert this while investigating?

Wed, Mar 8, 11:14 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Mar 7

oontvoo planned changes to D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..

Adding an optional flag to request compact-unwind for non-canonical personalities.

Tue, Mar 7, 12:48 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..

So in other words for case #1, we'd end up with one "unused" CU slot.

Not sure why you think so -- we have three canonical personalities, not two, right? __gcc_personality_v0, __gxx_personality_v0, and __objc_personality_v0. Why would we end up with an unused slot?

Tue, Mar 7, 11:20 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..
  • reverted to original proposal with some modification (only make objc and c++ personality symbols canonical - leaving out gcc)
  • addressed review comments
Tue, Mar 7, 11:19 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Mar 6

oontvoo added a comment to D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..

As I understand, ld64's best workaround for this right now is the -no_compact_unwind flag. This would be trivial for us to support but of course not ideal from a binary size standpoint. However, from a UX standpoint, "getting an error when you add an additional object to the link" is basically the current situation. I think it is more important for us to prioritize perf + implementation simplicity over a somewhat rare UX edge case...

Mon, Mar 6, 12:55 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Mar 3

oontvoo added a comment to D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..

I'm also curious about the motivation here; this wouldn't be the most trivial linker change, especially if we are trying not to regress perf. Moreover, ld64 doesn't do this; I'm not even sure it has any flags that let it support more than 3 personalities. Is it just a linker UX thing?

Fri, Mar 3, 7:12 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Mar 2

oontvoo planned changes to D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..

One issue is that we need to emit ONLY dwarf-unwind for those functions which use nonstandard personalities, while femit-dwarf-unwind enables emitting both compact-unwind and dwarf unwind.

So IMO the ideal design is that we emit both and have the linker fall back to DWARF unwind info if the number of personalities is too large.

Thu, Mar 2, 10:37 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Feb 28

oontvoo added a comment to D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..

P.S: Will add tests/whatnot. This is just a draft proposal to get a feel for how folks feel about this change. Thanks

Tue, Feb 28, 12:31 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo requested review of D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs..
Tue, Feb 28, 12:23 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Feb 27

oontvoo added inline comments to D144596: [lld] Support separate native object file path in --thinlto-prefix-replace.
Mon, Feb 27, 5:52 AM · Restricted Project, Restricted Project, Restricted Project

Feb 23 2023

oontvoo added inline comments to D144596: [lld] Support separate native object file path in --thinlto-prefix-replace.
Feb 23 2023, 6:02 AM · Restricted Project, Restricted Project, Restricted Project

Feb 16 2023

oontvoo accepted D142916: [lld-macho] Warn on method name collisions from category definitions.

Thanks!

Feb 16 2023, 5:57 AM · Restricted Project, Restricted Project, Restricted Project

Jan 23 2023

oontvoo added a comment to D142248: [lld-macho] Do not warn on missing /usr/local/lib library search path.

Also, could we have a test?

I'm not sure of a good way to test this because I'm trying to test the scenario that passing in -L/usr/local/lib that doesn't exist on the host doesn't result in a warning (and when passing -L/usr/local/lib with -Z, it does result in a warning). AFAICT, I can't test the universally test the latter behavior because that relies on having a non-existent /usr/local/lib directory (which most developer machines will almost be guaranteed to have). I can create a test for the former. It'll be no-op for the most developers since developers will have the directory, but if not, the behavior should be the same.

Jan 23 2023, 12:27 PM · Restricted Project, Restricted Project, Restricted Project

Jan 11 2023

oontvoo accepted D141461: [lld-macho][nfc] Use alignToPowerOf2 instead of alignTo when possible.

LG

Jan 11 2023, 5:51 AM · Restricted Project, Restricted Project, Restricted Project

Jan 5 2023

oontvoo accepted D141025: [lld-macho] Don't support relocations in cstring sections.

LG

Jan 5 2023, 7:06 AM · Restricted Project, Restricted Project, Restricted Project

Jan 4 2023

oontvoo committed rGe9c824239397: [lld-macho][nfc] Re-enable previously disabled test. (authored by oontvoo).
[lld-macho][nfc] Re-enable previously disabled test.
Jan 4 2023, 9:41 AM · Restricted Project
oontvoo closed D140987: [lld-macho][nfc] Re-enable previously disabled test..
Jan 4 2023, 9:40 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the summary of D140987: [lld-macho][nfc] Re-enable previously disabled test..
Jan 4 2023, 6:59 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the summary of D140987: [lld-macho][nfc] Re-enable previously disabled test..
Jan 4 2023, 6:58 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated subscribers of D140987: [lld-macho][nfc] Re-enable previously disabled test..
Jan 4 2023, 6:56 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo requested review of D140987: [lld-macho][nfc] Re-enable previously disabled test..
Jan 4 2023, 6:51 AM · Restricted Project, Restricted Project, Restricted Project

Jan 3 2023

oontvoo abandoned D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

rescinding this in favour of D140491.
Thanks!

Jan 3 2023, 5:54 PM · Restricted Project, Restricted Project, Restricted Project

Dec 21 2022

oontvoo added a comment to D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

I feel bad for all the back-and-forth with @oontvoo's work, but in general I am in favor of things that improve ease of adoption. @keith's solution seems clean enough too. +1

Dec 21 2022, 2:52 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

typo

Dec 21 2022, 10:57 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

removed redundant whitespaces

Dec 21 2022, 10:56 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

Thanks!

Dec 21 2022, 10:55 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

addressed review comments:

  • put fileloc's at the beginning of the warn msg
  • remove ld64.lld from expected warning msgs in tests
  • add comments
Dec 21 2022, 10:55 AM · Restricted Project, Restricted Project, Restricted Project

Dec 20 2022

oontvoo updated the diff for D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

reformat

Dec 20 2022, 10:30 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

added more tests for missing libaries (-l) too. Also included the files where the bad LC_LINKER_OPTION live to help debugging

Dec 20 2022, 10:28 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

updated warning msg in test

Dec 20 2022, 10:03 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

Okay, you've convinced me. But just to clarify some of what I said earlier:

You've pointed out that we shouldn't require people to turn off warnings, but this proposed change would not introduce more warnings/errors than whatever already exists

Yes, but it still makes turning on -fatal_warnings harder. And I would like to be able to turn it on for most of our builds. (We are already looking at downgrading certain warnings internally to achieve this, but I would like to minimize the number of local patches.)

Dec 20 2022, 9:41 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

Updated diff to implement option #2, whic is to make missing frameworks/libraries warnings instead of errors.

Dec 20 2022, 9:35 PM · Restricted Project, Restricted Project, Restricted Project

Dec 19 2022

oontvoo added a comment to D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

Eh, in doubt I'd do what int3 recommends 😅

Dec 19 2022, 7:30 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

Hmm, unfortunately doesn't look like we have a majority here ... I guess how about we go with the option that requires the least API change which is #2 (ie., no new flag):

  • not-found-errors from LC_LINKER_OPTION are warnings by default
  • you can use the existing -ignore_linker_option to silence the warnings if desired.
Dec 19 2022, 11:10 AM · Restricted Project, Restricted Project, Restricted Project

Dec 17 2022

oontvoo committed rG7d4f70f8e598: Reland 3nd attempt: [lld-macho] Fix bug in reading cpuSubType field. (authored by oontvoo).
Reland 3nd attempt: [lld-macho] Fix bug in reading cpuSubType field.
Dec 17 2022, 8:36 PM · Restricted Project
oontvoo added a reverting change for rG09c5aab7f881: Revert "Reland 2nd attempt: [lld-macho] Fix bug in reading cpuSubType field.": rG7d4f70f8e598: Reland 3nd attempt: [lld-macho] Fix bug in reading cpuSubType field..
Dec 17 2022, 8:36 PM · Restricted Project
oontvoo closed D139572: [lld-macho] Fix bug in reading of cpusubtype field.
Dec 17 2022, 8:36 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D139572: [lld-macho] Fix bug in reading of cpusubtype field.

Reland #3: temporarily disabled checking cpu type after link due to suspected bug (described above).
(The current test that the link succeeded should be sufficient because
the link would have failed prior to this patch).

Dec 17 2022, 8:35 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo reopened D139572: [lld-macho] Fix bug in reading of cpusubtype field.
Dec 17 2022, 8:35 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D139572: [lld-macho] Fix bug in reading of cpusubtype field.
Dec 17 2022, 7:48 PM · Restricted Project, Restricted Project, Restricted Project

Dec 16 2022

oontvoo committed rGb08acee42393: Reland 2nd attempt: [lld-macho] Fix bug in reading cpuSubType field. (authored by oontvoo).
Reland 2nd attempt: [lld-macho] Fix bug in reading cpuSubType field.
Dec 16 2022, 7:04 PM · Restricted Project
oontvoo added a reverting change for rG52a118d08fbb: Revert "Reland [lld-macho] Fix bug in reading cpuSubType field.": rGb08acee42393: Reland 2nd attempt: [lld-macho] Fix bug in reading cpuSubType field..
Dec 16 2022, 7:04 PM · Restricted Project
oontvoo closed D139572: [lld-macho] Fix bug in reading of cpusubtype field.
Dec 16 2022, 7:04 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D139572: [lld-macho] Fix bug in reading of cpusubtype field.

reland 2nd attempt

Dec 16 2022, 7:01 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo reopened D139572: [lld-macho] Fix bug in reading of cpusubtype field.
Dec 16 2022, 7:01 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated subscribers of D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..
Dec 16 2022, 12:04 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

From offline discussions, we have a few options: (in no particular order)

Dec 16 2022, 12:02 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

I wonder if at this point we should just implement LD64's behavior with an off-by-default flag to be more strict? Specifically they ignore these failures and collect the missing ones and only print about them in the case the link fails

Dec 16 2022, 11:23 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..

@keith Since you initially implemented these LC_LINKER_OPTION support, perhaps you could help reviewing this?
Thx

Dec 16 2022, 9:58 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a reviewer for D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS.: keith.
Dec 16 2022, 9:57 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo requested review of D140225: [lld-macho] Provide an option to ignore framework-not-found errors coming from LC_LINKER_OPTIONS..
Dec 16 2022, 9:56 AM · Restricted Project, Restricted Project, Restricted Project

Dec 12 2022

oontvoo added a comment to D139572: [lld-macho] Fix bug in reading of cpusubtype field.

Thanks for the fast revert! :)

@thakis What kind of Mac do you have? Is it arm64? Just curious since I can't seem to reproduce the crash on my machines ( Mac (x86) and Linux)
Thanks!

Dec 12 2022, 10:00 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D139572: [lld-macho] Fix bug in reading of cpusubtype field.

Thanks for the fast revert! :)

Dec 12 2022, 7:48 AM · Restricted Project, Restricted Project, Restricted Project

Dec 9 2022

oontvoo added a reverting change for rGf472da190b65: Reland [lld-macho] Fix bug in reading cpuSubType field.: rG52a118d08fbb: Revert "Reland [lld-macho] Fix bug in reading cpuSubType field.".
Dec 9 2022, 12:08 PM · Restricted Project
oontvoo committed rG52a118d08fbb: Revert "Reland [lld-macho] Fix bug in reading cpuSubType field." (authored by oontvoo).
Revert "Reland [lld-macho] Fix bug in reading cpuSubType field."
Dec 9 2022, 12:08 PM · Restricted Project
oontvoo added a comment to D139572: [lld-macho] Fix bug in reading of cpusubtype field.
Dec 9 2022, 12:07 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a reverting change for D139572: [lld-macho] Fix bug in reading of cpusubtype field: rG52a118d08fbb: Revert "Reland [lld-macho] Fix bug in reading cpuSubType field.".
Dec 9 2022, 12:07 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a reverting change for rG66692c822aee: Revert "[lld-macho] Fix bug in reading cpuSubType field.": rGf472da190b65: Reland [lld-macho] Fix bug in reading cpuSubType field..
Dec 9 2022, 11:04 AM · Restricted Project
oontvoo committed rGf472da190b65: Reland [lld-macho] Fix bug in reading cpuSubType field. (authored by oontvoo).
Reland [lld-macho] Fix bug in reading cpuSubType field.
Dec 9 2022, 11:04 AM · Restricted Project
oontvoo closed D139572: [lld-macho] Fix bug in reading of cpusubtype field.
Dec 9 2022, 11:04 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo committed rG0073fd8d0dda: Add the thread sanitizer support for X86_64 WatchOS simulators (authored by yfyang).
Add the thread sanitizer support for X86_64 WatchOS simulators
Dec 9 2022, 10:33 AM · Restricted Project, Restricted Project
oontvoo closed D139652: Add the thread sanitizer support for X86_64 WatchOS simulators.
Dec 9 2022, 10:33 AM · Restricted Project, Restricted Project
oontvoo updated the diff for D139572: [lld-macho] Fix bug in reading of cpusubtype field.

updated tests and reland

Dec 9 2022, 7:13 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo reopened D139572: [lld-macho] Fix bug in reading of cpusubtype field.
Dec 9 2022, 7:13 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D139572: [lld-macho] Fix bug in reading of cpusubtype field.
Dec 9 2022, 7:13 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D139572: [lld-macho] Fix bug in reading of cpusubtype field.

Thanks for the revert!

Dec 9 2022, 6:08 AM · Restricted Project, Restricted Project, Restricted Project

Dec 8 2022

oontvoo committed rGe54cfa48d2d5: [lld-macho] Fix bug in reading cpuSubType field. (authored by oontvoo).
[lld-macho] Fix bug in reading cpuSubType field.
Dec 8 2022, 7:10 PM · Restricted Project
oontvoo closed D139572: [lld-macho] Fix bug in reading of cpusubtype field.
Dec 8 2022, 7:10 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D139572: [lld-macho] Fix bug in reading of cpusubtype field.

Thx!

Dec 8 2022, 7:09 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D139572: [lld-macho] Fix bug in reading of cpusubtype field.

addressed review comment + rebase

Dec 8 2022, 7:09 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D139572: [lld-macho] Fix bug in reading of cpusubtype field.

rebase + fix typo

Dec 8 2022, 9:42 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo added inline comments to D139572: [lld-macho] Fix bug in reading of cpusubtype field.
Dec 8 2022, 7:35 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D139572: [lld-macho] Fix bug in reading of cpusubtype field.

Is there a test we could write here? How do the other bits in cpusubtype get set?

Dec 8 2022, 7:34 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D139572: [lld-macho] Fix bug in reading of cpusubtype field.

addressed review comments + added missing tests

Dec 8 2022, 7:33 AM · Restricted Project, Restricted Project, Restricted Project

Dec 7 2022

oontvoo requested review of D139572: [lld-macho] Fix bug in reading of cpusubtype field.
Dec 7 2022, 12:55 PM · Restricted Project, Restricted Project, Restricted Project

Dec 1 2022

oontvoo accepted D139069: [lld-macho] Private label aliases to weak symbols should not retain section data.

(Not sure why git-clang-format is failing for the debian build ... probably unrelated?)

Dec 1 2022, 6:05 AM · Restricted Project, Restricted Project, Restricted Project

Nov 30 2022

oontvoo added inline comments to D139069: [lld-macho] Private label aliases to weak symbols should not retain section data.
Nov 30 2022, 7:39 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo added inline comments to D139069: [lld-macho] Private label aliases to weak symbols should not retain section data.
Nov 30 2022, 7:26 PM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D138891: [MachO] Prevent overflow on 32-bit platforms when calculating load command offsets.

This was my solution to the related changeset D138830. It simplifies the logic a lot compared to that revision while still ensuring no overflow during calculation. I did not see the other overflows so perhaps it may be better to merge the two in some way. I'm not sure how to do that in Phabricator.

Nov 30 2022, 12:39 PM · Restricted Project, Restricted Project
oontvoo added inline comments to D138830: [llvm] Check for overflows when computing load-command's addresses..
Nov 30 2022, 5:51 AM · Restricted Project, Restricted Project

Nov 29 2022

oontvoo updated the diff for D138830: [llvm] Check for overflows when computing load-command's addresses..

updated err msgs and removed a few asserts

Nov 29 2022, 12:40 PM · Restricted Project, Restricted Project

Nov 28 2022

oontvoo requested review of D138830: [llvm] Check for overflows when computing load-command's addresses..
Nov 28 2022, 12:38 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D138830: [llvm] Check for overflows when computing load-command's addresses..

addressed review comment:

  • refactor code so that the overflow checks can be done in place
  • remove redundant check
  • fix off-by-one
Nov 28 2022, 12:35 PM · Restricted Project, Restricted Project
oontvoo updated the diff for D138830: [llvm] Check for overflows when computing load-command's addresses..
  • updated type
  • separate overflow case to different err msg to make debugging easier
Nov 28 2022, 10:38 AM · Restricted Project, Restricted Project
oontvoo added inline comments to D138830: [llvm] Check for overflows when computing load-command's addresses..
Nov 28 2022, 10:27 AM · Restricted Project, Restricted Project
oontvoo added a reviewer for D138830: [llvm] Check for overflows when computing load-command's addresses.: awilfox.
Nov 28 2022, 9:16 AM · Restricted Project, Restricted Project
oontvoo requested review of D138830: [llvm] Check for overflows when computing load-command's addresses..
Nov 28 2022, 9:15 AM · Restricted Project, Restricted Project

Nov 22 2022

oontvoo committed rG65226d3f1f53: [lld-macho] Fix bug in CUE folding that resulted in wrong unwind table. (authored by oontvoo).
[lld-macho] Fix bug in CUE folding that resulted in wrong unwind table.
Nov 22 2022, 7:41 AM · Restricted Project
oontvoo closed D138320: [lld-macho] Fix bug in CUE folding that resulted in wrong unwind table..
Nov 22 2022, 7:40 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo added a comment to D138320: [lld-macho] Fix bug in CUE folding that resulted in wrong unwind table..

thanks!

Nov 22 2022, 7:40 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo updated the diff for D138320: [lld-macho] Fix bug in CUE folding that resulted in wrong unwind table..

address review comments + rebase

Nov 22 2022, 7:40 AM · Restricted Project, Restricted Project, Restricted Project
oontvoo added inline comments to D138320: [lld-macho] Fix bug in CUE folding that resulted in wrong unwind table..
Nov 22 2022, 7:39 AM · Restricted Project, Restricted Project, Restricted Project