Page MenuHomePhabricator

int3 (Jez Ng)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 22 2020, 2:12 PM (18 w, 6 d)

Recent Activity

Yesterday

int3 updated the diff for D80857: [lld-macho] Handle GOT relocations of non-dylib symbols.

make sure to skip over non-dylib symbol entries when generating bind opcodes for GOT

Tue, Jun 2, 11:58 PM · Restricted Project
int3 accepted D80677: [lld-macho] Handle framework search path, alongside library search path.
Tue, Jun 2, 3:56 PM · Restricted Project
int3 updated the summary of D80859: [lld-macho] Ensure __bss sections we output have file offset of zero.
Tue, Jun 2, 3:56 PM · Restricted Project
int3 added a comment to D80859: [lld-macho] Ensure __bss sections we output have file offset of zero.

If no tool enforces this, then maybe this is unnecessary?

Tue, Jun 2, 3:56 PM · Restricted Project
int3 updated the diff for D80857: [lld-macho] Handle GOT relocations of non-dylib symbols.

address comments

Tue, Jun 2, 3:56 PM · Restricted Project
int3 added inline comments to D80857: [lld-macho] Handle GOT relocations of non-dylib symbols.
Tue, Jun 2, 3:56 PM · Restricted Project
int3 added a comment to D80856: [lld-macho] Support X86_64_RELOC_GOT.

@MaskRay yup that's my understanding too

Tue, Jun 2, 3:56 PM · Restricted Project
int3 added a comment to D80177: [lld-macho] Set __PAGEZERO size to 4GB.

Thanks for the heads up, just pushed a likely fix and will monitor http://lab.llvm.org:8011/builders/lld-x86_64-win. I'll set up a local Windows VM to catch future such issues earlier...

Tue, Jun 2, 3:56 PM · Restricted Project
int3 committed rGd767de44bf95: [lld-macho] Fix PAGEZERO=4GB errors on Windows by ensuring enum is uint64_t (authored by int3).
[lld-macho] Fix PAGEZERO=4GB errors on Windows by ensuring enum is uint64_t
Tue, Jun 2, 3:25 PM
int3 committed rG1e1a3f67ee71: [lld-macho] Ensure reads from nlist_64 structs are aligned when necessary (authored by int3).
[lld-macho] Ensure reads from nlist_64 structs are aligned when necessary
Tue, Jun 2, 1:45 PM
int3 closed D80414: [lld-macho] Ensure reads from nlist_64 structs are aligned when necessary.
Tue, Jun 2, 1:45 PM · Restricted Project
int3 committed rGa04c133564e6: [lld-macho] Set __PAGEZERO size to 4GB (authored by int3).
[lld-macho] Set __PAGEZERO size to 4GB
Tue, Jun 2, 1:45 PM
int3 committed rGf04d1c3b90c1: [lld-macho] Move all tests for erroneous inputs under invalid/ (authored by int3).
[lld-macho] Move all tests for erroneous inputs under invalid/
Tue, Jun 2, 1:45 PM
int3 closed D80177: [lld-macho] Set __PAGEZERO size to 4GB.
Tue, Jun 2, 1:44 PM · Restricted Project
int3 closed D80217: [lld-macho] Move all tests for erroneous inputs under invalid/.
Tue, Jun 2, 1:44 PM · Restricted Project
int3 committed rG6f6d91867da1: [lld-macho] Add some relocation validation logic (authored by int3).
[lld-macho] Add some relocation validation logic
Tue, Jun 2, 1:44 PM
int3 committed rGdf2a5778c32b: [lld-macho] Error on encountering undefined symbols (authored by int3).
[lld-macho] Error on encountering undefined symbols
Tue, Jun 2, 1:44 PM
int3 closed D80169: [lld-macho] Error on encountering undefined symbols.
Tue, Jun 2, 1:44 PM · Restricted Project
int3 closed D80049: [lld-macho] Add some relocation validation logic.
Tue, Jun 2, 1:44 PM · Restricted Project

Fri, May 29

int3 updated the diff for D80854: [lld-macho] Properly handle & validate relocation r_length.

update

Fri, May 29, 11:57 PM · Restricted Project
int3 updated the summary of D80859: [lld-macho] Ensure __bss sections we output have file offset of zero.
Fri, May 29, 10:18 PM · Restricted Project
int3 created D80859: [lld-macho] Ensure __bss sections we output have file offset of zero.
Fri, May 29, 10:18 PM · Restricted Project
int3 added a child revision for D80857: [lld-macho] Handle GOT relocations of non-dylib symbols: D80859: [lld-macho] Ensure __bss sections we output have file offset of zero.
Fri, May 29, 10:18 PM · Restricted Project
int3 created D80856: [lld-macho] Support X86_64_RELOC_GOT.
Fri, May 29, 9:46 PM · Restricted Project
int3 added a child revision for D80856: [lld-macho] Support X86_64_RELOC_GOT: D80857: [lld-macho] Handle GOT relocations of non-dylib symbols.
Fri, May 29, 9:46 PM · Restricted Project
int3 created D80857: [lld-macho] Handle GOT relocations of non-dylib symbols.
Fri, May 29, 9:46 PM · Restricted Project
int3 added reviewers for D80854: [lld-macho] Properly handle & validate relocation r_length: ruiu, pcc, MaskRay, christylee, smeenai, alexshap, Ktwu, gkm.
Fri, May 29, 9:46 PM · Restricted Project
int3 created D80855: [lld-macho] Support non-pcrel section relocs.
Fri, May 29, 9:46 PM · Restricted Project
int3 added a child revision for D80855: [lld-macho] Support non-pcrel section relocs: D80856: [lld-macho] Support X86_64_RELOC_GOT.
Fri, May 29, 9:46 PM · Restricted Project
int3 created D80854: [lld-macho] Properly handle & validate relocation r_length.
Fri, May 29, 9:46 PM · Restricted Project
int3 added a child revision for D80414: [lld-macho] Ensure reads from nlist_64 structs are aligned when necessary: D80854: [lld-macho] Properly handle & validate relocation r_length.
Fri, May 29, 9:46 PM · Restricted Project
int3 added a child revision for D80854: [lld-macho] Properly handle & validate relocation r_length: D80855: [lld-macho] Support non-pcrel section relocs.
Fri, May 29, 9:46 PM · Restricted Project
int3 updated the diff for D80414: [lld-macho] Ensure reads from nlist_64 structs are aligned when necessary.

remove comment

Fri, May 29, 9:14 PM · Restricted Project
int3 added inline comments to D80414: [lld-macho] Ensure reads from nlist_64 structs are aligned when necessary.
Fri, May 29, 9:14 PM · Restricted Project

Thu, May 28

int3 added inline comments to D80677: [lld-macho] Handle framework search path, alongside library search path.
Thu, May 28, 5:38 PM · Restricted Project

Wed, May 27

int3 added inline comments to D80677: [lld-macho] Handle framework search path, alongside library search path.
Wed, May 27, 6:02 PM · Restricted Project
int3 updated the diff for D80414: [lld-macho] Ensure reads from nlist_64 structs are aligned when necessary.

use support::ulittle

Wed, May 27, 3:12 AM · Restricted Project
int3 added a comment to D80414: [lld-macho] Ensure reads from nlist_64 structs are aligned when necessary.

The alignment wrappers are really neat! Especially that operator value_type() trick...

Wed, May 27, 3:12 AM · Restricted Project

Thu, May 21

int3 updated the summary of D80414: [lld-macho] Ensure reads from nlist_64 structs are aligned when necessary.
Thu, May 21, 6:25 PM · Restricted Project
int3 created D80414: [lld-macho] Ensure reads from nlist_64 structs are aligned when necessary.
Thu, May 21, 3:43 PM · Restricted Project
int3 added a child revision for D80217: [lld-macho] Move all tests for erroneous inputs under invalid/: D80414: [lld-macho] Ensure reads from nlist_64 structs are aligned when necessary.
Thu, May 21, 3:43 PM · Restricted Project
int3 updated the diff for D80049: [lld-macho] Add some relocation validation logic.

address comment

Thu, May 21, 1:32 PM · Restricted Project
int3 added inline comments to D80049: [lld-macho] Add some relocation validation logic.
Thu, May 21, 1:32 PM · Restricted Project
int3 added inline comments to D80049: [lld-macho] Add some relocation validation logic.
Thu, May 21, 12:26 PM · Restricted Project

Wed, May 20

int3 updated the diff for D80177: [lld-macho] Set __PAGEZERO size to 4GB.

llvm_unreachable

Wed, May 20, 4:00 PM · Restricted Project
int3 updated the diff for D80049: [lld-macho] Add some relocation validation logic.

move to getImplicitAddend

Wed, May 20, 4:00 PM · Restricted Project

Tue, May 19

int3 updated the diff for D80177: [lld-macho] Set __PAGEZERO size to 4GB.

fatal

Tue, May 19, 8:21 PM · Restricted Project
int3 updated the diff for D80169: [lld-macho] Error on encountering undefined symbols.

move to scanRelocations

Tue, May 19, 4:34 PM · Restricted Project
int3 added inline comments to D80177: [lld-macho] Set __PAGEZERO size to 4GB.
Tue, May 19, 4:34 PM · Restricted Project
int3 updated the diff for D80177: [lld-macho] Set __PAGEZERO size to 4GB.

make ENTRYOFF a numeric var

Tue, May 19, 3:27 PM · Restricted Project
int3 updated the diff for D80177: [lld-macho] Set __PAGEZERO size to 4GB.

fix and add test

Tue, May 19, 3:27 PM · Restricted Project
int3 added inline comments to D80177: [lld-macho] Set __PAGEZERO size to 4GB.
Tue, May 19, 3:27 PM · Restricted Project
int3 committed rGce0d8beebcf0: [lld-macho][re-land] Support X86_64_RELOC_UNSIGNED (authored by int3).
[lld-macho][re-land] Support X86_64_RELOC_UNSIGNED
Tue, May 19, 12:39 PM
int3 added a reverting change for rGdb8559eee4a0: Revert "[lld-macho] Support X86_64_RELOC_UNSIGNED": rGce0d8beebcf0: [lld-macho][re-land] Support X86_64_RELOC_UNSIGNED.
Tue, May 19, 12:39 PM
int3 committed rG4eb6f4854eba: [lld-macho][re-land] Support .subsections_via_symbols (authored by int3).
[lld-macho][re-land] Support .subsections_via_symbols
Tue, May 19, 12:38 PM
int3 closed D79926: [lld-macho] Support .subsections_via_symbols.
Tue, May 19, 12:38 PM · Restricted Project
int3 reopened D79926: [lld-macho] Support .subsections_via_symbols.
Tue, May 19, 9:16 AM · Restricted Project
int3 updated the diff for D79926: [lld-macho] Support .subsections_via_symbols.

ArrayRef is immutable so elements don't need to be const

Tue, May 19, 9:16 AM · Restricted Project
int3 committed rG70fbbcdd3437: Revert "[lld-macho] Support .subsections_via_symbols" (authored by int3).
Revert "[lld-macho] Support .subsections_via_symbols"
Tue, May 19, 8:44 AM
int3 added a reverting change for rGe270b2f1727c: [lld-macho] Support .subsections_via_symbols: rG70fbbcdd3437: Revert "[lld-macho] Support .subsections_via_symbols".
Tue, May 19, 8:43 AM
int3 committed rGdb8559eee4a0: Revert "[lld-macho] Support X86_64_RELOC_UNSIGNED" (authored by int3).
Revert "[lld-macho] Support X86_64_RELOC_UNSIGNED"
Tue, May 19, 8:43 AM
int3 added a reverting change for rG1f820e35596b: [lld-macho] Support X86_64_RELOC_UNSIGNED: rGdb8559eee4a0: Revert "[lld-macho] Support X86_64_RELOC_UNSIGNED".
Tue, May 19, 8:42 AM
int3 added inline comments to D79926: [lld-macho] Support .subsections_via_symbols.
Tue, May 19, 8:41 AM · Restricted Project
int3 committed rGe270b2f1727c: [lld-macho] Support .subsections_via_symbols (authored by int3).
[lld-macho] Support .subsections_via_symbols
Tue, May 19, 8:10 AM
int3 committed rG1f820e35596b: [lld-macho] Support X86_64_RELOC_UNSIGNED (authored by int3).
[lld-macho] Support X86_64_RELOC_UNSIGNED
Tue, May 19, 8:10 AM
int3 committed rG55e9eb416ee5: [lld-macho] Support -order_file (authored by int3).
[lld-macho] Support -order_file
Tue, May 19, 8:09 AM
int3 closed D79926: [lld-macho] Support .subsections_via_symbols.
Tue, May 19, 8:09 AM · Restricted Project
int3 closed D80048: [lld-macho] Support X86_64_RELOC_UNSIGNED.
Tue, May 19, 8:09 AM · Restricted Project
int3 closed D79668: [lld-macho] Support -order_file.
Tue, May 19, 8:08 AM · Restricted Project
int3 updated the diff for D80217: [lld-macho] Move all tests for erroneous inputs under invalid/.

update

Tue, May 19, 8:07 AM · Restricted Project
int3 created D80217: [lld-macho] Move all tests for erroneous inputs under invalid/.
Tue, May 19, 8:07 AM · Restricted Project
int3 committed rG1aadd6ce6128: [lld] Remove unused lld/test/Driver/Inputs/**/libtest.a (authored by gkm).
[lld] Remove unused lld/test/Driver/Inputs/**/libtest.a
Tue, May 19, 7:35 AM
int3 closed D80182: [lld] Remove unused lld/test/Driver/Inputs/**/libtest.a.
Tue, May 19, 7:35 AM · Restricted Project

Mon, May 18

int3 created D80177: [lld-macho] Set __PAGEZERO size to 4GB.
Mon, May 18, 9:09 PM · Restricted Project
int3 updated the diff for D79926: [lld-macho] Support .subsections_via_symbols.

add TODO

Mon, May 18, 8:36 PM · Restricted Project
int3 added inline comments to D79926: [lld-macho] Support .subsections_via_symbols.
Mon, May 18, 8:36 PM · Restricted Project
int3 updated the diff for D79668: [lld-macho] Support -order_file.

address comments

Mon, May 18, 6:58 PM · Restricted Project
int3 added inline comments to D79668: [lld-macho] Support -order_file.
Mon, May 18, 4:17 PM · Restricted Project
int3 created D80169: [lld-macho] Error on encountering undefined symbols.
Mon, May 18, 4:17 PM · Restricted Project
int3 added a child revision for D80049: [lld-macho] Add some relocation validation logic: D80169: [lld-macho] Error on encountering undefined symbols.
Mon, May 18, 4:17 PM · Restricted Project

Fri, May 15

int3 updated the diff for D79926: [lld-macho] Support .subsections_via_symbols.

update

Fri, May 15, 9:54 PM · Restricted Project
int3 updated the diff for D79926: [lld-macho] Support .subsections_via_symbols.

address comments

Fri, May 15, 9:54 PM · Restricted Project
int3 added inline comments to D79926: [lld-macho] Support .subsections_via_symbols.
Fri, May 15, 9:54 PM · Restricted Project
int3 updated the diff for D79668: [lld-macho] Support -order_file.

update

Fri, May 15, 9:11 PM · Restricted Project
int3 added inline comments to D80048: [lld-macho] Support X86_64_RELOC_UNSIGNED.
Fri, May 15, 9:11 PM · Restricted Project
int3 added inline comments to D79668: [lld-macho] Support -order_file.
Fri, May 15, 8:37 PM · Restricted Project
int3 updated the diff for D79668: [lld-macho] Support -order_file.

address comments

Fri, May 15, 8:37 PM · Restricted Project
int3 added inline comments to D79668: [lld-macho] Support -order_file.
Fri, May 15, 4:52 PM · Restricted Project
int3 updated the summary of D80049: [lld-macho] Add some relocation validation logic.
Fri, May 15, 4:52 PM · Restricted Project
int3 created D80049: [lld-macho] Add some relocation validation logic.
Fri, May 15, 4:52 PM · Restricted Project
int3 created D80048: [lld-macho] Support X86_64_RELOC_UNSIGNED.
Fri, May 15, 4:52 PM · Restricted Project
int3 added a child revision for D80048: [lld-macho] Support X86_64_RELOC_UNSIGNED: D80049: [lld-macho] Add some relocation validation logic.
Fri, May 15, 4:52 PM · Restricted Project
int3 added a child revision for D79926: [lld-macho] Support .subsections_via_symbols: D80048: [lld-macho] Support X86_64_RELOC_UNSIGNED.
Fri, May 15, 4:52 PM · Restricted Project

Thu, May 14

int3 updated the diff for D79926: [lld-macho] Support .subsections_via_symbols.

rebase

Thu, May 14, 5:26 PM · Restricted Project
int3 updated the diff for D79668: [lld-macho] Support -order_file.

rebase + support archive files

Thu, May 14, 5:26 PM · Restricted Project
int3 added inline comments to D78342: [lld] Add archive file support to Mach-O backend.
Thu, May 14, 4:53 PM · Restricted Project
int3 added inline comments to D78342: [lld] Add archive file support to Mach-O backend.
Thu, May 14, 4:21 PM · Restricted Project
int3 committed rG2b920ae78c1d: [lld] Add archive file support to Mach-O backend (authored by Ktwu).
[lld] Add archive file support to Mach-O backend
Thu, May 14, 1:05 PM
int3 closed D78342: [lld] Add archive file support to Mach-O backend.
Thu, May 14, 1:05 PM · Restricted Project
int3 added inline comments to D78342: [lld] Add archive file support to Mach-O backend.
Thu, May 14, 1:03 PM · Restricted Project