Page MenuHomePhabricator

int3 (Jez Ng)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 22 2020, 2:12 PM (127 w, 1 d)

Recent Activity

Yesterday

int3 accepted D128942: [lld-macho] Handle LOH_ARM64_ADRP_LDR linker optimization hints.

lgtm

Thu, Jun 30, 2:07 PM · Restricted Project, Restricted Project, Restricted Project
int3 updated the summary of D127637: [MC][MachO] Change addrsig format + ensure its size is properly set.
Thu, Jun 30, 1:41 PM · Restricted Project, Restricted Project
int3 added reviewers for D127637: [MC][MachO] Change addrsig format + ensure its size is properly set: pcc, MaskRay, grosbach.
Thu, Jun 30, 12:56 PM · Restricted Project, Restricted Project
int3 planned changes to D123729: [llvm-mc][macho][RFC] Enable DwarfFDESymbolsUseAbsDiff on aarch64.
Thu, Jun 30, 12:51 PM · Restricted Project, Restricted Project
int3 updated the summary of D127637: [MC][MachO] Change addrsig format + ensure its size is properly set.
Thu, Jun 30, 12:49 PM · Restricted Project, Restricted Project
int3 requested review of D128938: [lld-macho] Read in new addrsig format.
Thu, Jun 30, 12:49 PM · Restricted Project, Restricted Project, Restricted Project
int3 updated the diff for D127637: [MC][MachO] Change addrsig format + ensure its size is properly set.

use pointer sized relocs

Thu, Jun 30, 12:49 PM · Restricted Project, Restricted Project
int3 updated the diff for D127637: [MC][MachO] Change addrsig format + ensure its size is properly set.

new approach

Thu, Jun 30, 12:12 PM · Restricted Project, Restricted Project

Wed, Jun 29

int3 accepted D128093: [lld-macho] Initial support for Linker Optimization Hints.

lgtm

Wed, Jun 29, 12:58 PM · Restricted Project, Restricted Project, Restricted Project
int3 added inline comments to D128093: [lld-macho] Initial support for Linker Optimization Hints.
Wed, Jun 29, 12:34 PM · Restricted Project, Restricted Project, Restricted Project
int3 accepted D128798: [lld-macho] Emit REBASE_OPCODE_ADD_ADDR_IMM_SCALED if possible.

Thanks!

Wed, Jun 29, 11:33 AM · Restricted Project, Restricted Project, Restricted Project
int3 added inline comments to D128093: [lld-macho] Initial support for Linker Optimization Hints.
Wed, Jun 29, 11:07 AM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D128093: [lld-macho] Initial support for Linker Optimization Hints.

Nice perf optimizations btw :)

Wed, Jun 29, 11:03 AM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D128093: [lld-macho] Initial support for Linker Optimization Hints.

just one question about the bounds check, otherwise this lgtm

Wed, Jun 29, 11:03 AM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D128798: [lld-macho] Emit REBASE_OPCODE_ADD_ADDR_IMM_SCALED if possible.

can we have a test for this? obj2yaml dumps out the exact opcodes used, so we can check using that. See e.g. bind-opcodes.s

Wed, Jun 29, 10:30 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 27

int3 added inline comments to D128093: [lld-macho] Initial support for Linker Optimization Hints.
Mon, Jun 27, 9:32 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 23

int3 added inline comments to D128093: [lld-macho] Initial support for Linker Optimization Hints.
Thu, Jun 23, 8:15 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 22

int3 accepted D128343: [lld/mac] Add a few TimeTraceScopes.

lgtm

Wed, Jun 22, 9:29 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 21

int3 accepted D128294: [ADT] [lld-macho] Check for end iterator deref in filter_iterator_base.

much shorter test case, nice :)

Tue, Jun 21, 12:02 PM · Restricted Project, Restricted Project, Restricted Project
int3 accepted D128290: [lld/mac] On Apple systems, call CC_SHA256 from libSystem.
Tue, Jun 21, 11:36 AM · Restricted Project, Restricted Project, Restricted Project
int3 added inline comments to D128294: [ADT] [lld-macho] Check for end iterator deref in filter_iterator_base.
Tue, Jun 21, 11:35 AM · Restricted Project, Restricted Project, Restricted Project
int3 added inline comments to D128294: [ADT] [lld-macho] Check for end iterator deref in filter_iterator_base.
Tue, Jun 21, 11:34 AM · Restricted Project, Restricted Project, Restricted Project
int3 added inline comments to D128294: [ADT] [lld-macho] Check for end iterator deref in filter_iterator_base.
Tue, Jun 21, 11:33 AM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D128290: [lld/mac] On Apple systems, call CC_SHA256 from libSystem.

17%, wow

Tue, Jun 21, 11:31 AM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D128093: [lld-macho] Initial support for Linker Optimization Hints.

The added overhead on linking Chromium is 200 milliseconds on my M1 Mac mini, which accounts for about 4% of the total runtime.

Tue, Jun 21, 11:30 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 16

int3 committed rG8eeede973c69: [lld-macho][nfc] Tests for -force_load + regular archive load combinations (authored by int3).
[lld-macho][nfc] Tests for -force_load + regular archive load combinations
Thu, Jun 16, 8:50 PM · Restricted Project
int3 closed D128025: [lld-macho][nfc] Tests for -force_load + regular archive load combinations.
Thu, Jun 16, 8:50 PM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D128025: [lld-macho][nfc] Tests for -force_load + regular archive load combinations.

Maybe after D127941: [lld-macho] Fix an issue where Objective-C symbols where not force-loaded due to LC_LINKER_OPTION lands

Thu, Jun 16, 8:47 PM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D128020: [lld-macho] Fix parsing of $ld$ symbols with $ in them.

@keith gotcha. I think the commit message / title is confusing since this isn't an actual fix

Thu, Jun 16, 8:45 PM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D128020: [lld-macho] Fix parsing of $ld$ symbols with $ in them.

Hm so is this actually fixing the handling of these symbols, or just raising an assertion error when we encounter them?

Thu, Jun 16, 8:36 PM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D128020: [lld-macho] Fix parsing of $ld$ symbols with $ in them.

Could we have a test?

Thu, Jun 16, 8:28 PM · Restricted Project, Restricted Project, Restricted Project
int3 requested review of D128025: [lld-macho][nfc] Tests for -force_load + regular archive load combinations.
Thu, Jun 16, 8:22 PM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D127941: [lld-macho] Fix an issue where Objective-C symbols where not force-loaded due to LC_LINKER_OPTION.

Can you make the commit message more detailed? It's 1) nice not to make people go to GH issues to understand the changes 2) the description in the issue isn't super clear as-is (I understood the diff better after looking at the test case)

Thu, Jun 16, 6:03 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 14

int3 accepted D127753: [lld-macho] Group undefined symbol diagnostics by symbol.
Tue, Jun 14, 10:52 AM · Restricted Project, Restricted Project, Restricted Project
int3 added inline comments to D127753: [lld-macho] Group undefined symbol diagnostics by symbol.
Tue, Jun 14, 8:59 AM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D127696: [lld-macho] Print the name of functions containing undefined references.

One minute apart :) but yeah we can address that in a followup

Tue, Jun 14, 6:41 AM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D127696: [lld-macho] Print the name of functions containing undefined references.

And even for people who know what it means and can read assembly, what's the added value of knowing which offset in a function has the reference?

Tue, Jun 14, 6:40 AM · Restricted Project, Restricted Project, Restricted Project
int3 accepted D119668: [lld-macho] Add -static.

lgtm

Tue, Jun 14, 3:01 AM · Restricted Project, Restricted Project, Restricted Project
int3 accepted D127696: [lld-macho] Print the name of functions containing undefined references.

Should we omit it too, at least for undefined symbol diags?

Tue, Jun 14, 2:56 AM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D127670: [lld-macho] Fix symbol name returned from InputSection::getLocation.

For the refactor patch: There are usually few symbols per section, so a linear scan is likely faster in practice. Also, this function is only called when emitting errors, so it's not performance-critical anyways, probably. So I guess the motivation for that part is clarity?

Tue, Jun 14, 2:53 AM · Restricted Project, Restricted Project, Restricted Project
int3 accepted D127562: [lld-macho] Add support for exporting no symbols.

Thanks!

Tue, Jun 14, 2:48 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 13

int3 added a comment to D124561: [lld-macho] Support EH frames under arm64.

My bad, I now see you pointed it out in an earlier comment as well. Sorry about the churn.

Mon, Jun 13, 11:07 AM · Restricted Project, Restricted Project, Restricted Project
int3 committed rG224094eb447f: [lld-macho] Require aarch64 for eh-frame.s test (authored by int3).
[lld-macho] Require aarch64 for eh-frame.s test
Mon, Jun 13, 11:05 AM · Restricted Project
int3 planned changes to D127637: [MC][MachO] Change addrsig format + ensure its size is properly set.
Mon, Jun 13, 6:28 AM · Restricted Project, Restricted Project
int3 added inline comments to D127637: [MC][MachO] Change addrsig format + ensure its size is properly set.
Mon, Jun 13, 6:24 AM · Restricted Project, Restricted Project
int3 updated the summary of D127637: [MC][MachO] Change addrsig format + ensure its size is properly set.
Mon, Jun 13, 6:24 AM · Restricted Project, Restricted Project
int3 requested review of D127637: [MC][MachO] Change addrsig format + ensure its size is properly set.
Mon, Jun 13, 6:21 AM · Restricted Project, Restricted Project
int3 committed rGb422dac240f1: [lld-macho][reland] Support EH frames under arm64 (authored by int3).
[lld-macho][reland] Support EH frames under arm64
Mon, Jun 13, 4:48 AM · Restricted Project
int3 added a reverting change for rG10641a42e228: Revert "[lld-macho] Support EH frames under arm64": rGb422dac240f1: [lld-macho][reland] Support EH frames under arm64.
Mon, Jun 13, 4:48 AM · Restricted Project
int3 added a reverting change for rG942f4e3a7cc9: Revert "[lld-macho] Initial support for EH Frames": rGe183bf8e1599: [lld-macho][reland] Initial support for EH Frames.
Mon, Jun 13, 4:47 AM · Restricted Project
int3 committed rGe183bf8e1599: [lld-macho][reland] Initial support for EH Frames (authored by int3).
[lld-macho][reland] Initial support for EH Frames
Mon, Jun 13, 4:47 AM · Restricted Project
int3 committed rGe4a21e1644f2: [MC] Fix likely uninitialized memory bug (authored by int3).
[MC] Fix likely uninitialized memory bug
Mon, Jun 13, 4:42 AM · Restricted Project, Restricted Project
int3 closed D127630: [MC] Fix likely uninitialized memory bug.
Mon, Jun 13, 4:41 AM · Restricted Project, Restricted Project
int3 requested review of D127630: [MC] Fix likely uninitialized memory bug.
Mon, Jun 13, 4:05 AM · Restricted Project, Restricted Project
int3 added inline comments to D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible.
Mon, Jun 13, 3:50 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible.

Actually let me try it now

Mon, Jun 13, 3:42 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible.

Oh dear. Hmm does running the test with ASAN enabled hit any memory issues?

Mon, Jun 13, 3:42 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Sun, Jun 12

int3 committed rGd378268ead93: [lld-macho] Make `--icf=safe` work with LTO (authored by int3).
[lld-macho] Make `--icf=safe` work with LTO
Sun, Jun 12, 2:33 PM · Restricted Project
int3 closed D127600: [lld-macho] Make `--icf=safe` work with LTO.
Sun, Jun 12, 2:33 PM · Restricted Project, Restricted Project, Restricted Project
int3 added a reverting change for rGd941d597837d: Revert "[MC] Omit DWARF unwind info if compact unwind is present where eligible": rGd4bcb45db78d: [MC][re-land] Omit DWARF unwind info if compact unwind is present where eligible.
Sun, Jun 12, 2:24 PM · Restricted Project, Restricted Project, Restricted Project
int3 committed rGd4bcb45db78d: [MC][re-land] Omit DWARF unwind info if compact unwind is present where eligible (authored by int3).
[MC][re-land] Omit DWARF unwind info if compact unwind is present where eligible
Sun, Jun 12, 2:24 PM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible.

d'oh, I see it now. And of course the parent llvm/test/MC/MachO directory is gated to x86-only. Thanks!

Sun, Jun 12, 2:15 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible.

Buildbots gave me a bunch of errors of the form

Sun, Jun 12, 7:49 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
int3 added a reverting change for rGef501bf85d8c: [MC] Omit DWARF unwind info if compact unwind is present where eligible: rGd941d597837d: Revert "[MC] Omit DWARF unwind info if compact unwind is present where eligible".
Sun, Jun 12, 7:47 AM · Restricted Project, Restricted Project, Restricted Project
int3 committed rGd941d597837d: Revert "[MC] Omit DWARF unwind info if compact unwind is present where eligible" (authored by int3).
Revert "[MC] Omit DWARF unwind info if compact unwind is present where eligible"
Sun, Jun 12, 7:47 AM · Restricted Project, Restricted Project, Restricted Project
int3 added a reverting change for D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible: rGd941d597837d: Revert "[MC] Omit DWARF unwind info if compact unwind is present where eligible".
Sun, Jun 12, 7:47 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
int3 added a comment to rGef501bf85d8c: [MC] Omit DWARF unwind info if compact unwind is present where eligible.

Getting a lot of errors of the form

Sun, Jun 12, 7:38 AM · Restricted Project, Restricted Project, Restricted Project
int3 updated subscribers of D127600: [lld-macho] Make `--icf=safe` work with LTO.
Sun, Jun 12, 7:31 AM · Restricted Project, Restricted Project, Restricted Project
int3 requested review of D127600: [lld-macho] Make `--icf=safe` work with LTO.
Sun, Jun 12, 7:31 AM · Restricted Project, Restricted Project, Restricted Project
int3 committed rGef501bf85d8c: [MC] Omit DWARF unwind info if compact unwind is present where eligible (authored by int3).
[MC] Omit DWARF unwind info if compact unwind is present where eligible
Sun, Jun 12, 7:04 AM · Restricted Project, Restricted Project, Restricted Project
int3 closed D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible.
Sun, Jun 12, 7:04 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
int3 added inline comments to D127562: [lld-macho] Add support for exporting no symbols.
Sun, Jun 12, 6:59 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 9

int3 added a comment to D123435: [lld-macho] Initial support for EH Frames.

Ugh, sorry about that

Thu, Jun 9, 5:44 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 8

int3 committed rG977d62c33e33: [lld-macho] Support EH frames under arm64 (authored by int3).
[lld-macho] Support EH frames under arm64
Wed, Jun 8, 8:41 PM · Restricted Project
int3 committed rG826be330af9c: [lld-macho] Initial support for EH Frames (authored by int3).
[lld-macho] Initial support for EH Frames
Wed, Jun 8, 8:41 PM · Restricted Project
int3 closed D124561: [lld-macho] Support EH frames under arm64.
Wed, Jun 8, 8:41 PM · Restricted Project, Restricted Project, Restricted Project
int3 closed D123435: [lld-macho] Initial support for EH Frames.
Wed, Jun 8, 8:41 PM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D126800: Write output sections in parallel.

All observable behavior has to be deterministic IMHO. Else you can't cache the output.

Wed, Jun 8, 9:57 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 6

int3 added a comment to D126800: Write output sections in parallel.

@thakis does diag output *have* to be deterministic? The actual output binary should be deterministic, of course, but I don't see why the diag errors need to be

Mon, Jun 6, 12:59 PM · Restricted Project, Restricted Project, Restricted Project
int3 accepted D127110: [lld-macho] Demangle symbol names in duplicate-symbol error when -demangle is specified.

Nice!

Mon, Jun 6, 12:10 PM · Restricted Project, Restricted Project, Restricted Project

Wed, Jun 1

int3 added inline comments to D126800: Write output sections in parallel.
Wed, Jun 1, 12:12 PM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D126800: Write output sections in parallel.

Size of output binary + number of cores would also be good to know.

Wed, Jun 1, 12:11 PM · Restricted Project, Restricted Project, Restricted Project
int3 accepted D126800: Write output sections in parallel.

Would still love to have numbers on the workload size if possible.

Wed, Jun 1, 11:58 AM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D126800: Write output sections in parallel.

I think I commented before the edit :)

Wed, Jun 1, 11:56 AM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D126800: Write output sections in parallel.

Nice. Do you have some perf numbers + the size of the workload you're benchmarking against?

Wed, Jun 1, 11:56 AM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D126785: Cache file IDs of symbols in emitStabs for faster sorting.

Awesome!

Wed, Jun 1, 11:53 AM · Restricted Project, Restricted Project, Restricted Project
int3 accepted D126792: [lld-macho] Addressed additional post-commit comments from D126046.

Thank you!

Wed, Jun 1, 11:32 AM · Restricted Project, Restricted Project, Restricted Project

May 31 2022

int3 added a comment to D126046: [lld-macho] Support -non_global_symbols_strip_list, -non_global_symbols_no_strip_list, -x.

Sorry for the belated review. Took me a little longer than expected to get back in the swing of things :)

May 31 2022, 2:47 PM · Restricted Project, Restricted Project, Restricted Project

May 12 2022

int3 resigned from D124560: [llvm-objdump] Let --symbolize-operands symbolize basic block addresses based on the SHT_LLVM_BB_ADDR_MAP section..
May 12 2022, 8:19 PM · Restricted Project, Restricted Project

May 5 2022

int3 added inline comments to D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible.
May 5 2022, 7:14 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
int3 updated the diff for D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible.

make things work under cc1as too

May 5 2022, 7:11 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
int3 added inline comments to D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible.
May 5 2022, 12:57 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
int3 added inline comments to D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible.
May 5 2022, 12:24 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
int3 added inline comments to D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible.
May 5 2022, 11:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
int3 updated the diff for D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible.
May 5 2022, 11:11 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
int3 updated the diff for D122258: [MC] Omit DWARF unwind info if compact unwind is present where eligible.

update

May 5 2022, 11:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 4 2022

int3 committed rG19bb38b9c93c: [lld-macho][nfc] Set test min version to 11.0 (authored by int3).
[lld-macho][nfc] Set test min version to 11.0
May 4 2022, 3:02 PM · Restricted Project
int3 closed D124562: [lld-macho][nfc] Set test min version to 11.0.
May 4 2022, 3:02 PM · Restricted Project, Restricted Project, Restricted Project
int3 added a comment to D124562: [lld-macho][nfc] Set test min version to 11.0.

Ah I want this for my eh-frame.s test in D124561: [lld-macho] Support EH frames under arm64 in order that I can use %lld -arch arm64 rather than %no-arg-lld. (Since the macOS TBDs support both x86_64 and arm64, there's no need to specify a different -platform_version or -syslibroot.)

May 4 2022, 2:51 PM · Restricted Project, Restricted Project, Restricted Project
int3 accepted D124920: [llvm-otool] Make `llvm-otool -l` output compatible with otool for LC_BUILD_VERSION.

lgtm. Btw check your discord :p

May 4 2022, 12:09 PM · Restricted Project, Restricted Project