- User Since
- Jan 22 2020, 2:12 PM (73 w, 2 d)
Thanks! I see why you were checking for the GOT in tlv-dylib.s now...
The real culprit is https://github.com/llvm/llvm-project/commit/1d31fb8d122b1117cf20a9edc09812db8472e930, which I (unfortunately) thought simple enough to be landed without review. And I only landed it today, which explains why the breakage only happened today.
Thu, Jun 17
Sorry for the delay, was OOO earlier this week for a surgery.
Wed, Jun 16
Bump. Are you going to finish this? I've stumbled onto some programs that need it :)
remove use of ln; add test for force-loading multiple non-conflicting archives, and a test for non-force-loading multiple conflicting archives
test symlinks and hardlinks
Yeah as mentioned in my inline comment, my experiments show that ld64 treats symlinks as distinct inputs. But @thakis seems to think its otherwise, so we'll see...
Tue, Jun 15
Trying to produce one
We did have a test actually. I just I forgot we had %no_fatal_warnings_lld, which makes it not-too-ugly to test for warnings instead of errors... updating that test now
Mon, Jun 14
Sun, Jun 13
Sorry, I think that was spurious :( I can no longer replicate that performance win...
Fri, Jun 11
I ended up removing a lot of the asserts since sprinkling casts to ConcatInputSection seemed pretty awkward. I think you added most of these asserts, so lmk if you think we should put them back
And consider spreading out landing commits so that it's easier to see which one breaks things :)
But overall, it feels like things get a lot more complicated because we're not creating real InputSections for each literal in literal sections.
Neat! I think we still need a test for N_ALT_ENTRY, but I'm fine with having that in a follow-up (maybe just leave a TODO in icf.s).
It makes sense, yes. Always good to cross-check it with what ld64 is doing though.
Yes, I will do it, but wanted this out quickly.
Thu, Jun 10
Thanks for the fix!
Nice work :)
Wed, Jun 9
Realism is always good :)
Ah I see. Fair enough, there seems no getting around that. Having a pointer to the canonical InputSection instead of a symbol would solve the problem with N_ALT_ENTRY mentioned earlier, though