- User Since
- Jan 22 2020, 2:12 PM (45 w, 10 h)
Shuffling of which code? The changes to InputSection are mentioned in the summary, and the changes to InputFile are mentioned in the commit title
Tue, Dec 1
Thanks! I was actually thinking about this missing feature while implementing D91318: [lld-macho] Add archive name and file modtime to STABS output...
Mon, Nov 30
Sorry this took a while... got a bit sidetracked
Sun, Nov 29
@compnerd, want to have a look at this since you wrote the original test?
Please add lld-macho as the group reviewer in the future, that way more people can help review :)
thanks for the fix!
cc @gkm who implemented most of the option parsing
Tue, Nov 17
Sounds good to me :)
I used MD5 since that's what ld64 does. I hadn't looked at what lld-ELF/COFF were doing for this though, so thanks for the pointer! The only possible concern I can think of is the fact that the UUID version tags as specified in its RFC only provide for MD5 or SHA1 hashing, and ld64 seemed to think it important that we conform to this RFC. But I'm hard pressed to see how it would be an issue if we used a different hashing algorithm but tagged it as MD5. I'm inclined to just leave a TODO for now and come back later when we are tuning for performance
Wed, Nov 11
Tue, Nov 10
@smeenai Dwarf parsing appears to be on-demand, though I don't know if it's parsing just the subset of things we end up using. Specifically, compile_units() calls parseNormalUnits, which parses all units of type DW_SECT_INFO and DW_SECT_EXT_TYPES. I'll add a TODO to investigate more later.
Mon, Nov 9
pack into one test file
Nit: Commit title seems to indicate that we are adding support for paired relocs in this diff, but it seems like this diff is just paving the way for adding that support. Might be worth rephrasing... could also tag with [nfc] to make it explicit.
Thu, Nov 5
@tschuett we'll want to implement that eventually, but it's not a priority. Thanks for the pointer to that diff!
Nov 2 2020
Oct 28 2020
Oct 26 2020
Yeah I think llvm-dev would probably be a better place to find answers
Oct 25 2020
The failing test is unrelated to the changes made in this diff (also this diff hasn't been landed yet)
Oct 19 2020
Do we have any logic to emit an n_strx for an empty string?
Oct 17 2020
Note that unlike D89561, this diff doesn't need to make any alignment-related changes as LLD should already be handling that correctly. See the linkedit-contiguity.s test for more details.
Oct 15 2020
I'm not familiar with Darwin's history with STABS, but these symbols are still necessary for dsymutil / lldb to locate the DWARF debug info.
Oct 14 2020
don't match unnecessarily on exact addresses in test
Oct 13 2020
Oct 12 2020
don't run test on windows; fixing the paths there is more work than I'd like to do for now