Page MenuHomePhabricator

int3 (Jez Ng)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 22 2020, 2:12 PM (45 w, 10 h)

Recent Activity

Yesterday

int3 updated the summary of D92539: [lld-macho] Support parsing of bitcode within archives.
Wed, Dec 2, 9:42 PM · Restricted Project
int3 updated the diff for D92539: [lld-macho] Support parsing of bitcode within archives.

update

Wed, Dec 2, 9:40 PM · Restricted Project
int3 added inline comments to D92360: [lld/mac] Fix issues around thin archives.
Wed, Dec 2, 9:04 PM · Restricted Project
int3 requested review of D92539: [lld-macho] Support parsing of bitcode within archives.
Wed, Dec 2, 8:58 PM · Restricted Project
int3 updated the diff for D92537: [lld-macho] Implement -object_path_lto.

error handling

Wed, Dec 2, 8:58 PM · Restricted Project
int3 requested review of D92537: [lld-macho] Implement -object_path_lto.
Wed, Dec 2, 8:47 PM · Restricted Project
int3 updated the diff for D92453: [lld-macho][nfc] Move some methods from InputFile to ObjFile.

update

Wed, Dec 2, 6:48 PM · Restricted Project
int3 updated the summary of D92453: [lld-macho][nfc] Move some methods from InputFile to ObjFile.
Wed, Dec 2, 6:48 PM · Restricted Project
int3 added a comment to D92453: [lld-macho][nfc] Move some methods from InputFile to ObjFile.

Shuffling of which code? The changes to InputSection are mentioned in the summary, and the changes to InputFile are mentioned in the commit title

Wed, Dec 2, 8:53 AM · Restricted Project

Tue, Dec 1

int3 accepted D92456: [mac/lld] Make --reproduce work with thin archives.

lgtm

Tue, Dec 1, 8:42 PM · Restricted Project
int3 requested review of D92455: [lld-macho] Error out if we encounter a HelpHidden flag in tests.
Tue, Dec 1, 8:31 PM · Restricted Project
int3 requested review of D92453: [lld-macho][nfc] Move some methods from InputFile to ObjFile.
Tue, Dec 1, 8:15 PM · Restricted Project
int3 accepted D92437: [mac/lld] Include archive name in diagnostics.

sgtm

Tue, Dec 1, 7:56 PM · Restricted Project, Restricted Project
int3 added inline comments to D89257: [lld-macho] Emit STABS symbols for debugging, and drop debug sections.
Tue, Dec 1, 7:32 PM · Restricted Project
int3 added a comment to D92437: [mac/lld] Include archive name in diagnostics.

Thanks! I was actually thinking about this missing feature while implementing D91318: [lld-macho] Add archive name and file modtime to STABS output...

Tue, Dec 1, 7:29 PM · Restricted Project, Restricted Project
int3 committed rGc7dbaec396ef: [lld-macho] Add isCodeSection() (authored by int3).
[lld-macho] Add isCodeSection()
Tue, Dec 1, 3:06 PM
int3 committed rG78f6498cdcdb: [lld-macho] Flesh out STABS implementation (authored by int3).
[lld-macho] Flesh out STABS implementation
Tue, Dec 1, 3:06 PM
int3 committed rGb768d57b3687: [lld-macho] Add archive name and file modtime to STABS output (authored by int3).
[lld-macho] Add archive name and file modtime to STABS output
Tue, Dec 1, 3:06 PM
int3 committed rG51629abce0e2: [lld-macho] Emit local symbols in symtab; record metadata in LC_DYSYMTAB (authored by int3).
[lld-macho] Emit local symbols in symtab; record metadata in LC_DYSYMTAB
Tue, Dec 1, 3:06 PM
int3 committed rGd0c4be42e35d: [lld-macho] Emit empty string as first entry of string table (authored by int3).
[lld-macho] Emit empty string as first entry of string table
Tue, Dec 1, 3:06 PM
int3 closed D92430: [lld-macho] Add isCodeSection().
Tue, Dec 1, 3:05 PM · Restricted Project
int3 closed D92366: [lld-macho] Flesh out STABS implementation.
Tue, Dec 1, 3:05 PM · Restricted Project
int3 committed rG3fcb0eeb152b: [lld-macho] Emit STABS symbols for debugging, and drop debug sections (authored by int3).
[lld-macho] Emit STABS symbols for debugging, and drop debug sections
Tue, Dec 1, 3:05 PM
int3 closed D91318: [lld-macho] Add archive name and file modtime to STABS output.
Tue, Dec 1, 3:05 PM · Restricted Project
int3 closed D89639: [lld-macho] Emit empty string as first entry of string table.
Tue, Dec 1, 3:05 PM · Restricted Project
int3 closed D89285: [lld-macho] Emit local symbols in symtab; record metadata in LC_DYSYMTAB.
Tue, Dec 1, 3:05 PM · Restricted Project
int3 closed D89257: [lld-macho] Emit STABS symbols for debugging, and drop debug sections.
Tue, Dec 1, 3:05 PM · Restricted Project
int3 added inline comments to D92430: [lld-macho] Add isCodeSection().
Tue, Dec 1, 2:58 PM · Restricted Project
int3 added inline comments to D92430: [lld-macho] Add isCodeSection().
Tue, Dec 1, 2:41 PM · Restricted Project
int3 committed rG6b3eecd22ab2: [lld-macho] Extend PIE option handling (authored by int3).
[lld-macho] Extend PIE option handling
Tue, Dec 1, 2:36 PM
int3 closed D92362: [lld-macho] Extend PIE option handling.
Tue, Dec 1, 2:36 PM · Restricted Project
int3 requested review of D89257: [lld-macho] Emit STABS symbols for debugging, and drop debug sections.
Tue, Dec 1, 2:22 PM · Restricted Project
int3 added inline comments to D89257: [lld-macho] Emit STABS symbols for debugging, and drop debug sections.
Tue, Dec 1, 2:16 PM · Restricted Project
int3 updated the diff for D92366: [lld-macho] Flesh out STABS implementation.

address comment

Tue, Dec 1, 2:09 PM · Restricted Project
int3 added inline comments to D92366: [lld-macho] Flesh out STABS implementation.
Tue, Dec 1, 2:09 PM · Restricted Project
int3 requested review of D92430: [lld-macho] Add isCodeSection().
Tue, Dec 1, 2:08 PM · Restricted Project
int3 accepted D92360: [lld/mac] Fix issues around thin archives.

lgtm

Tue, Dec 1, 2:05 PM · Restricted Project

Mon, Nov 30

int3 added a comment to D89257: [lld-macho] Emit STABS symbols for debugging, and drop debug sections.

Sorry this took a while... got a bit sidetracked

Mon, Nov 30, 10:35 PM · Restricted Project
int3 updated the diff for D89257: [lld-macho] Emit STABS symbols for debugging, and drop debug sections.

update

Mon, Nov 30, 10:35 PM · Restricted Project
int3 requested review of D92366: [lld-macho] Flesh out STABS implementation.
Mon, Nov 30, 10:30 PM · Restricted Project
int3 added inline comments to D92360: [lld/mac] Fix issues around thin archives.
Mon, Nov 30, 9:17 PM · Restricted Project
int3 added inline comments to D87199: [lld-macho] Implement support for PIC.
Mon, Nov 30, 9:13 PM · Restricted Project
int3 requested review of D92362: [lld-macho] Extend PIE option handling.
Mon, Nov 30, 9:12 PM · Restricted Project
int3 added inline comments to D92360: [lld/mac] Fix issues around thin archives.
Mon, Nov 30, 7:11 PM · Restricted Project
int3 accepted D91894: [lld-macho] Implement -fatal_warnings.
Mon, Nov 30, 6:24 AM · Restricted Project

Sun, Nov 29

int3 accepted D92274: [lld/mac] Add --reproduce option.

lgtm

Sun, Nov 29, 9:41 PM · Restricted Project
int3 added a reviewer for D91891: [lld-macho] Don't warn on non-existent system libraries: compnerd.

@compnerd, want to have a look at this since you wrote the original test?

Sun, Nov 29, 9:18 PM · Restricted Project
int3 accepted D92149: [mac/lld] Add support for response files.

lgtnm

Sun, Nov 29, 9:06 PM · Restricted Project
int3 added a reviewer for D92149: [mac/lld] Add support for response files: Restricted Project.
Sun, Nov 29, 9:06 PM · Restricted Project
int3 added a comment to D91971: [lld/mac] Don't warn on -bundle and -execute flags.

Please add lld-macho as the group reviewer in the future, that way more people can help review :)

Sun, Nov 29, 9:01 PM · Restricted Project
int3 added a reviewer for D91971: [lld/mac] Don't warn on -bundle and -execute flags: Restricted Project.
Sun, Nov 29, 9:00 PM · Restricted Project
int3 accepted D91971: [lld/mac] Don't warn on -bundle and -execute flags.

thanks for the fix!

Sun, Nov 29, 9:00 PM · Restricted Project
int3 added a reviewer for D91894: [lld-macho] Implement -fatal_warnings: Restricted Project.

cc @gkm who implemented most of the option parsing

Sun, Nov 29, 8:57 PM · Restricted Project

Tue, Nov 17

int3 added a comment to D91640: lld: Add --color-diagnostic to MachO port, harmonize others.

Sounds good to me :)

Tue, Nov 17, 9:59 AM · Restricted Project
int3 accepted D91640: lld: Add --color-diagnostic to MachO port, harmonize others.

lgtm

Tue, Nov 17, 9:46 AM · Restricted Project
int3 added a comment to D89418: [lld-macho] Implement LC_UUID.

I used MD5 since that's what ld64 does. I hadn't looked at what lld-ELF/COFF were doing for this though, so thanks for the pointer! The only possible concern I can think of is the fact that the UUID version tags as specified in its RFC only provide for MD5 or SHA1 hashing, and ld64 seemed to think it important that we conform to this RFC. But I'm hard pressed to see how it would be an issue if we used a different hashing algorithm but tagged it as MD5. I'm inclined to just leave a TODO for now and come back later when we are tuning for performance

Tue, Nov 17, 6:27 AM · Restricted Project

Wed, Nov 11

int3 updated the diff for D91318: [lld-macho] Add archive name and file modtime to STABS output.

update

Wed, Nov 11, 8:19 PM · Restricted Project
int3 added inline comments to D89257: [lld-macho] Emit STABS symbols for debugging, and drop debug sections.
Wed, Nov 11, 8:14 PM · Restricted Project
int3 requested review of D91318: [lld-macho] Add archive name and file modtime to STABS output.
Wed, Nov 11, 8:14 PM · Restricted Project
int3 added inline comments to D89285: [lld-macho] Emit local symbols in symtab; record metadata in LC_DYSYMTAB.
Wed, Nov 11, 4:46 PM · Restricted Project

Tue, Nov 10

int3 added a reviewer for D89285: [lld-macho] Emit local symbols in symtab; record metadata in LC_DYSYMTAB: clayborg.
Tue, Nov 10, 5:03 PM · Restricted Project
int3 added a comment to D89257: [lld-macho] Emit STABS symbols for debugging, and drop debug sections.

@smeenai Dwarf parsing appears to be on-demand, though I don't know if it's parsing just the subset of things we end up using. Specifically, compile_units() calls parseNormalUnits, which parses all units of type DW_SECT_INFO and DW_SECT_EXT_TYPES. I'll add a TODO to investigate more later.

Tue, Nov 10, 4:49 PM · Restricted Project
int3 committed rG21f831134c90: [lld-macho] Add very basic support for LTO (authored by int3).
[lld-macho] Add very basic support for LTO
Tue, Nov 10, 12:20 PM
int3 closed D90663: [lld-macho] Add very basic support for LTO.
Tue, Nov 10, 12:20 PM · Restricted Project
int3 committed rG6cf244327b0d: [lld-macho][easy] Fix segment max protection (authored by int3).
[lld-macho][easy] Fix segment max protection
Tue, Nov 10, 12:20 PM
int3 closed D89420: [lld-macho][easy] Fix segment max protection.
Tue, Nov 10, 12:20 PM · Restricted Project
int3 committed rGb86908171ea8: [lld-macho] Implement LC_UUID (authored by int3).
[lld-macho] Implement LC_UUID
Tue, Nov 10, 12:20 PM
int3 closed D89418: [lld-macho] Implement LC_UUID.
Tue, Nov 10, 12:20 PM · Restricted Project
int3 committed rG2e8e1bdb8939: [lld-macho] Support linking against stub dylibs (authored by int3).
[lld-macho] Support linking against stub dylibs
Tue, Nov 10, 12:20 PM
int3 closed D89012: [lld-macho] Support linking against stub dylibs.
Tue, Nov 10, 12:19 PM · Restricted Project
int3 updated the diff for D90663: [lld-macho] Add very basic support for LTO.

fix use-after-free

Tue, Nov 10, 12:18 PM · Restricted Project

Mon, Nov 9

int3 added inline comments to D90663: [lld-macho] Add very basic support for LTO.
Mon, Nov 9, 9:39 PM · Restricted Project
int3 updated the diff for D90663: [lld-macho] Add very basic support for LTO.

fix

Mon, Nov 9, 9:38 PM · Restricted Project
int3 updated the diff for D90663: [lld-macho] Add very basic support for LTO.

pack into one test file

Mon, Nov 9, 9:36 PM · Restricted Project
int3 added inline comments to D90663: [lld-macho] Add very basic support for LTO.
Mon, Nov 9, 9:26 PM · Restricted Project
int3 updated the diff for D90663: [lld-macho] Add very basic support for LTO.

address comments

Mon, Nov 9, 9:25 PM · Restricted Project
int3 added inline comments to D89012: [lld-macho] Support linking against stub dylibs.
Mon, Nov 9, 9:05 PM · Restricted Project
int3 added inline comments to D90663: [lld-macho] Add very basic support for LTO.
Mon, Nov 9, 9:55 AM · Restricted Project
int3 added inline comments to D88629: [lld-macho] Add ARM64 target arch.
Mon, Nov 9, 9:47 AM · Restricted Project
int3 added a comment to D90614: [lld-macho] Handle paired relocs.

Nit: Commit title seems to indicate that we are adding support for paired relocs in this diff, but it seems like this diff is just paving the way for adding that support. Might be worth rephrasing... could also tag with [nfc] to make it explicit.

Mon, Nov 9, 9:43 AM · Restricted Project

Thu, Nov 5

int3 updated the diff for D90663: [lld-macho] Add very basic support for LTO.

address comments

Thu, Nov 5, 5:08 PM · Restricted Project
int3 added a comment to D90663: [lld-macho] Add very basic support for LTO.

@tschuett we'll want to implement that eventually, but it's not a priority. Thanks for the pointer to that diff!

Thu, Nov 5, 5:08 PM · Restricted Project

Nov 2 2020

int3 requested review of D90663: [lld-macho] Add very basic support for LTO.
Nov 2 2020, 7:00 PM · Restricted Project

Oct 28 2020

int3 added inline comments to D89420: [lld-macho][easy] Fix segment max protection.
Oct 28 2020, 2:23 PM · Restricted Project

Oct 26 2020

int3 added a comment to D89418: [lld-macho] Implement LC_UUID.

Yeah I think llvm-dev would probably be a better place to find answers

Oct 26 2020, 3:02 PM · Restricted Project

Oct 25 2020

int3 added a comment to D89418: [lld-macho] Implement LC_UUID.

The failing test is unrelated to the changes made in this diff (also this diff hasn't been landed yet)

Oct 25 2020, 8:53 AM · Restricted Project

Oct 19 2020

int3 added a comment to D89639: [lld-macho] Emit empty string as first entry of string table.

Do we have any logic to emit an n_strx for an empty string?

Oct 19 2020, 7:04 PM · Restricted Project

Oct 17 2020

int3 added a comment to D89639: [lld-macho] Emit empty string as first entry of string table.

Note that unlike D89561, this diff doesn't need to make any alignment-related changes as LLD should already be handling that correctly. See the linkedit-contiguity.s test for more details.

Oct 17 2020, 8:48 PM · Restricted Project
int3 requested review of D89639: [lld-macho] Emit empty string as first entry of string table.
Oct 17 2020, 8:46 PM · Restricted Project

Oct 15 2020

int3 added inline comments to D89420: [lld-macho][easy] Fix segment max protection.
Oct 15 2020, 9:13 AM · Restricted Project
int3 added inline comments to D89420: [lld-macho][easy] Fix segment max protection.
Oct 15 2020, 9:11 AM · Restricted Project
int3 added a comment to D89285: [lld-macho] Emit local symbols in symtab; record metadata in LC_DYSYMTAB.

I'm not familiar with Darwin's history with STABS, but these symbols are still necessary for dsymutil / lldb to locate the DWARF debug info.

Oct 15 2020, 9:00 AM · Restricted Project

Oct 14 2020

int3 requested review of D89420: [lld-macho][easy] Fix segment max protection.
Oct 14 2020, 12:48 PM · Restricted Project
int3 requested review of D89418: [lld-macho] Implement LC_UUID.
Oct 14 2020, 12:24 PM · Restricted Project
int3 updated the diff for D89285: [lld-macho] Emit local symbols in symtab; record metadata in LC_DYSYMTAB.

don't match unnecessarily on exact addresses in test

Oct 14 2020, 11:17 AM · Restricted Project
int3 updated the diff for D89285: [lld-macho] Emit local symbols in symtab; record metadata in LC_DYSYMTAB.

test dysymtab

Oct 14 2020, 9:30 AM · Restricted Project

Oct 13 2020

int3 updated the summary of D89012: [lld-macho] Support linking against stub dylibs.
Oct 13 2020, 10:28 PM · Restricted Project

Oct 12 2020

int3 updated the diff for D89257: [lld-macho] Emit STABS symbols for debugging, and drop debug sections.

don't run test on windows; fixing the paths there is more work than I'd like to do for now

Oct 12 2020, 7:08 PM · Restricted Project
int3 committed rG84cc39c329f8: [llvm-readobj] Don't print out section names for STABS symbols (authored by int3).
[llvm-readobj] Don't print out section names for STABS symbols
Oct 12 2020, 6:56 PM
int3 closed D88468: [llvm-readobj] Don't print out section names for STABS symbols.
Oct 12 2020, 6:56 PM · Restricted Project