This is an archive of the discontinued LLVM Phabricator instance.

Differential D114408

Fold a lot of ffixed_x if judgments
AbandonedPublic

Authored by achieveartificialintelligence on Nov 22 2021, 6:55 PM.

Details

Reviewers
simoncook
asb
luismarques
jrtc27
lenary

Diff Detail

Event Timeline

achieveartificialintelligence created this revision.Nov 22 2021, 6:55 PM
Herald added subscribers: frasercrmck, apazos, sameer.abuasal and 15 others. · View Herald TranscriptNov 22 2021, 6:55 PM
achieveartificialintelligence requested review of this revision.Nov 22 2021, 6:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 22 2021, 6:55 PM
Herald added subscribers: cfe-commits, MaskRay. · View Herald Transcript
achieveartificialintelligence updated this revision to Diff 389091.Nov 22 2021, 8:58 PM

Fix

Harbormaster completed remote builds in B135550: Diff 389091.Nov 23 2021, 12:23 AM
lenary resigned from this revision.Nov 23 2021, 2:02 AM
jrtc27 requested changes to this revision.Nov 23 2021, 2:23 AM

This has clearly not been tested whatsoever, it’s totally broken, the preprocessor does not work like that

This revision now requires changes to proceed.Nov 23 2021, 2:23 AM
achieveartificialintelligence abandoned this revision.Nov 29 2021, 7:51 PM
In D114408#3148311, @jrtc27 wrote:

This has clearly not been tested whatsoever, it’s totally broken, the preprocessor does not work like that

Thanks!

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
Arch/
68 lines

Diff 389091

clang/lib/Driver/ToolChains/Arch/RISCV.cpp

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines if (!getArchFeatures(D, MArch, Features, Args))
return; return;
// If users give march and mcpu, get std extension feature from MArch // If users give march and mcpu, get std extension feature from MArch
// and other features (ex. mirco architecture feature) from mcpu // and other features (ex. mirco architecture feature) from mcpu
if (Arg *A = Args.getLastArg(options::OPT_mcpu_EQ)) if (Arg *A = Args.getLastArg(options::OPT_mcpu_EQ))
getRISCFeaturesFromMcpu(D, Triple, Args, A, A->getValue(), Features); getRISCFeaturesFromMcpu(D, Triple, Args, A, A->getValue(), Features);
// Handle features corresponding to "-ffixed-X" options // Handle features corresponding to "-ffixed-X" options
if (Args.hasArg(options::OPT_ffixed_x1)) #define HAS_FFIXED_X(I) \
Features.push_back("+reserve-x1"); (if (Args.hasArg(options::OPT_ffixed_x(I))) \
if (Args.hasArg(options::OPT_ffixed_x2)) Features.push_back("+reserve-x(I)"))
Features.push_back("+reserve-x2");
if (Args.hasArg(options::OPT_ffixed_x3)) for (int I = 1; I <= 31; ++I)
Features.push_back("+reserve-x3"); HAS_FFIXED_X(I);
if (Args.hasArg(options::OPT_ffixed_x4))
Features.push_back("+reserve-x4");
if (Args.hasArg(options::OPT_ffixed_x5))
Features.push_back("+reserve-x5");
if (Args.hasArg(options::OPT_ffixed_x6))
Features.push_back("+reserve-x6");
if (Args.hasArg(options::OPT_ffixed_x7))
Features.push_back("+reserve-x7");
if (Args.hasArg(options::OPT_ffixed_x8))
Features.push_back("+reserve-x8");
if (Args.hasArg(options::OPT_ffixed_x9))
Features.push_back("+reserve-x9");
if (Args.hasArg(options::OPT_ffixed_x10))
Features.push_back("+reserve-x10");
if (Args.hasArg(options::OPT_ffixed_x11))
Features.push_back("+reserve-x11");
if (Args.hasArg(options::OPT_ffixed_x12))
Features.push_back("+reserve-x12");
if (Args.hasArg(options::OPT_ffixed_x13))
Features.push_back("+reserve-x13");
if (Args.hasArg(options::OPT_ffixed_x14))
Features.push_back("+reserve-x14");
if (Args.hasArg(options::OPT_ffixed_x15))
Features.push_back("+reserve-x15");
if (Args.hasArg(options::OPT_ffixed_x16))
Features.push_back("+reserve-x16");
if (Args.hasArg(options::OPT_ffixed_x17))
Features.push_back("+reserve-x17");
if (Args.hasArg(options::OPT_ffixed_x18))
Features.push_back("+reserve-x18");
if (Args.hasArg(options::OPT_ffixed_x19))
Features.push_back("+reserve-x19");
if (Args.hasArg(options::OPT_ffixed_x20))
Features.push_back("+reserve-x20");
if (Args.hasArg(options::OPT_ffixed_x21))
Features.push_back("+reserve-x21");
if (Args.hasArg(options::OPT_ffixed_x22))
Features.push_back("+reserve-x22");
if (Args.hasArg(options::OPT_ffixed_x23))
Features.push_back("+reserve-x23");
if (Args.hasArg(options::OPT_ffixed_x24))
Features.push_back("+reserve-x24");
if (Args.hasArg(options::OPT_ffixed_x25))
Features.push_back("+reserve-x25");
if (Args.hasArg(options::OPT_ffixed_x26))
Features.push_back("+reserve-x26");
if (Args.hasArg(options::OPT_ffixed_x27))
Features.push_back("+reserve-x27");
if (Args.hasArg(options::OPT_ffixed_x28))
Features.push_back("+reserve-x28");
if (Args.hasArg(options::OPT_ffixed_x29))
Features.push_back("+reserve-x29");
if (Args.hasArg(options::OPT_ffixed_x30))
Features.push_back("+reserve-x30");
if (Args.hasArg(options::OPT_ffixed_x31))
Features.push_back("+reserve-x31");
// -mrelax is default, unless -mno-relax is specified. // -mrelax is default, unless -mno-relax is specified.
if (Args.hasFlag(options::OPT_mrelax, options::OPT_mno_relax, true)) if (Args.hasFlag(options::OPT_mrelax, options::OPT_mno_relax, true))
Features.push_back("+relax"); Features.push_back("+relax");
else else
Features.push_back("-relax"); Features.push_back("-relax");
// GCC Compatibility: -mno-save-restore is default, unless -msave-restore is // GCC Compatibility: -mno-save-restore is default, unless -msave-restore is
▲ Show 20 Lines • Show All 168 Lines • Show Last 20 Lines