This adds support for SVE structured loads/stores to the relevant target
hooks, such that we can support these instructions in the InterleavedAccess
pass.
Depends on D112078
Paths
| Differential D112303
[AArch64][SVE] Generate SVE >2 element structured load/stores from fixed types ClosedPublic Authored by bsmith on Oct 22 2021, 4:08 AM.
Details Summary This adds support for SVE structured loads/stores to the relevant target Depends on D112078
Diff Detail
Event TimelineComment Actions Looks good to me. Optional nits.
This revision is now accepted and ready to land.Oct 27 2021, 8:36 AM This revision was landed with ongoing or failed builds.Oct 29 2021, 2:53 AM Closed by commit rG13faa5f44015: [AArch64][SVE] Generate SVE >1 element structured load/stores from fixed types (authored by bsmith). · Explain Why This revision was automatically updated to reflect the committed changes. Comment Actions This is causing build failures on our bot: https://green.lab.llvm.org/green/job/clang-stage1-RA/25089/console llvm-project/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:12017:10: error: no matching function for call to 'max' return std::max(1UL, (DL.getTypeSizeInBits(VecTy) + 127) / VecSize); ^~~~~~~~ Can you take a look please? Comment Actions Win: http://45.33.8.238/win/47923/step_4.txt Please take a look and revert for now if it takes a while to fix.
Revision Contents
Diff 383285 llvm/lib/Target/AArch64/AArch64ISelLowering.h
llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
llvm/test/Transforms/InterleavedAccess/AArch64/sve-interleaved-accesses.ll
|
nit. NEON? :)
trivial. While we're here I keep reading it as 'load integers', could we rename it to '...LoadIntrs'? Please reject this comment of mine unless you happen to agree.