This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Update to vlm.v and vsm.v according to v1.0-rc1.
ClosedPublic

Authored by HsiangKai on Jul 15 2021, 1:26 AM.

Diff Detail

Event Timeline

HsiangKai created this revision.Jul 15 2021, 1:26 AM
HsiangKai requested review of this revision.Jul 15 2021, 1:26 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 15 2021, 1:26 AM

I'm confused because the PDF at https://github.com/riscv/riscv-v-spec/releases/tag/v1.0-rc1 doesn't seem to describe vcpop.m.

I can see this has changed in the ToT https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc#changes-from-v1-0-rc1

Perhaps this will be part of a future 1.0-rc2?

llvm/test/CodeGen/RISCV/rvv/vse1-rv64.ll
13

Is this expected?

I'm confused because the PDF at https://github.com/riscv/riscv-v-spec/releases/tag/v1.0-rc1 doesn't seem to describe vcpop.m.

I can see this has changed in the ToT https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc#changes-from-v1-0-rc1

Perhaps this will be part of a future 1.0-rc2?

You are right. I will revert it. Thanks.

HsiangKai updated this revision to Diff 358918.Jul 15 2021, 4:14 AM
  • Remove vcpop.m.
  • Correct test cases.
HsiangKai retitled this revision from [RISCV] Update to vcpop.m, vlm.v and vsm.v according to v1.0-rc1. to [RISCV] Update to vlm.v and vsm.v according to v1.0-rc1..Jul 15 2021, 4:14 AM
HsiangKai edited the summary of this revision. (Show Details)
craig.topper added inline comments.Jul 15 2021, 9:03 AM
clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vse.c
1182

Was the call supposed to be renamed or just the test name?

clang/test/CodeGen/RISCV/rvv-intrinsics/vle.c
1258

Did you mean to leave the old test name? I don't see the same in the vse.c file

HsiangKai updated this revision to Diff 359175.Jul 15 2021, 5:33 PM

Update test cases.

This revision is now accepted and ready to land.Oct 4 2021, 8:08 PM
frasercrmck accepted this revision.Oct 5 2021, 1:11 AM

LGTM in principle but aliases.s is apparently failing with something that looks relevant.

This revision was landed with ongoing or failed builds.Oct 5 2021, 6:51 AM
This revision was automatically updated to reflect the committed changes.