This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][NFC] Add a single space after comma for VType
ClosedPublic

Authored by Jim on Jun 7 2021, 12:01 AM.

Details

Summary

In most of cases, it has a single space after comma in assembly operands.

Diff Detail

Event Timeline

Jim created this revision.Jun 7 2021, 12:01 AM
Jim requested review of this revision.Jun 7 2021, 12:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2021, 12:01 AM
craig.topper added a subscriber: craig.topper.

The examples in the V spec show no spaces. Are you going to update that too? What about binutils?

The examples in the V spec show no spaces. Are you going to update that too? What about binutils?

I refer to https://github.com/riscv/riscv-binutils-gdb/blob/c5ef83e53e2528c0737bb0f40e6b77dc8b82eac8/gas/testsuite/gas/riscv/vector-insns.s
It looks that binutils can accept two formats with or without spaces.

I pull a request to update riscv-v-spec.
https://github.com/riscv/riscv-v-spec/pull/693

This revision is now accepted and ready to land.Jun 7 2021, 10:48 AM
Jim updated this revision to Diff 350768.Jun 8 2021, 8:11 PM

Rebase

Jim added a comment.Jun 8 2021, 8:13 PM

The examples in the V spec show no spaces. Are you going to update that too? What about binutils?

I refer to https://github.com/riscv/riscv-binutils-gdb/blob/c5ef83e53e2528c0737bb0f40e6b77dc8b82eac8/gas/testsuite/gas/riscv/vector-insns.s
It looks that binutils can accept two formats with or without spaces.

I pull a request to update riscv-v-spec.
https://github.com/riscv/riscv-v-spec/pull/693

https://github.com/riscv/riscv-v-spec/pull/693 has been merged.

This revision was landed with ongoing or failed builds.Jun 8 2021, 8:17 PM
This revision was automatically updated to reflect the committed changes.

Note that I pushed rG292f4197249b to fix the failing tests introduced by this patch. Please check the test results before merging in the future, e.g. https://reviews.llvm.org/B107914 was showing this issue.

Jim added a comment.Jun 9 2021, 2:03 AM

Thanks, I missed to check MC tests.