Page MenuHomePhabricator

[AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros
ClosedPublic

Authored by Jake-Egan on Jun 4 2021, 11:20 AM.

Details

Summary


Transfer predefined macros, __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__, from the AIX XL C/C++ compilers.

__STDC_NO_ATOMICS__ is needed because Open XL for AIX does not have C library atomics.

__STDC_NO_THREADS__ should be set until the OS implementation is complete because of conformance issues for AIX libc.

This patch replaces https://reviews.llvm.org/D103587.

Diff Detail

Event Timeline

Jake-Egan created this revision.Jun 4 2021, 11:20 AM
Jake-Egan requested review of this revision.Jun 4 2021, 11:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 4 2021, 11:20 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Jake-Egan retitled this revision from Add STDC macros to [AIX] Transfer __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros.Jun 4 2021, 11:36 AM
Jake-Egan edited the summary of this revision. (Show Details)
Jake-Egan retitled this revision from [AIX] Transfer __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros to [AIX] Define __STDC_NO_ATOMICS__ and __STDC_NO_THREADS__ predefined macros.Jun 4 2021, 11:56 AM
Jake-Egan edited the summary of this revision. (Show Details)Jun 4 2021, 12:03 PM
cebowleratibm requested changes to this revision.Jun 7 2021, 12:36 PM

Would like you to prune the new tests, then I think this will be ready to land.

clang/test/Preprocessor/init-ppc.c
726

Suggest pruning some of these. I don't think it's necessary to test every visible -std level.

This revision now requires changes to proceed.Jun 7 2021, 12:36 PM
Jake-Egan updated this revision to Diff 350392.Jun 7 2021, 12:49 PM
Jake-Egan edited the summary of this revision. (Show Details)

Prune positive tests.

Jake-Egan updated this revision to Diff 350400.Jun 7 2021, 1:11 PM

Add C17 test.

Jake-Egan updated this revision to Diff 350406.Jun 7 2021, 1:38 PM

Fix formatting.

This revision is now accepted and ready to land.Jun 7 2021, 6:52 PM
lkail added a subscriber: lkail.Fri, Jul 9, 12:04 AM