Page MenuHomePhabricator

cebowleratibm (Chris Bowler)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 17 2019, 7:18 AM (31 w, 4 h)

Recent Activity

Fri, Jan 10

cebowleratibm updated the diff for D71013: [AIX] Allow vararg calls when all arguments reside in registers..

Already approved but I've addressed the nits and posted the final commit here because I'll need someone to commit it for me.

Fri, Jan 10, 7:55 AM · Restricted Project

Thu, Jan 9

cebowleratibm updated the diff for D71013: [AIX] Allow vararg calls when all arguments reside in registers..

Rewrote comments in aix-cc-altivec.ll test, fixed the vector diagnostic bug Zarko pointed out and addressed small nits.

Thu, Jan 9, 4:33 AM · Restricted Project
cebowleratibm added inline comments to D71013: [AIX] Allow vararg calls when all arguments reside in registers..
Thu, Jan 9, 4:18 AM · Restricted Project

Wed, Jan 8

cebowleratibm added inline comments to D71013: [AIX] Allow vararg calls when all arguments reside in registers..
Wed, Jan 8, 5:12 AM · Restricted Project

Tue, Jan 7

cebowleratibm updated the diff for D71013: [AIX] Allow vararg calls when all arguments reside in registers..

I've decided to use custom regs for all gpr inits for float varargs. I discovered that f64 passing in 64-bit gpr was missing a required bitcast to int to handle the initialization. The new logic ensures the bitcast occurs for any custom handling. Custom handling is only expected for gpr inits of float args.

Tue, Jan 7, 7:52 AM · Restricted Project

Dec 17 2019

cebowleratibm planned changes to D71013: [AIX] Allow vararg calls when all arguments reside in registers..

Recent problems have come up generating the GPR initializations for floating point args, which may require some rework. Hold off on review until revision is posted.

Dec 17 2019, 6:49 AM · Restricted Project
cebowleratibm added inline comments to D71013: [AIX] Allow vararg calls when all arguments reside in registers..
Dec 17 2019, 4:35 AM · Restricted Project

Dec 16 2019

cebowleratibm added inline comments to D71013: [AIX] Allow vararg calls when all arguments reside in registers..
Dec 16 2019, 5:35 AM · Restricted Project

Dec 13 2019

cebowleratibm added inline comments to D71013: [AIX] Allow vararg calls when all arguments reside in registers..
Dec 13 2019, 9:00 PM · Restricted Project
cebowleratibm added inline comments to D71013: [AIX] Allow vararg calls when all arguments reside in registers..
Dec 13 2019, 7:38 AM · Restricted Project

Dec 12 2019

cebowleratibm added a comment to D71013: [AIX] Allow vararg calls when all arguments reside in registers..

Minor tweaks and test upates to come. I'll add an assembly test to validate that we don't need to store to memory to initiailze the two GPRs for f64 in PPC32 mode on newer hardware.

Dec 12 2019, 9:00 AM · Restricted Project

Dec 6 2019

cebowleratibm updated the diff for D71013: [AIX] Allow vararg calls when all arguments reside in registers..

Clang formatted the change and updated the float reg to use LocVT.

Dec 6 2019, 7:34 AM · Restricted Project

Dec 5 2019

cebowleratibm added inline comments to D71013: [AIX] Allow vararg calls when all arguments reside in registers..
Dec 5 2019, 4:51 AM · Restricted Project

Dec 4 2019

cebowleratibm created D71013: [AIX] Allow vararg calls when all arguments reside in registers..
Dec 4 2019, 6:34 AM · Restricted Project

Nov 18 2019

cebowleratibm added inline comments to D69578: [AIX] Add support for lowering int, float and double formal arguments..
Nov 18 2019, 8:00 AM · Restricted Project
cebowleratibm added a comment to D70126: [PowerPC] Refactor FinishCall [NFC].

The new logic is much clearer, though it's hard to discern that the semantics remain correct because so much logic was redistributed. If a series of smaller commits were possible it would be easier to review.

Nov 18 2019, 6:48 AM · Restricted Project

Oct 24 2019

cebowleratibm updated the diff for D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI..

Use ValVT in CC_AIX rather than LocVT.

Oct 24 2019, 9:11 AM · Restricted Project
cebowleratibm added inline comments to D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI..
Oct 24 2019, 9:11 AM · Restricted Project

Oct 23 2019

cebowleratibm updated the diff for D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI..

One last test for error on AIX nest parameters. I renamed some of the aix tests for consistency.

Oct 23 2019, 7:28 AM · Restricted Project
cebowleratibm updated the diff for D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI..

Add tests for the limitation errors on sret parameters, byval parameters as well as arguments passed in memory. These are limitations that will be addressed in future work.

Oct 23 2019, 6:24 AM · Restricted Project

Oct 22 2019

cebowleratibm planned changes to D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI..

I'll add some test coverage for some of the limitation errors.

Oct 22 2019, 10:34 AM · Restricted Project
cebowleratibm added inline comments to D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI..
Oct 22 2019, 4:57 AM · Restricted Project
cebowleratibm updated the diff for D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI..

Minor correction on one of the nit comments.

Oct 22 2019, 4:57 AM · Restricted Project
cebowleratibm updated the diff for D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI..

Address nit comments.

Oct 22 2019, 4:57 AM · Restricted Project

Oct 17 2019

cebowleratibm created D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI..
Oct 17 2019, 4:57 AM · Restricted Project

Aug 12 2019

cebowleratibm updated the diff for D64424: [AIX] Implement LR prolog/epilog save/restore .

Update the TOC, FP and BP offset accessors to assert for AIX. The assertions will be removed with future work that accompanied by appropriate test coverage.

Aug 12 2019, 8:24 AM · Restricted Project

Aug 8 2019

cebowleratibm added inline comments to D64424: [AIX] Implement LR prolog/epilog save/restore .
Aug 8 2019, 8:49 AM · Restricted Project

Jul 30 2019

cebowleratibm updated the diff for D64424: [AIX] Implement LR prolog/epilog save/restore .

Rebased changes after D63738 and

Jul 30 2019, 7:46 AM · Restricted Project

Jul 9 2019

cebowleratibm retitled D64424: [AIX] Implement LR prolog/epilog save/restore from AIX: Implement LR prolog/epilog save/restore to [AIX] Implement LR prolog/epilog save/restore .
Jul 9 2019, 9:03 AM · Restricted Project
cebowleratibm created D64424: [AIX] Implement LR prolog/epilog save/restore .
Jul 9 2019, 8:57 AM · Restricted Project

Jun 28 2019

cebowleratibm added a reviewer for D61694: Boilerplate for producing XCOFF object files from the PowerPC backend.: cebowleratibm.
Jun 28 2019, 5:26 AM · Restricted Project