- User Since
- Jun 17 2019, 7:18 AM (31 w, 4 h)
Fri, Jan 10
Already approved but I've addressed the nits and posted the final commit here because I'll need someone to commit it for me.
Thu, Jan 9
Rewrote comments in aix-cc-altivec.ll test, fixed the vector diagnostic bug Zarko pointed out and addressed small nits.
Wed, Jan 8
Tue, Jan 7
I've decided to use custom regs for all gpr inits for float varargs. I discovered that f64 passing in 64-bit gpr was missing a required bitcast to int to handle the initialization. The new logic ensures the bitcast occurs for any custom handling. Custom handling is only expected for gpr inits of float args.
Dec 17 2019
Recent problems have come up generating the GPR initializations for floating point args, which may require some rework. Hold off on review until revision is posted.
Dec 16 2019
Dec 13 2019
Dec 12 2019
Minor tweaks and test upates to come. I'll add an assembly test to validate that we don't need to store to memory to initiailze the two GPRs for f64 in PPC32 mode on newer hardware.
Dec 6 2019
Clang formatted the change and updated the float reg to use LocVT.
Dec 5 2019
Dec 4 2019
Nov 18 2019
The new logic is much clearer, though it's hard to discern that the semantics remain correct because so much logic was redistributed. If a series of smaller commits were possible it would be easier to review.
Oct 24 2019
Use ValVT in CC_AIX rather than LocVT.
Oct 23 2019
One last test for error on AIX nest parameters. I renamed some of the aix tests for consistency.
Add tests for the limitation errors on sret parameters, byval parameters as well as arguments passed in memory. These are limitations that will be addressed in future work.
Oct 22 2019
I'll add some test coverage for some of the limitation errors.
Minor correction on one of the nit comments.
Address nit comments.
Oct 17 2019
Aug 12 2019
Update the TOC, FP and BP offset accessors to assert for AIX. The assertions will be removed with future work that accompanied by appropriate test coverage.
Aug 8 2019
Jul 30 2019
Rebased changes after D63738 and