Fix indent 2.

Fix indent.

Reducing this patch to the simpler cases for easier review. Will address the more complicated cases in
another patch.

In D140637#4196543, @IBricchi wrote:

I think the issue was that:

export_executable_symbols_for_plugins(AnalysisTests)

Was being called twice, once in each of the plugin cmake files. I've moved it into the main Analysys CMakeFile and I think this should fix the issue we were seeing, but I don't have an AIX machine to test it on. Would you mind checking @Jake-Egan?

Hi, we're seeing a CMake error on AIX after this change. Can you take a look please?

LGTM

Thanks for addressing this. Unfortunately the test is still failing after the fix and a clean build

In D144846#4167834, @hubert.reinterpretcast wrote:

In D144846#4167823, @Jake-Egan wrote:

Hi, this change caused some failures on AIX. Could you take a look please?

@Jake-Egan, the failure does not look like something this patch would cause.

Hi, this change caused some failures on AIX. Could you take a look please?

Hi, this new test fails on AIX, could you take a look please?
https://lab.llvm.org/buildbot/#/builders/214/builds/6148/steps/6/logs/FAIL__Clang__modules-full-output-tu-order_c

It fails with a different assembler error on different platforms (tried on AIX, linux, and mac). No error if you remove the AIX target.

clang++ -target powerpc64-ibm-aix -c foo.cc

This runs into the error The symbol .rodata.str1.1L...str is not defined. if we specify an optimization flag greater than 0.

That did the trick! I'm going to go ahead and revert 78f13ea093afdebcaa3b5c5690530b9217bbdfac because it's causing some other failures and your most recent commit fixes things.

Thank you for looking into this. Unfortunately I think 78f13ea093afdebcaa3b5c5690530b9217bbdfac removed another symbol _ZN4llvm4PassD2Ev and _ZN4llvm13AllAnalysesOnINS_6ModuleEE6SetKeyE is still missing as well. https://lab.llvm.org/buildbot/#/builders/214/builds/5781 (EDIT: Or maybe I spoke too soon and a clean build will resolve it: https://lab.llvm.org/buildbot/#/builders/214/builds/5782)

This or 4c72266830ffa332ebb7cf1d3bbd6c56d001fa0f seems to cause a test-suite build failure on AIX, could you take a look?
https://lab.llvm.org/buildbot/#/builders/214/builds/5779/steps/9/logs/stdio

Thank you - it seems only AIX uses -Wl,-brtl flags with these tests.

Hi, this caused some failures on AIX, could you take a look?

Thank you for looking into the failure. Fortunately the test is passing on the AIX bot now and locally for me - it looks like a clean build fixed it.

Hi, this change causes a failure on AIX. Could you take a look?
https://lab.llvm.org/buildbot/#/builders/214/builds/5502/steps/6/logs/FAIL__Clang__annotate-comments-objc_m

In D142484#4079909, @jhuber6 wrote:

In D142484#4079869, @Jake-Egan wrote:

Hi, this new test fails on AIX. Could you take a look?
https://lab.llvm.org/buildbot/#/builders/214/builds/5477/steps/6/logs/FAIL__Clang__linker-wrapper-libs_c

I might just put that this test requires Linux. Because I don't think I can debug it without access to the system. We don't really support offloading on anything but Linux anyway.

Hi, this new test fails on AIX. Could you take a look?
https://lab.llvm.org/buildbot/#/builders/214/builds/5477/steps/6/logs/FAIL__Clang__linker-wrapper-libs_c

Looking into an out-of-band solution.

It seems this problem is hard to investigate without having access to an AIX machine, so we are looking into it.

In D137058#4057424, @ChuanqiXu wrote:

In D137058#4056647, @Jake-Egan wrote:

Hi, this new test fails on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/5351/steps/6/logs/FAIL__Clang__module-output_cppm
Could you take a look?

I added // REQUIRES: x86-registered-target. Is it still failing?

Hi, this new test fails on AIX https://lab.llvm.org/buildbot/#/builders/214/builds/5351/steps/6/logs/FAIL__Clang__module-output_cppm
Could you take a look?

Getting a build failure on AIX, could you take a look please?

In D140867#4042405, @ChuanqiXu wrote:

In D140867#4042351, @Jake-Egan wrote:

Would you like to take a double look?

Yes, it still fails on the bot and on my local machine. I've added an XFAIL to the test for now just to get the AIX bot green.

Weird. Maybe you can find a method by adding REQUIRES or NOT-SUPPORTED and test it locally. If it goes well then you can upstream the change.

Would you like to take a double look?

In D140867#4038388, @ChuanqiXu wrote:

In D140867#4036239, @Jake-Egan wrote:

Hi, this test is failing on AIX, could you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/5242/steps/6/logs/FAIL__Clang__pr59765-modules-global-ctor-dtor_cppm

I fixed the failure by restricting the targets in https://github.com/llvm/llvm-project/commit/9cb1298dcc85c357eb97ed0bdc3c82c5d011f6f6. And the best approach is to add a separate test for AIX but I don't have an AIX machine. You can add it if you are interested.

Hi, this test is failing on AIX, could you take a look please? https://lab.llvm.org/buildbot/#/builders/214/builds/5242/steps/6/logs/FAIL__Clang__pr59765-modules-global-ctor-dtor_cppm

It doesn't look like the tests in https://lab.llvm.org/buildbot/#/builders/214/builds/4934 are failing anymore here: https://lab.llvm.org/buildbot/#/builders/214/builds/5174

Reverted this patch because it's still failing on the AIX bot.

Sorry to raise this issue late (due to the holidays), but it seems this change causes a test failure on AIX

If we'd like to go that route, I could update this patch to re-add cxx_under_test (or other name) as a lit parameter.

It looks like cxx_under_test would work for our use case. Is this option preferred?

Change path to /usr/local/.

Hopefully fix bad arc diff.

• [clang-ppc64-aix] Switch build compiler to clang

Removed release candidate from path.

Verified that it passes on AIX. LGTM.

Hi, this new test fails on AIX
https://lab.llvm.org/buildbot/#/builders/214/builds/2784/steps/6/logs/FAIL__LLVM__atan_ll
Could you take a look please?

There is a failure on the AIX bot also:

Hi, this new test is failing on AIX, could you take a look please?
https://lab.llvm.org/buildbot/#/builders/214/builds/2544/steps/6/logs/FAIL__Clang__objc_property_m

I'll do that next time, thank you!

Already committed here https://github.com/llvm/llvm-project/commit/adc1c34bab8c82e203ebdd04d6d418958e9ccb17

The OpenMPIRBuilderTest.cpp test fails to build on AIX. https://lab.llvm.org/buildbot/#/builders/214/builds/2398/steps/6/logs/stdio Can you take a look please?

Hi, the new test, zdebug.yaml, fails on AIX with error: LLVM was not compiled with LLVM_ENABLE_ZLIB: cannot decompress.
https://lab.llvm.org/buildbot/#/builders/214/builds/2061/steps/6/logs/FAIL__LLVM__zdebug_yaml