Page MenuHomePhabricator

Jake-Egan (Jake Egan)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2021, 1:49 PM (36 w, 1 d)

Recent Activity

Today

Jake-Egan added a reviewer for D117587: [ifs] Use a tmp file instead of "-": hubert.reinterpretcast.
Tue, Jan 18, 10:42 AM · Restricted Project
Jake-Egan retitled D117587: [ifs] Use a tmp file instead of "-" from [ifs] Use a tmp file instead of - to [ifs] Use a tmp file instead of "-".
Tue, Jan 18, 10:40 AM · Restricted Project
Jake-Egan requested review of D117587: [ifs] Use a tmp file instead of "-".
Tue, Jan 18, 10:39 AM · Restricted Project

Yesterday

Jake-Egan committed rG6f0977519d12: [AIX][ZOS] Handle unsupported builtin function CFStringMakeConstantString (authored by Jake-Egan).
[AIX][ZOS] Handle unsupported builtin function CFStringMakeConstantString
Mon, Jan 17, 8:24 AM
Jake-Egan closed D117315: [AIX][ZOS] Handle unsupported builtin function CFStringMakeConstantString.
Mon, Jan 17, 8:24 AM · Restricted Project

Fri, Jan 14

Jake-Egan updated the summary of D117315: [AIX][ZOS] Handle unsupported builtin function CFStringMakeConstantString.
Fri, Jan 14, 7:16 AM · Restricted Project
Jake-Egan requested review of D117315: [AIX][ZOS] Handle unsupported builtin function CFStringMakeConstantString.
Fri, Jan 14, 7:11 AM · Restricted Project

Sun, Jan 9

Jake-Egan committed rGfbf52caf58b3: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support (authored by Jake-Egan).
[AIX] Disable tests that fail because of no 64-bit XCOFF object file support
Sun, Jan 9, 9:27 AM
Jake-Egan closed D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.
Sun, Jan 9, 9:26 AM · Restricted Project, Restricted Project

Thu, Jan 6

Jake-Egan updated the summary of D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.
Thu, Jan 6, 10:30 AM · Restricted Project, Restricted Project
Jake-Egan committed rGe3a261831bd9: [CMake] Include ZLIB_ROOT in LLVMConfig.cmake (authored by Jake-Egan).
[CMake] Include ZLIB_ROOT in LLVMConfig.cmake
Thu, Jan 6, 8:25 AM
Jake-Egan closed D116235: [CMake] Include ZLIB_ROOT in LLVMConfig.cmake.
Thu, Jan 6, 8:25 AM · Restricted Project
Jake-Egan added inline comments to D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.
Thu, Jan 6, 6:43 AM · Restricted Project, Restricted Project

Tue, Jan 4

Jake-Egan added inline comments to D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.
Tue, Jan 4, 10:08 AM · Restricted Project, Restricted Project

Wed, Dec 29

Jake-Egan added a reviewer for D116235: [CMake] Include ZLIB_ROOT in LLVMConfig.cmake: phosek.
Wed, Dec 29, 11:07 AM · Restricted Project

Thu, Dec 23

Jake-Egan updated the summary of D116235: [CMake] Include ZLIB_ROOT in LLVMConfig.cmake.
Thu, Dec 23, 12:47 PM · Restricted Project
Jake-Egan requested review of D116235: [CMake] Include ZLIB_ROOT in LLVMConfig.cmake.
Thu, Dec 23, 12:44 PM · Restricted Project

Wed, Dec 22

Jake-Egan added inline comments to D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.
Wed, Dec 22, 11:05 AM · Restricted Project, Restricted Project
Jake-Egan updated the diff for D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.

Fixed typo.

Wed, Dec 22, 10:54 AM · Restricted Project, Restricted Project

Tue, Dec 21

Jake-Egan added inline comments to D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.
Tue, Dec 21, 11:02 AM · Restricted Project, Restricted Project
Jake-Egan updated the diff for D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.

Added -fintegrated-as option.

Tue, Dec 21, 11:01 AM · Restricted Project, Restricted Project

Dec 16 2021

Jake-Egan committed rG3aece7995cb6: Adapt test to be compatible with AIX (authored by Jake-Egan).
Adapt test to be compatible with AIX
Dec 16 2021, 9:35 AM
Jake-Egan closed D115695: Adapt test to be compatible with AIX.
Dec 16 2021, 9:35 AM · Restricted Project

Dec 15 2021

Jake-Egan added a comment to D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.

Ping.

Dec 15 2021, 8:37 AM · Restricted Project, Restricted Project

Dec 14 2021

Jake-Egan updated the diff for D115695: Adapt test to be compatible with AIX.

Use RE to match debug_info or dwinfo.

Dec 14 2021, 6:26 AM · Restricted Project

Dec 13 2021

Jake-Egan updated the summary of D115695: Adapt test to be compatible with AIX.
Dec 13 2021, 7:11 PM · Restricted Project
Jake-Egan requested review of D115695: Adapt test to be compatible with AIX.
Dec 13 2021, 7:01 PM · Restricted Project

Dec 9 2021

Jake-Egan committed rG143e42429480: [AIX] Disable failing tests because of missing DWARF sections (authored by Jake-Egan).
[AIX] Disable failing tests because of missing DWARF sections
Dec 9 2021, 6:06 AM
Jake-Egan closed D114681: [AIX] Disable failing tests because of missing DWARF sections.
Dec 9 2021, 6:06 AM · Restricted Project

Dec 8 2021

Jake-Egan added a comment to D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.

Ping.

Dec 8 2021, 8:39 AM · Restricted Project, Restricted Project
Jake-Egan committed rGb73cf6207efa: [DWARF] Fix consistency and AIX compatibility of checks in DWARF test (authored by Jake-Egan).
[DWARF] Fix consistency and AIX compatibility of checks in DWARF test
Dec 8 2021, 7:11 AM
Jake-Egan closed D115287: [DWARF] Fix consistency and AIX compatibility of checks in DWARF test.
Dec 8 2021, 7:10 AM · Restricted Project
Jake-Egan committed rG158ac4a62765: [LTO] Remove default_triple requirement from tests that specify the triple (authored by Jake-Egan).
[LTO] Remove default_triple requirement from tests that specify the triple
Dec 8 2021, 6:18 AM
Jake-Egan closed D115048: [LTO] Remove default_triple requirement from tests that specify the triple.
Dec 8 2021, 6:17 AM · Restricted Project

Dec 7 2021

Jake-Egan updated the summary of D115287: [DWARF] Fix consistency and AIX compatibility of checks in DWARF test.
Dec 7 2021, 8:29 PM · Restricted Project
Jake-Egan retitled D115287: [DWARF] Fix consistency and AIX compatibility of checks in DWARF test from [DWARF] Fix consistency of checks in DWARF test to [DWARF] Fix consistency and AIX compatibility of checks in DWARF test.
Dec 7 2021, 8:25 PM · Restricted Project
Jake-Egan added a comment to D115287: [DWARF] Fix consistency and AIX compatibility of checks in DWARF test.

Looks good, thanks! (this is for more AIX compatibility so the test is agnostic to strp V str encoding, right? Might be worth noting that in the commit message)

Dec 7 2021, 8:19 PM · Restricted Project
Jake-Egan added a reviewer for D115287: [DWARF] Fix consistency and AIX compatibility of checks in DWARF test: shchenz.
Dec 7 2021, 2:24 PM · Restricted Project
Jake-Egan updated the summary of D115287: [DWARF] Fix consistency and AIX compatibility of checks in DWARF test.
Dec 7 2021, 2:21 PM · Restricted Project
Jake-Egan requested review of D115287: [DWARF] Fix consistency and AIX compatibility of checks in DWARF test.
Dec 7 2021, 2:18 PM · Restricted Project
Jake-Egan updated the summary of D114681: [AIX] Disable failing tests because of missing DWARF sections.
Dec 7 2021, 7:55 AM · Restricted Project
Jake-Egan updated the diff for D114681: [AIX] Disable failing tests because of missing DWARF sections.

I updated the patch to add FIXME and added more detail to the description.

Dec 7 2021, 7:53 AM · Restricted Project

Dec 6 2021

Jake-Egan committed rGb23d17f6b5f7: [MC] Add emitXCOFFSymbolLinkageWithVisibility to MCNullStreamer (authored by Jake-Egan).
[MC] Add emitXCOFFSymbolLinkageWithVisibility to MCNullStreamer
Dec 6 2021, 6:27 AM
Jake-Egan closed D114876: [MC] Add emitXCOFFSymbolLinkageWithVisibility to MCNullStreamer.
Dec 6 2021, 6:26 AM · Restricted Project

Dec 3 2021

Jake-Egan updated the summary of D115048: [LTO] Remove default_triple requirement from tests that specify the triple.
Dec 3 2021, 8:35 AM · Restricted Project
Jake-Egan added a comment to D114683: [LTO] Specify triple to address unknown binary format assertion.

Aside: I think the default_triple requirement can be removed?

Dec 3 2021, 8:34 AM · Restricted Project
Jake-Egan updated the summary of D115048: [LTO] Remove default_triple requirement from tests that specify the triple.
Dec 3 2021, 8:32 AM · Restricted Project
Jake-Egan requested review of D115048: [LTO] Remove default_triple requirement from tests that specify the triple.
Dec 3 2021, 8:30 AM · Restricted Project

Dec 2 2021

Jake-Egan committed rG1e328b06c152: [LTO] Specify triple to address unknown binary format assertion (authored by Jake-Egan).
[LTO] Specify triple to address unknown binary format assertion
Dec 2 2021, 1:40 PM
Jake-Egan closed D114683: [LTO] Specify triple to address unknown binary format assertion.
Dec 2 2021, 1:40 PM · Restricted Project

Dec 1 2021

Jake-Egan updated the summary of D114876: [MC] Add emitXCOFFSymbolLinkageWithVisibility to MCNullStreamer.
Dec 1 2021, 6:59 AM · Restricted Project
Jake-Egan requested review of D114876: [MC] Add emitXCOFFSymbolLinkageWithVisibility to MCNullStreamer.
Dec 1 2021, 6:54 AM · Restricted Project

Nov 30 2021

Jake-Egan abandoned D114686: [AIX] XFAIL test missing inlined argument/local variables for the inlined subroutine.
Nov 30 2021, 6:10 AM · Restricted Project
Jake-Egan added a comment to D114686: [AIX] XFAIL test missing inlined argument/local variables for the inlined subroutine.

https://reviews.llvm.org/D114778 is created for the root cause, so I think we can abandon this patch now?

Nov 30 2021, 6:10 AM · Restricted Project
Jake-Egan abandoned D114685: [AIX] XFAIL test missing DBG_LABEL.

https://reviews.llvm.org/D114778 is created for the root cause, so I think we can abandon this patch now?

Nov 30 2021, 6:10 AM · Restricted Project

Nov 29 2021

Jake-Egan accepted D114484: [NFC][AIX]Disable unsupported hip test on AIX.
Nov 29 2021, 6:34 AM · Restricted Project
Jake-Egan added a comment to D114484: [NFC][AIX]Disable unsupported hip test on AIX.

LGTM

Nov 29 2021, 6:34 AM · Restricted Project

Nov 28 2021

Jake-Egan retitled D114686: [AIX] XFAIL test missing inlined argument/local variables for the inlined subroutine from [AIX] XFAIL test missing DW_TAG_formal_parameter to [AIX] XFAIL test missing inlined argument/local variables for the inlined subroutine.
Nov 28 2021, 7:37 PM · Restricted Project
Jake-Egan requested review of D114686: [AIX] XFAIL test missing inlined argument/local variables for the inlined subroutine.
Nov 28 2021, 7:34 PM · Restricted Project
Jake-Egan updated the summary of D114685: [AIX] XFAIL test missing DBG_LABEL.
Nov 28 2021, 7:20 PM · Restricted Project
Jake-Egan requested review of D114685: [AIX] XFAIL test missing DBG_LABEL.
Nov 28 2021, 7:18 PM · Restricted Project
Jake-Egan planned changes to D114110: [AIX] Mark tests using DWARF version less than 3 as unsupported because XCOFF64 requires DWARF64.
Nov 28 2021, 7:02 PM · Restricted Project
Jake-Egan committed rG01eb91fa86a0: [AIX] Disable empty.ll test using unsupported split dwarf (authored by Jake-Egan).
[AIX] Disable empty.ll test using unsupported split dwarf
Nov 28 2021, 6:55 PM
Jake-Egan closed D114567: [AIX] Disable empty.ll test using unsupported split dwarf.
Nov 28 2021, 6:55 PM · Restricted Project
Jake-Egan updated the summary of D114683: [LTO] Specify triple to address unknown binary format assertion.
Nov 28 2021, 6:46 PM · Restricted Project
Jake-Egan requested review of D114683: [LTO] Specify triple to address unknown binary format assertion.
Nov 28 2021, 6:39 PM · Restricted Project
Jake-Egan updated the summary of D114681: [AIX] Disable failing tests because of missing DWARF sections.
Nov 28 2021, 5:55 PM · Restricted Project
Jake-Egan requested review of D114681: [AIX] Disable failing tests because of missing DWARF sections.
Nov 28 2021, 5:54 PM · Restricted Project

Nov 25 2021

Jake-Egan committed rG0796869e4e1e: [AIX] Disable unsupported offloading gpu tests (authored by Jake-Egan).
[AIX] Disable unsupported offloading gpu tests
Nov 25 2021, 12:11 PM
Jake-Egan closed D114381: [AIX] Disable unsupported offloading gpu tests.
Nov 25 2021, 12:11 PM · Restricted Project
Jake-Egan updated the diff for D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.

Removed some tests already disabled by D114481.

Nov 25 2021, 11:00 AM · Restricted Project, Restricted Project
Jake-Egan added inline comments to D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.
Nov 25 2021, 10:53 AM · Restricted Project, Restricted Project

Nov 24 2021

Jake-Egan updated the summary of D114567: [AIX] Disable empty.ll test using unsupported split dwarf.
Nov 24 2021, 6:39 PM · Restricted Project
Jake-Egan requested review of D114567: [AIX] Disable empty.ll test using unsupported split dwarf.
Nov 24 2021, 6:35 PM · Restricted Project

Nov 23 2021

Jake-Egan updated the diff for D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.

Thanks for the review. I updated the patch to use lit.cfg.py to filter tests that use obj options. For tests that don't use the option or has an individual folder, I changed them to UNSUPPORTED instead of XFAIL.

Nov 23 2021, 7:16 AM · Restricted Project, Restricted Project

Nov 22 2021

Jake-Egan updated the summary of D114381: [AIX] Disable unsupported offloading gpu tests.
Nov 22 2021, 10:17 AM · Restricted Project
Jake-Egan requested review of D114381: [AIX] Disable unsupported offloading gpu tests.
Nov 22 2021, 10:12 AM · Restricted Project

Nov 18 2021

Jake-Egan added a comment to D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.

Can we use UNSUPPORTED instead of XFAIL since it is unsupported?

Nov 18 2021, 7:16 AM · Restricted Project, Restricted Project

Nov 17 2021

Jake-Egan updated the summary of D114110: [AIX] Mark tests using DWARF version less than 3 as unsupported because XCOFF64 requires DWARF64.
Nov 17 2021, 10:54 AM · Restricted Project
Jake-Egan requested review of D114110: [AIX] Mark tests using DWARF version less than 3 as unsupported because XCOFF64 requires DWARF64.
Nov 17 2021, 10:49 AM · Restricted Project

Nov 16 2021

Jake-Egan committed rG2f43a656f341: [AIX] XFAIL lto-comp-dir.ll for lack of .file directive support (authored by Jake-Egan).
[AIX] XFAIL lto-comp-dir.ll for lack of .file directive support
Nov 16 2021, 6:15 AM
Jake-Egan closed D113640: [AIX] XFAIL lto-comp-dir.ll for lack of .file directive support.
Nov 16 2021, 6:15 AM · Restricted Project

Nov 10 2021

Jake-Egan updated the summary of D113640: [AIX] XFAIL lto-comp-dir.ll for lack of .file directive support.
Nov 10 2021, 7:01 PM · Restricted Project
Jake-Egan requested review of D113640: [AIX] XFAIL lto-comp-dir.ll for lack of .file directive support.
Nov 10 2021, 6:59 PM · Restricted Project
Jake-Egan committed rG423ea9ae7f7e: [AIX] XFAIL 2009-03-29-SoftFloatVectorExtract.ll because of no soft float… (authored by Jake-Egan).
[AIX] XFAIL 2009-03-29-SoftFloatVectorExtract.ll because of no soft float…
Nov 10 2021, 5:58 PM
Jake-Egan closed D113407: [AIX] XFAIL 2009-03-29-SoftFloatVectorExtract.ll because of no soft float support.
Nov 10 2021, 5:58 PM · Restricted Project
Jake-Egan committed rG9303c7da3967: [AIX] Define WCHAR_T_TYPE as unsigned int on 64-bit AIX for wchar.c test (authored by Jake-Egan).
[AIX] Define WCHAR_T_TYPE as unsigned int on 64-bit AIX for wchar.c test
Nov 10 2021, 5:47 PM
Jake-Egan closed D113428: [AIX] Define WCHAR_T_TYPE as unsigned int on 64-bit AIX for wchar.c test.
Nov 10 2021, 5:47 PM · Restricted Project
Jake-Egan accepted D113614: [AIX][NFC] Disable clang-repl tests failing due to lack of 64-bit XCOFF support..

LGTM

Nov 10 2021, 5:40 PM · Restricted Project

Nov 9 2021

Jake-Egan updated the diff for D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.

Add LLVM :: DebugInfo/attr-btf_type_tag.ll

Nov 9 2021, 7:57 AM · Restricted Project, Restricted Project

Nov 8 2021

Jake-Egan updated the summary of D113428: [AIX] Define WCHAR_T_TYPE as unsigned int on 64-bit AIX for wchar.c test.
Nov 8 2021, 12:53 PM · Restricted Project
Jake-Egan requested review of D113428: [AIX] Define WCHAR_T_TYPE as unsigned int on 64-bit AIX for wchar.c test.
Nov 8 2021, 12:47 PM · Restricted Project
Jake-Egan updated the summary of D113407: [AIX] XFAIL 2009-03-29-SoftFloatVectorExtract.ll because of no soft float support.
Nov 8 2021, 8:30 AM · Restricted Project
Jake-Egan requested review of D113407: [AIX] XFAIL 2009-03-29-SoftFloatVectorExtract.ll because of no soft float support.
Nov 8 2021, 8:27 AM · Restricted Project

Nov 3 2021

Jake-Egan added a reviewer for D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support: hubert.reinterpretcast.
Nov 3 2021, 10:58 AM · Restricted Project, Restricted Project
Jake-Egan updated the summary of D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.
Nov 3 2021, 10:57 AM · Restricted Project, Restricted Project
Jake-Egan updated the diff for D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.

Updated patch to XFAIL only on 64-bit.

Nov 3 2021, 10:56 AM · Restricted Project, Restricted Project

Nov 2 2021

Jake-Egan updated the diff for D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.

Fix llvm/test/DebugInfo/omit-empty.ll.

Nov 2 2021, 1:56 PM · Restricted Project, Restricted Project
Jake-Egan updated the summary of D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.
Nov 2 2021, 1:50 PM · Restricted Project, Restricted Project
Jake-Egan requested review of D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support.
Nov 2 2021, 1:49 PM · Restricted Project, Restricted Project