Page MenuHomePhabricator

[RISCV][Clang] Add vmv and vfmv series intrinsic functions.
ClosedPublic

Authored by khchen on Apr 11 2021, 7:28 AM.

Details

Summary

Authored-by: Roger Ferrer Ibanez <rofirrim@gmail.com>
Co-Authored-by: Zakk Chen <zakk.chen@sifive.com>

Diff Detail

Event Timeline

khchen created this revision.Apr 11 2021, 7:28 AM
khchen requested review of this revision.Apr 11 2021, 7:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 11 2021, 7:28 AM
Jim added a reviewer: Jim.Apr 11 2021, 11:35 PM
Jim added inline comments.
clang/include/clang/Basic/riscv_vector.td
993

And below.

1001

I am not sure that indent is needed inside let expression. In some cases, it don't have indent.

khchen updated this revision to Diff 336839.Apr 12 2021, 8:16 AM
khchen marked 2 inline comments as done.

address Jim's comment.

clang/include/clang/Basic/riscv_vector.td
1001
khchen edited the summary of this revision. (Show Details)Apr 12 2021, 8:16 AM
This revision is now accepted and ready to land.Apr 12 2021, 10:00 AM
Jim added inline comments.Apr 12 2021, 6:39 PM
clang/include/clang/Basic/riscv_vector.td
1217

Indent

1221

Indent

khchen updated this revision to Diff 337175.Apr 13 2021, 8:54 AM
khchen edited the summary of this revision. (Show Details)

Fix Indent.

Jim accepted this revision.Apr 13 2021, 5:26 PM

LGTM