Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/include/clang/Basic/riscv_vector.td | ||
---|---|---|
345 | sufffix->suffix | |
365 | sufffix->suffix | |
375 | widden->widen | |
375 | I'm not sure having a multiclass that takes a bool is better than just having 2 different multiclasses. | |
388 | widden->widen | |
clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwadd.c | ||
36 | Why do scalars require _wx or _vx, but vector don't need a suffix? |
Address Craig's comments. Sorry for a lot of typos.
clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwadd.c | ||
---|---|---|
36 | https://github.com/riscv/rvv-intrinsic-doc/blob/master/rvv-intrinsic-rfc.md#widening-vector-scalar-arithmetic-instructions But in https://github.com/riscv/rvv-intrinsic-doc/pull/76 we start to make overloading name seems more consistent. So I think making this case consistent is ok to me. I could send a PR to intrinsic-doc, what do you think? |
clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwadd.c | ||
---|---|---|
36 | Should I update this patch for https://github.com/riscv/rvv-intrinsic-doc/pull/77 PR? |
clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vwadd.c | ||
---|---|---|
36 | I think that makes sense. It's more consistent for someone writing intrinsic code if the suffix is always there. |
sufffix->suffix