This is an archive of the discontinued LLVM Phabricator instance.

Differential D99501

ignore -flto= options recognized by GCC
ClosedPublic

Authored by doko on Mar 29 2021, 6:21 AM.

Details

Reviewers
tejohnson
rsmith
Commits
rG162848654842: ignore -flto= options recognized by GCC
Summary

as requested in https://bugs.llvm.org/show_bug.cgi?id=49553, submitting the proposed changes to just ignore the -flto= options which are recognized by GCC ("auto" and "jobserver").

GCC supports -flto=<auto|jobserver|<N> to select the parallelity for LTO builds. LLVM also has -flto-jobs=<N>, which only seems to have a meaning when used with -flto=thin?

The attached patch just ignores the values "auto" and "jobserver". that doesn't change anything in functionality. Another option would be to map these values to either "thin" or "full", maybe in presence of the -ffat-lto-objects option?

-flto=<n> could also be translated to -flto-jobs=<N>.

Diff Detail

Unit TestsFailed

TimeTest
400 msx64 debian > Clang.Frontend::optimization-remark-options.c
580 msx64 windows > Clang.Frontend::optimization-remark-options.c

Event Timeline

doko created this revision.Mar 29 2021, 6:21 AM
Herald added a subscriber: inglorion. · View Herald TranscriptMar 29 2021, 6:21 AM
doko requested review of this revision.Mar 29 2021, 6:21 AM
Harbormaster completed remote builds in B96098: Diff 333835.Mar 29 2021, 7:05 AM
serge-sans-paille added subscribers: mehdi_amini, serge-sans-paille.Mar 30 2021, 12:16 AM

Please submit a patch with context. @mehdi_amini this looks good to me, any thoughts?

doko updated this revision to Diff 334248.Mar 30 2021, 1:00 PM
Harbormaster completed remote builds in B96387: Diff 334248.Mar 30 2021, 1:34 PM
mehdi_amini added reviewers: tejohnson, rsmith.Mar 30 2021, 3:23 PM

I don't know what's the best practice for gcc compatibility with respect to clang command line flags, adding Teresa and Richard here.

tejohnson added a comment.Apr 1 2021, 8:34 AM

It looks like typically Clang will warn for unsupported gcc options. See clang_ignored_gcc_optimization_f_Group and its handling in Clang.cpp. I think it should be possible to simply mark these as clang_ignored_gcc_optimization_f_Group in Options.td. I.e. have an entry specifically for each of these, like:

def : Flag<["-"], "flto=auto">, Group<clang_ignored_gcc_optimization_f_Group>;
def : Flag<["-"], "flto=jobserver">, Group<clang_ignored_gcc_optimization_f_Group>;

doko added a comment.Apr 1 2021, 9:14 AM

do you mean, just discard the current patch, and just list those as unsupported?

tejohnson added a comment.Apr 1 2021, 9:16 AM
In D99501#2664253, @doko wrote:

do you mean, just discard the current patch, and just list those as unsupported?

Yes as an alternate approach that results in these being warned about (and ignored) as we seem to do for other unsupported gcc options.

doko updated this revision to Diff 334793.Apr 1 2021, 12:21 PM

discarded the first approach, and used the proposed approach. I added this close to the ignoring of the -ffat-lto-objects option. Please let me know if there's a better location. Builds and works as expected:

$ clang -flto=auto hello.c
clang: warning: optimization flag '-flto=auto' is not supported [-Wignored-optimization-argument]
$ echo $?
0

$ clang -flto=auto -ffat-lto-objects hello.c
clang: warning: optimization flag '-flto=auto' is not supported [-Wignored-optimization-argument]
clang: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]

$ clang -flto=jobserver -ffat-lto-objects hello.c
clang: warning: optimization flag '-flto=jobserver' is not supported [-Wignored-optimization-argument]
clang: warning: optimization flag '-ffat-lto-objects' is not supported [-Wignored-optimization-argument]

Herald added subscribers: jansvoboda11, dang. · View Herald TranscriptApr 1 2021, 12:21 PM
tejohnson accepted this revision.Apr 1 2021, 12:29 PM

lgtm

This revision is now accepted and ready to land.Apr 1 2021, 12:29 PM
Harbormaster completed remote builds in B96785: Diff 334793.Apr 1 2021, 1:23 PM
This revision was landed with ongoing or failed builds.Apr 5 2021, 2:55 AM
Closed by commit rG162848654842: ignore -flto= options recognized by GCC (authored by sylvestre.ledru). · Explain Why
This revision was automatically updated to reflect the committed changes.
sylvestre.ledru added a commit: rG162848654842: ignore -flto= options recognized by GCC.
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2021, 2:55 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
lebedev.ri added a subscriber: lebedev.ri.Apr 5 2021, 2:59 AM

Tests missing.
This somehow wasn't sent to cfe-commits list

fhahn added a subscriber: fhahn.Apr 8 2021, 2:56 AM
In D99501#2668774, @lebedev.ri wrote:

Tests missing.
This somehow wasn't sent to cfe-commits list

@doko could you add a test? e.g. in clang/test/Driver/clang_f_opts.c, which already contains a check for -ffat-lto-objects

doko added a comment.Apr 9 2021, 5:51 AM

here in the same place, or in a different merge request?

fhahn added a comment.Apr 9 2021, 5:58 AM
In D99501#2679394, @doko wrote:

here in the same place, or in a different merge request?

This one is closed now I think, so a new review would be ideal.

doko mentioned this in D100484: add test case for ignoring -flto=auto and -flto=jobserver.Apr 14 2021, 8:05 AM

that's now https://reviews.llvm.org/D100484

tejohnson added a comment.Apr 14 2021, 8:38 AM

Just approved the test case patch. Sorry I missed the lack of test on this!

fhahn added a comment.Apr 15 2021, 12:56 AM
In D99501#2689090, @tejohnson wrote:

Just approved the test case patch. Sorry I missed the lack of test on this!

Great, thanks!

sylvestre.ledru mentioned this in rG56cb214b38a7: add test case for ignoring -flto=auto and -flto=jobserver.Apr 15 2021, 3:20 AM

Revision Contents

PathSize
clang/
include/
clang/
Driver/
3 lines
lib/
Driver/
3 lines

Diff 333835

clang/include/clang/Driver/Driver.h

Context not available.
LTOK_None, LTOK_None,
LTOK_Full, LTOK_Full,
LTOK_Thin, LTOK_Thin,
LTOK_Unknown LTOK_Unknown,
LTOK_Ignored
}; };
/// Driver - Encapsulate logic for constructing compilation processes /// Driver - Encapsulate logic for constructing compilation processes
Context not available.
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Allocator for string saver.
-  llvm::BumpPtrAllocator Alloc;
+    /// Set CC_PRINT_OPTIONS mode, which is like -v but logs the commands to
+    /// CCPrintOptionsFilename or to stderr.
+    unsigned CCPrintOptions : 1;
+
+    /// Set CC_PRINT_HEADERS mode, which causes the frontend to log header
+    /// include information to CCPrintHeadersFilename or to stderr.
+    unsigned CCPrintHeaders : 1;
+

22 diff lines are omitted. See full path.

Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Allocator for string saver. - llvm…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Whether the driver should invoke flang for fortran inputs.
-  /// Other modes fall back to calling gcc which in turn calls gfortran.
-  bool IsFlangMode() const { return Mode == FlangMode; }
+    /// The file to log CC_PRINT_HEADERS output to, if enabled.
+    std::string CCPrintHeadersFilename;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Whether the driver should invoke flang for…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Only print tool bindings, don't build any jobs.
-  unsigned CCCPrintBindings : 1;
+    /// The file to log CC_LOG_DIAGNOSTICS output to, if enabled.
+    std::string CCLogDiagnosticsFilename;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Only print tool bindings, don't build any…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Set CC_PRINT_OPTIONS mode, which is like -v but logs the commands to
-  /// CCPrintOptionsFilename or to stderr.
-  unsigned CCPrintOptions : 1;
-
-  /// Set CC_PRINT_HEADERS mode, which causes the frontend to log header include
-  /// information to CCPrintHeadersFilename or to stderr.
-  unsigned CCPrintHeaders : 1;
-
-  /// Set CC_LOG_DIAGNOSTICS mode, which causes the frontend to log diagnostics
-  /// to CCLogDiagnosticsFilename or to stderr, in a stable machine readable

5 diff lines are omitted. See full path.

Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Set CC_PRINT_OPTIONS mode, which is like -v…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Whether the driver is generating diagnostics for debugging purposes.
-  unsigned CCGenDiagnostics : 1;
+    /// Whether the driver should follow g++ like behavior.
+    bool CCCIsCXX() const { return Mode == GXXMode; }
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Whether the driver is generating diagnostics…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Set CC_PRINT_PROC_STAT mode, which causes the driver to dump
-  /// performance report to CC_PRINT_PROC_STAT_FILE or to stdout.
-  unsigned CCPrintProcessStats : 1;
+    /// Whether the driver is just the preprocessor.
+    bool CCCIsCPP() const { return Mode == CPPMode; }
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Set CC_PRINT_PROC_STAT mode, which causes the…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Pointer to the ExecuteCC1Tool function, if available.
-  /// When the clangDriver lib is used through clang.exe, this provides a
-  /// shortcut for executing the -cc1 command-line directly, in the same
-  /// process.
-  typedef int (*CC1ToolFunc)(SmallVectorImpl<const char *> &ArgV);
-  CC1ToolFunc CC1Main = nullptr;
+    /// Whether the driver should follow gcc like behavior.
+    bool CCCIsCC() const { return Mode == GCCMode; }
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Pointer to the ExecuteCC1Tool function, if…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-private:
-  /// Raw target triple.
-  std::string TargetTriple;
+    /// Whether the driver should follow cl.exe like behavior.
+    bool IsCLMode() const { return Mode == CLMode; }
Lint: Pre-merge checks: clang-format: please reformat the code ``` -private: - /// Raw target triple. - std::string…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Name to use when invoking gcc/g++.
-  std::string CCCGenericGCCName;
+    /// Whether the driver should invoke flang for fortran inputs.
+    /// Other modes fall back to calling gcc which in turn calls gfortran.
+    bool IsFlangMode() const { return Mode == FlangMode; }
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Name to use when invoking gcc/g++. - std…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Name of configuration file if used.
-  std::string ConfigFile;
+    /// Only print tool bindings, don't build any jobs.
+    unsigned CCCPrintBindings : 1;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Name of configuration file if used. - std…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Object that stores strings read from configuration file.
-  llvm::StringSaver Saver;
+    /// Name to use when invoking gcc/g++.
+    std::string CCCGenericGCCName;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Object that stores strings read from…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Whether the driver should follow gcc like behavior.
-  bool CCCIsCC() const { return Mode == GCCMode; }
+    /// The file to log CC_PRINT_PROC_STAT_FILE output to, if enabled.
+    std::string CCPrintStatReportFilename;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Whether the driver should follow gcc like…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Arguments originated from configuration file.
-  std::unique_ptr<llvm::opt::InputArgList> CfgOptions;
+    /// Name of configuration file if used.
+    std::string ConfigFile;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Arguments originated from configuration file.
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Arguments originated from command line.
-  std::unique_ptr<llvm::opt::InputArgList> CLOptions;
+    /// Allocator for string saver.
+    llvm::BumpPtrAllocator Alloc;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Arguments originated from command line.
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Whether to check that input files exist when constructing compilation
-  /// jobs.
-  unsigned CheckInputsExist : 1;
+    /// Object that stores strings read from configuration file.
+    llvm::StringSaver Saver;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Whether to check that input files exist when…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-public:
-  /// Force clang to emit reproducer for driver invocation. This is enabled
-  /// indirectly by setting FORCE_CLANG_DIAGNOSTICS_CRASH environment variable
-  /// or when using the -gen-reproducer driver flag.
-  unsigned GenReproducer : 1;
+    /// Arguments originated from configuration file.
+    std::unique_ptr<llvm::opt::InputArgList> CfgOptions;
Lint: Pre-merge checks: clang-format: please reformat the code ``` -public: - /// Force clang to emit reproducer for…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-private:
-  /// Certain options suppress the 'no input files' warning.
-  unsigned SuppressMissingInputWarning : 1;
+    /// Arguments originated from command line.
+    std::unique_ptr<llvm::opt::InputArgList> CLOptions;
Lint: Pre-merge checks: clang-format: please reformat the code ``` -private: - /// Certain options suppress the 'no…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Cache of all the ToolChains in use by the driver.
-  ///
-  /// This maps from the string representation of a triple to a ToolChain
-  /// created targeting that triple. The driver owns all the ToolChain objects
-  /// stored in it, and will clean them up when torn down.
-  mutable llvm::StringMap<std::unique_ptr<ToolChain>> ToolChains;
+    /// Whether to check that input files exist when constructing compilation
+    /// jobs.
+    unsigned CheckInputsExist : 1;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Cache of all the ToolChains in use by the…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-private:
-  /// TranslateInputArgs - Create a new derived argument list from the input
-  /// arguments, after applying the standard argument translations.
-  llvm::opt::DerivedArgList *
-  TranslateInputArgs(const llvm::opt::InputArgList &Args) const;
+  public:
+    /// Force clang to emit reproducer for driver invocation. This is enabled
+    /// indirectly by setting FORCE_CLANG_DIAGNOSTICS_CRASH environment variable
+    /// or when using the -gen-reproducer driver flag.
+    unsigned GenReproducer : 1;
Lint: Pre-merge checks: clang-format: please reformat the code ``` -private: - /// TranslateInputArgs - Create a new…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  // getFinalPhase - Determine which compilation mode we are in and record
-  // which option we used to determine the final phase.
-  // TODO: Much of what getFinalPhase returns are not actually true compiler
-  //       modes. Fold this functionality into Types::getCompilationPhases and
-  //       handleArguments.
-  phases::ID getFinalPhase(const llvm::opt::DerivedArgList &DAL,
-                           llvm::opt::Arg **FinalPhaseArg = nullptr) const;
+  private:
+    /// Certain options suppress the 'no input files' warning.
+    unsigned SuppressMissingInputWarning : 1;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - // getFinalPhase - Determine which compilation…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  // handleArguments - All code related to claiming and printing diagnostics
-  // related to arguments to the driver are done here.
-  void handleArguments(Compilation &C, llvm::opt::DerivedArgList &Args,
-                       const InputList &Inputs, ActionList &Actions) const;
+    /// Cache of all the ToolChains in use by the driver.
+    ///
+    /// This maps from the string representation of a triple to a ToolChain
+    /// created targeting that triple. The driver owns all the ToolChain objects
+    /// stored in it, and will clean them up when torn down.
+    mutable llvm::StringMap<std::unique_ptr<ToolChain>> ToolChains;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - // handleArguments - All code related to claiming…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  // Before executing jobs, sets up response files for commands that need them.
-  void setUpResponseFiles(Compilation &C, Command &Cmd);
+  private:
+    /// TranslateInputArgs - Create a new derived argument list from the input
+    /// arguments, after applying the standard argument translations.
+    llvm::opt::DerivedArgList *
+    TranslateInputArgs(const llvm::opt::InputArgList &Args) const;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - // Before executing jobs, sets up response files…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Whether the driver should follow cl.exe like behavior.
-  bool IsCLMode() const { return Mode == CLMode; }
+    /// The file to log CC_PRINT_OPTIONS output to, if enabled.
+    std::string CCPrintOptionsFilename;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Whether the driver should follow cl.exe like…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Whether the driver is just the preprocessor.
-  bool CCCIsCPP() const { return Mode == CPPMode; }
+    /// Information about the host which can be overridden by the user.
+    std::string HostBits, HostMachine, HostSystem, HostRelease;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Whether the driver is just the preprocessor.
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-    /// The LLVM OpenMP runtime. When completed and integrated, this will become
-    /// the default for Clang.
-    OMPRT_OMP,
+  /// Driver - Encapsulate logic for constructing compilation processes
+  /// from a set of gcc-driver-like command line arguments.
+  class Driver {
+    DiagnosticsEngine &Diags;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// The LLVM OpenMP runtime. When completed and…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// System directory for config files.
-  std::string SystemConfigDir;
+    // Diag - Forwarding function for diagnostics.
+    DiagnosticBuilder Diag(unsigned DiagID) const {
+      return Diags.Report(DiagID);
+    }
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// System directory for config files. - std…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-    /// The GNU OpenMP runtime. Clang doesn't support generating OpenMP code for
-    /// this runtime but can swallow the pragmas, and find and link against the
-    /// runtime library itself.
-    OMPRT_GOMP,
+    IntrusiveRefCntPtr<llvm::vfs::FileSystem> VFS;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// The GNU OpenMP runtime. Clang doesn't…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-    /// The legacy name for the LLVM OpenMP runtime from when it was the Intel
-    /// OpenMP runtime. We support this mode for users with existing
-    /// dependencies on this runtime library name.
-    OMPRT_IOMP5
-  };
+    enum DriverMode { GCCMode, GXXMode, CPPMode, CLMode, FlangMode } Mode;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// The legacy name for the LLVM OpenMP runtime…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  // Diag - Forwarding function for diagnostics.
-  DiagnosticBuilder Diag(unsigned DiagID) const {
-    return Diags.Report(DiagID);
-  }
+    enum SaveTempsMode { SaveTempsNone, SaveTempsCwd, SaveTempsObj } SaveTemps;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - // Diag - Forwarding function for diagnostics.
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  // FIXME: Privatize once interface is stable.
-public:
-  /// The name the driver was invoked as.
-  std::string Name;
+    enum BitcodeEmbedMode { EmbedNone, EmbedMarker, EmbedBitcode } BitcodeEmbed;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - // FIXME: Privatize once interface is stable.
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// The path the driver executable was in, as invoked from the
-  /// command line.
-  std::string Dir;
+    /// LTO mode selected via -f(no-)?lto(=.*)? options.
+    LTOKind LTOMode;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// The path the driver executable was in, as…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// The original path to the clang executable.
-  std::string ClangExecutable;
+  public:
+    enum OpenMPRuntimeKind {
+      /// An unknown OpenMP runtime. We can't generate effective OpenMP code
+      /// without knowing what runtime to target.
+      OMPRT_Unknown,
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// The original path to the clang executable.
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Target and driver mode components extracted from clang executable name.
-  ParsedClangName ClangNameParts;
+      /// The LLVM OpenMP runtime. When completed and integrated, this will
+      /// become
+      /// the default for Clang.
+      OMPRT_OMP,
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Target and driver mode components extracted…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// The path to the installed clang directory, if any.
-  std::string InstalledDir;
+      /// The GNU OpenMP runtime. Clang doesn't support generating OpenMP code
+      /// for
+      /// this runtime but can swallow the pragmas, and find and link against
+      /// the
+      /// runtime library itself.
+      OMPRT_GOMP,
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// The path to the installed clang directory, if…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// The path to the compiler resource directory.
-  std::string ResourceDir;
+      /// The legacy name for the LLVM OpenMP runtime from when it was the Intel
+      /// OpenMP runtime. We support this mode for users with existing
+      /// dependencies on this runtime library name.
+      OMPRT_IOMP5
+    };
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// The path to the compiler resource directory.
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// User directory for config files.
-  std::string UserConfigDir;
+    // FIXME: Privatize once interface is stable.
+  public:
+    /// The name the driver was invoked as.
+    std::string Name;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// User directory for config files. - std…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Whether the driver should follow g++ like behavior.
-  bool CCCIsCXX() const { return Mode == GXXMode; }
+    /// Driver title to use with help.
+    std::string DriverTitle;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Whether the driver should follow g++ like…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// A prefix directory used to emulate a limited subset of GCC's '-Bprefix'
-  /// functionality.
-  /// FIXME: This type of customization should be removed in favor of the
-  /// universal driver when it is ready.
-  typedef SmallVector<std::string, 4> prefix_list;
-  prefix_list PrefixDirs;
+    /// The path the driver executable was in, as invoked from the
+    /// command line.
+    std::string Dir;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// A prefix directory used to emulate a limited…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// sysroot, if present
-  std::string SysRoot;
+    /// The original path to the clang executable.
+    std::string ClangExecutable;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// sysroot, if present - std::string SysRoot; +…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Dynamic loader prefix, if present
-  std::string DyldPrefix;
+    /// Target and driver mode components extracted from clang executable name.
+    ParsedClangName ClangNameParts;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Dynamic loader prefix, if present - std…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Driver title to use with help.
-  std::string DriverTitle;
+    /// The path to the installed clang directory, if any.
+    std::string InstalledDir;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Driver title to use with help. - std::string…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// Information about the host which can be overridden by the user.
-  std::string HostBits, HostMachine, HostSystem, HostRelease;
+    /// The path to the compiler resource directory.
+    std::string ResourceDir;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// Information about the host which can be…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// The file to log CC_PRINT_PROC_STAT_FILE output to, if enabled.
-  std::string CCPrintStatReportFilename;
+    /// System directory for config files.
+    std::string SystemConfigDir;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// The file to log CC_PRINT_PROC_STAT_FILE…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// The file to log CC_PRINT_OPTIONS output to, if enabled.
-  std::string CCPrintOptionsFilename;
+    /// User directory for config files.
+    std::string UserConfigDir;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// The file to log CC_PRINT_OPTIONS output to…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// The file to log CC_PRINT_HEADERS output to, if enabled.
-  std::string CCPrintHeadersFilename;
+    /// A prefix directory used to emulate a limited subset of GCC's '-Bprefix'
+    /// functionality.
+    /// FIXME: This type of customization should be removed in favor of the
+    /// universal driver when it is ready.
+    typedef SmallVector<std::string, 4> prefix_list;
+    prefix_list PrefixDirs;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// The file to log CC_PRINT_HEADERS output to…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// The file to log CC_LOG_DIAGNOSTICS output to, if enabled.
-  std::string CCLogDiagnosticsFilename;
+    /// sysroot, if present
+    std::string SysRoot;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// The file to log CC_LOG_DIAGNOSTICS output to…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  /// A list of inputs and their types for the given arguments.
-  typedef SmallVector<std::pair<types::ID, const llvm::opt::Arg *>, 16>
-      InputList;
+    /// Dynamic loader prefix, if present
+    std::string DyldPrefix;
Lint: Pre-merge checks: clang-format: please reformat the code ``` - /// A list of inputs and their types for the…
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-  void generatePrefixedToolNames(StringRef Tool, const ToolChain &TC,
-                                 SmallVectorImpl<std::string> &Names) const;
-
-  /// Find the appropriate .crash diagonostic file for the child crash
-  /// under this driver and copy it out to a temporary destination with the
-  /// other reproducer related files (.sh, .cache, etc). If not found, suggest a
-  /// directory for the user to look at.
-  ///
-  /// \param ReproCrashFilename The file path to copy the .crash to.
-  /// \param CrashDiagDir       The suggested directory for the user to look at

707 diff lines are omitted. See full path.

Lint: Pre-merge checks: clang-format: please reformat the code ``` - void generatePrefixedToolNames(StringRef Tool…

clang/lib/Driver/Driver.cpp

Context not available.
LTOMode = llvm::StringSwitch<LTOKind>(LTOName) LTOMode = llvm::StringSwitch<LTOKind>(LTOName)
.Case("full", LTOK_Full) .Case("full", LTOK_Full)
.Case("thin", LTOK_Thin) .Case("thin", LTOK_Thin)
.Case("auto", LTOK_Ignored)
.Case("jobserver", LTOK_Ignored)
.Default(LTOK_Unknown); .Default(LTOK_Unknown);
if (LTOMode == LTOK_Unknown) { if (LTOMode == LTOK_Unknown) {
// FIXME: check if argument is a number, then ignore, or handle it
assert(A); assert(A);
Diag(diag::err_drv_unsupported_option_argument) << A->getOption().getName() Diag(diag::err_drv_unsupported_option_argument) << A->getOption().getName()
<< A->getValue(); << A->getValue();
Context not available.