Page MenuHomePhabricator

inglorion (Bob Haarman)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 15 2015, 10:55 AM (175 w, 22 h)

Recent Activity

Mon, Apr 22

inglorion committed rG2eea99a4b982: [Support] unflake TempFileCollisions test (authored by inglorion).
[Support] unflake TempFileCollisions test
Mon, Apr 22, 12:45 PM
inglorion committed rL358914: [Support] unflake TempFileCollisions test.
[Support] unflake TempFileCollisions test
Mon, Apr 22, 12:44 PM
inglorion closed D56336: [Support] unflake TempFileCollisions test.
Mon, Apr 22, 12:44 PM · Restricted Project

Thu, Apr 18

inglorion added a comment to D56336: [Support] unflake TempFileCollisions test.

Does this look good now?

Thu, Apr 18, 1:00 PM · Restricted Project

Mon, Apr 15

inglorion committed rG8b1ec798b562: [LLD][COFF] use offset in archive to disambiguate archive members (authored by inglorion).
[LLD][COFF] use offset in archive to disambiguate archive members
Mon, Apr 15, 12:47 PM
inglorion committed rL358440: [LLD][COFF] use offset in archive to disambiguate archive members.
[LLD][COFF] use offset in archive to disambiguate archive members
Mon, Apr 15, 12:46 PM
inglorion committed rLLD358440: [LLD][COFF] use offset in archive to disambiguate archive members.
[LLD][COFF] use offset in archive to disambiguate archive members
Mon, Apr 15, 12:46 PM
inglorion closed D60549: [LLD][COFF] use offset in archive to disambiguate archive members.
Mon, Apr 15, 12:46 PM · Restricted Project

Thu, Apr 11

inglorion added inline comments to D60549: [LLD][COFF] use offset in archive to disambiguate archive members.
Thu, Apr 11, 2:27 PM · Restricted Project
inglorion updated the diff for D60549: [LLD][COFF] use offset in archive to disambiguate archive members.

without second constructor

Thu, Apr 11, 2:24 PM · Restricted Project

Wed, Apr 10

inglorion created D60549: [LLD][COFF] use offset in archive to disambiguate archive members.
Wed, Apr 10, 5:33 PM · Restricted Project

Tue, Apr 9

inglorion updated the diff for D56336: [Support] unflake TempFileCollisions test.

Updated as suggested by @rsmith (thanks!)

Tue, Apr 9, 5:19 PM · Restricted Project

Thu, Apr 4

inglorion closed D60159: Revert "[DAGCombine] Improve Lifetime node chains." and follow-ups.
Thu, Apr 4, 11:51 AM · Restricted Project

Tue, Apr 2

inglorion created D60159: Revert "[DAGCombine] Improve Lifetime node chains." and follow-ups.
Tue, Apr 2, 3:39 PM · Restricted Project

Feb 19 2019

inglorion committed rG61e8735f17fd: [lld-link] preserve @llvm.used symbols in LTO (authored by inglorion).
[lld-link] preserve @llvm.used symbols in LTO
Feb 19 2019, 4:26 PM
inglorion committed rLLD354410: [lld-link] preserve @llvm.used symbols in LTO.
[lld-link] preserve @llvm.used symbols in LTO
Feb 19 2019, 4:25 PM
inglorion committed rL354410: [lld-link] preserve @llvm.used symbols in LTO.
[lld-link] preserve @llvm.used symbols in LTO
Feb 19 2019, 4:25 PM
inglorion closed D58255: [lld-link] preserve @llvm.used symbols in LTO.
Feb 19 2019, 4:25 PM · Restricted Project
inglorion added inline comments to D58255: [lld-link] preserve @llvm.used symbols in LTO.
Feb 19 2019, 2:36 PM · Restricted Project

Feb 14 2019

inglorion created D58255: [lld-link] preserve @llvm.used symbols in LTO.
Feb 14 2019, 3:04 PM · Restricted Project

Feb 8 2019

inglorion committed rG3edf63c55a1e: [lld-link] better error message when failing to open archive members (authored by inglorion).
[lld-link] better error message when failing to open archive members
Feb 8 2019, 2:02 PM
inglorion committed rLLD353572: [lld-link] better error message when failing to open archive members.
[lld-link] better error message when failing to open archive members
Feb 8 2019, 2:00 PM
inglorion committed rL353572: [lld-link] better error message when failing to open archive members.
[lld-link] better error message when failing to open archive members
Feb 8 2019, 1:59 PM
inglorion closed D57974: [lld-link] better error message when failing to open archive members.
Feb 8 2019, 1:59 PM · Restricted Project
inglorion added inline comments to D57974: [lld-link] better error message when failing to open archive members.
Feb 8 2019, 1:52 PM · Restricted Project
inglorion updated the diff for D57974: [lld-link] better error message when failing to open archive members.

Use [=] instead of explicitly passing StringRefs to ReportBufferError.

Feb 8 2019, 1:52 PM · Restricted Project
inglorion added a comment to D57974: [lld-link] better error message when failing to open archive members.

(Following the same archive(member) format also used by toString() in InputFiles.cpp)

Feb 8 2019, 1:39 PM · Restricted Project
inglorion added a comment to D57974: [lld-link] better error message when failing to open archive members.

Before:

lld-link: error: could not get the buffer for the member defining symbol spvDiagnosticDestroy: No such file or directory
Feb 8 2019, 1:37 PM · Restricted Project
inglorion created D57974: [lld-link] better error message when failing to open archive members.
Feb 8 2019, 1:37 PM · Restricted Project

Feb 7 2019

inglorion accepted D57844: Handle CalledProcessError without a Python stack.

LGTM

Feb 7 2019, 11:08 AM · Restricted Project
inglorion requested changes to D57844: Handle CalledProcessError without a Python stack.

See earlier comment.

Feb 7 2019, 10:14 AM · Restricted Project

Feb 6 2019

inglorion added inline comments to D57844: Handle CalledProcessError without a Python stack.
Feb 6 2019, 3:16 PM · Restricted Project

Jan 30 2019

inglorion accepted D57395: [ThinLTO] Rename COMDATs for COFF when promoting/renaming COMDAT leader.

lgtm, thanks!

Jan 30 2019, 5:07 PM

Jan 29 2019

inglorion accepted D57414: Switch sanitizer-windows bot to annotator scripts.

LGTM, with some suggestions in the comments.

Jan 29 2019, 3:23 PM

Jan 24 2019

inglorion committed rL352142: simplify COFF module assembly test and move it to Object.
simplify COFF module assembly test and move it to Object
Jan 24 2019, 4:34 PM
inglorion closed D57192: simplify COFF module assembly test and move it to Object.
Jan 24 2019, 4:33 PM
inglorion added a comment to D57192: simplify COFF module assembly test and move it to Object.

Thank you!

Jan 24 2019, 4:33 PM
inglorion updated the diff for D57192: simplify COFF module assembly test and move it to Object.

Re-upload only the test change.

Jan 24 2019, 4:03 PM
inglorion updated the diff for D57192: simplify COFF module assembly test and move it to Object.

Simpler test. This crashes without D57073 and passes with D57073.

Jan 24 2019, 4:03 PM
inglorion added inline comments to D57192: simplify COFF module assembly test and move it to Object.
Jan 24 2019, 3:23 PM
inglorion added a comment to D57073: allow COFF .def directive in module assembly when using ThinLTO.

pcc, does D57192 implement your suggestion?

Jan 24 2019, 2:09 PM
inglorion created D57192: simplify COFF module assembly test and move it to Object.
Jan 24 2019, 2:08 PM
inglorion added a comment to D57073: allow COFF .def directive in module assembly when using ThinLTO.

Just saw your comment, pcc. I'll look into that.

Jan 24 2019, 1:50 PM
inglorion committed rL352112: allow COFF .def directive in module assembly when using ThinLTO.
allow COFF .def directive in module assembly when using ThinLTO
Jan 24 2019, 1:41 PM
inglorion closed D57073: allow COFF .def directive in module assembly when using ThinLTO.
Jan 24 2019, 1:41 PM

Jan 23 2019

inglorion updated the diff for D57073: allow COFF .def directive in module assembly when using ThinLTO.

add missing .1

Jan 23 2019, 4:48 PM
inglorion updated the diff for D57073: allow COFF .def directive in module assembly when using ThinLTO.

replaced .c test with an .ll test

Jan 23 2019, 1:19 PM

Jan 22 2019

inglorion created D57073: allow COFF .def directive in module assembly when using ThinLTO.
Jan 22 2019, 5:17 PM

Jan 4 2019

inglorion added a comment to D50126: [Support] fix TempFile infinite loop and permission denied errors.

@fedor.sergeev: You're right, thanks for pointing that out. Sent D56336 to fix that.

Jan 4 2019, 2:38 PM
inglorion created D56336: [Support] unflake TempFileCollisions test.
Jan 4 2019, 2:37 PM · Restricted Project

Sep 14 2018

inglorion added a comment to D51992: [ThinLTO]Expose cache entry expiration time option in llvm-lto and fix a test.

Thanks! For the case where you don't want the files to expire, can you instead set the expiration age to 0? That should stop the pruner from removing them.

Sep 14 2018, 2:52 PM
inglorion accepted D51746: Replace clang-x86-windows-msvc2015 with an x64 VS 2017 build script.

LGTM

Sep 14 2018, 2:47 PM

Sep 6 2018

inglorion added a comment to D51720: [COFF] don't mark lazy symbols as used in regular objects.

I was thinking that as well, and it did fix the size regression: from 151,548,928 to 141,140,992 bytes, where the non-LTO version is 140,072,960 bytes.

Sep 6 2018, 3:22 PM
inglorion committed rLLD341585: [COFF] don't mark lazy symbols as used in regular objects.
[COFF] don't mark lazy symbols as used in regular objects
Sep 6 2018, 1:30 PM
inglorion committed rL341585: [COFF] don't mark lazy symbols as used in regular objects.
[COFF] don't mark lazy symbols as used in regular objects
Sep 6 2018, 1:25 PM
inglorion closed D51720: [COFF] don't mark lazy symbols as used in regular objects.
Sep 6 2018, 1:25 PM
inglorion added a comment to D51720: [COFF] don't mark lazy symbols as used in regular objects.

Since r338767, "foo,p" and "bar,p" show up as "foo,px" and "bar,px", indicating that they are used in regular objects. However, there are no regular (non-LTO) objects in the test. Only main should have the 'x'.

Sep 6 2018, 12:11 PM
inglorion updated the diff for D51720: [COFF] don't mark lazy symbols as used in regular objects.

added test

Sep 6 2018, 12:09 PM
inglorion added a comment to D51720: [COFF] don't mark lazy symbols as used in regular objects.

Building Chromium with ThinLTO without this patch causes test_chrome_with_chromedriver.py to fail. With the patch, it runs successfully. (https://crbug.com/881036).

Sep 6 2018, 1:03 AM
inglorion created D51720: [COFF] don't mark lazy symbols as used in regular objects.
Sep 6 2018, 1:01 AM

Aug 24 2018

inglorion abandoned D46621: [Support] call FlushFileBuffers when closing raw_fd_ostream on Windows.

We don't need this. Abandoning.

Aug 24 2018, 1:48 PM

Aug 23 2018

inglorion added a comment to D48738: Add the ability to edit stream contents with llvm-pdbutil.

This is really useful. Thanks for doing this. I got a couple of questions and comments in-line.

Aug 23 2018, 4:25 PM

Aug 21 2018

inglorion committed rLLD340374: [Support][CachePruning] prune least recently accessed files first.
[Support][CachePruning] prune least recently accessed files first
Aug 21 2018, 5:53 PM
inglorion committed rL340374: [Support][CachePruning] prune least recently accessed files first.
[Support][CachePruning] prune least recently accessed files first
Aug 21 2018, 5:53 PM
inglorion closed D51062: [Support][CachePruning] prune least recently accessed files first.
Aug 21 2018, 5:53 PM
inglorion updated the diff for D51062: [Support][CachePruning] prune least recently accessed files first.

update llvm/test/ThinLTO/X86/cache.ll to match the new expectations

Aug 21 2018, 5:29 PM
inglorion created D51062: [Support][CachePruning] prune least recently accessed files first.
Aug 21 2018, 1:59 PM

Aug 20 2018

inglorion added a comment to D51006: LTO: make tempfiles in LTO cache subject to pruning.

Do you know why the temporary files are being left on disk? I wouldn't have expected that to happen because they are being created with delete-on-close.

Aug 20 2018, 4:11 PM
inglorion created D51006: LTO: make tempfiles in LTO cache subject to pruning.
Aug 20 2018, 3:34 PM

Aug 16 2018

inglorion added inline comments to D50877: [MS] Mangle a hash of the main file path into anonymous namespaces.
Aug 16 2018, 5:48 PM

Aug 2 2018

inglorion added a comment to D50126: [Support] fix TempFile infinite loop and permission denied errors.

Comment changed in rL338755.

Aug 2 2018, 11:28 AM
inglorion committed rL338755: [Support] [NFC] change comment about retries in createUniqueEntity.
[Support] [NFC] change comment about retries in createUniqueEntity
Aug 2 2018, 11:28 AM
inglorion added a comment to D50126: [Support] fix TempFile infinite loop and permission denied errors.

Sorry, Peter. Saw your reply after I had already pushed the change. Would:

Aug 2 2018, 11:18 AM
inglorion committed rL338745: [Support] fix TempFile infinite loop and permission denied errors.
[Support] fix TempFile infinite loop and permission denied errors
Aug 2 2018, 10:42 AM
inglorion closed D50126: [Support] fix TempFile infinite loop and permission denied errors.
Aug 2 2018, 10:42 AM
inglorion added a comment to D50127: [Support] use larger character set for creating unique filenames.

https://bugs.chromium.org/p/chromium/issues/detail?id=856635#c10 sounds like we only saw this if the pattern was made smaller. Are we sure this change fixes an actual problem?

Aug 2 2018, 10:37 AM
inglorion added a comment to D50126: [Support] fix TempFile infinite loop and permission denied errors.

Is this good to go?

Aug 2 2018, 10:31 AM

Aug 1 2018

inglorion updated the summary of D50127: [Support] use larger character set for creating unique filenames.
Aug 1 2018, 1:16 PM
inglorion updated the diff for D50127: [Support] use larger character set for creating unique filenames.

Use 36-character set instead of 32-character set, per @zturner's suggestion.

Aug 1 2018, 1:15 PM
inglorion added a comment to D50127: [Support] use larger character set for creating unique filenames.

Yeah. On top of the cost of getting a number from the cryptographically secure random number generator, I don't think using mod instead of and will cost that much. I'll make the change. We could add a few more characters ("-_@", probably others), but I think digits+letters is already a good improvement to what we currently have, without having to worry about file systems not liking some characters.

Aug 1 2018, 11:27 AM

Jul 31 2018

inglorion added a comment to D50126: [Support] fix TempFile infinite loop and permission denied errors.

This diff fixes a problem where, on Windows, TempFile::create() would immediately fail when the same name is tried again before the first file with that name is gone. That makes collisions less of an issue, because we can actually use more of the available names before we give up. It also fixes a problem where trying to create a tempfile when all available names are taken would lead to an infinite loop.

Jul 31 2018, 8:48 PM
inglorion added a comment to D50126: [Support] fix TempFile infinite loop and permission denied errors.

@zturner, the models we use here are 6 characters. Chosen from a set of 16 characters gives 16M possibilities. Randomly generating them gives a 50%+ probability of a collision after 5000 names or so. I have another patch up (D50127) to use a 32-character set instead, which means the same 6 character model gives about a billion possible names and you need to generate about 40,000 of them before you have a 50% probability of a collision.

Jul 31 2018, 8:44 PM
inglorion added a comment to D50127: [Support] use larger character set for creating unique filenames.

The inspiration for this is http://crbug.com/856635, where we're seeing the same file name generated multiple times during a single run.

Jul 31 2018, 8:25 PM
inglorion added a parent revision for D50127: [Support] use larger character set for creating unique filenames: D50126: [Support] fix TempFile infinite loop and permission denied errors.
Jul 31 2018, 8:17 PM
inglorion added a child revision for D50126: [Support] fix TempFile infinite loop and permission denied errors: D50127: [Support] use larger character set for creating unique filenames.
Jul 31 2018, 8:17 PM
inglorion created D50127: [Support] use larger character set for creating unique filenames.
Jul 31 2018, 8:16 PM
inglorion created D50126: [Support] fix TempFile infinite loop and permission denied errors.
Jul 31 2018, 7:24 PM

Jul 26 2018

inglorion committed rL338100: [LTO] Don't internalize declarations.
[LTO] Don't internalize declarations
Jul 26 2018, 10:41 PM
inglorion closed D49777: [LTO] Don't internalize declarations.
Jul 26 2018, 10:41 PM
inglorion updated the diff for D49777: [LTO] Don't internalize declarations.

fixed comment

Jul 26 2018, 7:09 PM
inglorion updated the diff for D49777: [LTO] Don't internalize declarations.

put error message check back in

Jul 26 2018, 7:08 PM
inglorion added a comment to D49777: [LTO] Don't internalize declarations.

Hmm, seems like I lost checking the error message along the way.

Jul 26 2018, 7:03 PM
inglorion updated the diff for D49777: [LTO] Don't internalize declarations.

Per @pcc's suggestions:

Jul 26 2018, 7:02 PM

Jul 25 2018

inglorion updated the diff for D49777: [LTO] Don't internalize declarations.

check for error message in test

Jul 25 2018, 4:39 PM
inglorion added a comment to D49777: [LTO] Don't internalize declarations.

Ah, just saw your comment about adding a check. Yes, I was checking that llvm-dis succeeds; I'll check for the error message instead to make it clearer what we're testing.

Jul 25 2018, 4:34 PM
inglorion updated the diff for D49777: [LTO] Don't internalize declarations.

Thanks, @tejohnson! I made the test case smaller.

Jul 25 2018, 4:26 PM
inglorion added a comment to D49777: [LTO] Don't internalize declarations.
but declarations cannot be internal.

Do you mean that the IR verifier would fail?

Jul 25 2018, 4:25 PM

Jul 24 2018

inglorion created D49777: [LTO] Don't internalize declarations.
Jul 24 2018, 10:54 PM

Jul 17 2018

inglorion committed rL337344: Revert "[InstCombine] Fold 'check for [no] signed truncation' pattern".
Revert "[InstCombine] Fold 'check for [no] signed truncation' pattern"
Jul 17 2018, 7:23 PM

Jul 9 2018

inglorion committed rC336604: Added -fcrash-diagnostics-dir flag.
Added -fcrash-diagnostics-dir flag
Jul 9 2018, 2:12 PM