[Matrix] Implement += and -= for Matrix Type.
Bugzilla ticket is here https://bugs.llvm.org/show_bug.cgi?id=46164
Paths
| Differential D98075
[Matrix] Implement += and -= for MatrixType ClosedPublic Authored by SaurabhJha on Mar 5 2021, 1:12 PM.
Details Summary [Matrix] Implement += and -= for Matrix Type. Bugzilla ticket is here https://bugs.llvm.org/show_bug.cgi?id=46164
Diff Detail
Event TimelineComment Actions Thanks for the patch! Could you also extend the Sema matrix-type-operators tests with checks for += & -=? It looks like the handling for multiply is slightly different and already works but is missing test coverage. It would be great if you could also extend the tests to check for *=. Comment Actions Implement tests for *= for matrices code gen and add tests in Sema for compound assignments Comment Actions
Thanks for the review. I have addressed your comments. We don't need to add anything to CodeGenCXX/matrix-type-operators.cpp and SemaCXX/matrix-type-operators.cpp, right?
This revision is now accepted and ready to land.Mar 7 2021, 4:49 AM Closed by commit rG63851a701eac: [Matrix] Implement += and -= for MatrixType. (authored by SaurabhJha, committed by fhahn). · Explain WhyMar 8 2021, 1:32 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 328849 clang/lib/Sema/SemaExpr.cpp
clang/test/CodeGen/matrix-type-operators.c
clang/test/Sema/matrix-type-operators.c
|
+=?