This is an archive of the discontinued LLVM Phabricator instance.

[SYCL] Ignore file-scope asm during device-side SYCL compilation.
ClosedPublic

Authored by ArturGainullin on Feb 11 2021, 12:59 PM.

Download Raw Diff

Details

Reviewers

bader
eandrews

Commits

rGff50b121e336: [SYCL] Ignore file-scope asm during device-side SYCL compilation.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed

	Time	Test
	270 ms	x64 debian > MemProfiler-x86_64-linux-dynamic.TestCases::test_malloc_load_store.c
	430 ms	x64 debian > MemProfiler-x86_64-linux.TestCases::test_malloc_load_store.c
	2,290 ms	x64 debian > libarcher.races::task-two.c

Event Timeline

ArturGainullin created this revision.Feb 11 2021, 12:59 PM

Herald added subscribers: Anastasia, ebevhan, yaxunl. · View Herald TranscriptFeb 11 2021, 12:59 PM

ArturGainullin requested review of this revision.Feb 11 2021, 12:59 PM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2021, 12:59 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Harbormaster completed remote builds in B88878: Diff 323121.Feb 11 2021, 7:45 PM

LGTM. Thanks.

This revision is now accepted and ready to land.Feb 11 2021, 9:47 PM

LGTM Thanks!

Rebase for retesting.

Harbormaster completed remote builds in B89057: Diff 323456.Feb 12 2021, 4:47 PM

This revision was landed with ongoing or failed builds.Feb 12 2021, 5:01 PM

Closed by commit rGff50b121e336: [SYCL] Ignore file-scope asm during device-side SYCL compilation. (authored by ArturGainullin). · Explain Why

This revision was automatically updated to reflect the committed changes.

ArturGainullin added a commit: rGff50b121e336: [SYCL] Ignore file-scope asm during device-side SYCL compilation..

Revision Contents

Path

Size

clang/

lib/

CodeGen/

CodeGenModule.cpp

3 lines

test/

CodeGenSYCL/

filescope_asm.c

6 lines

Diff 323121

clang/lib/CodeGen/CodeGenModule.cpp

//===--- CodeGenModule.cpp - Emit LLVM Code from ASTs for a Module --------===//		//===--- CodeGenModule.cpp - Emit LLVM Code from ASTs for a Module --------===//
		Lint: Lint Inline Actions clang-format not found in user's PATH; not linting file. Lint: Lint: clang-format not found in user's PATH; not linting file.
//		//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.		// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.		// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception		// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//		//
//===----------------------------------------------------------------------===//		//===----------------------------------------------------------------------===//
//		//
▲ Show 20 Lines • Show All 5,658 Lines • ▼ Show 20 Lines	void CodeGenModule::EmitTopLevelDecl(Decl *D) {

case Decl::FileScopeAsm: {		case Decl::FileScopeAsm: {
// File-scope asm is ignored during device-side CUDA compilation.		// File-scope asm is ignored during device-side CUDA compilation.
if (LangOpts.CUDA && LangOpts.CUDAIsDevice)		if (LangOpts.CUDA && LangOpts.CUDAIsDevice)
break;		break;
// File-scope asm is ignored during device-side OpenMP compilation.		// File-scope asm is ignored during device-side OpenMP compilation.
if (LangOpts.OpenMPIsDevice)		if (LangOpts.OpenMPIsDevice)
break;		break;
		// File-scope asm is ignored during device-side SYCL compilation.
		if (LangOpts.SYCLIsDevice)
		break;
auto *AD = cast<FileScopeAsmDecl>(D);		auto *AD = cast<FileScopeAsmDecl>(D);
getModule().appendModuleInlineAsm(AD->getAsmString()->getString());		getModule().appendModuleInlineAsm(AD->getAsmString()->getString());
break;		break;
}		}

case Decl::Import: {		case Decl::Import: {
auto *Import = cast<ImportDecl>(D);		auto *Import = cast<ImportDecl>(D);

▲ Show 20 Lines • Show All 567 Lines • Show Last 20 Lines

clang/test/CodeGenSYCL/filescope_asm.c

This file was added.

				// RUN: %clang_cc1 -fsycl -fsycl-is-device -triple spir64-unknown-unknown-sycldevice -emit-llvm %s -o - \| FileCheck %s
				//
				// Check that file-scope asm is ignored during device-side SYCL compilation.
				//
				// CHECK-NOT: module asm "foo"
				__asm__("foo");