Page MenuHomePhabricator

ArturGainullin (Artur Gainullin)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 23 2016, 12:26 AM (222 w, 4 d)

Recent Activity

May 30 2019

vladimirlaz <vladimir.lazarev@intel.com> committed rGc3a9615441c8: [SYCL] Fix bug in vector swizzles. (authored by ArturGainullin).
[SYCL] Fix bug in vector swizzles.
May 30 2019, 8:02 AM

May 15 2018

ArturGainullin committed rL332336: [X86] Improve unsigned saturation downconvert detection..
[X86] Improve unsigned saturation downconvert detection.
May 15 2018, 3:28 AM
ArturGainullin closed D45315: [X86] Improve unsigned saturation downconvert detection..
May 15 2018, 3:28 AM

May 14 2018

ArturGainullin updated the diff for D45315: [X86] Improve unsigned saturation downconvert detection..

Fixed according to comment.

May 14 2018, 12:40 PM
ArturGainullin added a comment to D45315: [X86] Improve unsigned saturation downconvert detection..

Simon, thanks! I agree that operands have same type. Do you think that it is better to create new node? Or the latest uploaded version where I update the operand of smax is acceptable?

May 14 2018, 7:23 AM
ArturGainullin added a comment to D45315: [X86] Improve unsigned saturation downconvert detection..

Ping.

May 14 2018, 12:55 AM

May 11 2018

ArturGainullin updated the diff for D45315: [X86] Improve unsigned saturation downconvert detection..
  • Sorry, but initially I did not understand your concern. Fixed the code, so that existing node with changed operands is returned.
May 11 2018, 2:57 AM

May 10 2018

ArturGainullin added a comment to D45315: [X86] Improve unsigned saturation downconvert detection..

Simon, could you please write if my comment is not enough and you need more details or clarification.

May 10 2018, 3:55 PM

Apr 30 2018

ArturGainullin added a comment to D45315: [X86] Improve unsigned saturation downconvert detection..

(truncate (smin (smax (x, C1), C2)) to dest_type)
is equivalent to
(truncate (umin (smax(x, C1), unsigned_max_of_dest_type)) to dest_type)
that is why I don't need to create any node and just return smax.

Apr 30 2018, 12:16 PM
ArturGainullin added a comment to D45315: [X86] Improve unsigned saturation downconvert detection..

Ping.

Apr 30 2018, 11:33 AM

Apr 24 2018

ArturGainullin added a comment to D45315: [X86] Improve unsigned saturation downconvert detection..

Ping.

Apr 24 2018, 12:35 PM

Apr 14 2018

ArturGainullin updated the diff for D45315: [X86] Improve unsigned saturation downconvert detection..
Committed the test. Rebased.
Apr 14 2018, 1:28 PM
ArturGainullin committed rL330090: [X86] Tests for unsigned saturation downconvert detection..
[X86] Tests for unsigned saturation downconvert detection.
Apr 14 2018, 1:13 PM
ArturGainullin added a comment to D45315: [X86] Improve unsigned saturation downconvert detection..

Sorry, forgot to commit one of the tests. WIll fix.

Apr 14 2018, 12:46 PM
ArturGainullin updated the diff for D45315: [X86] Improve unsigned saturation downconvert detection..
Rebased.
Apr 14 2018, 12:41 PM
ArturGainullin committed rL330088: [X86] Tests for unsigned saturation downconvert detection..
[X86] Tests for unsigned saturation downconvert detection.
Apr 14 2018, 12:12 PM

Apr 12 2018

ArturGainullin updated the summary of D45315: [X86] Improve unsigned saturation downconvert detection..
Apr 12 2018, 3:34 PM
ArturGainullin updated the summary of D45315: [X86] Improve unsigned saturation downconvert detection..
Apr 12 2018, 3:33 PM

Apr 11 2018

ArturGainullin committed rL329791: Eliminate a bitwise 'not' op of 'not' min/max by inverting the min/max..
Eliminate a bitwise 'not' op of 'not' min/max by inverting the min/max.
Apr 11 2018, 3:34 AM
ArturGainullin closed D45317: Eliminate a bitwise 'not' op of 'not' min/max by inverting the min/max..
Apr 11 2018, 3:34 AM
ArturGainullin updated the diff for D45315: [X86] Improve unsigned saturation downconvert detection..
  • Added detection of the smax(smin) pattern.
Apr 11 2018, 2:34 AM

Apr 10 2018

ArturGainullin retitled D45317: Eliminate a bitwise 'not' op of 'not' min/max by inverting the min/max. from Canonicalization of the min/max patterns. to Eliminate a bitwise 'not' op of 'not' min/max by inverting the min/max..
Apr 10 2018, 2:01 AM
ArturGainullin updated the diff for D45317: Eliminate a bitwise 'not' op of 'not' min/max by inverting the min/max..
  • Fixed according to comments.
Apr 10 2018, 1:55 AM

Apr 9 2018

ArturGainullin updated the summary of D45317: Eliminate a bitwise 'not' op of 'not' min/max by inverting the min/max..
Apr 9 2018, 4:10 AM
ArturGainullin updated the diff for D45317: Eliminate a bitwise 'not' op of 'not' min/max by inverting the min/max..
  • Addressed review comments.
Apr 9 2018, 4:09 AM

Apr 5 2018

ArturGainullin created D45317: Eliminate a bitwise 'not' op of 'not' min/max by inverting the min/max..
Apr 5 2018, 5:54 AM
ArturGainullin created D45315: [X86] Improve unsigned saturation downconvert detection..
Apr 5 2018, 5:52 AM

Oct 27 2017

ArturGainullin committed rL316795: Improve clamp recognition in ValueTracking..
Improve clamp recognition in ValueTracking.
Oct 27 2017, 1:54 PM
ArturGainullin closed D39240: Improve clamp recognition in ValueTracking. by committing rL316795: Improve clamp recognition in ValueTracking..
Oct 27 2017, 1:54 PM

Oct 26 2017

ArturGainullin updated the diff for D39240: Improve clamp recognition in ValueTracking..

Sanjay, thank you very much! I agree that solution with helper function looks better.

Oct 26 2017, 4:00 PM

Oct 24 2017

ArturGainullin created D39240: Improve clamp recognition in ValueTracking..
Oct 24 2017, 6:52 AM

Oct 23 2017

ArturGainullin committed rL316322: Test commit..
Test commit.
Oct 23 2017, 6:27 AM

Oct 17 2017

ArturGainullin updated the diff for D38536: Improve lookThroughCast function..

Improved comment.

Oct 17 2017, 1:10 AM

Oct 16 2017

ArturGainullin added a comment to D38536: Improve lookThroughCast function..

Oh, yes, it is clear for me now. Thanks! I have fixed according to your recommendation.

Oct 16 2017, 4:40 PM
ArturGainullin updated the diff for D38536: Improve lookThroughCast function..

Fixed according to comments.

Oct 16 2017, 4:39 PM
ArturGainullin added a comment to D38536: Improve lookThroughCast function..

For using constant from cmp instruction (instead of recreation) we will need to check that truncated constant is equal to lower bits of cmp constant.
That is why I decided just to recreate constant which looks like more general solution.

Oct 16 2017, 4:08 PM
ArturGainullin updated the diff for D38536: Improve lookThroughCast function..

Minimized test cases and added new ones.

Oct 16 2017, 4:01 PM
ArturGainullin updated the diff for D38531: Improve clamp recognition in ValueTracking..

We need to check that predicate is signed before matching patterns after clamp.
This condition was removed by mistake. Fixed.

Oct 16 2017, 2:30 PM
ArturGainullin updated the diff for D38531: Improve clamp recognition in ValueTracking..

Rebase after committing foldICmpWithZero as a separate change.
Also made changes according to comments.

Oct 16 2017, 3:17 AM
ArturGainullin added a comment to D38934: Move folding of icmp with zero after checking for min/max idioms..

Sanjay, no, I don't have. I have asked my colleague to commit. Thanks!

Oct 16 2017, 2:22 AM
ArturGainullin added a comment to D38536: Improve lookThroughCast function..

I have read more carefully your comment. As far as I understood in D26556 you want to change the process of decision making for function that folds cast operation into select.
According to suggestion from Eli you should try to match the size of a select to a cmp of its condition operand as a final result.
Necessary to mention that this function doesn't make cast folding when select is min/max and it is called only when select is an operand of cast operation.

Oct 16 2017, 1:48 AM

Oct 15 2017

ArturGainullin added a comment to D38536: Improve lookThroughCast function..

I have checked that patch from D26556 doesn't work for the case described in this review.
D26556 is about folding extension instruction into select.
I.e. in case of the following pattern:

s = select Cond, C1, C2 
sext s

sext operation is eliminated and C1, C2 constants are widened.

Oct 15 2017, 12:40 PM
ArturGainullin updated the diff for D38934: Move folding of icmp with zero after checking for min/max idioms..

Fixed comment.

Oct 15 2017, 3:46 AM
ArturGainullin added a comment to D38531: Improve clamp recognition in ValueTracking..

Created separate patch to move folding of cmp instruction: D38934. I will be able to update this differential revision when it will be committed.
I have renamed function so that we will be able to add an smax sibling for this fold with separate commit.

Oct 15 2017, 3:41 AM
ArturGainullin created D38934: Move folding of icmp with zero after checking for min/max idioms..
Oct 15 2017, 3:26 AM

Oct 11 2017

ArturGainullin added a comment to D38536: Improve lookThroughCast function..

Ping.

Oct 11 2017, 4:51 AM
ArturGainullin added a comment to D38531: Improve clamp recognition in ValueTracking..

Ping.

Oct 11 2017, 4:51 AM

Oct 4 2017

ArturGainullin created D38536: Improve lookThroughCast function..
Oct 4 2017, 3:21 AM
ArturGainullin created D38531: Improve clamp recognition in ValueTracking..
Oct 4 2017, 1:37 AM