ebevhan (Bevin Hansson)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 16 2018, 6:47 AM (18 w, 3 d)

Recent Activity

Today

ebevhan added inline comments to D46944: [analyzer] Use sufficiently large types for index/size calculation..
Fri, May 25, 7:41 AM
ebevhan added a comment to D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.

With the exception of the two inline comments, this looks good to me now!

Fri, May 25, 5:42 AM · Restricted Project

Yesterday

ebevhan added inline comments to D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Thu, May 24, 2:57 PM · Restricted Project
ebevhan added inline comments to D46944: [analyzer] Use sufficiently large types for index/size calculation..
Thu, May 24, 12:11 AM

Wed, May 23

ebevhan added a comment to D46986: [Fixed Point Arithmetic] Validation Test for Fixed Point Binary Operations and Saturated Addition.

Also, this patch and all of the following 'Validation Test' patches do much more than just add tests, they add plenty of functionality as well. In general, it's quite difficult to tell which patches add what.

Wed, May 23, 2:44 AM · Restricted Project
ebevhan added a comment to D46986: [Fixed Point Arithmetic] Validation Test for Fixed Point Binary Operations and Saturated Addition.

I cannot say that I'm pleased with the CodeGen emission of the operations as pure IR. I can only assume that you do not have hardware specifically tailored for these operations, as matching this type of code ought to be quite difficult after optimization is performed.

Wed, May 23, 2:40 AM · Restricted Project
ebevhan added inline comments to D46927: [Fixed Point Arithmetic] Augmented Assignment for Fixed Point Types.
Wed, May 23, 2:30 AM · Restricted Project
ebevhan added inline comments to D46917: [Fixed Point Arithmetic] Comparison and Unary Operations for Fixed Point Types.
Wed, May 23, 2:10 AM · Restricted Project
ebevhan added inline comments to D46917: [Fixed Point Arithmetic] Comparison and Unary Operations for Fixed Point Types.
Wed, May 23, 1:41 AM · Restricted Project
ebevhan added a comment to D46915: [Fixed Point Arithmetic] Set Fixed Point Precision Bits and Create Fixed Point Literals.

You should not define the fixed-point precision as compiler macros at build configure time. The number of fractional bits (the scaling factor) should be added to TargetInfo as target-configurable variables/accessors, and an accessor should be added to ASTContext (we call it 'getFixedPointScale') to fetch the scaling factor of arbitrary fixed-point types.

Wed, May 23, 1:32 AM · Restricted Project
ebevhan added inline comments to D46911: [Fixed Point Arithmetic] Addition of the remaining fixed point types and their saturated equivalents.
Wed, May 23, 12:54 AM · Restricted Project
ebevhan added inline comments to D46960: [Fixed Point Arithmetic] Predefined Precision Macros.
Wed, May 23, 12:36 AM · Restricted Project
ebevhan added inline comments to D46084: [Fixed Point Arithmetic] Addition of the Fixed Point _Accum type.
Wed, May 23, 12:29 AM · Restricted Project

Mon, May 21

ebevhan updated the diff for D46944: [analyzer] Use sufficiently large types for index/size calculation..

Made ArrayIndexTy into ssize_t, consolidated the tests and fixed the test that was failing.

Mon, May 21, 12:55 AM

Wed, May 16

ebevhan added inline comments to D46944: [analyzer] Use sufficiently large types for index/size calculation..
Wed, May 16, 10:34 AM
ebevhan added inline comments to D46944: [analyzer] Use sufficiently large types for index/size calculation..
Wed, May 16, 8:41 AM
ebevhan created D46944: [analyzer] Use sufficiently large types for index/size calculation..
Wed, May 16, 7:34 AM

Apr 24 2018

ebevhan added a comment to D45865: [Sema] Emit -Warray-bounds for multiple levels of subscript expressions..

Thank you! I do not have commit rights, so if someone could commit this that would be great.

Apr 24 2018, 6:05 AM
ebevhan updated the diff for D45865: [Sema] Emit -Warray-bounds for multiple levels of subscript expressions..

Removed local variable and added some more to the test.

Apr 24 2018, 1:21 AM

Apr 20 2018

ebevhan created D45865: [Sema] Emit -Warray-bounds for multiple levels of subscript expressions..
Apr 20 2018, 1:21 AM

Jan 31 2018

ebevhan updated the diff for D42103: [LSR] Don't force bases of foldable formulae to the final type..

Rebased. Another test case was affected, but as far as I can tell, the only difference is the elimination of two bitcasts.

Jan 31 2018, 7:49 AM

Jan 30 2018

ebevhan added a comment to D42103: [LSR] Don't force bases of foldable formulae to the final type..

I replaced the other two instances of Ty with nullptr, and only observed a difference in one AMDGPU test case (preserve-addrspace-assert.ll), likely caused by the change on line 5022. Before, GEPs for double* and i32* were produced, but with the patch, GEPs for the containing struct are produced instead. This is probably because the expander was being forced to emit the pre-offset expressions as the final types (which were double* and i32*) but with the patch it will emit GEPs that take the struct pointer instead.

Jan 30 2018, 6:50 AM

Jan 29 2018

ebevhan added a comment to D42103: [LSR] Don't force bases of foldable formulae to the final type..

Out-of-curiosity do you actually see codegen differences with that patch?

Jan 29 2018, 12:45 AM

Jan 22 2018

ebevhan updated the diff for D42103: [LSR] Don't force bases of foldable formulae to the final type..

Included the complete context. Sorry for missing that!

Jan 22 2018, 12:05 AM

Jan 16 2018

ebevhan created D42103: [LSR] Don't force bases of foldable formulae to the final type..
Jan 16 2018, 7:02 AM