- User Since
- Jan 16 2018, 6:47 AM (297 w, 1 d)
Aug 9 2023
Hi! We're seeing miscompiles downstream when running attributor-light in pipelines. In the below reproducer, DSE is eliminating a store that isn't dead.
May 23 2023
May 22 2023
What would be the semantics of such an operation if the address spaces are disjoint? Or, if the underlying pointer widths aren't the same?
May 21 2023
Sep 27 2022
Hi! A bit of late feedback on this patch. We found a failure in our downstream testing likely originating from here.
Jul 15 2022
We get a memory corruption issue in our downstream testing with this patch. I've attached a reproducer, which can be run with opt -passes=vector-combine reduced.ll:
Jul 14 2022
Sorry for the delay! I rebased the patch onto latest and it mostly worked, with a few hitches.
Rebased and addressed some comments.
Jun 9 2022
Hi! This test is failing in some of our downstream builds.
Jun 1 2022
I've been away from LLVM development for a while, and sadly this patch has languished a bit.
Oct 13 2020
Oct 9 2020
Oct 1 2020
Sep 30 2020
It doesn't seem like anyone has any more immediate feedback. @efriedma, have all of your review comments been adequately addressed?
Sep 29 2020
LGTM, but @aaron.ballman should probably give his two cents as well for completion's sake.
Sep 25 2020
Ping. The build failures don't seem related to the patch.
Another gentle ping.
Sep 24 2020
So is this patch good to go then?
Sep 23 2020
Sep 22 2020
Sep 21 2020
Ping. Any further comments?
Sep 15 2020
Any more feedback on this?
Sep 14 2020
Fix clang-format warnings.
Fix clang-format warnings.
Now only uses FP_TO_INT_SAT nodes for lowering. The nodes are selected in isel.
Sep 11 2020
Using Type::getFloatingPointTy now.
Sep 10 2020
Use default expansion for f128 conversions; they aren't native so we can't be sure that they saturate.
Removed NativeSaturation parameter and made all lowering happen in Lower.
Sep 9 2020
Followup to removing vector expansion in the parent patch.
Removed vector expansion.
Fixed failing test cases.
Sep 8 2020
Updated method name.
Sep 7 2020
Removed superfluous NaN check and updated tests.
I don't know why the premerge tests are failing. I don't see those failures locally, so it's rather hard to debug it, especially since the premerge build lacks proper debug info.
Added promotion mechanism.
Added a promotion mechanism to handle cases where the floating point type cannot be used to rescale the value.
Sep 4 2020
Sep 3 2020
Sep 2 2020
Sep 1 2020
Made natively saturating expansions use integer comparisons instead.
Aug 31 2020
Aug 27 2020
I hadn't considered half precision as that's sort of off my radar. That does make both these conversion methods and the corresponding codegen implementation rather problematic.
Fix comment mistake.
This needs a few tests.
Aug 26 2020
Rebased and did minor adjustments.
Aug 25 2020
Aug 24 2020
@gousemoodhin I just want to check; are you working on or planning to work on float-fixed support in the near future? Floating point conversions are the next step for the fixed-point support, so if you aren't immediately looking at it, I would like to take a shot at it.