- User Since
- Mar 5 2015, 8:05 AM (228 w, 3 d)
Thu, Jul 18
The commit has been reverted due to issues with libc++:
Wed, Jul 17
- Updated comments
- Added motivation
Reopening to continue reviews.
Fixed typo in the comment
Tue, Jul 16
I expect the example from the bug is going to compile now: https://bugs.llvm.org/show_bug.cgi?id=41009
Addressed some review comments. Refs are still to be fixed!
Mon, Jul 15
@rsmith, do you have any comments here? It would be quite useful to have this patch in Clang9.
Fri, Jul 12
Generate NULL for pointer param of __cxa_atexit on mismatching addr spaces
Thu, Jul 11
- Moved addr space inference of pointee type into template instantiation.
Wed, Jul 10
Changed API for target hook.
- Added handling of similar test case with InjectedClassNameType
Tue, Jul 9
Wed, Jul 3
If you like you can also change reserve_id_t. :)
Tue, Jul 2
LGTM! Thanks! I would suggest to wait a day or two before committing just in case John has any feedback.
Added a target hook to query address spaces with the largest pointer width.
I would say in the interest of saving testing time running one of those test in C++ mode should be enough.
- Removed diagnostic for address space in return type in tree transforms
Mon, Jul 1
btw, there seems to be the same issue with reserve_id_t?
This patch adds handling for OpenCL builtin functions.
For instance, OpenCL kernel in SYCL mode initializes lambda captures with
the kernel argument values. This initialization code for sampler emits
errors because OpenCL disallows sampler on the right hand side of the
binary operators - these are supposed to be used only by built-in
Functions having only one prototype will point to a prototype
definition of another function.
Jun 21 2019
Generic types are an abstraction of type sets. It mimics the way functions
are defined in the OpenCL specification.
Jun 20 2019
Jun 5 2019
Ping! I would appreciate any feedback to this change please. Thanks you!
Due to my recent commits I had to changed this slightly so it is now under a new review: https://reviews.llvm.org/D62914
Jun 3 2019
- Added more test cases
- Improved diagnostics to account for use of templates with addr spaces
@mantognini Good spot! Thanks!
- Exclude pointee from early return in addr space deduction
- Improved testing: added FileCheck and avoid testing unnecessary bits
- Guard OpenCL specific IR generation under OpenCL lang mode
Changed FIXME to a regular comment, modified wording.
May 30 2019
This patch does not address the issue with the accessors
on Qualifiers (isAddressSpaceSupersetOf, compatiblyIncludes),
because I don't know how to solve it without breaking a ton of
rather nice encapsulation. Either, every mention of compatiblyIncludes
must be replaced with a call to a corresponding ASTContext method,
Qualifiers must have a handle to ASTContext, or ASTContext must be
passed to every such call. This revision mentions the issue in a comment:
- Improved diagnostic
- Added more comments