- User Since
- Mar 5 2015, 8:05 AM (329 w, 12 h)
I agree we should have the same behavior for both options. Technically -finclude-default-header could be added in both steps but it is only effective in parsing the sources and does nothing otherwise. But it seems cleaner to align it with the header include option.
Tue, Jun 22
Thu, Jun 17
LGTM! Yes it seems the only situation where the check would evaluate to a different value with and without your patch is when we have RefRelationship == Sema::Ref_Related as false while the address space is not a superset then we would get an incorrect diagnostic. But I feel this would be diagnosed elsewhere before we end up in this check.
Do you think we could add any test for this yet? Or do we have to wait until we have other pieces in place for diffing to opencl-c.h? We could add a test for parsing the header but it is probably going to be very slow test?
I think the diagnostic wording can be improved separately if it's considered important as it seems this issue already existed.
Thu, Jun 10
LGTM! Thanks! Please, amend the comment as suggested in the final commit
Wed, Jun 9
Mon, Jun 7
Considering that this patch doesn't add anything new to the design, I suggest we go ahead. But we should continue the discussion around -cl-ext etc elsewhere and then perhaps some follow up patches will be needed to fix this fully.
Tue, Jun 1
Thu, May 27
Yeah I think this is the only case where DefaultLvalueConversion exits with an error at present.
Wed, May 26
I think this is a very good starting point for the testing of built-in functions. Btw should we now remove '[Draft]' from the title?
May 24 2021
Build failure should be fixed by https://github.com/llvm/llvm-project/commit/626e9641a2f5fde638b86d4e043f82fc58b908f8
May 21 2021
LGTM! Although I think it would be better if we set __IMAGE_SUPPORT__ conditionally also for earlier OpenCL versions.
May 20 2021
Just to move the discussion from https://reviews.llvm.org/D101519 here. First of all I think this change should not be OpenCL specific i.e. there is not reason to do something different from C++ in general.
May 18 2021
May 17 2021
May 14 2021
Just remember to reflect your final change in the commit message description. :)
May 12 2021
Added suggestions from Sven.
Added a comment in the test.
May 11 2021
May 10 2021
May 7 2021
May 6 2021
May 5 2021
May 4 2021
Apr 30 2021
Improved negative testing for cl_khr_gl_msaa_sharing
Test all image types as identifiers
- Added a pedantic warning about use of double even if the extension is in disabled state wrt pragma.
Apr 29 2021
If I build docs now I get the following output:
Apr 28 2021