- User Since
- Mar 5 2015, 8:05 AM (210 w, 4 d)
Moved testing of default header in C++ mode to test/Headers/opencl-c-header.cl
PS, I am just saying that I guess leaving this to the compiler is more helpful than explicitly requiring the full unroll. However, spec contradicts itself by first mentioning the full unroll and then stating that compiler will determines the unrolling factor.
The wording in spec is confusing btw because it says:
Fri, Mar 15
Thu, Mar 14
Wed, Mar 13
Tue, Mar 12
Mon, Mar 11
Thu, Mar 7
Committed in r355606.
Wed, Mar 6
I now create overloads for all address spaces that are being called.
Restructure code with early return.
Tue, Mar 5
Use common pointer type.
Updates FiXME explaining why C++ mode is more permissive.
Un-commented the line in the test
Moved adding address space to DestType earlier to cover pointer and non-pointer case.
- Implement the fix correctly by added an extra address space conversion step after binding the reference
- Fixed incorrect diagnostic in address space mismatch case when binding reference to a temporary value of a constant with incompatible type. Added missing test case.
Mon, Mar 4
LGTM! I am ok with this change to remove the macro from the common header. I don't think it belongs to there. However, I believe this functionality should be better represented in the vendors specific headers rather than clang directly. See my comment above!
Thu, Feb 28
Btw, I have changed the diagnostic wording... does this change make sense now?
Along those lines, in general, the normal C rules should allow casting foo* to bar* for any object types foo and bar, even if foo and bar are pointers with address spaces, like __local int * and __global int *. I don't see anything in the OpenCL standard that would contradict this. It looks like this patch changes that?
Wed, Feb 27
- Added a comment to explain OpenCL check.
LGTM! Thanks a lot for fixing this old bug! Btw, do you plan to look at generalizing this to C++ as well?
Tue, Feb 26
Mon, Feb 25
Committed to the release branch r354799.
Updated the section title!
LGTM! Although for consistency we could add this into python bindings too.
LGTM! Thanks! I guess we are missing a python test? No idea why we are not testing it though...
Fri, Feb 22
I just took the ownership of this to be able to close it.
I just closed the bug because it's no longer failing on the master branch. So I don't think this is needed.
Thu, Feb 21
Wed, Feb 20
LGTM! Great! Thanks!
Added a CodeGen test to cover address space of reference in reinterpret_cast.
Tue, Feb 19
Committed in r354121.
Mon, Feb 18
This seems like an interesting change. So far in OpenCL we have actively used only unroll. I will let others to assess in more details.
LGTM! Thanks! This totally makes sense! I think we inherited that from ObjC but never adapted fully. This change has low risk of breaking backwards compatibility but might need some minor update in tools.
Feb 15 2019
Feb 14 2019
Feb 13 2019
- Changed the diagnostic for binding reference and combined with existing similar one. That affected more tests however.
- Changed comment explaining address space behavior in the reference initialization.
Feb 11 2019
Feb 7 2019
- Moved version check inside the extension logic.
- Changed commit message to reflect better functionality of the patch.
Feb 6 2019
Btw, if we would implement something like this: