- User Since
- Mar 5 2015, 8:05 AM (254 w, 1 d)
Fri, Jan 3
Thu, Jan 2
Recovered lost bit of information.
Fri, Dec 27
It looks good, I was just thinking whether it would be possible to share more common infrastructure. There is Sema::CheckVectorOperands that corresponding OpenCL methods are using internally. Do you think it is possible to share the code more?
Dec 16 2019
Dec 13 2019
Dec 12 2019
- Moved "address space" printing into diagnostic engine
- Moved LangAS::Default into switch/case statement.
Dec 11 2019
- Allow sending address spaces into diagnostics
- Change wording of diagnostics for address spaces in overloading
Dec 10 2019
Dec 6 2019
Dec 5 2019
I presume OpenCL addr space logic won't apply in all cases in non-OpenCL compilations i.e. for example C++ because we enclose some of the logic under LangOpts checks.
Dec 4 2019
LGTM! Thanks! Please address the comment in your final commit.
Dec 3 2019
Nov 28 2019
Switched to using getAddrSpaceQualType in the entire code base.
Sorry, I don't have capacity currently to review this and I don't want to be blocking it either.
Nov 27 2019
Added getDefaultCXXMethodAddrSpace helper to Sema
Nov 26 2019
Nov 25 2019
Nov 22 2019
I think we should use -fpermissive rather than adding similar flag to Clang. At the end we might end up with other cases where we need similar mechanism it doesn't make sense to add a flag for each case.
Nov 21 2019
Nov 19 2019
- Added FIXME to enhance testing.
Nov 15 2019
Nov 14 2019
- Added pointer to lambda test case.
Nov 12 2019
- Added missing handling of lambda w/o param list.
Nov 11 2019
Nov 7 2019
Stop emitting the denorms-are-zero attribute for the OpenCL flag. It
has no in-tree users. The meaning would also be target dependent, such
as the AMDGPU choice to treat this as only meaning allow flushing of
f32 and not f16 or f64. The naming is also potentially confusing,
since DAZ in other contexts refers to instructions implicitly treating
input denormals as zero, not necessarily flushing output denormals to
I guess we need to think about testing quite soon. :)
Nov 5 2019
- Factored OpenCL diagnostics out in a separate helper function
- Removed special case for ParenType
Nov 4 2019
LGTM! Feel free to change comments on the final commit! Thanks!
Nov 1 2019
I agree. LGTM! Thanks!
Oct 17 2019
Added OpenCLSupport page into index.
Oct 16 2019
Oct 10 2019
Oct 4 2019
Can you please explain why we are deviating from C++ on this? My concern is that this can potentially uncover bugs in C++ parsing due to un-handled restrict cases that would have to be fixed in some unclear way... I would appreciate more detailed analysis before we go ahead.
Sep 27 2019
Sep 25 2019
Sep 24 2019
Sep 13 2019
Sep 12 2019
- Move addr space deduction to a later phase.
Sep 4 2019
- Added forgotten test
Moved addr space of pointee inference into Build* helpers of Sema.
Sep 3 2019
Aug 30 2019
missing test case
Aug 28 2019
Aug 23 2019
Aug 19 2019
Added small corrections in various parts.
- Added empty line and ; as requested on the review.