This is an archive of the discontinued LLVM Phabricator instance.

Differential D92574

[AArch64] Add support for ls64 to the .arch_extension asm directive
ClosedPublic

Authored by pratlucas on Dec 3 2020, 6:36 AM.

Details

Reviewers
simon_tatham
vhscampos
olista01
ostannard
dmgreen
Commits
rG1a9577bde1dd: [AArch64] Add support for ls64 to the .arch_extension asm directive
Summary

This adds support for the 'ls64' AArch64 extension to the .arch_extension
asm directive.

Diff Detail

Event Timeline

pratlucas created this revision.Dec 3 2020, 6:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2020, 6:36 AM
Herald added subscribers: llvm-commits, danielkiss, hiraditya, kristof.beyls. · View Herald Transcript
pratlucas requested review of this revision.Dec 3 2020, 6:36 AM
Harbormaster completed remote builds in B80954: Diff 309244.Dec 3 2020, 6:36 AM
pratlucas added reviewers: simon_tatham, vhscampos, olista01, ostannard, dmgreen.Dec 3 2020, 6:37 AM
pratlucas added a parent revision: D92391: [AArch64] Add support for the SPE-EEF feature.
pratlucas updated this revision to Diff 309248.Dec 3 2020, 7:06 AM

Reducing scope to 'ls64' extension only.

pratlucas retitled this revision from [AArch64] Add support for brbe, ls64, spe-eef and wfxt to .arch_extension to [AArch64] Add support for ls64 to the .arch_extension asm directive.Dec 3 2020, 7:07 AM
pratlucas edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B80957: Diff 309248.Dec 3 2020, 7:08 AM
pratlucas added a comment.Dec 14 2020, 5:31 AM

Ping.

pratlucas updated this revision to Diff 311627.Dec 14 2020, 9:24 AM

Rebasing.

Harbormaster completed remote builds in B82302: Diff 311627.Dec 14 2020, 10:52 AM
ostannard added inline comments.Dec 18 2020, 1:42 AM
llvm/test/MC/AArch64/directive-arch_extension-negative.s
87

This feature isn't enabled by default, so I'd expect this test to still pass even if the .arch_extension nols64 line was removed. We should enable all of these extensions with command-line options to llvm-mc, and probably add checks that the instructions are accepted before the extension is disabled.

This is an existing problem with many of the other tests in this file, so doing this as a separate patch would be best.

pratlucas added a child revision: D93538: [AArch64] Updating .arch_extension negative tests.Dec 18 2020, 6:00 AM
pratlucas marked an inline comment as done.
pratlucas added inline comments.
llvm/test/MC/AArch64/directive-arch_extension-negative.s
87

I've updated the test on D93538.

ostannard accepted this revision.Dec 18 2020, 6:17 AM

LGTM

This revision is now accepted and ready to land.Dec 18 2020, 6:17 AM
This revision was landed with ongoing or failed builds.Dec 18 2020, 7:56 AM
Closed by commit rG1a9577bde1dd: [AArch64] Add support for ls64 to the .arch_extension asm directive (authored by pratlucas). · Explain Why
This revision was automatically updated to reflect the committed changes.
pratlucas marked an inline comment as done.
pratlucas added a commit: rG1a9577bde1dd: [AArch64] Add support for ls64 to the .arch_extension asm directive.

Revision Contents

PathSize
llvm/
lib/
Target/
AArch64/
AsmParser/
1 line
test/
MC/
AArch64/
5 lines
4 lines

Diff 312798

llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp

Show First 20 Lines • Show All 2,906 Lines • ▼ Show 20 Lines const FeatureBitset Features;
{"ccpp", {AArch64::FeatureCCPP}}, {"ccpp", {AArch64::FeatureCCPP}},
{"rcpc", {AArch64::FeatureRCPC}}, {"rcpc", {AArch64::FeatureRCPC}},
{"sve", {AArch64::FeatureSVE}}, {"sve", {AArch64::FeatureSVE}},
{"sve2", {AArch64::FeatureSVE2}}, {"sve2", {AArch64::FeatureSVE2}},
{"sve2-aes", {AArch64::FeatureSVE2AES}}, {"sve2-aes", {AArch64::FeatureSVE2AES}},
{"sve2-sm4", {AArch64::FeatureSVE2SM4}}, {"sve2-sm4", {AArch64::FeatureSVE2SM4}},
{"sve2-sha3", {AArch64::FeatureSVE2SHA3}}, {"sve2-sha3", {AArch64::FeatureSVE2SHA3}},
{"sve2-bitperm", {AArch64::FeatureSVE2BitPerm}}, {"sve2-bitperm", {AArch64::FeatureSVE2BitPerm}},
{"ls64", {AArch64::FeatureLS64}},
{"xs", {AArch64::FeatureXS}}, {"xs", {AArch64::FeatureXS}},
// FIXME: Unsupported extensions // FIXME: Unsupported extensions
{"pan", {}}, {"pan", {}},
{"lor", {}}, {"lor", {}},
{"rdma", {}}, {"rdma", {}},
{"profile", {}}, {"profile", {}},
}; };
▲ Show 20 Lines • Show All 3,403 Lines • Show Last 20 Lines

llvm/test/MC/AArch64/directive-arch_extension-negative.s

Show First 20 Lines • Show All 77 Lines • ▼ Show 20 Lines
dc cvap, x7 dc cvap, x7
// CHECK: error: DC CVAP requires: ccpp // CHECK: error: DC CVAP requires: ccpp
// CHECK-NEXT: dc cvap, x7 // CHECK-NEXT: dc cvap, x7
.arch_extension norcpc .arch_extension norcpc
ldapr x0, [x1] ldapr x0, [x1]
// CHECK: error: instruction requires: rcpc // CHECK: error: instruction requires: rcpc
// CHECK-NEXT: ldapr x0, [x1] // CHECK-NEXT: ldapr x0, [x1]
.arch_extension nols64
ostannardUnsubmitted
Done
ReplyInline Actions

This feature isn't enabled by default, so I'd expect this test to still pass even if the .arch_extension nols64 line was removed. We should enable all of these extensions with command-line options to llvm-mc, and probably add checks that the instructions are accepted before the extension is disabled.

This is an existing problem with many of the other tests in this file, so doing this as a separate patch would be best.

ostannard: This feature isn't enabled by default, so I'd expect this test to still pass even if the `.
pratlucasAuthorUnsubmitted
Done
ReplyInline Actions

I've updated the test on D93538.

pratlucas: I've updated the test on D93538.
ld64b x0, [x13]
// CHECK: error: instruction requires: ls64
// CHECK-NEXT: ld64b x0, [x13]

llvm/test/MC/AArch64/directive-arch_extension.s

Show First 20 Lines • Show All 61 Lines • ▼ Show 20 Lines
.arch_extension ccpp .arch_extension ccpp
dc cvap, x7 dc cvap, x7
// CHECK: dc cvap, x7 // CHECK: dc cvap, x7
.arch_extension rcpc .arch_extension rcpc
ldapr x0, [x1] ldapr x0, [x1]
// CHECK: ldapr x0, [x1] // CHECK: ldapr x0, [x1]
.arch_extension ls64
ld64b x0, [x13]
// CHECK: ld64b x0, [x13]