User Details
- User Since
- Feb 5 2014, 1:36 AM (503 w, 5 d)
Aug 29 2023
LGTM
Aug 24 2023
Aug 22 2023
LGTM
Aug 21 2023
Aug 17 2023
LGTM
Aug 15 2023
I don't think this is the right way to fix this. Endianness shouldn't affect the ordering of lanes in registers, only when they are stored to memory. We've got some documentation on this at https://llvm.org/docs/BigEndianNEON.html.
Aug 11 2023
Thanks, LGTM
Aug 9 2023
Do you have a test case for the situation where r4 is not saved?
Aug 3 2023
Ticket for backport to LLVM 17: https://github.com/llvm/llvm-project/issues/64380
Right, thanks. Do you want to prepare a patch for this?
- Updated sign-return-address.ll after D156327
- Simplified llvm-dwarfdump checks
Aug 2 2023
Added full checking of the llvm-dwarfdump output.
Jul 31 2023
- Don't emit .cfi_negate_ra_state for synchronous unwind tables
- Convert test to update_llc_test_checks
- Test sync and async unwind tables
Jul 27 2023
LGTM
Jul 13 2023
LGTM
Hi, this change has caused a regression in one of our tests:
Jul 10 2023
LGTM
Jul 4 2023
One comment which would improve the robustness a bit more, other than that LGTM.
Apr 20 2023
LGTM
Apr 13 2023
LGTM
Apr 11 2023
Apr 4 2023
LGTM
Mar 24 2023
There is existing documentation of the diagnostics system here, which you could extend if something is still unclear or incomplete:
- clang/docs/InternalsManual.rst
- https://clang.llvm.org/docs/InternalsManual.html#the-diagnostics-subsystem
Mar 2 2023
LGTM
Mar 1 2023
LGTM
Feb 28 2023
LGTM
Feb 24 2023
LGTM
LGTM
Feb 21 2023
Feb 10 2023
LGTM, with one comment in the test.
Feb 9 2023
There are a number of closely related instructions which have the same problem, would it make sense to do them at the same time?
- LDRSB
- LDRH
- LDRSH
- STRH
Feb 8 2023
Could we move the whole of createJumpTableEntry (and getJumpTableEntrySize, maybe others) into TargetTransformInfo? That would move all of the existing target-specific code here into the respective backends, and avoid adding target-specific things to the interface of TargetTransformInfo`.
Jan 13 2023
LGTM
Jan 12 2023
Nov 21 2022
LGTM
Oct 7 2019
Apr 11 2019
Mar 29 2019
I can't see any other uses of the option groups, or any way to put an option into two groups, so this LGTM.
Mar 26 2019
Mar 25 2019
Mar 21 2019
Is there an existing compiler which this option is trying to be compatible with? GCC for AArch64 doesn't currently have an option for this, so we don't have to worry about compatibility with that. If possible, I'd prefer for the option to be "-mtp=", to match the option accepted by clang and GCC for AArch32.
Mar 20 2019
LGTM. Do you have commit access? If not, I can commit this for you.
LGTM
Mar 18 2019
LGTM with one nit .
Mar 14 2019
LGTM
Mar 8 2019
LGTM
Mar 5 2019
Mar 4 2019
Mar 1 2019
Feb 21 2019
LGTM
Feb 18 2019
Yes, the back-end work was all done years ago, I just also forgot about these while waiting for the ACLE to be published.
Ping
These macros have been in the published ACLE for a while now: https://developer.arm.com/products/software-development-tools/compilers/arm-compiler-5/docs/101028/latest/5-feature-test-macros#position-independent-code