olista01 (Oliver Stannard)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 5 2014, 1:36 AM (241 w, 2 d)

Recent Activity

Yesterday

olista01 accepted D51432: [AArch64] Unwinding support for return address signing.

LGTM, thanks!

Thu, Sep 20, 2:53 AM
olista01 added inline comments to D51798: [Dwarf/AArch64] Return address signing B key dwarf support.
Thu, Sep 20, 2:47 AM

Wed, Sep 19

olista01 accepted D52258: Fix for bug 34002.

LGTM, thanks!

Wed, Sep 19, 8:39 AM
olista01 committed rL342545: [ARM] Fix unwind information for floating point registers.
[ARM] Fix unwind information for floating point registers
Wed, Sep 19, 6:26 AM
olista01 closed D51494: Fix unwind information for floating point registers.
Wed, Sep 19, 6:26 AM
olista01 accepted D51494: Fix unwind information for floating point registers.
Wed, Sep 19, 3:13 AM
olista01 added inline comments to D52258: Fix for bug 34002.
Wed, Sep 19, 1:36 AM

Thu, Sep 13

olista01 added a comment to D51798: [Dwarf/AArch64] Return address signing B key dwarf support.

Before I review the code itself, have you agreed the .append_augmentation directive with the GCC/GAS developers to make sure we implement it the same way?

Thu, Sep 13, 5:48 AM
olista01 added inline comments to D50136: [AArch64] - Return address signing dwarf support.
Thu, Sep 13, 5:34 AM
olista01 added inline comments to D51432: [AArch64] Unwinding support for return address signing.
Thu, Sep 13, 5:09 AM
olista01 added a comment to D51429: [AArch64] Return Address Signing B Key Support.

This looks like it has the same problem as D51418 (doesn't get applied to C++ static constructor functions).

Thu, Sep 13, 4:53 AM
olista01 accepted D51427: [AArch64] Return address signing B key support.

LGTM

Thu, Sep 13, 4:47 AM
olista01 committed rL342126: [AArch64] Enable return address signing for static ctors.
[AArch64] Enable return address signing for static ctors
Thu, Sep 13, 3:29 AM
olista01 committed rC342126: [AArch64] Enable return address signing for static ctors.
[AArch64] Enable return address signing for static ctors
Thu, Sep 13, 3:29 AM
olista01 closed D51418: [AArch64] Enable return address signing for static ctors.
Thu, Sep 13, 3:29 AM

Fri, Aug 31

olista01 added inline comments to D51494: Fix unwind information for floating point registers.
Fri, Aug 31, 1:59 AM

Wed, Aug 29

olista01 created D51418: [AArch64] Enable return address signing for static ctors.
Wed, Aug 29, 6:02 AM

Aug 17 2018

olista01 added a comment to D50136: [AArch64] - Return address signing dwarf support.

I think this needs additional tests to cover:

  • The encoding of the CFI instruction in object files
  • The assembly parser and printer changes, to make sure that IR->assembly->object will work the same as IR->object.
Aug 17 2018, 5:52 AM
olista01 accepted D49793: [AArch64] - return address signing.

LGTM, thanks!

Aug 17 2018, 5:37 AM
olista01 accepted D49791: [AArch64] - Generate pointer authentication instructions.

LGTM, thanks!

Aug 17 2018, 5:33 AM

Aug 9 2018

olista01 accepted D50175: [AArch64][NFC] better matching of AArch64 target in aarch64-cpus.c tests.

LGTM, thanks!

Aug 9 2018, 6:55 AM
olista01 added inline comments to D50175: [AArch64][NFC] better matching of AArch64 target in aarch64-cpus.c tests.
Aug 9 2018, 6:20 AM

Aug 8 2018

olista01 added inline comments to D50175: [AArch64][NFC] better matching of AArch64 target in aarch64-cpus.c tests.
Aug 8 2018, 6:45 AM

Aug 7 2018

olista01 accepted D50236: [ARM] FP16: support VACGT.

Ont nit, other than that LGTM.

Aug 7 2018, 7:23 AM

Aug 3 2018

olista01 accepted D50186: [ARM] FP16: support vector zip and unzip.

LGTM

Aug 3 2018, 1:46 AM

Aug 1 2018

olista01 accepted D50142: [ARM] Armv8.2-A FP16 vector intrinsics tests.

LGTM with one nit.

Aug 1 2018, 7:08 AM

Jul 25 2018

olista01 added inline comments to D49791: [AArch64] - Generate pointer authentication instructions.
Jul 25 2018, 8:28 AM
olista01 accepted D49370: [AArch64] Armv8.2-A: add the crypto extensions.

LGTM

Jul 25 2018, 7:48 AM
olista01 added inline comments to D49370: [AArch64] Armv8.2-A: add the crypto extensions.
Jul 25 2018, 6:40 AM

Jul 18 2018

olista01 added a comment to D49370: [AArch64] Armv8.2-A: add the crypto extensions.

There are some variants of the PMULL instruction which depend on HasCrypto, which I think should be changed to HasAES.

Jul 18 2018, 8:12 AM

Jul 13 2018

olista01 accepted D49284: [AArch64] Armv8.4-A: LDAPR & STLR with immediate offset instructions (cont'd).

LGTM

Jul 13 2018, 6:06 AM

Jul 12 2018

olista01 accepted D48927: [AArch64] Armv8.4-A: LDAPR & STLR with immediate offset instructions.

LGTM, thanks.

Jul 12 2018, 3:46 AM

Jul 11 2018

olista01 added inline comments to D48927: [AArch64] Armv8.4-A: LDAPR & STLR with immediate offset instructions.
Jul 11 2018, 6:13 AM

Jul 4 2018

olista01 accepted D48649: [ARM] [Assembler] Support negative immediates: cover few missing cases.

LGTM

Jul 4 2018, 3:06 AM

Jul 3 2018

olista01 accepted D48871: [AArch64] Armv8.4-A: system registers.

LGTM

Jul 3 2018, 4:56 AM

Jun 28 2018

olista01 accepted D48625: [ARM][AArch64] Armv8.4-A enablement.

LGTM

Jun 28 2018, 8:08 AM
olista01 accepted D48711: [AArch64] Armv8.4-A: Virtualization system registers.

It would be worth clarifying in the comments and commit message that this is the "Secure EL2" extension, to avoid confusion with the "Enhanced Support for Nested Virtualization" extension, which I assume will be in a later patch.

Jun 28 2018, 2:37 AM
olista01 added inline comments to D48625: [ARM][AArch64] Armv8.4-A enablement.
Jun 28 2018, 2:27 AM

Jun 21 2018

olista01 added a comment to D48437: [ARM] ARMv6m and v8m.baseline strict align target feature.

This restriction is in the Armv6M architecture, so I think this should be done in ARMv6m, so it also applies to cortex-m1 and sc000, and I think this also applies to ARMv8mBaseline.

Jun 21 2018, 8:37 AM

Jun 5 2018

olista01 added a comment to D47711: [AArch64][SVE] Asm: Add parsing/printing support for exact FP immediates..

It looks like we currently have two ways in which floating-point operands can get parsed, and this patch adds a third, which accepts values which overlap with both of the existing ones. Instead, this seems like a good time to tidy this up, always parsing to the same AArch64Operand, and using predicate functions to check if the value is valid for each operand type, as we do for integer operands with different ranges.

Jun 5 2018, 7:36 AM

Apr 27 2018

olista01 committed rL331039: [ARM,AArch64] Add intrinsics for dot product instructions.
[ARM,AArch64] Add intrinsics for dot product instructions
Apr 27 2018, 7:09 AM
olista01 committed rC331039: [ARM,AArch64] Add intrinsics for dot product instructions.
[ARM,AArch64] Add intrinsics for dot product instructions
Apr 27 2018, 7:09 AM
olista01 closed D46109: [ARM,AArch64] Add intrinsics for dot product instructions.
Apr 27 2018, 7:09 AM
olista01 added inline comments to D46109: [ARM,AArch64] Add intrinsics for dot product instructions.
Apr 27 2018, 7:05 AM
olista01 committed rL331038: [ARM] Add __ARM_FEATURE_DOTPROD pre-defined macro.
[ARM] Add __ARM_FEATURE_DOTPROD pre-defined macro
Apr 27 2018, 6:59 AM
olista01 committed rC331038: [ARM] Add __ARM_FEATURE_DOTPROD pre-defined macro.
[ARM] Add __ARM_FEATURE_DOTPROD pre-defined macro
Apr 27 2018, 6:59 AM
olista01 closed D46108: [ARM] Add __ARM_FEATURE_DOTPROD pre-defined macro.
Apr 27 2018, 6:59 AM
olista01 committed rL331036: [AArch64] Codegen for v8.2A dot product intrinsics.
[AArch64] Codegen for v8.2A dot product intrinsics
Apr 27 2018, 6:49 AM
olista01 committed rL331032: [ARM] Codegen for v8.2A dot product intrinsics.
[ARM] Codegen for v8.2A dot product intrinsics
Apr 27 2018, 5:54 AM
olista01 closed D46106: [ARM] Codegen for v8.2A dot product intrinsics.
Apr 27 2018, 5:54 AM

Apr 26 2018

olista01 created D46109: [ARM,AArch64] Add intrinsics for dot product instructions.
Apr 26 2018, 2:30 AM
olista01 created D46108: [ARM] Add __ARM_FEATURE_DOTPROD pre-defined macro.
Apr 26 2018, 2:27 AM
olista01 created D46107: [AArch64] Codegen for v8.2A dot product intrinsics.
Apr 26 2018, 2:25 AM
olista01 created D46106: [ARM] Codegen for v8.2A dot product intrinsics.
Apr 26 2018, 2:24 AM

Apr 25 2018

olista01 accepted D45879: [AsmMatcher] Extend PredicateMethod with optional DiagnosticPredicate.

LGTM

Apr 25 2018, 7:58 AM

Apr 11 2018

olista01 accepted D45205: [ARM] FP16 VSEL codegen follow up.

LGTM, thanks.

Apr 11 2018, 2:16 AM

Apr 5 2018

olista01 added inline comments to D45205: [ARM] FP16 VSEL codegen follow up.
Apr 5 2018, 10:08 AM

Apr 3 2018

olista01 added a comment to D45205: [ARM] FP16 VSEL codegen follow up.

This patch now changes 4 DAG nodes, but doesn't touch any tests for most of them. Are these changes NFC, and properly tested elsewhere? If not, this needs more tests.

Apr 3 2018, 10:32 AM
olista01 added inline comments to D45205: [ARM] FP16 VSEL codegen follow up.
Apr 3 2018, 5:59 AM

Mar 6 2018

olista01 committed rL326810: [Asm] Fix another layering violation in assmebly macro dumping.
[Asm] Fix another layering violation in assmebly macro dumping
Mar 6 2018, 8:55 AM
olista01 committed rL326804: [ARM][Asm] Fix layering violation introduced by r326795.
[ARM][Asm] Fix layering violation introduced by r326795
Mar 6 2018, 7:35 AM
olista01 committed rL326795: [Asm] Add debug printing for assembler macros.
[Asm] Add debug printing for assembler macros
Mar 6 2018, 6:10 AM
olista01 closed D43937: [Asm] Add debug printing for assembler macros.
Mar 6 2018, 6:10 AM
olista01 committed rL326794: [Asm] Refactor debug printing of AsmToken.
[Asm] Refactor debug printing of AsmToken
Mar 6 2018, 6:05 AM
olista01 closed D43936: [Asm] Refactor debug printing of AsmToken.
Mar 6 2018, 6:05 AM
olista01 added inline comments to D43936: [Asm] Refactor debug printing of AsmToken.
Mar 6 2018, 5:48 AM

Mar 5 2018

olista01 committed rL326696: [ARM][Asm] VMOVSRR and VMOVRRS need sequential S registers.
[ARM][Asm] VMOVSRR and VMOVRRS need sequential S registers
Mar 5 2018, 5:30 AM
olista01 closed D44084: [ARM][Asm] VMOVSRR and VMOVRRS need sequential S registers.
Mar 5 2018, 5:29 AM
olista01 created D44084: [ARM][Asm] VMOVSRR and VMOVRRS need sequential S registers.
Mar 5 2018, 3:01 AM

Mar 1 2018

olista01 added a dependency for D43937: [Asm] Add debug printing for assembler macros: D43936: [Asm] Refactor debug printing of AsmToken.
Mar 1 2018, 3:47 AM
olista01 added a dependent revision for D43936: [Asm] Refactor debug printing of AsmToken: D43937: [Asm] Add debug printing for assembler macros.
Mar 1 2018, 3:47 AM
olista01 created D43937: [Asm] Add debug printing for assembler macros.
Mar 1 2018, 3:47 AM
olista01 created D43936: [Asm] Refactor debug printing of AsmToken.
Mar 1 2018, 3:45 AM

Feb 27 2018

olista01 accepted D43807: ARM: Don't rewrite add reg, $sp, 0 -> mov reg, $sp if the add defines CPSR..

LGTM, thanks.

Feb 27 2018, 4:14 AM
olista01 accepted D43777: [ARM] Another f16 litpool fix.

LGTM.

Feb 27 2018, 3:05 AM

Feb 21 2018

olista01 accepted D43580: [ARM] FP16 constant pool fix.

LGTM, but please wait a day to let other time-zones comment.

Feb 21 2018, 9:44 AM

Feb 16 2018

olista01 added a comment to D43374: [ARM]Decoding MSR with unpredictable destination register causes an assert.

Hi Simi,

Feb 16 2018, 2:01 AM

Feb 14 2018

olista01 accepted D43018: Move llvm::computeLoopSafetyInfo from LICM.cpp to LoopUtils.cpp. NFC.

LGTM

Feb 14 2018, 9:21 AM
olista01 added inline comments to D43291: [ARM] f16 vcmp fixes.
Feb 14 2018, 8:53 AM
olista01 accepted D43280: [ARM] f16 stack spill/reloads.

LGTM, thanks

Feb 14 2018, 7:07 AM
olista01 added a comment to D43280: [ARM] f16 stack spill/reloads.

The test case doesn't have to be exactly the -O0 output from clang, you should reduce it to clear IR which triggers the bug. To start with, are all of those allocas and memcpy calls required?

Feb 14 2018, 6:32 AM
olista01 added inline comments to D43280: [ARM] f16 stack spill/reloads.
Feb 14 2018, 6:21 AM

Feb 13 2018

olista01 accepted D42784: [ARM] Allow Half types in ConstantPool.

LGTM, thanks

Feb 13 2018, 7:30 AM
olista01 accepted D43179: [Thumb] Handle addressing mode AddrMode5FP16.

LGTM, thanks

Feb 13 2018, 1:56 AM

Feb 12 2018

olista01 added inline comments to D42784: [ARM] Allow Half types in ConstantPool.
Feb 12 2018, 9:58 AM
olista01 added inline comments to D43179: [Thumb] Handle addressing mode AddrMode5FP16.
Feb 12 2018, 9:53 AM
olista01 committed rL324908: [AArch64] Improve v8.1-A code-gen for atomic load-and.
[AArch64] Improve v8.1-A code-gen for atomic load-and
Feb 12 2018, 9:06 AM
olista01 closed D42478: [AArch64] Improve v8.1-A code-gen for atomic load-and.
Feb 12 2018, 9:05 AM
olista01 committed rL324892: [AArch64] Improve v8.1-A code-gen for atomic load-subtract.
[AArch64] Improve v8.1-A code-gen for atomic load-subtract
Feb 12 2018, 6:24 AM
olista01 closed D42477: [AArch64] Improve v8.1-A code-gen for atomic load-subtract.
Feb 12 2018, 6:23 AM
olista01 added a comment to D43125: [ARM] Don't print "Requires NEON" error message for M-profile.

To have a better handling than this, we'd have to error out earlier saying M-class doesn't have NEON, which probably needs more knowledge than that piece of code has...

Feb 12 2018, 5:13 AM
olista01 added a comment to D42477: [AArch64] Improve v8.1-A code-gen for atomic load-subtract.

Geoff Berry suggested to do this in DAG Combine

Feb 12 2018, 5:08 AM
olista01 added a comment to D42477: [AArch64] Improve v8.1-A code-gen for atomic load-subtract.

Ping (also for the related D42478).

Feb 12 2018, 2:05 AM
olista01 added inline comments to D42784: [ARM] Allow Half types in ConstantPool.
Feb 12 2018, 1:55 AM

Feb 9 2018

olista01 added inline comments to D42784: [ARM] Allow Half types in ConstantPool.
Feb 9 2018, 7:08 AM
olista01 committed rL324731: [ELF] Print the .type assembly directive correctly for STT_NOTYPE.
[ELF] Print the .type assembly directive correctly for STT_NOTYPE
Feb 9 2018, 5:36 AM
olista01 closed D43116: [ELF] Print the .type assembly directive correctly for STT_NOTYPE.
Feb 9 2018, 5:36 AM
olista01 updated the diff for D43116: [ELF] Print the .type assembly directive correctly for STT_NOTYPE.

Add a triple to the test.

Feb 9 2018, 3:35 AM
olista01 created D43116: [ELF] Print the .type assembly directive correctly for STT_NOTYPE.
Feb 9 2018, 3:34 AM

Feb 8 2018

olista01 committed rL324606: [ARM] Re-commit r324600 with fixed LLVMBuild.txt.
[ARM] Re-commit r324600 with fixed LLVMBuild.txt
Feb 8 2018, 6:34 AM