Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People olista01

olista01 (Oliver Stannard)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 5 2014, 1:36 AM (503 w, 5 d)

Recent Activity
View All

Aug 29 2023

olista01 accepted D157865: [ARM] Fix prologue/epilogue for pacbti-m leaf functions.

LGTM

Aug 29 2023, 9:20 AM · Restricted Project, Restricted Project

Aug 24 2023

olista01 committed rG40614e1c1483: [ARM] Save and restore CPSR around tMOVimm32 (authored by olista01).
[ARM] Save and restore CPSR around tMOVimm32
Aug 24 2023, 6:16 AM · Restricted Project, Restricted Project
olista01 closed D158404: [ARM] Save and restore CPSR around tMOVimm32.
Aug 24 2023, 6:15 AM · Restricted Project, Restricted Project

Aug 22 2023

olista01 added reviewers for D158512: [AArch64] Add test showing incorrect code-gen: kristof.beyls, stuij.
Aug 22 2023, 6:49 AM · Restricted Project, Restricted Project
olista01 added reviewers for D158511: [AArch64] Fix incorrect outlining with SLS-hardening: kristof.beyls, paquette, stuij.
Aug 22 2023, 6:48 AM · Restricted Project, Restricted Project
olista01 requested review of D158512: [AArch64] Add test showing incorrect code-gen.
Aug 22 2023, 6:47 AM · Restricted Project, Restricted Project
olista01 requested review of D158511: [AArch64] Fix incorrect outlining with SLS-hardening.
Aug 22 2023, 6:46 AM · Restricted Project, Restricted Project
olista01 accepted D157620: [Thumb1] Do not allow Armv6-m XO and PI code.

LGTM

Aug 22 2023, 1:42 AM · Restricted Project, Restricted Project

Aug 21 2023

olista01 added reviewers for D158404: [ARM] Save and restore CPSR around tMOVimm32: keith.walker.arm, stuij.
Aug 21 2023, 3:44 AM · Restricted Project, Restricted Project
olista01 requested review of D158404: [ARM] Save and restore CPSR around tMOVimm32.
Aug 21 2023, 3:43 AM · Restricted Project, Restricted Project

Aug 17 2023

olista01 accepted D157500: [Thumb1] Use callee-saved register to adjust stack pointer.

LGTM

Aug 17 2023, 7:48 AM · Restricted Project, Restricted Project
olista01 added inline comments to D157620: [Thumb1] Do not allow Armv6-m XO and PI code.
Aug 17 2023, 7:17 AM · Restricted Project, Restricted Project

Aug 15 2023

olista01 requested changes to D157984: [llvm][ARM][Neon][big-endian] Fix incorrect indexing of lanes.

I don't think this is the right way to fix this. Endianness shouldn't affect the ordering of lanes in registers, only when they are stored to memory. We've got some documentation on this at https://llvm.org/docs/BigEndianNEON.html.

Aug 15 2023, 8:22 AM · Restricted Project, Restricted Project

Aug 11 2023

olista01 accepted D157688: [LowerTypeTests,ARM] Support Armv8-M BTI in jump tables..

Thanks, LGTM

Aug 11 2023, 5:21 AM · Restricted Project, Restricted Project
olista01 added inline comments to D157688: [LowerTypeTests,ARM] Support Armv8-M BTI in jump tables..
Aug 11 2023, 4:31 AM · Restricted Project, Restricted Project
olista01 added inline comments to D157688: [LowerTypeTests,ARM] Support Armv8-M BTI in jump tables..
Aug 11 2023, 2:50 AM · Restricted Project, Restricted Project

Aug 9 2023

olista01 added a comment to D157500: [Thumb1] Use callee-saved register to adjust stack pointer.

Do you have a test case for the situation where r4 is not saved?

Aug 9 2023, 7:31 AM · Restricted Project, Restricted Project

Aug 3 2023

olista01 added a comment to D156428: [AArch64][PtrAuth] Fix unwind state for tail calls.

Ticket for backport to LLVM 17: https://github.com/llvm/llvm-project/issues/64380

Aug 3 2023, 3:50 AM · Restricted Project, Restricted Project
olista01 committed rGf2e7285b03fb: [AArch64][PtrAuth] Fix unwind state for tail calls (authored by olista01).
[AArch64][PtrAuth] Fix unwind state for tail calls
Aug 3 2023, 3:46 AM · Restricted Project, Restricted Project
olista01 closed D156428: [AArch64][PtrAuth] Fix unwind state for tail calls.
Aug 3 2023, 3:46 AM · Restricted Project, Restricted Project
olista01 added a comment to D156428: [AArch64][PtrAuth] Fix unwind state for tail calls.

Right, thanks. Do you want to prepare a patch for this?

Aug 3 2023, 3:41 AM · Restricted Project, Restricted Project
olista01 updated the diff for D156428: [AArch64][PtrAuth] Fix unwind state for tail calls.
  • Updated sign-return-address.ll after D156327
  • Simplified llvm-dwarfdump checks
Aug 3 2023, 3:39 AM · Restricted Project, Restricted Project

Aug 2 2023

olista01 updated the diff for D156428: [AArch64][PtrAuth] Fix unwind state for tail calls.

Added full checking of the llvm-dwarfdump output.

Aug 2 2023, 8:33 AM · Restricted Project, Restricted Project

Jul 31 2023

olista01 updated the diff for D156428: [AArch64][PtrAuth] Fix unwind state for tail calls.
  • Don't emit .cfi_negate_ra_state for synchronous unwind tables
  • Convert test to update_llc_test_checks
  • Test sync and async unwind tables
Jul 31 2023, 6:01 AM · Restricted Project, Restricted Project

Jul 27 2023

olista01 accepted D156339: [ARM] Correctly handle combining segmented stacks with execute-only.

LGTM

Jul 27 2023, 9:07 AM · Restricted Project, Restricted Project
olista01 added reviewers for D156428: [AArch64][PtrAuth] Fix unwind state for tail calls: ikudrin, eli.friedman, MaskRay.
Jul 27 2023, 6:44 AM · Restricted Project, Restricted Project
olista01 requested review of D156428: [AArch64][PtrAuth] Fix unwind state for tail calls.
Jul 27 2023, 6:43 AM · Restricted Project, Restricted Project

Jul 13 2023

olista01 accepted D155170: [ARM] don't emit constant pool for Thumb1 XO/stack guard combo.

LGTM

Jul 13 2023, 9:17 AM · Restricted Project, Restricted Project
olista01 added a reverting change for D154281: [CodeGen] Store SP adjustment in MachineBasicBlock. NFCI.: rGaea8db8eb98d: Revert "[CodeGen] Store SP adjustment in MachineBasicBlock. NFCI.".
Jul 13 2023, 6:26 AM · Restricted Project, Restricted Project
olista01 added a reverting change for rG58d1eaa3b6ce: [CodeGen] Store SP adjustment in MachineBasicBlock. NFCI.: rGaea8db8eb98d: Revert "[CodeGen] Store SP adjustment in MachineBasicBlock. NFCI.".
Jul 13 2023, 6:26 AM · Restricted Project, Restricted Project
olista01 committed rGaea8db8eb98d: Revert "[CodeGen] Store SP adjustment in MachineBasicBlock. NFCI." (authored by olista01).
Revert "[CodeGen] Store SP adjustment in MachineBasicBlock. NFCI."
Jul 13 2023, 6:26 AM · Restricted Project, Restricted Project
olista01 added a comment to D154281: [CodeGen] Store SP adjustment in MachineBasicBlock. NFCI..

Hi, this change has caused a regression in one of our tests:

Jul 13 2023, 6:18 AM · Restricted Project, Restricted Project

Jul 10 2023

olista01 accepted D154304: [ARM] Replace OperandMatchResultTy with ParseStatus (NFC).

LGTM

Jul 10 2023, 4:25 AM · Restricted Project, Restricted Project

Jul 4 2023

olista01 accepted D154355: [ARM] make execute only long call test checks more robust.

One comment which would improve the robustness a bit more, other than that LGTM.

Jul 4 2023, 1:46 AM · Restricted Project, Restricted Project

Apr 20 2023

olista01 accepted D148508: [AArch64] Make stack tagging compatible with SLH.

LGTM

Apr 20 2023, 1:46 AM · Restricted Project, Restricted Project

Apr 13 2023

olista01 accepted D147715: [ARM] Fix Crashes in fp16/bf16 Inline Asm.

LGTM

Apr 13 2023, 5:04 AM · Restricted Project, Restricted Project

Apr 11 2023

olista01 added inline comments to D147715: [ARM] Fix Crashes in fp16/bf16 Inline Asm.
Apr 11 2023, 5:08 AM · Restricted Project, Restricted Project

Apr 4 2023

olista01 accepted D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments.

LGTM

Apr 4 2023, 2:57 AM · Restricted Project, Restricted Project

Mar 24 2023

olista01 added a comment to D146802: [Documentation] improved documentation of diagnostic messages by explaining thier syntax and test of clang by telling which subobject is uninitialized.

There is existing documentation of the diagnostics system here, which you could extend if something is still unclear or incomplete:

Mar 24 2023, 7:36 AM · Restricted Project, Restricted Project

Mar 2 2023

olista01 accepted D143711: [ARM] Fix Crash in 't'/'w' handling without fp16/bf16.

LGTM

Mar 2 2023, 6:19 AM · Restricted Project, Restricted Project

Mar 1 2023

olista01 accepted D145048: [ARM] Remove a redundant function fixupBTI.

LGTM

Mar 1 2023, 3:27 AM · Restricted Project, Restricted Project

Feb 28 2023

olista01 accepted D141819: [NFC][AArch64] Use 'i' to encode the offset form of load/store..

LGTM

Feb 28 2023, 1:07 AM · Restricted Project, Restricted Project

Feb 24 2023

olista01 accepted D142980: [ARM] Accept .w suffixes for some memory instructions.

LGTM

Feb 24 2023, 12:57 AM · Restricted Project, Restricted Project
olista01 accepted D144470: [ARM] Remove redundant BTI instructions for table jumps.

LGTM

Feb 24 2023, 12:55 AM · Restricted Project, Restricted Project

Feb 21 2023

olista01 added inline comments to D144470: [ARM] Remove redundant BTI instructions for table jumps.
Feb 21 2023, 9:00 AM · Restricted Project, Restricted Project

Feb 10 2023

olista01 accepted D143711: [ARM] Fix Crash in 't'/'w' handling without fp16/bf16.

LGTM, with one comment in the test.

Feb 10 2023, 7:21 AM · Restricted Project, Restricted Project

Feb 9 2023

olista01 added a comment to D142980: [ARM] Accept .w suffixes for some memory instructions.

There are a number of closely related instructions which have the same problem, would it make sense to do them at the same time?

  • LDRSB
  • LDRH
  • LDRSH
  • STRH
Feb 9 2023, 8:15 AM · Restricted Project, Restricted Project

Feb 8 2023

olista01 added a comment to D143576: [LowerTypeTests] Support generating Armv6-M jump tables..

Could we move the whole of createJumpTableEntry (and getJumpTableEntrySize, maybe others) into TargetTransformInfo? That would move all of the existing target-specific code here into the respective backends, and avoid adding target-specific things to the interface of TargetTransformInfo`.

Feb 8 2023, 7:40 AM · Restricted Project, Restricted Project

Jan 13 2023

olista01 accepted D141405: [ARM] Accept two-register form of vnmul.

LGTM

Jan 13 2023, 6:28 AM · Restricted Project, Restricted Project

Jan 12 2023

olista01 added inline comments to D141405: [ARM] Accept two-register form of vnmul.
Jan 12 2023, 2:58 AM · Restricted Project, Restricted Project

Nov 21 2022

olista01 accepted D138143: [FPEnv] Enable strict fp for AArch64 in clang.

LGTM

Nov 21 2022, 1:54 AM · Restricted Project, Restricted Project

Oct 7 2019

olista01 closed D36747: [Asm, ARM] Add fallback diag for multiple invalid operands.
Oct 7 2019, 5:06 AM · Restricted Project

Apr 11 2019

olista01 committed rG6fa145e429b7: Test commit access (authored by olista01).
Test commit access
Apr 11 2019, 5:52 AM

Mar 29 2019

olista01 committed rGd83a559318a5: [AArch64] Support selecting TPIDR_EL[1-3] as the thread base (authored by olista01).
[AArch64] Support selecting TPIDR_EL[1-3] as the thread base
Mar 29 2019, 6:32 AM
olista01 committed rL357250: [AArch64] Support selecting TPIDR_EL[1-3] as the thread base.
[AArch64] Support selecting TPIDR_EL[1-3] as the thread base
Mar 29 2019, 6:31 AM
olista01 committed rC357250: [AArch64] Support selecting TPIDR_EL[1-3] as the thread base.
[AArch64] Support selecting TPIDR_EL[1-3] as the thread base
Mar 29 2019, 6:31 AM
olista01 closed D59631: [AArch64] Support selecting TPIDR_EL[1-3] as the thread base.
Mar 29 2019, 6:31 AM · Restricted Project
olista01 accepted D59631: [AArch64] Support selecting TPIDR_EL[1-3] as the thread base.

I can't see any other uses of the option groups, or any way to put an option into two groups, so this LGTM.

Mar 29 2019, 6:00 AM · Restricted Project
olista01 added inline comments to D59787: [ARM] Implement TTI::getMemcpyCost.
Mar 29 2019, 3:29 AM · Restricted Project

Mar 26 2019

olista01 committed rG5c9023847919: [ARM][Asm] Accept upper case coprocessor number and registers (authored by olista01).
[ARM][Asm] Accept upper case coprocessor number and registers
Mar 26 2019, 3:25 AM
olista01 committed rL356984: [ARM][Asm] Accept upper case coprocessor number and registers.
[ARM][Asm] Accept upper case coprocessor number and registers
Mar 26 2019, 3:25 AM
olista01 closed D59760: [ARM][Asm] Accept upper case coprocessor number and registers.
Mar 26 2019, 3:25 AM · Restricted Project

Mar 25 2019

olista01 created D59760: [ARM][Asm] Accept upper case coprocessor number and registers.
Mar 25 2019, 4:15 AM · Restricted Project

Mar 21 2019

olista01 added a reviewer for D59631: [AArch64] Support selecting TPIDR_EL[1-3] as the thread base: olista01.

Is there an existing compiler which this option is trying to be compatible with? GCC for AArch64 doesn't currently have an option for this, so we don't have to worry about compatibility with that. If possible, I'd prefer for the option to be "-mtp=", to match the option accepted by clang and GCC for AArch32.

Mar 21 2019, 5:56 AM · Restricted Project
olista01 committed rGdefdb1070fbc: [AArch64] Allow -mattr=tpidr-el[1|2|3] (authored by olista01).
[AArch64] Allow -mattr=tpidr-el[1|2|3]
Mar 21 2019, 4:30 AM
olista01 committed rL356657: [AArch64] Allow -mattr=tpidr-el[1|2|3].
[AArch64] Allow -mattr=tpidr-el[1|2|3]
Mar 21 2019, 4:29 AM
olista01 closed D54685: [AArch64] Allow -mattr=tpidr-el[1|2|3].
Mar 21 2019, 4:29 AM · Restricted Project

Mar 20 2019

olista01 accepted D54685: [AArch64] Allow -mattr=tpidr-el[1|2|3].

LGTM. Do you have commit access? If not, I can commit this for you.

Mar 20 2019, 3:12 AM · Restricted Project
olista01 accepted D59568: [ARM] Eliminate redundant "mov rN, sp" instructions in Thumb1..

LGTM

Mar 20 2019, 3:00 AM · Restricted Project

Mar 18 2019

olista01 accepted D59439: [ARM] Make sure to save/restore LR when we use tBfar..

LGTM with one nit .

Mar 18 2019, 6:15 AM · Restricted Project

Mar 14 2019

olista01 accepted D57765: [ARM] Add Cortex-M35P Support.

LGTM

Mar 14 2019, 3:32 AM · Restricted Project, Restricted Project
olista01 accepted D57763: [ARM] Add Cortex-M35P.
Mar 14 2019, 3:00 AM · Restricted Project

Mar 8 2019

olista01 accepted D59021: [ARM] [FIX] Restrict vfmal.f16 and vfmsl.f16 indexed version.

LGTM

Mar 8 2019, 9:00 AM · Restricted Project

Mar 5 2019

olista01 committed rG4a9086b53737: [ARM] Fix select_cc lowering for fp16 (authored by olista01).
[ARM] Fix select_cc lowering for fp16
Mar 5 2019, 2:43 AM
olista01 committed rL355385: [ARM] Fix select_cc lowering for fp16.
[ARM] Fix select_cc lowering for fp16
Mar 5 2019, 2:43 AM
olista01 closed D58813: [ARM] Fix select_cc lowering for fp16.
Mar 5 2019, 2:43 AM · Restricted Project

Mar 4 2019

olista01 committed rG181afc7f3bb9: [ARM] Fix selection of VLDR.16 instruction with imm offset (authored by olista01).
[ARM] Fix selection of VLDR.16 instruction with imm offset
Mar 4 2019, 1:17 AM
olista01 committed rL355305: [ARM] Fix selection of VLDR.16 instruction with imm offset.
[ARM] Fix selection of VLDR.16 instruction with imm offset
Mar 4 2019, 1:17 AM
olista01 closed D58822: [ARM] Fix selection of VLDR.16 instruction with imm offset.
Mar 4 2019, 1:17 AM · Restricted Project

Mar 1 2019

olista01 committed rG82fbbc21fdff: [ARM] Fix FP16 stack loads/stores for Thumb2 with frame pointer (authored by olista01).
[ARM] Fix FP16 stack loads/stores for Thumb2 with frame pointer
Mar 1 2019, 6:20 AM
olista01 committed rL355201: [ARM] Fix FP16 stack loads/stores for Thumb2 with frame pointer.
[ARM] Fix FP16 stack loads/stores for Thumb2 with frame pointer
Mar 1 2019, 6:19 AM
olista01 closed D58816: [ARM] Fix FP16 stack loads/stores for Thumb2 with frame pointer.
Mar 1 2019, 6:19 AM · Restricted Project
olista01 added inline comments to D58813: [ARM] Fix select_cc lowering for fp16.
Mar 1 2019, 6:12 AM · Restricted Project
olista01 committed rGe019e6223b63: [ARM] Consider undefined-on-NaN conditions in checkVSELConstraints (authored by olista01).
[ARM] Consider undefined-on-NaN conditions in checkVSELConstraints
Mar 1 2019, 5:58 AM
olista01 committed rL355199: [ARM] Consider undefined-on-NaN conditions in checkVSELConstraints.
[ARM] Consider undefined-on-NaN conditions in checkVSELConstraints
Mar 1 2019, 5:57 AM
olista01 closed D58812: [ARM] Consider undefined-on-NaN conditions in checkVSELConstraints.
Mar 1 2019, 5:57 AM · Restricted Project
olista01 created D58822: [ARM] Fix selection of VLDR.16 instruction with imm offset.
Mar 1 2019, 5:54 AM · Restricted Project
olista01 created D58816: [ARM] Fix FP16 stack loads/stores for Thumb2 with frame pointer.
Mar 1 2019, 3:42 AM · Restricted Project
olista01 created D58813: [ARM] Fix select_cc lowering for fp16.
Mar 1 2019, 1:28 AM · Restricted Project
olista01 created D58812: [ARM] Consider undefined-on-NaN conditions in checkVSELConstraints.
Mar 1 2019, 1:28 AM · Restricted Project
olista01 committed rG1ed7d8ae36c6: [ARM] Add armv8a triple to test check updaters (authored by olista01).
[ARM] Add armv8a triple to test check updaters
Mar 1 2019, 1:26 AM
olista01 committed rL355186: [ARM] Add armv8a triple to test check updaters.
[ARM] Add armv8a triple to test check updaters
Mar 1 2019, 1:25 AM

Feb 21 2019

olista01 accepted D58059: [AArch64] Print instruction before atomic semantic annotations.

LGTM

Feb 21 2019, 1:53 AM · Restricted Project

Feb 18 2019

olista01 committed rGe3c8ce8b7547: [ARM] Add pre-defined macros for ROPI and RWPI (authored by olista01).
[ARM] Add pre-defined macros for ROPI and RWPI
Feb 18 2019, 4:40 AM
olista01 committed rC354265: [ARM] Add pre-defined macros for ROPI and RWPI.
[ARM] Add pre-defined macros for ROPI and RWPI
Feb 18 2019, 4:39 AM
olista01 committed rL354265: [ARM] Add pre-defined macros for ROPI and RWPI.
[ARM] Add pre-defined macros for ROPI and RWPI
Feb 18 2019, 4:39 AM
olista01 closed D23610: [ARM] Add pre-defined macros for ROPI and RWPI.
Feb 18 2019, 4:39 AM · Restricted Project
olista01 added a comment to D23610: [ARM] Add pre-defined macros for ROPI and RWPI.

Yes, the back-end work was all done years ago, I just also forgot about these while waiting for the ACLE to be published.

Feb 18 2019, 4:38 AM · Restricted Project
Herald added a project to D54791: [AArch64] Fix disassembly of SXTL and UXTL aliases: Restricted Project.

Ping

Feb 18 2019, 3:12 AM · Restricted Project
olista01 added a comment to D23610: [ARM] Add pre-defined macros for ROPI and RWPI.

These macros have been in the published ACLE for a while now: https://developer.arm.com/products/software-development-tools/compilers/arm-compiler-5/docs/101028/latest/5-feature-test-macros#position-independent-code

Feb 18 2019, 3:08 AM · Restricted Project