Page MenuHomePhabricator

[AArch64] Add support for ls64 to the .arch_extension asm directive
ClosedPublic

Authored by pratlucas on Dec 3 2020, 6:36 AM.

Details

Summary

This adds support for the 'ls64' AArch64 extension to the .arch_extension
asm directive.

Diff Detail

Event Timeline

pratlucas created this revision.Dec 3 2020, 6:36 AM
pratlucas requested review of this revision.Dec 3 2020, 6:36 AM
pratlucas updated this revision to Diff 309248.Dec 3 2020, 7:06 AM

Reducing scope to 'ls64' extension only.

pratlucas retitled this revision from [AArch64] Add support for brbe, ls64, spe-eef and wfxt to .arch_extension to [AArch64] Add support for ls64 to the .arch_extension asm directive.Dec 3 2020, 7:07 AM
pratlucas edited the summary of this revision. (Show Details)
ostannard added inline comments.Dec 18 2020, 1:42 AM
llvm/test/MC/AArch64/directive-arch_extension-negative.s
87

This feature isn't enabled by default, so I'd expect this test to still pass even if the .arch_extension nols64 line was removed. We should enable all of these extensions with command-line options to llvm-mc, and probably add checks that the instructions are accepted before the extension is disabled.

This is an existing problem with many of the other tests in this file, so doing this as a separate patch would be best.

pratlucas marked an inline comment as done.
pratlucas added inline comments.
llvm/test/MC/AArch64/directive-arch_extension-negative.s
87

I've updated the test on D93538.

This revision is now accepted and ready to land.Dec 18 2020, 6:17 AM
This revision was landed with ongoing or failed builds.Dec 18 2020, 7:56 AM
This revision was automatically updated to reflect the committed changes.
pratlucas marked an inline comment as done.