Page MenuHomePhabricator

vhscampos (Victor Campos)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2015, 11:50 AM (304 w, 6 d)

Recent Activity

Apr 21 2021

vhscampos committed rGee3e01627ff8: [Clang][ARM] Define __VFP_FP__ macro unconditionally (authored by vhscampos).
[Clang][ARM] Define __VFP_FP__ macro unconditionally
Apr 21 2021, 7:04 AM
vhscampos closed D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally.
Apr 21 2021, 7:04 AM · Restricted Project
vhscampos added a comment to D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally.

Thanks Peter. Since one week has passed, I plan to commit these changes by the end of the day if nothing surfaces.

Apr 21 2021, 1:29 AM · Restricted Project

Apr 15 2021

vhscampos updated the diff for D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally.

Add a clarifying comment.

Apr 15 2021, 5:05 AM · Restricted Project

Apr 13 2021

vhscampos added reviewers for D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally: stuij, miyuki, SjoerdMeijer.
Apr 13 2021, 2:25 AM · Restricted Project
vhscampos requested review of D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally.
Apr 13 2021, 2:06 AM · Restricted Project

Mar 23 2021

vhscampos committed rGf22b4c7122bc: [ARM] Handle debug instrs in ARM Low Overhead Loop pass (authored by vhscampos).
[ARM] Handle debug instrs in ARM Low Overhead Loop pass
Mar 23 2021, 4:49 AM
vhscampos closed D99075: [ARM] Handle debug instrs in ARM Low Overhead Loop pass.
Mar 23 2021, 4:49 AM · Restricted Project
vhscampos updated the diff for D99075: [ARM] Handle debug instrs in ARM Low Overhead Loop pass.

Remove if statement inside RemovePredicate as it's already covered by an assertion.

Mar 23 2021, 4:45 AM · Restricted Project
vhscampos updated the diff for D99075: [ARM] Handle debug instrs in ARM Low Overhead Loop pass.

Remove predicate of instructions after the divergent one even if there's no non-debug instruction after it.

Mar 23 2021, 4:14 AM · Restricted Project

Mar 22 2021

vhscampos updated the diff for D99075: [ARM] Handle debug instrs in ARM Low Overhead Loop pass.

Add assertion in RemovePredicate lambda.
SKip debug instructions inside VPT blocks with predicate divergence.

Mar 22 2021, 9:24 AM · Restricted Project
vhscampos added a reviewer for D99075: [ARM] Handle debug instrs in ARM Low Overhead Loop pass: samparker.
Mar 22 2021, 7:04 AM · Restricted Project
vhscampos requested review of D99075: [ARM] Handle debug instrs in ARM Low Overhead Loop pass.
Mar 22 2021, 7:01 AM · Restricted Project

Mar 12 2021

vhscampos accepted D98510: [Clang][ARM] Reenable arm_acle.c test..

LGTM. mem2reg is a simple enough optimization to clear up the IR in this case. Thank you.

Mar 12 2021, 7:34 AM · Restricted Project

Dec 8 2020

vhscampos abandoned D90845: [libunwind] Create CREDITS.TXT file.
Dec 8 2020, 9:01 AM · Restricted Project, Restricted Project

Nov 6 2020

vhscampos added a comment to D88645: [Annotation] Allows annotation to carry some additional constant arguments..

@Tyker This is causing another build failure in another example:

Nov 6 2020, 7:34 AM · Restricted Project, Restricted Project

Nov 5 2020

vhscampos added reviewers for D90845: [libunwind] Create CREDITS.TXT file: chandlerc, aadg.
Nov 5 2020, 6:04 AM · Restricted Project, Restricted Project
vhscampos accepted D90594: [AArch64] Enable RAS 1.1 system registers in all AArch64.
Nov 5 2020, 6:03 AM · Restricted Project
vhscampos requested review of D90845: [libunwind] Create CREDITS.TXT file.
Nov 5 2020, 5:59 AM · Restricted Project, Restricted Project

Aug 4 2020

vhscampos abandoned D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing.
Aug 4 2020, 3:54 AM · Restricted Project
vhscampos added a comment to D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing.

Not really. Closing it

Aug 4 2020, 3:54 AM · Restricted Project

Jul 29 2020

vhscampos committed rG71bf6dd682c0: [Driver][ARM] Fix testcase that should only run on ARM (authored by vhscampos).
[Driver][ARM] Fix testcase that should only run on ARM
Jul 29 2020, 6:41 AM
vhscampos committed rGd1a3396bfbc6: [Driver][ARM] Disable unsupported features when nofp arch extension is used (authored by vhscampos).
[Driver][ARM] Disable unsupported features when nofp arch extension is used
Jul 29 2020, 6:20 AM
vhscampos closed D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.
Jul 29 2020, 6:19 AM · Restricted Project, Restricted Project

Jul 23 2020

vhscampos updated the diff for D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.
  1. Add comment explaining the MVE-Integer detail.
  2. Add another test to check the disabled features.
Jul 23 2020, 4:20 AM · Restricted Project, Restricted Project

Jul 21 2020

vhscampos added a comment to D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.

Ping.

Jul 21 2020, 2:40 AM · Restricted Project, Restricted Project

Jul 14 2020

vhscampos committed rGdad1868772f1: [AArch64][AsmParser] Add rcpc support in .arch_extension (authored by vhscampos).
[AArch64][AsmParser] Add rcpc support in .arch_extension
Jul 14 2020, 2:58 AM
vhscampos closed D83685: [AArch64][AsmParser] Add rcpc support in .arch_extension.
Jul 14 2020, 2:57 AM · Restricted Project

Jul 13 2020

vhscampos added a reviewer for D83685: [AArch64][AsmParser] Add rcpc support in .arch_extension: samparker.
Jul 13 2020, 8:29 AM · Restricted Project
Herald added a project to D83685: [AArch64][AsmParser] Add rcpc support in .arch_extension: Restricted Project.
Jul 13 2020, 8:25 AM · Restricted Project

Jul 3 2020

vhscampos updated the diff for D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.
  1. Merged the second patch into this (handle bf16).
  2. Do the same treatment for -mcpu.
  3. Instead of doing string search once again, return the desired information in the first time using a by-ref argument.
  4. This new approach covers positional differences between +fp and +nofp.
Jul 3 2020, 8:02 AM · Restricted Project, Restricted Project

Jul 2 2020

vhscampos added inline comments to D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.
Jul 2 2020, 6:57 AM · Restricted Project, Restricted Project
vhscampos added a comment to D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.

I will merge the two patches into one.

Jul 2 2020, 2:05 AM · Restricted Project, Restricted Project

Jul 1 2020

vhscampos added a reviewer for D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing: chill.
Jul 1 2020, 4:49 AM · Restricted Project
vhscampos added a reviewer for D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used: chill.
Jul 1 2020, 4:49 AM · Restricted Project, Restricted Project
vhscampos retitled D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing from Disable bf16 when hardware FP support is missing to [Driver][ARM] Disable bf16 when hardware FP support is missing.
Jul 1 2020, 4:49 AM · Restricted Project
vhscampos created D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing.
Jul 1 2020, 4:49 AM · Restricted Project
vhscampos created D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.
Jul 1 2020, 4:49 AM · Restricted Project, Restricted Project
vhscampos abandoned D82947: [Driver][ARM] Disable unsupported features when nofp arch extension is used.
Jul 1 2020, 4:49 AM · Restricted Project
vhscampos abandoned D82946: [Driver][ARM] Disable bf16 when hardware FP support is missing.
Jul 1 2020, 4:49 AM · Restricted Project
vhscampos created D82947: [Driver][ARM] Disable unsupported features when nofp arch extension is used.
Jul 1 2020, 4:49 AM · Restricted Project
vhscampos created D82946: [Driver][ARM] Disable bf16 when hardware FP support is missing.
Jul 1 2020, 4:49 AM · Restricted Project

Jun 25 2020

vhscampos committed rGda852b03b009: [AArch64] Emit warning when disassembling unpredictable LDRAA and LDRAB (authored by vhscampos).
[AArch64] Emit warning when disassembling unpredictable LDRAA and LDRAB
Jun 25 2020, 8:01 AM
vhscampos closed D82541: [AArch64] Emit warning when disassembling unpredictable LDRAA and LDRAB.
Jun 25 2020, 8:01 AM · Restricted Project
vhscampos added inline comments to D82541: [AArch64] Emit warning when disassembling unpredictable LDRAA and LDRAB.
Jun 25 2020, 7:25 AM · Restricted Project
vhscampos created D82541: [AArch64] Emit warning when disassembling unpredictable LDRAA and LDRAB.
Jun 25 2020, 4:42 AM · Restricted Project
vhscampos added a reviewer for D82541: [AArch64] Emit warning when disassembling unpredictable LDRAA and LDRAB: ostannard.
Jun 25 2020, 4:42 AM · Restricted Project

Jun 24 2020

vhscampos committed rG1b090db0df47: [ARM] Improve diagnostics message when Neon is unsupported (authored by vhscampos).
[ARM] Improve diagnostics message when Neon is unsupported
Jun 24 2020, 2:40 AM
vhscampos closed D81847: [ARM] Improve diagnostics message when Neon is unsupported.
Jun 24 2020, 2:40 AM · Restricted Project

Jun 15 2020

vhscampos created D81847: [ARM] Improve diagnostics message when Neon is unsupported.
Jun 15 2020, 9:13 AM · Restricted Project
vhscampos added a reviewer for D81847: [ARM] Improve diagnostics message when Neon is unsupported: stuij.
Jun 15 2020, 9:13 AM · Restricted Project

May 28 2020

vhscampos added a comment to D79778: [CodeGen] Remove buggy handling of input operands in inline asm.

This is the problematic case:

May 28 2020, 6:30 AM · Restricted Project
vhscampos committed rGc010d4d19550: [ARM] Improve codegen of volatile load/store of i64 (authored by vhscampos).
[ARM] Improve codegen of volatile load/store of i64
May 28 2020, 3:13 AM
vhscampos closed D70072: [ARM] Improve codegen of volatile load/store of i64.
May 28 2020, 3:13 AM · Restricted Project

May 27 2020

vhscampos requested review of D70072: [ARM] Improve codegen of volatile load/store of i64.
May 27 2020, 8:05 AM · Restricted Project
vhscampos updated the diff for D70072: [ARM] Improve codegen of volatile load/store of i64.

Improve the testcase which exercises loads and stores from stack. Now, wrong frame index replacements will be caught here.

May 27 2020, 8:05 AM · Restricted Project
vhscampos reopened D70072: [ARM] Improve codegen of volatile load/store of i64.
May 27 2020, 8:05 AM · Restricted Project
vhscampos committed rGc7593b0f0d28: [ARM] Fix rewrite of frame index in Thumb2's address mode i8s4 (authored by vhscampos).
[ARM] Fix rewrite of frame index in Thumb2's address mode i8s4
May 27 2020, 5:22 AM
vhscampos closed D80557: [ARM] Fix rewrite of frame index in Thumb2's address mode i8s4.
May 27 2020, 5:22 AM · Restricted Project

May 26 2020

vhscampos added a reviewer for D80557: [ARM] Fix rewrite of frame index in Thumb2's address mode i8s4: efriedma.
May 26 2020, 8:38 AM · Restricted Project
vhscampos retitled D80557: [ARM] Fix rewrite of frame index in Thumb2's address mode i8s4 from [ARM] fix rewrite of frame index in Thumb2's address mode i8s4 to [ARM] Fix rewrite of frame index in Thumb2's address mode i8s4.
May 26 2020, 8:38 AM · Restricted Project
vhscampos created D80557: [ARM] Fix rewrite of frame index in Thumb2's address mode i8s4.
May 26 2020, 8:38 AM · Restricted Project

May 22 2020

vhscampos committed rG872ee78f65f4: Revert "[ARM] Improve codegen of volatile load/store of i64" (authored by vhscampos).
Revert "[ARM] Improve codegen of volatile load/store of i64"
May 22 2020, 3:36 AM
vhscampos added a reverting change for rG8a1255322318: [ARM] Improve codegen of volatile load/store of i64: rG872ee78f65f4: Revert "[ARM] Improve codegen of volatile load/store of i64".
May 22 2020, 3:36 AM

May 13 2020

vhscampos committed rGcac6a26f3813: [TableGen] Fix register class handling in TableGen's DAG ISel Matcher Generator (authored by vhscampos).
[TableGen] Fix register class handling in TableGen's DAG ISel Matcher Generator
May 13 2020, 2:39 AM
vhscampos closed D79705: [TableGen] Fix register class handling in TableGen's DAG ISel Matcher Generator.
May 13 2020, 2:39 AM · Restricted Project
vhscampos added a comment to D79778: [CodeGen] Remove buggy handling of input operands in inline asm.

This effort is to specifically address this bug: https://bugs.llvm.org/show_bug.cgi?id=34165

May 13 2020, 1:34 AM · Restricted Project

May 12 2020

vhscampos updated the diff for D79705: [TableGen] Fix register class handling in TableGen's DAG ISel Matcher Generator.

Added a test.

May 12 2020, 9:07 AM · Restricted Project
vhscampos added a reviewer for D79778: [CodeGen] Remove buggy handling of input operands in inline asm: efriedma.
May 12 2020, 5:52 AM · Restricted Project
vhscampos added a comment to D79716: [CodeGen] Fix bug in inline asm reserved register detection.

Thanks @efriedma for the clarification. It seems that the handling of input operands must be moved to clang then.

May 12 2020, 5:52 AM · Restricted Project
vhscampos created D79778: [CodeGen] Remove buggy handling of input operands in inline asm.
May 12 2020, 5:52 AM · Restricted Project

May 11 2020

vhscampos created D79716: [CodeGen] Fix bug in inline asm reserved register detection.
May 11 2020, 7:29 AM · Restricted Project
vhscampos created D79705: [TableGen] Fix register class handling in TableGen's DAG ISel Matcher Generator.
May 11 2020, 4:15 AM · Restricted Project
vhscampos added a reviewer for D79705: [TableGen] Fix register class handling in TableGen's DAG ISel Matcher Generator: rampitec.
May 11 2020, 4:15 AM · Restricted Project

Apr 29 2020

vhscampos committed rGd3dc4c32afb4: [AArch64] Remove inexistent system register ERXTS_EL1 (authored by vhscampos).
[AArch64] Remove inexistent system register ERXTS_EL1
Apr 29 2020, 9:06 AM
vhscampos closed D79007: [AArch64] Remove inexistent system register ERXTS_EL1.
Apr 29 2020, 9:06 AM · Restricted Project

Apr 28 2020

vhscampos added a comment to D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

This change isn't more restrictive than GCC. In your example, the difference is being caused by gcc seemingly adding -fomit-frame-pointer, whereas Clang does not.

Apr 28 2020, 10:11 AM · Restricted Project
vhscampos added a comment to D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

Hi @manojgupta. I am not familiar enough with this piece of code to understand whether it could be fixed by simply using any other general-purpose register instead of r7.

Apr 28 2020, 8:34 AM · Restricted Project
vhscampos added a reviewer for D79007: [AArch64] Remove inexistent system register ERXTS_EL1: SjoerdMeijer.
Apr 28 2020, 8:01 AM · Restricted Project
vhscampos created D79007: [AArch64] Remove inexistent system register ERXTS_EL1.
Apr 28 2020, 8:01 AM · Restricted Project

Apr 16 2020

vhscampos added a comment to D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

Thanks @saugustine.

Apr 16 2020, 2:14 AM · Restricted Project

Apr 15 2020

vhscampos committed rGd85b3877dcd2: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm (authored by vhscampos).
[CodeGen][ARM] Error when writing to specific reserved registers in inline asm
Apr 15 2020, 7:07 AM
vhscampos closed D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.
Apr 15 2020, 7:06 AM · Restricted Project

Apr 8 2020

vhscampos updated the diff for D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

Amended commit msg to explain why clobber operands are not handled.

Apr 8 2020, 5:23 AM · Restricted Project
vhscampos added a comment to D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

Clobber operands are intentionally not handled in this patch. They were already covered in AsmPrinter::emitInlineAsm(const MachineInstr *MI), even though, in the latter, only a warning is given, not an error.

Apr 8 2020, 5:23 AM · Restricted Project
vhscampos updated the summary of D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.
Apr 8 2020, 5:23 AM · Restricted Project

Apr 2 2020

vhscampos retitled D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm from [CodeGen] Error when writing to reserved registers in inline asm to [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.
Apr 2 2020, 2:08 AM · Restricted Project
vhscampos updated the diff for D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

The patch has been redone to detect only writes to PC, base pointer and
frame pointer on ARM target. Similar implementations can be done for
other targets as the base class's function is virtual.

Apr 2 2020, 2:08 AM · Restricted Project

Mar 30 2020

vhscampos added a comment to D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

Indeed, it seems that gcc allows the use of SP in inline asm.

Mar 30 2020, 5:22 AM · Restricted Project

Mar 27 2020

vhscampos added a comment to D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

I should have given more context, so let me amend that.

Mar 27 2020, 4:50 AM · Restricted Project

Mar 26 2020

vhscampos added a comment to D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

It is diagnosing the same cases as the similar check present in CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp, lines 549-585. The latter, however, only covers clobber operands, leaving input and output operands unchecked.

Mar 26 2020, 10:18 AM · Restricted Project
vhscampos updated the diff for D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.

Fixing naming issue detected by clang-tidy.

Mar 26 2020, 8:38 AM · Restricted Project
vhscampos added a reviewer for D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm: efriedma.
Mar 26 2020, 8:06 AM · Restricted Project
vhscampos created D76848: [CodeGen][ARM] Error when writing to specific reserved registers in inline asm.
Mar 26 2020, 7:33 AM · Restricted Project

Mar 11 2020

vhscampos committed rG8a1255322318: [ARM] Improve codegen of volatile load/store of i64 (authored by vhscampos).
[ARM] Improve codegen of volatile load/store of i64
Mar 11 2020, 3:47 AM
vhscampos closed D70072: [ARM] Improve codegen of volatile load/store of i64.
Mar 11 2020, 3:47 AM · Restricted Project
vhscampos updated the diff for D70072: [ARM] Improve codegen of volatile load/store of i64.

Added comment to explain the fallback to non-register-offset variants.

Mar 11 2020, 3:47 AM · Restricted Project

Mar 10 2020

vhscampos requested review of D70072: [ARM] Improve codegen of volatile load/store of i64.

Can I please have this reviewed again? I have addressed the issues reported.

Mar 10 2020, 10:19 AM · Restricted Project
vhscampos updated the summary of D70072: [ARM] Improve codegen of volatile load/store of i64.
Mar 10 2020, 10:19 AM · Restricted Project
vhscampos updated the diff for D70072: [ARM] Improve codegen of volatile load/store of i64.
  1. Explictly avoid using the register-offset variant of LDRD/STRD. This variant has a limitation on register allocation: the register allocated to the register-offset cannot be reused in any of the remaining operands. I could not find an easy way to implement this in LLVM, so I left it as a to-do in the future.
  2. Instruction selection of STRD was moved from TableGen to C++ because of point (1).
  3. Updated tests to reflect these changes.
Mar 10 2020, 10:19 AM · Restricted Project