Page MenuHomePhabricator

vhscampos (Victor Campos)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2015, 11:50 AM (358 w, 1 d)

Recent Activity

Apr 5 2022

vhscampos accepted D123111: [AArch64] Make PMMIR_EL1 read-only..

LGTM.

Apr 5 2022, 2:56 AM · Restricted Project, Restricted Project
vhscampos added inline comments to D123111: [AArch64] Make PMMIR_EL1 read-only..
Apr 5 2022, 2:38 AM · Restricted Project, Restricted Project

Mar 18 2022

vhscampos accepted D121983: Driver: Don't warn on -mbranch-protection when linking.

LGTM, thanks

Mar 18 2022, 1:49 AM · Restricted Project, Restricted Project

Feb 22 2022

vhscampos accepted D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo.

LGTM

Feb 22 2022, 2:20 AM · Restricted Project

Feb 21 2022

vhscampos added a comment to D116153: [ARM][AArch64] Add missing v8.x checks.

I don't see any problem with the patch, but we should wait on @SjoerdMeijer.

Feb 21 2022, 7:43 AM · Restricted Project

Jan 4 2022

vhscampos added inline comments to D116154: [ARM] Adding macros for coprocessor intrinsics as per ACLE.
Jan 4 2022, 4:10 AM · Restricted Project

Dec 10 2021

vhscampos accepted D115507: Add PACBTI-M support to LLVM release notes..

LGTM.

Dec 10 2021, 3:39 AM · Restricted Project, Restricted Project

Nov 29 2021

vhscampos accepted D112421: [clang][ARM] PACBTI-M frontend support.
Nov 29 2021, 1:52 AM · Restricted Project, Restricted Project

Nov 25 2021

vhscampos added inline comments to D112421: [clang][ARM] PACBTI-M frontend support.
Nov 25 2021, 8:38 AM · Restricted Project, Restricted Project

Oct 28 2021

vhscampos added inline comments to D112421: [clang][ARM] PACBTI-M frontend support.
Oct 28 2021, 8:24 AM · Restricted Project, Restricted Project
vhscampos added inline comments to D112420: [clang][ARM] PACBTI-M assembly support.
Oct 28 2021, 7:29 AM · Restricted Project, Restricted Project

Oct 19 2021

vhscampos added a comment to D109246: [AArch64][MC] Merge FeaturePMU into FeaturePerfMon.

Hi. Yes, it is intended behaviour. New system registers are usually available unconditionally. Typically only instructions are conditioned on target features.

Oct 19 2021, 5:11 AM · Restricted Project

Oct 12 2021

vhscampos committed rG3e7cf33a8376: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang (authored by vhscampos).
[docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang
Oct 12 2021, 12:41 AM
vhscampos closed D110241: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang.
Oct 12 2021, 12:41 AM · Restricted Project, Restricted Project

Oct 11 2021

vhscampos committed rG3550e242fad6: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A (authored by vhscampos).
[Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A
Oct 11 2021, 9:45 AM
vhscampos closed D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.
Oct 11 2021, 9:45 AM · Restricted Project, Restricted Project

Oct 5 2021

vhscampos added a comment to D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.

To the relevant persons I have just added to the review: @srhines @nickdesaulniers @llozano

Oct 5 2021, 2:53 AM · Restricted Project, Restricted Project
vhscampos added reviewers for D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A: srhines, nickdesaulniers, llozano.
Oct 5 2021, 2:50 AM · Restricted Project, Restricted Project

Sep 30 2021

vhscampos updated the diff for D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.
  1. Disable the cryptographic extensions by default.
  2. Small fix in TargetParserTest.cpp to include different spellings of the -march values.
Sep 30 2021, 8:08 AM · Restricted Project, Restricted Project

Sep 22 2021

vhscampos updated the diff for D110241: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang.

Added 'the' for better phrasing.

Sep 22 2021, 6:39 AM · Restricted Project, Restricted Project
vhscampos added a reviewer for D110241: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang: pratlucas.
Sep 22 2021, 6:18 AM · Restricted Project, Restricted Project
vhscampos requested review of D110241: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang.
Sep 22 2021, 6:16 AM · Restricted Project, Restricted Project
vhscampos updated the diff for D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.

Add missing . to end of sentences in comments.

Sep 22 2021, 2:14 AM · Restricted Project, Restricted Project

Sep 21 2021

vhscampos requested review of D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.

Sorry @SjoerdMeijer , I found a bug in the implementation (as described in the latest comment). Therefore I kindly ask another round of review, please.

Sep 21 2021, 8:24 AM · Restricted Project, Restricted Project
vhscampos updated the diff for D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.
  1. Fix bug in "+sve2" feature position in the target features list. It was being inserted at the end, which made it impossible to disable it using +nosve2, as the positive option would always be placed after the negative one.
  2. Add tests to the bug fix above.
Sep 21 2021, 8:22 AM · Restricted Project, Restricted Project

Sep 16 2021

vhscampos updated the summary of D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.
Sep 16 2021, 6:27 AM · Restricted Project, Restricted Project

Sep 14 2021

vhscampos added inline comments to D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.
Sep 14 2021, 6:44 AM · Restricted Project, Restricted Project
vhscampos updated the diff for D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.
  1. Enable the SVE2 extension as default.
  2. Remove out of date comments in tests.
  3. Remove unrelated change.
Sep 14 2021, 6:43 AM · Restricted Project, Restricted Project

Sep 9 2021

vhscampos added reviewers for D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A: SjoerdMeijer, ostannard.
Sep 9 2021, 9:15 AM · Restricted Project, Restricted Project
vhscampos requested review of D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.
Sep 9 2021, 9:01 AM · Restricted Project, Restricted Project

Sep 6 2021

vhscampos committed rG79f9c79aaf84: [AArch64][MC] Merge FeaturePMU into FeaturePerfMon (authored by vhscampos).
[AArch64][MC] Merge FeaturePMU into FeaturePerfMon
Sep 6 2021, 6:57 AM
vhscampos closed D109246: [AArch64][MC] Merge FeaturePMU into FeaturePerfMon.
Sep 6 2021, 6:57 AM · Restricted Project

Sep 3 2021

vhscampos added a reviewer for D109246: [AArch64][MC] Merge FeaturePMU into FeaturePerfMon: dnsampaio.
Sep 3 2021, 10:03 AM · Restricted Project
vhscampos requested review of D109246: [AArch64][MC] Merge FeaturePMU into FeaturePerfMon.
Sep 3 2021, 10:00 AM · Restricted Project

Jul 19 2021

vhscampos committed rG59e4e53ead25: [NewPM] Fix wrong perfect forwardings (authored by vhscampos).
[NewPM] Fix wrong perfect forwardings
Jul 19 2021, 9:21 AM
vhscampos closed D106148: [NewPM] Fix wrong perfect forwardings.
Jul 19 2021, 9:21 AM · Restricted Project
vhscampos added a comment to D106148: [NewPM] Fix wrong perfect forwardings.

Thanks for your review

Jul 19 2021, 8:55 AM · Restricted Project
vhscampos added inline comments to D106148: [NewPM] Fix wrong perfect forwardings.
Jul 19 2021, 8:47 AM · Restricted Project
vhscampos retitled D106148: [NewPM] Fix wrong perfect forwardings from [NewPM] Fix wrong perfect forwarding in createModuleToFunctionPassAdaptor to [NewPM] Fix wrong perfect forwardings.
Jul 19 2021, 8:20 AM · Restricted Project
vhscampos added a comment to D106148: [NewPM] Fix wrong perfect forwardings.

@aeubanks Yes, thank you. Just did that.

Jul 19 2021, 4:24 AM · Restricted Project
vhscampos updated the diff for D106148: [NewPM] Fix wrong perfect forwardings.

Fixes in other places of the new pass manager.

Jul 19 2021, 4:23 AM · Restricted Project

Jul 16 2021

vhscampos added reviewers for D106148: [NewPM] Fix wrong perfect forwardings: aeubanks, chandlerc.
Jul 16 2021, 6:37 AM · Restricted Project
vhscampos requested review of D106148: [NewPM] Fix wrong perfect forwardings.
Jul 16 2021, 6:35 AM · Restricted Project

Apr 21 2021

vhscampos committed rGee3e01627ff8: [Clang][ARM] Define __VFP_FP__ macro unconditionally (authored by vhscampos).
[Clang][ARM] Define __VFP_FP__ macro unconditionally
Apr 21 2021, 7:04 AM
vhscampos closed D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally.
Apr 21 2021, 7:04 AM · Restricted Project
vhscampos added a comment to D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally.

Thanks Peter. Since one week has passed, I plan to commit these changes by the end of the day if nothing surfaces.

Apr 21 2021, 1:29 AM · Restricted Project

Apr 15 2021

vhscampos updated the diff for D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally.

Add a clarifying comment.

Apr 15 2021, 5:05 AM · Restricted Project

Apr 13 2021

vhscampos added reviewers for D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally: stuij, miyuki, SjoerdMeijer.
Apr 13 2021, 2:25 AM · Restricted Project
vhscampos requested review of D100372: [Clang][ARM] Define __VFP_FP__ macro unconditionally.
Apr 13 2021, 2:06 AM · Restricted Project

Mar 23 2021

vhscampos committed rGf22b4c7122bc: [ARM] Handle debug instrs in ARM Low Overhead Loop pass (authored by vhscampos).
[ARM] Handle debug instrs in ARM Low Overhead Loop pass
Mar 23 2021, 4:49 AM
vhscampos closed D99075: [ARM] Handle debug instrs in ARM Low Overhead Loop pass.
Mar 23 2021, 4:49 AM · Restricted Project
vhscampos updated the diff for D99075: [ARM] Handle debug instrs in ARM Low Overhead Loop pass.

Remove if statement inside RemovePredicate as it's already covered by an assertion.

Mar 23 2021, 4:45 AM · Restricted Project
vhscampos updated the diff for D99075: [ARM] Handle debug instrs in ARM Low Overhead Loop pass.

Remove predicate of instructions after the divergent one even if there's no non-debug instruction after it.

Mar 23 2021, 4:14 AM · Restricted Project

Mar 22 2021

vhscampos updated the diff for D99075: [ARM] Handle debug instrs in ARM Low Overhead Loop pass.

Add assertion in RemovePredicate lambda.
SKip debug instructions inside VPT blocks with predicate divergence.

Mar 22 2021, 9:24 AM · Restricted Project
vhscampos added a reviewer for D99075: [ARM] Handle debug instrs in ARM Low Overhead Loop pass: samparker.
Mar 22 2021, 7:04 AM · Restricted Project
vhscampos requested review of D99075: [ARM] Handle debug instrs in ARM Low Overhead Loop pass.
Mar 22 2021, 7:01 AM · Restricted Project

Mar 12 2021

vhscampos accepted D98510: [Clang][ARM] Reenable arm_acle.c test..

LGTM. mem2reg is a simple enough optimization to clear up the IR in this case. Thank you.

Mar 12 2021, 7:34 AM · Restricted Project

Dec 8 2020

vhscampos abandoned D90845: [libunwind] Create CREDITS.TXT file.
Dec 8 2020, 9:01 AM · Restricted Project, Restricted Project

Nov 6 2020

vhscampos added a comment to D88645: [Annotation] Allows annotation to carry some additional constant arguments..

@Tyker This is causing another build failure in another example:

Nov 6 2020, 7:34 AM · Restricted Project, Restricted Project

Nov 5 2020

vhscampos added reviewers for D90845: [libunwind] Create CREDITS.TXT file: chandlerc, aadg.
Nov 5 2020, 6:04 AM · Restricted Project, Restricted Project
vhscampos accepted D90594: [AArch64] Enable RAS 1.1 system registers in all AArch64.
Nov 5 2020, 6:03 AM · Restricted Project
vhscampos requested review of D90845: [libunwind] Create CREDITS.TXT file.
Nov 5 2020, 5:59 AM · Restricted Project, Restricted Project

Aug 4 2020

vhscampos abandoned D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing.
Aug 4 2020, 3:54 AM · Restricted Project
vhscampos added a comment to D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing.

Not really. Closing it

Aug 4 2020, 3:54 AM · Restricted Project

Jul 29 2020

vhscampos committed rG71bf6dd682c0: [Driver][ARM] Fix testcase that should only run on ARM (authored by vhscampos).
[Driver][ARM] Fix testcase that should only run on ARM
Jul 29 2020, 6:41 AM
vhscampos committed rGd1a3396bfbc6: [Driver][ARM] Disable unsupported features when nofp arch extension is used (authored by vhscampos).
[Driver][ARM] Disable unsupported features when nofp arch extension is used
Jul 29 2020, 6:20 AM
vhscampos closed D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.
Jul 29 2020, 6:19 AM · Restricted Project, Restricted Project

Jul 23 2020

vhscampos updated the diff for D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.
  1. Add comment explaining the MVE-Integer detail.
  2. Add another test to check the disabled features.
Jul 23 2020, 4:20 AM · Restricted Project, Restricted Project

Jul 21 2020

vhscampos added a comment to D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.

Ping.

Jul 21 2020, 2:40 AM · Restricted Project, Restricted Project

Jul 14 2020

vhscampos committed rGdad1868772f1: [AArch64][AsmParser] Add rcpc support in .arch_extension (authored by vhscampos).
[AArch64][AsmParser] Add rcpc support in .arch_extension
Jul 14 2020, 2:58 AM
vhscampos closed D83685: [AArch64][AsmParser] Add rcpc support in .arch_extension.
Jul 14 2020, 2:57 AM · Restricted Project

Jul 13 2020

vhscampos added a reviewer for D83685: [AArch64][AsmParser] Add rcpc support in .arch_extension: samparker.
Jul 13 2020, 8:29 AM · Restricted Project
Herald added a project to D83685: [AArch64][AsmParser] Add rcpc support in .arch_extension: Restricted Project.
Jul 13 2020, 8:25 AM · Restricted Project

Jul 3 2020

vhscampos updated the diff for D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.
  1. Merged the second patch into this (handle bf16).
  2. Do the same treatment for -mcpu.
  3. Instead of doing string search once again, return the desired information in the first time using a by-ref argument.
  4. This new approach covers positional differences between +fp and +nofp.
Jul 3 2020, 8:02 AM · Restricted Project, Restricted Project

Jul 2 2020

vhscampos added inline comments to D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.
Jul 2 2020, 6:57 AM · Restricted Project, Restricted Project
vhscampos added a comment to D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.

I will merge the two patches into one.

Jul 2 2020, 2:05 AM · Restricted Project, Restricted Project

Jul 1 2020

vhscampos added a reviewer for D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing: chill.
Jul 1 2020, 4:49 AM · Restricted Project
vhscampos added a reviewer for D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used: chill.
Jul 1 2020, 4:49 AM · Restricted Project, Restricted Project
vhscampos retitled D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing from Disable bf16 when hardware FP support is missing to [Driver][ARM] Disable bf16 when hardware FP support is missing.
Jul 1 2020, 4:49 AM · Restricted Project
vhscampos created D82949: [Driver][ARM] Disable bf16 when hardware FP support is missing.
Jul 1 2020, 4:49 AM · Restricted Project
vhscampos created D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used.
Jul 1 2020, 4:49 AM · Restricted Project, Restricted Project
vhscampos abandoned D82947: [Driver][ARM] Disable unsupported features when nofp arch extension is used.
Jul 1 2020, 4:49 AM · Restricted Project
vhscampos abandoned D82946: [Driver][ARM] Disable bf16 when hardware FP support is missing.
Jul 1 2020, 4:49 AM · Restricted Project
vhscampos created D82947: [Driver][ARM] Disable unsupported features when nofp arch extension is used.
Jul 1 2020, 4:49 AM · Restricted Project
vhscampos created D82946: [Driver][ARM] Disable bf16 when hardware FP support is missing.
Jul 1 2020, 4:49 AM · Restricted Project

Jun 25 2020

vhscampos committed rGda852b03b009: [AArch64] Emit warning when disassembling unpredictable LDRAA and LDRAB (authored by vhscampos).
[AArch64] Emit warning when disassembling unpredictable LDRAA and LDRAB
Jun 25 2020, 8:01 AM
vhscampos closed D82541: [AArch64] Emit warning when disassembling unpredictable LDRAA and LDRAB.
Jun 25 2020, 8:01 AM · Restricted Project
vhscampos added inline comments to D82541: [AArch64] Emit warning when disassembling unpredictable LDRAA and LDRAB.
Jun 25 2020, 7:25 AM · Restricted Project
vhscampos created D82541: [AArch64] Emit warning when disassembling unpredictable LDRAA and LDRAB.
Jun 25 2020, 4:42 AM · Restricted Project
vhscampos added a reviewer for D82541: [AArch64] Emit warning when disassembling unpredictable LDRAA and LDRAB: ostannard.
Jun 25 2020, 4:42 AM · Restricted Project

Jun 24 2020

vhscampos committed rG1b090db0df47: [ARM] Improve diagnostics message when Neon is unsupported (authored by vhscampos).
[ARM] Improve diagnostics message when Neon is unsupported
Jun 24 2020, 2:40 AM
vhscampos closed D81847: [ARM] Improve diagnostics message when Neon is unsupported.
Jun 24 2020, 2:40 AM · Restricted Project

Jun 15 2020

vhscampos created D81847: [ARM] Improve diagnostics message when Neon is unsupported.
Jun 15 2020, 9:13 AM · Restricted Project
vhscampos added a reviewer for D81847: [ARM] Improve diagnostics message when Neon is unsupported: stuij.
Jun 15 2020, 9:13 AM · Restricted Project

May 28 2020

vhscampos added a comment to D79778: [CodeGen] Remove buggy handling of input operands in inline asm.

This is the problematic case:

May 28 2020, 6:30 AM · Restricted Project
vhscampos committed rGc010d4d19550: [ARM] Improve codegen of volatile load/store of i64 (authored by vhscampos).
[ARM] Improve codegen of volatile load/store of i64
May 28 2020, 3:13 AM
vhscampos closed D70072: [ARM] Improve codegen of volatile load/store of i64.
May 28 2020, 3:13 AM · Restricted Project

May 27 2020

vhscampos requested review of D70072: [ARM] Improve codegen of volatile load/store of i64.
May 27 2020, 8:05 AM · Restricted Project
vhscampos updated the diff for D70072: [ARM] Improve codegen of volatile load/store of i64.

Improve the testcase which exercises loads and stores from stack. Now, wrong frame index replacements will be caught here.

May 27 2020, 8:05 AM · Restricted Project
vhscampos reopened D70072: [ARM] Improve codegen of volatile load/store of i64.
May 27 2020, 8:05 AM · Restricted Project