Page MenuHomePhabricator

vhscampos (Victor Campos)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2015, 11:50 AM (225 w, 3 d)

Recent Activity

Thu, Dec 12

vhscampos updated the diff for D69559: [AArch64] Improve codegen of volatile load/store of i128.
  1. Move new ISD node definitions to TableGen.
  2. Instruction selection done in TableGen using patterns.
Thu, Dec 12, 8:23 AM · Restricted Project

Wed, Dec 11

vhscampos updated the summary of D70072: [ARM] Improve codegen of volatile load/store of i64.
Wed, Dec 11, 5:50 AM · Restricted Project
vhscampos updated the diff for D70072: [ARM] Improve codegen of volatile load/store of i64.
  1. Update summary to have a better explanation of this patch.
  2. Add a post-ISel hook to add register allocation hints to LDRD/STRD operands.
  3. In the AArch32 case, move ISel from TableGen back to the C++ side. This is needed because we must have a custom lowering whenever LDRD/STRD selection would normally yield a register offset. The ARM Load/Store Optimizer is not able to handle LDRD/STRD's register offsets in the cases where LDRD/STRD must be reverted to LDM/STM. As such, the C++ instruction selection opts for not generating instructions with a register offset.
  4. Improve test by testing several immediate boundary cases.
Wed, Dec 11, 5:50 AM · Restricted Project

Mon, Dec 2

vhscampos committed rGdcf11c5e86ce: [ARM][AArch64] Complex addition Neon intrinsics for Armv8.3-A (authored by vhscampos).
[ARM][AArch64] Complex addition Neon intrinsics for Armv8.3-A
Mon, Dec 2, 6:40 AM
vhscampos closed D70862: [ARM][AArch64] Complex addition Neon intrinsics for Armv8.3-A.
Mon, Dec 2, 6:40 AM · Restricted Project, Restricted Project

Fri, Nov 29

vhscampos created D70862: [ARM][AArch64] Complex addition Neon intrinsics for Armv8.3-A.
Fri, Nov 29, 9:17 AM · Restricted Project, Restricted Project
vhscampos committed rGe478385e7708: [ARM] Fix instruction selection for ARMISD::CMOV with f16 type (authored by vhscampos).
[ARM] Fix instruction selection for ARMISD::CMOV with f16 type
Fri, Nov 29, 2:44 AM
vhscampos closed D70667: [ARM] Fix instruction selection for ARMISD::CMOV with f16 type.
Fri, Nov 29, 2:43 AM · Restricted Project
vhscampos updated the diff for D70667: [ARM] Fix instruction selection for ARMISD::CMOV with f16 type.

Require single-precision floating-point registers instead.

Fri, Nov 29, 2:08 AM · Restricted Project
vhscampos updated the summary of D70667: [ARM] Fix instruction selection for ARMISD::CMOV with f16 type.
Fri, Nov 29, 2:08 AM · Restricted Project

Wed, Nov 27

vhscampos updated the diff for D70667: [ARM] Fix instruction selection for ARMISD::CMOV with f16 type.

Now using a pseudo instruction instead, VMOVHcc, which is lowered into a single-precision VMOV.

Wed, Nov 27, 8:17 AM · Restricted Project
vhscampos added a reviewer for D70667: [ARM] Fix instruction selection for ARMISD::CMOV with f16 type: dmgreen.
Wed, Nov 27, 8:17 AM · Restricted Project

Mon, Nov 25

vhscampos added a reviewer for D70667: [ARM] Fix instruction selection for ARMISD::CMOV with f16 type: ostannard.
Mon, Nov 25, 5:44 AM · Restricted Project
vhscampos created D70667: [ARM] Fix instruction selection for ARMISD::CMOV with f16 type.
Mon, Nov 25, 5:35 AM · Restricted Project

Fri, Nov 22

vhscampos updated the diff for D70072: [ARM] Improve codegen of volatile load/store of i64.

Fixed the immediate range check to cover -1020 to 1020.

Fri, Nov 22, 3:22 AM · Restricted Project

Wed, Nov 20

vhscampos added inline comments to D70072: [ARM] Improve codegen of volatile load/store of i64.
Wed, Nov 20, 8:52 AM · Restricted Project
vhscampos updated the diff for D70072: [ARM] Improve codegen of volatile load/store of i64.
  1. Move the custom SD nodes to TableGen.
  2. Truncating stores not restricted anymore.
  3. Remove isUnindexed() calls since they should return true always at this point.
  4. Extend test to also check loads/stores that have an offset.
Wed, Nov 20, 8:52 AM · Restricted Project

Tue, Nov 19

vhscampos added inline comments to D70072: [ARM] Improve codegen of volatile load/store of i64.
Tue, Nov 19, 5:17 AM · Restricted Project

Nov 13 2019

vhscampos updated the diff for D69559: [AArch64] Improve codegen of volatile load/store of i128.
  1. Create new AArch64ISD nodes specific to load/store of pairs of registers.
  2. Custom lower i128 volatile loads/stores to these new AArch64ISD nodes.
Nov 13 2019, 3:10 AM · Restricted Project
vhscampos updated the diff for D70072: [ARM] Improve codegen of volatile load/store of i64.
  1. Not exclude extloads anymore.
  2. Create new ARMISD nodes specific to load/store of dual registers.
  3. Custom lower i64 volatile loads/stores to these new ARMISD nodes.
Nov 13 2019, 2:34 AM · Restricted Project

Nov 11 2019

vhscampos added reviewers for D70072: [ARM] Improve codegen of volatile load/store of i64: efriedma, john.brawn.
Nov 11 2019, 5:20 AM · Restricted Project
vhscampos added a reviewer for D69559: [AArch64] Improve codegen of volatile load/store of i128: efriedma.
Nov 11 2019, 5:20 AM · Restricted Project
vhscampos added a reviewer for D70072: [ARM] Improve codegen of volatile load/store of i64: dmgreen.
Nov 11 2019, 4:08 AM · Restricted Project
vhscampos created D70072: [ARM] Improve codegen of volatile load/store of i64.
Nov 11 2019, 3:58 AM · Restricted Project

Oct 30 2019

vhscampos updated the diff for D69559: [AArch64] Improve codegen of volatile load/store of i128.

Amending patch to include the transfer of memory operands from the original
SDNode to the new MachineSDNode.

Oct 30 2019, 7:28 AM · Restricted Project

Oct 29 2019

vhscampos added reviewers for D69559: [AArch64] Improve codegen of volatile load/store of i128: labrinea, t.p.northover.
Oct 29 2019, 6:17 AM · Restricted Project
vhscampos created D69559: [AArch64] Improve codegen of volatile load/store of i128.
Oct 29 2019, 6:08 AM · Restricted Project

Oct 28 2019

vhscampos committed rGf6e11a36c49c: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE (authored by vhscampos).
[ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE
Oct 28 2019, 4:07 AM
vhscampos closed D69250: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE.
Oct 28 2019, 4:07 AM · Restricted Project, Restricted Project
vhscampos committed rG5d35b7d9e1a3: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64 (authored by vhscampos).
[ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64
Oct 28 2019, 3:59 AM
vhscampos closed D69297: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64.
Oct 28 2019, 3:59 AM · Restricted Project

Oct 25 2019

vhscampos added a comment to D69250: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE.

Added support for __clsll as requested.

Oct 25 2019, 8:15 AM · Restricted Project, Restricted Project
vhscampos updated the summary of D69250: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE.
Oct 25 2019, 8:15 AM · Restricted Project, Restricted Project
vhscampos retitled D69250: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE from [ARM][AArch64] Implement __cls and __clsl intrinsics from ACLE to [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE.
Oct 25 2019, 8:15 AM · Restricted Project, Restricted Project
vhscampos updated the diff for D69250: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE.

Add support for __clsll.

Oct 25 2019, 8:07 AM · Restricted Project, Restricted Project
vhscampos updated the diff for D69297: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64.

Use __builtin_bit_cast to perform the relevant bitcasts.

Oct 25 2019, 4:10 AM · Restricted Project

Oct 23 2019

vhscampos added inline comments to D69250: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE.
Oct 23 2019, 5:30 AM · Restricted Project, Restricted Project

Oct 22 2019

vhscampos updated the diff for D69297: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64.

Run clang-format

Oct 22 2019, 3:53 AM · Restricted Project
vhscampos added a reviewer for D69297: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64: momchil.velikov.
Oct 22 2019, 3:53 AM · Restricted Project
vhscampos created D69297: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64.
Oct 22 2019, 3:44 AM · Restricted Project
vhscampos added inline comments to D69250: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE.
Oct 22 2019, 2:58 AM · Restricted Project, Restricted Project

Oct 21 2019

vhscampos added a reviewer for D69250: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE: compnerd.
Oct 21 2019, 5:11 AM · Restricted Project, Restricted Project
vhscampos created D69250: [ARM][AArch64] Implement __cls, __clsl and __clsll intrinsics from ACLE.
Oct 21 2019, 5:02 AM · Restricted Project, Restricted Project

Oct 18 2019

vhscampos committed rGe64863d19242: [SCEV] Removing deprecated comment in ScalarEvolutionExpander (authored by vhscampos).
[SCEV] Removing deprecated comment in ScalarEvolutionExpander
Oct 18 2019, 6:36 AM
vhscampos committed rL375232: [SCEV] Removing deprecated comment in ScalarEvolutionExpander.
[SCEV] Removing deprecated comment in ScalarEvolutionExpander
Oct 18 2019, 6:36 AM
vhscampos abandoned D26217: Consider all SCEVMulExpr operands for factoring in FactorOutConstant.
Oct 18 2019, 6:35 AM
vhscampos committed rGffcd7698aea7: [AArch64] Adding support for PMMIR_EL1 register (authored by vhscampos).
[AArch64] Adding support for PMMIR_EL1 register
Oct 18 2019, 5:40 AM
vhscampos closed D68940: [AArch64] Adding support for PMMIR_EL1 register.
Oct 18 2019, 5:39 AM · Restricted Project
vhscampos committed rL375228: [AArch64] Adding support for PMMIR_EL1 register.
[AArch64] Adding support for PMMIR_EL1 register
Oct 18 2019, 5:39 AM

Oct 17 2019

vhscampos updated the diff for D68940: [AArch64] Adding support for PMMIR_EL1 register.

Added test into Disassembler

Oct 17 2019, 5:16 AM · Restricted Project

Oct 16 2019

vhscampos accepted D69039: [AArch64,Assembler] Compiler support for ID_MMFR5_EL1.
Oct 16 2019, 7:41 AM · Restricted Project
vhscampos added a reviewer for D68940: [AArch64] Adding support for PMMIR_EL1 register: dnsampaio.
Oct 16 2019, 7:40 AM · Restricted Project

Oct 14 2019

vhscampos added a reviewer for D68940: [AArch64] Adding support for PMMIR_EL1 register: t.p.northover.
Oct 14 2019, 4:24 AM · Restricted Project
vhscampos created D68940: [AArch64] Adding support for PMMIR_EL1 register.
Oct 14 2019, 4:24 AM · Restricted Project
vhscampos committed rGd34822ad4c42: Fixing typo in llvm/IR/Intrinsics.td (authored by vhscampos).
Fixing typo in llvm/IR/Intrinsics.td
Oct 14 2019, 4:15 AM
vhscampos committed rL374766: Fixing typo in llvm/IR/Intrinsics.td.
Fixing typo in llvm/IR/Intrinsics.td
Oct 14 2019, 4:14 AM

Dec 13 2016

vhscampos added a comment to D27647: Fix arguments of trace output in __kmp_push_stack.

Yes, thanks.

Dec 13 2016, 10:43 AM

Dec 12 2016

vhscampos updated the diff for D27647: Fix arguments of trace output in __kmp_push_stack.

Moved trace call inside the critical section.

Dec 12 2016, 12:20 PM

Dec 9 2016

vhscampos retitled D27647: Fix arguments of trace output in __kmp_push_stack from to Fix arguments of trace output in __kmp_push_stack.
Dec 9 2016, 5:40 PM

Nov 28 2016

vhscampos retitled D27172: Fixed typo in kmp_process_deps trace output from to Fixed typo in kmp_process_deps trace output.
Nov 28 2016, 11:53 AM
vhscampos added a comment to D26786: Fix memory leaks of buffer allocated in __kmp_str_format().

Yes, thanks.

Nov 28 2016, 11:23 AM

Nov 21 2016

vhscampos updated the diff for D26786: Fix memory leaks of buffer allocated in __kmp_str_format().

Fixed indentation and variable name issues.

Nov 21 2016, 12:03 PM

Nov 17 2016

vhscampos updated the diff for D26786: Fix memory leaks of buffer allocated in __kmp_str_format().

Applied your comments.

Nov 17 2016, 11:14 AM
vhscampos added a comment to D26786: Fix memory leaks of buffer allocated in __kmp_str_format().

Ok, I'm fixing the patch. Thanks.

Nov 17 2016, 11:11 AM

Nov 16 2016

vhscampos retitled D26786: Fix memory leaks of buffer allocated in __kmp_str_format() from to Fix memory leaks of buffer allocated in __kmp_str_format().
Nov 16 2016, 6:45 PM

Nov 9 2016

vhscampos added a comment to D26217: Consider all SCEVMulExpr operands for factoring in FactorOutConstant.

Okay. Thanks for the clarification. Should I create another patch just for the removal of lines 223-225?

Nov 9 2016, 11:23 AM
vhscampos added a comment to D26318: Added check for malloc return.

Yes, please.

Nov 9 2016, 11:21 AM

Nov 8 2016

vhscampos added a comment to D26318: Added check for malloc return.

Done.

Nov 8 2016, 5:46 PM
vhscampos updated the diff for D26318: Added check for malloc return.
Nov 8 2016, 5:45 PM
vhscampos added a reviewer for D26217: Consider all SCEVMulExpr operands for factoring in FactorOutConstant: mehdi_amini.
Nov 8 2016, 3:53 PM

Nov 4 2016

vhscampos retitled D26318: Added check for malloc return from to Added check for malloc return.
Nov 4 2016, 5:04 PM

Nov 1 2016

vhscampos retitled D26217: Consider all SCEVMulExpr operands for factoring in FactorOutConstant from to Consider all SCEVMulExpr operands for factoring in FactorOutConstant.
Nov 1 2016, 3:04 PM

Oct 31 2016

vhscampos updated the diff for D26058: Add more conditions to check whether task waiting is necessary in kmp_omp_taskwait().

Given that checking 'tasking_ser' is redundant, I removed it.

Oct 31 2016, 1:35 PM

Oct 27 2016

vhscampos retitled D26058: Add more conditions to check whether task waiting is necessary in kmp_omp_taskwait() from to Add more conditions to check whether task waiting is necessary in kmp_omp_taskwait().
Oct 27 2016, 6:25 PM

Oct 26 2016

vhscampos added a comment to D26001: Use getpagesize() instead of PAGE_SIZE macro when KMP_OS_LINUX is true.

Yes, thanks.

Oct 26 2016, 12:21 PM
vhscampos updated the diff for D26001: Use getpagesize() instead of PAGE_SIZE macro when KMP_OS_LINUX is true.

I have applied the suggestions.

Oct 26 2016, 12:10 PM
vhscampos retitled D26001: Use getpagesize() instead of PAGE_SIZE macro when KMP_OS_LINUX is true from to Use getpagesize() instead of PAGE_SIZE macro when KMP_OS_LINUX is true.
Oct 26 2016, 11:13 AM
vhscampos added a comment to D25972: Fixing typos in __kmp_release_deps trace outputs.

Yes, please. Thanks.

Oct 26 2016, 10:47 AM

Oct 25 2016

vhscampos retitled D25972: Fixing typos in __kmp_release_deps trace outputs from to Fixing typos in __kmp_release_deps trace outputs.
Oct 25 2016, 4:54 PM

Oct 14 2015

vhscampos added a comment to D13725: [IDFCalculator] Use DominatorTreeBase instead of DominatorTree.

Yes, please.

Oct 14 2015, 7:42 AM
vhscampos retitled D13725: [IDFCalculator] Use DominatorTreeBase instead of DominatorTree from to [IDFCalculator] Use DominatorTreeBase instead of DominatorTree.
Oct 14 2015, 7:00 AM