Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

vhscampos (Victor Campos)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 19 2015, 11:50 AM (423 w, 2 d)

Recent Activity

Mon, Sep 11

vhscampos committed rGdbeb3d029d8e: Add missing vrnd intrinsics (authored by miyengar).
Add missing vrnd intrinsics
Mon, Sep 11, 5:00 AM · Restricted Project, Restricted Project, Restricted Project
vhscampos closed D158626: [AArch64] Add missing vrnd intrinsics.
Mon, Sep 11, 4:59 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Sep 5

vhscampos added a comment to D159357: [AArch64] Move PAuth codegen down the machine pipeline.

I don't understand the motivation here. This moves PAuth's instruction insertion later down the pipeline, but why? The handling in the machine outliner isn't made any simpler IMO.

Tue, Sep 5, 3:06 AM · Restricted Project, Restricted Project

Aug 16 2023

vhscampos committed rGd77cba6d474a: [Clang][DebugInfo] Emit narrower base types for structured binding declarations… (authored by vhscampos).
[Clang][DebugInfo] Emit narrower base types for structured binding declarations…
Aug 16 2023, 2:45 AM · Restricted Project, Restricted Project
vhscampos closed D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields.
Aug 16 2023, 2:45 AM · debug-info, Restricted Project, Restricted Project

Aug 15 2023

vhscampos added a comment to D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields.

@aprantl We have discussed internally a few options to implement correct debug information in this case. But this will be future work.

Aug 15 2023, 6:08 AM · debug-info, Restricted Project, Restricted Project
vhscampos updated the diff for D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields.
  • Redone test to cover only what's needed.
Aug 15 2023, 6:00 AM · debug-info, Restricted Project, Restricted Project

Aug 11 2023

vhscampos added inline comments to D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields.
Aug 11 2023, 5:53 AM · debug-info, Restricted Project, Restricted Project
vhscampos updated the diff for D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields.
  • Addressed the one comment regarding code.
  • Changed the test to use update_cc_test
Aug 11 2023, 5:52 AM · debug-info, Restricted Project, Restricted Project

Aug 9 2023

vhscampos added reviewers for D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields: shafik, aprantl.
Aug 9 2023, 4:54 AM · debug-info, Restricted Project, Restricted Project
vhscampos added reviewers for D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields: tmatheson, pratlucas, keith.walker.arm.
Aug 9 2023, 1:43 AM · debug-info, Restricted Project, Restricted Project
vhscampos requested review of D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields.
Aug 9 2023, 1:41 AM · debug-info, Restricted Project, Restricted Project

Feb 23 2023

vhscampos committed rG875391728c11: Avoid strict aliasing violation on type punning inside llvm::PointerIntPair (authored by brenoguim).
Avoid strict aliasing violation on type punning inside llvm::PointerIntPair
Feb 23 2023, 9:04 AM · Restricted Project, Restricted Project
vhscampos closed D124571: Avoid strict aliasing violation on type punning inside llvm::PointerIntPair.
Feb 23 2023, 9:03 AM · Restricted Project, Restricted Project
vhscampos added a comment to D124571: Avoid strict aliasing violation on type punning inside llvm::PointerIntPair.

Hi @brenoguim, I will submit this patch for you.

Feb 23 2023, 7:36 AM · Restricted Project, Restricted Project

Jan 11 2023

vhscampos committed rGbb4870e6172a: [ReleaseNotes] Add Neoverse V2 CPU to LLVM's release notes (authored by vhscampos).
[ReleaseNotes] Add Neoverse V2 CPU to LLVM's release notes
Jan 11 2023, 3:49 AM · Restricted Project, Restricted Project
vhscampos closed D141394: [ReleaseNotes] Add Neoverse V2 CPU to LLVM's release notes.
Jan 11 2023, 3:49 AM · Restricted Project, Restricted Project

Jan 10 2023

vhscampos added reviewers for D141394: [ReleaseNotes] Add Neoverse V2 CPU to LLVM's release notes: dmgreen, david-arm.
Jan 10 2023, 8:54 AM · Restricted Project, Restricted Project
vhscampos requested review of D141394: [ReleaseNotes] Add Neoverse V2 CPU to LLVM's release notes.
Jan 10 2023, 8:46 AM · Restricted Project, Restricted Project

Dec 8 2022

vhscampos added a comment to rG61318fa5c764: Fix an unused-variable warning in release build, NFC.

This was not an NFC change as the call to isDeadStore doesn't happen anymore in noasserts builds.

Dec 8 2022, 10:20 AM · Restricted Project, Restricted Project

Nov 9 2022

vhscampos committed rG9d1ff787e5c2: [AArch64] Add support for the Cortex-X3 CPU (authored by vhscampos).
[AArch64] Add support for the Cortex-X3 CPU
Nov 9 2022, 3:34 AM · Restricted Project, Restricted Project, Restricted Project
vhscampos closed D136589: [AArch64] Add support for the Cortex-X3 CPU.
Nov 9 2022, 3:34 AM · Restricted Project, Restricted Project, Restricted Project

Nov 8 2022

vhscampos updated the diff for D136589: [AArch64] Add support for the Cortex-X3 CPU.

Rebasing and conflict resolution

Nov 8 2022, 9:23 AM · Restricted Project, Restricted Project, Restricted Project
vhscampos added a comment to D136589: [AArch64] Add support for the Cortex-X3 CPU.

@tschuett Do you still want me to put the note about 'native' detection for neoverse-v2 back?

Nov 8 2022, 7:38 AM · Restricted Project, Restricted Project, Restricted Project

Nov 2 2022

vhscampos updated the diff for D136589: [AArch64] Add support for the Cortex-X3 CPU.

Added SSBS

Nov 2 2022, 5:10 AM · Restricted Project, Restricted Project, Restricted Project
vhscampos added inline comments to D136589: [AArch64] Add support for the Cortex-X3 CPU.
Nov 2 2022, 4:06 AM · Restricted Project, Restricted Project, Restricted Project
vhscampos updated the diff for D136589: [AArch64] Add support for the Cortex-X3 CPU.

Added AEK_FLAM to the list of features for Cortex-X3

Nov 2 2022, 3:56 AM · Restricted Project, Restricted Project, Restricted Project
vhscampos accepted D136957: [AArch64] Add support for the Cortex-A715 CPU.
Nov 2 2022, 3:33 AM · Restricted Project, Restricted Project, Restricted Project
vhscampos added inline comments to D136957: [AArch64] Add support for the Cortex-A715 CPU.
Nov 2 2022, 2:56 AM · Restricted Project, Restricted Project, Restricted Project

Oct 31 2022

vhscampos updated the diff for D136589: [AArch64] Add support for the Cortex-X3 CPU.

Combining release notes of Cortex-X3 and Neoverse V2.

Oct 31 2022, 7:33 AM · Restricted Project, Restricted Project, Restricted Project

Oct 28 2022

vhscampos committed rG56f967db51fb: [Object] Prevent null pointer dereference in BigArchiveMemberHeader (authored by vhscampos).
[Object] Prevent null pointer dereference in BigArchiveMemberHeader
Oct 28 2022, 5:15 AM · Restricted Project, Restricted Project
vhscampos closed D135449: [Object] Prevent null pointer dereference in BigArchiveMemberHeader.
Oct 28 2022, 5:15 AM · Restricted Project, Restricted Project

Oct 27 2022

vhscampos planned changes to D136589: [AArch64] Add support for the Cortex-X3 CPU.

We found an issue in the list of target features for v9-A. This patch will be affected.

Oct 27 2022, 3:31 AM · Restricted Project, Restricted Project, Restricted Project

Oct 25 2022

vhscampos added a reviewer for D135449: [Object] Prevent null pointer dereference in BigArchiveMemberHeader: brenoguim.
Oct 25 2022, 7:46 AM · Restricted Project, Restricted Project
vhscampos added inline comments to D136589: [AArch64] Add support for the Cortex-X3 CPU.
Oct 25 2022, 5:37 AM · Restricted Project, Restricted Project, Restricted Project
vhscampos added inline comments to D136589: [AArch64] Add support for the Cortex-X3 CPU.
Oct 25 2022, 5:36 AM · Restricted Project, Restricted Project, Restricted Project
vhscampos updated the diff for D136589: [AArch64] Add support for the Cortex-X3 CPU.

Comments addressed

Oct 25 2022, 5:36 AM · Restricted Project, Restricted Project, Restricted Project

Oct 24 2022

vhscampos added reviewers for D136589: [AArch64] Add support for the Cortex-X3 CPU: simpal01, stuij.
Oct 24 2022, 3:17 AM · Restricted Project, Restricted Project, Restricted Project
vhscampos requested review of D136589: [AArch64] Add support for the Cortex-X3 CPU.
Oct 24 2022, 3:16 AM · Restricted Project, Restricted Project, Restricted Project

Oct 7 2022

vhscampos added a comment to D135449: [Object] Prevent null pointer dereference in BigArchiveMemberHeader.

For reference, a null pointer can reach this code from Archive.cpp line 458.

Oct 7 2022, 8:01 AM · Restricted Project, Restricted Project
vhscampos added a reviewer for D135449: [Object] Prevent null pointer dereference in BigArchiveMemberHeader: DiggerLin.
Oct 7 2022, 7:59 AM · Restricted Project, Restricted Project
vhscampos requested review of D135449: [Object] Prevent null pointer dereference in BigArchiveMemberHeader.
Oct 7 2022, 7:56 AM · Restricted Project, Restricted Project

Sep 13 2022

vhscampos added a comment to D111283: [clang] template / auto deduction deduces common sugar.

For reference, another small reproducer of the crash, but with a different stack trace than the first example posted here:

Sep 13 2022, 8:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Aug 22 2022

vhscampos committed rG1d66c5ebbc43: [ARM] Fix bug in also_compatible_with attribute parser (authored by vhscampos).
[ARM] Fix bug in also_compatible_with attribute parser
Aug 22 2022, 1:41 AM · Restricted Project, Restricted Project
vhscampos closed D132214: [ARM] Fix bug in also_compatible_with attribute parser.
Aug 22 2022, 1:40 AM · Restricted Project, Restricted Project

Aug 19 2022

vhscampos added a reviewer for D132214: [ARM] Fix bug in also_compatible_with attribute parser: pratlucas.
Aug 19 2022, 1:56 AM · Restricted Project, Restricted Project
vhscampos accepted D132120: [AArch64] Fix list of features for Cortex-X1C.
Aug 19 2022, 1:55 AM · Restricted Project, Restricted Project
vhscampos requested review of D132214: [ARM] Fix bug in also_compatible_with attribute parser.
Aug 19 2022, 1:55 AM · Restricted Project, Restricted Project

Aug 16 2022

vhscampos committed rG784da8a722b3: [ARM] Simplify the creation of escaped build attribute values (authored by vhscampos).
[ARM] Simplify the creation of escaped build attribute values
Aug 16 2022, 3:50 AM · Restricted Project, Restricted Project
vhscampos closed D131680: [ARM] Simplify the creation of escaped build attribute values.
Aug 16 2022, 3:49 AM · Restricted Project, Restricted Project
vhscampos committed rG08c6840f254c: [ARM] Parse Tag_also_compatible_with attribute (authored by vhscampos).
[ARM] Parse Tag_also_compatible_with attribute
Aug 16 2022, 3:23 AM · Restricted Project, Restricted Project
vhscampos closed D130913: [ARM] Parse Tag_also_compatible_with attribute.
Aug 16 2022, 3:23 AM · Restricted Project, Restricted Project

Aug 11 2022

vhscampos added a reviewer for D131680: [ARM] Simplify the creation of escaped build attribute values: pratlucas.
Aug 11 2022, 7:30 AM · Restricted Project, Restricted Project
vhscampos requested review of D131680: [ARM] Simplify the creation of escaped build attribute values.
Aug 11 2022, 7:29 AM · Restricted Project, Restricted Project
vhscampos updated the diff for D130913: [ARM] Parse Tag_also_compatible_with attribute.

Small improvement to printStringEscapedImpl

Aug 11 2022, 6:20 AM · Restricted Project, Restricted Project
vhscampos updated the diff for D130913: [ARM] Parse Tag_also_compatible_with attribute.

More general handling of attributes inside also_compatible_with

Aug 11 2022, 5:54 AM · Restricted Project, Restricted Project
vhscampos added inline comments to D131555: [Clang] Propagate const context info when emitting compound literal.
Aug 11 2022, 2:37 AM · Restricted Project, Restricted Project
vhscampos added inline comments to D131555: [Clang] Propagate const context info when emitting compound literal.
Aug 11 2022, 2:36 AM · Restricted Project, Restricted Project

Aug 1 2022

vhscampos added reviewers for D130913: [ARM] Parse Tag_also_compatible_with attribute: pratlucas, stuij.
Aug 1 2022, 9:18 AM · Restricted Project, Restricted Project
vhscampos requested review of D130913: [ARM] Parse Tag_also_compatible_with attribute.
Aug 1 2022, 9:08 AM · Restricted Project, Restricted Project

Jul 26 2022

vhscampos committed rGb43bec19b975: [ARM] Add Tag_CPU_arch missing value descriptions in attribute parser (authored by vhscampos).
[ARM] Add Tag_CPU_arch missing value descriptions in attribute parser
Jul 26 2022, 12:33 AM · Restricted Project, Restricted Project
vhscampos closed D129631: [ARM] Add Tag_CPU_arch missing value descriptions in attribute parser.
Jul 26 2022, 12:32 AM · Restricted Project, Restricted Project

Jul 25 2022

vhscampos accepted D129692: [ARM] Correct features on pacbti tests. NFC.

It LGTM too. Thanks.

Jul 25 2022, 1:37 AM · Restricted Project, Restricted Project

Jul 15 2022

vhscampos added a reviewer for D129877: [ubsan][test] Add test to check interaction between inlining and attribute no_sanitize("undefined"): eugenis.
Jul 15 2022, 9:45 AM · Restricted Project, Restricted Project
vhscampos requested review of D129877: [ubsan][test] Add test to check interaction between inlining and attribute no_sanitize("undefined").
Jul 15 2022, 9:42 AM · Restricted Project, Restricted Project
vhscampos accepted D129500: [Arm] Fix parsing and emission of Tag_also_compatible_with eabi attribute.

LGTM. Please wait one week or so for any other comment.

Jul 15 2022, 3:40 AM · Restricted Project, Restricted Project

Jul 13 2022

vhscampos added a comment to D129631: [ARM] Add Tag_CPU_arch missing value descriptions in attribute parser.

I can't think of a way to test multiple Tag_CPU_arch values in the same test file. So I created one test file for each CPU arch that I touched.

Jul 13 2022, 6:06 AM · Restricted Project, Restricted Project
vhscampos updated the diff for D129631: [ARM] Add Tag_CPU_arch missing value descriptions in attribute parser.

Adding testcases

Jul 13 2022, 6:05 AM · Restricted Project, Restricted Project
vhscampos added reviewers for D129631: [ARM] Add Tag_CPU_arch missing value descriptions in attribute parser: stuij, SjoerdMeijer, pratlucas.
Jul 13 2022, 3:41 AM · Restricted Project, Restricted Project
vhscampos requested review of D129631: [ARM] Add Tag_CPU_arch missing value descriptions in attribute parser.
Jul 13 2022, 3:40 AM · Restricted Project, Restricted Project

Jul 12 2022

vhscampos requested changes to D129500: [Arm] Fix parsing and emission of Tag_also_compatible_with eabi attribute.

A couple of typos in the commit message:

Jul 12 2022, 2:15 AM · Restricted Project, Restricted Project

Apr 5 2022

vhscampos accepted D123111: [AArch64] Make PMMIR_EL1 read-only..

LGTM.

Apr 5 2022, 2:56 AM · Restricted Project, Restricted Project
vhscampos added inline comments to D123111: [AArch64] Make PMMIR_EL1 read-only..
Apr 5 2022, 2:38 AM · Restricted Project, Restricted Project

Mar 18 2022

vhscampos accepted D121983: Driver: Don't warn on -mbranch-protection when linking.

LGTM, thanks

Mar 18 2022, 1:49 AM · Restricted Project, Restricted Project

Feb 22 2022

vhscampos accepted D118757: [AArch64] Remove unused feature flags from AArch64TargetInfo.

LGTM

Feb 22 2022, 2:20 AM · Restricted Project

Feb 21 2022

vhscampos added a comment to D116153: [ARM][AArch64] Add missing v8.x checks.

I don't see any problem with the patch, but we should wait on @SjoerdMeijer.

Feb 21 2022, 7:43 AM · Restricted Project

Jan 4 2022

vhscampos added inline comments to D116154: [ARM] Adding macros for coprocessor intrinsics as per ACLE.
Jan 4 2022, 4:10 AM · Restricted Project

Dec 10 2021

vhscampos accepted D115507: Add PACBTI-M support to LLVM release notes..

LGTM.

Dec 10 2021, 3:39 AM · Restricted Project, Restricted Project

Nov 29 2021

vhscampos accepted D112421: [clang][ARM] PACBTI-M frontend support.
Nov 29 2021, 1:52 AM · Restricted Project, Restricted Project

Nov 25 2021

vhscampos added inline comments to D112421: [clang][ARM] PACBTI-M frontend support.
Nov 25 2021, 8:38 AM · Restricted Project, Restricted Project

Oct 28 2021

vhscampos added inline comments to D112421: [clang][ARM] PACBTI-M frontend support.
Oct 28 2021, 8:24 AM · Restricted Project, Restricted Project
vhscampos added inline comments to D112420: [clang][ARM] PACBTI-M assembly support.
Oct 28 2021, 7:29 AM · Restricted Project, Restricted Project

Oct 19 2021

vhscampos added a comment to D109246: [AArch64][MC] Merge FeaturePMU into FeaturePerfMon.

Hi. Yes, it is intended behaviour. New system registers are usually available unconditionally. Typically only instructions are conditioned on target features.

Oct 19 2021, 5:11 AM · Restricted Project

Oct 12 2021

vhscampos committed rG3e7cf33a8376: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang (authored by vhscampos).
[docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang
Oct 12 2021, 12:41 AM
vhscampos closed D110241: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang.
Oct 12 2021, 12:41 AM · Restricted Project, Restricted Project

Oct 11 2021

vhscampos committed rG3550e242fad6: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A (authored by vhscampos).
[Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A
Oct 11 2021, 9:45 AM
vhscampos closed D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.
Oct 11 2021, 9:45 AM · Restricted Project, Restricted Project

Oct 5 2021

vhscampos added a comment to D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.

To the relevant persons I have just added to the review: @srhines @nickdesaulniers @llozano

Oct 5 2021, 2:53 AM · Restricted Project, Restricted Project
vhscampos added reviewers for D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A: srhines, nickdesaulniers, llozano.
Oct 5 2021, 2:50 AM · Restricted Project, Restricted Project

Sep 30 2021

vhscampos updated the diff for D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.
  1. Disable the cryptographic extensions by default.
  2. Small fix in TargetParserTest.cpp to include different spellings of the -march values.
Sep 30 2021, 8:08 AM · Restricted Project, Restricted Project

Sep 22 2021

vhscampos updated the diff for D110241: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang.

Added 'the' for better phrasing.

Sep 22 2021, 6:39 AM · Restricted Project, Restricted Project
vhscampos added a reviewer for D110241: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang: pratlucas.
Sep 22 2021, 6:18 AM · Restricted Project, Restricted Project
vhscampos requested review of D110241: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang.
Sep 22 2021, 6:16 AM · Restricted Project, Restricted Project
vhscampos updated the diff for D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.

Add missing . to end of sentences in comments.

Sep 22 2021, 2:14 AM · Restricted Project, Restricted Project

Sep 21 2021

vhscampos requested review of D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.

Sorry @SjoerdMeijer , I found a bug in the implementation (as described in the latest comment). Therefore I kindly ask another round of review, please.

Sep 21 2021, 8:24 AM · Restricted Project, Restricted Project
vhscampos updated the diff for D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.
  1. Fix bug in "+sve2" feature position in the target features list. It was being inserted at the end, which made it impossible to disable it using +nosve2, as the positive option would always be placed after the negative one.
  2. Add tests to the bug fix above.
Sep 21 2021, 8:22 AM · Restricted Project, Restricted Project

Sep 16 2021

vhscampos updated the summary of D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.
Sep 16 2021, 6:27 AM · Restricted Project, Restricted Project

Sep 14 2021

vhscampos added inline comments to D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.
Sep 14 2021, 6:44 AM · Restricted Project, Restricted Project
vhscampos updated the diff for D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A.
  1. Enable the SVE2 extension as default.
  2. Remove out of date comments in tests.
  3. Remove unrelated change.
Sep 14 2021, 6:43 AM · Restricted Project, Restricted Project

Sep 9 2021

vhscampos added reviewers for D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A: SjoerdMeijer, ostannard.
Sep 9 2021, 9:15 AM · Restricted Project, Restricted Project