LGTM.

LGTM, thanks

LGTM

I don't see any problem with the patch, but we should wait on @SjoerdMeijer.

LGTM.

Hi. Yes, it is intended behaviour. New system registers are usually available unconditionally. Typically only instructions are conditioned on target features.

To the relevant persons I have just added to the review: @srhines @nickdesaulniers @llozano

1. Disable the cryptographic extensions by default.
2. Small fix in TargetParserTest.cpp to include different spellings of the -march values.

Added 'the' for better phrasing.

Add missing . to end of sentences in comments.

Sorry @SjoerdMeijer , I found a bug in the implementation (as described in the latest comment). Therefore I kindly ask another round of review, please.

1. Fix bug in "+sve2" feature position in the target features list. It was being inserted at the end, which made it impossible to disable it using +nosve2, as the positive option would always be placed after the negative one.
2. Add tests to the bug fix above.

1. Enable the SVE2 extension as default.
2. Remove out of date comments in tests.
3. Remove unrelated change.

Thanks for your review

@aeubanks Yes, thank you. Just did that.

Fixes in other places of the new pass manager.

Thanks Peter. Since one week has passed, I plan to commit these changes by the end of the day if nothing surfaces.

Add a clarifying comment.

Remove if statement inside RemovePredicate as it's already covered by an assertion.

Remove predicate of instructions after the divergent one even if there's no non-debug instruction after it.

Add assertion in RemovePredicate lambda.
SKip debug instructions inside VPT blocks with predicate divergence.

LGTM. mem2reg is a simple enough optimization to clear up the IR in this case. Thank you.

@Tyker This is causing another build failure in another example:

Not really. Closing it

1. Add comment explaining the MVE-Integer detail.
2. Add another test to check the disabled features.

Ping.

1. Merged the second patch into this (handle bf16).
2. Do the same treatment for -mcpu.
3. Instead of doing string search once again, return the desired information in the first time using a by-ref argument.
4. This new approach covers positional differences between +fp and +nofp.

I will merge the two patches into one.

This is the problematic case:

Improve the testcase which exercises loads and stores from stack. Now, wrong frame index replacements will be caught here.