User Details
- User Since
- Aug 19 2015, 11:50 AM (423 w, 2 d)
Mon, Sep 11
Tue, Sep 5
I don't understand the motivation here. This moves PAuth's instruction insertion later down the pipeline, but why? The handling in the machine outliner isn't made any simpler IMO.
Aug 16 2023
Aug 15 2023
@aprantl We have discussed internally a few options to implement correct debug information in this case. But this will be future work.
- Redone test to cover only what's needed.
Aug 11 2023
- Addressed the one comment regarding code.
- Changed the test to use update_cc_test
Aug 9 2023
Feb 23 2023
Hi @brenoguim, I will submit this patch for you.
Jan 11 2023
Jan 10 2023
Dec 8 2022
This was not an NFC change as the call to isDeadStore doesn't happen anymore in noasserts builds.
Nov 9 2022
Nov 8 2022
Rebasing and conflict resolution
@tschuett Do you still want me to put the note about 'native' detection for neoverse-v2 back?
Nov 2 2022
Added SSBS
Added AEK_FLAM to the list of features for Cortex-X3
Oct 31 2022
Combining release notes of Cortex-X3 and Neoverse V2.
Oct 28 2022
Oct 27 2022
We found an issue in the list of target features for v9-A. This patch will be affected.
Oct 25 2022
Comments addressed
Oct 24 2022
Oct 7 2022
For reference, a null pointer can reach this code from Archive.cpp line 458.
Sep 13 2022
For reference, another small reproducer of the crash, but with a different stack trace than the first example posted here:
Aug 22 2022
Aug 19 2022
Aug 16 2022
Aug 11 2022
Small improvement to printStringEscapedImpl
More general handling of attributes inside also_compatible_with
Aug 1 2022
Jul 26 2022
Jul 25 2022
It LGTM too. Thanks.
Jul 15 2022
LGTM. Please wait one week or so for any other comment.
Jul 13 2022
I can't think of a way to test multiple Tag_CPU_arch values in the same test file. So I created one test file for each CPU arch that I touched.
Adding testcases
Jul 12 2022
A couple of typos in the commit message:
Apr 5 2022
LGTM.
Mar 18 2022
LGTM, thanks
Feb 22 2022
LGTM
Feb 21 2022
I don't see any problem with the patch, but we should wait on @SjoerdMeijer.
Jan 4 2022
Dec 10 2021
LGTM.
Nov 29 2021
Nov 25 2021
Oct 28 2021
Oct 19 2021
Hi. Yes, it is intended behaviour. New system registers are usually available unconditionally. Typically only instructions are conditioned on target features.
Oct 12 2021
Oct 11 2021
Oct 5 2021
To the relevant persons I have just added to the review: @srhines @nickdesaulniers @llozano
Sep 30 2021
- Disable the cryptographic extensions by default.
- Small fix in TargetParserTest.cpp to include different spellings of the -march values.
Sep 22 2021
Added 'the' for better phrasing.
Add missing . to end of sentences in comments.
Sep 21 2021
Sorry @SjoerdMeijer , I found a bug in the implementation (as described in the latest comment). Therefore I kindly ask another round of review, please.
- Fix bug in "+sve2" feature position in the target features list. It was being inserted at the end, which made it impossible to disable it using +nosve2, as the positive option would always be placed after the negative one.
- Add tests to the bug fix above.
Sep 16 2021
Sep 14 2021
- Enable the SVE2 extension as default.
- Remove out of date comments in tests.
- Remove unrelated change.