I don't understand the motivation here. This moves PAuth's instruction insertion later down the pipeline, but why? The handling in the machine outliner isn't made any simpler IMO.

@aprantl We have discussed internally a few options to implement correct debug information in this case. But this will be future work.

• Redone test to cover only what's needed.

• Addressed the one comment regarding code.
• Changed the test to use update_cc_test

Hi @brenoguim, I will submit this patch for you.

This was not an NFC change as the call to isDeadStore doesn't happen anymore in noasserts builds.

Rebasing and conflict resolution

@tschuett Do you still want me to put the note about 'native' detection for neoverse-v2 back?

Added SSBS

Added AEK_FLAM to the list of features for Cortex-X3

Combining release notes of Cortex-X3 and Neoverse V2.

We found an issue in the list of target features for v9-A. This patch will be affected.

Comments addressed

For reference, a null pointer can reach this code from Archive.cpp line 458.

For reference, another small reproducer of the crash, but with a different stack trace than the first example posted here:

Small improvement to printStringEscapedImpl

More general handling of attributes inside also_compatible_with

It LGTM too. Thanks.

LGTM. Please wait one week or so for any other comment.

I can't think of a way to test multiple Tag_CPU_arch values in the same test file. So I created one test file for each CPU arch that I touched.

Adding testcases

A couple of typos in the commit message:

LGTM.

LGTM, thanks

LGTM

I don't see any problem with the patch, but we should wait on @SjoerdMeijer.

LGTM.

Hi. Yes, it is intended behaviour. New system registers are usually available unconditionally. Typically only instructions are conditioned on target features.

To the relevant persons I have just added to the review: @srhines @nickdesaulniers @llozano

1. Disable the cryptographic extensions by default.
2. Small fix in TargetParserTest.cpp to include different spellings of the -march values.

Added 'the' for better phrasing.

Add missing . to end of sentences in comments.

Sorry @SjoerdMeijer , I found a bug in the implementation (as described in the latest comment). Therefore I kindly ask another round of review, please.

1. Fix bug in "+sve2" feature position in the target features list. It was being inserted at the end, which made it impossible to disable it using +nosve2, as the positive option would always be placed after the negative one.
2. Add tests to the bug fix above.

1. Enable the SVE2 extension as default.
2. Remove out of date comments in tests.
3. Remove unrelated change.