This is an archive of the discontinued LLVM Phabricator instance.

Differential D93538

[AArch64] Updating .arch_extension negative tests
ClosedPublic

Authored by pratlucas on Dec 18 2020, 5:54 AM.

Details

Reviewers
olista01
ostannard
dmgreen
vhscampos
simon_tatham
Commits
rG91593e461a24: [AArch64] Updating .arch_extension negative tests
Summary

This updates the test for the .arch_extension as directive negatives
to properly enable the extensions being tested on the llvm-mc command
line before validating that the directive correctly disables them.

Diff Detail

Event Timeline

pratlucas created this revision.Dec 18 2020, 5:54 AM
Herald added subscribers: danielkiss, kristof.beyls. · View Herald TranscriptDec 18 2020, 5:54 AM
pratlucas requested review of this revision.Dec 18 2020, 5:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 18 2020, 5:54 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
pratlucas added a parent revision: D92574: [AArch64] Add support for ls64 to the .arch_extension asm directive.Dec 18 2020, 6:00 AM
pratlucas added reviewers: olista01, ostannard, dmgreen, vhscampos, simon_tatham.
pratlucas mentioned this in D92574: [AArch64] Add support for ls64 to the .arch_extension asm directive.
ostannard accepted this revision.Dec 18 2020, 6:15 AM

LGTM

This revision is now accepted and ready to land.Dec 18 2020, 6:15 AM
This revision was landed with ongoing or failed builds.Dec 18 2020, 7:57 AM
Closed by commit rG91593e461a24: [AArch64] Updating .arch_extension negative tests (authored by pratlucas). · Explain Why
This revision was automatically updated to reflect the committed changes.
pratlucas added a commit: rG91593e461a24: [AArch64] Updating .arch_extension negative tests.

Revision Contents

PathSize
llvm/
test/
MC/
AArch64/
72 lines

Diff 312799

llvm/test/MC/AArch64/directive-arch_extension-negative.s

// RUN: not llvm-mc -triple aarch64 -filetype asm -o - %s 2>&1 | FileCheck %s // RUN: not llvm-mc -triple aarch64 \
// RUN: -mattr=+crc,+sm4,+sha3,+sha2,+aes,+fp,+neon,+ras,+lse,+predres,+ccdp,+mte,+tlb-rmi,+pan-rwv,+ccpp,+rcpc,+ls64 \
// RUN: -filetype asm -o - %s 2>&1 | FileCheck %s
.arch_extension axp64 .arch_extension axp64
// CHECK: error: unknown architectural extension: axp64 // CHECK: error: unknown architectural extension: axp64
// CHECK-NEXT: .arch_extension axp64 // CHECK-NEXT: .arch_extension axp64
crc32cx w0, w1, x3
// CHECK-NOT: [[@LINE-1]]:1: error: instruction requires: crc
.arch_extension nocrc .arch_extension nocrc
crc32cx w0, w1, x3 crc32cx w0, w1, x3
// CHECK: error: instruction requires: crc // CHECK: [[@LINE-1]]:1: error: instruction requires: crc
// CHECK-NEXT: crc32cx w0, w1, x3 // CHECK-NEXT: crc32cx w0, w1, x3
sm4e v2.4s, v15.4s
// CHECK-NOT: [[@LINE-1]]:1: error: instruction requires: sm4
.arch_extension nosm4 .arch_extension nosm4
sm4e v2.4s, v15.4s sm4e v2.4s, v15.4s
// CHECK: error: instruction requires: sm4 // CHECK: [[@LINE-1]]:1: error: instruction requires: sm4
// CHECK-NEXT: sm4e v2.4s, v15.4s // CHECK-NEXT: sm4e v2.4s, v15.4s
sha512h q0, q1, v2.2d
// CHECK-NOT: [[@LINE-1]]:1: error: instruction requires: sha3
.arch_extension nosha3 .arch_extension nosha3
sha512h q0, q1, v2.2d sha512h q0, q1, v2.2d
// CHECK: error: instruction requires: sha3 // CHECK: [[@LINE-1]]:1: error: instruction requires: sha3
// CHECK-NEXT: sha512h q0, q1, v2.2d // CHECK-NEXT: sha512h q0, q1, v2.2d
sha1h s0, s1
// CHECK-NOT: [[@LINE-1]]:1: error: instruction requires: sha2
.arch_extension nosha2 .arch_extension nosha2
sha1h s0, s1 sha1h s0, s1
// CHECK: error: instruction requires: sha2 // CHECK: [[@LINE-1]]:1: error: instruction requires: sha2
// CHECK-NEXT: sha1h s0, s1 // CHECK-NEXT: sha1h s0, s1
aese v0.16b, v1.16b
// CHECK-NOT: [[@LINE-1]]:1: error: instruction requires: aes
.arch_extension noaes .arch_extension noaes
aese v0.16b, v1.16b aese v0.16b, v1.16b
// CHECK: error: instruction requires: aes // CHECK: [[@LINE-1]]:1: error: instruction requires: aes
// CHECK-NEXT: aese v0.16b, v1.16b // CHECK-NEXT: aese v0.16b, v1.16b
fminnm d0, d0, d1
// CHECK-NOT: [[@LINE-1]]:1: error: instruction requires: fp
.arch_extension nofp .arch_extension nofp
fminnm d0, d0, d1 fminnm d0, d0, d1
// CHECK: error: instruction requires: fp // CHECK: [[@LINE-1]]:1: error: instruction requires: fp
// CHECK-NEXT: fminnm d0, d0, d1 // CHECK-NEXT: fminnm d0, d0, d1
addp v0.4s, v0.4s, v0.4s
// CHECK-NOT: [[@LINE-1]]:1: error: instruction requires: neon
.arch_extension nosimd .arch_extension nosimd
addp v0.4s, v0.4s, v0.4s addp v0.4s, v0.4s, v0.4s
// CHECK: error: instruction requires: neon // CHECK: [[@LINE-1]]:1: error: instruction requires: neon
// CHECK-NEXT: addp v0.4s, v0.4s, v0.4s // CHECK-NEXT: addp v0.4s, v0.4s, v0.4s
esb
// CHECK-NOT: [[@LINE-1]]:1: error: instruction requires: ras
.arch_extension noras .arch_extension noras
esb esb
// CHECK: error: instruction requires: ras // CHECK: [[@LINE-1]]:1: error: instruction requires: ras
// CHECK-NEXT: esb // CHECK-NEXT: esb
casa w5, w7, [x20]
// CHECK-NOT: [[@LINE-1]]:1: error: instruction requires: lse
.arch_extension nolse .arch_extension nolse
casa w5, w7, [x20] casa w5, w7, [x20]
// CHECK: error: instruction requires: lse // CHECK: [[@LINE-1]]:1: error: instruction requires: lse
// CHECK-NEXT: casa w5, w7, [x20] // CHECK-NEXT: casa w5, w7, [x20]
cfp rctx, x0
// CHECK-NOT: [[@LINE-1]]:5: error: CFPRCTX requires: predres
.arch_extension nopredres .arch_extension nopredres
cfp rctx, x0 cfp rctx, x0
// CHECK: error: CFPRCTX requires: predres // CHECK: [[@LINE-1]]:5: error: CFPRCTX requires: predres
// CHECK-NEXT: cfp rctx, x0 // CHECK-NEXT: cfp rctx, x0
dc cvadp, x7
// CHECK-NOT: [[@LINE-1]]:4: error: DC CVADP requires: ccdp
.arch_extension noccdp .arch_extension noccdp
dc cvadp, x7 dc cvadp, x7
// CHECK: error: DC CVADP requires: ccdp // CHECK: [[@LINE-1]]:4: error: DC CVADP requires: ccdp
// CHECK-NEXT: dc cvadp, x7 // CHECK-NEXT: dc cvadp, x7
irg x0, x1
// CHECK-NOT: [[@LINE-1]]:1: error: instruction requires: mte
.arch_extension nomte .arch_extension nomte
irg x0, x1 irg x0, x1
// CHECK: error: instruction requires: mte // CHECK: [[@LINE-1]]:1: error: instruction requires: mte
// CHECK-NEXT: irg x0, x1 // CHECK-NEXT: irg x0, x1
tlbi vmalle1os
// CHECK-NOT: [[@LINE-1]]:6: error: TLBI VMALLE1OS requires: tlb-rmi
.arch_extension notlb-rmi .arch_extension notlb-rmi
tlbi vmalle1os tlbi vmalle1os
// CHECK: error: TLBI VMALLE1OS requires: tlb-rmi // CHECK: [[@LINE-1]]:6: error: TLBI VMALLE1OS requires: tlb-rmi
// CHECK-NEXT: tlbi vmalle1os // CHECK-NEXT: tlbi vmalle1os
at s1e1wp, x2
// CHECK-NOT: [[@LINE-1]]:4: error: AT S1E1WP requires: pan-rwv
.arch_extension nopan-rwv .arch_extension nopan-rwv
at s1e1wp, x2 at s1e1wp, x2
// CHECK: error: AT S1E1WP requires: pan-rwv // CHECK: [[@LINE-1]]:4: error: AT S1E1WP requires: pan-rwv
// CHECK-NEXT: at s1e1wp, x2 // CHECK-NEXT: at s1e1wp, x2
dc cvap, x7
// CHECK-NOT: [[@LINE-1]]:4: error: DC CVAP requires: ccpp
.arch_extension noccpp .arch_extension noccpp
dc cvap, x7 dc cvap, x7
// CHECK: error: DC CVAP requires: ccpp // CHECK: [[@LINE-1]]:4: error: DC CVAP requires: ccpp
// CHECK-NEXT: dc cvap, x7 // CHECK-NEXT: dc cvap, x7
ldapr x0, [x1]
// CHECK-NOT: [[@LINE-1]]:1: error: instruction requires: rcpc
.arch_extension norcpc .arch_extension norcpc
ldapr x0, [x1] ldapr x0, [x1]
// CHECK: error: instruction requires: rcpc // CHECK: [[@LINE-1]]:1: error: instruction requires: rcpc
// CHECK-NEXT: ldapr x0, [x1] // CHECK-NEXT: ldapr x0, [x1]
ld64b x0, [x13]
// CHECK-NOT: [[@LINE-1]]:1: error: instruction requires: ls64
.arch_extension nols64 .arch_extension nols64
ld64b x0, [x13] ld64b x0, [x13]
// CHECK: error: instruction requires: ls64 // CHECK: [[@LINE-1]]:1: error: instruction requires: ls64
// CHECK-NEXT: ld64b x0, [x13] // CHECK-NEXT: ld64b x0, [x13]