Page MenuHomePhabricator

pratlucas (Lucas Prates)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 21 2020, 7:29 AM (128 w, 21 h)

Recent Activity

Today

pratlucas committed rGe0af05574175: [Docs] Add release note for ARM's new -mframe-chain option (authored by pratlucas).
[Docs] Add release note for ARM's new -mframe-chain option
Wed, Jul 6, 2:07 AM · Restricted Project, Restricted Project
pratlucas closed D129085: [Docs] Add release note for ARM's new -mframe-chain option.
Wed, Jul 6, 2:07 AM · Restricted Project, Restricted Project

Mon, Jul 4

pratlucas added a reviewer for D129085: [Docs] Add release note for ARM's new -mframe-chain option: efriedma.
Mon, Jul 4, 8:21 AM · Restricted Project, Restricted Project
pratlucas requested review of D129085: [Docs] Add release note for ARM's new -mframe-chain option.
Mon, Jul 4, 8:20 AM · Restricted Project, Restricted Project

Mon, Jun 27

pratlucas committed rG70a5c525349b: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records (authored by pratlucas).
[ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records
Mon, Jun 27, 6:09 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas closed D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.
Mon, Jun 27, 6:08 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas updated the diff for D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.

Updating method to use MAchineBasickBlock::iterator&.

Mon, Jun 27, 6:07 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Jun 23

pratlucas updated the diff for D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.

Fixing use-after-poison issue detected by ASAN buildbot.

Thu, Jun 23, 5:35 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas reopened D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.
Thu, Jun 23, 5:31 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 14

pratlucas added a comment to D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.

@RKSimon I was writting my comment above just before I saw your message, lucky they went in in the correct order :)
I'm tracking down the source of the invalid tMOVr and I'll raise a ticket with the details.

Tue, Jun 14, 6:58 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas added a comment to D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.

The newly added frame-chain.ll test uncovered an issue with an invalid use of the tMOVr instruction, which is only available from V6 onwards. The failure was captured by a buildbot with expensive checks enabled.
The issue is unrelated to the codegen changes from this patch, and still happens when compiling the same IR code if the changes are reverted.
Given the above, I've updated the test to use thumbv6m while the issue is not resolved: rGcbcce82ef6b5.

Tue, Jun 14, 6:44 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas committed rGcbcce82ef6b5: [NFC][Thumb] Update frame-chain codegen test to use thumbv6m (authored by pratlucas).
[NFC][Thumb] Update frame-chain codegen test to use thumbv6m
Tue, Jun 14, 6:38 AM · Restricted Project, Restricted Project
pratlucas committed rG7625e01d6616: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records (authored by pratlucas).
[ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records
Tue, Jun 14, 5:38 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas closed D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.
Tue, Jun 14, 5:37 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Jun 13

pratlucas updated the diff for D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.

Fixing assertion failure caused by incorrect use of tSTRr.

Mon, Jun 13, 8:07 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas reopened D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.
Mon, Jun 13, 3:05 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas committed rG33b9ad647e91: Revert "[ARM][Thumb] Command-line option to ensure AAPCS compliant Frame… (authored by pratlucas).
Revert "[ARM][Thumb] Command-line option to ensure AAPCS compliant Frame…
Mon, Jun 13, 3:05 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas added a reverting change for rG6119053dab67: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records: rG33b9ad647e91: Revert "[ARM][Thumb] Command-line option to ensure AAPCS compliant Frame….
Mon, Jun 13, 3:05 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas added a reverting change for D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records: rG33b9ad647e91: Revert "[ARM][Thumb] Command-line option to ensure AAPCS compliant Frame….
Mon, Jun 13, 3:04 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas committed rG6119053dab67: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records (authored by pratlucas).
[ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records
Mon, Jun 13, 2:21 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas closed D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.
Mon, Jun 13, 2:21 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas committed rG7775124b5c9d: [NFC][Thumb1] Use FrameDestroy flag to identify epilog instructions (authored by pratlucas).
[NFC][Thumb1] Use FrameDestroy flag to identify epilog instructions
Mon, Jun 13, 2:19 AM · Restricted Project, Restricted Project
pratlucas closed D126285: [NFC][Thumb1] Use FrameDestroy flag to identify epilog instructions.
Mon, Jun 13, 2:19 AM · Restricted Project, Restricted Project

Wed, Jun 8

pratlucas added inline comments to D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.
Wed, Jun 8, 7:41 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas updated the diff for D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.

Avoid scavenging extra register when accessing const pool.

Wed, Jun 8, 7:38 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 7

pratlucas added inline comments to D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.
Tue, Jun 7, 9:27 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas updated the diff for D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.

Addressing comments.

Tue, Jun 7, 9:26 AM · Restricted Project, Restricted Project, Restricted Project

May 24 2022

pratlucas added a reviewer for D126285: [NFC][Thumb1] Use FrameDestroy flag to identify epilog instructions: efriedma.
May 24 2022, 3:58 AM · Restricted Project, Restricted Project
pratlucas added inline comments to D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.
May 24 2022, 3:57 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas updated the diff for D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.

Avoiding unecessary uses of FP and addressing review comments.

May 24 2022, 3:37 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas requested review of D126285: [NFC][Thumb1] Use FrameDestroy flag to identify epilog instructions.
May 24 2022, 3:28 AM · Restricted Project, Restricted Project

May 20 2022

pratlucas updated the diff for D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.

Addressing review comments.

May 20 2022, 8:58 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas added inline comments to D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.
May 20 2022, 8:58 AM · Restricted Project, Restricted Project, Restricted Project

May 18 2022

pratlucas updated the diff for D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.

Fix incorrect use of r11 on load/store instructions.

May 18 2022, 4:28 AM · Restricted Project, Restricted Project, Restricted Project

May 13 2022

pratlucas added inline comments to D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.
May 13 2022, 7:42 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas updated the diff for D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.

Adding frame access test coverage, adding check for FrameSetup flag and adjusting calculation of FP value.

May 13 2022, 7:34 AM · Restricted Project, Restricted Project, Restricted Project

May 6 2022

pratlucas added reviewers for D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records: ostannard, rnk, asl, tmatheson, labrinea.
May 6 2022, 7:23 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas updated the diff for D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.

Addressing linting messages.

May 6 2022, 7:19 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas requested review of D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records.
May 6 2022, 7:03 AM · Restricted Project, Restricted Project, Restricted Project

Jan 20 2022

pratlucas committed rG283f5a198a0e: [GlobalISel] Fix incorrect sign extension when combining G_INTTOPTR and… (authored by pratlucas).
[GlobalISel] Fix incorrect sign extension when combining G_INTTOPTR and…
Jan 20 2022, 9:03 AM
pratlucas closed D116941: [GlobalISel] Fix incorrect sign extension when combining G_INTTOPTR and G_PTR_ADD.
Jan 20 2022, 9:02 AM · Restricted Project

Jan 13 2022

pratlucas added inline comments to D116941: [GlobalISel] Fix incorrect sign extension when combining G_INTTOPTR and G_PTR_ADD.
Jan 13 2022, 3:27 AM · Restricted Project
pratlucas updated the diff for D116941: [GlobalISel] Fix incorrect sign extension when combining G_INTTOPTR and G_PTR_ADD.

Updating comment.

Jan 13 2022, 3:06 AM · Restricted Project

Jan 11 2022

pratlucas retitled D116941: [GlobalISel] Fix incorrect sign extension when combining G_INTTOPTR and G_PTR_ADD from [GlobalISel] Fix incorrect sign extension when combining G_INTTOPTR and G_ADD to [GlobalISel] Fix incorrect sign extension when combining G_INTTOPTR and G_PTR_ADD.
Jan 11 2022, 1:46 AM · Restricted Project
pratlucas updated the diff for D116941: [GlobalISel] Fix incorrect sign extension when combining G_INTTOPTR and G_PTR_ADD.

Using APInt on match/apply functions' interfaces and merging mir test into existing one.

Jan 11 2022, 1:41 AM · Restricted Project

Jan 10 2022

pratlucas added reviewers for D116941: [GlobalISel] Fix incorrect sign extension when combining G_INTTOPTR and G_PTR_ADD: aditya_nandakumar, arsenm, Petar.Avramovic.
Jan 10 2022, 7:34 AM · Restricted Project
pratlucas requested review of D116941: [GlobalISel] Fix incorrect sign extension when combining G_INTTOPTR and G_PTR_ADD.
Jan 10 2022, 7:21 AM · Restricted Project

Dec 31 2021

pratlucas accepted D115694: [ARM] Introduce an empty "armv8.8-a" architecture..

LGTM

Dec 31 2021, 3:50 AM · Restricted Project, Restricted Project

Sep 23 2021

pratlucas added inline comments to D110065: [AArch64] Add support for the 'R' architecture profile..
Sep 23 2021, 12:59 AM · Restricted Project, Restricted Project

Sep 22 2021

pratlucas accepted D110241: [docs] List support for Armv9-A, Armv9.1-A and Armv9.2-A in LLVM and Clang.

LGTM.

Sep 22 2021, 6:40 AM · Restricted Project, Restricted Project

Jun 29 2021

pratlucas abandoned D102909: [NPM] Ability to add a pass before a previously registered one.

The limitation with the registerOptimizerLastEPCallback ordering is that, when they come from different plugins - i.e. different shared libraries -, it is currently based solely on the order of command line options and can't be defined in the code.

Jun 29 2021, 8:04 AM · Restricted Project

Jun 28 2021

pratlucas committed rG5cf27532fa6f: [NFC] Fixing short title underline in release notes file (authored by pratlucas).
[NFC] Fixing short title underline in release notes file
Jun 28 2021, 5:55 AM
pratlucas committed rG88b1135e72ea: [Aarch64] Adding support for Armv9-A Realm Management Extension (authored by pratlucas).
[Aarch64] Adding support for Armv9-A Realm Management Extension
Jun 28 2021, 5:45 AM
pratlucas closed D104773: [Aarch64] Adding support for Armv9-A Realm Management Extension.
Jun 28 2021, 5:45 AM · Restricted Project
pratlucas committed rG7749b19e9cb1: [NFC] Adding test for clobbering of high registers in Thumb (authored by pratlucas).
[NFC] Adding test for clobbering of high registers in Thumb
Jun 28 2021, 5:45 AM
pratlucas closed D96335: [NFC] Adding test for clobbering of high registers in Thumb.
Jun 28 2021, 5:44 AM · Restricted Project

Jun 25 2021

pratlucas added inline comments to D104773: [Aarch64] Adding support for Armv9-A Realm Management Extension.
Jun 25 2021, 7:36 AM · Restricted Project
pratlucas updated the diff for D104773: [Aarch64] Adding support for Armv9-A Realm Management Extension.

Adding subtarget feature to control RME availability.

Jun 25 2021, 7:34 AM · Restricted Project

Jun 24 2021

pratlucas updated the diff for D104773: [Aarch64] Adding support for Armv9-A Realm Management Extension.

Rebasing.

Jun 24 2021, 3:12 AM · Restricted Project
pratlucas updated the summary of D104773: [Aarch64] Adding support for Armv9-A Realm Management Extension.
Jun 24 2021, 2:13 AM · Restricted Project

Jun 23 2021

pratlucas updated the diff for D104773: [Aarch64] Adding support for Armv9-A Realm Management Extension.

Adding RME support to release notes.

Jun 23 2021, 3:54 AM · Restricted Project
pratlucas added reviewers for D104773: [Aarch64] Adding support for Armv9-A Realm Management Extension: vhscampos, ostannard, tmatheson, labrinea, MarkMurrayARM, michaelplatings, dmgreen.
Jun 23 2021, 2:31 AM · Restricted Project
pratlucas requested review of D104773: [Aarch64] Adding support for Armv9-A Realm Management Extension.
Jun 23 2021, 2:29 AM · Restricted Project

Jun 18 2021

pratlucas accepted D104476: [ARM][NFC] Tidy up subtarget frame pointer routines.

LGTM.

Jun 18 2021, 6:29 AM · Restricted Project

Jun 14 2021

pratlucas added a comment to D102909: [NPM] Ability to add a pass before a previously registered one.

This solution works well if both passes are always supposed to be run together. If they should also work as standalone passes, it becomes tricky to figure out at what point each of them should be registered.
This could be done using the legacy pass manager on a hacky kind of way by querying for the passes on the PassRegistry, but this is no longer an option in NPM.

Jun 14 2021, 6:48 AM · Restricted Project

Jun 9 2021

pratlucas added a comment to D102909: [NPM] Ability to add a pass before a previously registered one.

I'd still like to understand exactly what you'd be using this for. As in why does some pass need to run before all other instances of some other pass?

Jun 9 2021, 9:10 AM · Restricted Project

May 24 2021

pratlucas added a comment to D102909: [NPM] Ability to add a pass before a previously registered one.

Hi @aeubanks,
As I mentioned, this is mostly targeted on plugin passes. At the moment the NPM only offers the PassBuilder's callbacks level of granularity to control when a plugin pass should be run, which might not be sufficient on some cases. The goal was to provide a more fine grained control over this, allowing plugin implementations to run before other native or plugin passes that migth impact their behavior.
Do you have any suggestions on alternative ways to achieve this? I'm not fond of using pass names here myself and would be more than happy to go for a different implementation.

May 24 2021, 2:07 AM · Restricted Project

May 21 2021

pratlucas added reviewers for D102909: [NPM] Ability to add a pass before a previously registered one: aeubanks, TaWeiTu, ychen, chandlerc.
May 21 2021, 3:21 AM · Restricted Project
pratlucas requested review of D102909: [NPM] Ability to add a pass before a previously registered one.
May 21 2021, 2:56 AM · Restricted Project

Feb 24 2021

pratlucas added a comment to D96335: [NFC] Adding test for clobbering of high registers in Thumb.

Ping.

Feb 24 2021, 2:59 AM · Restricted Project

Feb 15 2021

pratlucas updated the diff for D96335: [NFC] Adding test for clobbering of high registers in Thumb.

Dropping test's IR section.

Feb 15 2021, 8:23 AM · Restricted Project

Feb 11 2021

pratlucas accepted D96493: [ARM] Copy-paste error in ARMv87a architecture definition..

LGTM.

Feb 11 2021, 5:31 AM · Restricted Project

Feb 9 2021

pratlucas added reviewers for D96335: [NFC] Adding test for clobbering of high registers in Thumb: eli.friedman, MarkMurrayARM, john.brawn, arsenm.
Feb 9 2021, 6:17 AM · Restricted Project
pratlucas abandoned D81942: [NFC][CodeGen] Refactor: splitting register allocation method in RegAllocFast.

This change is no longer relevant after D52010.

Feb 9 2021, 6:16 AM · Restricted Project
pratlucas abandoned D80999: [ARM][CodeGen] Enabling spilling of high registers in RegAllocFast for Thumb1.

The changes from D52010 have removed the conflict that made the spilling of high register necessary.
This patch is no longer relevant. D96335 adds a test covering the high register clobbering scenario.

Feb 9 2021, 6:15 AM · Restricted Project
pratlucas requested review of D96335: [NFC] Adding test for clobbering of high registers in Thumb.
Feb 9 2021, 6:13 AM · Restricted Project

Feb 2 2021

pratlucas abandoned D75904: [ARM][CodeGen] Fixing stack alignment of HFA arguments on AArch32 PCS.
Feb 2 2021, 2:06 AM · Restricted Project, Restricted Project
pratlucas abandoned D75903: [AArch64][CodeGen] Fixing stack alignment of HFA arguments on AArch64 PCS.
Feb 2 2021, 2:06 AM · Restricted Project, Restricted Project

Jan 27 2021

pratlucas accepted D93101: [Clang][Codegen] Truncate initializers of union bitfield members.

The truncate conditions look a lot better and the test coverage seems reasonable now.
LGTM.

Jan 27 2021, 8:31 AM · Restricted Project

Jan 14 2021

pratlucas committed rG2b1e25befefc: [AArch64] Adding ACLE intrinsics for the LS64 extension (authored by pratlucas).
[AArch64] Adding ACLE intrinsics for the LS64 extension
Jan 14 2021, 1:44 AM
pratlucas closed D93232: [AArch64] Adding ACLE intrinsics for the LS64 extension.
Jan 14 2021, 1:44 AM · Restricted Project, Restricted Project
pratlucas accepted D94616: [NFC] Disallow unused prefixes under MC/AArch64.

LGTM.

Jan 14 2021, 1:39 AM · Restricted Project

Jan 12 2021

pratlucas added a comment to D93232: [AArch64] Adding ACLE intrinsics for the LS64 extension.

Ping.

Jan 12 2021, 1:44 AM · Restricted Project, Restricted Project

Jan 7 2021

pratlucas added a comment to D94233: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function attribute id changes.

No problem! I've pushed the commit on your behalf.

Jan 7 2021, 9:11 AM · Restricted Project
pratlucas committed rG59fce6b06616: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function… (authored by jeroen.dobbelaere).
[NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function…
Jan 7 2021, 9:08 AM
pratlucas closed D94233: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function attribute id changes.
Jan 7 2021, 9:08 AM · Restricted Project
pratlucas accepted D94233: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function attribute id changes.

LGMT.

Jan 7 2021, 7:29 AM · Restricted Project

Jan 4 2021

pratlucas added a comment to D93232: [AArch64] Adding ACLE intrinsics for the LS64 extension.

Ping.

Jan 4 2021, 9:24 AM · Restricted Project, Restricted Project

Dec 18 2020

pratlucas committed rG91593e461a24: [AArch64] Updating .arch_extension negative tests (authored by pratlucas).
[AArch64] Updating .arch_extension negative tests
Dec 18 2020, 7:57 AM
pratlucas closed D93538: [AArch64] Updating .arch_extension negative tests.
Dec 18 2020, 7:57 AM · Restricted Project
pratlucas committed rG1a9577bde1dd: [AArch64] Add support for ls64 to the .arch_extension asm directive (authored by pratlucas).
[AArch64] Add support for ls64 to the .arch_extension asm directive
Dec 18 2020, 7:56 AM
pratlucas closed D92574: [AArch64] Add support for ls64 to the .arch_extension asm directive.
Dec 18 2020, 7:56 AM · Restricted Project
pratlucas added inline comments to D92574: [AArch64] Add support for ls64 to the .arch_extension asm directive.
Dec 18 2020, 6:02 AM · Restricted Project
pratlucas added reviewers for D93538: [AArch64] Updating .arch_extension negative tests: olista01, ostannard, dmgreen, vhscampos, simon_tatham.
Dec 18 2020, 6:01 AM · Restricted Project
pratlucas requested review of D93538: [AArch64] Updating .arch_extension negative tests.
Dec 18 2020, 5:54 AM · Restricted Project
pratlucas committed rG51fe17b0471a: [AArch64] Add support for the SPE-EEF feature (authored by pratlucas).
[AArch64] Add support for the SPE-EEF feature
Dec 18 2020, 3:12 AM
pratlucas closed D92391: [AArch64] Add support for the SPE-EEF feature.
Dec 18 2020, 3:12 AM · Restricted Project
pratlucas committed rGda21f7ec146e: [AArch64] Add support for the Branch Record Buffer extension (authored by pratlucas).
[AArch64] Add support for the Branch Record Buffer extension
Dec 18 2020, 3:11 AM
pratlucas closed D92389: [AArch64] Add support for the Branch Record Buffer extension.
Dec 18 2020, 3:11 AM · Restricted Project

Dec 17 2020

pratlucas committed rGc5046ebdf6e4: [ARM] Adding v8.7-A command-line support for the ARM target (authored by pratlucas).
[ARM] Adding v8.7-A command-line support for the ARM target
Dec 17 2020, 5:49 AM