User Details
User Details
- User Since
- Jan 21 2020, 7:29 AM (165 w, 5 d)
Thu, Mar 2
Thu, Mar 2
pratlucas added a comment to D145131: [Arm][AArch64] Setting IsX18ReservedByDefault() to true for Unknown OSes.
I agree with @dmgreen, this doesn't seem to be the right default behaviour according to the ABI. I understand it can be useful for building cross-platform code, but "unknown" also affects other use cases such as bare metal targets.
Jan 31 2023
Jan 31 2023
pratlucas added inline comments to D142963: [AArch64] Handle negative architecture features.
Jan 27 2023
Jan 27 2023
pratlucas committed rG852bb68ddb2b: [NFC][AArch64] Get extension strings directly from ArchInfo in target parser (authored by pratlucas).
[NFC][AArch64] Get extension strings directly from ArchInfo in target parser
pratlucas committed rG0753cf2caca7: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects (authored by pratlucas).
[NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects
pratlucas committed rG9ea00fc74c3c: [NFC][AArch64] Use optional returns in target parser instead of 'invalid'… (authored by pratlucas).
[NFC][AArch64] Use optional returns in target parser instead of 'invalid'…
Jan 26 2023
Jan 26 2023
pratlucas updated the diff for D142540: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects.
Renaming getDefaultExtensions() to getImpliedExtensions().
pratlucas added inline comments to D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects.
Jan 25 2023
Jan 25 2023
Jan 23 2023
Jan 23 2023
pratlucas committed rG5f6813beed85: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver (authored by pratlucas).
[AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver
pratlucas committed rG8246aceb90c2: [AArch64] Add command line support for v9.4-A's Instrumentation Extension (authored by pratlucas).
[AArch64] Add command line support for v9.4-A's Instrumentation Extension
pratlucas added inline comments to D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver.
pratlucas updated the diff for D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver.
Updated to use the same approach as D141518.
pratlucas updated the diff for D141403: [AArch64] Add command line support for v9.4-A's Instrumentation Extension.
Rebasing, including minor changes due to recent target parser refactoring.
pratlucas committed rG1efea0ae8ed2: [AArch64] Support v8.9-A/v9.4-A in .arch_extension directive (authored by pratlucas).
[AArch64] Support v8.9-A/v9.4-A in .arch_extension directive
pratlucas committed rG8ea4a4b0f47a: [AArch64] Add missing system register for v8.9-A/v9.4-A Permission Indirection… (authored by pratlucas).
[AArch64] Add missing system register for v8.9-A/v9.4-A Permission Indirection…
pratlucas committed rGb94b8f1e77d9: [AArch64] Make CNTPCTSS_EL0 and CNTVCTSS_EL0 system registers read-only (authored by pratlucas).
[AArch64] Make CNTPCTSS_EL0 and CNTVCTSS_EL0 system registers read-only
Jan 13 2023
Jan 13 2023
LGTM with a tiny nit. Feel free to fix it when landing the changes.
Jan 13 2023, 7:02 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
Jan 12 2023
Jan 12 2023
pratlucas added a comment to D141518: [AArch64] Move default extensions from clang Driver to TargetParser.
Sorry, I just noticed my previous comment wasn't clear on what I meant by passing on the target features.
The features are indeed included as part of the IR attributes since D141411, but they are no longer included as -target-feature arguments in calls to cc1 by the clang driver. This is not the case when using -mcpu, for example.
I agree the end result will be the same assuming the information is consistent between the TargetParser and the backend's subtarget features, but I think it would be good to define the what's the clang driver's expected behaviour to avoid any inconsistencies in the future.
pratlucas added a comment to D141518: [AArch64] Move default extensions from clang Driver to TargetParser.
It makes sense to move this to the TargetParser and the code looks much better indeed. My only concern is that this changes the driver's behaviour in regards to which target feature flags are passed from clang to the backend.
Jan 10 2023
Jan 10 2023
pratlucas added reviewers for D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver: lenary, tmatheson, stuij.
pratlucas requested review of D141402: [AArch64] Support v8.9-A/v9.4-A in .arch_extension directive.
Jan 5 2023
Jan 5 2023
LGTM.
Jan 5 2023, 1:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Jan 3 2023
Jan 3 2023
pratlucas committed rG419a21609444: [NFC][AArch64] Adjust comments in tablegen file (authored by pratlucas).
[NFC][AArch64] Adjust comments in tablegen file
Dec 19 2022
Dec 19 2022
pratlucas committed rGd73cfc6710c2: [AArch64] Add missing v8.8a Non-maskable Interrupts feature (authored by pratlucas).
[AArch64] Add missing v8.8a Non-maskable Interrupts feature
pratlucas committed rGf516e9171564: [AArch64] Add new v9.4-A PM pstate system register (authored by pratlucas).
[AArch64] Add new v9.4-A PM pstate system register
Dec 16 2022
Dec 16 2022
pratlucas added reviewers for D140216: [AArch64] Add missing v8.8a Non-maskable Interrupts feature: lenary, tmatheson, dcandler, stuij, peter.smith.
pratlucas requested review of D140216: [AArch64] Add missing v8.8a Non-maskable Interrupts feature.
LGTM.
Dec 15 2022
Dec 15 2022
pratlucas updated the summary of D139925: [AArch64] Add new v9.4-A PM pstate system register.
LGTM.
pratlucas added inline comments to D139925: [AArch64] Add new v9.4-A PM pstate system register.
Dec 13 2022
Dec 13 2022
pratlucas added inline comments to D139925: [AArch64] Add new v9.4-A PM pstate system register.
pratlucas added a comment to D139925: [AArch64] Add new v9.4-A PM pstate system register.
Indeed. I'll add an entry to the release notes to capture that.
pratlucas requested review of D139925: [AArch64] Add new v9.4-A PM pstate system register.
Dec 8 2022
Dec 8 2022
pratlucas committed rG2050e7ebe18c: [Arm][AArch64] Add support for v8.9-A/v9.4-A base extensions (authored by pratlucas).
[Arm][AArch64] Add support for v8.9-A/v9.4-A base extensions
Dec 6 2022
Dec 6 2022
pratlucas requested review of D139424: [Arm][AArch64] Add support for v8.9-A/v9.4-A base extensions.
Dec 5 2022
Dec 5 2022
LGTM
Nov 30 2022
Nov 30 2022
LGTM
Nov 28 2022
Nov 28 2022
pratlucas added inline comments to D138753: [AArch64TargetParser] getArchFeatures -> getArchFeature.
LGTM
Nov 24 2022
Nov 24 2022
pratlucas committed rGb0d4045dabef: [AArch64] Add support for v8.9-A/v9.4-A Debug and PMU extensions (authored by pratlucas).
[AArch64] Add support for v8.9-A/v9.4-A Debug and PMU extensions
Nov 23 2022
Nov 23 2022
pratlucas updated the summary of D138556: [AArch64] Add support for v8.9-A/v9.4-A Debug and PMU extensions.
pratlucas requested review of D138556: [AArch64] Add support for v8.9-A/v9.4-A Debug and PMU extensions.
LGTM.
Nov 15 2022
Nov 15 2022
pratlucas added inline comments to D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support.
pratlucas added inline comments to D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support.
pratlucas added inline comments to D138026: [ARM][AArch64] Use StringRef in TargetParser structs.
LGTM.
pratlucas added inline comments to D138019: [ARM][AArch64] De-template TargetParser types.
pratlucas added inline comments to D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support.
Nov 14 2022
Nov 14 2022
LGTM, assuming the unnecessary templates are going to be removed on a follow up patch.
Oct 18 2022
Oct 18 2022
Thanks! LGTM.
Oct 13 2022
Oct 13 2022
pratlucas added inline comments to D135680: [clang][ARM] follow GCC behavior for defining __SOFTFP__.
Aug 23 2022
Aug 23 2022
pratlucas committed rGd1922c986242: [AArch64] Fix list of features for Cortex-X1C (authored by pratlucas).
[AArch64] Fix list of features for Cortex-X1C
Aug 22 2022
Aug 22 2022
LGTM.
Aug 18 2022
Aug 18 2022
pratlucas added reviewers for D132120: [AArch64] Fix list of features for Cortex-X1C: stuij, vhscampos, dmgreen.
pratlucas requested review of D132120: [AArch64] Fix list of features for Cortex-X1C.
Aug 12 2022
Aug 12 2022
LGTM.
LGTM.
Aug 8 2022
Aug 8 2022
pratlucas added inline comments to D130913: [ARM] Parse Tag_also_compatible_with attribute.
Aug 1 2022
Aug 1 2022
pratlucas committed rGba9caf91708a: [Arm] Fix parsing and emission of Tag_also_compatible_with eabi attribute (authored by pratlucas).
[Arm] Fix parsing and emission of Tag_also_compatible_with eabi attribute
Jul 13 2022
Jul 13 2022
LGTM.
pratlucas added a comment to D129631: [ARM] Add Tag_CPU_arch missing value descriptions in attribute parser.
It'd be good to have a test covering the new values. Can you add one, please?
Jul 12 2022
Jul 12 2022
pratlucas added a comment to D129500: [Arm] Fix parsing and emission of Tag_also_compatible_with eabi attribute.
Updated commit message to fix typos.
pratlucas updated the summary of D129500: [Arm] Fix parsing and emission of Tag_also_compatible_with eabi attribute.
Jul 11 2022
Jul 11 2022
pratlucas updated the summary of D129500: [Arm] Fix parsing and emission of Tag_also_compatible_with eabi attribute.
pratlucas updated the diff for D129500: [Arm] Fix parsing and emission of Tag_also_compatible_with eabi attribute.
Minor update to include order.