Page MenuHomePhabricator
People pratlucas

pratlucas (Lucas Prates)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 21 2020, 7:29 AM (73 w, 2 d)

Recent Activity
View All

Mon, Jun 14

pratlucas added a comment to D102909: [NPM] Ability to add a pass before a previously registered one.

This solution works well if both passes are always supposed to be run together. If they should also work as standalone passes, it becomes tricky to figure out at what point each of them should be registered.
This could be done using the legacy pass manager on a hacky kind of way by querying for the passes on the PassRegistry, but this is no longer an option in NPM.

Mon, Jun 14, 6:48 AM · Restricted Project

Wed, Jun 9

pratlucas added a comment to D102909: [NPM] Ability to add a pass before a previously registered one.

I'd still like to understand exactly what you'd be using this for. As in why does some pass need to run before all other instances of some other pass?

Wed, Jun 9, 9:10 AM · Restricted Project

Mon, May 24

pratlucas added a comment to D102909: [NPM] Ability to add a pass before a previously registered one.

Hi @aeubanks,
As I mentioned, this is mostly targeted on plugin passes. At the moment the NPM only offers the PassBuilder's callbacks level of granularity to control when a plugin pass should be run, which might not be sufficient on some cases. The goal was to provide a more fine grained control over this, allowing plugin implementations to run before other native or plugin passes that migth impact their behavior.
Do you have any suggestions on alternative ways to achieve this? I'm not fond of using pass names here myself and would be more than happy to go for a different implementation.

Mon, May 24, 2:07 AM · Restricted Project

Fri, May 21

pratlucas added reviewers for D102909: [NPM] Ability to add a pass before a previously registered one: aeubanks, TaWeiTu, ychen, chandlerc.
Fri, May 21, 3:21 AM · Restricted Project
pratlucas requested review of D102909: [NPM] Ability to add a pass before a previously registered one.
Fri, May 21, 2:56 AM · Restricted Project

Feb 24 2021

pratlucas added a comment to D96335: [NFC] Adding test for clobbering of high registers in Thumb.

Ping.

Feb 24 2021, 2:59 AM · Restricted Project

Feb 15 2021

pratlucas updated the diff for D96335: [NFC] Adding test for clobbering of high registers in Thumb.

Dropping test's IR section.

Feb 15 2021, 8:23 AM · Restricted Project

Feb 11 2021

pratlucas accepted D96493: [ARM] Copy-paste error in ARMv87a architecture definition..

LGTM.

Feb 11 2021, 5:31 AM · Restricted Project

Feb 9 2021

pratlucas added reviewers for D96335: [NFC] Adding test for clobbering of high registers in Thumb: eli.friedman, MarkMurrayARM, john.brawn, arsenm.
Feb 9 2021, 6:17 AM · Restricted Project
pratlucas abandoned D81942: [NFC][CodeGen] Refactor: splitting register allocation method in RegAllocFast.

This change is no longer relevant after D52010.

Feb 9 2021, 6:16 AM · Restricted Project
pratlucas abandoned D80999: [ARM][CodeGen] Enabling spilling of high registers in RegAllocFast for Thumb1.

The changes from D52010 have removed the conflict that made the spilling of high register necessary.
This patch is no longer relevant. D96335 adds a test covering the high register clobbering scenario.

Feb 9 2021, 6:15 AM · Restricted Project
pratlucas requested review of D96335: [NFC] Adding test for clobbering of high registers in Thumb.
Feb 9 2021, 6:13 AM · Restricted Project

Feb 2 2021

pratlucas abandoned D75904: [ARM][CodeGen] Fixing stack alignment of HFA arguments on AArch32 PCS.
Feb 2 2021, 2:06 AM · Restricted Project, Restricted Project
pratlucas abandoned D75903: [AArch64][CodeGen] Fixing stack alignment of HFA arguments on AArch64 PCS.
Feb 2 2021, 2:06 AM · Restricted Project, Restricted Project

Jan 27 2021

pratlucas accepted D93101: [Clang][Codegen] Truncate initializers of union bitfield members.

The truncate conditions look a lot better and the test coverage seems reasonable now.
LGTM.

Jan 27 2021, 8:31 AM · Restricted Project

Jan 14 2021

pratlucas committed rG2b1e25befefc: [AArch64] Adding ACLE intrinsics for the LS64 extension (authored by pratlucas).
[AArch64] Adding ACLE intrinsics for the LS64 extension
Jan 14 2021, 1:44 AM
pratlucas closed D93232: [AArch64] Adding ACLE intrinsics for the LS64 extension.
Jan 14 2021, 1:44 AM · Restricted Project, Restricted Project
pratlucas accepted D94616: [NFC] Disallow unused prefixes under MC/AArch64.

LGTM.

Jan 14 2021, 1:39 AM · Restricted Project

Jan 12 2021

pratlucas added a comment to D93232: [AArch64] Adding ACLE intrinsics for the LS64 extension.

Ping.

Jan 12 2021, 1:44 AM · Restricted Project, Restricted Project

Jan 7 2021

pratlucas added a comment to D94233: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function attribute id changes.

No problem! I've pushed the commit on your behalf.

Jan 7 2021, 9:11 AM · Restricted Project
pratlucas committed rG59fce6b06616: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function… (authored by jeroen.dobbelaere).
[NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function…
Jan 7 2021, 9:08 AM
pratlucas closed D94233: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function attribute id changes.
Jan 7 2021, 9:08 AM · Restricted Project
pratlucas accepted D94233: [NFC] make clang/test/CodeGen/arm_neon_intrinsics.c resistent to function attribute id changes.

LGMT.

Jan 7 2021, 7:29 AM · Restricted Project

Jan 4 2021

pratlucas added a comment to D93232: [AArch64] Adding ACLE intrinsics for the LS64 extension.

Ping.

Jan 4 2021, 9:24 AM · Restricted Project, Restricted Project

Dec 18 2020

pratlucas committed rG91593e461a24: [AArch64] Updating .arch_extension negative tests (authored by pratlucas).
[AArch64] Updating .arch_extension negative tests
Dec 18 2020, 7:57 AM
pratlucas closed D93538: [AArch64] Updating .arch_extension negative tests.
Dec 18 2020, 7:57 AM · Restricted Project
pratlucas committed rG1a9577bde1dd: [AArch64] Add support for ls64 to the .arch_extension asm directive (authored by pratlucas).
[AArch64] Add support for ls64 to the .arch_extension asm directive
Dec 18 2020, 7:56 AM
pratlucas closed D92574: [AArch64] Add support for ls64 to the .arch_extension asm directive.
Dec 18 2020, 7:56 AM · Restricted Project
pratlucas added inline comments to D92574: [AArch64] Add support for ls64 to the .arch_extension asm directive.
Dec 18 2020, 6:02 AM · Restricted Project
pratlucas added reviewers for D93538: [AArch64] Updating .arch_extension negative tests: olista01, ostannard, dmgreen, vhscampos, simon_tatham.
Dec 18 2020, 6:01 AM · Restricted Project
pratlucas requested review of D93538: [AArch64] Updating .arch_extension negative tests.
Dec 18 2020, 5:54 AM · Restricted Project
pratlucas committed rG51fe17b0471a: [AArch64] Add support for the SPE-EEF feature (authored by pratlucas).
[AArch64] Add support for the SPE-EEF feature
Dec 18 2020, 3:12 AM
pratlucas closed D92391: [AArch64] Add support for the SPE-EEF feature.
Dec 18 2020, 3:12 AM · Restricted Project
pratlucas committed rGda21f7ec146e: [AArch64] Add support for the Branch Record Buffer extension (authored by pratlucas).
[AArch64] Add support for the Branch Record Buffer extension
Dec 18 2020, 3:11 AM
pratlucas closed D92389: [AArch64] Add support for the Branch Record Buffer extension.
Dec 18 2020, 3:11 AM · Restricted Project

Dec 17 2020

pratlucas committed rGc5046ebdf6e4: [ARM] Adding v8.7-A command-line support for the ARM target (authored by pratlucas).
[ARM] Adding v8.7-A command-line support for the ARM target
Dec 17 2020, 5:49 AM
pratlucas closed D93231: [ARM] Adding v8.7-A command-line support for the ARM target.
Dec 17 2020, 5:49 AM · Restricted Project, Restricted Project
pratlucas committed rGc4d851b07903: [ARM][AAarch64] Initial command-line support for v8.7-A (authored by pratlucas).
[ARM][AAarch64] Initial command-line support for v8.7-A
Dec 17 2020, 5:47 AM
pratlucas closed D91776: [ARM][AAarch64] Initial command-line support for v8.7-A.
Dec 17 2020, 5:47 AM · Restricted Project, Restricted Project
pratlucas committed rG313889191ea1: [AArch64] Adding the v8.7-A LD64B/ST64B Accelerator extension (authored by pratlucas).
[AArch64] Adding the v8.7-A LD64B/ST64B Accelerator extension
Dec 17 2020, 5:46 AM
pratlucas closed D91775: [AArch64] Adding the v8.7-A LD64B/ST64B Accelerator extension.
Dec 17 2020, 5:46 AM · Restricted Project
pratlucas committed rG97c006aabb6c: [AArch64] Add a GPR64x8 register class (authored by pratlucas).
[AArch64] Add a GPR64x8 register class
Dec 17 2020, 5:46 AM
pratlucas closed D91774: [AArch64] Add a GPR64x8 register class.
Dec 17 2020, 5:45 AM · Restricted Project
pratlucas committed rG42b92b31b8b8: [ARM][AArch64] Adding basic support for the v8.7-A architecture (authored by pratlucas).
[ARM][AArch64] Adding basic support for the v8.7-A architecture
Dec 17 2020, 5:45 AM
pratlucas closed D91772: [ARM][AArch64] Adding basic support for the v8.7-A architecture.
Dec 17 2020, 5:45 AM · Restricted Project
pratlucas committed rG83ea17fc5f74: [NFC][AArch64] Capturing multiple feature requirements in AsmParser messages (authored by pratlucas).
[NFC][AArch64] Capturing multiple feature requirements in AsmParser messages
Dec 17 2020, 5:44 AM
pratlucas closed D92388: [NFC][AArch64] Capturing multiple feature requirements in AsmParser messages.
Dec 17 2020, 5:44 AM · Restricted Project
pratlucas committed rGb5bbb4b2b753: [NFC][AArch64] Move AArch64 MSR/MRS into a new decoder namespace (authored by pratlucas).
[NFC][AArch64] Move AArch64 MSR/MRS into a new decoder namespace
Dec 17 2020, 5:40 AM
pratlucas closed D91771: [NFC][AArch64] Move AArch64 MSR/MRS into a new decoder namespace.
Dec 17 2020, 5:40 AM · Restricted Project

Dec 14 2020

pratlucas added reviewers for D93232: [AArch64] Adding ACLE intrinsics for the LS64 extension: simon_tatham, vhscampos, olista01, ostannard, dmgreen.
Dec 14 2020, 9:31 AM · Restricted Project, Restricted Project
pratlucas added reviewers for D93231: [ARM] Adding v8.7-A command-line support for the ARM target: momchil.velikov, simon_tatham, vhscampos, olista01, ostannard, dmgreen.
Dec 14 2020, 9:30 AM · Restricted Project, Restricted Project
pratlucas requested review of D93232: [AArch64] Adding ACLE intrinsics for the LS64 extension.
Dec 14 2020, 9:25 AM · Restricted Project, Restricted Project
pratlucas requested review of D93231: [ARM] Adding v8.7-A command-line support for the ARM target.
Dec 14 2020, 9:25 AM · Restricted Project, Restricted Project
pratlucas updated the diff for D92574: [AArch64] Add support for ls64 to the .arch_extension asm directive.

Rebasing.

Dec 14 2020, 9:24 AM · Restricted Project
pratlucas updated the diff for D92391: [AArch64] Add support for the SPE-EEF feature.

Rebasing.

Dec 14 2020, 9:24 AM · Restricted Project
pratlucas updated the diff for D92389: [AArch64] Add support for the Branch Record Buffer extension.

Rebasing.

Dec 14 2020, 9:24 AM · Restricted Project
pratlucas updated the diff for D91776: [ARM][AAarch64] Initial command-line support for v8.7-A.

Rebasing.

Dec 14 2020, 9:24 AM · Restricted Project, Restricted Project
pratlucas updated the diff for D91775: [AArch64] Adding the v8.7-A LD64B/ST64B Accelerator extension.

Rebasing.

Dec 14 2020, 9:23 AM · Restricted Project
pratlucas updated the diff for D91774: [AArch64] Add a GPR64x8 register class.

Rebasing.

Dec 14 2020, 9:23 AM · Restricted Project
pratlucas updated the diff for D91772: [ARM][AArch64] Adding basic support for the v8.7-A architecture.

Rebasing.

Dec 14 2020, 9:23 AM · Restricted Project
pratlucas updated the diff for D92388: [NFC][AArch64] Capturing multiple feature requirements in AsmParser messages.

Rebasing.

Dec 14 2020, 9:22 AM · Restricted Project
pratlucas updated the diff for D91771: [NFC][AArch64] Move AArch64 MSR/MRS into a new decoder namespace.

Rebasing.

Dec 14 2020, 9:19 AM · Restricted Project
pratlucas added a comment to D92389: [AArch64] Add support for the Branch Record Buffer extension.

Ping.

Dec 14 2020, 5:32 AM · Restricted Project
pratlucas added a comment to D92391: [AArch64] Add support for the SPE-EEF feature.

Ping.

Dec 14 2020, 5:32 AM · Restricted Project
pratlucas added a comment to D92574: [AArch64] Add support for ls64 to the .arch_extension asm directive.

Ping.

Dec 14 2020, 5:31 AM · Restricted Project

Dec 9 2020

pratlucas updated the diff for D91772: [ARM][AArch64] Adding basic support for the v8.7-A architecture.

Adding new TLBI operands to xs tests.

Dec 9 2020, 3:44 AM · Restricted Project

Dec 8 2020

pratlucas added a comment to D91772: [ARM][AArch64] Adding basic support for the v8.7-A architecture.

Ping.

Dec 8 2020, 3:20 AM · Restricted Project
pratlucas added a comment to D92388: [NFC][AArch64] Capturing multiple feature requirements in AsmParser messages.

Ping.

Dec 8 2020, 3:20 AM · Restricted Project

Dec 3 2020

pratlucas retitled D92574: [AArch64] Add support for ls64 to the .arch_extension asm directive from [AArch64] Add support for brbe, ls64, spe-eef and wfxt to .arch_extension to [AArch64] Add support for ls64 to the .arch_extension asm directive.
Dec 3 2020, 7:07 AM · Restricted Project
pratlucas updated the diff for D92574: [AArch64] Add support for ls64 to the .arch_extension asm directive.

Reducing scope to 'ls64' extension only.

Dec 3 2020, 7:06 AM · Restricted Project
pratlucas added reviewers for D92574: [AArch64] Add support for ls64 to the .arch_extension asm directive: simon_tatham, vhscampos, olista01, ostannard, dmgreen.
Dec 3 2020, 6:37 AM · Restricted Project
pratlucas requested review of D92574: [AArch64] Add support for ls64 to the .arch_extension asm directive.
Dec 3 2020, 6:36 AM · Restricted Project

Dec 2 2020

pratlucas abandoned D92390: [AArch64] Add support for the Call Stack Recorder extension.
Dec 2 2020, 3:26 AM · Restricted Project

Dec 1 2020

pratlucas added reviewers for D92391: [AArch64] Add support for the SPE-EEF feature: simon_tatham, vhscampos, olista01, ostannard, dmgreen.
Dec 1 2020, 6:39 AM · Restricted Project
pratlucas added reviewers for D92390: [AArch64] Add support for the Call Stack Recorder extension: simon_tatham, vhscampos, olista01, ostannard, dmgreen.
Dec 1 2020, 6:38 AM · Restricted Project
pratlucas added reviewers for D92389: [AArch64] Add support for the Branch Record Buffer extension: simon_tatham, vhscampos, olista01, ostannard, dmgreen.
Dec 1 2020, 6:38 AM · Restricted Project
pratlucas requested review of D92391: [AArch64] Add support for the SPE-EEF feature.
Dec 1 2020, 6:35 AM · Restricted Project
pratlucas requested review of D92390: [AArch64] Add support for the Call Stack Recorder extension.
Dec 1 2020, 6:35 AM · Restricted Project
pratlucas requested review of D92389: [AArch64] Add support for the Branch Record Buffer extension.
Dec 1 2020, 6:34 AM · Restricted Project
pratlucas added reviewers for D92388: [NFC][AArch64] Capturing multiple feature requirements in AsmParser messages: simon_tatham, vhscampos, olista01, ostannard, dmgreen.
Dec 1 2020, 6:32 AM · Restricted Project
pratlucas abandoned D91773: [AArch64] Add SubtargetFeatures for v8.7-A options.

As suggested, the contents of this revision were squashed into D91772.

Dec 1 2020, 6:30 AM · Restricted Project
pratlucas added a comment to D91772: [ARM][AArch64] Adding basic support for the v8.7-A architecture.

As suggested, I've squashed D91773 into this review.
The comments from D91773 were addressed in this latest version.

Dec 1 2020, 6:27 AM · Restricted Project
pratlucas updated the diff for D91772: [ARM][AArch64] Adding basic support for the v8.7-A architecture.

Rebasing and addressing comments.

Dec 1 2020, 6:23 AM · Restricted Project
pratlucas requested review of D92388: [NFC][AArch64] Capturing multiple feature requirements in AsmParser messages.
Dec 1 2020, 6:17 AM · Restricted Project

Nov 19 2020

pratlucas added reviewers for D91776: [ARM][AAarch64] Initial command-line support for v8.7-A: simon_tatham, vhscampos, dmgreen, olista01, ostannard.
Nov 19 2020, 2:14 AM · Restricted Project, Restricted Project
pratlucas added reviewers for D91775: [AArch64] Adding the v8.7-A LD64B/ST64B Accelerator extension: simon_tatham, vhscampos, dmgreen, olista01, ostannard.
Nov 19 2020, 2:13 AM · Restricted Project
pratlucas added reviewers for D91774: [AArch64] Add a GPR64x8 register class: simon_tatham, vhscampos, dmgreen, olista01, ostannard.
Nov 19 2020, 2:13 AM · Restricted Project
pratlucas added reviewers for D91773: [AArch64] Add SubtargetFeatures for v8.7-A options: simon_tatham, vhscampos, dmgreen, olista01, ostannard.
Nov 19 2020, 2:13 AM · Restricted Project
pratlucas added reviewers for D91772: [ARM][AArch64] Adding basic support for the v8.7-A architecture: simon_tatham, vhscampos, dmgreen, olista01, ostannard.
Nov 19 2020, 2:12 AM · Restricted Project
pratlucas added reviewers for D91771: [NFC][AArch64] Move AArch64 MSR/MRS into a new decoder namespace: simon_tatham, vhscampos, dmgreen, olista01, ostannard.
Nov 19 2020, 2:11 AM · Restricted Project
pratlucas requested review of D91776: [ARM][AAarch64] Initial command-line support for v8.7-A.
Nov 19 2020, 2:07 AM · Restricted Project, Restricted Project
pratlucas requested review of D91775: [AArch64] Adding the v8.7-A LD64B/ST64B Accelerator extension.
Nov 19 2020, 2:07 AM · Restricted Project
pratlucas requested review of D91774: [AArch64] Add a GPR64x8 register class.
Nov 19 2020, 2:06 AM · Restricted Project
pratlucas requested review of D91773: [AArch64] Add SubtargetFeatures for v8.7-A options.
Nov 19 2020, 2:06 AM · Restricted Project
pratlucas requested review of D91772: [ARM][AArch64] Adding basic support for the v8.7-A architecture.
Nov 19 2020, 2:06 AM · Restricted Project
pratlucas requested review of D91771: [NFC][AArch64] Move AArch64 MSR/MRS into a new decoder namespace.
Nov 19 2020, 2:05 AM · Restricted Project

Nov 9 2020

pratlucas committed rGc2c2cc136013: [ARM][AArch64] Adding Neoverse V1 CPU support (authored by pratlucas).
[ARM][AArch64] Adding Neoverse V1 CPU support
Nov 9 2020, 5:16 AM
pratlucas closed D90765: [ARM][AArch64] Adding Neoverse V1 CPU support.
Nov 9 2020, 5:15 AM · Restricted Project, Restricted Project
pratlucas updated the diff for D90765: [ARM][AArch64] Adding Neoverse V1 CPU support.

Removing extra includes.

Nov 9 2020, 2:57 AM · Restricted Project, Restricted Project

Nov 6 2020

pratlucas updated the diff for D90765: [ARM][AArch64] Adding Neoverse V1 CPU support.

Updating default extensions in target parser to match tablegen features.

Nov 6 2020, 9:42 AM · Restricted Project, Restricted Project