Page MenuHomePhabricator

pratlucas (Lucas Prates)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 21 2020, 7:29 AM (165 w, 5 d)

Recent Activity

Thu, Mar 2

pratlucas added a comment to D145131: [Arm][AArch64] Setting IsX18ReservedByDefault() to true for Unknown OSes.

I agree with @dmgreen, this doesn't seem to be the right default behaviour according to the ABI. I understand it can be useful for building cross-platform code, but "unknown" also affects other use cases such as bare metal targets.

Thu, Mar 2, 3:38 AM · Restricted Project, Restricted Project

Jan 31 2023

pratlucas added inline comments to D142963: [AArch64] Handle negative architecture features.
Jan 31 2023, 1:53 AM · Restricted Project, Restricted Project

Jan 27 2023

pratlucas committed rG852bb68ddb2b: [NFC][AArch64] Get extension strings directly from ArchInfo in target parser (authored by pratlucas).
[NFC][AArch64] Get extension strings directly from ArchInfo in target parser
Jan 27 2023, 7:17 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas closed D142541: [NFC][AArch64] Get extension strings directly from ArchInfo in target parser.
Jan 27 2023, 7:17 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas committed rG0753cf2caca7: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects (authored by pratlucas).
[NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects
Jan 27 2023, 4:37 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas closed D142540: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects.
Jan 27 2023, 4:37 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas committed rG9ea00fc74c3c: [NFC][AArch64] Use optional returns in target parser instead of 'invalid'… (authored by pratlucas).
[NFC][AArch64] Use optional returns in target parser instead of 'invalid'…
Jan 27 2023, 4:36 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas closed D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects.
Jan 27 2023, 4:36 AM · Restricted Project, Restricted Project, Restricted Project

Jan 26 2023

pratlucas updated the diff for D142540: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects.

Renaming getDefaultExtensions() to getImpliedExtensions().

Jan 26 2023, 9:37 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas added inline comments to D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects.
Jan 26 2023, 6:03 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas accepted D142548: [AArch64] Replace AEK_CRYPTO with relevant features in cpu definitions.
Jan 26 2023, 3:29 AM · Restricted Project, Restricted Project, Restricted Project

Jan 25 2023

pratlucas added a reviewer for D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects: dmgreen.
Jan 25 2023, 7:17 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas added reviewers for D142541: [NFC][AArch64] Get extension strings directly from ArchInfo in target parser: lenary, tmatheson, stuij.
Jan 25 2023, 6:56 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas added reviewers for D142540: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects: lenary, tmatheson, stuij.
Jan 25 2023, 6:56 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas added reviewers for D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects: lenary, tmatheson, stuij.
Jan 25 2023, 6:56 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas requested review of D142541: [NFC][AArch64] Get extension strings directly from ArchInfo in target parser.
Jan 25 2023, 6:53 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas requested review of D142540: [NFC][AArch64] Get default features directly from ArchInfo and CpuInfo objects.
Jan 25 2023, 6:53 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas requested review of D142539: [NFC][AArch64] Use optional returns in target parser instead of 'invalid' objects.
Jan 25 2023, 6:52 AM · Restricted Project, Restricted Project, Restricted Project

Jan 23 2023

pratlucas committed rG5f6813beed85: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver (authored by pratlucas).
[AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver
Jan 23 2023, 8:41 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas closed D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver.
Jan 23 2023, 8:41 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas committed rG8246aceb90c2: [AArch64] Add command line support for v9.4-A's Instrumentation Extension (authored by pratlucas).
[AArch64] Add command line support for v9.4-A's Instrumentation Extension
Jan 23 2023, 8:40 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas closed D141403: [AArch64] Add command line support for v9.4-A's Instrumentation Extension.
Jan 23 2023, 8:40 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas added inline comments to D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver.
Jan 23 2023, 8:10 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas updated the diff for D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver.

Updated to use the same approach as D141518.

Jan 23 2023, 8:01 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas updated the diff for D141403: [AArch64] Add command line support for v9.4-A's Instrumentation Extension.

Rebasing, including minor changes due to recent target parser refactoring.

Jan 23 2023, 8:00 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas committed rG1efea0ae8ed2: [AArch64] Support v8.9-A/v9.4-A in .arch_extension directive (authored by pratlucas).
[AArch64] Support v8.9-A/v9.4-A in .arch_extension directive
Jan 23 2023, 7:03 AM · Restricted Project, Restricted Project
pratlucas closed D141402: [AArch64] Support v8.9-A/v9.4-A in .arch_extension directive.
Jan 23 2023, 7:03 AM · Restricted Project, Restricted Project
pratlucas committed rG8ea4a4b0f47a: [AArch64] Add missing system register for v8.9-A/v9.4-A Permission Indirection… (authored by pratlucas).
[AArch64] Add missing system register for v8.9-A/v9.4-A Permission Indirection…
Jan 23 2023, 7:01 AM · Restricted Project, Restricted Project
pratlucas closed D141400: [AArch64] Add missing system register for v8.9-A/v9.4-A Permission Indirection Extension.
Jan 23 2023, 7:01 AM · Restricted Project, Restricted Project
pratlucas committed rGb94b8f1e77d9: [AArch64] Make CNTPCTSS_EL0 and CNTVCTSS_EL0 system registers read-only (authored by pratlucas).
[AArch64] Make CNTPCTSS_EL0 and CNTVCTSS_EL0 system registers read-only
Jan 23 2023, 3:31 AM · Restricted Project, Restricted Project
pratlucas closed D141398: [AArch64] Make CNTPCTSS_EL0 and CNTVCTSS_EL0 system registers read-only.
Jan 23 2023, 3:31 AM · Restricted Project, Restricted Project

Jan 13 2023

pratlucas accepted D138792: [AArch64] Improve TargetParser API.

LGTM with a tiny nit. Feel free to fix it when landing the changes.

Jan 13 2023, 7:02 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 12 2023

pratlucas added a comment to D141518: [AArch64] Move default extensions from clang Driver to TargetParser.

Sorry, I just noticed my previous comment wasn't clear on what I meant by passing on the target features.
The features are indeed included as part of the IR attributes since D141411, but they are no longer included as -target-feature arguments in calls to cc1 by the clang driver. This is not the case when using -mcpu, for example.
I agree the end result will be the same assuming the information is consistent between the TargetParser and the backend's subtarget features, but I think it would be good to define the what's the clang driver's expected behaviour to avoid any inconsistencies in the future.

Jan 12 2023, 9:33 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas added a comment to D141518: [AArch64] Move default extensions from clang Driver to TargetParser.

It makes sense to move this to the TargetParser and the code looks much better indeed. My only concern is that this changes the driver's behaviour in regards to which target feature flags are passed from clang to the backend.

Jan 12 2023, 8:51 AM · Restricted Project, Restricted Project, Restricted Project

Jan 10 2023

pratlucas added reviewers for D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver: lenary, tmatheson, stuij.
Jan 10 2023, 9:14 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas added reviewers for D141403: [AArch64] Add command line support for v9.4-A's Instrumentation Extension: lenary, tmatheson, stuij, tyb0807.
Jan 10 2023, 9:13 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas added reviewers for D141402: [AArch64] Support v8.9-A/v9.4-A in .arch_extension directive: lenary, tmatheson, stuij, dmgreen.
Jan 10 2023, 9:13 AM · Restricted Project, Restricted Project
pratlucas added reviewers for D141400: [AArch64] Add missing system register for v8.9-A/v9.4-A Permission Indirection Extension: lenary, tmatheson, stuij, tyb0807.
Jan 10 2023, 9:13 AM · Restricted Project, Restricted Project
pratlucas added reviewers for D141398: [AArch64] Make CNTPCTSS_EL0 and CNTVCTSS_EL0 system registers read-only: simon_tatham, dmgreen, lenary.
Jan 10 2023, 9:11 AM · Restricted Project, Restricted Project
pratlucas requested review of D141404: [AArch64][Clang] Adjust default features for v8.9-A/v9.4-A in clang driver.
Jan 10 2023, 9:10 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas requested review of D141403: [AArch64] Add command line support for v9.4-A's Instrumentation Extension.
Jan 10 2023, 9:10 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas requested review of D141402: [AArch64] Support v8.9-A/v9.4-A in .arch_extension directive.
Jan 10 2023, 9:10 AM · Restricted Project, Restricted Project
pratlucas requested review of D141400: [AArch64] Add missing system register for v8.9-A/v9.4-A Permission Indirection Extension.
Jan 10 2023, 9:09 AM · Restricted Project, Restricted Project
pratlucas requested review of D141398: [AArch64] Make CNTPCTSS_EL0 and CNTVCTSS_EL0 system registers read-only.
Jan 10 2023, 9:09 AM · Restricted Project, Restricted Project

Jan 5 2023

pratlucas accepted D140999: [NFC][TargetParser] Remove llvm/Support/AArch64TargetParser.h.

LGTM.

Jan 5 2023, 1:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jan 3 2023

pratlucas committed rG419a21609444: [NFC][AArch64] Adjust comments in tablegen file (authored by pratlucas).
[NFC][AArch64] Adjust comments in tablegen file
Jan 3 2023, 6:46 AM · Restricted Project, Restricted Project

Dec 19 2022

pratlucas committed rGd73cfc6710c2: [AArch64] Add missing v8.8a Non-maskable Interrupts feature (authored by pratlucas).
[AArch64] Add missing v8.8a Non-maskable Interrupts feature
Dec 19 2022, 7:08 AM · Restricted Project, Restricted Project
pratlucas closed D140216: [AArch64] Add missing v8.8a Non-maskable Interrupts feature.
Dec 19 2022, 7:08 AM · Restricted Project, Restricted Project
pratlucas committed rGf516e9171564: [AArch64] Add new v9.4-A PM pstate system register (authored by pratlucas).
[AArch64] Add new v9.4-A PM pstate system register
Dec 19 2022, 7:08 AM · Restricted Project, Restricted Project
pratlucas closed D139925: [AArch64] Add new v9.4-A PM pstate system register.
Dec 19 2022, 7:08 AM · Restricted Project, Restricted Project

Dec 16 2022

pratlucas added reviewers for D140216: [AArch64] Add missing v8.8a Non-maskable Interrupts feature: lenary, tmatheson, dcandler, stuij, peter.smith.
Dec 16 2022, 7:01 AM · Restricted Project, Restricted Project
pratlucas requested review of D140216: [AArch64] Add missing v8.8a Non-maskable Interrupts feature.
Dec 16 2022, 7:00 AM · Restricted Project, Restricted Project
pratlucas accepted D139443: [AArch64] Support SLC in ACLE prefetch intrinsics.

LGTM.

Dec 16 2022, 3:34 AM · Restricted Project, Restricted Project, Restricted Project

Dec 15 2022

pratlucas updated the summary of D139925: [AArch64] Add new v9.4-A PM pstate system register.
Dec 15 2022, 3:35 AM · Restricted Project, Restricted Project
pratlucas accepted D139936: [AArch64] RASv2 Assembly Support.

LGTM.

Dec 15 2022, 3:22 AM · Restricted Project, Restricted Project
pratlucas added inline comments to D139925: [AArch64] Add new v9.4-A PM pstate system register.
Dec 15 2022, 3:20 AM · Restricted Project, Restricted Project

Dec 13 2022

pratlucas added inline comments to D139925: [AArch64] Add new v9.4-A PM pstate system register.
Dec 13 2022, 6:25 AM · Restricted Project, Restricted Project
pratlucas added a comment to D139925: [AArch64] Add new v9.4-A PM pstate system register.

Indeed. I'll add an entry to the release notes to capture that.

Dec 13 2022, 6:18 AM · Restricted Project, Restricted Project
pratlucas added reviewers for D139925: [AArch64] Add new v9.4-A PM pstate system register: lenary, stuij, dmgreen, tmatheson, psmith.
Dec 13 2022, 2:37 AM · Restricted Project, Restricted Project
pratlucas requested review of D139925: [AArch64] Add new v9.4-A PM pstate system register.
Dec 13 2022, 2:32 AM · Restricted Project, Restricted Project

Dec 8 2022

pratlucas committed rG2050e7ebe18c: [Arm][AArch64] Add support for v8.9-A/v9.4-A base extensions (authored by pratlucas).
[Arm][AArch64] Add support for v8.9-A/v9.4-A base extensions
Dec 8 2022, 2:15 AM · Restricted Project, Restricted Project
pratlucas closed D139424: [Arm][AArch64] Add support for v8.9-A/v9.4-A base extensions.
Dec 8 2022, 2:15 AM · Restricted Project, Restricted Project

Dec 6 2022

pratlucas added reviewers for D139424: [Arm][AArch64] Add support for v8.9-A/v9.4-A base extensions: lenary, tmatheson, stuij, dmgreen.
Dec 6 2022, 6:05 AM · Restricted Project, Restricted Project
pratlucas requested review of D139424: [Arm][AArch64] Add support for v8.9-A/v9.4-A base extensions.
Dec 6 2022, 6:04 AM · Restricted Project, Restricted Project

Dec 5 2022

pratlucas accepted D139086: [AArch64] Implement __arm_rsr128/__arm_wsr128.

LGTM

Dec 5 2022, 6:42 AM · Restricted Project, Restricted Project, Restricted Project

Nov 30 2022

pratlucas accepted D138753: [AArch64TargetParser] getArchFeatures -> getArchFeature.

LGTM

Nov 30 2022, 6:26 AM · Restricted Project, Restricted Project, Restricted Project

Nov 28 2022

pratlucas added inline comments to D138753: [AArch64TargetParser] getArchFeatures -> getArchFeature.
Nov 28 2022, 1:15 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas accepted D138754: [AArch64] Remove unused fields from CPUs in TargetParser.

LGTM

Nov 28 2022, 1:10 AM · Restricted Project, Restricted Project

Nov 24 2022

pratlucas committed rGb0d4045dabef: [AArch64] Add support for v8.9-A/v9.4-A Debug and PMU extensions (authored by pratlucas).
[AArch64] Add support for v8.9-A/v9.4-A Debug and PMU extensions
Nov 24 2022, 8:15 AM · Restricted Project, Restricted Project
pratlucas closed D138556: [AArch64] Add support for v8.9-A/v9.4-A Debug and PMU extensions.
Nov 24 2022, 8:15 AM · Restricted Project, Restricted Project

Nov 23 2022

pratlucas updated the summary of D138556: [AArch64] Add support for v8.9-A/v9.4-A Debug and PMU extensions.
Nov 23 2022, 3:33 AM · Restricted Project, Restricted Project
pratlucas added reviewers for D138556: [AArch64] Add support for v8.9-A/v9.4-A Debug and PMU extensions: lenary, tmatheson, stuij, dmgreen.
Nov 23 2022, 2:33 AM · Restricted Project, Restricted Project
pratlucas requested review of D138556: [AArch64] Add support for v8.9-A/v9.4-A Debug and PMU extensions.
Nov 23 2022, 2:31 AM · Restricted Project, Restricted Project
pratlucas accepted D138553: [AArch64] Add Missing System Registers.

LGTM.

Nov 23 2022, 2:07 AM · Restricted Project, Restricted Project

Nov 15 2022

pratlucas added inline comments to D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support.
Nov 15 2022, 7:18 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas added inline comments to D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support.
Nov 15 2022, 6:59 AM · Restricted Project, Restricted Project, Restricted Project
pratlucas added inline comments to D138026: [ARM][AArch64] Use StringRef in TargetParser structs.
Nov 15 2022, 5:30 AM · Restricted Project, Restricted Project
pratlucas accepted D138017: [ARM][AArch64] Move common code into ARMTargetParserCommon.

LGTM.

Nov 15 2022, 2:38 AM · Restricted Project, Restricted Project
pratlucas added inline comments to D138019: [ARM][AArch64] De-template TargetParser types.
Nov 15 2022, 2:34 AM · Restricted Project, Restricted Project
pratlucas added inline comments to D138010: [AArch64][ARM] add Armv8.9-a/Armv9.4-a identifier support.
Nov 15 2022, 1:58 AM · Restricted Project, Restricted Project, Restricted Project

Nov 14 2022

pratlucas accepted D137924: [TargetParser] Split AArch64TargetParser from ARMTargetParser.

LGTM, assuming the unnecessary templates are going to be removed on a follow up patch.

Nov 14 2022, 7:28 AM · Restricted Project, Restricted Project

Oct 18 2022

pratlucas accepted D135680: [clang][ARM] follow GCC behavior for defining __SOFTFP__.

Thanks! LGTM.

Oct 18 2022, 5:35 AM · Restricted Project, Restricted Project

Oct 13 2022

pratlucas added inline comments to D135680: [clang][ARM] follow GCC behavior for defining __SOFTFP__.
Oct 13 2022, 7:21 AM · Restricted Project, Restricted Project

Aug 23 2022

pratlucas committed rGd1922c986242: [AArch64] Fix list of features for Cortex-X1C (authored by pratlucas).
[AArch64] Fix list of features for Cortex-X1C
Aug 23 2022, 3:35 AM · Restricted Project, Restricted Project
pratlucas closed D132120: [AArch64] Fix list of features for Cortex-X1C.
Aug 23 2022, 3:35 AM · Restricted Project, Restricted Project

Aug 22 2022

pratlucas accepted D132214: [ARM] Fix bug in also_compatible_with attribute parser.

LGTM.

Aug 22 2022, 1:35 AM · Restricted Project, Restricted Project

Aug 18 2022

pratlucas added reviewers for D132120: [AArch64] Fix list of features for Cortex-X1C: stuij, vhscampos, dmgreen.
Aug 18 2022, 2:41 AM · Restricted Project, Restricted Project
pratlucas requested review of D132120: [AArch64] Fix list of features for Cortex-X1C.
Aug 18 2022, 2:40 AM · Restricted Project, Restricted Project

Aug 12 2022

pratlucas accepted D130913: [ARM] Parse Tag_also_compatible_with attribute.

LGTM.

Aug 12 2022, 5:40 AM · Restricted Project, Restricted Project
pratlucas accepted D131680: [ARM] Simplify the creation of escaped build attribute values.

LGTM.

Aug 12 2022, 5:33 AM · Restricted Project, Restricted Project

Aug 8 2022

pratlucas added inline comments to D130913: [ARM] Parse Tag_also_compatible_with attribute.
Aug 8 2022, 1:53 AM · Restricted Project, Restricted Project

Aug 1 2022

pratlucas committed rGba9caf91708a: [Arm] Fix parsing and emission of Tag_also_compatible_with eabi attribute (authored by pratlucas).
[Arm] Fix parsing and emission of Tag_also_compatible_with eabi attribute
Aug 1 2022, 5:28 AM · Restricted Project, Restricted Project
pratlucas closed D129500: [Arm] Fix parsing and emission of Tag_also_compatible_with eabi attribute.
Aug 1 2022, 5:28 AM · Restricted Project, Restricted Project

Jul 13 2022

pratlucas accepted D129631: [ARM] Add Tag_CPU_arch missing value descriptions in attribute parser.

LGTM.

Jul 13 2022, 6:31 AM · Restricted Project, Restricted Project
pratlucas added a comment to D129631: [ARM] Add Tag_CPU_arch missing value descriptions in attribute parser.

It'd be good to have a test covering the new values. Can you add one, please?

Jul 13 2022, 3:59 AM · Restricted Project, Restricted Project

Jul 12 2022

pratlucas added a comment to D129500: [Arm] Fix parsing and emission of Tag_also_compatible_with eabi attribute.

Updated commit message to fix typos.

Jul 12 2022, 2:28 AM · Restricted Project, Restricted Project
pratlucas updated the summary of D129500: [Arm] Fix parsing and emission of Tag_also_compatible_with eabi attribute.
Jul 12 2022, 2:26 AM · Restricted Project, Restricted Project

Jul 11 2022

pratlucas updated the summary of D129500: [Arm] Fix parsing and emission of Tag_also_compatible_with eabi attribute.
Jul 11 2022, 10:03 AM · Restricted Project, Restricted Project
pratlucas updated the diff for D129500: [Arm] Fix parsing and emission of Tag_also_compatible_with eabi attribute.

Minor update to include order.

Jul 11 2022, 9:52 AM · Restricted Project, Restricted Project
pratlucas requested review of D129500: [Arm] Fix parsing and emission of Tag_also_compatible_with eabi attribute.
Jul 11 2022, 9:50 AM · Restricted Project, Restricted Project