User Details
- User Since
- Jan 21 2020, 7:29 AM (165 w, 5 d)
Thu, Mar 2
I agree with @dmgreen, this doesn't seem to be the right default behaviour according to the ABI. I understand it can be useful for building cross-platform code, but "unknown" also affects other use cases such as bare metal targets.
Jan 31 2023
Jan 27 2023
Jan 26 2023
Renaming getDefaultExtensions() to getImpliedExtensions().
Jan 25 2023
Jan 23 2023
Updated to use the same approach as D141518.
Rebasing, including minor changes due to recent target parser refactoring.
Jan 13 2023
LGTM with a tiny nit. Feel free to fix it when landing the changes.
Jan 12 2023
Sorry, I just noticed my previous comment wasn't clear on what I meant by passing on the target features.
The features are indeed included as part of the IR attributes since D141411, but they are no longer included as -target-feature arguments in calls to cc1 by the clang driver. This is not the case when using -mcpu, for example.
I agree the end result will be the same assuming the information is consistent between the TargetParser and the backend's subtarget features, but I think it would be good to define the what's the clang driver's expected behaviour to avoid any inconsistencies in the future.
It makes sense to move this to the TargetParser and the code looks much better indeed. My only concern is that this changes the driver's behaviour in regards to which target feature flags are passed from clang to the backend.
Jan 10 2023
Jan 5 2023
LGTM.
Jan 3 2023
Dec 19 2022
Dec 16 2022
LGTM.
Dec 15 2022
LGTM.
Dec 13 2022
Indeed. I'll add an entry to the release notes to capture that.
Dec 8 2022
Dec 6 2022
Dec 5 2022
LGTM
Nov 30 2022
LGTM
Nov 28 2022
LGTM
Nov 24 2022
Nov 23 2022
LGTM.
Nov 15 2022
LGTM.
Nov 14 2022
LGTM, assuming the unnecessary templates are going to be removed on a follow up patch.
Oct 18 2022
Thanks! LGTM.
Oct 13 2022
Aug 23 2022
Aug 22 2022
LGTM.
Aug 18 2022
Aug 12 2022
LGTM.
LGTM.
Aug 8 2022
Aug 1 2022
Jul 13 2022
LGTM.
It'd be good to have a test covering the new values. Can you add one, please?
Jul 12 2022
Updated commit message to fix typos.
Jul 11 2022
Minor update to include order.