This builds on D90868 to introduce the straightforward isel patterns for sign/sign_generic.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
| Time | Test | |
|---|---|---|
| 380 ms | linux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp Script:
--
: 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -mcmodel=large -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/hwasan/TestCases/sizes.cpp -nostdlib++ -lstdc++ -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp
| |
| 250 ms | linux > LLVM.CodeGen/AArch64::ptrauth-intrinsics.ll Script:
--
: 'RUN: at line 2'; /mnt/disks/ssd0/agent/llvm-project/build/bin/llc < /mnt/disks/ssd0/agent/llvm-project/llvm/test/CodeGen/AArch64/ptrauth-intrinsics.ll -mtriple arm64e-apple-darwin -verify-machineinstrs | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/llvm/test/CodeGen/AArch64/ptrauth-intrinsics.ll --check-prefixes=ALL
| |
| 240 ms | linux > LLVM.CodeGen/AArch64/GlobalISel::ptrauth-intrinsics.ll Script:
--
: 'RUN: at line 2'; /mnt/disks/ssd0/agent/llvm-project/build/bin/llc < /mnt/disks/ssd0/agent/llvm-project/llvm/test/CodeGen/AArch64/GlobalISel/ptrauth-intrinsics.ll -mtriple arm64e-apple-darwin -global-isel -global-isel-abort=1 | /mnt/disks/ssd0/agent/llvm-project/build/bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/llvm/test/CodeGen/AArch64/GlobalISel/ptrauth-intrinsics.ll --check-prefixes=ALL
| |
| 140 ms | windows > LLVM.CodeGen/AArch64::ptrauth-intrinsics.ll Script:
--
: 'RUN: at line 2'; c:\ws\w16c2-1\llvm-project\premerge-checks\build\bin\llc.exe < C:\ws\w16c2-1\llvm-project\premerge-checks\llvm\test\CodeGen\AArch64\ptrauth-intrinsics.ll -mtriple arm64e-apple-darwin -verify-machineinstrs | c:\ws\w16c2-1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w16c2-1\llvm-project\premerge-checks\llvm\test\CodeGen\AArch64\ptrauth-intrinsics.ll --check-prefixes=ALL
| |
| 160 ms | windows > LLVM.CodeGen/AArch64/GlobalISel::ptrauth-intrinsics.ll Script:
--
: 'RUN: at line 2'; c:\ws\w16c2-1\llvm-project\premerge-checks\build\bin\llc.exe < C:\ws\w16c2-1\llvm-project\premerge-checks\llvm\test\CodeGen\AArch64\GlobalISel\ptrauth-intrinsics.ll -mtriple arm64e-apple-darwin -global-isel -global-isel-abort=1 | c:\ws\w16c2-1\llvm-project\premerge-checks\build\bin\filecheck.exe C:\ws\w16c2-1\llvm-project\premerge-checks\llvm\test\CodeGen\AArch64\GlobalISel\ptrauth-intrinsics.ll --check-prefixes=ALL
| |
| View Full Test Results (6 Failed) |
Event Timeline
| llvm/test/CodeGen/AArch64/ptrauth-intrinsics.ll | ||
|---|---|---|
| 2 | I'd prefer adding one more RUN line instead of duplicating the file. | |
Comment Actions
Rebased, split tests by intrinsic rather than by GISel vs SDAG (since GISel is now always built and we don't need the separate test directory)
Comment Actions
I wonder if we could have these tests be generic for aarch64 target.
These intrinsics implementation don't have anything dependent on Apple ABI.
Comment Actions
That ship has sailed I think ;) A large chunk of tests use different targets depending on who wrote them, and I guess that's okay precisely because the target differences aren't relevant to the tests.
That's a lot less true for the logic around lowering global references and constants and whatnot, I'm sure that looks quite different for non-darwin (and maybe that'll be enough to justify splitting the test file altogether, the ones I have for those features cover a lot of darwin-specific subtleties that aren't relevant elsewhere)
Comment Actions
LGTM, any triplet could work here, where it matters we can add a new RUN line with an other triplet.