Page MenuHomePhabricator
People chill

chill (Momchil Velikov)
User

Projects

User does not belong to any projects.

User Details

User Since
May 24 2017, 3:29 AM (305 w, 3 d)

Recent Activity
View All

Thu, Mar 30

chill committed rG99e57f06c4df: [CodeGenPrepare] Increase the limit on the number of instructions to scan (authored by chill).
[CodeGenPrepare] Increase the limit on the number of instructions to scan
Thu, Mar 30, 6:39 AM · Restricted Project, Restricted Project
chill closed D143894: [CodeGenPrepare] Increase the limit on the number of instructions to scan.
Thu, Mar 30, 6:38 AM · Restricted Project, Restricted Project
chill committed rG2453da0a4e60: [CodeGenPrepare] Fix counting uses when folding addresses into memory… (authored by chill).
[CodeGenPrepare] Fix counting uses when folding addresses into memory…
Thu, Mar 30, 6:19 AM · Restricted Project, Restricted Project
chill closed D143893: [CodeGenPrepare] Fix counting uses when folding addresses into memory instructions.
Thu, Mar 30, 6:18 AM · Restricted Project, Restricted Project

Wed, Mar 29

chill updated the diff for D143897: [CodeGenPrepare] Estimate liveness of loop invariants when checking for address folding profitability.

Chages: make the limit on loop invariant users to scan a parameter

Wed, Mar 29, 9:32 AM · Restricted Project, Restricted Project
chill updated the diff for D143895: [AArch64] Fix incorrect `isLegalAddressingMode`.

+ canonicalise 2*Reg into Reg + Reg

Wed, Mar 29, 7:44 AM · Restricted Project, Restricted Project
chill updated the diff for D143894: [CodeGenPrepare] Increase the limit on the number of instructions to scan.
Wed, Mar 29, 6:03 AM · Restricted Project, Restricted Project
chill added a comment to D145707: [LiveInterval] Fix live range overlap check.
In D145707#4182348, @MatzeB wrote:

Could you add a test to unittests/MI/LiveIntervalTest.cpp?

Done.

Wed, Mar 29, 2:11 AM · Restricted Project, Restricted Project
chill updated the diff for D145707: [LiveInterval] Fix live range overlap check.
Wed, Mar 29, 2:11 AM · Restricted Project, Restricted Project

Mon, Mar 27

chill added a comment to D143897: [CodeGenPrepare] Estimate liveness of loop invariants when checking for address folding profitability.

Ping?

Mon, Mar 27, 2:41 AM · Restricted Project, Restricted Project
chill added a comment to D143896: [NFC][CodeGenPrepare] Match against the correct instruction when checking profitability of folding an address.

PIng?

Mon, Mar 27, 2:40 AM · Restricted Project, Restricted Project
chill added a reviewer for D143894: [CodeGenPrepare] Increase the limit on the number of instructions to scan: mkazantsev.
Mon, Mar 27, 2:39 AM · Restricted Project, Restricted Project
chill added a reviewer for D143893: [CodeGenPrepare] Fix counting uses when folding addresses into memory instructions: mkazantsev.
Mon, Mar 27, 2:39 AM · Restricted Project, Restricted Project
chill updated the diff for D145706: [MachineSink] Sink instruction copies when they can replace copy into hard register.

Update: don't sink instructions with non-register operands which could affect register pressure.

Mon, Mar 27, 2:33 AM · Restricted Project, Restricted Project
chill updated the diff for D143895: [AArch64] Fix incorrect `isLegalAddressingMode`.

Fixed a few places in LSR where we called isLegalAddressingMode without a base register, even
though we meant an addressing mode with a base register.

Mon, Mar 27, 2:16 AM · Restricted Project, Restricted Project

Thu, Mar 23

chill committed rG5c9a26238a19: [CodeGenPrepare][NFC] Pre-commit test for memory use count fix (authored by chill).
[CodeGenPrepare][NFC] Pre-commit test for memory use count fix
Thu, Mar 23, 10:56 AM · Restricted Project, Restricted Project
chill closed D145705: [CodeGenPrepare][NFC] Pre-commit test for memory use count fix.
Thu, Mar 23, 10:55 AM · Restricted Project, Restricted Project
chill committed rG6a2a5f08de0a: [CodeGenPrepare] Don't give up if unable to sink first arg to a cold call (authored by chill).
[CodeGenPrepare] Don't give up if unable to sink first arg to a cold call
Thu, Mar 23, 10:37 AM · Restricted Project, Restricted Project
chill closed D143892: [CodeGenPrepare] Don't give up if unable to sink first arg to a cold call.
Thu, Mar 23, 10:36 AM · Restricted Project, Restricted Project

Fri, Mar 17

chill added inline comments to D145379: [FuncSpec] Cost model improvements..
Fri, Mar 17, 8:09 AM · Restricted Project, Restricted Project

Fri, Mar 10

chill added reviewers for D145706: [MachineSink] Sink instruction copies when they can replace copy into hard register: fhahn, efriedma, t.p.northover.
Fri, Mar 10, 8:26 AM · Restricted Project, Restricted Project
chill retitled D143898: [CodeGenPrepare] Relax conditions for folding addressing mode into loads/stores from [CodeGenPrepare] Fold addressing mode into calls to [CodeGenPrepare] Relax conditions for folding addressing mode into loads/stores.
Fri, Mar 10, 8:25 AM · Restricted Project, Restricted Project
chill updated the summary of D145706: [MachineSink] Sink instruction copies when they can replace copy into hard register.
Fri, Mar 10, 8:22 AM · Restricted Project, Restricted Project
chill updated the diff for D143892: [CodeGenPrepare] Don't give up if unable to sink first arg to a cold call.
Fri, Mar 10, 3:25 AM · Restricted Project, Restricted Project

Thu, Mar 9

chill updated the summary of D143898: [CodeGenPrepare] Relax conditions for folding addressing mode into loads/stores.
Thu, Mar 9, 10:49 AM · Restricted Project, Restricted Project
chill requested review of D145707: [LiveInterval] Fix live range overlap check.
Thu, Mar 9, 10:38 AM · Restricted Project, Restricted Project
chill requested review of D145706: [MachineSink] Sink instruction copies when they can replace copy into hard register.
Thu, Mar 9, 10:36 AM · Restricted Project, Restricted Project
chill updated the diff for D143898: [CodeGenPrepare] Relax conditions for folding addressing mode into loads/stores.
Thu, Mar 9, 10:35 AM · Restricted Project, Restricted Project
chill updated the diff for D143897: [CodeGenPrepare] Estimate liveness of loop invariants when checking for address folding profitability.
Thu, Mar 9, 10:35 AM · Restricted Project, Restricted Project
chill updated the diff for D143896: [NFC][CodeGenPrepare] Match against the correct instruction when checking profitability of folding an address.
Thu, Mar 9, 10:34 AM · Restricted Project, Restricted Project
chill updated the diff for D143895: [AArch64] Fix incorrect `isLegalAddressingMode`.
Thu, Mar 9, 10:30 AM · Restricted Project, Restricted Project
chill updated the diff for D143894: [CodeGenPrepare] Increase the limit on the number of instructions to scan.
Thu, Mar 9, 10:29 AM · Restricted Project, Restricted Project
chill updated the diff for D143893: [CodeGenPrepare] Fix counting uses when folding addresses into memory instructions.
Thu, Mar 9, 10:28 AM · Restricted Project, Restricted Project
chill added a reviewer for D145705: [CodeGenPrepare][NFC] Pre-commit test for memory use count fix: mkazantsev.
Thu, Mar 9, 10:27 AM · Restricted Project, Restricted Project
chill requested review of D145705: [CodeGenPrepare][NFC] Pre-commit test for memory use count fix.
Thu, Mar 9, 10:26 AM · Restricted Project, Restricted Project
chill added inline comments to D143892: [CodeGenPrepare] Don't give up if unable to sink first arg to a cold call.
Thu, Mar 9, 10:24 AM · Restricted Project, Restricted Project
chill updated the diff for D143892: [CodeGenPrepare] Don't give up if unable to sink first arg to a cold call.
Thu, Mar 9, 10:23 AM · Restricted Project, Restricted Project

Feb 27 2023

chill added inline comments to D144838: [SCCP] Correct the made changes behavior.
Feb 27 2023, 2:18 AM · Restricted Project, Restricted Project

Feb 14 2023

chill added a comment to D143898: [CodeGenPrepare] Relax conditions for folding addressing mode into loads/stores.
In D143898#4123601, @efriedma wrote:

If I'm understanding correctly, the point is that we don't want to block sinking if an address computation has multiple uses, where only some are foldable?

Yes, for when we cannot say we aren't extending live ranges of the address "registers".

Feb 14 2023, 4:16 AM · Restricted Project, Restricted Project

Feb 13 2023

chill updated the summary of D143898: [CodeGenPrepare] Relax conditions for folding addressing mode into loads/stores.
Feb 13 2023, 8:38 AM · Restricted Project, Restricted Project
chill added reviewers for D143898: [CodeGenPrepare] Relax conditions for folding addressing mode into loads/stores: fhahn, t.p.northover, efriedma.
Feb 13 2023, 8:37 AM · Restricted Project, Restricted Project
chill added reviewers for D143897: [CodeGenPrepare] Estimate liveness of loop invariants when checking for address folding profitability: fhahn, efriedma.
Feb 13 2023, 8:37 AM · Restricted Project, Restricted Project
chill added reviewers for D143896: [NFC][CodeGenPrepare] Match against the correct instruction when checking profitability of folding an address: mkazantsev, reames.
Feb 13 2023, 8:36 AM · Restricted Project, Restricted Project
chill added reviewers for D143895: [AArch64] Fix incorrect `isLegalAddressingMode`: t.p.northover, fhahn.
Feb 13 2023, 8:36 AM · Restricted Project, Restricted Project
chill added a reviewer for D143894: [CodeGenPrepare] Increase the limit on the number of instructions to scan: bkramer.
Feb 13 2023, 8:35 AM · Restricted Project, Restricted Project
chill added a reviewer for D143893: [CodeGenPrepare] Fix counting uses when folding addresses into memory instructions: bkramer.
Feb 13 2023, 8:35 AM · Restricted Project, Restricted Project
chill added reviewers for D143892: [CodeGenPrepare] Don't give up if unable to sink first arg to a cold call: reames, mkazantsev.
Feb 13 2023, 8:34 AM · Restricted Project, Restricted Project
chill updated the summary of D143898: [CodeGenPrepare] Relax conditions for folding addressing mode into loads/stores.
Feb 13 2023, 7:54 AM · Restricted Project, Restricted Project
chill updated the summary of D143898: [CodeGenPrepare] Relax conditions for folding addressing mode into loads/stores.
Feb 13 2023, 7:14 AM · Restricted Project, Restricted Project
chill retitled D143897: [CodeGenPrepare] Estimate liveness of loop invariants when checking for address folding profitability from [CodeGenPrepare] Loop invariant liveness to [CodeGenPrepare] Estimate liveness of loop invariants when checking for address folding profitability.
Feb 13 2023, 6:52 AM · Restricted Project, Restricted Project
chill updated the summary of D143896: [NFC][CodeGenPrepare] Match against the correct instruction when checking profitability of folding an address.
Feb 13 2023, 6:44 AM · Restricted Project, Restricted Project
chill updated the summary of D143895: [AArch64] Fix incorrect `isLegalAddressingMode`.
Feb 13 2023, 6:37 AM · Restricted Project, Restricted Project
chill updated the summary of D143894: [CodeGenPrepare] Increase the limit on the number of instructions to scan.
Feb 13 2023, 6:31 AM · Restricted Project, Restricted Project
chill updated the summary of D143893: [CodeGenPrepare] Fix counting uses when folding addresses into memory instructions.
Feb 13 2023, 6:24 AM · Restricted Project, Restricted Project
chill requested review of D143898: [CodeGenPrepare] Relax conditions for folding addressing mode into loads/stores.
Feb 13 2023, 2:50 AM · Restricted Project, Restricted Project
chill requested review of D143897: [CodeGenPrepare] Estimate liveness of loop invariants when checking for address folding profitability.
Feb 13 2023, 2:50 AM · Restricted Project, Restricted Project
chill requested review of D143896: [NFC][CodeGenPrepare] Match against the correct instruction when checking profitability of folding an address.
Feb 13 2023, 2:49 AM · Restricted Project, Restricted Project
chill requested review of D143895: [AArch64] Fix incorrect `isLegalAddressingMode`.
Feb 13 2023, 2:48 AM · Restricted Project, Restricted Project
chill requested review of D143894: [CodeGenPrepare] Increase the limit on the number of instructions to scan.
Feb 13 2023, 2:47 AM · Restricted Project, Restricted Project
chill requested review of D143893: [CodeGenPrepare] Fix counting uses when folding addresses into memory instructions.
Feb 13 2023, 2:46 AM · Restricted Project, Restricted Project
chill requested review of D143892: [CodeGenPrepare] Don't give up if unable to sink first arg to a cold call.
Feb 13 2023, 2:45 AM · Restricted Project, Restricted Project

Jan 3 2023

chill added a comment to D96004: [AArch64] Stack probing for function prologues.
In D96004#3992651, @efriedma wrote:

What's the status of this patch? Were the review comments addressed, or is this still waiting for someone to address them?

Jan 3 2023, 2:52 AM · Restricted Project, Restricted Project

Dec 23 2022

chill accepted D140564: [IPSCCP] Create a Pass parameter to control specialization of functions..
Dec 23 2022, 6:58 AM · Restricted Project, Restricted Project
chill added inline comments to D140564: [IPSCCP] Create a Pass parameter to control specialization of functions..
Dec 23 2022, 3:42 AM · Restricted Project, Restricted Project
chill added inline comments to D140564: [IPSCCP] Create a Pass parameter to control specialization of functions..
Dec 23 2022, 2:45 AM · Restricted Project, Restricted Project

Dec 14 2022

chill committed rGe6b9fc4c8be0: [FuncSpec] Global ranking of specialisations (authored by chill).
[FuncSpec] Global ranking of specialisations
Dec 14 2022, 7:35 AM · Restricted Project, Restricted Project
chill closed D139346: [FuncSpec] Global ranking of specialisations.
Dec 14 2022, 7:35 AM · Restricted Project, Restricted Project
chill updated the diff for D139346: [FuncSpec] Global ranking of specialisations.
Dec 14 2022, 4:00 AM · Restricted Project, Restricted Project
chill added inline comments to D139346: [FuncSpec] Global ranking of specialisations.
Dec 14 2022, 3:45 AM · Restricted Project, Restricted Project

Dec 9 2022

chill accepted D138654: [IPSCCP] Move the IPSCCP run function under the IPO directory..
Dec 9 2022, 6:24 AM · Restricted Project, Restricted Project
chill accepted D139622: [AArch64][NFC] Move hasFeature fields initiations to the declaration.
Dec 9 2022, 3:55 AM · Restricted Project, Restricted Project
chill added inline comments to D139622: [AArch64][NFC] Move hasFeature fields initiations to the declaration.
Dec 9 2022, 2:36 AM · Restricted Project, Restricted Project

Dec 8 2022

chill added inline comments to D139622: [AArch64][NFC] Move hasFeature fields initiations to the declaration.
Dec 8 2022, 6:15 AM · Restricted Project, Restricted Project
chill added a comment to D139346: [FuncSpec] Global ranking of specialisations.

Latest update:

  • fixed the bug in calculating the specialisation budget
  • let the compiler choose the size of some SmallVectors
  • moved a few debug prints around
Dec 8 2022, 4:26 AM · Restricted Project, Restricted Project
chill added a comment to D139346: [FuncSpec] Global ranking of specialisations.
In D139346#3980918, @labrinea wrote:

All 12 specializations are coming from get_mem_mv, but only MaxClonesThreshold ought to be kept.

Dec 8 2022, 4:14 AM · Restricted Project, Restricted Project
chill updated the diff for D139346: [FuncSpec] Global ranking of specialisations.
Dec 8 2022, 4:05 AM · Restricted Project, Restricted Project

Dec 6 2022

chill accepted D139445: [AArch64] Add __ARM_FEATURE_BTI and __ARM_FEATURE_PAUTH.
Dec 6 2022, 11:26 AM · Restricted Project, Restricted Project
chill updated the summary of D139346: [FuncSpec] Global ranking of specialisations.
Dec 6 2022, 4:57 AM · Restricted Project, Restricted Project

Dec 5 2022

chill added reviewers for D139346: [FuncSpec] Global ranking of specialisations: ChuanqiXu, SjoerdMeijer, labrinea, fhahn.
Dec 5 2022, 10:17 AM · Restricted Project, Restricted Project
chill requested review of D139346: [FuncSpec] Global ranking of specialisations.
Dec 5 2022, 10:14 AM · Restricted Project, Restricted Project
chill accepted D126455: [FuncSpec] Make the Function Specializer part of the IPSCCP pass..
Dec 5 2022, 1:30 AM · Restricted Project, Restricted Project

Nov 30 2022

chill committed rGe7ed43c7530d: [FuncSpec] Invalidate analyses when deleting a fully specialised function (authored by chill).
[FuncSpec] Invalidate analyses when deleting a fully specialised function
Nov 30 2022, 10:58 AM · Restricted Project, Restricted Project
chill closed D138909: FuncSpec] Invalidate analyses when deleting a fully specialised function.
Nov 30 2022, 10:58 AM · Restricted Project, Restricted Project

Nov 29 2022

chill added a comment to D126455: [FuncSpec] Make the Function Specializer part of the IPSCCP pass..

LGTM, but let's give a chance for other people to have a look too. @sinan @fhahn

Nov 29 2022, 8:20 AM · Restricted Project, Restricted Project
chill added a comment to D138909: FuncSpec] Invalidate analyses when deleting a fully specialised function.

Ideally, now that we have the FAM in FunctionSpecializer I would like to also remove the callbacks (GetTLI, GetTTi, etc) and also remove the Legacy pass manager support entirely
from SCCP/IPSCCP/FuncSpec. Unfortunately, those callbacks are needed by getInlineCost and a few other functions down the call chain.

Nov 29 2022, 4:23 AM · Restricted Project, Restricted Project
chill added reviewers for D138909: FuncSpec] Invalidate analyses when deleting a fully specialised function: ChuanqiXu, SjoerdMeijer, labrinea.
Nov 29 2022, 4:19 AM · Restricted Project, Restricted Project
chill updated the summary of D138909: FuncSpec] Invalidate analyses when deleting a fully specialised function.
Nov 29 2022, 4:17 AM · Restricted Project, Restricted Project
chill requested review of D138909: FuncSpec] Invalidate analyses when deleting a fully specialised function.
Nov 29 2022, 4:16 AM · Restricted Project, Restricted Project

Nov 28 2022

chill accepted D138654: [IPSCCP] Move the IPSCCP run function under the IPO directory..
Nov 28 2022, 2:24 AM · Restricted Project, Restricted Project

Nov 18 2022

chill added inline comments to D135463: [FuncSpec] Do not generate multiple copies for identical specializations..
Nov 18 2022, 8:45 AM · Restricted Project, Restricted Project
chill added a comment to D126455: [FuncSpec] Make the Function Specializer part of the IPSCCP pass..

Would you, please, mark as done the no longer relevant comments?
I think the only issue left is with the circular dependency between libraries.

Nov 18 2022, 4:21 AM · Restricted Project, Restricted Project

Nov 17 2022

chill added reviewers for D135463: [FuncSpec] Do not generate multiple copies for identical specializations.: SjoerdMeijer, ChuanqiXu.
Nov 17 2022, 6:23 AM · Restricted Project, Restricted Project
chill added inline comments to D135463: [FuncSpec] Do not generate multiple copies for identical specializations..
Nov 17 2022, 1:56 AM · Restricted Project, Restricted Project

Nov 10 2022

chill added inline comments to D126455: [FuncSpec] Make the Function Specializer part of the IPSCCP pass..
Nov 10 2022, 2:26 AM · Restricted Project, Restricted Project
chill added inline comments to D126455: [FuncSpec] Make the Function Specializer part of the IPSCCP pass..
Nov 10 2022, 2:13 AM · Restricted Project, Restricted Project

Nov 9 2022

chill added inline comments to D126455: [FuncSpec] Make the Function Specializer part of the IPSCCP pass..
Nov 9 2022, 4:24 AM · Restricted Project, Restricted Project
chill added inline comments to D126455: [FuncSpec] Make the Function Specializer part of the IPSCCP pass..
Nov 9 2022, 3:49 AM · Restricted Project, Restricted Project
chill added inline comments to D126455: [FuncSpec] Make the Function Specializer part of the IPSCCP pass..
Nov 9 2022, 2:23 AM · Restricted Project, Restricted Project

Nov 8 2022

chill added inline comments to D126455: [FuncSpec] Make the Function Specializer part of the IPSCCP pass..
Nov 8 2022, 8:30 AM · Restricted Project, Restricted Project
chill added inline comments to D126455: [FuncSpec] Make the Function Specializer part of the IPSCCP pass..
Nov 8 2022, 8:02 AM · Restricted Project, Restricted Project