Page MenuHomePhabricator

chill (Momchil Velikov)
User

Projects

User does not belong to any projects.

User Details

User Since
May 24 2017, 3:29 AM (117 w, 3 d)

Recent Activity

Yesterday

chill added a comment to D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type.
In D36562#1641930, @wmi wrote:

Shouldn't we disable OPT_ffine_grained_bitfield_accesses only if TSAN is active?

I don't remember why it is disabled for all sanitizer modes. Seems you are right that the disabling the option is only necessary for TSAN. Do you have actual needs for the option to be functioning on other sanitizer modes?

Fri, Aug 23, 2:07 AM · Restricted Project

Wed, Aug 21

Herald added a project to D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type: Restricted Project.

Shouldn't we disable OPT_ffine_grained_bitfield_accesses only if TSAN is active?

Wed, Aug 21, 8:20 AM · Restricted Project
chill added reviewers for D66459: Make ShrinkWrap more consistent.: qcolombet, thegameg.
Wed, Aug 21, 12:30 AM · Restricted Project

Tue, Aug 20

chill requested changes to D66459: Make ShrinkWrap more consistent..

Could you, please, give some code examples of the issues that you see?

Tue, Aug 20, 2:45 AM · Restricted Project

Tue, Aug 13

chill committed rG114c37e72a5f: [ARM] Fix detection of duplicates when parsing reg list operands (authored by chill).
[ARM] Fix detection of duplicates when parsing reg list operands
Tue, Aug 13, 9:13 AM
chill committed rGf990e4a4c7bc: [ARM] Fix encoding of APSR in CLRM instruction (authored by chill).
[ARM] Fix encoding of APSR in CLRM instruction
Tue, Aug 13, 9:13 AM
chill committed rL368712: [ARM] Fix detection of duplicates when parsing reg list operands.
[ARM] Fix detection of duplicates when parsing reg list operands
Tue, Aug 13, 9:12 AM
chill committed rL368711: [ARM] Fix encoding of APSR in CLRM instruction.
[ARM] Fix encoding of APSR in CLRM instruction
Tue, Aug 13, 9:12 AM
chill closed D65957: [ARM] Fix detection of duplicates when parsing reg list operands.
Tue, Aug 13, 9:12 AM · Restricted Project
chill closed D65873: [ARM] Fix encoding of APSR in CLRM instruction.
Tue, Aug 13, 9:12 AM · Restricted Project
chill committed rG941660299ac6: Enable memtag sanitizer in all AArch64 toolchains (authored by chill).
Enable memtag sanitizer in all AArch64 toolchains
Tue, Aug 13, 7:20 AM
chill committed rG5b25674b7307: [AArch64] Make the memtag sanitizer require the memtag extension (authored by chill).
[AArch64] Make the memtag sanitizer require the memtag extension
Tue, Aug 13, 7:20 AM
chill committed rL368697: Enable memtag sanitizer in all AArch64 toolchains.
Enable memtag sanitizer in all AArch64 toolchains
Tue, Aug 13, 7:20 AM
chill closed D65642: Enable memtag sanitizer in all AArch64 toolchains .
Tue, Aug 13, 7:20 AM · Restricted Project
chill committed rL368696: [AArch64] Make the memtag sanitizer require the memtag extension.
[AArch64] Make the memtag sanitizer require the memtag extension
Tue, Aug 13, 7:20 AM
chill closed D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Tue, Aug 13, 7:20 AM · Restricted Project

Fri, Aug 9

chill added inline comments to D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Fri, Aug 9, 9:22 AM · Restricted Project
chill updated the diff for D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Fri, Aug 9, 9:22 AM · Restricted Project

Thu, Aug 8

chill updated the diff for D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Thu, Aug 8, 10:39 AM · Restricted Project
chill added a parent revision for D65957: [ARM] Fix detection of duplicates when parsing reg list operands: D65873: [ARM] Fix encoding of APSR in CLRM instruction.
Thu, Aug 8, 9:09 AM · Restricted Project
chill added a reviewer for D65873: [ARM] Fix encoding of APSR in CLRM instruction: ostannard.
Thu, Aug 8, 9:09 AM · Restricted Project
chill created D65957: [ARM] Fix detection of duplicates when parsing reg list operands.
Thu, Aug 8, 9:09 AM · Restricted Project
chill added a child revision for D65873: [ARM] Fix encoding of APSR in CLRM instruction: D65957: [ARM] Fix detection of duplicates when parsing reg list operands.
Thu, Aug 8, 9:09 AM · Restricted Project

Wed, Aug 7

chill added a reviewer for D65873: [ARM] Fix encoding of APSR in CLRM instruction: simon_tatham.
Wed, Aug 7, 7:44 AM · Restricted Project
chill updated the summary of D65873: [ARM] Fix encoding of APSR in CLRM instruction.
Wed, Aug 7, 7:43 AM · Restricted Project
chill created D65873: [ARM] Fix encoding of APSR in CLRM instruction.
Wed, Aug 7, 7:43 AM · Restricted Project
chill added inline comments to D62667: [ARM] Add the non-MVE instructions in Arm v8.1-M..
Wed, Aug 7, 3:58 AM · Restricted Project

Tue, Aug 6

chill updated the diff for D65642: Enable memtag sanitizer in all AArch64 toolchains .
Tue, Aug 6, 9:05 AM · Restricted Project
chill added inline comments to D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Tue, Aug 6, 7:02 AM · Restricted Project
chill added inline comments to D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Tue, Aug 6, 7:00 AM · Restricted Project
chill updated the diff for D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Tue, Aug 6, 7:00 AM · Restricted Project

Mon, Aug 5

chill added a reviewer for D65508: [AArch64] Make the memtag sanitizer require the memtag extension: vitalybuka.
Mon, Aug 5, 2:33 AM · Restricted Project
chill added a reviewer for D65642: Enable memtag sanitizer in all AArch64 toolchains : vitalybuka.
Mon, Aug 5, 2:33 AM · Restricted Project

Fri, Aug 2

chill added a reviewer for D65642: Enable memtag sanitizer in all AArch64 toolchains : eugenis.
Fri, Aug 2, 2:31 AM · Restricted Project
chill added a child revision for D65508: [AArch64] Make the memtag sanitizer require the memtag extension: D65642: Enable memtag sanitizer in all AArch64 toolchains .
Fri, Aug 2, 2:31 AM · Restricted Project
chill created D65642: Enable memtag sanitizer in all AArch64 toolchains .
Fri, Aug 2, 2:31 AM · Restricted Project
chill added a parent revision for D65642: Enable memtag sanitizer in all AArch64 toolchains : D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Fri, Aug 2, 2:31 AM · Restricted Project

Wed, Jul 31

chill committed rGa36d31478c18: [AArch64] Add support for Transactional Memory Extension (TME) (authored by chill).
[AArch64] Add support for Transactional Memory Extension (TME)
Wed, Jul 31, 5:54 AM
chill committed rL367428: [AArch64] Add support for Transactional Memory Extension (TME).
[AArch64] Add support for Transactional Memory Extension (TME)
Wed, Jul 31, 5:53 AM
chill closed D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Wed, Jul 31, 5:53 AM · Restricted Project
chill added a reviewer for D65508: [AArch64] Make the memtag sanitizer require the memtag extension: eugenis.
Wed, Jul 31, 5:26 AM · Restricted Project
chill created D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Wed, Jul 31, 5:25 AM · Restricted Project

Tue, Jul 30

chill updated the diff for D64416: [AArch64] Add support for Transactional Memory Extension (TME).

Rebase on top of master.

Tue, Jul 30, 6:43 AM · Restricted Project
chill accepted D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Tue, Jul 30, 4:03 AM · Restricted Project

Mon, Jul 29

chill edited reviewers for D65404: [AArch64] Disable __ARM_FEATURE_SVE without ACLE., added: ktkachov; removed: chill.
Mon, Jul 29, 10:09 AM · Restricted Project
chill added a comment to D64416: [AArch64] Add support for Transactional Memory Extension (TME).

If there are no objections, I'll go ahead with committing that Soon(tm) on the basis of previous acceptance.

Mon, Jul 29, 7:36 AM · Restricted Project

Fri, Jul 26

chill committed rG898d953693ff: [AArch64] Define ETE and TRBE system registers (authored by chill).
[AArch64] Define ETE and TRBE system registers
Fri, Jul 26, 2:20 AM
chill committed rL367093: [AArch64] Define ETE and TRBE system registers.
[AArch64] Define ETE and TRBE system registers
Fri, Jul 26, 2:19 AM
chill closed D63707: [AArch64] Define ETE and TRBE system registers.
Fri, Jul 26, 2:19 AM · Restricted Project

Thu, Jul 25

chill added a comment to D63707: [AArch64] Define ETE and TRBE system registers.

Done, thanks!

Thu, Jul 25, 8:57 AM · Restricted Project
chill updated the diff for D63707: [AArch64] Define ETE and TRBE system registers.
Thu, Jul 25, 8:57 AM · Restricted Project
chill committed rGa655f476b0eb: [AArch64][SVE] Allow explicit size specifier for predicate operand (authored by chill).
[AArch64][SVE] Allow explicit size specifier for predicate operand
Thu, Jul 25, 6:57 AM
chill committed rL367019: [AArch64][SVE] Allow explicit size specifier for predicate operand.
[AArch64][SVE] Allow explicit size specifier for predicate operand
Thu, Jul 25, 6:55 AM
chill closed D65145: [AArch64][SVE] Allow explicit size specifier for predicate operand.
Thu, Jul 25, 6:55 AM · Restricted Project
chill updated the diff for D65145: [AArch64][SVE] Allow explicit size specifier for predicate operand.
Thu, Jul 25, 6:24 AM · Restricted Project

Jul 25 2019

chill added a comment to D63707: [AArch64] Define ETE and TRBE system registers.

Ping?

Jul 25 2019, 2:52 AM · Restricted Project

Jul 23 2019

chill added reviewers for D65145: [AArch64][SVE] Allow explicit size specifier for predicate operand: sdesmalen, c-rhodes, t.p.northover.
Jul 23 2019, 7:04 AM · Restricted Project
chill created D65145: [AArch64][SVE] Allow explicit size specifier for predicate operand.
Jul 23 2019, 7:04 AM · Restricted Project

Jul 22 2019

chill requested review of D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 22 2019, 10:23 AM · Restricted Project
chill updated the diff for D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 22 2019, 10:19 AM · Restricted Project

Jul 19 2019

chill planned changes to D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 19 2019, 6:08 AM · Restricted Project
chill requested review of D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 19 2019, 1:39 AM · Restricted Project
chill updated the diff for D64416: [AArch64] Add support for Transactional Memory Extension (TME).

Changed tcancel implementation.

Jul 19 2019, 1:39 AM · Restricted Project

Jul 18 2019

chill planned changes to D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 18 2019, 1:45 AM · Restricted Project
chill reopened D64416: [AArch64] Add support for Transactional Memory Extension (TME).

I reverted the patch, have to rework tcancel.

Jul 18 2019, 1:45 AM · Restricted Project

Jul 17 2019

chill committed rL366355: Revert [AArch64] Add support for Transactional Memory Extension (TME).
Revert [AArch64] Add support for Transactional Memory Extension (TME)
Jul 17 2019, 10:45 AM
chill committed rG0e2b74a2b0b8: Revert [AArch64] Add support for Transactional Memory Extension (TME) (authored by chill).
Revert [AArch64] Add support for Transactional Memory Extension (TME)
Jul 17 2019, 10:45 AM
chill committed rG4b8da3a503e4: [AArch64] Add support for Transactional Memory Extension (TME) (authored by chill).
[AArch64] Add support for Transactional Memory Extension (TME)
Jul 17 2019, 6:24 AM
chill committed rL366322: [AArch64] Add support for Transactional Memory Extension (TME).
[AArch64] Add support for Transactional Memory Extension (TME)
Jul 17 2019, 6:23 AM
chill closed D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 17 2019, 6:23 AM · Restricted Project
chill committed rGe14cfe2d2ea2: [AArch64] Consistent types and naming for AArch64 target features (NFC) (authored by chill).
[AArch64] Consistent types and naming for AArch64 target features (NFC)
Jul 17 2019, 4:25 AM
chill committed rL366315: [AArch64] Consistent types and naming for AArch64 target features (NFC).
[AArch64] Consistent types and naming for AArch64 target features (NFC)
Jul 17 2019, 4:24 AM
chill closed D64415: Consistent types and naming for AArch64 target features (NFC).
Jul 17 2019, 4:24 AM · Restricted Project
chill updated the diff for D64415: Consistent types and naming for AArch64 target features (NFC).
Jul 17 2019, 4:23 AM · Restricted Project
chill committed rG52c393961519: [TableGen] Do not set ReadNone attribute on intrinsics with side effects (authored by chill).
[TableGen] Do not set ReadNone attribute on intrinsics with side effects
Jul 17 2019, 3:58 AM
chill committed rL366312: [TableGen] Do not set ReadNone attribute on intrinsics with side effects.
[TableGen] Do not set ReadNone attribute on intrinsics with side effects
Jul 17 2019, 3:53 AM
chill closed D64414: Do not set ReadNone attribute on intrinsics with side effects.
Jul 17 2019, 3:53 AM · Restricted Project

Jul 16 2019

chill accepted D64415: Consistent types and naming for AArch64 target features (NFC).

Going to commit as obvious.

Jul 16 2019, 1:46 AM · Restricted Project

Jul 15 2019

chill updated the diff for D64414: Do not set ReadNone attribute on intrinsics with side effects.

Added a regression test.

Jul 15 2019, 9:25 AM · Restricted Project
chill updated subscribers of D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 15 2019, 2:00 AM · Restricted Project
chill updated subscribers of D64415: Consistent types and naming for AArch64 target features (NFC).
Jul 15 2019, 1:55 AM · Restricted Project
chill added a reviewer for D64415: Consistent types and naming for AArch64 target features (NFC): t.p.northover.
Jul 15 2019, 1:53 AM · Restricted Project

Jul 11 2019

chill added a comment to D64414: Do not set ReadNone attribute on intrinsics with side effects.

What if a different thread causes an abort before the commit? store-load forwarding would then cause an inconsistent view, wouldn't it?
I find this is like atomic loads that also "write" memory if the synchronization is strong enough to make other modifications visible at that point.

If the transaction is aborted before or by the tcommit, it'll be automatically rolled back to the tstart, which initiated it, discarding
any register and memory writes, and won't reach the instruction after the tcommit.

I agree, that is what needs to happen. Maybe I misunderstood what your example was supposed to show. The way I did understand it, I figured you want the store to load propagation to happen across the tcommit instruction. That has to be forbidden in the IR as it will otherwise happen and break the atomicity of the transaction. To forbid it one would give the tcommit intrinsic a memory effect. Now, I think it actually has a memory effect: Similar to sequential consistent atomic loads, tcommit synchronizes, thereby making memory changes visible to the thread.

We can move the discussion to the main patch if you want.

Jul 11 2019, 6:51 AM · Restricted Project
chill added inline comments to D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 11 2019, 6:09 AM · Restricted Project
chill updated the diff for D64416: [AArch64] Add support for Transactional Memory Extension (TME).

Thanks for the review. I've addressed the comments.

Jul 11 2019, 5:50 AM · Restricted Project

Jul 10 2019

chill removed a reviewer for D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A: momchil.velikov.
Jul 10 2019, 7:51 AM · Restricted Project, Restricted Project
chill added a comment to D64447: Fix llvm.aarch64.irg properties..

I suggested this change here: https://reviews.llvm.org/D60486#inline-574695
But I've got the feeling (from https://reviews.llvm.org/D64414) it a subject for a debate.

Jul 10 2019, 2:50 AM · Restricted Project
chill added reviewers for D64447: Fix llvm.aarch64.irg properties.: t.p.northover, jdoerfert.
Jul 10 2019, 2:48 AM · Restricted Project
chill added reviewers for D64416: [AArch64] Add support for Transactional Memory Extension (TME): t.p.northover, jdoerfert.
Jul 10 2019, 2:47 AM · Restricted Project
chill added a comment to D64414: Do not set ReadNone attribute on intrinsics with side effects.

What if a different thread causes an abort before the commit? store-load forwarding would then cause an inconsistent view, wouldn't it?
I find this is like atomic loads that also "write" memory if the synchronization is strong enough to make other modifications visible at that point.

Jul 10 2019, 2:23 AM · Restricted Project
chill added inline comments to D63707: [AArch64] Define ETE and TRBE system registers.
Jul 10 2019, 1:47 AM · Restricted Project

Jul 9 2019

chill added a comment to D64414: Do not set ReadNone attribute on intrinsics with side effects.

I'm a bit lost. What intrinsic do we have that is "no-mem" but has side-effects?

E.g __builtin_arm_tcommit, which I'm adding in this series, or __builtin_arm_irg (which is *should* be NoMem, but is not, perhaps as a workaround for this issue).

(Sorry if I'm way off here but I'd like to understand this better)

tcommit makes the transaction state visible, correct? If so, I'd argue it modifies the memory (especially for other threads). Maybe my confusion stems from the IR vs MIR conflict here but in IR, I would not like tcommit to be readnone for multiple reasons, including memory movement around it.

Jul 9 2019, 12:52 PM · Restricted Project
chill updated subscribers of D64413: [ARM] Enable VPUSH/VPOP aliases when either MVE or VFP is present.
Jul 9 2019, 11:40 AM · Restricted Project
chill added a comment to D64414: Do not set ReadNone attribute on intrinsics with side effects.

I'm a bit lost. What intrinsic do we have that is "no-mem" but has side-effects?

Jul 9 2019, 11:10 AM · Restricted Project
chill added a comment to D64414: Do not set ReadNone attribute on intrinsics with side effects.

If an intrinsic is defined without outputs, but having side effects, it still can be removed completely from the program

This kinda sounds slightly backwards.
*If* there are side-effects, then i'd expect it not to be dropped regardless of readnone status.

Jul 9 2019, 8:49 AM · Restricted Project
chill added a comment to D64402: [libunwind] Fix Unwind-EHABI.cpp:getByte on big-endian targets.

Sorry, messages crossed.

Jul 9 2019, 7:56 AM · Restricted Project, Restricted Project
chill accepted D64402: [libunwind] Fix Unwind-EHABI.cpp:getByte on big-endian targets.

LGTM, that's what EHABI spec says:

Jul 9 2019, 7:55 AM · Restricted Project, Restricted Project
chill added a comment to D64414: Do not set ReadNone attribute on intrinsics with side effects.

Test?

Jul 9 2019, 6:55 AM · Restricted Project
chill added a parent revision for D64416: [AArch64] Add support for Transactional Memory Extension (TME): D64415: Consistent types and naming for AArch64 target features (NFC).
Jul 9 2019, 6:41 AM · Restricted Project
chill added a child revision for D64415: Consistent types and naming for AArch64 target features (NFC): D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 9 2019, 6:41 AM · Restricted Project