Page MenuHomePhabricator

chill (Momchil Velikov)
User

Projects

User does not belong to any projects.

User Details

User Since
May 24 2017, 3:29 AM (266 w, 2 d)

Recent Activity

Tue, Jun 28

chill added inline comments to D114174: [ARM][CodeGen] Add support for complex addition and multiplication.
Tue, Jun 28, 7:46 AM · Restricted Project, Restricted Project
chill added inline comments to D114174: [ARM][CodeGen] Add support for complex addition and multiplication.
Tue, Jun 28, 7:42 AM · Restricted Project, Restricted Project
chill added a comment to D114174: [ARM][CodeGen] Add support for complex addition and multiplication.

Do we have some broad overview of the approach and the algorithm? It'd be a good idea put something like this in the description and eventually the commit message. (I searched for LLVM complex RFCs, buy couldn't find anything useful).

Tue, Jun 28, 3:30 AM · Restricted Project, Restricted Project
chill added inline comments to D114174: [ARM][CodeGen] Add support for complex addition and multiplication.
Tue, Jun 28, 3:28 AM · Restricted Project, Restricted Project

Mon, Jun 27

chill updated the diff for D117867: [GVN] MemorySSA for GVN: remove all mention of MemDep from GVN.
Mon, Jun 27, 7:54 AM · Restricted Project, Restricted Project
chill updated the diff for D120421: [GVN] MemorySSA for GVN: switch to using MemorySSA by default.
Mon, Jun 27, 7:53 AM · Restricted Project, Restricted Project
chill updated the diff for D116825: [GVN] MemorySSA for GVN: use MemorySSA for redundant loads elimination.

Revert to a previous version, which scanned all the memory
accesses in a block. Add a testcase showing why it's necessary.

Mon, Jun 27, 7:53 AM · Restricted Project, Restricted Project
chill updated the diff for D115160: [GVN] MemorySSA for GVN: use the incoming memory state in the value numbers.
Mon, Jun 27, 7:23 AM · Restricted Project, Restricted Project
chill updated the diff for D118255: [GVN] MemorySSA for GVN: add a switch to enable MemorySSA for GVN.
Mon, Jun 27, 7:23 AM · Restricted Project, Restricted Project

May 9 2022

chill updated the diff for D117867: [GVN] MemorySSA for GVN: remove all mention of MemDep from GVN.
May 9 2022, 9:44 AM · Restricted Project, Restricted Project
chill updated the diff for D120421: [GVN] MemorySSA for GVN: switch to using MemorySSA by default.
May 9 2022, 9:43 AM · Restricted Project, Restricted Project
chill updated the diff for D116825: [GVN] MemorySSA for GVN: use MemorySSA for redundant loads elimination.
May 9 2022, 9:43 AM · Restricted Project, Restricted Project
chill updated the diff for D115160: [GVN] MemorySSA for GVN: use the incoming memory state in the value numbers.
May 9 2022, 9:42 AM · Restricted Project, Restricted Project
chill updated the diff for D118255: [GVN] MemorySSA for GVN: add a switch to enable MemorySSA for GVN.
May 9 2022, 9:41 AM · Restricted Project, Restricted Project

Apr 18 2022

chill committed rGe0ff354b8376: [AArch64] Async unwind - Adjust unwind info in AArch64LoadStoreOptimizer (authored by chill).
[AArch64] Async unwind - Adjust unwind info in AArch64LoadStoreOptimizer
Apr 18 2022, 4:11 AM · Restricted Project, Restricted Project
chill closed D114547: [AArch64] Async unwind - Adjust unwind info in AArch64LoadStoreOptimizer.
Apr 18 2022, 4:11 AM · Restricted Project, Restricted Project

Apr 15 2022

chill updated the diff for D114547: [AArch64] Async unwind - Adjust unwind info in AArch64LoadStoreOptimizer.

Fixed a bootstrap failure, there was a missing check for end iterator.

Apr 15 2022, 8:03 AM · Restricted Project, Restricted Project
chill committed rG24c84bd2363a: [AArch64] Async unwind - Fix MTE codegen emitting frame adjustments in a loop (authored by chill).
[AArch64] Async unwind - Fix MTE codegen emitting frame adjustments in a loop
Apr 15 2022, 6:03 AM · Restricted Project, Restricted Project
chill closed D114548: [AArch64] Async unwind - Fix MTE codegen emitting frame adjustments in a loop.
Apr 15 2022, 6:03 AM · Restricted Project, Restricted Project
chill planned changes to D114547: [AArch64] Async unwind - Adjust unwind info in AArch64LoadStoreOptimizer.
Apr 15 2022, 4:17 AM · Restricted Project, Restricted Project
chill reopened D114547: [AArch64] Async unwind - Adjust unwind info in AArch64LoadStoreOptimizer.
Apr 15 2022, 4:17 AM · Restricted Project, Restricted Project
chill updated the diff for D114548: [AArch64] Async unwind - Fix MTE codegen emitting frame adjustments in a loop.
Apr 15 2022, 4:16 AM · Restricted Project, Restricted Project

Apr 14 2022

chill added a reverting change for rGecbf32dd88fc: [AArch64] Async unwind - Adjust unwind info in AArch64LoadStoreOptimizer: rG62d4686be3a2: Revert "[AArch64] Async unwind - Adjust unwind info in….
Apr 14 2022, 1:37 AM · Restricted Project, Restricted Project
chill committed rG62d4686be3a2: Revert "[AArch64] Async unwind - Adjust unwind info in… (authored by chill).
Revert "[AArch64] Async unwind - Adjust unwind info in…
Apr 14 2022, 1:37 AM · Restricted Project, Restricted Project
chill added a reverting change for D114547: [AArch64] Async unwind - Adjust unwind info in AArch64LoadStoreOptimizer: rG62d4686be3a2: Revert "[AArch64] Async unwind - Adjust unwind info in….
Apr 14 2022, 1:37 AM · Restricted Project, Restricted Project

Apr 13 2022

chill committed rGecbf32dd88fc: [AArch64] Async unwind - Adjust unwind info in AArch64LoadStoreOptimizer (authored by chill).
[AArch64] Async unwind - Adjust unwind info in AArch64LoadStoreOptimizer
Apr 13 2022, 9:26 AM · Restricted Project, Restricted Project
chill closed D114547: [AArch64] Async unwind - Adjust unwind info in AArch64LoadStoreOptimizer.
Apr 13 2022, 9:25 AM · Restricted Project, Restricted Project
chill added a comment to D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets.

Should these lists contain only source tree headers or also generated header files? I'm not seeing arm_mve.h, for example.

Apr 13 2022, 7:50 AM · Restricted Project, Restricted Project

Apr 12 2022

chill committed rGd0ea42a7c1bc: [AArch64] Async unwind - function epilogues (authored by chill).
[AArch64] Async unwind - function epilogues
Apr 12 2022, 8:53 AM · Restricted Project, Restricted Project
chill closed D112330: [AArch64] Async unwind - function epilogues.
Apr 12 2022, 8:53 AM · Restricted Project, Restricted Project
chill updated the diff for D112330: [AArch64] Async unwind - function epilogues.
Apr 12 2022, 6:53 AM · Restricted Project, Restricted Project

Apr 11 2022

chill updated the diff for D112330: [AArch64] Async unwind - function epilogues.
Apr 11 2022, 10:50 AM · Restricted Project, Restricted Project
chill added inline comments to D112330: [AArch64] Async unwind - function epilogues.
Apr 11 2022, 10:29 AM · Restricted Project, Restricted Project
chill committed rGb4ad28da196d: [CodeGen] Async unwind - add a pass to fix CFI information (authored by chill).
[CodeGen] Async unwind - add a pass to fix CFI information
Apr 11 2022, 5:37 AM · Restricted Project, Restricted Project
chill closed D114545: [CodeGen] Async unwind - add a pass to fix CFI information.
Apr 11 2022, 5:36 AM · Restricted Project, Restricted Project
chill updated the diff for D114545: [CodeGen] Async unwind - add a pass to fix CFI information.
Apr 11 2022, 3:47 AM · Restricted Project, Restricted Project

Apr 6 2022

chill requested review of D114545: [CodeGen] Async unwind - add a pass to fix CFI information.
Apr 6 2022, 8:23 AM · Restricted Project, Restricted Project
chill updated the diff for D114545: [CodeGen] Async unwind - add a pass to fix CFI information.

Updated to exclude unreachable blocks.

Apr 6 2022, 8:23 AM · Restricted Project, Restricted Project

Apr 5 2022

chill planned changes to D114545: [CodeGen] Async unwind - add a pass to fix CFI information.
Apr 5 2022, 9:54 AM · Restricted Project, Restricted Project
chill added a comment to D114545: [CodeGen] Async unwind - add a pass to fix CFI information.

Hi I have temporarily reverted this change as it has caused LLVM buildbot failures with failing fuzzer-threaded.test with clang crashing over an assertion failure in llvm/lib/CodeGen/CFIFixup.cpp. Kindly look into it. Thanks
.

Apr 5 2022, 9:54 AM · Restricted Project, Restricted Project
chill reopened D114545: [CodeGen] Async unwind - add a pass to fix CFI information.
Apr 5 2022, 9:48 AM · Restricted Project, Restricted Project

Apr 4 2022

chill committed rG980c3e6dd223: [CodeGen] Async unwind - add a pass to fix CFI information (authored by chill).
[CodeGen] Async unwind - add a pass to fix CFI information
Apr 4 2022, 6:39 AM · Restricted Project, Restricted Project
chill closed D114545: [CodeGen] Async unwind - add a pass to fix CFI information.
Apr 4 2022, 6:38 AM · Restricted Project, Restricted Project
chill added a comment to D114545: [CodeGen] Async unwind - add a pass to fix CFI information.

Looks great! Thanks again for the hard work! And sorry again for being so slow to get to this important pass :-(

Apr 4 2022, 2:00 AM · Restricted Project, Restricted Project

Apr 1 2022

chill added inline comments to D114545: [CodeGen] Async unwind - add a pass to fix CFI information.
Apr 1 2022, 2:49 AM · Restricted Project, Restricted Project
chill updated the diff for D114545: [CodeGen] Async unwind - add a pass to fix CFI information.
Apr 1 2022, 2:46 AM · Restricted Project, Restricted Project

Mar 31 2022

chill added inline comments to D114545: [CodeGen] Async unwind - add a pass to fix CFI information.
Mar 31 2022, 7:09 AM · Restricted Project, Restricted Project
chill updated the diff for D114545: [CodeGen] Async unwind - add a pass to fix CFI information.
Mar 31 2022, 6:51 AM · Restricted Project, Restricted Project

Mar 30 2022

chill updated the diff for D114548: [AArch64] Async unwind - Fix MTE codegen emitting frame adjustments in a loop.
Mar 30 2022, 9:56 AM · Restricted Project, Restricted Project
chill updated the diff for D114547: [AArch64] Async unwind - Adjust unwind info in AArch64LoadStoreOptimizer.
Mar 30 2022, 9:55 AM · Restricted Project, Restricted Project
chill updated the diff for D112330: [AArch64] Async unwind - function epilogues.
Mar 30 2022, 9:55 AM · Restricted Project, Restricted Project
chill added inline comments to D114545: [CodeGen] Async unwind - add a pass to fix CFI information.
Mar 30 2022, 9:54 AM · Restricted Project, Restricted Project
chill updated the diff for D114545: [CodeGen] Async unwind - add a pass to fix CFI information.
Mar 30 2022, 9:42 AM · Restricted Project, Restricted Project

Mar 29 2022

chill added a comment to D114545: [CodeGen] Async unwind - add a pass to fix CFI information.

"layout order" seems to suggest the linear placement order.

That's right, it's the order of increasing instruction addresses, corresponding to the basic block layout and the order of instructions in the basic block.

Mar 29 2022, 10:56 AM · Restricted Project, Restricted Project

Mar 24 2022

chill committed rG50a97aacacf6: [AArch64] Async unwind - function prologues (authored by chill).
[AArch64] Async unwind - function prologues
Mar 24 2022, 9:18 AM · Restricted Project
chill closed D111411: [AArch64] Async unwind - function prologues.
Mar 24 2022, 9:17 AM · Restricted Project, Restricted Project
chill accepted D112330: [AArch64] Async unwind - function epilogues.
Mar 24 2022, 7:34 AM · Restricted Project, Restricted Project
chill accepted D114545: [CodeGen] Async unwind - add a pass to fix CFI information.
Mar 24 2022, 7:34 AM · Restricted Project, Restricted Project
chill updated the diff for D114548: [AArch64] Async unwind - Fix MTE codegen emitting frame adjustments in a loop.

Rebased.

Mar 24 2022, 7:33 AM · Restricted Project, Restricted Project
chill updated the diff for D114547: [AArch64] Async unwind - Adjust unwind info in AArch64LoadStoreOptimizer.

Rebased

Mar 24 2022, 7:33 AM · Restricted Project, Restricted Project
chill updated the diff for D112330: [AArch64] Async unwind - function epilogues.

Updated on top of latest main, will commit it the following days, based on previous
acceptance, as it contains no non-trivial changes.

Mar 24 2022, 7:32 AM · Restricted Project, Restricted Project
chill updated the diff for D114545: [CodeGen] Async unwind - add a pass to fix CFI information.

Updated on top of latest main, will commit it the following days, based on previous
acceptance, as it contains no non-trivial changes.

Mar 24 2022, 7:32 AM · Restricted Project, Restricted Project
chill updated the diff for D111411: [AArch64] Async unwind - function prologues.

Updated on top of latest main and on top of D121017
Now https://bugs.chromium.org/p/chromium/issues/detail?id=1302998 should be fixed.

Mar 24 2022, 7:30 AM · Restricted Project, Restricted Project

Mar 23 2022

chill committed rGa6d238536d95: [AArch64] Fallback to DWARF when trying to emit compact unwind info with… (authored by chill).
[AArch64] Fallback to DWARF when trying to emit compact unwind info with…
Mar 23 2022, 8:34 AM · Restricted Project
chill closed D121017: [AArch64] Fallback to DWARF when trying to emit compact unwind info with multiple CFA offset adjustments.
Mar 23 2022, 8:34 AM · Restricted Project, Restricted Project
chill updated the diff for D117867: [GVN] MemorySSA for GVN: remove all mention of MemDep from GVN.
Mar 23 2022, 7:47 AM · Restricted Project, Restricted Project
chill updated the diff for D120421: [GVN] MemorySSA for GVN: switch to using MemorySSA by default.
Mar 23 2022, 7:46 AM · Restricted Project, Restricted Project
chill updated the diff for D116825: [GVN] MemorySSA for GVN: use MemorySSA for redundant loads elimination.
Mar 23 2022, 7:46 AM · Restricted Project, Restricted Project
chill updated the diff for D115160: [GVN] MemorySSA for GVN: use the incoming memory state in the value numbers.
Mar 23 2022, 7:45 AM · Restricted Project, Restricted Project
chill updated the diff for D118255: [GVN] MemorySSA for GVN: add a switch to enable MemorySSA for GVN.
Mar 23 2022, 7:44 AM · Restricted Project, Restricted Project

Mar 11 2022

chill added a comment to D121017: [AArch64] Fallback to DWARF when trying to emit compact unwind info with multiple CFA offset adjustments.

Ping.

Mar 11 2022, 10:17 AM · Restricted Project, Restricted Project

Mar 7 2022

Herald added a project to D114548: [AArch64] Async unwind - Fix MTE codegen emitting frame adjustments in a loop: Restricted Project.

PIng?

Mar 7 2022, 4:23 AM · Restricted Project, Restricted Project
chill updated the diff for D112330: [AArch64] Async unwind - function epilogues.
Mar 7 2022, 4:18 AM · Restricted Project, Restricted Project
chill updated the diff for D114545: [CodeGen] Async unwind - add a pass to fix CFI information.
Mar 7 2022, 4:17 AM · Restricted Project, Restricted Project
chill updated the diff for D111411: [AArch64] Async unwind - function prologues.
Mar 7 2022, 4:13 AM · Restricted Project, Restricted Project

Mar 4 2022

chill added inline comments to D111703: [ARM] __cxa_end_cleanup should be called instead of _UnwindResume..
Mar 4 2022, 3:12 PM · Restricted Project, Restricted Project, Restricted Project
chill planned changes to D111411: [AArch64] Async unwind - function prologues.
Mar 4 2022, 11:53 AM · Restricted Project, Restricted Project
chill reopened D111411: [AArch64] Async unwind - function prologues.
Mar 4 2022, 11:53 AM · Restricted Project, Restricted Project
chill requested review of D121017: [AArch64] Fallback to DWARF when trying to emit compact unwind info with multiple CFA offset adjustments.
Mar 4 2022, 11:47 AM · Restricted Project, Restricted Project
chill requested review of D112330: [AArch64] Async unwind - function epilogues.
Mar 4 2022, 8:30 AM · Restricted Project, Restricted Project
chill requested review of D114545: [CodeGen] Async unwind - add a pass to fix CFI information.

Brought forward, emitting epilogue would no be correct without this patch. A little bit of tests moved to the epilogues patch, no other changes.

Mar 4 2022, 8:30 AM · Restricted Project, Restricted Project
chill added a comment to D112330: [AArch64] Async unwind - function epilogues.

Committing this change caused failures in the asan/hwasan regression tests. The reason was that emitting unwind info
in epilogues caused the unwind information in case like below:

foo:
  ...
  CSR saves
  ...
  CSR restores
  ret
L:
  ...
  b <somewhere>

to no longer be accidentally correct for the region starting at L. That could be a miscompilation
if a throwing call somehow ends up in that region.

Mar 4 2022, 8:28 AM · Restricted Project, Restricted Project
chill updated the diff for D112330: [AArch64] Async unwind - function epilogues.
Mar 4 2022, 8:14 AM · Restricted Project, Restricted Project
chill updated the diff for D114545: [CodeGen] Async unwind - add a pass to fix CFI information.
Mar 4 2022, 8:14 AM · Restricted Project, Restricted Project
Herald added a project to D114547: [AArch64] Async unwind - Adjust unwind info in AArch64LoadStoreOptimizer: Restricted Project.
Mar 4 2022, 8:12 AM · Restricted Project, Restricted Project
chill reopened D112330: [AArch64] Async unwind - function epilogues.
Mar 4 2022, 8:12 AM · Restricted Project, Restricted Project
Herald added a project to D114545: [CodeGen] Async unwind - add a pass to fix CFI information: Restricted Project.
Mar 4 2022, 8:10 AM · Restricted Project, Restricted Project

Mar 2 2022

chill added a reverting change for rG74319d67943a: [AArch64] Async unwind - function epilogues: rG63c9aca12afa: Revert "[AArch64] Async unwind - function epilogues".
Mar 2 2022, 7:02 AM · Restricted Project
chill committed rG63c9aca12afa: Revert "[AArch64] Async unwind - function epilogues" (authored by chill).
Revert "[AArch64] Async unwind - function epilogues"
Mar 2 2022, 7:02 AM · Restricted Project
chill added a reverting change for D112330: [AArch64] Async unwind - function epilogues: rG63c9aca12afa: Revert "[AArch64] Async unwind - function epilogues".
Mar 2 2022, 7:02 AM · Restricted Project, Restricted Project
chill committed rG74319d67943a: [AArch64] Async unwind - function epilogues (authored by chill).
[AArch64] Async unwind - function epilogues
Mar 2 2022, 5:32 AM · Restricted Project
chill closed D112330: [AArch64] Async unwind - function epilogues.
Mar 2 2022, 5:32 AM · Restricted Project, Restricted Project

Mar 1 2022

chill updated the diff for D112330: [AArch64] Async unwind - function epilogues.
Mar 1 2022, 8:40 AM · Restricted Project, Restricted Project

Feb 28 2022

chill committed rG32e8b550e543: [AArch64] Async unwind - function prologues (authored by chill).
[AArch64] Async unwind - function prologues
Feb 28 2022, 5:44 AM
chill closed D111411: [AArch64] Async unwind - function prologues.
Feb 28 2022, 5:43 AM · Restricted Project, Restricted Project
chill updated the diff for D111411: [AArch64] Async unwind - function prologues.
Feb 28 2022, 3:50 AM · Restricted Project, Restricted Project

Feb 25 2022

chill committed rG20a093e2bc31: [AArch64] Async unwind - Refactor generation of shadow call stack… (authored by chill).
[AArch64] Async unwind - Refactor generation of shadow call stack…
Feb 25 2022, 3:11 AM
chill closed D112329: [AArch64] Async unwind - Refactor generation of shadow call stack prologue/epilogue.
Feb 25 2022, 3:10 AM · Restricted Project

Feb 24 2022

chill committed rG17e85cd4109c: [AArch64] Async unwind - Always place the first LDP at the end when… (authored by chill).
[AArch64] Async unwind - Always place the first LDP at the end when…
Feb 24 2022, 10:57 AM
chill closed D112328: [AArch64] Async unwind - Always place the first LDP at the end when ReverseCSRRestoreSeq is true .
Feb 24 2022, 10:57 AM · Restricted Project