Page MenuHomePhabricator

chill (Momchil Velikov)
User

Projects

User does not belong to any projects.

User Details

User Since
May 24 2017, 3:29 AM (100 w, 2 d)

Recent Activity

Mar 25 2019

chill updated the diff for D51160: Adjust MIScheduler to use ProcResource counts.

Updated regression tests.

Mar 25 2019, 4:53 PM · Restricted Project

Feb 25 2019

chill added inline comments to D58490: [ARM] Be super conservative about atomics.
Feb 25 2019, 1:57 AM · Restricted Project

Oct 11 2018

chill commandeered D51160: Adjust MIScheduler to use ProcResource counts.

Taking over as Jackson's internship ended in the meantime.

Oct 11 2018, 8:33 AM · Restricted Project

Oct 8 2018

chill added a comment to D51160: Adjust MIScheduler to use ProcResource counts.

Ping?

Oct 8 2018, 6:48 AM · Restricted Project

Sep 28 2018

chill added a comment to D51160: Adjust MIScheduler to use ProcResource counts.

PIng?

Sep 28 2018, 9:34 AM · Restricted Project

Sep 6 2018

chill added a reviewer for D51494: Fix unwind information for floating point registers: compnerd.
Sep 6 2018, 6:29 AM

Aug 30 2018

chill edited reviewers for D51494: Fix unwind information for floating point registers, added: chill; removed: momchil.velikov.
Aug 30 2018, 10:02 AM

Aug 29 2018

chill added inline comments to D51160: Adjust MIScheduler to use ProcResource counts.
Aug 29 2018, 2:26 AM · Restricted Project
chill added inline comments to D51160: Adjust MIScheduler to use ProcResource counts.
Aug 29 2018, 2:05 AM · Restricted Project

Aug 15 2018

chill committed rL339766: Use .cpp extension for certain tests instead of .cc.
Use .cpp extension for certain tests instead of .cc
Aug 15 2018, 5:23 AM
chill committed rC339766: Use .cpp extension for certain tests instead of .cc.
Use .cpp extension for certain tests instead of .cc
Aug 15 2018, 5:22 AM

Jul 30 2018

chill committed rL338279: [ARM, AArch64]: Use unadjusted alignment when passing composites as arguments.
[ARM, AArch64]: Use unadjusted alignment when passing composites as arguments
Jul 30 2018, 10:49 AM
chill committed rC338279: [ARM, AArch64]: Use unadjusted alignment when passing composites as arguments.
[ARM, AArch64]: Use unadjusted alignment when passing composites as arguments
Jul 30 2018, 10:49 AM
chill closed D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.
Jul 30 2018, 10:48 AM
chill accepted D49984: Fix uninitialized read in ARM's PrintAsmOperand.

LGTM.

Jul 30 2018, 9:30 AM
chill added inline comments to D49984: Fix uninitialized read in ARM's PrintAsmOperand.
Jul 30 2018, 8:13 AM
chill added inline comments to D49984: Fix uninitialized read in ARM's PrintAsmOperand.
Jul 30 2018, 7:33 AM

Jul 27 2018

chill added a comment to D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.

Thanks for pointing this!

Jul 27 2018, 4:02 AM
chill updated the diff for D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.

Fixed to properly examine the canonical type when getting it's unadjusted alignment.

Jul 27 2018, 4:01 AM

Jul 23 2018

chill added a comment to D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.

Ping?

Jul 23 2018, 10:23 AM

Jul 20 2018

chill accepted D49465: [ARM] Enable tail calls for all Thumb1 targets..

LGTM. test/CodeGen/Thumb/PR35481.ll needs an update though ( and a typo there CHECK-V47)

Jul 20 2018, 3:31 AM
chill accepted D49459: [ARM] Avoid spilling lr with Thumb1 tail calls..
Jul 20 2018, 3:28 AM

Jul 18 2018

chill added inline comments to D49459: [ARM] Avoid spilling lr with Thumb1 tail calls..
Jul 18 2018, 6:50 AM

Jul 16 2018

chill added a comment to D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.

Ping?

Jul 16 2018, 1:37 AM

Jul 9 2018

chill added a comment to D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.

Ping?

Jul 9 2018, 3:48 PM

Jul 5 2018

chill accepted D48916: Fix setting of empty implicit-section-name attribute for functions affected by '#pragma clang section'.

LGTM. Please, wait a couple of days before committing to give a chance to someone else to weigh in.

Jul 5 2018, 12:51 AM

Jul 4 2018

chill added inline comments to D48916: Fix setting of empty implicit-section-name attribute for functions affected by '#pragma clang section'.
Jul 4 2018, 1:35 AM

Jul 2 2018

chill added a comment to D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.

Ping?

Jul 2 2018, 1:40 AM

Jun 25 2018

chill updated the diff for D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.

Update: use "unadjusted alignment" instead of "natural alignment", rename things accordingly.

Jun 25 2018, 6:31 AM
chill added inline comments to D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.
Jun 25 2018, 2:14 AM
chill added a comment to D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.

I'm fine with the ABI changes, but I'm not very convinced by the "NaturalAlignment" name.

Jun 25 2018, 2:14 AM

Jun 21 2018

chill added a comment to D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.

Ping?

Jun 21 2018, 7:42 AM

Jun 13 2018

chill added a comment to D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.

Ping?

Jun 13 2018, 3:09 AM

Jun 6 2018

chill updated the diff for D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.

Update: refactor a bit to not impose size overhead on targets, which don't use natural alignment.

Jun 6 2018, 8:51 AM

Jun 1 2018

chill added a comment to D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.

I'm not sure Apple will want to mess with their ABI like this... adding some reviewers.

Jun 1 2018, 1:09 PM
chill updated the diff for D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.

Update:

  • fix only APCS, don't touch other ABIs
  • misc other
Jun 1 2018, 1:07 PM

May 31 2018

chill updated the diff for D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.

Update:

  • similar changes needed for AArch64
  • added/updated tests
May 31 2018, 2:29 AM

May 21 2018

chill committed rC332843: [Sema] Fix incorrect packed aligned structure layout.
[Sema] Fix incorrect packed aligned structure layout
May 21 2018, 7:32 AM
chill committed rL332843: [Sema] Fix incorrect packed aligned structure layout.
[Sema] Fix incorrect packed aligned structure layout
May 21 2018, 7:32 AM
chill closed D46439: [Sema] Fix incorrect packed aligned structure layout.
May 21 2018, 7:32 AM
chill added a comment to D46439: [Sema] Fix incorrect packed aligned structure layout.

Thanks a lot!

May 21 2018, 7:27 AM

May 15 2018

chill added a comment to D46439: [Sema] Fix incorrect packed aligned structure layout.

Ping?

May 15 2018, 3:47 AM

May 8 2018

chill added a comment to D46439: [Sema] Fix incorrect packed aligned structure layout.

Update: updated comment, added a test.

May 8 2018, 7:28 AM
chill updated the diff for D46439: [Sema] Fix incorrect packed aligned structure layout.
May 8 2018, 7:26 AM

May 4 2018

chill added a child revision for D46439: [Sema] Fix incorrect packed aligned structure layout: D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.
May 4 2018, 9:51 AM
chill added a parent revision for D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments: D46439: [Sema] Fix incorrect packed aligned structure layout.
May 4 2018, 9:51 AM
chill removed a parent revision for D46439: [Sema] Fix incorrect packed aligned structure layout: D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.
May 4 2018, 9:51 AM
chill removed a child revision for D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments: D46439: [Sema] Fix incorrect packed aligned structure layout.
May 4 2018, 9:51 AM
chill added a parent revision for D46439: [Sema] Fix incorrect packed aligned structure layout: D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.
May 4 2018, 9:49 AM
chill added a child revision for D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments: D46439: [Sema] Fix incorrect packed aligned structure layout.
May 4 2018, 9:49 AM
chill created D46439: [Sema] Fix incorrect packed aligned structure layout.
May 4 2018, 9:45 AM

May 3 2018

chill added a comment to D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.

I'd like to see some tests for __attribute((packed)).

May 3 2018, 10:07 AM

May 1 2018

chill added a comment to D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.

Ping?

May 1 2018, 2:26 AM

Apr 24 2018

chill created D46013: [ARM] Conform to AAPCS when passing overaligned composites as arguments.
Apr 24 2018, 7:58 AM

Apr 18 2018

chill committed rL330253: Add tests for shrink wrapping and VLAs.
Add tests for shrink wrapping and VLAs
Apr 18 2018, 6:40 AM
chill closed D45727: Add tests for shrink wrapping and VLAs.
Apr 18 2018, 6:40 AM
chill updated the diff for D45727: Add tests for shrink wrapping and VLAs.
Apr 18 2018, 6:37 AM
chill updated the diff for D45727: Add tests for shrink wrapping and VLAs.
Apr 18 2018, 3:51 AM

Apr 17 2018

chill created D45727: Add tests for shrink wrapping and VLAs.
Apr 17 2018, 10:24 AM
chill committed rL330193: Revert "Fix incorrect choice of callee-saved registers save/restore points….
Revert "Fix incorrect choice of callee-saved registers save/restore points…
Apr 17 2018, 9:34 AM
chill committed rL330192: Fix incorrect choice of callee-saved registers save/restore points (take 2).
Fix incorrect choice of callee-saved registers save/restore points (take 2)
Apr 17 2018, 9:03 AM
chill added a comment to D45524: Fix incorrect choice of callee-saved registers save/restore points.

IIRC, there was a test case in the original patch but I can't see it in the landed commit. Any idea what happened?

Apr 17 2018, 9:00 AM
chill committed rL330183: Fix incorrect choice of callee-saved registers save/restore points.
Fix incorrect choice of callee-saved registers save/restore points
Apr 17 2018, 1:42 AM
chill closed D45524: Fix incorrect choice of callee-saved registers save/restore points.
Apr 17 2018, 1:42 AM
chill updated the summary of D45524: Fix incorrect choice of callee-saved registers save/restore points.
Apr 17 2018, 1:39 AM
chill updated the diff for D45524: Fix incorrect choice of callee-saved registers save/restore points.
Apr 17 2018, 1:28 AM

Apr 16 2018

chill added a comment to D45524: Fix incorrect choice of callee-saved registers save/restore points.

Thanks a lot for the comments and the review.

Apr 16 2018, 10:05 AM
chill updated the diff for D45524: Fix incorrect choice of callee-saved registers save/restore points.

Added a comment; reformatted a little

Apr 16 2018, 10:00 AM

Apr 13 2018

chill added inline comments to D45524: Fix incorrect choice of callee-saved registers save/restore points.
Apr 13 2018, 10:42 AM
chill updated the diff for D45524: Fix incorrect choice of callee-saved registers save/restore points.
Apr 13 2018, 10:38 AM

Apr 11 2018

chill added inline comments to D45524: Fix incorrect choice of callee-saved registers save/restore points.
Apr 11 2018, 9:55 AM
chill created D45524: Fix incorrect choice of callee-saved registers save/restore points.
Apr 11 2018, 9:14 AM

Mar 2 2018

chill committed rL326584: [ARM] Fix access to stack arguments when re-aligning SP in Armv6m.
[ARM] Fix access to stack arguments when re-aligning SP in Armv6m
Mar 2 2018, 7:49 AM
chill closed D43566: [ARM] Fix access to stack arguments when re-aligning SP in Armv6m.
Mar 2 2018, 7:49 AM

Mar 1 2018

chill added a comment to D43566: [ARM] Fix access to stack arguments when re-aligning SP in Armv6m.

Thanks a lot for the review!

Mar 1 2018, 2:14 AM

Feb 28 2018

chill updated the diff for D43566: [ARM] Fix access to stack arguments when re-aligning SP in Armv6m.

Update:

  • refactor to use the existing ARMFrameLowering::ResolveFrameIndexReference.
  • small tweak to the latter to better accommodate T1.
Feb 28 2018, 6:11 AM

Feb 21 2018

chill added a reviewer for D43566: [ARM] Fix access to stack arguments when re-aligning SP in Armv6m: grosbach.
Feb 21 2018, 7:57 AM
chill created D43566: [ARM] Fix access to stack arguments when re-aligning SP in Armv6m.
Feb 21 2018, 4:18 AM

Feb 15 2018

chill committed rL325234: [DebugInfo] Accept enumeration types without underlying integer type present in.
[DebugInfo] Accept enumeration types without underlying integer type present in
Feb 15 2018, 5:32 AM
chill closed D43304: [DebugInfo] Accept enumeration types without underlying inetger type present in debug info metadata.
Feb 15 2018, 5:32 AM
chill updated the diff for D43304: [DebugInfo] Accept enumeration types without underlying inetger type present in debug info metadata.

Minor style change and added a test.

Feb 15 2018, 3:38 AM

Feb 14 2018

chill added a comment to D43304: [DebugInfo] Accept enumeration types without underlying inetger type present in debug info metadata.

I'll add a test tomorrow.

Feb 14 2018, 10:58 AM
chill created D43304: [DebugInfo] Accept enumeration types without underlying inetger type present in debug info metadata.
Feb 14 2018, 10:58 AM
chill committed rL325121: Use EXPECT_FALSE instead of EXPECT_EQ(false, ....
Use EXPECT_FALSE instead of EXPECT_EQ(false, ...
Feb 14 2018, 5:14 AM
chill closed D43233: Use EXPECT_FALSE instead of EXPECT_EQ(false, ....
Feb 14 2018, 5:14 AM
chill added a comment to D42734: [DebugInfo] Improvements to representation of enumeration types (PR36168).

Hi, Momchil. I suspect this change caused

Assertion failed: (DTy), function constructEnumTypeDIE, file /Users/buildslave/jenkins/workspace/clang-stage1-configure-RA/llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp, line 1436.

on the build bot http://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/ For example, see http://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/8694/console

Earlier instead of assert(DTy); we had

if (DTy) {
  addType(Buffer, DTy);
  addFlag(Buffer, dwarf::DW_AT_enum_class);
}

I don't know where the bug is but maybe it makes sense to remove assertion for now and correctly handle nullptr DTy? This will unblock the build bot for others and after that you can work on better fix if required.

Feb 14 2018, 2:42 AM

Feb 13 2018

chill created D43233: Use EXPECT_FALSE instead of EXPECT_EQ(false, ....
Feb 13 2018, 6:00 AM

Feb 12 2018

chill committed rL324900: Re-commit r324490: [DebugInfo] Improvements to representation of enumeration….
Re-commit r324490: [DebugInfo] Improvements to representation of enumeration…
Feb 12 2018, 8:14 AM
chill committed rC324900: Re-commit r324490: [DebugInfo] Improvements to representation of enumeration….
Re-commit r324490: [DebugInfo] Improvements to representation of enumeration…
Feb 12 2018, 8:14 AM
chill committed rL324899: Re-commit r324489: [DebugInfo] Improvements to representation of enumeration….
Re-commit r324489: [DebugInfo] Improvements to representation of enumeration…
Feb 12 2018, 8:13 AM

Feb 7 2018

chill committed rL324511: Revert "[DebugInfo] Improvements to representation of enumeration types….
Revert "[DebugInfo] Improvements to representation of enumeration types…
Feb 7 2018, 12:31 PM
chill committed rC324508: Revert [DebugInfo] Improvements to representation of enumeration types….
Revert [DebugInfo] Improvements to representation of enumeration types…
Feb 7 2018, 11:59 AM
chill committed rL324508: Revert [DebugInfo] Improvements to representation of enumeration types….
Revert [DebugInfo] Improvements to representation of enumeration types…
Feb 7 2018, 11:59 AM
chill committed rL324490: [DebugInfo] Improvements to representation of enumeration types (PR36168).
[DebugInfo] Improvements to representation of enumeration types (PR36168)
Feb 7 2018, 8:54 AM
chill committed rC324490: [DebugInfo] Improvements to representation of enumeration types (PR36168).
[DebugInfo] Improvements to representation of enumeration types (PR36168)
Feb 7 2018, 8:54 AM
chill closed D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168).
Feb 7 2018, 8:54 AM
chill closed D42736: [DebugInfo] Improvements to representation of enumeration types (PR36168).
Feb 7 2018, 8:54 AM
chill committed rL324489: [DebugInfo] Improvements to representation of enumeration types (PR36168).
[DebugInfo] Improvements to representation of enumeration types (PR36168)
Feb 7 2018, 8:49 AM
chill closed D42734: [DebugInfo] Improvements to representation of enumeration types (PR36168).
Feb 7 2018, 8:49 AM

Feb 5 2018

chill updated the diff for D42734: [DebugInfo] Improvements to representation of enumeration types (PR36168).
Feb 5 2018, 6:55 AM