In D68916#1708356, @efriedma wrote:

Adding aliases seems like the right approach; we have aliases for a bunch of other instructions.

I'm not sure why you need the AsmMatchConverter, though; needs a comment to explain.

Why is Rt listed twice here?

In D68862#1708079, @carwil wrote:

IMHO, since reserved registes are per-function, this strongly suggests implementation as function attribute(s), rather than subtarget features (also for the pre-existing r9).

What do you mean reserved registers are per-function? That sounds like you're describing local register variables, which I don't believe Clang has any support for (and there aren't a great deal of use-cases for anyway).
We're specifically talking about global usage here.

TBH, I quite dislike the creeping abuse of SubtargetFeatures as code generation options.

Removed some accidental change.

Updated to not require dominance/post-dominance unconditionally. Removed dependency on the parent patch and will place untag
operations in front of resume, for now.

Indeed, that patch is a bit premature. I've kicked up a discussion about supplementing the (EH)ABI, and this patch need to wait for the outcome.

I hope I will be able to pick this up in the following weeks and land patches a couple of weeks later. Sorry for the delay, but priorities shift all the time ;)

Just noticed patches lack context. Will upload a new version.

LGTM

In D36562#1641930, @wmi wrote:

In D36562#1639441, @chill wrote:

Shouldn't we disable OPT_ffine_grained_bitfield_accesses only if TSAN is active?

I don't remember why it is disabled for all sanitizer modes. Seems you are right that the disabling the option is only necessary for TSAN. Do you have actual needs for the option to be functioning on other sanitizer modes?

Shouldn't we disable OPT_ffine_grained_bitfield_accesses only if TSAN is active?

Could you, please, give some code examples of the issues that you see?

Rebase on top of master.

If there are no objections, I'll go ahead with committing that Soon(tm) on the basis of previous acceptance.

Done, thanks!

Ping?

Changed tcancel implementation.

I reverted the patch, have to rework tcancel.