Page MenuHomePhabricator

chill (Momchil Velikov)
User

Projects

User does not belong to any projects.

User Details

User Since
May 24 2017, 3:29 AM (212 w, 5 d)

Recent Activity

Sat, Jun 12

chill edited reviewers for D104123: [llvm][AArch64] Handle arrays of struct properly (from IR), added: t.p.northover, psmith, efriedma, chill; removed: momchil.velikov.

I think this change make sense. I wouldn't worry about the AAPCS64 compliance as long as the (implicit, ill-defined) "LLVM IR PCS" is flexible enough, so as to allow implementing AAPCS64.
Perhaps it's useful to have more tests, on both sides of the calls and returns:

Sat, Jun 12, 8:06 AM · Restricted Project

Wed, Jun 9

chill accepted D103167: [ARM] Fix Machine Outliner LDRD/STRD handling in Thumb mode.
Wed, Jun 9, 4:47 AM · Restricted Project

Mon, Jun 7

chill added a comment to D103167: [ARM] Fix Machine Outliner LDRD/STRD handling in Thumb mode.

@efriedma, @chill is this patch ok for you ? (it'd be great to have the issue fixed into 12.0.1 release)

Mon, Jun 7, 6:28 AM · Restricted Project

Wed, Jun 2

chill added inline comments to D103167: [ARM] Fix Machine Outliner LDRD/STRD handling in Thumb mode.
Wed, Jun 2, 7:46 AM · Restricted Project
chill added inline comments to D103167: [ARM] Fix Machine Outliner LDRD/STRD handling in Thumb mode.
Wed, Jun 2, 5:53 AM · Restricted Project

Tue, Jun 1

chill added reviewers for D103080: [CMake] Ignore arm_*.h for non-ARM build: efriedma, t.p.northover.
Tue, Jun 1, 8:15 AM · Restricted Project
chill added a comment to D103080: [CMake] Ignore arm_*.h for non-ARM build.

IMHO, it's possible to write a frontend test, which includes, say arm_neon.h, but does not really require the ARM or AArch64 backends to be configured (e.g. CodeGen/arm-vector-align.c?)
If arm_neon.h is not built, then the test would need the appropriate REQUIRES line, but than that means the frontend test coverage would decrease for people, who
are not interested in Arm backends. Mind you, even if a test is Arm specific, that does not mean it does not depend on generic code.

Tue, Jun 1, 8:15 AM · Restricted Project

Tue, May 25

chill committed rG21aa107eb79f: Reland "Do not create LLVM IR `constant`s for objects with dynamic… (authored by chill).
Reland "Do not create LLVM IR `constant`s for objects with dynamic…
Tue, May 25, 7:56 AM
chill closed D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation.
Tue, May 25, 7:55 AM · Restricted Project
chill updated the diff for D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation.

Updated a test to run for x86_64-linux instead of %itanium_abi_triple, to avoid having invalid
syntax for MACH-O sections. The patch itself does not care about section attribute syntax and x86 target
does not even need to be compiled.

Tue, May 25, 4:26 AM · Restricted Project
chill planned changes to D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation.
Tue, May 25, 1:29 AM · Restricted Project
chill reopened D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation.
Tue, May 25, 1:29 AM · Restricted Project
chill added a comment to D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation.

Thanks, I'll have a look.

Tue, May 25, 1:29 AM · Restricted Project

Mon, May 24

chill committed rG13dd65b3a1a3: Do not create LLVM IR `constant`s for objects with dynamic initialisation (authored by chill).
Do not create LLVM IR `constant`s for objects with dynamic initialisation
Mon, May 24, 2:05 PM
chill closed D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation.
Mon, May 24, 2:05 PM · Restricted Project
chill updated the diff for D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation.

Moved a test from here to there, and did a few test tweaks, NFC.

Mon, May 24, 7:34 AM · Restricted Project

May 21 2021

chill accepted D102903: [clang] Fix Wnested-anon-types in ABIArgInfo .

LGTM, cheers!

May 21 2021, 1:49 AM · Restricted Project

May 18 2021

chill added a comment to D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation.

Once test accidentally copied to the wrong directory, I'm going to fix that.

May 18 2021, 8:27 AM · Restricted Project
chill requested review of D102693: Do not create LLVM IR `constant`s for objects with dynamic initialisation.
May 18 2021, 8:26 AM · Restricted Project

May 10 2021

chill committed rG5c7b43aa8298: [clang][AArch32] Correctly align HA arguments when passed on the stack (authored by chill).
[clang][AArch32] Correctly align HA arguments when passed on the stack
May 10 2021, 8:29 AM
chill closed D100853: [clang][AArch32] Correctly align HA arguments when passed on the stack.
May 10 2021, 8:29 AM · Restricted Project, Restricted Project
chill added a comment to D100853: [clang][AArch32] Correctly align HA arguments when passed on the stack.

lgtm

Sorry about the delay.

May 10 2021, 5:49 AM · Restricted Project, Restricted Project
chill committed rGf3139b20a0bf: [GlobalISel] Fix wrong invocation of `getParamStackAlign` (NFC) (authored by chill).
[GlobalISel] Fix wrong invocation of `getParamStackAlign` (NFC)
May 10 2021, 4:18 AM
chill closed D102004: [GlobalISel] Fix wrong invocation of `getParamStackAlign` (NFC).
May 10 2021, 4:17 AM · Restricted Project

May 7 2021

chill added a comment to D102004: [GlobalISel] Fix wrong invocation of `getParamStackAlign` (NFC).

Thanks!

May 7 2021, 8:43 AM · Restricted Project

May 6 2021

chill added reviewers for D102004: [GlobalISel] Fix wrong invocation of `getParamStackAlign` (NFC): t.p.northover, arsenm.
May 6 2021, 10:07 AM · Restricted Project
chill requested review of D102004: [GlobalISel] Fix wrong invocation of `getParamStackAlign` (NFC).
May 6 2021, 10:04 AM · Restricted Project

May 5 2021

chill added a comment to D100853: [clang][AArch32] Correctly align HA arguments when passed on the stack.

Ping?

May 5 2021, 9:10 AM · Restricted Project, Restricted Project

May 4 2021

chill added inline comments to D101164: [CodeGen][ARM] Implement atomicrmw as pseudo operations at -O0.
May 4 2021, 6:52 AM · Restricted Project

Apr 27 2021

chill updated the diff for D100853: [clang][AArch32] Correctly align HA arguments when passed on the stack.

Rebase/retested on top of main

Apr 27 2021, 8:36 AM · Restricted Project, Restricted Project

Apr 20 2021

chill requested review of D100853: [clang][AArch32] Correctly align HA arguments when passed on the stack.
Apr 20 2021, 7:21 AM · Restricted Project, Restricted Project
chill added a comment to D100332: [CSSPGO] Flip SkipPseudoOp to true for MIR APIs..

Apologies if you're already aware.

Apr 20 2021, 7:02 AM · Restricted Project

Apr 15 2021

chill committed rGf9d932e6735a: [clang][AArch64] Correctly align HFA arguments when passed on the stack (authored by chill).
[clang][AArch64] Correctly align HFA arguments when passed on the stack
Apr 15 2021, 2:59 PM
chill closed D98794: [AArch64] Correctly align HFA arguments when passed on the stack.
Apr 15 2021, 2:58 PM · Restricted Project, Restricted Project
chill updated the diff for D98794: [AArch64] Correctly align HFA arguments when passed on the stack.

Fixed a merge conflict with https://reviews.llvm.org/D100467

Apr 15 2021, 2:32 PM · Restricted Project, Restricted Project

Apr 14 2021

chill committed rGa0124f4e4ded: Remove deprecated member functions (NFC) (authored by chill).
Remove deprecated member functions (NFC)
Apr 14 2021, 11:11 AM
chill closed D99098: Remove deprecated member functions (NFC).
Apr 14 2021, 11:10 AM · Restricted Project
chill updated the diff for D98794: [AArch64] Correctly align HFA arguments when passed on the stack.

Updated with only whitespace changes.

Apr 14 2021, 8:50 AM · Restricted Project, Restricted Project
chill added a comment to D99098: Remove deprecated member functions (NFC).

Thank you for the clean up. Really appreciate it.
Before submitting the patch did you check that there are no users in experimental targets? (ARC, VE)

Apr 14 2021, 5:51 AM · Restricted Project

Apr 13 2021

chill added reviewers for D99098: Remove deprecated member functions (NFC): t.p.northover, gchatelet.
Apr 13 2021, 11:11 AM · Restricted Project
chill requested review of D98794: [AArch64] Correctly align HFA arguments when passed on the stack.
Apr 13 2021, 10:48 AM · Restricted Project, Restricted Project
chill added a comment to D98794: [AArch64] Correctly align HFA arguments when passed on the stack.
Apr 13 2021, 10:48 AM · Restricted Project, Restricted Project
chill added reviewers for D100397: Add alignment argument to the byval attribute (prototype): rnk, jdoerfert, peter.smith, t.p.northover.
Apr 13 2021, 10:46 AM · Restricted Project
chill planned changes to D100397: Add alignment argument to the byval attribute (prototype).
Apr 13 2021, 10:42 AM · Restricted Project
chill requested review of D100397: Add alignment argument to the byval attribute (prototype).
Apr 13 2021, 10:41 AM · Restricted Project

Apr 9 2021

chill committed rGacf3279a037f: For non-null pointer checks, do not descend through out-of-bounds GEPs (authored by chill).
For non-null pointer checks, do not descend through out-of-bounds GEPs
Apr 9 2021, 6:09 AM
chill closed D99642: For non-null pointer checks, do not descend through out-of-bounds GEPs.
Apr 9 2021, 6:09 AM · Restricted Project
chill added a comment to D99642: For non-null pointer checks, do not descend through out-of-bounds GEPs.

I did minor test updates, following reviewers' suggestions, don't think another review is warranted, going to commit.

Apr 9 2021, 3:05 AM · Restricted Project

Apr 8 2021

chill updated the diff for D99642: For non-null pointer checks, do not descend through out-of-bounds GEPs.
Apr 8 2021, 5:31 AM · Restricted Project

Apr 7 2021

chill added a comment to D99642: For non-null pointer checks, do not descend through out-of-bounds GEPs.

I think this should be using Val->stripInBoundsOffsets() rather than modify the getUnderlyingObject() API.

Apr 7 2021, 8:48 AM · Restricted Project
chill updated the diff for D99642: For non-null pointer checks, do not descend through out-of-bounds GEPs.
Apr 7 2021, 8:45 AM · Restricted Project
chill planned changes to D98794: [AArch64] Correctly align HFA arguments when passed on the stack.

This needs to be changed, cf. https://lists.llvm.org/pipermail/llvm-dev/2021-March/149405.html

Apr 7 2021, 5:52 AM · Restricted Project, Restricted Project

Mar 31 2021

chill added reviewers for D99642: For non-null pointer checks, do not descend through out-of-bounds GEPs: nikic, lebedev.ri.
Mar 31 2021, 1:45 AM · Restricted Project
chill requested review of D99642: For non-null pointer checks, do not descend through out-of-bounds GEPs.
Mar 31 2021, 1:43 AM · Restricted Project

Mar 22 2021

chill updated the diff for D98794: [AArch64] Correctly align HFA arguments when passed on the stack.
Mar 22 2021, 11:54 AM · Restricted Project, Restricted Project
chill requested review of D99098: Remove deprecated member functions (NFC).
Mar 22 2021, 11:26 AM · Restricted Project
chill planned changes to D98794: [AArch64] Correctly align HFA arguments when passed on the stack.
Mar 22 2021, 7:33 AM · Restricted Project, Restricted Project
chill added inline comments to D98794: [AArch64] Correctly align HFA arguments when passed on the stack.
Mar 22 2021, 4:41 AM · Restricted Project, Restricted Project

Mar 18 2021

chill accepted D98853: [test] Fix incorrect use of string variable use.
Mar 18 2021, 4:13 AM · Restricted Project

Mar 17 2021

chill updated the diff for D98794: [AArch64] Correctly align HFA arguments when passed on the stack.
Mar 17 2021, 10:28 AM · Restricted Project, Restricted Project
chill added reviewers for D98794: [AArch64] Correctly align HFA arguments when passed on the stack: t.p.northover, rnk, jdoerfert, ostannard, bogner, pratlucas, psmith.
Mar 17 2021, 10:26 AM · Restricted Project, Restricted Project
chill requested review of D98794: [AArch64] Correctly align HFA arguments when passed on the stack.
Mar 17 2021, 10:25 AM · Restricted Project, Restricted Project

Feb 5 2021

chill added inline comments to D75903: [AArch64][CodeGen] Fixing stack alignment of HFA arguments on AArch64 PCS.
Feb 5 2021, 1:49 AM · Restricted Project, Restricted Project

Jan 8 2021

chill added a comment to D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension..

FWIW I think it would be good to have a bit more details in the description for changes such as this, like a link to the public docs for the extension.

Jan 8 2021, 7:24 AM · Restricted Project, Restricted Project

Jan 6 2021

chill accepted D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension..

LGTM

Jan 6 2021, 4:49 AM · Restricted Project, Restricted Project

Jan 5 2021

chill accepted D94081: [AArch64] Add +flagm archictecture option, allowing the v8.4a flag modification extension..

LGTM.

Jan 5 2021, 6:51 AM · Restricted Project, Restricted Project
chill added a reviewer for D94081: [AArch64] Add +flagm archictecture option, allowing the v8.4a flag modification extension.: chill.
Jan 5 2021, 6:51 AM · Restricted Project, Restricted Project
chill added reviewers for D94083: [AArch64] Add +pauth archictecture option, allowing the v8.3a pointer authentication extension.: ab, chill.
Jan 5 2021, 6:21 AM · Restricted Project, Restricted Project

Dec 29 2020

chill added inline comments to D93899: [AArch64] Add BRB IALL and BRB INJ instructions.
Dec 29 2020, 9:22 AM · Restricted Project

Dec 21 2020

chill added a comment to D65280: Add a pass to lower is.constant and objectsize intrinsics.

FYI: https://bugs.llvm.org/show_bug.cgi?id=48472

Dec 21 2020, 1:47 AM · Restricted Project

Nov 30 2020

chill added inline comments to D91994: [AArch64] Cortex-R82: remove crypto.
Nov 30 2020, 1:48 AM · Restricted Project, Restricted Project
chill added inline comments to D91994: [AArch64] Cortex-R82: remove crypto.
Nov 30 2020, 1:47 AM · Restricted Project, Restricted Project
chill added a comment to D91994: [AArch64] Cortex-R82: remove crypto.

In the Arm Architecture Reference Manual Supplement - Armv8, for Armv8-R AArch64 architecture profile
"A1.4 Architecture extensions" lists among others

  • FEAT_SHA1 Advanced SIMD SHA1 instructions
  • FEAT_SHA256 Advanced SIMD SHA256 instructions
  • FEAT_AES Advanced SIMD AES instructions
  • FEAT_PMULL Advanced SIMD PMULL instructions

Is there a document, which says R82 does not implement those ?

Nov 30 2020, 1:44 AM · Restricted Project, Restricted Project
chill edited reviewers for D91994: [AArch64] Cortex-R82: remove crypto, added: chill; removed: momchil.velikov.
Nov 30 2020, 1:31 AM · Restricted Project, Restricted Project
chill added a comment to D91994: [AArch64] Cortex-R82: remove crypto.

In the Arm Architecture Reference Manual Supplement - Armv8, for Armv8-R AArch64 architecture profile
"A1.4 Architecture extensions" lists among others

Nov 30 2020, 1:30 AM · Restricted Project, Restricted Project

Nov 13 2020

chill accepted D91438: [AArch64] Define __ARM_FEATURE_{CRC32,ATOMICS}.

LGTM, thanks.

Nov 13 2020, 9:42 AM · Restricted Project
chill added a reviewer for D91438: [AArch64] Define __ARM_FEATURE_{CRC32,ATOMICS}: chill.
Nov 13 2020, 9:11 AM · Restricted Project

Nov 9 2020

chill committed rG937ab6a7853d: [ARM][MachineOutliner] Emit more CFI instructions (authored by chill).
[ARM][MachineOutliner] Emit more CFI instructions
Nov 9 2020, 7:26 AM
chill closed D89483: [ARM][MachineOutliner] Emit more CFI instructions.
Nov 9 2020, 7:26 AM · Restricted Project
chill added a comment to D89483: [ARM][MachineOutliner] Emit more CFI instructions.

Thanks!

Nov 9 2020, 1:23 AM · Restricted Project
chill updated the diff for D89483: [ARM][MachineOutliner] Emit more CFI instructions.
Nov 9 2020, 1:23 AM · Restricted Project

Nov 7 2020

chill updated the diff for D89483: [ARM][MachineOutliner] Emit more CFI instructions.
Nov 7 2020, 2:21 AM · Restricted Project

Nov 6 2020

chill planned changes to D89483: [ARM][MachineOutliner] Emit more CFI instructions.
Nov 6 2020, 3:12 AM · Restricted Project

Nov 5 2020

chill committed rG5b30d9adc053: [MachineOutliner] Do not outline debug instructions (authored by chill).
[MachineOutliner] Do not outline debug instructions
Nov 5 2020, 11:27 AM
chill closed D89485: [MachineOutliner] Do not outline debug instructions.
Nov 5 2020, 11:27 AM · Restricted Project
chill added a comment to D89485: [MachineOutliner] Do not outline debug instructions.

Cheers!

Nov 5 2020, 10:51 AM · Restricted Project
chill committed rG35d625125465: Add default value for MachineInstr::modifiesRegister. NFC. (authored by chill).
Add default value for MachineInstr::modifiesRegister. NFC.
Nov 5 2020, 10:51 AM
chill closed D89625: Add default value for MachineInstr::modifiesRegister. NFC..
Nov 5 2020, 10:50 AM · Restricted Project
chill added a comment to D89625: Add default value for MachineInstr::modifiesRegister. NFC..

Cheers!

Nov 5 2020, 10:00 AM · Restricted Project

Nov 4 2020

chill added a comment to D89485: [MachineOutliner] Do not outline debug instructions.

That should be the minimum number of instructions now, one less and the outlining does not pass the cost threshold.

Nov 4 2020, 7:45 AM · Restricted Project
chill updated the diff for D89485: [MachineOutliner] Do not outline debug instructions.
Nov 4 2020, 7:44 AM · Restricted Project
chill added a comment to D89483: [ARM][MachineOutliner] Emit more CFI instructions.

Ping.

Nov 4 2020, 6:41 AM · Restricted Project

Nov 3 2020

chill updated the diff for D89485: [MachineOutliner] Do not outline debug instructions.
Nov 3 2020, 4:36 AM · Restricted Project

Nov 2 2020

chill committed rG7360d6d921c6: [ARM][MachineOutliner] Do not overestimate LR liveness in return block (authored by chill).
[ARM][MachineOutliner] Do not overestimate LR liveness in return block
Nov 2 2020, 8:48 AM
chill closed D89189: [ARM][MachineOutliner] Do not overestimate LR liveness in return block.
Nov 2 2020, 8:48 AM · Restricted Project
chill added a comment to D89625: Add default value for MachineInstr::modifiesRegister. NFC..

I'd check if there are some calls of modifiesRegister that pass nullptr, the patch LGTM otherwise

Nov 2 2020, 7:28 AM · Restricted Project
chill added a comment to D89189: [ARM][MachineOutliner] Do not overestimate LR liveness in return block.

Ping.

Nov 2 2020, 1:25 AM · Restricted Project
chill added a comment to D89485: [MachineOutliner] Do not outline debug instructions.

Ping.

Nov 2 2020, 1:24 AM · Restricted Project

Oct 28 2020

chill added a comment to D89625: Add default value for MachineInstr::modifiesRegister. NFC..

Ping.

Oct 28 2020, 2:39 AM · Restricted Project
chill added a comment to D89483: [ARM][MachineOutliner] Emit more CFI instructions.

Ping.

Oct 28 2020, 2:39 AM · Restricted Project