Page MenuHomePhabricator

chill (Momchil Velikov)
User

Projects

User does not belong to any projects.

User Details

User Since
May 24 2017, 3:29 AM (124 w, 6 d)

Recent Activity

Yesterday

chill updated the diff for D68711: Implement target(branch-protection) attribute for AArch64.
Tue, Oct 15, 3:47 AM

Mon, Oct 14

chill added a comment to D68916: [ARM] Accept ldrb.w mnemonic for certain addressing modes (PR43382).

Adding aliases seems like the right approach; we have aliases for a bunch of other instructions.

I'm not sure why you need the AsmMatchConverter, though; needs a comment to explain.

Why is Rt listed twice here?

Mon, Oct 14, 3:56 PM · Restricted Project
chill added a comment to D68862: [ARM] Allocatable Global Register Variables for ARM.

IMHO, since reserved registes are per-function, this strongly suggests implementation as function attribute(s), rather than subtarget features (also for the pre-existing r9).

What do you mean reserved registers are per-function? That sounds like you're describing local register variables, which I don't believe Clang has any support for (and there aren't a great deal of use-cases for anyway).
We're specifically talking about global usage here.

Mon, Oct 14, 9:11 AM · Restricted Project, Restricted Project

Sat, Oct 12

chill created D68916: [ARM] Accept ldrb.w mnemonic for certain addressing modes (PR43382).
Sat, Oct 12, 11:22 AM · Restricted Project

Fri, Oct 11

chill added inline comments to D68862: [ARM] Allocatable Global Register Variables for ARM.
Fri, Oct 11, 6:03 AM · Restricted Project, Restricted Project
chill added a comment to D68862: [ARM] Allocatable Global Register Variables for ARM.

TBH, I quite dislike the creeping abuse of SubtargetFeatures as code generation options.

Fri, Oct 11, 6:03 AM · Restricted Project, Restricted Project

Wed, Oct 9

chill committed rGd037a5f06538: [AArch64] Ensure no tagged memory is left in the unallocated portion of the… (authored by chill).
[AArch64] Ensure no tagged memory is left in the unallocated portion of the…
Wed, Oct 9, 9:31 AM
chill closed D68469: [AArch64] Ensure no tagged memory is left in the unallocated portion of the stack.
Wed, Oct 9, 9:31 AM · Restricted Project
chill committed rL374182: [AArch64] Ensure no tagged memory is left in the unallocated portion of the.
[AArch64] Ensure no tagged memory is left in the unallocated portion of the
Wed, Oct 9, 9:31 AM
chill updated the diff for D68711: Implement target(branch-protection) attribute for AArch64.

Removed some accidental change.

Wed, Oct 9, 9:12 AM
chill created D68711: Implement target(branch-protection) attribute for AArch64.
Wed, Oct 9, 9:03 AM

Tue, Oct 8

chill updated the diff for D68469: [AArch64] Ensure no tagged memory is left in the unallocated portion of the stack.
Tue, Oct 8, 4:07 AM · Restricted Project

Mon, Oct 7

chill removed a parent revision for D68469: [AArch64] Ensure no tagged memory is left in the unallocated portion of the stack: D68468: [AArch64] Do not untag before returning via a `resume` instruction.
Mon, Oct 7, 10:36 AM · Restricted Project
chill removed a child revision for D68468: [AArch64] Do not untag before returning via a `resume` instruction: D68469: [AArch64] Ensure no tagged memory is left in the unallocated portion of the stack.
Mon, Oct 7, 10:35 AM · Restricted Project
chill updated the diff for D68469: [AArch64] Ensure no tagged memory is left in the unallocated portion of the stack.

Updated to not require dominance/post-dominance unconditionally. Removed dependency on the parent patch and will place untag
operations in front of resume, for now.

Mon, Oct 7, 10:35 AM · Restricted Project
chill planned changes to D68468: [AArch64] Do not untag before returning via a `resume` instruction.

Indeed, that patch is a bit premature. I've kicked up a discussion about supplementing the (EH)ABI, and this patch need to wait for the outcome.

Mon, Oct 7, 3:05 AM · Restricted Project

Sun, Oct 6

chill added a comment to D62394: [ARM][CMSE] Add CMSE header & builtins.

I hope I will be able to pick this up in the following weeks and land patches a couple of weeks later. Sorry for the delay, but priorities shift all the time ;)

Sun, Oct 6, 5:51 AM
chill added a comment to D68469: [AArch64] Ensure no tagged memory is left in the unallocated portion of the stack.

Just noticed patches lack context. Will upload a new version.

Sun, Oct 6, 5:40 AM · Restricted Project

Fri, Oct 4

chill committed rL373757: Requesting commit access for chill.
Requesting commit access for chill
Fri, Oct 4, 9:31 AM
chill added reviewers for D68469: [AArch64] Ensure no tagged memory is left in the unallocated portion of the stack: eugenis, vitalybuka, ostannard.
Fri, Oct 4, 9:14 AM · Restricted Project
chill added reviewers for D68468: [AArch64] Do not untag before returning via a `resume` instruction: eugenis, vitalybuka, ostannard.
Fri, Oct 4, 9:14 AM · Restricted Project
chill added a parent revision for D68469: [AArch64] Ensure no tagged memory is left in the unallocated portion of the stack: D68468: [AArch64] Do not untag before returning via a `resume` instruction.
Fri, Oct 4, 9:05 AM · Restricted Project
chill updated the summary of D68469: [AArch64] Ensure no tagged memory is left in the unallocated portion of the stack.
Fri, Oct 4, 9:05 AM · Restricted Project
chill added a child revision for D68468: [AArch64] Do not untag before returning via a `resume` instruction: D68469: [AArch64] Ensure no tagged memory is left in the unallocated portion of the stack.
Fri, Oct 4, 9:05 AM · Restricted Project
chill created D68469: [AArch64] Ensure no tagged memory is left in the unallocated portion of the stack.
Fri, Oct 4, 9:05 AM · Restricted Project
chill created D68468: [AArch64] Do not untag before returning via a `resume` instruction.
Fri, Oct 4, 8:46 AM · Restricted Project

Mon, Sep 30

chill accepted D68090: Fix doc for t inline asm constraints for ARM/Thumb.
Mon, Sep 30, 2:01 AM · Restricted Project

Sep 13 2019

chill accepted D67542: Fix depfile name construction.

LGTM

Sep 13 2019, 3:37 AM · Restricted Project, Restricted Project
chill added a reviewer for D67542: Fix depfile name construction: chill.
Sep 13 2019, 2:50 AM · Restricted Project, Restricted Project

Aug 27 2019

chill added inline comments to rL363464: Add --print-supported-cpus flag for clang..
Aug 27 2019, 10:11 AM

Aug 23 2019

chill added a comment to D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type.
In D36562#1641930, @wmi wrote:

Shouldn't we disable OPT_ffine_grained_bitfield_accesses only if TSAN is active?

I don't remember why it is disabled for all sanitizer modes. Seems you are right that the disabling the option is only necessary for TSAN. Do you have actual needs for the option to be functioning on other sanitizer modes?

Aug 23 2019, 2:07 AM · Restricted Project

Aug 21 2019

Herald added a project to D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type: Restricted Project.

Shouldn't we disable OPT_ffine_grained_bitfield_accesses only if TSAN is active?

Aug 21 2019, 8:20 AM · Restricted Project
chill added reviewers for D66459: Make ShrinkWrap more consistent.: qcolombet, thegameg.
Aug 21 2019, 12:30 AM · Restricted Project

Aug 20 2019

chill requested changes to D66459: Make ShrinkWrap more consistent..

Could you, please, give some code examples of the issues that you see?

Aug 20 2019, 2:45 AM · Restricted Project

Aug 13 2019

chill committed rG114c37e72a5f: [ARM] Fix detection of duplicates when parsing reg list operands (authored by chill).
[ARM] Fix detection of duplicates when parsing reg list operands
Aug 13 2019, 9:13 AM
chill committed rGf990e4a4c7bc: [ARM] Fix encoding of APSR in CLRM instruction (authored by chill).
[ARM] Fix encoding of APSR in CLRM instruction
Aug 13 2019, 9:13 AM
chill committed rL368712: [ARM] Fix detection of duplicates when parsing reg list operands.
[ARM] Fix detection of duplicates when parsing reg list operands
Aug 13 2019, 9:12 AM
chill committed rL368711: [ARM] Fix encoding of APSR in CLRM instruction.
[ARM] Fix encoding of APSR in CLRM instruction
Aug 13 2019, 9:12 AM
chill closed D65957: [ARM] Fix detection of duplicates when parsing reg list operands.
Aug 13 2019, 9:12 AM · Restricted Project
chill closed D65873: [ARM] Fix encoding of APSR in CLRM instruction.
Aug 13 2019, 9:12 AM · Restricted Project
chill committed rG941660299ac6: Enable memtag sanitizer in all AArch64 toolchains (authored by chill).
Enable memtag sanitizer in all AArch64 toolchains
Aug 13 2019, 7:20 AM
chill committed rG5b25674b7307: [AArch64] Make the memtag sanitizer require the memtag extension (authored by chill).
[AArch64] Make the memtag sanitizer require the memtag extension
Aug 13 2019, 7:20 AM
chill committed rL368697: Enable memtag sanitizer in all AArch64 toolchains.
Enable memtag sanitizer in all AArch64 toolchains
Aug 13 2019, 7:20 AM
chill closed D65642: Enable memtag sanitizer in all AArch64 toolchains .
Aug 13 2019, 7:20 AM · Restricted Project
chill committed rL368696: [AArch64] Make the memtag sanitizer require the memtag extension.
[AArch64] Make the memtag sanitizer require the memtag extension
Aug 13 2019, 7:20 AM
chill closed D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Aug 13 2019, 7:20 AM · Restricted Project

Aug 9 2019

chill added inline comments to D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Aug 9 2019, 9:22 AM · Restricted Project
chill updated the diff for D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Aug 9 2019, 9:22 AM · Restricted Project

Aug 8 2019

chill updated the diff for D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Aug 8 2019, 10:39 AM · Restricted Project
chill added a parent revision for D65957: [ARM] Fix detection of duplicates when parsing reg list operands: D65873: [ARM] Fix encoding of APSR in CLRM instruction.
Aug 8 2019, 9:09 AM · Restricted Project
chill added a reviewer for D65873: [ARM] Fix encoding of APSR in CLRM instruction: ostannard.
Aug 8 2019, 9:09 AM · Restricted Project
chill created D65957: [ARM] Fix detection of duplicates when parsing reg list operands.
Aug 8 2019, 9:09 AM · Restricted Project
chill added a child revision for D65873: [ARM] Fix encoding of APSR in CLRM instruction: D65957: [ARM] Fix detection of duplicates when parsing reg list operands.
Aug 8 2019, 9:09 AM · Restricted Project

Aug 7 2019

chill added a reviewer for D65873: [ARM] Fix encoding of APSR in CLRM instruction: simon_tatham.
Aug 7 2019, 7:44 AM · Restricted Project
chill updated the summary of D65873: [ARM] Fix encoding of APSR in CLRM instruction.
Aug 7 2019, 7:43 AM · Restricted Project
chill created D65873: [ARM] Fix encoding of APSR in CLRM instruction.
Aug 7 2019, 7:43 AM · Restricted Project
chill added inline comments to D62667: [ARM] Add the non-MVE instructions in Arm v8.1-M..
Aug 7 2019, 3:58 AM · Restricted Project

Aug 6 2019

chill updated the diff for D65642: Enable memtag sanitizer in all AArch64 toolchains .
Aug 6 2019, 9:05 AM · Restricted Project
chill added inline comments to D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Aug 6 2019, 7:02 AM · Restricted Project
chill added inline comments to D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Aug 6 2019, 7:00 AM · Restricted Project
chill updated the diff for D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Aug 6 2019, 7:00 AM · Restricted Project

Aug 5 2019

chill added a reviewer for D65508: [AArch64] Make the memtag sanitizer require the memtag extension: vitalybuka.
Aug 5 2019, 2:33 AM · Restricted Project
chill added a reviewer for D65642: Enable memtag sanitizer in all AArch64 toolchains : vitalybuka.
Aug 5 2019, 2:33 AM · Restricted Project

Aug 2 2019

chill added a reviewer for D65642: Enable memtag sanitizer in all AArch64 toolchains : eugenis.
Aug 2 2019, 2:31 AM · Restricted Project
chill added a child revision for D65508: [AArch64] Make the memtag sanitizer require the memtag extension: D65642: Enable memtag sanitizer in all AArch64 toolchains .
Aug 2 2019, 2:31 AM · Restricted Project
chill created D65642: Enable memtag sanitizer in all AArch64 toolchains .
Aug 2 2019, 2:31 AM · Restricted Project
chill added a parent revision for D65642: Enable memtag sanitizer in all AArch64 toolchains : D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Aug 2 2019, 2:31 AM · Restricted Project

Jul 31 2019

chill committed rGa36d31478c18: [AArch64] Add support for Transactional Memory Extension (TME) (authored by chill).
[AArch64] Add support for Transactional Memory Extension (TME)
Jul 31 2019, 5:54 AM
chill committed rL367428: [AArch64] Add support for Transactional Memory Extension (TME).
[AArch64] Add support for Transactional Memory Extension (TME)
Jul 31 2019, 5:53 AM
chill closed D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 31 2019, 5:53 AM · Restricted Project
chill added a reviewer for D65508: [AArch64] Make the memtag sanitizer require the memtag extension: eugenis.
Jul 31 2019, 5:26 AM · Restricted Project
chill created D65508: [AArch64] Make the memtag sanitizer require the memtag extension.
Jul 31 2019, 5:25 AM · Restricted Project

Jul 30 2019

chill updated the diff for D64416: [AArch64] Add support for Transactional Memory Extension (TME).

Rebase on top of master.

Jul 30 2019, 6:43 AM · Restricted Project
chill accepted D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 30 2019, 4:03 AM · Restricted Project

Jul 29 2019

chill edited reviewers for D65404: [AArch64] Disable __ARM_FEATURE_SVE without ACLE., added: ktkachov; removed: chill.
Jul 29 2019, 10:09 AM · Restricted Project
chill added a comment to D64416: [AArch64] Add support for Transactional Memory Extension (TME).

If there are no objections, I'll go ahead with committing that Soon(tm) on the basis of previous acceptance.

Jul 29 2019, 7:36 AM · Restricted Project

Jul 26 2019

chill committed rG898d953693ff: [AArch64] Define ETE and TRBE system registers (authored by chill).
[AArch64] Define ETE and TRBE system registers
Jul 26 2019, 2:20 AM
chill committed rL367093: [AArch64] Define ETE and TRBE system registers.
[AArch64] Define ETE and TRBE system registers
Jul 26 2019, 2:19 AM
chill closed D63707: [AArch64] Define ETE and TRBE system registers.
Jul 26 2019, 2:19 AM · Restricted Project

Jul 25 2019

chill added a comment to D63707: [AArch64] Define ETE and TRBE system registers.

Done, thanks!

Jul 25 2019, 8:57 AM · Restricted Project
chill updated the diff for D63707: [AArch64] Define ETE and TRBE system registers.
Jul 25 2019, 8:57 AM · Restricted Project
chill committed rGa655f476b0eb: [AArch64][SVE] Allow explicit size specifier for predicate operand (authored by chill).
[AArch64][SVE] Allow explicit size specifier for predicate operand
Jul 25 2019, 6:57 AM
chill committed rL367019: [AArch64][SVE] Allow explicit size specifier for predicate operand.
[AArch64][SVE] Allow explicit size specifier for predicate operand
Jul 25 2019, 6:55 AM
chill closed D65145: [AArch64][SVE] Allow explicit size specifier for predicate operand.
Jul 25 2019, 6:55 AM · Restricted Project
chill updated the diff for D65145: [AArch64][SVE] Allow explicit size specifier for predicate operand.
Jul 25 2019, 6:24 AM · Restricted Project
chill added a comment to D63707: [AArch64] Define ETE and TRBE system registers.

Ping?

Jul 25 2019, 2:52 AM · Restricted Project

Jul 23 2019

chill added reviewers for D65145: [AArch64][SVE] Allow explicit size specifier for predicate operand: sdesmalen, c-rhodes, t.p.northover.
Jul 23 2019, 7:04 AM · Restricted Project
chill created D65145: [AArch64][SVE] Allow explicit size specifier for predicate operand.
Jul 23 2019, 7:04 AM · Restricted Project

Jul 22 2019

chill requested review of D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 22 2019, 10:23 AM · Restricted Project
chill updated the diff for D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 22 2019, 10:19 AM · Restricted Project

Jul 19 2019

chill planned changes to D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 19 2019, 6:08 AM · Restricted Project
chill requested review of D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 19 2019, 1:39 AM · Restricted Project
chill updated the diff for D64416: [AArch64] Add support for Transactional Memory Extension (TME).

Changed tcancel implementation.

Jul 19 2019, 1:39 AM · Restricted Project

Jul 18 2019

chill planned changes to D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 18 2019, 1:45 AM · Restricted Project
chill reopened D64416: [AArch64] Add support for Transactional Memory Extension (TME).

I reverted the patch, have to rework tcancel.

Jul 18 2019, 1:45 AM · Restricted Project

Jul 17 2019

chill committed rL366355: Revert [AArch64] Add support for Transactional Memory Extension (TME).
Revert [AArch64] Add support for Transactional Memory Extension (TME)
Jul 17 2019, 10:45 AM
chill committed rG0e2b74a2b0b8: Revert [AArch64] Add support for Transactional Memory Extension (TME) (authored by chill).
Revert [AArch64] Add support for Transactional Memory Extension (TME)
Jul 17 2019, 10:45 AM
chill committed rG4b8da3a503e4: [AArch64] Add support for Transactional Memory Extension (TME) (authored by chill).
[AArch64] Add support for Transactional Memory Extension (TME)
Jul 17 2019, 6:24 AM
chill committed rL366322: [AArch64] Add support for Transactional Memory Extension (TME).
[AArch64] Add support for Transactional Memory Extension (TME)
Jul 17 2019, 6:23 AM
chill closed D64416: [AArch64] Add support for Transactional Memory Extension (TME).
Jul 17 2019, 6:23 AM · Restricted Project