Once the new option parsing system is committed, this will allow to generate a
check to ensure that correct command line generation happens
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Looks like this broke tests on windows: http://45.33.8.238/win/23171/step_7.txt
Please take a look, and if it takes a while to fix, please revert for now.
I have reverted this change in 8d2d0e84857cb1f2d01456eb433b5172d3a0772b to get the build bots green again.
Thanks for the revert.
In addition to the one eabi test, we saw widespread msan use-of-uninitialized-value errors from here: https://github.com/llvm/llvm-project/blob/master/llvm/lib/Target/ARM/ARMTargetMachine.cpp#L229. I think it would explain the eabi test failure.
Just to also jump in on the thread: This broke the modules builds. I fixed that in https://reviews.llvm.org/rGe0e7eb2e2648aee83caf2ecfe2972ce2f653d306 so please recommit that patch or merge it into this revision before relanding. Thanks!
Yes of course. This is a prerequisite for some other changes that are waiting to land and need polishing. Thanks for doing the revert. I will investigate the failures and recommit it when appropriate.