User Details
User Details
- User Since
- Mar 23 2016, 8:38 AM (117 w, 1 d)
Tue, Jun 19
Tue, Jun 19
Refactor OnExit utility class in ClangUserExpression
This revision was not accepted when it landed; it landed in state Needs Review.
teemperor updated the diff for D48303: Don't take the address of an xvalue when printing an expr result.
- Generalized test case a bit more and no longer checking only for 0.
Mon, Jun 18
Mon, Jun 18
teemperor added a reviewer for D48303: Don't take the address of an xvalue when printing an expr result: jingham.
teemperor updated the diff for D48303: Don't take the address of an xvalue when printing an expr result.
- Removed now unnecessary brackets.
teemperor updated the diff for D48303: Don't take the address of an xvalue when printing an expr result.
- Added test case
teemperor planned changes to D48303: Don't take the address of an xvalue when printing an expr result.
- Needs a test
Fixed file completion for paths that start with '~'.
Wed, Jun 13
Wed, Jun 13
Add modules support for lldb headers in include/
teemperor updated the diff for D47929: Add modules support for lldb headers in include/.
- Finally found the one and only way to spell "Objective-C++"
Tue, Jun 12
Tue, Jun 12
teemperor updated the diff for D47929: Add modules support for lldb headers in include/.
- The regex that removes the modules cache now actually removes the whole flag + path.
- Fixed more typos.
Disable warnings for the generated LLDB wrapper source
Added missing include to AMDHSAKernelDescriptor.h
teemperor committed rL334549: Added modulemap for lldb-mi.
Added modulemap for lldb-mi
teemperor updated subscribers of D47996: Added modulemap for lldb-mi.
- Fixed mailing list subscriber.
teemperor updated the diff for D47929: Add modules support for lldb headers in include/.
- Fixed a typo.
teemperor updated the diff for D47929: Add modules support for lldb headers in include/.
- Obj-C -> Obj-C++
It seems people are also in favor of completely disabling the warnings, so that patch will replace this one.
teemperor retitled D47996: Added modulemap for lldb-mi from Added modulemap for lldb mi to Added modulemap for lldb-mi.
teemperor added inline comments to D47929: Add modules support for lldb headers in include/.
teemperor updated the diff for D47929: Add modules support for lldb headers in include/.
- All Obj-C files are now in their own subdirectory. This way we can filter out the modules flags for them.
teemperor planned changes to D47929: Add modules support for lldb headers in include/.
It seems the compilation fails on OS X with this modulemap (or any modulemap). The reason seems to be that on OS X we compile Obj-C++ as part of lldb which assumes that Clang/LLVM is valid Obj-C++. However, the Obj-C parsing code in Clang is *not* valid Obj-C++ as some parts of the code use variables named like IBAction for describing, well, IBAction in Obj-C.
Mon, Jun 11
Mon, Jun 11
Fix that AlignedAllocation.h doesn't compile because of VersionTuple
Fix that AlignedAllocation.h doesn't compile because of VersionTuple
This revision was not accepted when it landed; it landed in state Needs Review.
Sun, Jun 10
Sun, Jun 10
Fri, Jun 8
Fri, Jun 8
teemperor updated the diff for D47929: Add modules support for lldb headers in include/.
- Removed some inconsistent white space.
teemperor added a comment to D47929: Add modules support for lldb headers in include/.
@aprantl It's good for build times and more importantly it's consistent with the way Clang/LLVM are naming/organizing their modules. But I actually don't have a strong opinion on how the modules are named/organized.
Thu, Jun 7
Thu, Jun 7
teemperor updated subscribers of D47929: Add modules support for lldb headers in include/.
teemperor added a comment to D47929: Add modules support for lldb headers in include/.
I generated a report for the remaining cyclic dependencies in the lldb module here.
Added missing include to LoadedModuleInfoList.h
This revision was not accepted when it landed; it landed in state Needs Review.
Sun, May 27
Sun, May 27
Fix memory leak in SubsPrimitiveParmItanium
This revision was not accepted when it landed; it landed in state Needs Review.
Sat, May 26
Sat, May 26
Add missing includes to some LLDB headers.
This revision was not accepted when it landed; it landed in state Needs Review.
teemperor committed rL333343: Don't include headers from inside a namespace in MIUtilSingletonHelper.h.
Don't include headers from inside a namespace in MIUtilSingletonHelper.h
This revision was not accepted when it landed; it landed in state Needs Review.
Forward declare DumpValueObjectOptions in ValueObject.h
This revision was not accepted when it landed; it landed in state Needs Review.
Wed, May 23
Wed, May 23
[modules] Mark __wmmintrin_pclmul.h/__wmmintrin_aes.h as textual
[modules] Mark __wmmintrin_pclmul.h/__wmmintrin_aes.h as textual
teemperor edited reviewers for D47277: [modules] Mark __wmmintrin_pclmul.h/__wmmintrin_aes.h as textual, added: v.g.vassilev; removed: slydiman.
(Wrong Vassil, sorry)
Fix unaligned memory access when reading INPUT_FILE_OFFSETS data
Fix unaligned memory access when reading INPUT_FILE_OFFSETS data
Tue, May 22
Tue, May 22
May 21 2018
May 21 2018
Add missing include for cstdint to Visibility.h
Add missing include for cstdint to Visibility.h
This revision was not accepted when it landed; it landed in state Needs Review.
Apr 27 2018
Apr 27 2018
Make MultiplexASTDeserializationListener part of the API [NFC]
Make MultiplexASTDeserializationListener part of the API [NFC]
Mar 27 2018
Mar 27 2018
teemperor added inline comments to D39714: [modules] Move generation counter from ExternalASTSource to ASTContext.
teemperor updated the diff for D43871: [modules] No longer include stdlib.h from mm_malloc.h..
- Added more test cases for reverse include order and clang modules.
Mar 7 2018
Mar 7 2018
LGTM!
Mar 5 2018
Mar 5 2018
Including <functional> for std::bind
This revision was not accepted when it landed; it landed in state Needs Review.
Mar 3 2018
Mar 3 2018
As this will land in clang 7, can you add a note to the release notes that this breaks backwards compatibility for this interface (can be another commit)? Also, we should point out that this is the only API change this interface will have in the foreseeable future.
Feb 28 2018
Feb 28 2018
LGTM!
Feb 27 2018
Feb 27 2018
teemperor requested changes to D43809: Add possibility to specify output stream for CompilerInstance.
See the inline comments. Please run clang-format over this patch after addressing them (there are a few indentation issues).
Feb 11 2018
Feb 11 2018
teemperor updated the diff for D39714: [modules] Move generation counter from ExternalASTSource to ASTContext.
Jan 24 2018
Jan 24 2018
Refactor RecursiveASTVisitor test for post-order traversal
Refactor RecursiveASTVisitor test for post-order traversal
This revision was not accepted when it landed; it landed in state Needs Review.
teemperor updated the diff for D37557: Refactor RecursiveASTVisitor test for post-order traversal.
- Rebased and clang formatted.
Jan 23 2018
Jan 23 2018
teemperor committed rL323197: Fix memory leaks in GoParser.
Fix memory leaks in GoParser
Prevent unaligned memory read in parseMinidumpString
Jan 22 2018
Jan 22 2018
Fix memory leak in TestClangASTContext.TestRecordHasFields
This revision was not accepted when it landed; it landed in state Needs Review.
teemperor committed rL323122: [modules] Correctly overload getModule in the MultiplexExternalSemaSource.
[modules] Correctly overload getModule in the MultiplexExternalSemaSource
teemperor committed rC323122: [modules] Correctly overload getModule in the MultiplexExternalSemaSource.
[modules] Correctly overload getModule in the MultiplexExternalSemaSource