Page MenuHomePhabricator

teemperor (Raphael Isemann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 23 2016, 8:38 AM (142 w, 5 d)

Recent Activity

Tue, Dec 11

teemperor added a comment to D43871: [modules] No longer include stdlib.h from mm_malloc.h..

@joerg Yeah, we saw the commit explaining why the original fwd declaration patch was reverted. However, from what I can see, we only have three ways to fix the cyclic dependency between glibc and Clang's internal module:

Tue, Dec 11, 10:45 AM

Mon, Dec 10

teemperor committed rL348755: Misc typos fixes in ./lib folder.
Misc typos fixes in ./lib folder
Mon, Dec 10, 4:41 AM
teemperor committed rC348755: Misc typos fixes in ./lib folder.
Misc typos fixes in ./lib folder
Mon, Dec 10, 4:41 AM
teemperor closed D55475: Misc typos fixes in ./lib folder.
Mon, Dec 10, 4:41 AM

Sun, Dec 9

teemperor accepted D55475: Misc typos fixes in ./lib folder.

This looks all good to me and from what see this was requested in a previous review (D44188). Do you need someone to commit this or did you receive commit access?

Sun, Dec 9, 6:34 AM

Sat, Dec 8

teemperor resigned from D55475: Misc typos fixes in ./lib folder.
Sat, Dec 8, 6:58 AM

Thu, Dec 6

teemperor accepted D55361: Move Broadcaster+Listener+Event combo from Core into Utility.
Thu, Dec 6, 10:01 AM
teemperor added a comment to D55361: Move Broadcaster+Listener+Event combo from Core into Utility.

LGTM modulo the unrelated clang-format changes. Feel free to commit them separately (even though the m_event_names fix looks a bit strange).

Thu, Dec 6, 10:00 AM

Thu, Nov 29

teemperor committed rC347863: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger.
Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger
Thu, Nov 29, 5:54 AM
teemperor committed rL347863: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger.
Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger
Thu, Nov 29, 5:53 AM
teemperor closed D54898: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger.
Thu, Nov 29, 5:53 AM · Restricted Project

Mon, Nov 26

teemperor created D54898: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger.
Mon, Nov 26, 7:28 AM · Restricted Project

Nov 11 2018

teemperor added a comment to D54385: Remove comments after header includes..

Do we also want to get rid of the // C Includes comments that are in some files? LLVM isn't using them either and just removing lines doesn't make git blame more complicated.

Nov 11 2018, 12:05 AM · Restricted Project

Nov 10 2018

teemperor accepted D54335: [CMake] Fix: add_host_subdirectory source/Host/macosx.

LGTM, sorry for that!

Nov 10 2018, 1:36 AM

Nov 4 2018

teemperor added a comment to D54072: Add a command to dump a module's clang ast..

Yeah it uses the color settings of the diagnostic engine which are probably set to false in LLDB. I think activating colors there should fix the issue.

Nov 4 2018, 6:35 AM
teemperor added a comment to D54072: Add a command to dump a module's clang ast..

I think Pavel's point is to call the dump overload which allows specifying our own custom raw_ostream: https://clang.llvm.org/doxygen/classclang_1_1Decl.html#a278b3b87b6f9d3b20ed566a8684341a6 And our raw_ostream is configured by LLDB to correctly choose if we want color or not.

Nov 4 2018, 6:25 AM

Nov 2 2018

teemperor added a comment to D54059: Remove Java debugger plugin.

Minor detail: The revision title only mentions Java, but this revision removes both Go and Java.

Nov 2 2018, 5:09 PM · Restricted Project
teemperor added a comment to D54003: Refactor ClangASTContext::AddEnumerationValueToEnumerationType() to remove redundant parameter which can be calculated from other parameter.

This looks nice, just added some minor comments below. Otherwise LGTM after Davide's point is addressed.

Nov 2 2018, 2:35 PM

Oct 24 2018

teemperor accepted D52651: Add functionality to export settings.

Woops, I wanted to accept in my previous comment.

Oct 24 2018, 4:24 PM · Restricted Project
teemperor requested changes to D52651: Add functionality to export settings.

Sorry, this somehow didn't show up in my review queue. I think this can land after two minor things are fixed:

Oct 24 2018, 4:23 PM · Restricted Project
teemperor accepted D53639: [autocompletion] Handle the space before pressing tab.

LGTM!

Oct 24 2018, 4:52 AM
teemperor requested changes to D53639: [autocompletion] Handle the space before pressing tab.
Oct 24 2018, 4:15 AM

Oct 4 2018

teemperor accepted D52884: Fix typos..

This looks all good to me. I'm a bit worried about the changes to AppleObjCTrampolineHandler.cpp, but from what I can see we don't actually rely on this specific field name anywhere in our code.

Oct 4 2018, 6:23 AM

Oct 1 2018

teemperor added a comment to D52651: Add functionality to export settings.
  • Running settings export /home/teemperor/foobar1 /home/teemperor/foobar2 will actually just create foobar1, but will not report any error that foobar2 is silently ignored.
Oct 1 2018, 11:22 AM · Restricted Project
teemperor requested changes to D52651: Add functionality to export settings.

Runnings settings export crashes LLDB:

Oct 1 2018, 11:13 AM · Restricted Project

Sep 27 2018

teemperor committed rL343191: Refactor ClangUserExpression::GetLanguageForExpr.
Refactor ClangUserExpression::GetLanguageForExpr
Sep 27 2018, 3:14 AM
teemperor committed rLLDB343191: Refactor ClangUserExpression::GetLanguageForExpr.
Refactor ClangUserExpression::GetLanguageForExpr
Sep 27 2018, 3:14 AM
teemperor closed D52561: Refactor ClangUserExpression::GetLanguageForExpr.
Sep 27 2018, 3:14 AM

Sep 26 2018

teemperor created D52561: Refactor ClangUserExpression::GetLanguageForExpr.
Sep 26 2018, 10:00 AM

Sep 25 2018

teemperor accepted D52498: [lldb-mi] Fix bugs in target-select-so-path.test.

Looks good and fixes the tests for me, so I think this is good to go. Thanks for the patch!

Sep 25 2018, 11:43 AM
teemperor added a comment to D52498: [lldb-mi] Fix bugs in target-select-so-path.test.

Hmmm, maybe I mixing up something here, but the docs state pass_fds was added in 3.2:

Sep 25 2018, 8:52 AM

Sep 24 2018

teemperor added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

Yeah, explicitly typing python2 is what I did to fix it. Not sure if that breaks other OSs though (e.g. if a system has no python2 binary, but only python).

Sep 24 2018, 8:18 AM
teemperor updated subscribers of D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

AFAIR, adding an exit(...) to ConnectToRemote won't solve this problem. The test will still be failing on Arch.

Sep 24 2018, 7:19 AM
teemperor added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

Posting my mail here for the record:

Sep 24 2018, 7:19 AM

Sep 22 2018

teemperor added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

Yes, the writeSocketIdToPipe(unnamed_pipe_fd, socket_id); fails in this method/file.

Sep 22 2018, 2:14 PM
teemperor committed rLLDB342804: Change type of m_user_expression_start_pos to size_t.
Change type of m_user_expression_start_pos to size_t
Sep 22 2018, 6:35 AM
teemperor committed rL342804: Change type of m_user_expression_start_pos to size_t.
Change type of m_user_expression_start_pos to size_t
Sep 22 2018, 6:35 AM

Sep 21 2018

teemperor added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

Sure, here is the output: After some debugging it seems that our select wrapper code is failing. We probably could fix this by terminating the process like in the other error cases in the same method (grep for the "failed to write to the unnamed pipe" error to see the code).

Sep 21 2018, 6:01 AM

Sep 20 2018

teemperor accepted D52139: [lldb-mi] Fix hanging of target-select-so-path.test.
Sep 20 2018, 12:51 PM
teemperor added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

I'm accepting this as seems to improve the situation, even though it's not a complete fix.

Sep 20 2018, 12:51 PM
teemperor added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

FYI, for me the test is still hanging on Arch Linux.

Sep 20 2018, 10:15 AM

Sep 19 2018

teemperor added a comment to D52270: TestMultilineExpr: validate evaluation for expressions spread over multiple lines.

Can't you just check for '5', as this is the only information we actually actually care about here?

Sep 19 2018, 11:29 AM

Sep 18 2018

teemperor accepted D50751: Allow use of self.filecheck in LLDB tests (c.f self.expect).

LGTM minus one small detail (see inline comment). Thanks Vedant!

Sep 18 2018, 1:38 AM · Restricted Project

Sep 17 2018

teemperor committed rLLDB342385: Add descriptions to completed expressions.
Add descriptions to completed expressions
Sep 17 2018, 5:10 AM
teemperor committed rL342385: Add descriptions to completed expressions.
Add descriptions to completed expressions
Sep 17 2018, 5:10 AM
teemperor closed D52103: Add descriptions to completed expressions.
Sep 17 2018, 5:10 AM

Sep 14 2018

teemperor accepted D51520: Add libc++ data formatter for std::variant.

LGTM now, thanks for the patch!

Sep 14 2018, 11:09 AM
teemperor requested changes to D51520: Add libc++ data formatter for std::variant.

LibCxx.h/.cpp are still not clang-formatted. I ran clang-format over the patch and pushed it here that this patch doesn't get stuck on this minor detail: https://github.com/Teemperor/lldb/commit/1c5c2f8f5d5af00420559dee52c9155e5bc72518.diff

Sep 14 2018, 10:51 AM
teemperor created D52103: Add descriptions to completed expressions.
Sep 14 2018, 10:26 AM
teemperor added a comment to D49739: Add new API to SBTarget class.

This test is timing out for me on Arch Linux. Any idea why?

Sep 14 2018, 8:32 AM

Sep 13 2018

teemperor committed rLLDB342181: Add support for descriptions with command completions..
Add support for descriptions with command completions.
Sep 13 2018, 2:27 PM
teemperor committed rL342181: Add support for descriptions with command completions..
Add support for descriptions with command completions.
Sep 13 2018, 2:27 PM
teemperor closed D51175: Add support for descriptions with command completions..
Sep 13 2018, 2:27 PM
teemperor updated the diff for D51175: Add support for descriptions with command completions..
  • Rebasing before merging.
Sep 13 2018, 2:25 PM
teemperor committed rLLDB342121: Remove byte counting from SourceManager [NFC].
Remove byte counting from SourceManager [NFC]
Sep 13 2018, 2:21 AM
teemperor committed rL342121: Remove byte counting from SourceManager [NFC].
Remove byte counting from SourceManager [NFC]
Sep 13 2018, 2:20 AM
teemperor closed D50809: Remove byte counting from SourceManager [NFC].
Sep 13 2018, 2:20 AM
teemperor updated the diff for D50809: Remove byte counting from SourceManager [NFC].
  • Fixed conflicts before merging.
Sep 13 2018, 2:20 AM
teemperor removed a parent revision for D50809: Remove byte counting from SourceManager [NFC]: D50681: Remove manual byte counting from internal Stream methods..
Sep 13 2018, 2:14 AM
teemperor removed a child revision for D50681: Remove manual byte counting from internal Stream methods.: D50809: Remove byte counting from SourceManager [NFC].
Sep 13 2018, 2:14 AM
teemperor added a comment to D51175: Add support for descriptions with command completions..

@jingham I'm confused, what are the requested changes? Because the behavior we seem to agree on is that we keep completions with the same value but different descriptions which is already the current implementation (see lines 138 and 148 in CompletionRequestTest.cpp)

Sep 13 2018, 1:05 AM

Sep 12 2018

teemperor accepted D50383: Move SafeMachO from Utility to Host.

LGTM, thanks!

Sep 12 2018, 4:15 AM
teemperor committed rLLDB342044: Remove manual byte counting from internal Stream methods..
Remove manual byte counting from internal Stream methods.
Sep 12 2018, 3:22 AM
teemperor committed rL342044: Remove manual byte counting from internal Stream methods..
Remove manual byte counting from internal Stream methods.
Sep 12 2018, 3:22 AM
teemperor closed D50681: Remove manual byte counting from internal Stream methods..
Sep 12 2018, 3:21 AM
teemperor retitled D50809: Remove byte counting from SourceManager [NFC] from Remove byte counting from SourceManager to Remove byte counting from SourceManager [NFC].
Sep 12 2018, 3:09 AM
teemperor committed rLLDB342042: Add a basic test for 'memory region'.
Add a basic test for 'memory region'
Sep 12 2018, 3:06 AM
teemperor committed rL342042: Add a basic test for 'memory region'.
Add a basic test for 'memory region'
Sep 12 2018, 3:05 AM
teemperor closed D51930: Add a basic test for 'memory region'.
Sep 12 2018, 3:05 AM

Sep 11 2018

teemperor added a comment to D51959: Add compatability version to liblldb in framework builds.

LGTM otherwise, but don’t know frameworks good enough to accept.

Sep 11 2018, 10:45 PM
teemperor updated the diff for D43871: [modules] No longer include stdlib.h from mm_malloc.h..
  • Removed comment about redeclaring free in the test. That's wasn't correctly formulated and is anyway no longer true now that the test case including this file got bigger.
  • Fixed formatting in the free declaration.

(Thanks, Richard).

Sep 11 2018, 8:11 AM
teemperor updated subscribers of D51930: Add a basic test for 'memory region'.

@davide Maybe git is failing me, but I can only find D47508 but that doesn't seem related. Let's ping @vsk

Sep 11 2018, 7:40 AM
teemperor added a comment to D51557: Replace uses of LazyBool with LazyBool template.

(Phabricator didn't send my draft, sorry for the delay).

Sep 11 2018, 7:35 AM
teemperor added a comment to D51175: Add support for descriptions with command completions..

ping :)

Sep 11 2018, 7:27 AM
teemperor created D51930: Add a basic test for 'memory region'.
Sep 11 2018, 7:16 AM
teemperor committed rL341940: Print the correct error when our DynamicCheckerFunctions fail to install.
Print the correct error when our DynamicCheckerFunctions fail to install
Sep 11 2018, 7:03 AM
teemperor committed rLLDB341940: Print the correct error when our DynamicCheckerFunctions fail to install.
Print the correct error when our DynamicCheckerFunctions fail to install
Sep 11 2018, 7:03 AM
teemperor closed D51602: Print the correct error when our DynamicCheckerFunctions fail to install.
Sep 11 2018, 7:02 AM
teemperor closed D51602: Print the correct error when our DynamicCheckerFunctions fail to install.
Sep 11 2018, 7:02 AM
teemperor committed rLLDB341931: [NFC] Fix compiler warning in TestArmv7Disassembly.cpp.
[NFC] Fix compiler warning in TestArmv7Disassembly.cpp
Sep 11 2018, 5:48 AM
teemperor committed rL341931: [NFC] Fix compiler warning in TestArmv7Disassembly.cpp.
[NFC] Fix compiler warning in TestArmv7Disassembly.cpp
Sep 11 2018, 5:48 AM
teemperor added a comment to rL341535: Reland [ClangUserExpression][NFC] Removed unused code.

Can we rework GetLanguageForExpr? Or at least rename it.

Sep 11 2018, 5:11 AM

Sep 6 2018

teemperor committed rL341535: Reland [ClangUserExpression][NFC] Removed unused code.
Reland [ClangUserExpression][NFC] Removed unused code
Sep 6 2018, 3:25 AM
teemperor committed rLLDB341535: Reland [ClangUserExpression][NFC] Removed unused code.
Reland [ClangUserExpression][NFC] Removed unused code
Sep 6 2018, 3:25 AM
teemperor committed rL341532: Revert "[ClangUserExpression][NFC] Removed unused code".
Revert "[ClangUserExpression][NFC] Removed unused code"
Sep 6 2018, 2:47 AM
teemperor committed rLLDB341532: Revert "[ClangUserExpression][NFC] Removed unused code".
Revert "[ClangUserExpression][NFC] Removed unused code"
Sep 6 2018, 2:47 AM

Sep 5 2018

teemperor added a comment to D51615: Set Windows console mode to enable support for ansi escape codes.

LGTM from my side, but @zturner should take a look too.

Sep 5 2018, 7:32 AM
teemperor committed rL341471: [www] Updated outdated download links [NFC].
[www] Updated outdated download links [NFC]
Sep 5 2018, 7:29 AM
teemperor committed rLLDB341471: [www] Updated outdated download links [NFC].
[www] Updated outdated download links [NFC]
Sep 5 2018, 7:29 AM

Sep 4 2018

teemperor added a comment to D51600: [NFC] Fixed enum constant in boolean context error.

(you can also try arcanist which will do this automatically for you)

Sep 4 2018, 9:04 AM
teemperor added a reviewer for D51604: Terminate debugger if an assert was hit: Restricted Project.
Sep 4 2018, 5:38 AM
teemperor requested changes to D50383: Move SafeMachO from Utility to Host.

Please add the header also to the modulemap in Host (which has to be manually written, as the Host module contains a lot of OS-specific headers):
module SafeMachO { header "Host/SafeMachO.h" export * }

Sep 4 2018, 3:49 AM
teemperor requested changes to D51615: Set Windows console mode to enable support for ansi escape codes.

Thanks! Didn't know we can activate this setting for the user.

Sep 4 2018, 3:47 AM

Sep 3 2018

teemperor accepted D51600: [NFC] Fixed enum constant in boolean context error.

This whole code doesn't seem to have test coverage, so I'll not demand a test for this. Also this patch is clearly fixing a typo, so let's get this in.

Sep 3 2018, 2:59 PM
teemperor accepted D51601: [NFC] Use llvm_unreachable instead of lldb::assert .

LGTM, thanks!

Sep 3 2018, 2:50 PM
teemperor updated the summary of D51602: Print the correct error when our DynamicCheckerFunctions fail to install.
Sep 3 2018, 1:42 PM
teemperor added a comment to D51602: Print the correct error when our DynamicCheckerFunctions fail to install.

Don't see a way to test this, as this can only be triggered when something in LLDB is going really wrong. That piece of code also has zero test coverage, so I'll just merge it in a few weeks or so unless someone comes up with a good way to test this.

Sep 3 2018, 1:41 PM
teemperor created D51602: Print the correct error when our DynamicCheckerFunctions fail to install.
Sep 3 2018, 1:40 PM
teemperor added a comment to D48704: [LLDB] Fix for "Bug 37950: ExecutionContext::GetByteOrder() always returns endian::InlHostByteOrder()".

My question about a good test case template was more directed at everyone :)

Sep 3 2018, 12:28 PM · Restricted Project
teemperor updated the diff for D51557: Replace uses of LazyBool with LazyBool template.
  • Now using a typedef instead of a macro.
  • Using LLVM code style in Lazy.h
  • Renamed UpdateX to CalculateX
Sep 3 2018, 11:36 AM