teemperor (Raphael Isemann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 23 2016, 8:38 AM (134 w, 4 d)

Recent Activity

Thu, Oct 4

teemperor accepted D52884: Fix typos..

This looks all good to me. I'm a bit worried about the changes to AppleObjCTrampolineHandler.cpp, but from what I can see we don't actually rely on this specific field name anywhere in our code.

Thu, Oct 4, 6:23 AM

Mon, Oct 1

teemperor added a comment to D52651: Add functionality to export settings.
  • Running settings export /home/teemperor/foobar1 /home/teemperor/foobar2 will actually just create foobar1, but will not report any error that foobar2 is silently ignored.
Mon, Oct 1, 11:22 AM · Restricted Project
teemperor requested changes to D52651: Add functionality to export settings.

Runnings settings export crashes LLDB:

Mon, Oct 1, 11:13 AM · Restricted Project

Thu, Sep 27

teemperor committed rL343191: Refactor ClangUserExpression::GetLanguageForExpr.
Refactor ClangUserExpression::GetLanguageForExpr
Thu, Sep 27, 3:14 AM
teemperor committed rLLDB343191: Refactor ClangUserExpression::GetLanguageForExpr.
Refactor ClangUserExpression::GetLanguageForExpr
Thu, Sep 27, 3:14 AM
teemperor closed D52561: Refactor ClangUserExpression::GetLanguageForExpr.
Thu, Sep 27, 3:14 AM

Wed, Sep 26

teemperor created D52561: Refactor ClangUserExpression::GetLanguageForExpr.
Wed, Sep 26, 10:00 AM

Tue, Sep 25

teemperor accepted D52498: [lldb-mi] Fix bugs in target-select-so-path.test.

Looks good and fixes the tests for me, so I think this is good to go. Thanks for the patch!

Tue, Sep 25, 11:43 AM
teemperor added a comment to D52498: [lldb-mi] Fix bugs in target-select-so-path.test.

Hmmm, maybe I mixing up something here, but the docs state pass_fds was added in 3.2:

Tue, Sep 25, 8:52 AM

Mon, Sep 24

teemperor added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

Yeah, explicitly typing python2 is what I did to fix it. Not sure if that breaks other OSs though (e.g. if a system has no python2 binary, but only python).

Mon, Sep 24, 8:18 AM
teemperor updated subscribers of D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

AFAIR, adding an exit(...) to ConnectToRemote won't solve this problem. The test will still be failing on Arch.

Mon, Sep 24, 7:19 AM
teemperor added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

Posting my mail here for the record:

Mon, Sep 24, 7:19 AM

Sat, Sep 22

teemperor added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

Yes, the writeSocketIdToPipe(unnamed_pipe_fd, socket_id); fails in this method/file.

Sat, Sep 22, 2:14 PM
teemperor committed rLLDB342804: Change type of m_user_expression_start_pos to size_t.
Change type of m_user_expression_start_pos to size_t
Sat, Sep 22, 6:35 AM
teemperor committed rL342804: Change type of m_user_expression_start_pos to size_t.
Change type of m_user_expression_start_pos to size_t
Sat, Sep 22, 6:35 AM

Sep 21 2018

teemperor added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

Sure, here is the output: After some debugging it seems that our select wrapper code is failing. We probably could fix this by terminating the process like in the other error cases in the same method (grep for the "failed to write to the unnamed pipe" error to see the code).

Sep 21 2018, 6:01 AM

Sep 20 2018

teemperor accepted D52139: [lldb-mi] Fix hanging of target-select-so-path.test.
Sep 20 2018, 12:51 PM
teemperor added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

I'm accepting this as seems to improve the situation, even though it's not a complete fix.

Sep 20 2018, 12:51 PM
teemperor added a comment to D52139: [lldb-mi] Fix hanging of target-select-so-path.test.

FYI, for me the test is still hanging on Arch Linux.

Sep 20 2018, 10:15 AM

Sep 19 2018

teemperor added a comment to D52270: TestMultilineExpr: validate evaluation for expressions spread over multiple lines.

Can't you just check for '5', as this is the only information we actually actually care about here?

Sep 19 2018, 11:29 AM

Sep 18 2018

teemperor accepted D50751: Allow use of self.filecheck in LLDB tests (c.f self.expect).

LGTM minus one small detail (see inline comment). Thanks Vedant!

Sep 18 2018, 1:38 AM · Restricted Project

Sep 17 2018

teemperor committed rLLDB342385: Add descriptions to completed expressions.
Add descriptions to completed expressions
Sep 17 2018, 5:10 AM
teemperor committed rL342385: Add descriptions to completed expressions.
Add descriptions to completed expressions
Sep 17 2018, 5:10 AM
teemperor closed D52103: Add descriptions to completed expressions.
Sep 17 2018, 5:10 AM

Sep 14 2018

teemperor accepted D51520: Add libc++ data formatter for std::variant.

LGTM now, thanks for the patch!

Sep 14 2018, 11:09 AM
teemperor requested changes to D51520: Add libc++ data formatter for std::variant.

LibCxx.h/.cpp are still not clang-formatted. I ran clang-format over the patch and pushed it here that this patch doesn't get stuck on this minor detail: https://github.com/Teemperor/lldb/commit/1c5c2f8f5d5af00420559dee52c9155e5bc72518.diff

Sep 14 2018, 10:51 AM
teemperor created D52103: Add descriptions to completed expressions.
Sep 14 2018, 10:26 AM
teemperor added a comment to D49739: Add new API to SBTarget class.

This test is timing out for me on Arch Linux. Any idea why?

Sep 14 2018, 8:32 AM

Sep 13 2018

teemperor committed rLLDB342181: Add support for descriptions with command completions..
Add support for descriptions with command completions.
Sep 13 2018, 2:27 PM
teemperor committed rL342181: Add support for descriptions with command completions..
Add support for descriptions with command completions.
Sep 13 2018, 2:27 PM
teemperor closed D51175: Add support for descriptions with command completions..
Sep 13 2018, 2:27 PM
teemperor updated the diff for D51175: Add support for descriptions with command completions..
  • Rebasing before merging.
Sep 13 2018, 2:25 PM
teemperor committed rLLDB342121: Remove byte counting from SourceManager [NFC].
Remove byte counting from SourceManager [NFC]
Sep 13 2018, 2:21 AM
teemperor committed rL342121: Remove byte counting from SourceManager [NFC].
Remove byte counting from SourceManager [NFC]
Sep 13 2018, 2:20 AM
teemperor closed D50809: Remove byte counting from SourceManager [NFC].
Sep 13 2018, 2:20 AM
teemperor updated the diff for D50809: Remove byte counting from SourceManager [NFC].
  • Fixed conflicts before merging.
Sep 13 2018, 2:20 AM
teemperor removed a dependency for D50809: Remove byte counting from SourceManager [NFC]: D50681: Remove manual byte counting from internal Stream methods..
Sep 13 2018, 2:14 AM
teemperor removed a dependent revision for D50681: Remove manual byte counting from internal Stream methods.: D50809: Remove byte counting from SourceManager [NFC].
Sep 13 2018, 2:14 AM
teemperor added a comment to D51175: Add support for descriptions with command completions..

@jingham I'm confused, what are the requested changes? Because the behavior we seem to agree on is that we keep completions with the same value but different descriptions which is already the current implementation (see lines 138 and 148 in CompletionRequestTest.cpp)

Sep 13 2018, 1:05 AM

Sep 12 2018

teemperor accepted D50383: Move SafeMachO from Utility to Host.

LGTM, thanks!

Sep 12 2018, 4:15 AM
teemperor committed rLLDB342044: Remove manual byte counting from internal Stream methods..
Remove manual byte counting from internal Stream methods.
Sep 12 2018, 3:22 AM
teemperor committed rL342044: Remove manual byte counting from internal Stream methods..
Remove manual byte counting from internal Stream methods.
Sep 12 2018, 3:22 AM
teemperor closed D50681: Remove manual byte counting from internal Stream methods..
Sep 12 2018, 3:21 AM
teemperor retitled D50809: Remove byte counting from SourceManager [NFC] from Remove byte counting from SourceManager to Remove byte counting from SourceManager [NFC].
Sep 12 2018, 3:09 AM
teemperor committed rLLDB342042: Add a basic test for 'memory region'.
Add a basic test for 'memory region'
Sep 12 2018, 3:06 AM
teemperor committed rL342042: Add a basic test for 'memory region'.
Add a basic test for 'memory region'
Sep 12 2018, 3:05 AM
teemperor closed D51930: Add a basic test for 'memory region'.
Sep 12 2018, 3:05 AM

Sep 11 2018

teemperor added a comment to D51959: Add compatability version to liblldb in framework builds.

LGTM otherwise, but don’t know frameworks good enough to accept.

Sep 11 2018, 10:45 PM
teemperor updated the diff for D43871: [modules] No longer include stdlib.h from mm_malloc.h..
  • Removed comment about redeclaring free in the test. That's wasn't correctly formulated and is anyway no longer true now that the test case including this file got bigger.
  • Fixed formatting in the free declaration.

(Thanks, Richard).

Sep 11 2018, 8:11 AM
teemperor updated subscribers of D51930: Add a basic test for 'memory region'.

@davide Maybe git is failing me, but I can only find D47508 but that doesn't seem related. Let's ping @vsk

Sep 11 2018, 7:40 AM
teemperor added a comment to D51557: Replace uses of LazyBool with LazyBool template.

(Phabricator didn't send my draft, sorry for the delay).

Sep 11 2018, 7:35 AM
teemperor added a comment to D51175: Add support for descriptions with command completions..

ping :)

Sep 11 2018, 7:27 AM
teemperor created D51930: Add a basic test for 'memory region'.
Sep 11 2018, 7:16 AM
teemperor committed rL341940: Print the correct error when our DynamicCheckerFunctions fail to install.
Print the correct error when our DynamicCheckerFunctions fail to install
Sep 11 2018, 7:03 AM
teemperor committed rLLDB341940: Print the correct error when our DynamicCheckerFunctions fail to install.
Print the correct error when our DynamicCheckerFunctions fail to install
Sep 11 2018, 7:03 AM
teemperor closed D51602: Print the correct error when our DynamicCheckerFunctions fail to install.
Sep 11 2018, 7:02 AM
teemperor closed D51602: Print the correct error when our DynamicCheckerFunctions fail to install.
Sep 11 2018, 7:02 AM
teemperor committed rLLDB341931: [NFC] Fix compiler warning in TestArmv7Disassembly.cpp.
[NFC] Fix compiler warning in TestArmv7Disassembly.cpp
Sep 11 2018, 5:48 AM
teemperor committed rL341931: [NFC] Fix compiler warning in TestArmv7Disassembly.cpp.
[NFC] Fix compiler warning in TestArmv7Disassembly.cpp
Sep 11 2018, 5:48 AM
teemperor added a comment to rL341535: Reland [ClangUserExpression][NFC] Removed unused code.

Can we rework GetLanguageForExpr? Or at least rename it.

Sep 11 2018, 5:11 AM

Sep 6 2018

teemperor committed rL341535: Reland [ClangUserExpression][NFC] Removed unused code.
Reland [ClangUserExpression][NFC] Removed unused code
Sep 6 2018, 3:25 AM
teemperor committed rLLDB341535: Reland [ClangUserExpression][NFC] Removed unused code.
Reland [ClangUserExpression][NFC] Removed unused code
Sep 6 2018, 3:25 AM
teemperor committed rL341532: Revert "[ClangUserExpression][NFC] Removed unused code".
Revert "[ClangUserExpression][NFC] Removed unused code"
Sep 6 2018, 2:47 AM
teemperor committed rLLDB341532: Revert "[ClangUserExpression][NFC] Removed unused code".
Revert "[ClangUserExpression][NFC] Removed unused code"
Sep 6 2018, 2:47 AM

Sep 5 2018

teemperor added a comment to D51615: Set Windows console mode to enable support for ansi escape codes.

LGTM from my side, but @zturner should take a look too.

Sep 5 2018, 7:32 AM
teemperor committed rL341471: [www] Updated outdated download links [NFC].
[www] Updated outdated download links [NFC]
Sep 5 2018, 7:29 AM
teemperor committed rLLDB341471: [www] Updated outdated download links [NFC].
[www] Updated outdated download links [NFC]
Sep 5 2018, 7:29 AM

Sep 4 2018

teemperor added a comment to D51600: [NFC] Fixed enum constant in boolean context error.

(you can also try arcanist which will do this automatically for you)

Sep 4 2018, 9:04 AM
teemperor added a reviewer for D51604: Terminate debugger if an assert was hit: Restricted Project.
Sep 4 2018, 5:38 AM
teemperor requested changes to D50383: Move SafeMachO from Utility to Host.

Please add the header also to the modulemap in Host (which has to be manually written, as the Host module contains a lot of OS-specific headers):
module SafeMachO { header "Host/SafeMachO.h" export * }

Sep 4 2018, 3:49 AM
teemperor requested changes to D51615: Set Windows console mode to enable support for ansi escape codes.

Thanks! Didn't know we can activate this setting for the user.

Sep 4 2018, 3:47 AM

Sep 3 2018

teemperor accepted D51600: [NFC] Fixed enum constant in boolean context error.

This whole code doesn't seem to have test coverage, so I'll not demand a test for this. Also this patch is clearly fixing a typo, so let's get this in.

Sep 3 2018, 2:59 PM
teemperor accepted D51601: [NFC] Use llvm_unreachable instead of lldb::assert .

LGTM, thanks!

Sep 3 2018, 2:50 PM
teemperor updated the summary of D51602: Print the correct error when our DynamicCheckerFunctions fail to install.
Sep 3 2018, 1:42 PM
teemperor added a comment to D51602: Print the correct error when our DynamicCheckerFunctions fail to install.

Don't see a way to test this, as this can only be triggered when something in LLDB is going really wrong. That piece of code also has zero test coverage, so I'll just merge it in a few weeks or so unless someone comes up with a good way to test this.

Sep 3 2018, 1:41 PM
teemperor created D51602: Print the correct error when our DynamicCheckerFunctions fail to install.
Sep 3 2018, 1:40 PM
teemperor added a comment to D48704: [LLDB] Fix for "Bug 37950: ExecutionContext::GetByteOrder() always returns endian::InlHostByteOrder()".

My question about a good test case template was more directed at everyone :)

Sep 3 2018, 12:28 PM · Restricted Project
teemperor updated the diff for D51557: Replace uses of LazyBool with LazyBool template.
  • Now using a typedef instead of a macro.
  • Using LLVM code style in Lazy.h
  • Renamed UpdateX to CalculateX
Sep 3 2018, 11:36 AM

Sep 2 2018

teemperor added a comment to D48704: [LLDB] Fix for "Bug 37950: ExecutionContext::GetByteOrder() always returns endian::InlHostByteOrder()".

Do we have a test case for different target byte orders that could be used as a test template here? Otherwise I would just merge this in as the previous behavior of this function was clearly wrong.

Sep 2 2018, 1:42 PM · Restricted Project
teemperor set the repository for D48704: [LLDB] Fix for "Bug 37950: ExecutionContext::GetByteOrder() always returns endian::InlHostByteOrder()" to rLLDB LLDB.
Sep 2 2018, 1:42 PM · Restricted Project

Aug 31 2018

teemperor created D51557: Replace uses of LazyBool with LazyBool template.
Aug 31 2018, 1:51 PM

Aug 30 2018

teemperor committed rLLDB341157: Fixed missing sidebars on the website.
Fixed missing sidebars on the website
Aug 30 2018, 7:08 PM
teemperor committed rL341157: Fixed missing sidebars on the website.
Fixed missing sidebars on the website
Aug 30 2018, 7:08 PM
teemperor committed rLLDB341126: Fixed comment for UserExpression::Complete [NFC].
Fixed comment for UserExpression::Complete [NFC]
Aug 30 2018, 2:32 PM
teemperor committed rL341126: Fixed comment for UserExpression::Complete [NFC].
Fixed comment for UserExpression::Complete [NFC]
Aug 30 2018, 2:32 PM
teemperor committed rL341124: Use a CompletionRequest in the expression command completion [NFC].
Use a CompletionRequest in the expression command completion [NFC]
Aug 30 2018, 2:27 PM
teemperor committed rLLDB341124: Use a CompletionRequest in the expression command completion [NFC].
Use a CompletionRequest in the expression command completion [NFC]
Aug 30 2018, 2:27 PM
teemperor committed rLLDB341121: Move NoBuiltin=true closer to the other LangOpts code [NFC].
Move NoBuiltin=true closer to the other LangOpts code [NFC]
Aug 30 2018, 1:58 PM
teemperor committed rL341121: Move NoBuiltin=true closer to the other LangOpts code [NFC].
Move NoBuiltin=true closer to the other LangOpts code [NFC]
Aug 30 2018, 1:57 PM
teemperor committed rLLDB341112: Adjusting some comments in ClangExpressionParser.cpp.
Adjusting some comments in ClangExpressionParser.cpp
Aug 30 2018, 1:21 PM
teemperor committed rL341112: Adjusting some comments in ClangExpressionParser.cpp.
Adjusting some comments in ClangExpressionParser.cpp
Aug 30 2018, 1:21 PM
teemperor committed rL341109: Added missing include to <cctype> for 'std::isalnum'.
Added missing include to <cctype> for 'std::isalnum'
Aug 30 2018, 1:15 PM
teemperor committed rLLDB341109: Added missing include to <cctype> for 'std::isalnum'.
Added missing include to <cctype> for 'std::isalnum'
Aug 30 2018, 1:15 PM
teemperor committed rLLDB341105: Fixed code style for the CodeCompletion members [NFC].
Fixed code style for the CodeCompletion members [NFC]
Aug 30 2018, 12:50 PM
teemperor committed rL341105: Fixed code style for the CodeCompletion members [NFC].
Fixed code style for the CodeCompletion members [NFC]
Aug 30 2018, 12:50 PM
teemperor added a project to D51185: Reuse the SelectorTable from Clang's Preprocessor: Unknown Object (Project).
Aug 30 2018, 12:45 PM · Unknown Object (Project)
teemperor added a project to D50481: Fix broken builtin functions in the expression command: Unknown Object (Project).
Aug 30 2018, 12:44 PM · Unknown Object (Project)
teemperor added a project to D51253: Let the CompilerInstance create our clang ASTContext: Unknown Object (Project).
Aug 30 2018, 12:44 PM · Unknown Object (Project)
teemperor added a comment to D50802: Expression autocompletion with variables and symbols.

@acoomans D48465 has landed, so feel free to file bugs for any completions that are not provided by this. Thanks!

Aug 30 2018, 10:55 AM
teemperor committed rL341089: Move Predicate.h from Host to Utility.
Move Predicate.h from Host to Utility
Aug 30 2018, 10:52 AM