- User Since
- Mar 23 2016, 8:38 AM (90 w, 5 h)
Mon, Nov 27
Nov 8 2017
Nov 7 2017
Adding people that could review.
Nov 6 2017
Oct 30 2017
- Removed virtual keyword when we already have override.
Sep 13 2017
Sep 12 2017
- Rebased with the correct diff...
- Rebased diff before merging.
Sep 10 2017
- Moved code from FrontendAction.cpp into createFileManager()
- Added test case.
Sep 7 2017
Sep 6 2017
@johannes The blocking reviewer is because it touches clone detection code :) Fine with me, I have some comments on things but nothing that affects this review. LGTM!
Sep 5 2017
Sep 3 2017
- Rebased and updated patch before merging.
- Rebased and fixed merge conflicts before merging.
Sep 2 2017
Sep 1 2017
@arphaman I suggested tablegen in D36664 because I remembered we had some CMake sanity check about not having an *.inc in our include dir: https://github.com/llvm-mirror/clang/blob/master/CMakeLists.txt#L266 Not sure if it actually fires for our case, but it looks like it does.
Aug 31 2017
Aug 29 2017
Aug 28 2017
Aug 27 2017
Aug 26 2017
Aug 23 2017
Sorry for the delay, was on vacation.
Aug 22 2017
Found one more minor comment typo. And could you do your changes to OptParserEmitter.cpp all in this patch? Because Rui/Me pointed out those things on this review, so this patch should also fix them IMHO :)
Aug 17 2017
Aug 16 2017
That's a really nice approach to this problem, good job Yuka! See my inline comments for some minor remarks.
Aug 15 2017
Very well done, I really like this patch! I added a few remarks mostly about the comments that need some small adjusting.
Aug 10 2017
LGTM, more publicity means that more shells will make use of it.
Aug 3 2017
I see, thanks for the information! If we don't need to support this in the shell-completion and we shouldn't report invalid arguments, then it seems this review is stuck here. I'll abandon as I don't see any other use case for this code.
Aug 1 2017
E.g. If you add a flag that lands in between the results it breaks. Add -Wmajor-new-feature and the test goes red. Same with the flag results or changing the help test for -std=.
Jul 31 2017
- Remove some unneeded includes
Jul 30 2017
I'm open to suggestions how we should handle user-provided checkers that maybe come with their own configs. Should we add that if we have a custom checker in the registry, that we disable this check to keep backwards compability? Or do we demand users to register their own configs in the registry?
- Updated according to Artem's comments.
Jul 25 2017
If you can't reproduce, you should try running a debug build through valgrind. It points out this issue:
Jul 22 2017
Thanks for the quick fix, LGTM!
Jul 18 2017
ping. Any objections to adding this GCC alias?
Jul 15 2017
I have a last request in my inline comment regarding the documentation, otherwise this is good to go. Nice work!
@yamaguchi yes, the reason why we have to treat the -W... flags specially should be documented (as they're not in the OptTable as you said). E.g. something like // We have to query the -W flags manually as they're not in the OptTable. and then maybe a TODO: Find a good way to add them to OptTable instead and them remove this code..
It seems the code doesn't compile in clang because on your platform std::vector is implicitly included by some header, on clang+Arch however it isn`t (see the error at the end of https://teemperor.de/ccir/D35447).
Jul 14 2017
Jul 9 2017
@johannes D34880 has landed, so feel free to propose patches to the StmtDataCollector API that would help you (e.g. to support identifiers). You can see examples how to use it in the CloneDetection.cpp (once for storing data in a FoldingetSetNodeID and once for directly hashing the data with MD5).
Jul 2 2017
Yeah, we should move it, but it should land somewhere in a header in /AST/ so that for example the StmtProfiler could make use of this. I'm open for suggestions here :)
Jul 1 2017
For the record, one can get a (maybe incomplete) list of options that are without completion via: curl "https://teemperor.de/pub/clang_flags.txt" | grep -v HelpText | grep -v Group.
The only options I can see that I would miss if they would disappear are the ones who are clearly meant to be public but just lack the HelpText (like our beloved sysroot, which is a public GCC flag). So I think this patch can go forward and someone will have to add a HelpText for those flags in the future.
LGTM, everything still works in the latest bash on Linux.
I'm not sure what you refer to by I just saw we actually have the completion code in the Driver. We are already auto completing both cc1 options and driver options, right?
Jun 30 2017
Yes, it does indeed skip identifiers and literals for this reason :). It was planned to make this template more configurable for use cases like yours, so I'm totally fine with adding configuration parameters. I just opened D34880 where I make this template public as a first step.
I didn't have time to have a close look at this patch, but it seems you're interested in the specific TU-independent data of a Stmt to compare them. So if you are interested in such data and don't want to write your own function to collect it for each Stmt subclass, there is the StmtDataCollector in the CloneDetection.cpp here and a example how to use it is here.
Jun 29 2017
Two thought from me on this:
Jun 25 2017
Works as intended, good job!
Jun 24 2017
Jun 22 2017
Jun 21 2017
@ahatanak I think we can leave the more expressive clang name for this warning and just add the bit cryptic GCC name for compability. But I don't have a strong opinion on this.