Page MenuHomePhabricator

teemperor (Raphael Isemann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 23 2016, 8:38 AM (200 w, 4 d)

Recent Activity

Today

teemperor committed rGa311bebb53d4: [lldb][NFC] Give import-std-module tests a more unique file names (authored by teemperor).
[lldb][NFC] Give import-std-module tests a more unique file names
Mon, Jan 27, 2:00 AM
teemperor committed rG785c6b22914f: [lldb][NFC] Improve documentation for CompletionRequest (authored by teemperor).
[lldb][NFC] Improve documentation for CompletionRequest
Mon, Jan 27, 1:51 AM

Fri, Jan 24

teemperor committed rG06ae3748db8a: [lldb][NFC] Cleanup some if conditions in ASTImporterDelegate::Imported (authored by teemperor).
[lldb][NFC] Cleanup some if conditions in ASTImporterDelegate::Imported
Fri, Jan 24, 4:53 AM
teemperor created D73345: [lldb] Don't create duplicate declarations when completing a forward declaration with a definition from another source.
Fri, Jan 24, 4:52 AM · Restricted Project
teemperor updated the diff for D73024: [lldb] Complete return types of CXXMethodDecls to prevent crashing due to covariant return types.
  • Made test stricter.
  • Moved code to ASTImporterDelegate.
Fri, Jan 24, 4:08 AM · Restricted Project
teemperor committed rGc0738d2480b9: [lldb][NFC] Fix formatting in ASTImporterDelegate::ImportImpl (authored by teemperor).
[lldb][NFC] Fix formatting in ASTImporterDelegate::ImportImpl
Fri, Jan 24, 3:01 AM
teemperor committed rG36f12d2638f8: [lldb][NFC] Delete unused ClangASTImporter::CompleteDecl (authored by teemperor).
[lldb][NFC] Delete unused ClangASTImporter::CompleteDecl
Fri, Jan 24, 2:55 AM
teemperor committed rG326c39b569e3: [clang][NFC] Remove redundant cast (authored by teemperor).
[clang][NFC] Remove redundant cast
Fri, Jan 24, 2:08 AM
teemperor added inline comments to D72946: [lldb] Remove ClangASTImporter reference from Target.
Fri, Jan 24, 1:00 AM · Restricted Project
teemperor accepted D72946: [lldb] Remove ClangASTImporter reference from Target.

Is an AST importer specific to a target? Can we just put it into the Clang AST type system subclass and create it lazily?

Fri, Jan 24, 12:57 AM · Restricted Project
teemperor committed rG808142876c10: [lldb][NFC] Fix all formatting errors in .cpp file headers (authored by teemperor).
[lldb][NFC] Fix all formatting errors in .cpp file headers
Fri, Jan 24, 12:04 AM
teemperor closed D73258: [lldb][NFC] Fix all formatting errors in .cpp file headers.
Fri, Jan 24, 12:04 AM · Restricted Project

Thu, Jan 23

teemperor added inline comments to D73303: [lldb/Target] Add Abort StackFrame Recognizer.
Thu, Jan 23, 11:54 PM · Restricted Project
teemperor added a comment to D72953: Fix the handling of unnamed bit-fields when parsing DWARF.

LGTM modulo some minor points regarding the test. The refactoring of the parsing code and using expect_expr can be done as NFC follow-ups. Thanks for the patch, great work!

Thu, Jan 23, 9:25 AM · Restricted Project
teemperor accepted D72953: Fix the handling of unnamed bit-fields when parsing DWARF.
Thu, Jan 23, 9:25 AM · Restricted Project
teemperor created D73258: [lldb][NFC] Fix all formatting errors in .cpp file headers.
Thu, Jan 23, 2:09 AM · Restricted Project
teemperor committed rGa1e0b53490af: [lldb][NFC] Delete empty file source/Host/linux/ProcessLauncherLinux.cpp (authored by teemperor).
[lldb][NFC] Delete empty file source/Host/linux/ProcessLauncherLinux.cpp
Thu, Jan 23, 1:42 AM
teemperor committed rG6e3b0cc2fb9e: [lldb][NFC] Rename ClangASTContext to TypeSystemClang (authored by teemperor).
[lldb][NFC] Rename ClangASTContext to TypeSystemClang
Thu, Jan 23, 1:16 AM
teemperor closed D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang.
Thu, Jan 23, 1:16 AM · Restricted Project

Wed, Jan 22

teemperor added a comment to D72953: Fix the handling of unnamed bit-fields when parsing DWARF.

I just went back to the radar we had about the CG crash and this *does* fix that issue (rdar://53932023). I could also not reproduce the CG crash again so I assume that was something else that fiddled around in that area. So LGTM minus the thing with the last_bitfield_info last_field_info duality which I would prefer we could get rid of before landing (but it's not a must and can be done as a follow-up commit).

Wed, Jan 22, 6:43 AM · Restricted Project
teemperor committed rG4481eefbe842: [ASTImporter] Properly delete decls from SavedImportPaths (authored by jarin).
[ASTImporter] Properly delete decls from SavedImportPaths
Wed, Jan 22, 6:24 AM
teemperor closed D73166: [ASTImporter] Properly delete decls from SavedImportPaths.
Wed, Jan 22, 6:24 AM · Restricted Project
teemperor added a comment to D73166: [ASTImporter] Properly delete decls from SavedImportPaths.

I can land it, seems to pass all LLDB tests too.

Wed, Jan 22, 6:24 AM · Restricted Project
teemperor added a reviewer for D69933: [ASTImporter] Limit imports of structs: teemperor.
Wed, Jan 22, 2:08 AM · Restricted Project, Restricted Project

Tue, Jan 21

teemperor committed rGc9a39a896c95: [lldb] Add a display name to ClangASTContext instances (authored by teemperor).
[lldb] Add a display name to ClangASTContext instances
Tue, Jan 21, 11:57 PM
teemperor closed D72391: [lldb] Add a display name to ClangASTContext instances.
Tue, Jan 21, 11:57 PM · Restricted Project
teemperor added a comment to D69933: [ASTImporter] Limit imports of structs.

I really don't think the ASTImporter should ever manipulate records in the source context (effectively the source context should be considered immutable). It also seems *very* wrong that what we import depends in any way on a previous expression so I agree we should fix that. In theory the ImportDefinition call in the ASTImporter shouldn't do any real work as we have the MinimalImport mode on in LLDB so it should only load some bare bone record with external storage IIUC. So I think the original version of the patch seems like a better approach to me from a quick glance.

Tue, Jan 21, 11:55 AM · Restricted Project, Restricted Project
teemperor committed rG1f7b95d038e6: [lldb][NFC] Convert LLDB_LOGF to LLDB_LOG in ClangASTSource.cpp (authored by teemperor).
[lldb][NFC] Convert LLDB_LOGF to LLDB_LOG in ClangASTSource.cpp
Tue, Jan 21, 4:48 AM
teemperor added a comment to D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest.

This still leaves the question of the script interpreter plugins, which are suspiciously *not* included in "all plugins". The script interpreters are quite special, so I think it's fine to handle them separately -- the question is just how to convey that distinction. Move them into a different top level folder? Call this SystemInitializerMostPlugins ?

Tue, Jan 21, 3:43 AM · Restricted Project
teemperor added a comment to D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest.

I moved the single non-plugin call back to the original Full/Test subclasses so the name is now correct. Also I removed all the duplicated linking flags that I forgot to remove before.

Tue, Jan 21, 1:35 AM · Restricted Project
teemperor added inline comments to D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort.
Tue, Jan 21, 1:35 AM · Restricted Project
teemperor updated the diff for D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest.
  • Removed all the duplicated linking flags too.
Tue, Jan 21, 1:35 AM · Restricted Project

Mon, Jan 20

teemperor updated subscribers of D72557: Add pretty printers for llvm::PointerIntPair and llvm::PointerUnion..
Mon, Jan 20, 1:32 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
teemperor committed rG65bab53afb8b: [lldb][NFC] Add test for iterator invalidation during code completion. (authored by teemperor).
[lldb][NFC] Add test for iterator invalidation during code completion.
Mon, Jan 20, 6:08 AM
teemperor updated the summary of D73038: 64 bit SourceLocs.
Mon, Jan 20, 5:49 AM
teemperor created D73038: 64 bit SourceLocs.
Mon, Jan 20, 5:49 AM
teemperor committed rG22447a61d405: [lldb] Mark the implicit copy constructor as deleted when a move constructor is… (authored by teemperor).
[lldb] Mark the implicit copy constructor as deleted when a move constructor is…
Mon, Jan 20, 5:40 AM
teemperor closed D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided..
Mon, Jan 20, 5:40 AM · Restricted Project
teemperor added a comment to D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided..

Thanks for the review!

Mon, Jan 20, 5:21 AM · Restricted Project
teemperor updated the diff for D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided..
  • Added a simple expr evaluation as an additional way to trigger the error.
Mon, Jan 20, 5:21 AM · Restricted Project
teemperor planned changes to D73024: [lldb] Complete return types of CXXMethodDecls to prevent crashing due to covariant return types.

Actually that seems to be more complicated in case we get the method decl by asking the ASTImporter for a definition (which will skip this code).

Mon, Jan 20, 4:35 AM · Restricted Project
teemperor requested changes to D72953: Fix the handling of unnamed bit-fields when parsing DWARF.
Mon, Jan 20, 3:58 AM · Restricted Project
teemperor added a comment to D72953: Fix the handling of unnamed bit-fields when parsing DWARF.

(Jim pointed out that we land this without expect_expr to make back porting easier but somehow Phabricator didn't add his comment to the review here. expect_expr is not yet in the downstream Github branch but it is in the 10 release branch, so that makes sense to me).

Mon, Jan 20, 3:58 AM · Restricted Project
teemperor created D73024: [lldb] Complete return types of CXXMethodDecls to prevent crashing due to covariant return types.
Mon, Jan 20, 3:21 AM · Restricted Project
teemperor updated the summary of D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest.
Mon, Jan 20, 1:02 AM · Restricted Project
teemperor created D73018: [lldb] Add SystemInitializerAllPlugins and delete copy-pasted Init code in SystemInitializerFull and SystemInitializerTest.
Mon, Jan 20, 1:02 AM · Restricted Project

Sun, Jan 19

teemperor added a comment to D73016: [lldb/CMake] Make it possible to disable plugins at configuration time.

How does this deal with linking flags etc.? Your cmake cache disabled LLDB_PLUGIN_SYMBOLFILE_NATIVEPDB_BUILD (well, it would without the LDB typo) but that just gives me a build that fails to link with ld: error: unable to find library -llldbPluginSymbolFileNativePDB.

Sun, Jan 19, 11:48 PM · Restricted Project

Fri, Jan 17

teemperor added a comment to D72953: Fix the handling of unnamed bit-fields when parsing DWARF.

(Just some quick comments, will review this properly during normal working hours)

Fri, Jan 17, 2:24 PM · Restricted Project
teemperor removed reviewers for D72946: [lldb] Remove ClangASTImporter reference from Target: martong, a.sidorin.
Fri, Jan 17, 12:57 PM · Restricted Project
teemperor requested changes to D72946: [lldb] Remove ClangASTImporter reference from Target.

I wish we could do this without a global map. Also the ClangASTImporter shouldn't have a dependency on Target (I'm actually surprised this compiles without an additional include).

Fri, Jan 17, 12:57 PM · Restricted Project
teemperor committed rG791f132132b2: [lldb] Remove out of order OperatingSystemPython::Terminate call in… (authored by teemperor).
[lldb] Remove out of order OperatingSystemPython::Terminate call in…
Fri, Jan 17, 4:07 AM
teemperor committed rGf2d41ad0e7e0: [lldb] Add missing terminate calls to Python/Lua subsystems (authored by teemperor).
[lldb] Add missing terminate calls to Python/Lua subsystems
Fri, Jan 17, 3:51 AM
teemperor added inline comments to D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort.
Fri, Jan 17, 3:48 AM · Restricted Project
teemperor committed rGc3ab790c8f5d: [lldb][NFC] Resynchronize Init/Terminate calls in SystemInitializerFull/Test. (authored by teemperor).
[lldb][NFC] Resynchronize Init/Terminate calls in SystemInitializerFull/Test.
Fri, Jan 17, 2:38 AM
teemperor committed rG6b840834cd50: [lldb][NFC] Delete unused lldb/source/Plugins/LanguageRuntime/Go/CMakeLists.txt (authored by teemperor).
[lldb][NFC] Delete unused lldb/source/Plugins/LanguageRuntime/Go/CMakeLists.txt
Fri, Jan 17, 12:59 AM

Thu, Jan 16

teemperor committed rG5ac610668a7c: [lldb] Re-add NSDate formatter (authored by teemperor).
[lldb] Re-add NSDate formatter
Thu, Jan 16, 11:59 PM
teemperor committed rG81eaa3ddd060: [lldb][NFC] Delete TestDataFormatterObjCNSDate.py (authored by teemperor).
[lldb][NFC] Delete TestDataFormatterObjCNSDate.py
Thu, Jan 16, 8:29 AM
teemperor committed rG39d6b6c21f74: [lldb][NFC] Migrate several tests to expect_expr (authored by teemperor).
[lldb][NFC] Migrate several tests to expect_expr
Thu, Jan 16, 4:47 AM
teemperor added a comment to D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang.

Are there any objections against this? Otherwise I'll land this tomorrow.

Thu, Jan 16, 1:31 AM · Restricted Project
teemperor committed rG4f244bba4f66: [lldb] Fix asan failures in data-formatter-objc tests (authored by teemperor).
[lldb] Fix asan failures in data-formatter-objc tests
Thu, Jan 16, 1:03 AM

Wed, Jan 15

teemperor committed rG13f22f5d5958: [lldb] Add expect_expr function for testing expression evaluation in dotests. (authored by teemperor).
[lldb] Add expect_expr function for testing expression evaluation in dotests.
Wed, Jan 15, 4:10 AM
teemperor closed D70314: [lldb] Add expect_expr function for testing expression evaluation in dotests..
Wed, Jan 15, 4:10 AM · Restricted Project
teemperor retitled D70314: [lldb] Add expect_expr function for testing expression evaluation in dotests. from [lldb] Add better test commands for expression evaluation to [lldb] Add expect_expr function for testing expression evaluation in dotests..
Wed, Jan 15, 4:01 AM · Restricted Project
teemperor updated the diff for D70314: [lldb] Add expect_expr function for testing expression evaluation in dotests..
  • Removed substr functionality.
  • Using frame() now.
Wed, Jan 15, 3:15 AM · Restricted Project
teemperor updated the diff for D70314: [lldb] Add expect_expr function for testing expression evaluation in dotests..
  • Removed everything that is not summary or value.
Wed, Jan 15, 2:47 AM · Restricted Project
teemperor updated the diff for D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang.
  • Replaced dummy contents with actual patch
Wed, Jan 15, 1:23 AM · Restricted Project
teemperor added a comment to D70314: [lldb] Add expect_expr function for testing expression evaluation in dotests..

I also got rid of the expr->frame var->expr flow and it's not just expr->frame var. I don't want to remove them as we found two formatter bugs by testing both but once these thing don't break constantly then we can remove the 'expr' variant from the simple expression function.

Wed, Jan 15, 1:14 AM · Restricted Project
teemperor updated the diff for D70314: [lldb] Add expect_expr function for testing expression evaluation in dotests..
  • Moved to using the SBAPI.
Wed, Jan 15, 1:05 AM · Restricted Project

Tue, Jan 14

teemperor added a comment to D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang.

We might also want to move these into lldb/source/Plugins/TypeSystem as well to complete this refactor?

Tue, Jan 14, 1:28 PM · Restricted Project
teemperor updated the diff for D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided..
  • Readd test files.
Tue, Jan 14, 8:02 AM · Restricted Project
teemperor updated the diff for D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided..
  • Rebase.
Tue, Jan 14, 6:16 AM · Restricted Project
teemperor updated the diff for D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang.
  • Revert to original dummy patch.
Tue, Jan 14, 6:16 AM · Restricted Project
teemperor added a comment to D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang.

Huh, seems I uploaded to the wrong review

Tue, Jan 14, 6:06 AM · Restricted Project
teemperor updated the diff for D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang.
  • Rebased to get rid of shady StringRef -> C-String conversion.
Tue, Jan 14, 5:35 AM · Restricted Project
teemperor committed rG3f944a8b8ca8: [lldb][NFC] Make name parameter in AddMethodToCXXRecordType a StringRef (authored by teemperor).
[lldb][NFC] Make name parameter in AddMethodToCXXRecordType a StringRef
Tue, Jan 14, 5:27 AM
teemperor created D72698: [lldb] Add method decls to a CXXRecordDecl only after all their properties are defined.
Tue, Jan 14, 5:26 AM · Restricted Project
teemperor added a comment to D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided..

FWIW this patch makes me realise that we really should have a Sema around when we create the module AST as this would prevent issues like this and saves us from simulating Sema behavior. That's probably yet another large refactoring so I don't have time for that soon-ish but if anyone wants to do this then be my guest.

Tue, Jan 14, 5:16 AM · Restricted Project
teemperor updated the diff for D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided..
  • Upload correct revision of the test file.
Tue, Jan 14, 5:16 AM · Restricted Project
teemperor created D72694: [lldb] Mark the implicit copy constructor as deleted when a move constructor is provided..
Tue, Jan 14, 5:09 AM · Restricted Project
teemperor accepted D72510: [lldb/Expression] Improve interpreter error message with a non-running target.

LGTM, thanks!

Tue, Jan 14, 3:50 AM · Restricted Project
teemperor committed rG9492e9d8cfd3: [lldb][NFC] Cleanup ClangASTContext::CompleteTagDeclarationDefinition (authored by teemperor).
[lldb][NFC] Cleanup ClangASTContext::CompleteTagDeclarationDefinition
Tue, Jan 14, 3:05 AM
teemperor added a comment to D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang.

Both TypeSystemClang and ClangTypeSystem works for me.

Tue, Jan 14, 2:00 AM · Restricted Project
teemperor committed rGd8ffd601d523: [lldb][NFC] Rewrite python_api/rdar-12481949 test (authored by teemperor).
[lldb][NFC] Rewrite python_api/rdar-12481949 test
Tue, Jan 14, 1:14 AM
teemperor closed D72593: [lldb][NFC] Rewrite python_api/rdar-12481949 test.
Tue, Jan 14, 1:14 AM · Restricted Project
teemperor committed rGf18370fe0e75: [lldb] Don't defend against internal LLVM errors in IRInterpreter (authored by teemperor).
[lldb] Don't defend against internal LLVM errors in IRInterpreter
Tue, Jan 14, 1:04 AM
teemperor closed D72596: [lldb] Don't defend against internal LLVM errors in IRInterpreter.
Tue, Jan 14, 1:04 AM · Restricted Project
teemperor added reviewers for D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang: JDevlieghere, davide.
Tue, Jan 14, 12:54 AM · Restricted Project
teemperor added a comment to D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang.

We are currently after a fresh rebranch downstream so now is a good time to rename this without causing merge-conflict hell later on. It would be useful if could get consensus if and to what we should rename this class soon-ish so that I can make this move as painless as possible.

Tue, Jan 14, 12:54 AM · Restricted Project
teemperor added a reviewer for D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang: labath.
Tue, Jan 14, 12:54 AM · Restricted Project
teemperor created D72684: [lldb][NFC] Rename ClangASTContext to TypeSystemClang.
Tue, Jan 14, 12:46 AM · Restricted Project
teemperor committed rG61b6a4e82653: [lldb] Fix that SBThread.GetStopDescription is returning strings with… (authored by teemperor).
[lldb] Fix that SBThread.GetStopDescription is returning strings with…
Tue, Jan 14, 12:36 AM
teemperor closed D72086: [lldb] Fix that SBThread.GetStopDescription is returning strings with uninitialized memory at the end..
Tue, Jan 14, 12:36 AM · Restricted Project
teemperor added a comment to rG61bd19206f61: [libc++] Explicitly enumerate std::string external instantiations..

FWIW we solved the LLDB problems.

Tue, Jan 14, 12:07 AM

Mon, Jan 13

teemperor added a comment to D72447: [lldb] Mark several tests as not dependent on debug info.

This introduced a failure on the Windows LLDB bot (there were already other failing tests though, so maybe you missed it):

http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/12554

Mon, Jan 13, 1:24 PM · Restricted Project
teemperor committed rG577efd09e3b7: [lldb] Revert ddf044290ede for TestProcessAPI.py (authored by teemperor).
[lldb] Revert ddf044290ede for TestProcessAPI.py
Mon, Jan 13, 1:15 PM
teemperor added a reverting change for rGddf044290ede: [lldb] Mark several tests as not dependent on debug info: rG577efd09e3b7: [lldb] Revert ddf044290ede for TestProcessAPI.py.
Mon, Jan 13, 1:15 PM
teemperor committed rGc1fbede984ec: [lldb][NFC] Remove debug print statement from TestExprDiagnostics.py (authored by teemperor).
[lldb][NFC] Remove debug print statement from TestExprDiagnostics.py
Mon, Jan 13, 5:20 AM
teemperor updated the summary of D72596: [lldb] Don't defend against internal LLVM errors in IRInterpreter.
Mon, Jan 13, 4:15 AM · Restricted Project
teemperor updated the summary of D72596: [lldb] Don't defend against internal LLVM errors in IRInterpreter.
Mon, Jan 13, 3:20 AM · Restricted Project
teemperor updated the summary of D72596: [lldb] Don't defend against internal LLVM errors in IRInterpreter.
Mon, Jan 13, 3:19 AM · Restricted Project