Page MenuHomePhabricator

teemperor (Raphael Isemann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 23 2016, 8:38 AM (251 w, 6 d)

Recent Activity

Today

teemperor requested review of D94991: [lldb][docs] Remove -webkit-hyphens in table cells so that table widths are correct on Safari.
Tue, Jan 19, 11:54 AM
teemperor added inline comments to D94967: [lldb][docs] Filter out 'thisown' attribute and inheritance boilerplate.
Tue, Jan 19, 10:12 AM
teemperor updated the diff for D94967: [lldb][docs] Filter out 'thisown' attribute and inheritance boilerplate.
  • Compile regex only once
Tue, Jan 19, 10:11 AM
teemperor committed rG2f8099509030: [lldb][docs] Update .htaccess to redirect from old SB API documentation to new… (authored by teemperor).
[lldb][docs] Update .htaccess to redirect from old SB API documentation to new…
Tue, Jan 19, 9:59 AM
teemperor closed D94900: [lldb][docs] Update .htaccess to redirect from old SB API documentation to new one.
Tue, Jan 19, 9:59 AM · Restricted Project
teemperor committed rG3cae8b33297b: [lldb][docs] Add a doc page for enums and constants (authored by teemperor).
[lldb][docs] Add a doc page for enums and constants
Tue, Jan 19, 9:54 AM
teemperor closed D94959: [lldb][docs] Add a doc page for enums and constants.
Tue, Jan 19, 9:54 AM · Restricted Project
teemperor added a comment to D94917: [lldb] Fix crash in "help memory read".

From what I understand this means D91378 is no longer necessary. thanks!

Tue, Jan 19, 7:06 AM · Restricted Project
teemperor committed rG626681b09a3e: [lldb] Fix two documentation typos (authored by teemperor).
[lldb] Fix two documentation typos
Tue, Jan 19, 6:26 AM
teemperor requested review of D94967: [lldb][docs] Filter out 'thisown' attribute and inheritance boilerplate.
Tue, Jan 19, 6:06 AM
teemperor updated the summary of D94959: [lldb][docs] Add a doc page for enums and constants.
Tue, Jan 19, 4:06 AM · Restricted Project
teemperor updated the diff for D94959: [lldb][docs] Add a doc page for enums and constants.
  • Add a comment for the orphan in the doc page.
Tue, Jan 19, 3:50 AM · Restricted Project
teemperor requested review of D94959: [lldb][docs] Add a doc page for enums and constants.
Tue, Jan 19, 3:33 AM · Restricted Project

Yesterday

teemperor committed rGa58aceffad61: [lldb][docs] Use 'any' as the default role in LLDB's sphinx project (authored by teemperor).
[lldb][docs] Use 'any' as the default role in LLDB's sphinx project
Mon, Jan 18, 10:09 AM
teemperor closed D94899: [lldb][docs] Use 'any' as the default role in LLDB's sphinx project.
Mon, Jan 18, 10:08 AM · Restricted Project
teemperor requested review of D94900: [lldb][docs] Update .htaccess to redirect from old SB API documentation to new one.
Mon, Jan 18, 2:48 AM · Restricted Project
teemperor requested review of D94899: [lldb][docs] Use 'any' as the default role in LLDB's sphinx project.
Mon, Jan 18, 2:29 AM · Restricted Project
teemperor committed rG6e75ee6b65c1: [lldb][docs] Use inline literals for code/paths instead of rendering it with… (authored by teemperor).
[lldb][docs] Use inline literals for code/paths instead of rendering it with…
Mon, Jan 18, 2:10 AM
teemperor committed rGf446fc5acf88: [lldb][docs] Resolve the remaining sphinx formatter warnings in the SB API docs (authored by teemperor).
[lldb][docs] Resolve the remaining sphinx formatter warnings in the SB API docs
Mon, Jan 18, 1:48 AM

Sun, Jan 17

teemperor committed rG7e9e6ac526eb: [lldb][docs] Fix some RST formatting errors related to code examples. (authored by teemperor).
[lldb][docs] Fix some RST formatting errors related to code examples.
Sun, Jan 17, 8:42 AM
teemperor committed rGacdc74568927: [lldb][docs] Cleanup the Python doc strings for SB API classes (authored by teemperor).
[lldb][docs] Cleanup the Python doc strings for SB API classes
Sun, Jan 17, 7:52 AM
teemperor added a comment to D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference.

There is no syntax highlighting for Python in sphinx? The code in
https://lldb.llvm.org/python_api/lldb.SBDebugger.html#lldb.SBDebugger
is hard to read.

Even the line breaks between the source code and web page differ.

Sun, Jan 17, 7:32 AM · Restricted Project, Restricted Project
teemperor committed rGe7bc6c594b75: Reland [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python… (authored by teemperor).
Reland [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python…
Sun, Jan 17, 3:13 AM

Fri, Jan 15

teemperor committed rG4017c6fe7f11: [lldb][docs] Translate ASCII art to restructured text formatting (authored by teemperor).
[lldb][docs] Translate ASCII art to restructured text formatting
Fri, Jan 15, 5:44 AM
teemperor added a reverting change for rGbab121a1b66e: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference: rG9d2053f61aac: Revert "[lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python….
Fri, Jan 15, 5:09 AM
teemperor committed rG9d2053f61aac: Revert "[lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python… (authored by teemperor).
Revert "[lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python…
Fri, Jan 15, 5:09 AM
teemperor added a reverting change for D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference: rG9d2053f61aac: Revert "[lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python….
Fri, Jan 15, 5:08 AM · Restricted Project, Restricted Project
teemperor committed rGbab121a1b66e: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference (authored by teemperor).
[lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference
Fri, Jan 15, 4:27 AM
teemperor closed D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference.
Fri, Jan 15, 4:27 AM · Restricted Project, Restricted Project

Wed, Jan 13

teemperor updated the summary of D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference.
Wed, Jan 13, 1:54 AM · Restricted Project, Restricted Project
teemperor added a comment to D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference.

I merged the Python API now into the normal website (see https://teemperor.de/pub/lldb_website/python_api.html# for how this looks). So cross-referencing and the website search now work for everything.

Wed, Jan 13, 1:51 AM · Restricted Project, Restricted Project
teemperor updated the diff for D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference.
  • Merged Python API and normal website.
Wed, Jan 13, 1:31 AM · Restricted Project, Restricted Project

Tue, Jan 12

teemperor added inline comments to D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference.
Tue, Jan 12, 10:04 AM · Restricted Project, Restricted Project
teemperor updated the diff for D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference.
  • Use the old output directory name.
Tue, Jan 12, 4:51 AM · Restricted Project, Restricted Project
teemperor added a comment to D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference.

I generated the current website here: https://teemperor.de/pub/sbapi/

Tue, Jan 12, 4:44 AM · Restricted Project, Restricted Project
teemperor requested review of D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference.
Tue, Jan 12, 4:41 AM · Restricted Project, Restricted Project

Fri, Jan 8

teemperor requested review of D94307: [lldb] Don't emit a warning when using Objective-C getters in expressions.
Fri, Jan 8, 7:11 AM
teemperor committed rGb0dc54e08a9b: [lldb][NFC] Refactor setup code for Clang diagnostics (authored by teemperor).
[lldb][NFC] Refactor setup code for Clang diagnostics
Fri, Jan 8, 5:26 AM
teemperor accepted D94244: [lldb] Bump the required SWIG version to 3.

LGTM modulo the warning messages still referencing 2 instead of 3.

Fri, Jan 8, 5:22 AM · Restricted Project
teemperor accepted D93421: Fix how ValueObject deals with getting unsigned values.

LGTM, thanks!

Fri, Jan 8, 4:47 AM

Wed, Jan 6

teemperor requested review of D94173: [lldb] Add an EnumFlags class for representing flags based on enums.
Wed, Jan 6, 6:07 AM

Dec 18 2020

teemperor requested changes to D93421: Fix how ValueObject deals with getting unsigned values.

Some comments about that this still prints 255, but otherwise this is looking good.

Dec 18 2020, 6:35 AM
teemperor requested review of D93533: [clang][objc] Add a warning when declaring BOOL bitfields with width 1.
Dec 18 2020, 4:34 AM

Dec 17 2020

teemperor added a comment to D93421: Fix how ValueObject deals with getting unsigned values.

I just realized that I got the char sign also mixed up. It's an unsigned char in LLDB, so the 255 is wrong (But I believe our char signedness handling is not correct in any C language). But the fact that we don't print YES/NO for that bitfield is right (just the int value is wrong).

Dec 17 2020, 9:19 AM
teemperor requested changes to D93421: Fix how ValueObject deals with getting unsigned values.

I think the proper fix here is to warn about BOOL bitfields with size 1 if BOOL is a typedef for signed char. I can make a Clang warning for that. I guess on the LLDB side we should make it clear that BOOL here has an invalid value (and then print the int value as we currently do)?

Dec 17 2020, 6:57 AM
teemperor added a comment to D93421: Fix how ValueObject deals with getting unsigned values.

This seems suspicious to me, on a couple of levels. You claim that BOOL is an unsigned type, but the apple documentation says "BOOL is explicitly signed so @encode(BOOL) is c rather than C even if -funsigned-char is used." Which one is true? Could this have something to do with the fact that the documentation assumes obj-c (which does not have a native bool type) but in lldb, we use obj-c++ (which, I guess, inherits bool from c++) everywhere?

If BOOL is unsigned, then it's not clear to me why would Scalar::ExtractBitfield be sign-extending anything. OTOH, if it is _signed_, then sign-extension seems to be the right behavior.

I think we may have some deeper problems with the handling bitfields whose underlying types are 1 byte long. Lldb (I think, correctly) sign-extends all signed bitfields, except the signed char one:

(lldb) p a
(A) $0 = {
  bool_ = true
  signed_char = '\x01'
  signed_short = -1
  signed_int = -1
  unsigned_char = '\x01'
  unsigned_short = 1
  unsigned_int = 1
}
(lldb) p/x a
(A) $1 = {
  bool_ = 0x01
  signed_char = 0x01
  signed_short = 0x0001
  signed_int = 0x00000001
  unsigned_char = 0x01
  unsigned_short = 0x0001
  unsigned_int = 0x00000001
}

This patch does not have any impact on this behavior, but the fact that signed char comes out as '\x01' seems suspicious. This is what gdb does for the same input:

(gdb) p a
$1 = {bool_ = true, signed_char = -1 '\377', signed_short = -1, signed_int = -1, unsigned_char = 1 '\001', unsigned_short = 1, unsigned_int = 1}
(gdb) p/x a
$2 = {bool_ = 0x1, signed_char = 0xff, signed_short = 0xffff, signed_int = 0xffffffff, unsigned_char = 0x1, unsigned_short = 0x1, unsigned_int = 0x1}

Finally, even though I'm not sure this is the right solution, I am sure that GetValueAsSigned should get the same fix as GetValueAsUnsigned

Dec 17 2020, 4:41 AM
teemperor added a comment to D93421: Fix how ValueObject deals with getting unsigned values.

Whether BOOL is signed char or bool is apparently depending on the architecture (???). See ClangExpressionSourceCode::GetText, Clang's __OBJC_BOOL_IS_BOOL macro and then there is also some preprocessor shenanigans for non-Clang ObjC (?) in the objc.h header from what I can see. Whether C++ is active is never actually checked anywhere (the bool type is coming from stdbool.h which is unconditionally included by objc.h).

Dec 17 2020, 4:32 AM
teemperor committed rGb8338983e6f6: [lldb] Add std::array to the supported template list of the CxxModuleHandler (authored by teemperor).
[lldb] Add std::array to the supported template list of the CxxModuleHandler
Dec 17 2020, 2:48 AM
teemperor committed rG722247c8124a: [lldb] Unify the two CreateTypedef implementations in TypeSystemClang (authored by teemperor).
[lldb] Unify the two CreateTypedef implementations in TypeSystemClang
Dec 17 2020, 1:49 AM
teemperor closed D93382: [lldb] Unify the two CreateTypedef implementations in TypeSystemClang.
Dec 17 2020, 1:49 AM · Restricted Project

Dec 16 2020

teemperor added a reviewer for D93382: [lldb] Unify the two CreateTypedef implementations in TypeSystemClang: JDevlieghere.
Dec 16 2020, 2:26 PM · Restricted Project
teemperor requested review of D93382: [lldb] Unify the two CreateTypedef implementations in TypeSystemClang.
Dec 16 2020, 1:20 AM · Restricted Project

Dec 15 2020

teemperor committed rG2b09dedac4c8: [lldb] Fix import-std-module tests after libc++ got a new __memory subdirectory (authored by teemperor).
[lldb] Fix import-std-module tests after libc++ got a new __memory subdirectory
Dec 15 2020, 7:16 AM
teemperor committed rZORG44410c491239: Use clang-stage2-Rthinlto host-compilers to for LLDB jobs (authored by teemperor).
Use clang-stage2-Rthinlto host-compilers to for LLDB jobs
Dec 15 2020, 2:25 AM

Dec 14 2020

teemperor added a comment to D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types..

I believe rsmith is in GMT-8, so I assume this won't get a fix soon and I went ahead and reverted in 22ccdb787024e954318e35fcf904fd4fa36f5679

Dec 14 2020, 5:07 AM · Restricted Project
teemperor committed rG22ccdb787024: Revert "Consider reference, pointer, and pointer-to-member TemplateArguments to… (authored by teemperor).
Revert "Consider reference, pointer, and pointer-to-member TemplateArguments to…
Dec 14 2020, 5:04 AM
teemperor added a reverting change for rG05cdf4acf42a: Consider reference, pointer, and pointer-to-member TemplateArguments to be…: rG22ccdb787024: Revert "Consider reference, pointer, and pointer-to-member TemplateArguments to….
Dec 14 2020, 5:04 AM
teemperor added a reverting change for D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.: rG22ccdb787024: Revert "Consider reference, pointer, and pointer-to-member TemplateArguments to….
Dec 14 2020, 5:04 AM · Restricted Project

Dec 11 2020

teemperor accepted D92957: ExpressionParser: Migrate to FileEntryRef in ParseInternal, NFC.
Dec 11 2020, 7:37 AM · Restricted Project

Dec 10 2020

teemperor committed rG47e7ecdd7d36: [lldb] Introduce separate scratch ASTs for debug info types and types imported… (authored by teemperor).
[lldb] Introduce separate scratch ASTs for debug info types and types imported…
Dec 10 2020, 10:28 AM
teemperor closed D92759: [lldb] Introduce separate scratch ASTs for debug info types and types imported from C++ modules..
Dec 10 2020, 10:28 AM · Restricted Project
teemperor committed rG839e84527789: [lldb] Remove assumption from Clang-based data formatters that their types are… (authored by teemperor).
[lldb] Remove assumption from Clang-based data formatters that their types are…
Dec 10 2020, 8:35 AM
teemperor closed D92757: [lldb] Remove assumption from Clang-based data formatters that their types are in the scratch AST.
Dec 10 2020, 8:35 AM · Restricted Project
teemperor committed rG208e3f5d9b6c: [lldb] Fix that symbols.clang-modules-cache-path is never initialized (authored by teemperor).
[lldb] Fix that symbols.clang-modules-cache-path is never initialized
Dec 10 2020, 4:38 AM
teemperor closed D92772: [lldb] Fix that symbols.clang-modules-cache-path is never initialized.
Dec 10 2020, 4:38 AM · Restricted Project
teemperor committed rG958608285eb4: [lldb] Allow LLDB to automatically retry a failed expression with an imported… (authored by teemperor).
[lldb] Allow LLDB to automatically retry a failed expression with an imported…
Dec 10 2020, 3:30 AM
teemperor closed D92784: [lldb] Allow LLDB to automatically retry a failed expression with an import std C++ module.
Dec 10 2020, 3:29 AM · Restricted Project
teemperor committed rG4df4edb6ad14: [lldb][NFC] Fix a typo in TestCppMultipleInheritance (authored by teemperor).
[lldb][NFC] Fix a typo in TestCppMultipleInheritance
Dec 10 2020, 1:57 AM

Dec 9 2020

teemperor planned changes to D92848: [lldb] Create a ASTImporterSharedState and pass it to all ASTImporterDelegates.

There area few failures once I actually create the lookup table, so I put this on my TODO list.

Dec 9 2020, 11:25 AM
teemperor committed rG199ec40e7bcc: [lldb][NFC] Refactor _get_bool_config_skip_if_decorator (authored by teemperor).
[lldb][NFC] Refactor _get_bool_config_skip_if_decorator
Dec 9 2020, 11:03 AM
teemperor added inline comments to D92784: [lldb] Allow LLDB to automatically retry a failed expression with an import std C++ module.
Dec 9 2020, 9:40 AM · Restricted Project
teemperor accepted D92908: [lldb] Kill the inferior instead of detaching during test suite runs.

LGTM. I assume that's the result of investigating Vedant's zombie generation script?

Dec 9 2020, 9:37 AM · Restricted Project
teemperor added a comment to D92848: [lldb] Create a ASTImporterSharedState and pass it to all ASTImporterDelegates.

So the only downside I can see is that the ASTImporter is no longer considering non-imported declarations in the To context (which are not known to the SharedState) for merging?

This is the case if you create the SharedState without a lookup table. If you pass a TUDecl then a lookup table will be created and in the constructor of that we traverse the AST to initialize the lookup. And from that point we will find every existing Decl even if they were not imported. As it is now we'd still be using the old noload_lookup.

@martong I assume I can make a follow-up for removing all the ASTImporter code for situations without a shared state?

Yes, that'd would be super.
Other than that, if you could make sure that the ASTImporterLookupTable is initialized then noload_lookup would not be needed and we could simplify so much in clang::ASTImporter.

Hmm, as far as I remember, in the past I tried this. And bumped into some issues, because during the traverse we had to load Decls with external storage and that introduced a new and uncontrolled import...

Dec 9 2020, 8:23 AM
teemperor added inline comments to D92759: [lldb] Introduce separate scratch ASTs for debug info types and types imported from C++ modules..
Dec 9 2020, 7:32 AM · Restricted Project
teemperor updated the diff for D92759: [lldb] Introduce separate scratch ASTs for debug info types and types imported from C++ modules..
  • Clarify ClangASTContext destructor code.
Dec 9 2020, 7:29 AM · Restricted Project

Dec 8 2020

teemperor updated the diff for D92759: [lldb] Introduce separate scratch ASTs for debug info types and types imported from C++ modules..
  • Expanded test with mixed debug info/module types (thanks Shafik!)
Dec 8 2020, 2:52 PM · Restricted Project
teemperor updated the diff for D92784: [lldb] Allow LLDB to automatically retry a failed expression with an import std C++ module.
  • Now using one setting with a backing enum (Thanks Jonas)
  • Gave up on imposing my doxygen code style on the project (Thanks Adrian).
  • Expanded test (Thanks Shafik)
Dec 8 2020, 2:48 PM · Restricted Project
teemperor added a comment to D92784: [lldb] Allow LLDB to automatically retry a failed expression with an import std C++ module.

Would it make sense to convert import-std-module to an enum with values True, False and Fallback instead of introducing a new option and then changing the default over time?

Dec 8 2020, 2:46 PM · Restricted Project
teemperor committed rGa2c157eb3ebc: [cmake] Make ExecutionEngine/Orc/Shared depend on intrinsics_gen to fix modules… (authored by teemperor).
[cmake] Make ExecutionEngine/Orc/Shared depend on intrinsics_gen to fix modules…
Dec 8 2020, 11:42 AM
teemperor closed D92873: [cmake] Make ExecutionEngine/Orc/Shared depend on intrinsics_gen to fix modules build.
Dec 8 2020, 11:42 AM · Restricted Project
teemperor added a comment to D92873: [cmake] Make ExecutionEngine/Orc/Shared depend on intrinsics_gen to fix modules build.

I'll go ahead and land this to unbreak the bots using Clang modules. Just using this for post-commit review.

Dec 8 2020, 11:40 AM · Restricted Project
teemperor added a reviewer for D92873: [cmake] Make ExecutionEngine/Orc/Shared depend on intrinsics_gen to fix modules build: sgraenitz.
Dec 8 2020, 11:29 AM · Restricted Project
teemperor requested review of D92873: [cmake] Make ExecutionEngine/Orc/Shared depend on intrinsics_gen to fix modules build.
Dec 8 2020, 11:28 AM · Restricted Project
teemperor added a comment to D92848: [lldb] Create a ASTImporterSharedState and pass it to all ASTImporterDelegates.

So the only downside I can see is that the ASTImporter is no longer considering non-imported declarations in the To context (which are not known to the SharedState) for merging? Given that we most likely never want this to happen within LLDB, this seems like a straightforward change.

Dec 8 2020, 8:48 AM
teemperor accepted D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef.

There are several LLDB tests failing with this change. The TestImportBaseClassWhenClassHasDerivedMember.py is probably the only relevant one. The others are probably failing for the same reason but with a more convoluted setup. I looked into the failure and it seems this patch is now skipping the workaround in ImportContext that was introduced in D78000 (as the Importer.GetAlreadyImportedOrNull will give us a DeclContext and then we just use that as-is). If you remove the if (!DC || !LexicalDC) before the if ((Err = ImportDeclContext(D, DC, LexicalDC))) this should keep the old behaviour.

Dec 8 2020, 8:23 AM · Restricted Project
teemperor requested review of D92848: [lldb] Create a ASTImporterSharedState and pass it to all ASTImporterDelegates.
Dec 8 2020, 7:37 AM
teemperor committed rG6face9119c81: [lldb][import-std-module] Add a test for typedef'd std types (authored by teemperor).
[lldb][import-std-module] Add a test for typedef'd std types
Dec 8 2020, 4:37 AM
teemperor committed rZORGb92c0f759b1f: [lldb] Remove use of removed dotest arg -s in build.py (authored by teemperor).
[lldb] Remove use of removed dotest arg -s in build.py
Dec 8 2020, 2:55 AM

Dec 7 2020

teemperor requested review of D92784: [lldb] Allow LLDB to automatically retry a failed expression with an import std C++ module.
Dec 7 2020, 12:50 PM · Restricted Project
teemperor accepted D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC).

LGTM, thanks! Bonus points for the emotional rollercoaster in the review history.

Dec 7 2020, 12:38 PM · Restricted Project
teemperor added a comment to D92772: [lldb] Fix that symbols.clang-modules-cache-path is never initialized.

I had to add a lldb-noinit alias that creates a completely uninitialized lldb (as the default init file for the tests sets a cache path).

Dec 7 2020, 9:48 AM · Restricted Project
teemperor requested review of D92772: [lldb] Fix that symbols.clang-modules-cache-path is never initialized.
Dec 7 2020, 9:47 AM · Restricted Project
teemperor added a comment to D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef.

Ping.
@teemperor please take a look if you have some time. This is a really important patch which may influence some future directions regarding the ASTImporter.

Dec 7 2020, 9:46 AM · Restricted Project
teemperor requested review of D92759: [lldb] Introduce separate scratch ASTs for debug info types and types imported from C++ modules..
Dec 7 2020, 6:01 AM · Restricted Project
teemperor requested review of D92757: [lldb] Remove assumption from Clang-based data formatters that their types are in the scratch AST.
Dec 7 2020, 5:19 AM · Restricted Project

Dec 4 2020

teemperor committed rGe97b991eef63: [lldb] Remove LLDB session dir and just store test traces in the respective… (authored by teemperor).
[lldb] Remove LLDB session dir and just store test traces in the respective…
Dec 4 2020, 2:43 AM
teemperor closed D92498: [lldb] Remove LLDB session dir and just store test traces in the respective test build directory.
Dec 4 2020, 2:43 AM · Restricted Project
teemperor committed rG594308c7ad07: [lldb][NFC] Rename TypeSystemClang::GetScratch to ScratchTypeSystemClang… (authored by teemperor).
[lldb][NFC] Rename TypeSystemClang::GetScratch to ScratchTypeSystemClang…
Dec 4 2020, 2:29 AM
teemperor requested review of D92498: [lldb] Remove LLDB session dir and just store test traces in the respective test build directory.
Dec 4 2020, 1:47 AM · Restricted Project
teemperor updated the diff for D92498: [lldb] Remove LLDB session dir and just store test traces in the respective test build directory.

I was a bit too quick with updating that one, doesn't seem to pass the tests. Two small fixes:

Dec 4 2020, 1:47 AM · Restricted Project