Page MenuHomePhabricator

teemperor (Raphael Isemann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 23 2016, 8:38 AM (178 w, 4 d)

Recent Activity

Thu, Aug 22

teemperor committed rG4ae79199ed1a: [lldb] Remove ')' to fix the build (authored by teemperor).
[lldb] Remove ')' to fix the build
Thu, Aug 22, 8:21 AM
teemperor committed rL369660: [lldb] Remove ')' to fix the build.
[lldb] Remove ')' to fix the build
Thu, Aug 22, 8:18 AM
teemperor committed rG00235e1b920e: [lldb][NFC] Fix indentation in CommandObjectProcess (authored by teemperor).
[lldb][NFC] Fix indentation in CommandObjectProcess
Thu, Aug 22, 6:52 AM
teemperor committed rL369652: [lldb][NFC] Fix indentation in CommandObjectProcess.
[lldb][NFC] Fix indentation in CommandObjectProcess
Thu, Aug 22, 6:51 AM
teemperor committed rG5215770e88ee: [lldb][NFC] Add test for target stop-hook disable/enable/delete (authored by teemperor).
[lldb][NFC] Add test for target stop-hook disable/enable/delete
Thu, Aug 22, 6:10 AM
teemperor committed rL369646: [lldb][NFC] Add test for target stop-hook disable/enable/delete.
[lldb][NFC] Add test for target stop-hook disable/enable/delete
Thu, Aug 22, 6:10 AM
teemperor updated the diff for D66581: [lldb] Construct the dummy target when the first Dummy object is constructed.
  • Fix variable name.
  • Move GetDummyTarget to header as it's only a one-liner.
Thu, Aug 22, 4:09 AM · Restricted Project
teemperor created D66581: [lldb] Construct the dummy target when the first Dummy object is constructed.
Thu, Aug 22, 3:41 AM · Restricted Project
teemperor committed rG494370c101e2: [lldb][NFC] Remove unused return value from HandleOptionArgumentCompletion (authored by teemperor).
[lldb][NFC] Remove unused return value from HandleOptionArgumentCompletion
Thu, Aug 22, 2:17 AM
teemperor committed rL369635: [lldb][NFC] Remove unused return value from HandleOptionArgumentCompletion.
[lldb][NFC] Remove unused return value from HandleOptionArgumentCompletion
Thu, Aug 22, 2:17 AM
teemperor committed rG1153dc9603c7: [lldb][NFC] NFC cleanup for the completion code (authored by teemperor).
[lldb][NFC] NFC cleanup for the completion code
Thu, Aug 22, 2:07 AM
teemperor committed rL369632: [lldb][NFC] NFC cleanup for the completion code.
[lldb][NFC] NFC cleanup for the completion code
Thu, Aug 22, 2:02 AM
teemperor committed rL369625: [lldb][NFC] Remove dead code that is supposed to handle invalid command options.
[lldb][NFC] Remove dead code that is supposed to handle invalid command options
Thu, Aug 22, 1:12 AM
teemperor committed rG36162014c469: [lldb][NFC] Remove dead code that is supposed to handle invalid command options (authored by teemperor).
[lldb][NFC] Remove dead code that is supposed to handle invalid command options
Thu, Aug 22, 1:12 AM
teemperor closed D66522: [lldb][NFC] Remove dead code that is supposed to handle invalid command options.
Thu, Aug 22, 1:12 AM · Restricted Project, Restricted Project
teemperor committed rGae34ed2c0d2f: [lldb][NFC] Remove WordComplete mode, make result array indexed from 0 and… (authored by teemperor).
[lldb][NFC] Remove WordComplete mode, make result array indexed from 0 and…
Thu, Aug 22, 12:45 AM
teemperor committed rL369624: [lldb][NFC] Remove WordComplete mode, make result array indexed from 0 and….
[lldb][NFC] Remove WordComplete mode, make result array indexed from 0 and…
Thu, Aug 22, 12:45 AM
teemperor closed D66536: [lldb][NFC] Remove WordComplete mode, make result array indexed from 0 and remove any undocumented/redundant return values.
Thu, Aug 22, 12:44 AM · Restricted Project, Restricted Project

Wed, Aug 21

teemperor added inline comments to D66536: [lldb][NFC] Remove WordComplete mode, make result array indexed from 0 and remove any undocumented/redundant return values.
Wed, Aug 21, 7:47 AM · Restricted Project, Restricted Project
teemperor updated the diff for D66536: [lldb][NFC] Remove WordComplete mode, make result array indexed from 0 and remove any undocumented/redundant return values.
  • Add comment that we emulate the old API by adding the common prefix as element 0.
Wed, Aug 21, 7:47 AM · Restricted Project, Restricted Project
teemperor created D66536: [lldb][NFC] Remove WordComplete mode, make result array indexed from 0 and remove any undocumented/redundant return values.
Wed, Aug 21, 7:47 AM · Restricted Project, Restricted Project
teemperor committed rG717717b1ff8b: [lldb][NFC] Merge multiple TestApropos.py (authored by teemperor).
[lldb][NFC] Merge multiple TestApropos.py
Wed, Aug 21, 7:23 AM
teemperor committed rL369530: [lldb][NFC] Merge multiple TestApropos.py.
[lldb][NFC] Merge multiple TestApropos.py
Wed, Aug 21, 7:23 AM
teemperor updated the diff for D66522: [lldb][NFC] Remove dead code that is supposed to handle invalid command options.
  • Remove some unreachable that are not in the command/interpreter directory (as they might be used differently and could be reached).
Wed, Aug 21, 6:46 AM · Restricted Project, Restricted Project
teemperor committed rG34a04e703d9e: [lldb] Add tests for 'settings remove' and fix error message typos (authored by teemperor).
[lldb] Add tests for 'settings remove' and fix error message typos
Wed, Aug 21, 6:27 AM
teemperor committed rL369524: [lldb] Add tests for 'settings remove' and fix error message typos.
[lldb] Add tests for 'settings remove' and fix error message typos
Wed, Aug 21, 6:27 AM
teemperor committed rG006d22de508d: [lldb] Add tests for setting completions and enable 'settings remove' completion (authored by teemperor).
[lldb] Add tests for setting completions and enable 'settings remove' completion
Wed, Aug 21, 5:57 AM
teemperor committed rL369521: [lldb] Add tests for setting completions and enable 'settings remove' completion.
[lldb] Add tests for setting completions and enable 'settings remove' completion
Wed, Aug 21, 5:56 AM
teemperor committed rG68756a8c37b2: [lldb][NFC] Add tests for register command (authored by teemperor).
[lldb][NFC] Add tests for register command
Wed, Aug 21, 3:40 AM
teemperor committed rL369513: [lldb][NFC] Add tests for register command.
[lldb][NFC] Add tests for register command
Wed, Aug 21, 3:40 AM
teemperor created D66522: [lldb][NFC] Remove dead code that is supposed to handle invalid command options.
Wed, Aug 21, 3:23 AM · Restricted Project, Restricted Project
teemperor committed rG4fc1eb55d197: [lldb][NFC] Add tests for invalid command invocations (authored by teemperor).
[lldb][NFC] Add tests for invalid command invocations
Wed, Aug 21, 2:17 AM
teemperor committed rL369506: [lldb][NFC] Add tests for invalid command invocations.
[lldb][NFC] Add tests for invalid command invocations
Wed, Aug 21, 2:15 AM
teemperor committed rG8a42af7b17cf: [NFC] Mark CallTargetComparator() as const to fix libc++ warnings (authored by teemperor).
[NFC] Mark CallTargetComparator() as const to fix libc++ warnings
Wed, Aug 21, 12:41 AM
teemperor committed rL369500: [NFC] Mark CallTargetComparator() as const to fix libc++ warnings.
[NFC] Mark CallTargetComparator() as const to fix libc++ warnings
Wed, Aug 21, 12:41 AM

Tue, Aug 20

teemperor resigned from D66463: Regex: +isValid() with no parameter.
Tue, Aug 20, 3:25 AM · Restricted Project
teemperor committed rG213a5abb4fa8: [lldb][NFC] Test quotes when completing (authored by teemperor).
[lldb][NFC] Test quotes when completing
Tue, Aug 20, 2:27 AM
teemperor committed rL369353: [lldb][NFC] Test quotes when completing.
[lldb][NFC] Test quotes when completing
Tue, Aug 20, 2:27 AM
teemperor accepted D66451: [ClangExpressionParser] Add ClangDeclVendor.

LGTM

Tue, Aug 20, 12:27 AM · Restricted Project, Restricted Project

Mon, Aug 19

teemperor committed rG0f4e9835c98a: [lldb] Make TestIOHandlerCompletion more stable and document it (authored by teemperor).
[lldb] Make TestIOHandlerCompletion more stable and document it
Mon, Aug 19, 12:20 PM
teemperor committed rL369293: [lldb] Make TestIOHandlerCompletion more stable and document it.
[lldb] Make TestIOHandlerCompletion more stable and document it
Mon, Aug 19, 12:12 PM
teemperor committed rG6632ad5851d6: [lldb][NFC] Stop using GetNumberOfMatches in CompletionRequest test (authored by teemperor).
[lldb][NFC] Stop using GetNumberOfMatches in CompletionRequest test
Mon, Aug 19, 7:54 AM
teemperor committed rL369267: [lldb][NFC] Stop using GetNumberOfMatches in CompletionRequest test.
[lldb][NFC] Stop using GetNumberOfMatches in CompletionRequest test
Mon, Aug 19, 7:54 AM
teemperor committed rG0684132107e5: [lldb][NFC] Use CompletionRequest in Variable::AutoComplete (authored by teemperor).
[lldb][NFC] Use CompletionRequest in Variable::AutoComplete
Mon, Aug 19, 4:50 AM
teemperor committed rL369252: [lldb][NFC] Use CompletionRequest in Variable::AutoComplete.
[lldb][NFC] Use CompletionRequest in Variable::AutoComplete
Mon, Aug 19, 4:49 AM
teemperor committed rGfb443746a89d: [lldb][NFC] Add a few more completion tests to increase test coverage (authored by teemperor).
[lldb][NFC] Add a few more completion tests to increase test coverage
Mon, Aug 19, 3:48 AM
teemperor committed rL369249: [lldb][NFC] Add a few more completion tests to increase test coverage.
[lldb][NFC] Add a few more completion tests to increase test coverage
Mon, Aug 19, 3:48 AM
teemperor committed rGb8639f5c0fd8: [lldb][NFC] Remove StringList::AutoComplete (authored by teemperor).
[lldb][NFC] Remove StringList::AutoComplete
Mon, Aug 19, 1:17 AM
teemperor committed rL369242: [lldb][NFC] Remove StringList::AutoComplete.
[lldb][NFC] Remove StringList::AutoComplete
Mon, Aug 19, 1:15 AM
teemperor committed rG81094aad6174: [lldb][NFC] Use GetMaxStringLength in CommandObjectApropos::DoExecute (authored by teemperor).
[lldb][NFC] Use GetMaxStringLength in CommandObjectApropos::DoExecute
Mon, Aug 19, 1:06 AM
teemperor committed rL369240: [lldb][NFC] Use GetMaxStringLength in CommandObjectApropos::DoExecute.
[lldb][NFC] Use GetMaxStringLength in CommandObjectApropos::DoExecute
Mon, Aug 19, 12:59 AM
teemperor closed D66345: [lldb][NFC] Allow for-range iterating over StringList.

Not sure if we can get rid of StringList so easily as we still have SBStringList.

We can keep the SBStringList. We can just have it be backed by a vector<string> instead of the StringList thingy...

Mon, Aug 19, 12:46 AM · Restricted Project
teemperor committed rG21599876be32: [lldb][NFC] Address review comments to StringList for-loop support (authored by teemperor).
[lldb][NFC] Address review comments to StringList for-loop support
Mon, Aug 19, 12:24 AM
teemperor committed rL369237: [lldb][NFC] Address review comments to StringList for-loop support.
[lldb][NFC] Address review comments to StringList for-loop support
Mon, Aug 19, 12:24 AM

Sat, Aug 17

teemperor committed rG37a928efd9f5: [lldb][NFC] Remove unused MaterializeInitializer and MaterializeInternalVariable (authored by teemperor).
[lldb][NFC] Remove unused MaterializeInitializer and MaterializeInternalVariable
Sat, Aug 17, 2:59 PM
teemperor committed rL369198: [lldb][NFC] Remove unused MaterializeInitializer and MaterializeInternalVariable.
[lldb][NFC] Remove unused MaterializeInitializer and MaterializeInternalVariable
Sat, Aug 17, 2:56 PM

Fri, Aug 16

teemperor committed rG4c78b7882506: [lldb][NFC] Allow for-ranges on StringList (authored by teemperor).
[lldb][NFC] Allow for-ranges on StringList
Fri, Aug 16, 7:27 AM
teemperor committed rL369113: [lldb][NFC] Allow for-ranges on StringList.
[lldb][NFC] Allow for-ranges on StringList
Fri, Aug 16, 7:27 AM
teemperor updated the diff for D66345: [lldb][NFC] Allow for-range iterating over StringList.

Not sure if we can get rid of StringList so easily as we still have SBStringList.

Fri, Aug 16, 7:25 AM · Restricted Project
teemperor updated the diff for D66345: [lldb][NFC] Allow for-range iterating over StringList.
  • Fixed some minor issues.
Fri, Aug 16, 6:43 AM · Restricted Project
teemperor created D66345: [lldb][NFC] Allow for-range iterating over StringList.
Fri, Aug 16, 6:37 AM · Restricted Project

Thu, Aug 15

teemperor committed rG2fc20f652cd8: [lldb][NFC] Refactor remaining completion logic to use CompletionRequests (authored by teemperor).
[lldb][NFC] Refactor remaining completion logic to use CompletionRequests
Thu, Aug 15, 6:14 AM
teemperor committed rL369000: [lldb][NFC] Refactor remaining completion logic to use CompletionRequests.
[lldb][NFC] Refactor remaining completion logic to use CompletionRequests
Thu, Aug 15, 6:14 AM
teemperor committed rG5c5408ce2c8c: [lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build… (authored by teemperor).
[lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build…
Thu, Aug 15, 12:31 AM
teemperor committed rL368975: [lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build….
[lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build…
Thu, Aug 15, 12:31 AM
teemperor closed D66208: [lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build failures.
Thu, Aug 15, 12:31 AM · Restricted Project, Restricted Project

Wed, Aug 14

teemperor added a comment to D66208: [lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build failures.

LGTM.

Out of curiosity, do you know why we don't see this on the CMake bot on GreenDragon, which is a modules build? Is this so infrequent that I might have missed it?

http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/

Wed, Aug 14, 2:31 PM · Restricted Project, Restricted Project
teemperor committed rG66214b581c43: Revert "[lldb] Reinstate original guard variable check" (authored by teemperor).
Revert "[lldb] Reinstate original guard variable check"
Wed, Aug 14, 2:22 PM
teemperor committed rL368920: Revert "[lldb] Reinstate original guard variable check".
Revert "[lldb] Reinstate original guard variable check"
Wed, Aug 14, 2:21 PM
teemperor created D66208: [lldb] Let LLDB depend on intrinsics_gen to fix non-deterministic module build failures.
Wed, Aug 14, 3:24 AM · Restricted Project, Restricted Project

Tue, Aug 13

teemperor added a comment to D66175: Improve anonymous class heuristic in ClangASTContext::CreateRecordType .

Could you expand the test (or add another test) for completing in an anonymous classes? Otherwise this LGTM beside Adrian comments assuming this fixes the crash.

Tue, Aug 13, 11:48 PM · Restricted Project
teemperor added a comment to D63165: Initial support for native debugging of x86/x64 Windows processes.

This commit seems to have broken the windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/7780

Tue, Aug 13, 11:43 PM · Restricted Project, Restricted Project
teemperor committed rGafd493ea2b65: [lldb] Reinstate original guard variable check (authored by teemperor).
[lldb] Reinstate original guard variable check
Tue, Aug 13, 10:55 PM
teemperor committed rL368802: [lldb] Reinstate original guard variable check.
[lldb] Reinstate original guard variable check
Tue, Aug 13, 10:51 PM
teemperor committed rGa23b25031e48: [lldb] Fix Microsoft guard variable detection (authored by teemperor).
[lldb] Fix Microsoft guard variable detection
Tue, Aug 13, 7:16 AM
teemperor committed rL368695: [lldb] Fix Microsoft guard variable detection.
[lldb] Fix Microsoft guard variable detection
Tue, Aug 13, 7:13 AM
teemperor committed rG7f7b2966f7be: [lldb] Reland "Refactor guard variable checks in IRForTarget" (authored by teemperor).
[lldb] Reland "Refactor guard variable checks in IRForTarget"
Tue, Aug 13, 6:10 AM
teemperor committed rL368688: [lldb] Reland "Refactor guard variable checks in IRForTarget".
[lldb] Reland "Refactor guard variable checks in IRForTarget"
Tue, Aug 13, 6:08 AM
teemperor committed rG2515640aee77: [lldb][NFC] Add basic IOHandler completion test (authored by teemperor).
[lldb][NFC] Add basic IOHandler completion test
Tue, Aug 13, 5:12 AM
teemperor committed rL368679: [lldb][NFC] Add basic IOHandler completion test.
[lldb][NFC] Add basic IOHandler completion test
Tue, Aug 13, 5:12 AM

Mon, Aug 12

teemperor committed rGdf8bdcadf95e: [lldb][NFC] Minor fixes for lldb_private::DiagnosticManager (authored by teemperor).
[lldb][NFC] Minor fixes for lldb_private::DiagnosticManager
Mon, Aug 12, 7:38 AM
teemperor committed rL368582: [lldb][NFC] Minor fixes for lldb_private::DiagnosticManager.
[lldb][NFC] Minor fixes for lldb_private::DiagnosticManager
Mon, Aug 12, 7:37 AM
teemperor committed rG8940687c6dcb: [lldb] Remove undocumented return value from DiagnosticManager::PutString (authored by teemperor).
[lldb] Remove undocumented return value from DiagnosticManager::PutString
Mon, Aug 12, 7:12 AM
teemperor committed rL368577: [lldb] Remove undocumented return value from DiagnosticManager::PutString.
[lldb] Remove undocumented return value from DiagnosticManager::PutString
Mon, Aug 12, 7:11 AM
teemperor committed rG50286542143a: [lldb][NFC] Add unit test for lldb_private::DiagnosticManager (authored by teemperor).
[lldb][NFC] Add unit test for lldb_private::DiagnosticManager
Mon, Aug 12, 6:34 AM
teemperor committed rL368567: [lldb][NFC] Add unit test for lldb_private::DiagnosticManager.
[lldb][NFC] Add unit test for lldb_private::DiagnosticManager
Mon, Aug 12, 6:34 AM

Sat, Aug 10

teemperor committed rGb448d1bf2122: [lldb] Fix dynamic_cast by no longer failing on variable without metadata (authored by teemperor).
[lldb] Fix dynamic_cast by no longer failing on variable without metadata
Sat, Aug 10, 3:57 AM
teemperor committed rL368511: [lldb] Fix dynamic_cast by no longer failing on variable without metadata.
[lldb] Fix dynamic_cast by no longer failing on variable without metadata
Sat, Aug 10, 3:57 AM
teemperor closed D65932: [lldb] Fix dynamic_cast by no longer failing on variable without metadata.
Sat, Aug 10, 3:57 AM · Restricted Project, Restricted Project
teemperor updated the diff for D65932: [lldb] Fix dynamic_cast by no longer failing on variable without metadata.
  • Rebased patch.
  • Updated title/description.
Sat, Aug 10, 3:21 AM · Restricted Project, Restricted Project
teemperor committed rGc4b5b66a05bb: [clang] Fixed x86 cpuid NSC signature (authored by teemperor).
[clang] Fixed x86 cpuid NSC signature
Sat, Aug 10, 3:18 AM
teemperor committed rL368510: [clang] Fixed x86 cpuid NSC signature.
[clang] Fixed x86 cpuid NSC signature
Sat, Aug 10, 3:13 AM
teemperor closed D65978: [clang] Fixed x86 cpuid NSC signature.
Sat, Aug 10, 3:13 AM · Restricted Project, Restricted Project
teemperor accepted D65978: [clang] Fixed x86 cpuid NSC signature.

LGTM. Thanks for the patch!

Sat, Aug 10, 3:12 AM · Restricted Project, Restricted Project
teemperor added a comment to D65978: [clang] Fixed x86 cpuid NSC signature.

@Jacotot I assume you don't have commit access to merge yourself?

Sat, Aug 10, 1:59 AM · Restricted Project, Restricted Project

Fri, Aug 9

teemperor committed rG19351b24caec: [lldb][NFC] Assert on invalid cursors positions when creating CompletionRequest (authored by teemperor).
[lldb][NFC] Assert on invalid cursors positions when creating CompletionRequest
Fri, Aug 9, 7:34 AM
teemperor committed rL368444: [lldb][NFC] Assert on invalid cursors positions when creating CompletionRequest.
[lldb][NFC] Assert on invalid cursors positions when creating CompletionRequest
Fri, Aug 9, 7:34 AM
teemperor committed rGdb7d874b712d: [lldb][NFC] Remove unused IRForTarget::BuildRelocation (authored by teemperor).
[lldb][NFC] Remove unused IRForTarget::BuildRelocation
Fri, Aug 9, 7:22 AM
teemperor committed rL368442: [lldb][NFC] Remove unused IRForTarget::BuildRelocation.
[lldb][NFC] Remove unused IRForTarget::BuildRelocation
Fri, Aug 9, 7:20 AM
teemperor added a comment to D65932: [lldb] Fix dynamic_cast by no longer failing on variable without metadata.

I only have distant notions of what this code does, so this question might be completely off: Is this the code that decides whether we need to rewrite the accesses to a variable to go through the __lldb_args structure? If yes, I was surprised to learn recently that we rewrite accesses to global variables at all. I understand why we do it for locals, but why not access globals through standard codegen? If the issue your addressing is the result of this transformation, do you have any idea why we do the transformation in the first place?

Fri, Aug 9, 3:38 AM · Restricted Project, Restricted Project