Page MenuHomePhabricator

teemperor (Raphael Isemann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 23 2016, 8:38 AM (273 w, 6 d)

Recent Activity

Today

teemperor added a comment to D104653: [lldb] Avoid using any shell when calling xcrun..

@kastiglione Good point, I dropped using any shell at the source.

Tue, Jun 22, 11:27 AM · Restricted Project
teemperor updated the diff for D104653: [lldb] Avoid using any shell when calling xcrun..
  • Addressing Adrian's comments (sorry for the delay)
Tue, Jun 22, 11:26 AM · Restricted Project
teemperor committed rG709f8186a45e: [lldb] Add missing string include to lldb-server's main (authored by teemperor).
[lldb] Add missing string include to lldb-server's main
Tue, Jun 22, 10:50 AM
teemperor committed rG48e2d3a5c23f: [lldb][NFC] Remove an outdated comment in HostInfoBase (authored by teemperor).
[lldb][NFC] Remove an outdated comment in HostInfoBase
Tue, Jun 22, 7:49 AM
teemperor committed rGc462048cc4c0: [lldb][NFC] Use SubsystemRAII in XcodeSDKModuleTests (authored by teemperor).
[lldb][NFC] Use SubsystemRAII in XcodeSDKModuleTests
Tue, Jun 22, 4:41 AM
teemperor accepted D104697: [lldb] Remove more redundant SetStatus(eReturnStatusFailed).
Tue, Jun 22, 3:40 AM · Restricted Project
teemperor added a reviewer for D104697: [lldb] Remove more redundant SetStatus(eReturnStatusFailed): teemperor.
Tue, Jun 22, 3:36 AM · Restricted Project
teemperor updated subscribers of rG98e2b1a8dd8f: [lldb] Adjust Clang version requirements for tail_call_frames tests.

@vsk Just fixing this to get the matrix bot green when it gets back online, but you might have a better idea how to fix this (like, making the call site info decorator more strict?). FWIW, all the failing tests with their output can be found here: https://ci.teemperor.de/job/llvm-master-test-matrix/30/

Tue, Jun 22, 3:25 AM
teemperor added 1 auditor(s) for rG98e2b1a8dd8f: [lldb] Adjust Clang version requirements for tail_call_frames tests: vsk.
Tue, Jun 22, 3:24 AM
teemperor committed rG98e2b1a8dd8f: [lldb] Adjust Clang version requirements for tail_call_frames tests (authored by teemperor).
[lldb] Adjust Clang version requirements for tail_call_frames tests
Tue, Jun 22, 3:24 AM
teemperor committed rG35cf5b109769: [lldb] Bumb Clang version requirement for TestBasicEntryValues.py to 11 (authored by teemperor).
[lldb] Bumb Clang version requirement for TestBasicEntryValues.py to 11
Tue, Jun 22, 2:58 AM
teemperor committed rZORG478f6eb87c87: [lldb] Actually let the matrix bot test something (authored by teemperor).
[lldb] Actually let the matrix bot test something
Tue, Jun 22, 2:14 AM
teemperor accepted D104067: [lldb] Decouple ObjCLanguage from Symtab.

LGTM, thanks!

Tue, Jun 22, 1:09 AM · Restricted Project

Yesterday

teemperor committed rGc197cddb16b3: [lldb] Add support for escaping zsh arguments (authored by teemperor).
[lldb] Add support for escaping zsh arguments
Mon, Jun 21, 10:47 AM
teemperor closed D104627: [lldb] Add support for escaping zsh arguments.
Mon, Jun 21, 10:47 AM · Restricted Project
teemperor committed rG1265f05c268f: [lldb] Skip TestLimitDebugInfo for Clang<7 (authored by teemperor).
[lldb] Skip TestLimitDebugInfo for Clang<7
Mon, Jun 21, 10:47 AM
teemperor added a comment to D104437: Add test for functions with extended characters..

Ah, my grep/find skills clearly failed me :)

Yeah, those tests are exactly the same scenarios. However, if I understand correctly, don't they use the API? I wanted to add some coverage for the shell because I'm making changes to the Editline wrapper, and the existing tests don't appear to cover user input from the command line. But maybe I'm missing how those two tie together. Thanks.

Mon, Jun 21, 9:54 AM · Restricted Project
teemperor committed rG0a2d4f3f24a3: [lldb] Enable Rust v0 symbol demangling (authored by Alexander Mols <asm@fb.com>).
[lldb] Enable Rust v0 symbol demangling
Mon, Jun 21, 9:21 AM
teemperor closed D104054: [lldb] Enable Rust v0 symbol demangling.
Mon, Jun 21, 9:20 AM · Restricted Project
teemperor added a comment to D104653: [lldb] Avoid using any shell when calling xcrun..

FWIW, I'm open to preferring bash over zsh as the default shell. But as zsh is already the default on macOS we might as well start using it when possible.

Mon, Jun 21, 9:19 AM · Restricted Project
teemperor retitled D104653: [lldb] Avoid using any shell when calling xcrun. from [lldb] Explicitly prefer a vanilla shell (zsh, bash, sh) over the user's default shell to [lldb] Explicitly prefer a vanilla shell (zsh, bash, sh) over the user's default shell when running `xcrun`.
Mon, Jun 21, 8:54 AM · Restricted Project
teemperor requested review of D104653: [lldb] Avoid using any shell when calling xcrun..
Mon, Jun 21, 8:54 AM · Restricted Project
teemperor updated the diff for D104627: [lldb] Add support for escaping zsh arguments.
  • Add pipe and backslash
Mon, Jun 21, 7:53 AM · Restricted Project
teemperor updated the diff for D104635: [lldb] Add support for escaping fish arguments.
  • Upload the fish diff
Mon, Jun 21, 7:53 AM · Restricted Project
teemperor added a comment to D104635: [lldb] Add support for escaping fish arguments.

Whoops, wrong diff...

Mon, Jun 21, 7:52 AM · Restricted Project
teemperor updated the diff for D104635: [lldb] Add support for escaping fish arguments.
  • Add pipe and backslash also as special characters.
Mon, Jun 21, 5:19 AM · Restricted Project
teemperor requested review of D104635: [lldb] Add support for escaping fish arguments.
Mon, Jun 21, 5:14 AM · Restricted Project
teemperor added a comment to rGf2c009dbcfd1: [lldb-vscode] attempt to fix flakiness.

ProgressEventThreadFunction is now unused which will raise a warning (and break -Werror builds):

Mon, Jun 21, 4:48 AM
teemperor committed rG7f20e6ae3229: [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses (authored by teemperor).
[lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses
Mon, Jun 21, 4:34 AM
teemperor closed D104221: [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses.
Mon, Jun 21, 4:34 AM · Restricted Project
teemperor requested changes to D104067: [lldb] Decouple ObjCLanguage from Symtab.

ping!

Sorry, feel free to me directly sooner :)

Mon, Jun 21, 4:18 AM · Restricted Project
teemperor requested changes to D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime..

Could you move this function into the Debugger class and just make SBDebugger forward to that function? We usually keep the SB* classes as thin wrappers that only contain binding specific logic and have the actual implementation in the sibling class without the SB prefix.

Mon, Jun 21, 3:47 AM · Restricted Project
teemperor requested review of D104629: [lldb] Escape semicolons for all shells.
Mon, Jun 21, 3:29 AM · Restricted Project
teemperor added a reviewer for D104627: [lldb] Add support for escaping zsh arguments: JDevlieghere.
Mon, Jun 21, 3:27 AM · Restricted Project
teemperor updated the diff for D104627: [lldb] Add support for escaping zsh arguments.
  • Remove $ so that env variables will be expanded.
Mon, Jun 21, 3:13 AM · Restricted Project
teemperor requested review of D104627: [lldb] Add support for escaping zsh arguments.
Mon, Jun 21, 3:07 AM · Restricted Project
teemperor added a comment to D104525: [lldb] Assert that CommandResultObject error messages are not empty.

Yeah good point, I can do that. I'm gonna go over the remaining SetStatus calls first, then I'll look at it.

Mon, Jun 21, 3:02 AM · Restricted Project
teemperor added a comment to D104525: [lldb] Assert that CommandResultObject error messages are not empty.

LGTM, thanks for cleaning this up.

Mon, Jun 21, 2:54 AM · Restricted Project

Thu, Jun 17

teemperor added a comment to D104444: [lldb] Fix complex integer type parsing for GCC.

FYI GDB does not support these complex types.
GCC discusses it as PR debug/93988.

Thu, Jun 17, 10:26 AM · Restricted Project
teemperor planned changes to D104444: [lldb] Fix complex integer type parsing for GCC.

Is this specific to GCC? To be on the safe side, would it make sense to check like type_name == "__unknown__" && compiler == GCC?

Thu, Jun 17, 6:35 AM · Restricted Project
teemperor accepted D104448: [lldb] Remove redundant calls to set eReturnStatusFailed.

LGTM now, just a small nit about the redundant "error: " string.

Thu, Jun 17, 6:28 AM · Restricted Project
teemperor requested changes to D104448: [lldb] Remove redundant calls to set eReturnStatusFailed.

There are two places where this isn't redundant (see inline comments) but otherwise this LGTM. Thanks!

Thu, Jun 17, 5:05 AM · Restricted Project
teemperor added a reviewer for D104448: [lldb] Remove redundant calls to set eReturnStatusFailed: teemperor.
Thu, Jun 17, 4:54 AM · Restricted Project
teemperor added inline comments to D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children.
Thu, Jun 17, 3:36 AM · Restricted Project
teemperor updated the diff for D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children.
  • Added a unit test (thanks Shafik!)
Thu, Jun 17, 3:34 AM · Restricted Project
teemperor added a reviewer for D104444: [lldb] Fix complex integer type parsing for GCC: werat.
Thu, Jun 17, 2:34 AM · Restricted Project
teemperor requested review of D104444: [lldb] Fix complex integer type parsing for GCC.
Thu, Jun 17, 2:33 AM · Restricted Project
teemperor requested changes to D104437: Add test for functions with extended characters..

Thanks for writing tests, it's really appreciated! FWIW, I think that you can just check in new tests without having to go through a full review (unless you do want feedback for it).

Thu, Jun 17, 1:52 AM · Restricted Project
teemperor committed rG25fa67868b36: [lldb] Skip variant/optional libc++ tests for Clang 5/6 (authored by teemperor).
[lldb] Skip variant/optional libc++ tests for Clang 5/6
Thu, Jun 17, 12:54 AM

Wed, Jun 16

teemperor accepted D104379: [lldb] Remove redundant calls to set eReturnStatusFailed.

LGTM and passes on macOS and Linux for me. Thanks!

Wed, Jun 16, 8:30 AM · Restricted Project
teemperor accepted D104380: [lldb] Set return object failed status even if error string is empty.

At least on the test suite on Linux that branch is anyway never taken, so LGTM. Thanks!

Wed, Jun 16, 8:24 AM · Restricted Project
teemperor added a comment to D104377: [lldb] Don't try to set -Wno-deprecated-declarations.

There is some cleanup that needs to be done before this can land. https://reviews.llvm.org/D104374 fixes some deprecation warnings from Python and there are some macOS APIs that got deprecated (which I still need to fix)

Wed, Jun 16, 6:32 AM · Restricted Project
teemperor requested review of D104377: [lldb] Don't try to set -Wno-deprecated-declarations.
Wed, Jun 16, 6:30 AM · Restricted Project
teemperor requested review of D104375: [lldb] Don't try to set -Wno-deprecated-register.
Wed, Jun 16, 6:26 AM · Restricted Project
teemperor requested review of D104374: [lldb] Rework the Python threading initialization.
Wed, Jun 16, 6:19 AM · Restricted Project
teemperor committed rG59d58863bc0e: [lldb] Require Clang 8 for gpubnames test (authored by teemperor).
[lldb] Require Clang 8 for gpubnames test
Wed, Jun 16, 5:07 AM
teemperor committed rG3b7795aeceb1: [lldb] vwprintw -> vw_printw in IOHandlerCursesGUI (authored by teemperor).
[lldb] vwprintw -> vw_printw in IOHandlerCursesGUI
Wed, Jun 16, 4:14 AM

Tue, Jun 15

teemperor committed rGb8567559cf38: [lldb] Make the ClassTemplateDecl merging logic in TypeSystemClang respect… (authored by teemperor).
[lldb] Make the ClassTemplateDecl merging logic in TypeSystemClang respect…
Tue, Jun 15, 10:25 AM
teemperor closed D100662: [lldb] Make the ClassTemplateDecl merging logic in TypeSystemClang respect template parameters.
Tue, Jun 15, 10:25 AM · Restricted Project
teemperor updated the diff for D100662: [lldb] Make the ClassTemplateDecl merging logic in TypeSystemClang respect template parameters.
  • assert -> lldbassert
Tue, Jun 15, 9:46 AM · Restricted Project
teemperor added a comment to D104281: [lldb][docs] Add reference docs for Lua scripting.

In fact, the same idea also occurred to me before. I think it's also achievable by a plugin sphinx-code-tabs.

Tue, Jun 15, 9:42 AM · Restricted Project
teemperor requested review of D104307: [lldb] Remove SBHostOS threading functionality.
Tue, Jun 15, 9:36 AM
teemperor accepted D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py.

Personally I think if there is the pointer (and sizeof(std::unique_ptr<XXX, YYY> == 16) there should be the "deleter =" specified even if it is default deleter.

Tue, Jun 15, 2:13 AM · Restricted Project
teemperor requested changes to D104283: [lldb] Fix libstdc++ 11's std::unique_ptr affecting LLDB testsuite TestDataFormatterStdUniquePtr.py.

I think the way the provider is supposed to work is that there is always deleter child as long as it's not default_delete<T>, so I think we have to check for the name to avoid that we also hide an empty user-specified deleter.

Tue, Jun 15, 12:44 AM · Restricted Project

Mon, Jun 14

teemperor added a comment to D104281: [lldb][docs] Add reference docs for Lua scripting.

Instead of copying the text from the Python page, I was actually thinking whether we should make the 'scripting' page more generic and just add the language-specific examples for Python and Lua there. I am not sure what's the best way to do that visually though with RST. We could just go for raw HTML and use a tab switcher like this:

Mon, Jun 14, 11:46 PM · Restricted Project
teemperor added a reviewer for D104281: [lldb][docs] Add reference docs for Lua scripting: JDevlieghere.
Mon, Jun 14, 10:54 PM · Restricted Project
teemperor added a comment to D104231: [lldb] Deprecate the threading functionality in SBHostOS.

Not sure what else we should do to properly deprecate an API. LLVM's approach would be to put [[deprecated("bla")]] the C++ APIs (which would mean you need a C++14 compiler to use the SB API) and there is also the lldb-versioning.h header (which seems to be reserved for actual API breakages).

Mon, Jun 14, 8:22 AM · Restricted Project
teemperor updated the diff for D104231: [lldb] Deprecate the threading functionality in SBHostOS.
  • Remove the deprecation attribute that got inserted by accident.
Mon, Jun 14, 8:16 AM · Restricted Project
teemperor requested review of D104231: [lldb] Deprecate the threading functionality in SBHostOS.
Mon, Jun 14, 8:14 AM · Restricted Project
teemperor committed rGd94ce1a391cb: [lldb][docs] Add the missing rst anchors to the Python enum docs (authored by teemperor).
[lldb][docs] Add the missing rst anchors to the Python enum docs
Mon, Jun 14, 7:32 AM
teemperor committed rGe3d5e3193fd5: [lldb][docs] Fix section name for InputReaderGranularity (authored by teemperor).
[lldb][docs] Fix section name for InputReaderGranularity
Mon, Jun 14, 7:22 AM
teemperor requested review of D104221: [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses.
Mon, Jun 14, 5:59 AM · Restricted Project
teemperor committed rG11e2922bb7ad: [lldb][docs] Document SBType (authored by teemperor).
[lldb][docs] Document SBType
Mon, Jun 14, 4:20 AM
teemperor closed D103454: [lldb][docs] Document SBType.
Mon, Jun 14, 4:19 AM · Restricted Project
teemperor updated the diff for D103454: [lldb][docs] Document SBType.
  • Make language more uniform
  • Point out anonymous struct is a GNU extension.
Mon, Jun 14, 4:02 AM · Restricted Project
teemperor accepted D104041: [lldb] Replace default bodies of special member functions with = default;.

Not sure what happened to my accept, but I'll LGTM this again. Thanks!

Mon, Jun 14, 3:14 AM

Fri, Jun 11

teemperor committed rG60fde9542aac: [lldb] Remove GCC XFAIL for TestCPPAuto and TestClassTemplateParameterPack (authored by teemperor).
[lldb] Remove GCC XFAIL for TestCPPAuto and TestClassTemplateParameterPack
Fri, Jun 11, 2:22 PM
teemperor added a comment to D103675: [LLDB/API] Expose args and env from SBProcessInfo..

Not sure why this failed. Is it perhaps a difference where some processes have args including the executable and some do not?

Fri, Jun 11, 10:10 AM · Restricted Project
teemperor accepted D104054: [lldb] Enable Rust v0 symbol demangling.

LGTM, thanks! (And congrats on your first patch)

Fri, Jun 11, 9:53 AM · Restricted Project
teemperor committed rGab46490dfc5c: [lldb] Remove GCC XFAIL for TestTypedefArray (authored by teemperor).
[lldb] Remove GCC XFAIL for TestTypedefArray
Fri, Jun 11, 7:25 AM
teemperor committed rGb1603cb66fc6: [lldb] Fix compilation after removal of APInt::toString (authored by teemperor).
[lldb] Fix compilation after removal of APInt::toString
Fri, Jun 11, 7:21 AM
teemperor committed rGe2d0798bc3e4: [lldb] Unmark TestInlines as XFAIL for gcc (authored by teemperor).
[lldb] Unmark TestInlines as XFAIL for gcc
Fri, Jun 11, 7:07 AM
teemperor reopened D81550: [lldb] Add support for evaluating expressions in static member functions.

Reopen because of the revert.

Fri, Jun 11, 6:02 AM · Restricted Project
teemperor added a reverting change for rG00764c36edf8: [lldb] Add support for evaluating expressions in static member functions: rG4125b46232ca: Revert "[lldb] Add support for evaluating expressions in static member….
Fri, Jun 11, 6:01 AM
teemperor committed rG4125b46232ca: Revert "[lldb] Add support for evaluating expressions in static member… (authored by teemperor).
Revert "[lldb] Add support for evaluating expressions in static member…
Fri, Jun 11, 6:01 AM
teemperor added a reverting change for D81550: [lldb] Add support for evaluating expressions in static member functions: rG4125b46232ca: Revert "[lldb] Add support for evaluating expressions in static member….
Fri, Jun 11, 6:01 AM · Restricted Project
teemperor added inline comments to D103750: [analyzer] Handle std::make_unique for SmartPtrModeling.
Fri, Jun 11, 5:00 AM · Restricted Project
teemperor added a comment to D103750: [analyzer] Handle std::make_unique for SmartPtrModeling.

How do I set the C++ standard while running a test?

Fri, Jun 11, 1:23 AM · Restricted Project
teemperor requested changes to D104067: [lldb] Decouple ObjCLanguage from Symtab.

This looks pretty good to me.

It's a little awkward in InitNameIndexes that we look up the various NameToSymbolIndex maps by eFunctionNameType, use the function name type again to sort the names & index pairs into the bucket we looked up before. I wonder if that could be made cleaner by having an

AddToSymbolNameToIndexMap(symbol_name, index, func_name_type)

interface, which would just sort the symbol names into the right map. Not sure that's worth the bother, however.

Fri, Jun 11, 12:38 AM · Restricted Project
teemperor accepted D104091: [lldb] Fix leak in test.

LGTM, big thanks for the patch & quick turnaround!

Fri, Jun 11, 12:05 AM · Restricted Project

Thu, Jun 10

teemperor committed rG632cbcac7906: [lldb] Move once_flags in HostInfoLinux so the internal state struct (authored by teemperor).
[lldb] Move once_flags in HostInfoLinux so the internal state struct
Thu, Jun 10, 11:54 PM
teemperor closed D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct.
Thu, Jun 10, 11:54 PM · Restricted Project
teemperor added inline comments to D104091: [lldb] Fix leak in test.
Thu, Jun 10, 11:47 PM · Restricted Project
teemperor requested changes to D104091: [lldb] Fix leak in test.

I think we should instead implement the Terminate function that the plugin system provides to tear down our state. I made a patch in D104093 that
moves the once_flags to the internal state struct, so with a proper Terminate implementation + my patch this should all work properly.

Thu, Jun 10, 11:45 PM · Restricted Project
teemperor requested review of D104093: [lldb] Move once_flags in HostInfoLinux so the internal state struct.
Thu, Jun 10, 11:41 PM · Restricted Project
teemperor added inline comments to D104054: [lldb] Enable Rust v0 symbol demangling.
Thu, Jun 10, 2:48 PM · Restricted Project
teemperor added a comment to D104054: [lldb] Enable Rust v0 symbol demangling.

This seems reasonable to me, but I'll leave this open for a while in case someone that knows more about Rust mangling shows up. Otherwise I'll accept this next week.

Thu, Jun 10, 1:59 PM · Restricted Project
teemperor added a comment to D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls.

Sure I can take a look, but I don't see the immediate problem when looking at the backtrace.

Thu, Jun 10, 1:10 PM · Restricted Project
teemperor added a comment to D104041: [lldb] Replace default bodies of special member functions with = default;.

LGTM beside some minor formatting bugs that got exacerbated by the clang-tidy run. I got bored of writing 'format' everywhere so I translated every comment into a different language via Google translate. I'll already accept this as this is easy to fix.

Thu, Jun 10, 9:50 AM

Wed, Jun 9

teemperor accepted D103483: [lldb] Convert the default constructor’s member initializers into default member initializers.

This doesn't compile for me (on Linux):

Wed, Jun 9, 8:23 AM · Restricted Project