Page MenuHomePhabricator

teemperor (Raphael Isemann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 23 2016, 8:38 AM (169 w, 1 h)

Recent Activity

Fri, May 31

teemperor added a comment to D62743: Add color to the default thread and frame format..

+1. I'm (obviously) in favor of this.

Fri, May 31, 10:39 AM · Restricted Project, Restricted Project
teemperor accepted D62714: [FormatEntity] Ignore ASCII escape sequences when colors are disabled..

LGTM, thanks!

Fri, May 31, 1:15 AM · Restricted Project, Restricted Project

Tue, May 21

teemperor abandoned D61231: Add 'oneOf' utility function for comparing a ConstString against a set of strings.
Tue, May 21, 4:03 PM · Restricted Project

May 13 2019

teemperor added inline comments to D61847: [lldb] NFC modernize codebase with modernize-use-nullptr.
May 13 2019, 2:32 AM · Restricted Project, Restricted Project
teemperor added a reviewer for D61847: [lldb] NFC modernize codebase with modernize-use-nullptr: Restricted Project.
May 13 2019, 1:53 AM · Restricted Project, Restricted Project

May 10 2019

teemperor added a comment to D61737: [lldb] add -ex CLI option as alias to --one-line.
In D61737#1497785, @kwk wrote:

I would rather not clutter up the lldb command driver's options with gdb command flags. That seems like it will make lldb harder to figure out and reduce our freedom to choose reasonable short names for lldb driver options.

It is good to have this discussion early on and that is exactly why I've picked this little example option -ex in the first place. I was about to add more options/flags/parameters that borrow from GDB. Another reason why I *just* want to add more GDB commands instead of introducing a *GDB mode* is because I don't want to make a false promise. I'd rather try to bring a lot of commands from GDB over and if one is missing, that's fine because it might not be used that often. But if we have a switch to the lldb binary that means we promise something that we don't keep. In essence I rather like a soft-gdb-mode in GDB just by *accidentally* allowing for the same commands *and* CLI arguments than a hard-gdb-mode.

May 10 2019, 12:59 AM · Restricted Project

May 9 2019

teemperor added a comment to D61737: [lldb] add -ex CLI option as alias to --one-line.

If it's just about adding some commonly used GDB flags I'm fine with adding them to the normal LLDB flags. If the plan is to implement most/all of the flags GDB supports, then I would prefer having something like --gdb or lldb-gdb (which seems anyway necessary to resolve the conflicts with the current LLDB flags like -x, -b, -l, etc.).

May 9 2019, 12:02 PM · Restricted Project
teemperor added a comment to D61737: [lldb] add -ex CLI option as alias to --one-line.

Not sure if I like this change. We don't have single dash flags with multiple characters in LLDB, so this flag looks a bit out of place. And there is the bigger question if we really want to be compatible with the GDB flags (which are already incompatible with the flags LLDB is currently offering). If we really go this way then I would suggest we also add more commonly used GDB flags like --args.

May 9 2019, 11:30 AM · Restricted Project

May 6 2019

teemperor created D61606: Add support for importing general C++ modules into the LLDB expression evaluator.
May 6 2019, 12:19 PM · Restricted Project, Restricted Project

May 5 2019

teemperor created D61565: Ignore generated @import statements in the expression evaluator to fix import-std-module tests on macOS.
May 5 2019, 4:56 AM · Restricted Project, Restricted Project

May 3 2019

teemperor committed rG090a5b29b881: Fixed some minor style issues in rLLDB359921 [NFC] (authored by teemperor).
Fixed some minor style issues in rLLDB359921 [NFC]
May 3 2019, 2:00 PM
teemperor committed rL359931: Fixed some minor style issues in rLLDB359921 [NFC].
Fixed some minor style issues in rLLDB359921 [NFC]
May 3 2019, 2:00 PM
teemperor committed rLLDB359931: Fixed some minor style issues in rLLDB359921 [NFC].
Fixed some minor style issues in rLLDB359921 [NFC]
May 3 2019, 2:00 PM
teemperor accepted D61483: [www] list command: lldb run <args>.

LGTM, seems consistent with the row above

May 3 2019, 3:13 AM · Restricted Project
teemperor committed rG1756630dfaa1: C.128 override, virtual keyword handling (authored by teemperor).
C.128 override, virtual keyword handling
May 3 2019, 3:03 AM
teemperor committed rLLDB359868: C.128 override, virtual keyword handling.
C.128 override, virtual keyword handling
May 3 2019, 3:03 AM
teemperor committed rL359868: C.128 override, virtual keyword handling.
C.128 override, virtual keyword handling
May 3 2019, 3:02 AM
teemperor closed D61440: C.128 override, virtual keyword handling.
May 3 2019, 3:02 AM · Restricted Project, Restricted Project
teemperor added a comment to D61440: C.128 override, virtual keyword handling.

Looks good now, thanks!

May 3 2019, 12:10 AM · Restricted Project, Restricted Project

May 2 2019

teemperor updated the summary of D61478: Move decl completion out of the ASTImporterDelegate and document it [NFC].
May 2 2019, 11:51 PM · Restricted Project
teemperor created D61478: Move decl completion out of the ASTImporterDelegate and document it [NFC].
May 2 2019, 11:51 PM · Restricted Project
teemperor added a comment to D61440: C.128 override, virtual keyword handling.

You don't have to use arc, you can also just update the code via the "Update diff" button and upload a patch file. So it doesn't really matter how you organize your local git branch as long as you can produce a patch file from the changes. Phabricator takes care of making diffs between the patches you upload, so there is always a change history here.

May 2 2019, 2:19 PM · Restricted Project, Restricted Project
teemperor added a comment to D61440: C.128 override, virtual keyword handling.

Not sure how you invoke git clang-format, but I assume you specified the wrong commit range...

May 2 2019, 12:57 PM · Restricted Project, Restricted Project
teemperor accepted D61440: C.128 override, virtual keyword handling.

FYI, I still think there are some style issues there (e.g. the AppleObjCRuntimeV2.cpp change makes it longer than 80 chars) but I can just clang-format this before committing.

May 2 2019, 12:40 PM · Restricted Project, Restricted Project
teemperor added a comment to D61440: C.128 override, virtual keyword handling.
In D61440#1488424, @kwk wrote:

LGTM module some minor code style issues (You removed some virtuals but didn't fix the indentation of the parameters on the next line, see the inline comments for examples).

@teemperor I would have loved to use clang-format for this but apparently the LLDB code is still manually formatted. It would be a bliss to just use the LLVM clang-format style and never ever talk about "style" again.

May 2 2019, 12:36 PM · Restricted Project, Restricted Project
teemperor committed rG21db1440f9b2: Remove unnecessary check in SymbolFileDWARF::ParseImportedModules (authored by teemperor).
Remove unnecessary check in SymbolFileDWARF::ParseImportedModules
May 2 2019, 11:29 AM
teemperor committed rL359813: Remove unnecessary check in SymbolFileDWARF::ParseImportedModules.
Remove unnecessary check in SymbolFileDWARF::ParseImportedModules
May 2 2019, 11:25 AM
teemperor committed rLLDB359813: Remove unnecessary check in SymbolFileDWARF::ParseImportedModules.
Remove unnecessary check in SymbolFileDWARF::ParseImportedModules
May 2 2019, 11:24 AM
teemperor closed D61394: Remove unnecessary check in SymbolFileDWARF::ParseImportedModules.
May 2 2019, 11:24 AM · Restricted Project, Restricted Project
teemperor added a comment to D61438: [ASTImporter] Use llvm::Expected and Error in the importer API.

I think the best way to handle these errors in LLDB is to just log and then return some default value. That should make the current command print an error, which is better than terminating LLDB.

May 2 2019, 10:59 AM · Restricted Project, Restricted Project, Restricted Project
teemperor accepted D61440: C.128 override, virtual keyword handling.

LGTM module some minor code style issues (You removed some virtuals but didn't fix the indentation of the parameters on the next line, see the inline comments for examples).

May 2 2019, 10:23 AM · Restricted Project, Restricted Project
teemperor committed rG9a0acdf65e7f: Add std::stack and std::queue support to CxxModuleHandler (authored by teemperor).
Add std::stack and std::queue support to CxxModuleHandler
May 2 2019, 4:25 AM
teemperor committed rLLDB359779: Add std::stack and std::queue support to CxxModuleHandler.
Add std::stack and std::queue support to CxxModuleHandler
May 2 2019, 4:23 AM
teemperor committed rL359779: Add std::stack and std::queue support to CxxModuleHandler.
Add std::stack and std::queue support to CxxModuleHandler
May 2 2019, 4:23 AM
teemperor closed D61305: Add std::stack and std::queue support to CxxModuleHandler.
May 2 2019, 4:23 AM · Restricted Project, Restricted Project, Restricted Project
teemperor committed rG3356c32098d5: Rename Minion to ASTImporterDelegate (authored by teemperor).
Rename Minion to ASTImporterDelegate
May 2 2019, 3:57 AM
teemperor committed rLLDB359777: Rename Minion to ASTImporterDelegate.
Rename Minion to ASTImporterDelegate
May 2 2019, 3:56 AM
teemperor committed rL359777: Rename Minion to ASTImporterDelegate.
Rename Minion to ASTImporterDelegate
May 2 2019, 3:56 AM
teemperor closed D61299: Rename Minion to ASTImporterDelegate.
May 2 2019, 3:56 AM · Restricted Project, Restricted Project
teemperor closed D61140: Copy Argument Passing Restrictions setting when importing a CXXRecordDecl definition.

This has been landed as rC359338 but somehow Phabricator didn't close this. Closing this manually.

May 2 2019, 3:30 AM
teemperor closed D61266: Skip TestClassTemplateParameterPack.py on all platforms.

This has been merged as rLLDB359699 but somehow Phabriactor hasn't figured out yet that this needs to be closed. Closing this manually.

May 2 2019, 3:27 AM
teemperor committed rG71569d0d5234: Inject only relevant local variables in the expression evaluation context (authored by teemperor).
Inject only relevant local variables in the expression evaluation context
May 2 2019, 3:14 AM
teemperor committed rL359773: Inject only relevant local variables in the expression evaluation context.
Inject only relevant local variables in the expression evaluation context
May 2 2019, 3:14 AM
teemperor committed rLLDB359773: Inject only relevant local variables in the expression evaluation context.
Inject only relevant local variables in the expression evaluation context
May 2 2019, 3:14 AM
teemperor closed D46551: Inject only relevant local variables in the expression evaluation context.
May 2 2019, 3:14 AM · Restricted Project
teemperor updated the diff for D61299: Rename Minion to ASTImporterDelegate.
  • Added documentation.
  • Fixed more references to 'minion' pointed out in the review.
May 2 2019, 3:03 AM · Restricted Project, Restricted Project

May 1 2019

teemperor created D61394: Remove unnecessary check in SymbolFileDWARF::ParseImportedModules.
May 1 2019, 12:17 PM · Restricted Project, Restricted Project
teemperor added a comment to D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.

As we're anyway throwing in reduced test cases, here is another version:

May 1 2019, 10:31 AM · Restricted Project
teemperor committed rG290be2a3b744: Fix build URL in new LLDB website (authored by teemperor).
Fix build URL in new LLDB website
May 1 2019, 2:54 AM
teemperor committed rLLDB359665: Fix build URL in new LLDB website.
Fix build URL in new LLDB website
May 1 2019, 2:53 AM
teemperor committed rL359665: Fix build URL in new LLDB website.
Fix build URL in new LLDB website
May 1 2019, 2:52 AM
teemperor closed D61368: Fix build URL in new LLDB website.
May 1 2019, 2:52 AM · Restricted Project, Restricted Project
teemperor committed rGc53f8db770d7: Removed unnecessary conversion to StringRef (authored by teemperor).
Removed unnecessary conversion to StringRef
May 1 2019, 2:49 AM
teemperor committed rLLDB359664: Removed unnecessary conversion to StringRef.
Removed unnecessary conversion to StringRef
May 1 2019, 2:49 AM
teemperor committed rL359664: Removed unnecessary conversion to StringRef.
Removed unnecessary conversion to StringRef
May 1 2019, 2:49 AM
teemperor added a comment to D61368: Fix build URL in new LLDB website.

I just realized that you probably don't have commit access yet, so I'll commit this for you. Thanks for the patch!

May 1 2019, 2:49 AM · Restricted Project, Restricted Project
teemperor accepted D61368: Fix build URL in new LLDB website.
May 1 2019, 1:00 AM · Restricted Project, Restricted Project

Apr 30 2019

teemperor created D61305: Add std::stack and std::queue support to CxxModuleHandler.
Apr 30 2019, 5:04 AM · Restricted Project, Restricted Project, Restricted Project
teemperor committed rG9a7ccd01b6f6: Sort containers alphabetically in CxxModuleHandler [NFC] (authored by teemperor).
Sort containers alphabetically in CxxModuleHandler [NFC]
Apr 30 2019, 3:28 AM
teemperor committed rLLDB359546: Sort containers alphabetically in CxxModuleHandler [NFC].
Sort containers alphabetically in CxxModuleHandler [NFC]
Apr 30 2019, 3:27 AM
teemperor committed rL359546: Sort containers alphabetically in CxxModuleHandler [NFC].
Sort containers alphabetically in CxxModuleHandler [NFC]
Apr 30 2019, 3:27 AM
teemperor created D61299: Rename Minion to ASTImporterDelegate.
Apr 30 2019, 2:55 AM · Restricted Project, Restricted Project
teemperor added inline comments to D59537: Instantiate 'std' templates explicitly in the expression evaluator.
Apr 30 2019, 1:47 AM · Restricted Project, Restricted Project, Restricted Project
teemperor committed rGf74a4c1f6df9: Instantiate 'std' templates explicitly in the expression evaluator (authored by teemperor).
Instantiate 'std' templates explicitly in the expression evaluator
Apr 30 2019, 1:42 AM
teemperor committed rL359538: Instantiate 'std' templates explicitly in the expression evaluator.
Instantiate 'std' templates explicitly in the expression evaluator
Apr 30 2019, 1:42 AM
teemperor committed rLLDB359538: Instantiate 'std' templates explicitly in the expression evaluator.
Instantiate 'std' templates explicitly in the expression evaluator
Apr 30 2019, 1:42 AM
teemperor closed D59537: Instantiate 'std' templates explicitly in the expression evaluator.
Apr 30 2019, 1:41 AM · Restricted Project, Restricted Project, Restricted Project

Apr 29 2019

teemperor added inline comments to D61146: Set a CXXRecordDecl to not be passed in registers if DW_CC_pass_by_reference when loading from DWARF.
Apr 29 2019, 3:26 PM · Restricted Project
teemperor committed rGe9bc35fe064b: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior. (authored by teemperor).
[ASTImporter] Add an ImportImpl method to allow customizing Import behavior.
Apr 29 2019, 2:03 PM
teemperor committed rC359502: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior..
[ASTImporter] Add an ImportImpl method to allow customizing Import behavior.
Apr 29 2019, 2:03 PM
teemperor committed rL359502: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior..
[ASTImporter] Add an ImportImpl method to allow customizing Import behavior.
Apr 29 2019, 2:03 PM
teemperor closed D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior..
Apr 29 2019, 2:03 PM · Restricted Project
teemperor added a comment to D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior..

I'll land this as it seems only the tests are subject to change and I want to also land the dependencies of this patch. Please let me know if you want any other changes changes to the test and thanks for the review!

Apr 29 2019, 2:03 PM · Restricted Project
teemperor planned changes to D61244: Re-enable gmodules tests on Linux.

I looked into this a bit further and I think the best way forward is to enable gmodules on Linux but exclude all tests that rely on system modules (i.e. std or libc) as that really seems to be a messy situation. I'll update the patch accordingly.

Apr 29 2019, 1:51 PM · Restricted Project
teemperor added inline comments to D59537: Instantiate 'std' templates explicitly in the expression evaluator.
Apr 29 2019, 1:14 PM · Restricted Project, Restricted Project, Restricted Project
teemperor updated the diff for D59537: Instantiate 'std' templates explicitly in the expression evaluator.
  • Fixed m_sema documentation.
Apr 29 2019, 1:01 PM · Restricted Project, Restricted Project, Restricted Project
teemperor updated the diff for D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior..
  • Refactored test according to Gábor's feedback.
Apr 29 2019, 11:19 AM · Restricted Project
teemperor accepted D61266: Skip TestClassTemplateParameterPack.py on all platforms.
So a long-term fix for this would require at least reworking ho that debug information is generated.
Apr 29 2019, 10:12 AM
teemperor updated the diff for D61244: Re-enable gmodules tests on Linux.
  • Add 'linux' to the list of platforms supporting gmodules.
Apr 29 2019, 3:09 AM · Restricted Project
teemperor added a comment to D61244: Re-enable gmodules tests on Linux.

LG, but note that this has no effect on the overall set of tests which will run as long as gmodules remains disabled in test_categories.is_supported_on_platform.

Apr 29 2019, 3:07 AM · Restricted Project

Apr 28 2019

teemperor updated the summary of D61244: Re-enable gmodules tests on Linux.
Apr 28 2019, 12:22 PM · Restricted Project
teemperor created D61244: Re-enable gmodules tests on Linux.
Apr 28 2019, 12:22 PM · Restricted Project
teemperor added a comment to D61231: Add 'oneOf' utility function for comparing a ConstString against a set of strings.

Yeah, I'm also just like 60% confident that this more readable/expressive.

Apr 28 2019, 11:17 AM · Restricted Project
teemperor requested changes to D61235: Add more information to the log timer dump.
Apr 28 2019, 9:40 AM · Restricted Project, Restricted Project
teemperor added a comment to D61235: Add more information to the log timer dump.

Could you provide a test? There are some existing tests for Timer in lldb/unittests/Utility/TimerTest.cpp which you can extend. You can run/compile these tests via LIT_FILTER="TimerTest" make check-lldb.

Apr 28 2019, 9:40 AM · Restricted Project, Restricted Project
teemperor added a comment to D61219: [WIP] Enable std module import tests on Darwin.

Adding the SDK sysroot there would affect all paths (even user paths that are not in the sysroot) from what I can tell, not just /usr/include. I think the way we implemented this on Linux is via GetSystemIncludeDirectories, see D61240.

Apr 28 2019, 7:23 AM
teemperor created D61240: Implement GetSystemIncludeDirectories for macOS.
Apr 28 2019, 7:21 AM · Restricted Project

Apr 27 2019

teemperor added a comment to D61233: Refactor ObjectFile::GetSDKVersion.

I decided to go for a vector because otherwise the implementation in ObjectFileMachO gets a bit awkward. But I have no problem with doing a VersionTuple instead and adding some manual translation to version tuple in ObjectFileMachO.

Apr 27 2019, 12:58 PM · Restricted Project
teemperor updated the diff for D61233: Refactor ObjectFile::GetSDKVersion.
  • Added documentation on the return value.
Apr 27 2019, 12:56 PM · Restricted Project
teemperor created D61233: Refactor ObjectFile::GetSDKVersion.
Apr 27 2019, 12:56 PM · Restricted Project
teemperor created D61231: Add 'oneOf' utility function for comparing a ConstString against a set of strings.
Apr 27 2019, 11:51 AM · Restricted Project
teemperor added a comment to D57880: Add assert for 'bad' code path in GetUniqueNamespaceDeclaration.

Friendly ping @shafik

Apr 27 2019, 11:14 AM · Restricted Project
teemperor committed rGe2849a031c02: Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift (authored by teemperor).
Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift
Apr 27 2019, 11:14 AM
teemperor committed rLLDB359387: Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift.
Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift
Apr 27 2019, 11:14 AM
teemperor committed rL359387: Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift.
Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift
Apr 27 2019, 11:13 AM
teemperor closed D60654: Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift.
Apr 27 2019, 11:13 AM · Restricted Project, Restricted Project
teemperor set the repository for D46551: Inject only relevant local variables in the expression evaluation context to rLLDB LLDB.
Apr 27 2019, 6:34 AM · Restricted Project
teemperor updated the summary of D46551: Inject only relevant local variables in the expression evaluation context.
Apr 27 2019, 6:31 AM · Restricted Project
teemperor added a reviewer for D46551: Inject only relevant local variables in the expression evaluation context: shafik.
Apr 27 2019, 6:30 AM · Restricted Project
teemperor updated the diff for D46551: Inject only relevant local variables in the expression evaluation context.
  • Disable the variable filtering when during tab completion for now, as it seems our Clang lookup doesn't pull in external types which breaks the completion tests (and others too). This is only a temporary fix to unblock D59960.
  • Some minor cleanup and documentation.
Apr 27 2019, 6:29 AM · Restricted Project