Page MenuHomePhabricator

teemperor (Raphael Isemann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 23 2016, 8:38 AM (326 w, 4 d)

Recent Activity

Mon, Jun 13

teemperor added a comment to D126668: LLDB: Fix resolving nested template parameters.

I don't really have the full context here, but I am wondering if we shouldn't somehow take the DW_AT_declaration attribute into account here. It seems like that should give a more definitive answer as to whether we can expect to see a full set of template parameters or not.

Mon, Jun 13, 12:08 AM · Restricted Project, Restricted Project

May 20 2022

teemperor added a comment to D126057: [lldb] Fix that empty target.run-args are not actually used when launching process.

Don't have access to a macOS machine that can run the tests, so maybe someone should give this a spin before landing :)

May 20 2022, 3:06 AM · Restricted Project, Restricted Project
teemperor requested review of D126057: [lldb] Fix that empty target.run-args are not actually used when launching process.
May 20 2022, 3:04 AM · Restricted Project, Restricted Project

Apr 7 2022

teemperor accepted D91835: [lldb] Add Python bindings to print stack traces on crashes..

This is beautiful

Apr 7 2022, 11:12 AM · Restricted Project, Restricted Project

Mar 24 2022

teemperor committed rG0c86198b279a: Reland "[ELF] Enable new passmanager plugin support for LTO" (authored by Jakob Koschel <jakobkoschel@gmail.com>).
Reland "[ELF] Enable new passmanager plugin support for LTO"
Mar 24 2022, 8:29 AM · Restricted Project
teemperor added a reverting change for rG32012eb11b23: [ELF] Enable new passmanager plugin support for LTO: rG1104d7926124: Revert "[ELF] Enable new passmanager plugin support for LTO".
Mar 24 2022, 1:57 AM · Restricted Project
teemperor added a reverting change for D120490: [ELF] Enable new passmanager plugin support for LTO: rG1104d7926124: Revert "[ELF] Enable new passmanager plugin support for LTO".
Mar 24 2022, 1:57 AM · Restricted Project, Restricted Project
teemperor added a comment to D120490: [ELF] Enable new passmanager plugin support for LTO.

Thanks, reverting while investigating.

Mar 24 2022, 1:57 AM · Restricted Project, Restricted Project
teemperor committed rG1104d7926124: Revert "[ELF] Enable new passmanager plugin support for LTO" (authored by teemperor).
Revert "[ELF] Enable new passmanager plugin support for LTO"
Mar 24 2022, 1:57 AM · Restricted Project
teemperor committed rG32012eb11b23: [ELF] Enable new passmanager plugin support for LTO (authored by Jakob Koschel <jakobkoschel@gmail.com>).
[ELF] Enable new passmanager plugin support for LTO
Mar 24 2022, 12:10 AM · Restricted Project
teemperor closed D120490: [ELF] Enable new passmanager plugin support for LTO.
Mar 24 2022, 12:09 AM · Restricted Project, Restricted Project

Mar 6 2022

teemperor accepted D121064: [lldb] Add a setting to change the autosuggestion ANSI escape codes.

LGTM, thanks! FWIW, if you have fish installed you might wanna check what they are doing on your terminal for its autosuggestions (and we might wanna steal their default, even though I thought this was 'faint').

Mar 6 2022, 11:18 PM · Restricted Project, Restricted Project

Feb 24 2022

teemperor added a comment to D120490: [ELF] Enable new passmanager plugin support for LTO.

Just some drive-by comments, but in general I think this would be nice to get fixed.

Feb 24 2022, 1:42 PM · Restricted Project, Restricted Project

Jan 19 2022

teemperor added a comment to D116155: [clang][AST][ASTImporter] Set record to complete during import of its members..

I'm really sorry @martong , but I no longer work on LLDB (or the ASTImporter) and I'm not really in the loop regarding LLDB development.

Jan 19 2022, 10:53 AM · Restricted Project

Dec 5 2021

teemperor added a comment to D85719: Initialize static const fields in the AST for expression evaluation.

Btw, that patch that I referenced hasn't landed yet (it just lacks the tests and probably rebasing), but I'm OOO for an unknown duration so feel free to land it yourself.

Dec 5 2021, 5:27 AM · Restricted Project

Nov 24 2021

teemperor accepted D110827: [LLDB] Provide target specific directories to libclang.

LGTM, thanks for fixing this!

Nov 24 2021, 11:17 PM · Restricted Project

Nov 17 2021

teemperor added a comment to D113498: [lldb] Constant-resolve operands to `getelementptr`.

I really like the solution, but I think by fixing the CanInterpret you also made the test case no longer reach the actual changed interpreting logic?

So, CanInterpret says "we can't interpret this" (which is correct), but then the interpreter won't run it and your change to ResolveConstantValue isn't actually tested. There is no other test that touches that logic from what I can see. You could try throwing in some other expression at this that tests that new code? Maybe some kind of pointer arithmetic on a variable defined in your expression itself (so it can be constant evaluated).

I think you're right, the interpreter now doesn't get to evaluating the operands of GetElementPtr. However, I've failed to construct an expression that would have a constant expression with getelementptr instruction. So far I've only been able to reproduce it with the example from the test case (which is being rejected during CanInterpret). I've tried expressions like const int x = 1; (int*)100 + (long long)(&x) and similar (also with x being a global variable), but they're are being compiled in a way that getelementptr is not a constant expression anymore.

Nov 17 2021, 3:19 AM · Restricted Project

Nov 13 2021

teemperor added a reverting change for rGcef1e07cc6d0: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT: rGc3a3e65ecc08: Revert "[lldb] Fix that the embedded Python REPL crashes if it receives SIGINT".
Nov 13 2021, 9:19 AM
teemperor committed rGc3a3e65ecc08: Revert "[lldb] Fix that the embedded Python REPL crashes if it receives SIGINT" (authored by teemperor).
Revert "[lldb] Fix that the embedded Python REPL crashes if it receives SIGINT"
Nov 13 2021, 9:19 AM
teemperor added a reverting change for D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT: rGc3a3e65ecc08: Revert "[lldb] Fix that the embedded Python REPL crashes if it receives SIGINT".
Nov 13 2021, 9:18 AM · Restricted Project

Nov 12 2021

teemperor updated the diff for D101950: [lldb][WIP] Use forward decls with redeclared definitions instead of minimal import for records.
  • Update from git
Nov 12 2021, 8:41 AM · Restricted Project, Restricted Project
teemperor updated subscribers of D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT.

@labath raised some concerns in IRC about the setup code being run in a potential multithreaded env (which makes sense). Feel free to revert (not sure when/if I'll get around to address the issues)

Nov 12 2021, 6:59 AM · Restricted Project
teemperor committed rGcef1e07cc6d0: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT (authored by teemperor).
[lldb] Fix that the embedded Python REPL crashes if it receives SIGINT
Nov 12 2021, 5:20 AM
teemperor closed D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT.
Nov 12 2021, 5:19 AM · Restricted Project

Nov 11 2021

teemperor accepted D113720: [lldb][NFC] Inclusive language: rename m_master in ASTImporterDelegate.
Nov 11 2021, 2:52 PM · Restricted Project
teemperor accepted D113687: [lldb][NFC] Inclusive language: replace master/slave names for ptys.

LGTM, thanks!

Nov 11 2021, 11:02 AM · Restricted Project
teemperor accepted D113673: [lldb] Unwrap the type when dereferencing the value.

Thanks a lot for fixing this, could you point to D103532 as the cause for the regression in the commit message?

Nov 11 2021, 9:01 AM · Restricted Project
teemperor requested review of D113682: [lldb] Add a setting for changing the type completion mode to use the new redecl method.
Nov 11 2021, 8:51 AM · Restricted Project
teemperor added a reviewer for D113498: [lldb] Constant-resolve operands to `getelementptr`: Restricted Project.

I really like the solution, but I think by fixing the CanInterpret you also made the test case no longer reach the actual changed interpreting logic?

Nov 11 2021, 7:06 AM · Restricted Project
teemperor accepted D113605: [lldb][NFC] Fix documentation for EncodingDataType.

LGTM, thanks!

Nov 11 2021, 6:33 AM · Restricted Project
teemperor added a comment to D113634: [lldb] Add support for DW_TAG_immutable_type.

Are the DWARFASTParserClang changes meant as a step towards making it parse D?

Yes, not only D but any language that currently falls here (https://github.com/llvm/llvm-project/blob/main/lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp#L106-L112). AFAIK, rust have immutable variables too. Since I'm working on a DWARFFASTParser for D this won't affect it in the future, but for languages like Rust that uses the Python API and rely on Clang DWARFParser, this could be beneficial.

Nov 11 2021, 6:32 AM · Restricted Project
teemperor added a comment to D111409: proposed support for Java interface to Scripting Bridge.

Are you asking for dedicated physical resources for running nightly builds?

I don't think any of the current bots have a Java installation so I think it's either that or we get someone with a bot to setup the required Java installation.

I don't have a problem with installing the necessary packages on the bot I manage, but I cannot subscribe to tracking down any failures (or flaky tests!) for this configuration (and, in my experience, any new feature like this is going to have flaky tests). Flaky tests (probably just one) are the reason that lua integration is not enabled on this bot.

Nov 11 2021, 4:23 AM
teemperor committed rGb72727a75a64: [lldb][NFC] Remove commented out code in SymbolFileDWARF (authored by teemperor).
[lldb][NFC] Remove commented out code in SymbolFileDWARF
Nov 11 2021, 3:46 AM
teemperor committed rG2a0e77362e3a: [lldb][NFC] Remove no longer valid comment for TypeSystem::SetSymbolFile (authored by teemperor).
[lldb][NFC] Remove no longer valid comment for TypeSystem::SetSymbolFile
Nov 11 2021, 3:40 AM
teemperor added a comment to D111409: proposed support for Java interface to Scripting Bridge.

Are you asking for dedicated physical resources for running nightly builds?

Nov 11 2021, 2:49 AM
teemperor added a comment to D113634: [lldb] Add support for DW_TAG_immutable_type.

Are the DWARFASTParserClang changes meant as a step towards making it parse D?

Nov 11 2021, 2:24 AM · Restricted Project
teemperor added a comment to D110578: [lldb] Add support for D programming language.

I changed the commit name from "Add support for D programming language" to "[lldb] Add support for demangling D symbols" when landing (which is more accurate).

Nov 11 2021, 2:12 AM · Restricted Project, Restricted Project
teemperor committed rG96a735990839: [lldb] Add support for demangling D symbols (authored by ljmf00).
[lldb] Add support for demangling D symbols
Nov 11 2021, 2:12 AM
teemperor closed D110578: [lldb] Add support for D programming language.
Nov 11 2021, 2:12 AM · Restricted Project, Restricted Project

Nov 10 2021

teemperor added inline comments to D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h.
Nov 10 2021, 3:17 PM · Restricted Project
teemperor accepted D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h.

I guess that's just clang-format ran over the file? If yes, then LGTM

Nov 10 2021, 3:16 PM · Restricted Project
teemperor requested review of D113562: [lldb][NFC] Add an ImporterBackedASTSource that serves as base class for LLDB ExternalASTSources that use the ASTImporter.
Nov 10 2021, 4:32 AM · Restricted Project
teemperor added a comment to D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls".

I actually didn't see that the patch deleted the TestCppReferenceToOuterClass test. Could you just add a @skipIf # Crashes or so above its def test... method? The test itself is still valid user code that we shouldn't crash on.

Nov 10 2021, 4:23 AM · Restricted Project
teemperor updated the diff for D113524: [lldb] Make TypeSystemClang work with redeclarations.
  • Clang-format some last minute renames
Nov 10 2021, 3:25 AM · Restricted Project
teemperor requested changes to D113533: [LLDB] Remove access check of decl in TypeSystemClang.cpp.

I'm pretty sure you're trying to solve the same problem as here: D85993

Nov 10 2021, 1:00 AM · Restricted Project

Nov 9 2021

teemperor added a comment to D113524: [lldb] Make TypeSystemClang work with redeclarations.

Note that the changed Dump method and the dump method that takes an ExecutionContext are not tested as we can't test those things via unit tests. They can only be tested with an updated DWARF parser on a real executable/process.

Nov 9 2021, 3:53 PM · Restricted Project
teemperor requested review of D113524: [lldb] Make TypeSystemClang work with redeclarations.
Nov 9 2021, 3:52 PM · Restricted Project
teemperor added inline comments to D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls".
Nov 9 2021, 2:32 PM · Restricted Project
teemperor accepted D113449: Revert "[lldb] Disable minimal import mode for RecordDecls that back FieldDecls".

LGTM, thanks for this!

Nov 9 2021, 2:30 PM · Restricted Project

Nov 5 2021

teemperor accepted D113299: [NFC] Inclusive Language: change master to main for .chm files.
Nov 5 2021, 10:57 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
teemperor added inline comments to D113277: [lldb] Delete TypeSystemClang::ParseClassTemplateDecl.
Nov 5 2021, 7:25 AM · Restricted Project
teemperor updated the summary of D113277: [lldb] Delete TypeSystemClang::ParseClassTemplateDecl.
Nov 5 2021, 7:10 AM · Restricted Project
teemperor updated the summary of D113277: [lldb] Delete TypeSystemClang::ParseClassTemplateDecl.
Nov 5 2021, 7:02 AM · Restricted Project
teemperor requested review of D113277: [lldb] Delete TypeSystemClang::ParseClassTemplateDecl.
Nov 5 2021, 7:00 AM · Restricted Project
teemperor added a comment to rGf9e6be5cc1a2: [lldb] Update tagged pointer command output and test..

0xffffffff still seems to randomly find __NSCFNumber according to Green Dragon (and the same happens locally with an about 10% chance).

Nov 5 2021, 5:49 AM

Nov 4 2021

teemperor committed rGf6b7bcc64a6a: [lldb][NFC] StringRef-ify name param in CreateClassTemplateDecl (authored by teemperor).
[lldb][NFC] StringRef-ify name param in CreateClassTemplateDecl
Nov 4 2021, 7:28 AM
teemperor committed rG7323d07483f2: [lldb][NFC] Remove a bunch of unnecessary nullptr checks (authored by teemperor).
[lldb][NFC] Remove a bunch of unnecessary nullptr checks
Nov 4 2021, 7:21 AM
teemperor closed D113175: [lldb][NFC] Remove a bunch of unnecessary nullptr checks.
Nov 4 2021, 7:21 AM · Restricted Project
teemperor committed rGb738a69ab8e3: [lldb][NFC] StringRef-ify the name parameter in CreateEnumerationType (authored by teemperor).
[lldb][NFC] StringRef-ify the name parameter in CreateEnumerationType
Nov 4 2021, 6:49 AM
teemperor closed D113176: [lldb][NFC] StringRef-ify the name parameter in CreateEnumerationType.
Nov 4 2021, 6:49 AM · Restricted Project
teemperor requested review of D113176: [lldb][NFC] StringRef-ify the name parameter in CreateEnumerationType.
Nov 4 2021, 3:02 AM · Restricted Project
teemperor requested review of D113175: [lldb][NFC] Remove a bunch of unnecessary nullptr checks.
Nov 4 2021, 3:01 AM · Restricted Project
teemperor accepted D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime..

LGTM, thanks!

Nov 4 2021, 1:32 AM · Restricted Project

Nov 3 2021

teemperor requested review of D113109: [clang] Avoid expensive pulling in of definitions in ObjCInterfaceDecl::isThisDeclarationADefinition.
Nov 3 2021, 8:19 AM · Restricted Project
teemperor requested review of D113102: [clang] Remove that ASTContext::getObjCInterfaceType eagerly pulls in definitions of ObjCInterfaceDecls.
Nov 3 2021, 6:52 AM · Restricted Project, Restricted Project

Nov 2 2021

teemperor added a comment to D112439: normalize file path when searching the source map.

Thanks a lot for your comments, they are very useful and I learned a lot about C++ by talking with you.

I'll address these comments and submit a patch and request your review.

Much appreciated!

Nov 2 2021, 5:53 AM · Restricted Project
teemperor added a comment to D112439: normalize file path when searching the source map.

Fixed in 58dd658583eec9af24ca1262e1bce9f884d65487

Nov 2 2021, 4:58 AM · Restricted Project
teemperor committed rG58dd658583ee: [lldb] Fix a use-after-free in FindFileTest.cpp (authored by teemperor).
[lldb] Fix a use-after-free in FindFileTest.cpp
Nov 2 2021, 4:40 AM
teemperor added a comment to D112439: normalize file path when searching the source map.

Seems that patch can't build by CI because it is based on this patch. In my understanding we need to merge this patch firstly and rebase that NFC patch to let CI work, right?

You can set parent/child revisions in Phabricator that should handle this situation (not sure if the premerge-checks are respecting that, but that's how Phab usually manages unmerged dependencies).

But to be clear, the premerge checks on Phabricator are *not* building or testing LLDB at all. See the CI log:

INFO    projects: {'lldb'}
INFO    all excluded projects(*) {'check-cxxabi', 'flang', 'libunwind', 'compiler-rt', 'cross-project-tests', 'libcxx', 'libcxxabi', 'libc', 'openmp', 'lldb'}
INFO    effective projects list set()

Thanks a lot for the detailed information!

BTW, I see there are some test failure reported by CI, but I can't reproduce them in my local environment (X86_64 Ubuntu and Windows), is there any docker images to simulate the CI environment?

Can you try a Release + Assert build? I'm looking at the failures at the moment too and it seems to only fail in non-Debug builds.

Sure, I'll try the release + assert build. Thanks again!

Nov 2 2021, 4:27 AM · Restricted Project
teemperor added a comment to D112439: normalize file path when searching the source map.

Seems that patch can't build by CI because it is based on this patch. In my understanding we need to merge this patch firstly and rebase that NFC patch to let CI work, right?

You can set parent/child revisions in Phabricator that should handle this situation (not sure if the premerge-checks are respecting that, but that's how Phab usually manages unmerged dependencies).

But to be clear, the premerge checks on Phabricator are *not* building or testing LLDB at all. See the CI log:

INFO    projects: {'lldb'}
INFO    all excluded projects(*) {'check-cxxabi', 'flang', 'libunwind', 'compiler-rt', 'cross-project-tests', 'libcxx', 'libcxxabi', 'libc', 'openmp', 'lldb'}
INFO    effective projects list set()

Thanks a lot for the detailed information!

BTW, I see there are some test failure reported by CI, but I can't reproduce them in my local environment (X86_64 Ubuntu and Windows), is there any docker images to simulate the CI environment?

Nov 2 2021, 4:14 AM · Restricted Project
teemperor added a comment to D112439: normalize file path when searching the source map.

Seems that patch can't build by CI because it is based on this patch. In my understanding we need to merge this patch firstly and rebase that NFC patch to let CI work, right?

Nov 2 2021, 4:05 AM · Restricted Project
teemperor committed rGcd2e66efa65f: [lldb][gmodules] Fix TestDataFormatterGlobals under gmodules (authored by teemperor).
[lldb][gmodules] Fix TestDataFormatterGlobals under gmodules
Nov 2 2021, 2:14 AM
teemperor added a comment to D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types.

I think this was just fixed by 48677f58b06cfb8715902173c5bc3d1764d7c8c6

Nov 2 2021, 2:13 AM · Restricted Project
teemperor updated subscribers of D112165: Cleanup a few more PR36048 skips.

Small note: gmodules test are never run on Linux, so you actually have to run them on macOS (or I think FreeBSD) to know whether the tests work.

Yeah, I'll admit I didn't test this, but seemed consistent with the other changes/cleanup - did this cause any breakage you know of?

Could gmodules be tested on Linux? (I had originally really hoped/tried to encourage gmodules to be implemented in a way that'd be compatible with Split DWARF but it never quite got there, unfortunately... would've made more overlap in functionality/testability/portability, I think)

(I should setup a build environment on my Macbook Pro, but haven't got around to it as yet)

Nov 2 2021, 12:01 AM · Restricted Project

Nov 1 2021

teemperor committed rGac7c8808ba89: [lldb][gmodules] Fix TestDataFormatterCpp with gmodules on macOS (authored by teemperor).
[lldb][gmodules] Fix TestDataFormatterCpp with gmodules on macOS
Nov 1 2021, 10:45 AM
teemperor added a comment to D112165: Cleanup a few more PR36048 skips.

Small note: gmodules test are never run on Linux, so you actually have to run them on macOS (or I think FreeBSD) to know whether the tests work.

Nov 1 2021, 10:14 AM · Restricted Project
teemperor committed rG9e0a39f3787a: [lldb] Add a test for class loading via member typedefs (authored by teemperor).
[lldb] Add a test for class loading via member typedefs
Nov 1 2021, 7:59 AM

Oct 31 2021

teemperor accepted D112856: [lldb] Only specify LLVM_ENABLE_RUNTIMES in the libcxx error message..

LGTM

Oct 31 2021, 11:23 PM · Restricted Project

Oct 30 2021

teemperor committed rG4cf9d1e4492f: [lldb][NFC] Modernize for-loops in ModuleList (authored by teemperor).
[lldb][NFC] Modernize for-loops in ModuleList
Oct 30 2021, 4:41 AM
teemperor closed D112379: [lldb][NFC] Modernize for-loops in ModuleList.
Oct 30 2021, 4:41 AM · Restricted Project
teemperor committed rG85bcc1eb2f56: [lldb] Make SBType::IsTypeComplete more consistent by forcing the loading of… (authored by teemperor).
[lldb] Make SBType::IsTypeComplete more consistent by forcing the loading of…
Oct 30 2021, 4:29 AM
teemperor closed D112615: [lldb] Make SBType::IsTypeComplete more consistent by forcing the loading of definitions.
Oct 30 2021, 4:29 AM · Restricted Project
teemperor committed rGe2ede1715d41: [lldb] Update field offset/sizes when encountering artificial members such as… (authored by teemperor).
[lldb] Update field offset/sizes when encountering artificial members such as…
Oct 30 2021, 4:23 AM
teemperor closed D112697: [lldb] Update field offset/sizes when encountering artificial members such as vtable pointers.
Oct 30 2021, 4:22 AM · Restricted Project
teemperor committed rG01b3bd3992b4: [ASTImporter] Remove ASTNodeImporter::IsStructuralMatch overload for… (authored by teemperor).
[ASTImporter] Remove ASTNodeImporter::IsStructuralMatch overload for…
Oct 30 2021, 4:12 AM
teemperor closed D112804: [ASTImporter] Remove ASTNodeImporter::IsStructuralMatch overload for EnumConstantDecl.
Oct 30 2021, 4:12 AM · Restricted Project

Oct 29 2021

teemperor added inline comments to D112804: [ASTImporter] Remove ASTNodeImporter::IsStructuralMatch overload for EnumConstantDecl.
Oct 29 2021, 4:57 AM · Restricted Project
teemperor requested review of D112804: [ASTImporter] Remove ASTNodeImporter::IsStructuralMatch overload for EnumConstantDecl.
Oct 29 2021, 4:51 AM · Restricted Project
teemperor accepted D112802: [lldb/test] Replace shlex.join with shlex.quote.

Thanks!

Oct 29 2021, 4:40 AM · Restricted Project
teemperor committed rG96808c69a13c: [ASTImporter] Remove redundant IsStructuralMatch overloads (authored by teemperor).
[ASTImporter] Remove redundant IsStructuralMatch overloads
Oct 29 2021, 3:24 AM
teemperor closed D112796: [ASTImporter] Remove redundant IsStructuralMatch overloads.
Oct 29 2021, 3:23 AM · Restricted Project
teemperor added a comment to D112796: [ASTImporter] Remove redundant IsStructuralMatch overloads.

Makes sense! Thanks!

Oct 29 2021, 3:16 AM · Restricted Project
teemperor added inline comments to D112796: [ASTImporter] Remove redundant IsStructuralMatch overloads.
Oct 29 2021, 2:54 AM · Restricted Project
teemperor requested review of D112796: [ASTImporter] Remove redundant IsStructuralMatch overloads.
Oct 29 2021, 2:52 AM · Restricted Project
teemperor committed rGac73f567cffb: [lldb] Remove forgotten FIXME on CPlusPlus formatters (authored by ljmf00).
[lldb] Remove forgotten FIXME on CPlusPlus formatters
Oct 29 2021, 2:33 AM
teemperor closed D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters.
Oct 29 2021, 2:33 AM · Restricted Project

Oct 28 2021

teemperor added a comment to D112586: [lldb] Remove forgotten FIXME on CPlusPlus formatters.

LGTM, thanks.

Note: I can't land it

Oct 28 2021, 12:53 PM · Restricted Project
teemperor requested changes to D110827: [LLDB] Provide target specific directories to libclang.

Apologies for the delay, this slipped out of my review queue by accident.

Oct 28 2021, 8:20 AM · Restricted Project
teemperor committed rGf5c65be51043: [lldb][NFC] Improve CppModuleConfiguration documentation a bit (authored by teemperor).
[lldb][NFC] Improve CppModuleConfiguration documentation a bit
Oct 28 2021, 7:39 AM
teemperor accepted D112708: [lldb] Make TypeSystemClang::GetFullyUnqualifiedType work for constant arrays.

LGTM, could you also extend a non-unit test to test the change within the whole FormatManager/etc. setup? I think TestDataFormatterAdv.py already has a very similar section about ignoring cv on types.

I've added a simple check to that test. I didn't want to go overboard, as I already have an made an exhaustive test in the follow-up patch.

Oct 28 2021, 7:05 AM · Restricted Project