Page MenuHomePhabricator

teemperor (Raphael Isemann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 23 2016, 8:38 AM (186 w, 4 d)

Recent Activity

Fri, Oct 18

teemperor added a comment to D68130: [lldb] Don't emit artificial constructor declarations as global functions.

Well, I'm fine with x-failing it on Linux, even though I guess at some point someone (i.e., probably me) has to figure out why this stuff is broken in the expression parser.

Fri, Oct 18, 5:47 PM · Restricted Project
teemperor added a comment to D69209: [lldb] Add test for running static initializers in expressions..

Just dumping this here because I don't want to anger the build bots before going into the weekend.

Fri, Oct 18, 5:38 PM · Restricted Project
teemperor created D69209: [lldb] Add test for running static initializers in expressions..
Fri, Oct 18, 5:38 PM · Restricted Project
teemperor added a comment to D68130: [lldb] Don't emit artificial constructor declarations as global functions.

Sorry, seems like I forgot to delete these tests when I extracted them into their own test function.

Fri, Oct 18, 12:30 PM · Restricted Project
teemperor committed rG5c28d49314c7: [lldb][NFC] Remove wrong tests in TestCallOverriddenMethod (authored by teemperor).
[lldb][NFC] Remove wrong tests in TestCallOverriddenMethod
Fri, Oct 18, 12:21 PM
teemperor committed rL375271: [lldb][NFC] Remove wrong tests in TestCallOverriddenMethod.
[lldb][NFC] Remove wrong tests in TestCallOverriddenMethod
Fri, Oct 18, 12:21 PM

Thu, Oct 17

teemperor committed rGb31c6241566e: [lldb][NFC] Fix typo in DWARFASTParserClang.cpp (authored by teemperor).
[lldb][NFC] Fix typo in DWARFASTParserClang.cpp
Thu, Oct 17, 4:12 PM
teemperor committed rL375187: [lldb][NFC] Fix typo in DWARFASTParserClang.cpp.
[lldb][NFC] Fix typo in DWARFASTParserClang.cpp
Thu, Oct 17, 4:12 PM
teemperor committed rG69b3363a5340: [lldb] X-fail tests that use constructors in expressions on Windows (authored by teemperor).
[lldb] X-fail tests that use constructors in expressions on Windows
Thu, Oct 17, 2:28 PM
teemperor committed rL375173: [lldb] X-fail tests that use constructors in expressions on Windows.
[lldb] X-fail tests that use constructors in expressions on Windows
Thu, Oct 17, 2:28 PM
teemperor added a comment to D68130: [lldb] Don't emit artificial constructor declarations as global functions.

Yeah, seems like constructing objects in expressions isn't implemented on Windows. I'm not sure if there is a reliable way to test that constructors aren't shadowed by these global functions if constructors themselves don't work on Windows, but I filed llvm.org/pr43707 for the underlying bug and x-failed the tests. Will push in a few minutes.

Thu, Oct 17, 2:09 PM · Restricted Project
teemperor accepted D69058: [test] Add a .clang-format file for the shell test. .

LGTM, thanks!

Thu, Oct 17, 1:13 PM · Restricted Project
teemperor committed rG6237c9fe6ce9: [lldb] Don't emit artificial constructor declarations as global functions (authored by teemperor).
[lldb] Don't emit artificial constructor declarations as global functions
Thu, Oct 17, 11:21 AM
teemperor closed D68130: [lldb] Don't emit artificial constructor declarations as global functions.
Thu, Oct 17, 11:21 AM · Restricted Project
teemperor committed rL375151: [lldb] Don't emit artificial constructor declarations as global functions.
[lldb] Don't emit artificial constructor declarations as global functions
Thu, Oct 17, 11:21 AM
teemperor added a comment to D69119: Modernize the rest of the Find.* API (NFC).

+1

Thu, Oct 17, 10:42 AM · Restricted Project
teemperor accepted D69114: Disable TestProcessList on windows.
Thu, Oct 17, 10:14 AM · Restricted Project
teemperor added a comment to D69114: Disable TestProcessList on windows.

I filed a bug for you, please reference it and submit: https://bugs.llvm.org/show_bug.cgi?id=43702 (we can update the bug description later).

Thu, Oct 17, 10:14 AM · Restricted Project

Wed, Oct 16

teemperor committed rG755420c08538: Revert "make ConstString allocate memory in non-tiny chunks" (authored by teemperor).
Revert "make ConstString allocate memory in non-tiny chunks"
Wed, Oct 16, 5:02 PM
teemperor committed rL375062: Revert "make ConstString allocate memory in non-tiny chunks".
Revert "make ConstString allocate memory in non-tiny chunks"
Wed, Oct 16, 5:01 PM
teemperor added a comment to D68549: make ConstString allocate memory in non-tiny chunks.

(Seems like my previous comment was cut off in the middle for some reason?)

Wed, Oct 16, 7:11 AM · Restricted Project

Tue, Oct 15

teemperor added a comment to D68549: make ConstString allocate memory in non-tiny chunks.

Oh, I wasn't aware we already had that in the allocator. I looked at the source and it seems that we need to first create about 1024 slabs before we reach the 1MiB limit, which means we need 256 * 1024 = 262144 slabs in LLDB due to the 256 different string pools.

Tue, Oct 15, 5:44 PM · Restricted Project
teemperor updated subscribers of D68549: make ConstString allocate memory in non-tiny chunks.

This patch actually made the RSS memory in our benchmarks go up by quite a bit (see lldb-bench ). The reason is that while we only create 1MiB chunks in the new allocator, we do have 256 different string pools we use as the backend for ConstString. So this means that we actually do allocation steps of 1MiB * 256 = 256MiB which is quite a lot. On a side note, we do use ConstString in the lldb-debugserver, and allocating additional 256MiB on some device running lldb-debugserver could end up being a serious problem if my understanding is correct? (+Alex because IIRC he cares about the debug server memory footprint).

Tue, Oct 15, 4:50 PM · Restricted Project

Mon, Oct 14

teemperor added a comment to D68130: [lldb] Don't emit artificial constructor declarations as global functions.

So, are there any concerns about this (beside the typo which I'll fix pre-commit) and Shafik's request for documentation (which will be another NFC commit)?

Mon, Oct 14, 8:15 AM · Restricted Project
teemperor added a reviewer for D68868: Fix build under musl: JDevlieghere.

(Adding Jonas because reproducers)

Mon, Oct 14, 7:38 AM · Restricted Project

Fri, Oct 11

teemperor committed rG766a0cb1e082: [lldb] Mark import-std-module/empty-module as libc++ test (authored by teemperor).
[lldb] Mark import-std-module/empty-module as libc++ test
Fri, Oct 11, 10:33 AM
teemperor committed rL374574: [lldb] Mark import-std-module/empty-module as libc++ test.
[lldb] Mark import-std-module/empty-module as libc++ test
Fri, Oct 11, 10:33 AM
teemperor committed rG81018c85b9c8: [lldb] Add import-std-module/sysroot to the libc++ test category. (authored by teemperor).
[lldb] Add import-std-module/sysroot to the libc++ test category.
Fri, Oct 11, 10:24 AM
teemperor committed rL374572: [lldb] Add import-std-module/sysroot to the libc++ test category..
[lldb] Add import-std-module/sysroot to the libc++ test category.
Fri, Oct 11, 10:24 AM
teemperor committed rG423c2e98e4e4: [lldb] Fix crash in CxxModuleHandler when std module is empty (authored by teemperor).
[lldb] Fix crash in CxxModuleHandler when std module is empty
Fri, Oct 11, 1:46 AM
teemperor committed rL374525: [lldb] Fix crash in CxxModuleHandler when std module is empty.
[lldb] Fix crash in CxxModuleHandler when std module is empty
Fri, Oct 11, 1:46 AM
teemperor created D68861: [lldb] Add nodebug attribute to import-std-module/sysroot test.
Fri, Oct 11, 1:09 AM · Restricted Project

Thu, Oct 10

teemperor committed rGffe170c6e260: [lldb] Fix minidebuginfo-set-and-hit-breakpoint.test (authored by teemperor).
[lldb] Fix minidebuginfo-set-and-hit-breakpoint.test
Thu, Oct 10, 7:07 AM
teemperor committed rL374352: [lldb] Fix minidebuginfo-set-and-hit-breakpoint.test.
[lldb] Fix minidebuginfo-set-and-hit-breakpoint.test
Thu, Oct 10, 7:06 AM
teemperor committed rGccd54a1349fc: [lldb] Add log output for the support files we pass to the… (authored by teemperor).
[lldb] Add log output for the support files we pass to the…
Thu, Oct 10, 6:48 AM
teemperor committed rL374350: [lldb] Add log output for the support files we pass to the….
[lldb] Add log output for the support files we pass to the…
Thu, Oct 10, 6:47 AM
teemperor committed rGf5b2b76008dc: [lldb] Make sure import-std-module/sysroot actually passes for the right reasons (authored by teemperor).
[lldb] Make sure import-std-module/sysroot actually passes for the right reasons
Thu, Oct 10, 6:00 AM
teemperor committed rL374335: [lldb] Make sure import-std-module/sysroot actually passes for the right reasons.
[lldb] Make sure import-std-module/sysroot actually passes for the right reasons
Thu, Oct 10, 6:00 AM
teemperor committed rG95e264fc8a93: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback (authored by teemperor).
[lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback
Thu, Oct 10, 4:33 AM
teemperor closed D68696: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback.
Thu, Oct 10, 4:33 AM · Restricted Project
teemperor committed rL374313: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback.
[lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback
Thu, Oct 10, 4:25 AM
teemperor committed rG067bb1f546ef: [lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit test that… (authored by teemperor).
[lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit test that…
Thu, Oct 10, 4:15 AM
teemperor closed D68773: [lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit test that function..
Thu, Oct 10, 4:14 AM · Restricted Project
teemperor committed rL374311: [lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit test that….
[lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit test that…
Thu, Oct 10, 4:14 AM
teemperor retitled D68773: [lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit test that function. from [lldb] Fix out of bounds read in DataExtractor::GetCStr and add actually unit test that function. to [lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit test that function..
Thu, Oct 10, 4:14 AM · Restricted Project
teemperor committed rG186f1c58c5ea: [lldb][NFC] Use llvm::all_of instead of std::all_of in CppModuleConfiguration (authored by teemperor).
[lldb][NFC] Use llvm::all_of instead of std::all_of in CppModuleConfiguration
Thu, Oct 10, 3:56 AM
teemperor committed rL374307: [lldb][NFC] Use llvm::all_of instead of std::all_of in CppModuleConfiguration.
[lldb][NFC] Use llvm::all_of instead of std::all_of in CppModuleConfiguration
Thu, Oct 10, 3:55 AM
teemperor added a comment to D68696: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback.

Thanks for the explanation! Doesn't seem like removing this breaks Swift, so I'll land this.

Thu, Oct 10, 3:19 AM · Restricted Project
teemperor created D68773: [lldb] Fix out of bounds read in DataExtractor::GetCStr and add unit test that function..
Thu, Oct 10, 3:10 AM · Restricted Project
teemperor committed rG7c47b4a11304: [lldb][NFC] Use unique_ptr in DiagnosticManager to express ownership (authored by teemperor).
[lldb][NFC] Use unique_ptr in DiagnosticManager to express ownership
Thu, Oct 10, 1:35 AM
teemperor committed rL374289: [lldb][NFC] Use unique_ptr in DiagnosticManager to express ownership.
[lldb][NFC] Use unique_ptr in DiagnosticManager to express ownership
Thu, Oct 10, 1:34 AM
teemperor accepted D68750: Implement serialization and deserialization of scripted points.
Thu, Oct 10, 12:58 AM · Restricted Project
teemperor added a comment to D68750: Implement serialization and deserialization of scripted points.

LGTM, thanks a lot!

Thu, Oct 10, 12:57 AM · Restricted Project
teemperor updated the diff for D68010: [lldb] Fix string summary of an empty NSPathStore2.
  • GetHasSourceSize -> HasSourceSize
  • Moved some code around according to feedback.
Thu, Oct 10, 12:11 AM · Restricted Project

Wed, Oct 9

teemperor added a comment to D68696: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback.

I just realised the same is true for addr (beside that it is consistently named). I'll remove this too after this has landed.

Wed, Oct 9, 5:25 AM · Restricted Project
teemperor created D68696: [lldb][NFC] Remove strange bool parameter from Searcher::SearchCallback.
Wed, Oct 9, 5:22 AM · Restricted Project
teemperor created D68691: [lldb] Add MemorySource abstraction, unit test StringPrinter and document found bugs.
Wed, Oct 9, 4:27 AM · Restricted Project
teemperor added a comment to D68691: [lldb] Add MemorySource abstraction, unit test StringPrinter and document found bugs.

Btw, the current declaration of MemorySource is just what I came up with on the fly. Not sure where the documentation should go or if that class deserves its own header.

Wed, Oct 9, 4:27 AM · Restricted Project
teemperor committed rG4e969da33e11: [lldb] Don't crash when the ASTImporter produces diagnostics but instead log… (authored by teemperor).
[lldb] Don't crash when the ASTImporter produces diagnostics but instead log…
Wed, Oct 9, 1:34 AM
teemperor committed rL374145: [lldb] Don't crash when the ASTImporter produces diagnostics but instead log….
[lldb] Don't crash when the ASTImporter produces diagnostics but instead log…
Wed, Oct 9, 1:34 AM

Tue, Oct 8

teemperor accepted D68638: [lldb] Avoid resource leak.

LGTM. Also, this whole function seems to have no tests. So if you find an easy way to test this, then please add a test to functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py. You can also check this in as-is if the test turns out to be too complicated (I'm not a big fan of the whole "you touched my spaghetti so you also have to come up with a way to test the whole thing".)

Tue, Oct 8, 7:19 AM · Restricted Project

Mon, Oct 7

teemperor added inline comments to D67994: Modify lldb-test to print out ASTs from symbol file.
Mon, Oct 7, 11:30 AM · Restricted Project

Sat, Oct 5

teemperor accepted D68422: [DWARFASTParserClang] Factor out structure-like type parsing, NFC.

Also LGTM! Thanks!

Sat, Oct 5, 12:12 AM · Restricted Project

Fri, Oct 4

teemperor created D68464: [lldb][modern-type-lookup] Ask the ExternalASTMerger to lookup namespaces instead of using the old mechanism.
Fri, Oct 4, 6:50 AM · Restricted Project
teemperor committed rGbaf769d322d9: [lldb] Get the TargetAPI lock in SBProcess::IsInstrumentationRuntimePresent (authored by teemperor).
[lldb] Get the TargetAPI lock in SBProcess::IsInstrumentationRuntimePresent
Fri, Oct 4, 3:01 AM
teemperor committed rL373725: [lldb] Get the TargetAPI lock in SBProcess::IsInstrumentationRuntimePresent.
[lldb] Get the TargetAPI lock in SBProcess::IsInstrumentationRuntimePresent
Fri, Oct 4, 2:53 AM
teemperor closed D67831: [lldb] Get the TargetAPI lock in SBProcess::IsInstrumentationRuntimePresen.
Fri, Oct 4, 2:53 AM · Restricted Project, Restricted Project
teemperor committed rG91ad5398d154: [lldb] Fix that 'ninja clean' breaks the build by deleting debugserver_vers.c (authored by teemperor).
[lldb] Fix that 'ninja clean' breaks the build by deleting debugserver_vers.c
Fri, Oct 4, 2:52 AM
teemperor committed rL373723: [lldb] Fix that 'ninja clean' breaks the build by deleting debugserver_vers.c.
[lldb] Fix that 'ninja clean' breaks the build by deleting debugserver_vers.c
Fri, Oct 4, 2:52 AM
teemperor closed D68376: [lldb] Fix that 'ninja clean' breaks the build by deleting debugserver_vers.c.
Fri, Oct 4, 2:51 AM · Restricted Project, Restricted Project
teemperor committed rG51e0bbb02de3: [lldb][modern-type-lookup] No longer import temporary declarations into the… (authored by teemperor).
[lldb][modern-type-lookup] No longer import temporary declarations into the…
Fri, Oct 4, 1:26 AM
teemperor committed rL373711: [lldb][modern-type-lookup] No longer import temporary declarations into the….
[lldb][modern-type-lookup] No longer import temporary declarations into the…
Fri, Oct 4, 1:25 AM
teemperor closed D68326: [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST.
Fri, Oct 4, 1:25 AM · Restricted Project, Restricted Project

Thu, Oct 3

teemperor updated the diff for D68326: [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST.
  • Addressed feedback (Thanks Gabor, Adrian & Shafik!)
Thu, Oct 3, 6:59 AM · Restricted Project, Restricted Project
teemperor added inline comments to D68326: [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST.
Thu, Oct 3, 6:55 AM · Restricted Project, Restricted Project
teemperor committed rGb941cdd6bc1a: [clang][NFC] Fix misspellings in ExternalASTMerger.h (authored by teemperor).
[clang][NFC] Fix misspellings in ExternalASTMerger.h
Thu, Oct 3, 2:57 AM
teemperor committed rL373577: [clang][NFC] Fix misspellings in ExternalASTMerger.h.
[clang][NFC] Fix misspellings in ExternalASTMerger.h
Thu, Oct 3, 2:57 AM
teemperor created D68376: [lldb] Fix that 'ninja clean' breaks the build by deleting debugserver_vers.c.
Thu, Oct 3, 1:02 AM · Restricted Project, Restricted Project

Wed, Oct 2

teemperor committed rG5c375ed66945: [lldb] Fix evaluation of nested classes with parent from other CU (authored by teemperor).
[lldb] Fix evaluation of nested classes with parent from other CU
Wed, Oct 2, 6:48 AM
teemperor committed rL373470: [lldb] Fix evaluation of nested classes with parent from other CU.
[lldb] Fix evaluation of nested classes with parent from other CU
Wed, Oct 2, 6:44 AM
teemperor closed D68278: Fix evaluation of nested classes with parent from other CU.
Wed, Oct 2, 6:44 AM · Restricted Project, Restricted Project
teemperor committed rGecbfb851a073: [lldb][NFC] Remove ClangASTContext::Clear (authored by teemperor).
[lldb][NFC] Remove ClangASTContext::Clear
Wed, Oct 2, 5:37 AM
teemperor committed rL373460: [lldb][NFC] Remove ClangASTContext::Clear.
[lldb][NFC] Remove ClangASTContext::Clear
Wed, Oct 2, 5:36 AM
teemperor committed rG2eb963abff8e: [lldb][NFC] Create the ASTContext in ClangASTContext exactly once. (authored by teemperor).
[lldb][NFC] Create the ASTContext in ClangASTContext exactly once.
Wed, Oct 2, 5:25 AM
teemperor committed rL373457: [lldb][NFC] Create the ASTContext in ClangASTContext exactly once..
[lldb][NFC] Create the ASTContext in ClangASTContext exactly once.
Wed, Oct 2, 5:24 AM
teemperor added inline comments to D68278: Fix evaluation of nested classes with parent from other CU.
Wed, Oct 2, 5:18 AM · Restricted Project, Restricted Project
teemperor accepted D68278: Fix evaluation of nested classes with parent from other CU.
Wed, Oct 2, 3:06 AM · Restricted Project, Restricted Project
teemperor added a comment to D68278: Fix evaluation of nested classes with parent from other CU.

Just a few nitpicks about some minor typos, otherwise this LGTM. Thanks for the patch! I assume you need someone to commit this for you?

Wed, Oct 2, 3:06 AM · Restricted Project, Restricted Project
teemperor created D68326: [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST.
Wed, Oct 2, 2:38 AM · Restricted Project, Restricted Project

Tue, Oct 1

teemperor requested changes to D68278: Fix evaluation of nested classes with parent from other CU.

A few short comments what the role of the different classes/members play in the test case would be helpful. E.g. "This member/variable/expressions triggers the loading of Decl Foo in that CU". I'll take a closer look tomorrow, but on the first looks this patch LGTM. Thanks!

Tue, Oct 1, 10:29 AM · Restricted Project, Restricted Project
teemperor committed rGb67c3b6cf0f0: [lldb][NFC] Mark ClangASTContext constructor as explicit (authored by teemperor).
[lldb][NFC] Mark ClangASTContext constructor as explicit
Tue, Oct 1, 6:45 AM
teemperor committed rL373339: [lldb][NFC] Mark ClangASTContext constructor as explicit.
[lldb][NFC] Mark ClangASTContext constructor as explicit
Tue, Oct 1, 6:43 AM
teemperor committed rGe4e305e5eea5: [lldb][NFC] Remove unused ClangASTContext::GetHasExternalStorage (authored by teemperor).
[lldb][NFC] Remove unused ClangASTContext::GetHasExternalStorage
Tue, Oct 1, 6:25 AM
teemperor committed rL373337: [lldb][NFC] Remove unused ClangASTContext::GetHasExternalStorage.
[lldb][NFC] Remove unused ClangASTContext::GetHasExternalStorage
Tue, Oct 1, 6:25 AM
teemperor committed rG1ce75045ebf1: [lldb][NFC] Remove unused ClangASTContext functions for checking/removing the… (authored by teemperor).
[lldb][NFC] Remove unused ClangASTContext functions for checking/removing the…
Tue, Oct 1, 6:08 AM
teemperor committed rL373334: [lldb][NFC] Remove unused ClangASTContext functions for checking/removing the….
[lldb][NFC] Remove unused ClangASTContext functions for checking/removing the…
Tue, Oct 1, 6:08 AM
teemperor committed rGc73bfc98f81e: [lldb][NFC] Disallow changing the ASTContext of an ClangASTContext after… (authored by teemperor).
[lldb][NFC] Disallow changing the ASTContext of an ClangASTContext after…
Tue, Oct 1, 5:58 AM
teemperor committed rL373330: [lldb][NFC] Disallow changing the ASTContext of an ClangASTContext after….
[lldb][NFC] Disallow changing the ASTContext of an ClangASTContext after…
Tue, Oct 1, 5:57 AM
teemperor committed rGd01b4a786271: [lldb][NFC] Modernize ClangASTContext constructor (authored by teemperor).
[lldb][NFC] Modernize ClangASTContext constructor
Tue, Oct 1, 5:27 AM
teemperor committed rL373329: [lldb][NFC] Modernize ClangASTContext constructor.
[lldb][NFC] Modernize ClangASTContext constructor
Tue, Oct 1, 5:26 AM