teemperor (Raphael Isemann)
TS@CERN

Projects

User does not belong to any projects.

User Details

User Since
Mar 23 2016, 8:38 AM (100 w, 13 h)

Recent Activity

Sun, Feb 11

teemperor updated the diff for D39714: [modules] Move generation counter from ExternalASTSource to ASTContext.
Sun, Feb 11, 12:27 PM

Wed, Jan 24

teemperor committed rC323310: Refactor RecursiveASTVisitor test for post-order traversal.
Refactor RecursiveASTVisitor test for post-order traversal
Wed, Jan 24, 1:42 AM
teemperor committed rL323310: Refactor RecursiveASTVisitor test for post-order traversal.
Refactor RecursiveASTVisitor test for post-order traversal
Wed, Jan 24, 1:42 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Wed, Jan 24, 1:42 AM
teemperor updated the diff for D37557: Refactor RecursiveASTVisitor test for post-order traversal.
  • Rebased and clang formatted.
Wed, Jan 24, 1:42 AM

Tue, Jan 23

teemperor committed rL323197: Fix memory leaks in GoParser.
Fix memory leaks in GoParser
Tue, Jan 23, 5:52 AM
teemperor closed D42409: Fix memory leaks in GoParser.
Tue, Jan 23, 5:52 AM
teemperor added a reviewer for D37797: Fix crash in Sema when wrongly assuming VarDecl init is not value dependent.: v.g.vassilev.
Tue, Jan 23, 1:18 AM
teemperor committed rL323181: Prevent unaligned memory read in parseMinidumpString.
Prevent unaligned memory read in parseMinidumpString
Tue, Jan 23, 12:07 AM
teemperor closed D42348: Prevent unaligned memory read in parseMinidumpString.
Tue, Jan 23, 12:07 AM
teemperor created D42409: Fix memory leaks in GoParser.
Tue, Jan 23, 12:01 AM

Jan 22 2018

teemperor committed rL323138: Fix memory leak in TestClangASTContext.TestRecordHasFields.
Fix memory leak in TestClangASTContext.TestRecordHasFields
Jan 22 2018, 10:58 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Jan 22 2018, 10:58 AM
teemperor created D42386: Fix memory leak in TestClangASTContext.TestRecordHasFields.
Jan 22 2018, 10:58 AM
teemperor committed rL323122: [modules] Correctly overload getModule in the MultiplexExternalSemaSource.
[modules] Correctly overload getModule in the MultiplexExternalSemaSource
Jan 22 2018, 7:29 AM
teemperor committed rC323122: [modules] Correctly overload getModule in the MultiplexExternalSemaSource.
[modules] Correctly overload getModule in the MultiplexExternalSemaSource
Jan 22 2018, 7:29 AM
teemperor closed D39416: [modules] Correctly overload getModule in the MultiplexExternalSemaSource.
Jan 22 2018, 7:29 AM
teemperor committed rL323119: Fix uninitialized variable in GoParser.
Fix uninitialized variable in GoParser
Jan 22 2018, 6:34 AM
teemperor closed D42339: Fix uninitialized variable in GoParser.
Jan 22 2018, 6:34 AM
teemperor committed rL323085: Fix memory leaks in MinidumpParserTest.
Fix memory leaks in MinidumpParserTest
Jan 22 2018, 1:51 AM
teemperor closed D42347: Fix memory leaks in MinidumpParserTest.
Jan 22 2018, 1:51 AM
teemperor updated the diff for D42347: Fix memory leaks in MinidumpParserTest.
  • Using make_unique now.
Jan 22 2018, 1:48 AM
teemperor committed rL323082: Fix use after free in DiskFilesOrDirectories.
Fix use after free in DiskFilesOrDirectories
Jan 22 2018, 1:19 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Jan 22 2018, 1:19 AM
teemperor added a reviewer for D42348: Prevent unaligned memory read in parseMinidumpString: davide.

Thanks, I think only this and the first GoParser patch ( D42339 ) needs some double checking, the others ( D42346, D42338 ) are trivial and I'll merge in the next few hours as zturner suggested.

Jan 22 2018, 12:16 AM
teemperor added a reviewer for D42339: Fix uninitialized variable in GoParser: davide.
Jan 22 2018, 12:13 AM
teemperor committed rL323081: Fix unrepresentable float value in ScalarTest.
Fix unrepresentable float value in ScalarTest
Jan 22 2018, 12:13 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Jan 22 2018, 12:13 AM

Jan 21 2018

teemperor committed rL323076: Fix memory leaks in TestArm64InstEmulation.
Fix memory leaks in TestArm64InstEmulation
Jan 21 2018, 11:23 PM
teemperor closed D42336: Fix memory leaks in TestArm64InstEmulation.
Jan 21 2018, 11:23 PM
teemperor committed rL323075: Make loop counter unsigned in SymbolFilePDB::GetCompileUnitIndex.
Make loop counter unsigned in SymbolFilePDB::GetCompileUnitIndex
Jan 21 2018, 10:57 PM
teemperor closed D42345: Make loop counter unsigned in SymbolFilePDB::GetCompileUnitIndex.
Jan 21 2018, 10:57 PM
teemperor committed rL323064: [modules] Fix missing includes/typo in LLDB's includes. [NFC].
[modules] Fix missing includes/typo in LLDB's includes. [NFC]
Jan 21 2018, 1:56 AM
teemperor closed D42340: [modules] Fix missing includes/typo in LLDB's includes. [NFC].
Jan 21 2018, 1:56 AM

Jan 20 2018

teemperor created D42348: Prevent unaligned memory read in parseMinidumpString.
Jan 20 2018, 11:47 PM
teemperor created D42347: Fix memory leaks in MinidumpParserTest.
Jan 20 2018, 11:39 PM
teemperor created D42346: Fix use after free in DiskFilesOrDirectories.
Jan 20 2018, 11:35 PM
teemperor created D42345: Make loop counter unsigned in SymbolFilePDB::GetCompileUnitIndex.
Jan 20 2018, 11:28 PM
teemperor updated the diff for D42340: [modules] Fix missing includes/typo in LLDB's includes. [NFC].
  • Ditched the commented includes.
Jan 20 2018, 3:06 PM
teemperor updated the summary of D42340: [modules] Fix missing includes/typo in LLDB's includes. [NFC].
Jan 20 2018, 3:06 PM
teemperor created D42340: [modules] Fix missing includes/typo in LLDB's includes. [NFC].
Jan 20 2018, 2:25 PM
teemperor created D42339: Fix uninitialized variable in GoParser.
Jan 20 2018, 1:52 PM
teemperor updated the summary of D42339: Fix uninitialized variable in GoParser.
Jan 20 2018, 1:52 PM
teemperor created D42338: Fix unrepresentable float value in ScalarTest.
Jan 20 2018, 1:42 PM
teemperor created D42336: Fix memory leaks in TestArm64InstEmulation.
Jan 20 2018, 1:19 PM

Nov 27 2017

teemperor added a comment to D39716: Explicitly set CMake policy CMP0068 to NEW to avoid warnings.

ping

Nov 27 2017, 12:07 AM

Nov 8 2017

teemperor committed rL317675: Fixed link to bugzilla in the sidebar.
Fixed link to bugzilla in the sidebar
Nov 8 2017, 2:11 AM

Nov 7 2017

teemperor added reviewers for D39716: Explicitly set CMake policy CMP0068 to NEW to avoid warnings: smeenai, beanz.

Adding people that could review.

Nov 7 2017, 2:25 AM

Nov 6 2017

teemperor updated the summary of D39714: [modules] Move generation counter from ExternalASTSource to ASTContext.
Nov 6 2017, 11:19 PM
teemperor created D39714: [modules] Move generation counter from ExternalASTSource to ASTContext.
Nov 6 2017, 11:18 PM
teemperor committed rL317467: Fixed dead links in WritingAnLLVMPass.rst.
Fixed dead links in WritingAnLLVMPass.rst
Nov 6 2017, 1:52 AM

Oct 30 2017

teemperor updated the diff for D39416: [modules] Correctly overload getModule in the MultiplexExternalSemaSource.
  • Removed virtual keyword when we already have override.
Oct 30 2017, 5:48 AM
teemperor created D39416: [modules] Correctly overload getModule in the MultiplexExternalSemaSource.
Oct 30 2017, 5:47 AM

Sep 13 2017

teemperor created D37797: Fix crash in Sema when wrongly assuming VarDecl init is not value dependent..
Sep 13 2017, 3:03 AM

Sep 12 2017

teemperor committed rL313049: Use the VFS from the CompilerInvocation by default.
Use the VFS from the CompilerInvocation by default
Sep 12 2017, 9:56 AM
teemperor closed D37416: Use the VFS from the CompilerInvocation by default by committing rL313049: Use the VFS from the CompilerInvocation by default.
Sep 12 2017, 9:56 AM
teemperor updated the diff for D37416: Use the VFS from the CompilerInvocation by default.
  • Rebased with the correct diff...
Sep 12 2017, 6:42 AM
teemperor updated the diff for D37416: Use the VFS from the CompilerInvocation by default.
  • Rebased diff before merging.
Sep 12 2017, 3:05 AM
teemperor updated the summary of D37416: Use the VFS from the CompilerInvocation by default.
Sep 12 2017, 2:52 AM

Sep 10 2017

teemperor updated the diff for D37416: Use the VFS from the CompilerInvocation by default.
  • Moved code from FrontendAction.cpp into createFileManager()
Sep 10 2017, 6:59 AM
teemperor updated the diff for D37416: Use the VFS from the CompilerInvocation by default.
  • Added test case.
Sep 10 2017, 2:02 AM

Sep 7 2017

teemperor created D37557: Refactor RecursiveASTVisitor test for post-order traversal.
Sep 7 2017, 2:34 AM

Sep 6 2017

teemperor accepted D37383: [AST] Add TableGen for StmtDataCollectors.

@johannes The blocking reviewer is because it touches clone detection code :) Fine with me, I have some comments on things but nothing that affects this review. LGTM!

Sep 6 2017, 6:09 AM

Sep 5 2017

teemperor updated subscribers of D37475: Make MultiplexASTDeserializationListener part of the API [NFC].
Sep 5 2017, 6:58 AM
teemperor created D37475: Make MultiplexASTDeserializationListener part of the API [NFC].
Sep 5 2017, 6:57 AM
teemperor committed rL312533: [Bash-autocomplete] Fix crash when invoking --autocomplete without value..
[Bash-autocomplete] Fix crash when invoking --autocomplete without value.
Sep 5 2017, 5:42 AM
teemperor closed D37465: [Bash-autocomplete] Fix crash when invoking --autocomplete without value. by committing rL312533: [Bash-autocomplete] Fix crash when invoking --autocomplete without value..
Sep 5 2017, 5:42 AM
teemperor created D37465: [Bash-autocomplete] Fix crash when invoking --autocomplete without value..
Sep 5 2017, 3:58 AM

Sep 3 2017

teemperor committed rL312468: [analyzer] Increase minimum complexity filter of the CloneChecker..
[analyzer] Increase minimum complexity filter of the CloneChecker.
Sep 3 2017, 10:58 PM
teemperor closed D34178: [analyzer] Increase minimum complexity filter of the CloneChecker. by committing rL312468: [analyzer] Increase minimum complexity filter of the CloneChecker..
Sep 3 2017, 10:57 PM
teemperor updated the diff for D34178: [analyzer] Increase minimum complexity filter of the CloneChecker..
  • Rebased and updated patch before merging.
Sep 3 2017, 10:57 PM
teemperor committed rL312440: [analyzer] MinComplexityConstraint now early exits and only does one macro….
[analyzer] MinComplexityConstraint now early exits and only does one macro…
Sep 3 2017, 6:49 AM
teemperor closed D34361: [analyzer] MinComplexityConstraint now early exits and only does one macro stack lookup by committing rL312440: [analyzer] MinComplexityConstraint now early exits and only does one macro….
Sep 3 2017, 6:49 AM
teemperor updated the diff for D34361: [analyzer] MinComplexityConstraint now early exits and only does one macro stack lookup.
  • Rebased and fixed merge conflicts before merging.
Sep 3 2017, 6:44 AM
teemperor updated subscribers of D37416: Use the VFS from the CompilerInvocation by default.
Sep 3 2017, 6:14 AM

Sep 2 2017

teemperor created D37416: Use the VFS from the CompilerInvocation by default.
Sep 2 2017, 5:59 PM

Sep 1 2017

teemperor added a comment to D37383: [AST] Add TableGen for StmtDataCollectors.

@arphaman I suggested tablegen in D36664 because I remembered we had some CMake sanity check about not having an *.inc in our include dir: https://github.com/llvm-mirror/clang/blob/master/CMakeLists.txt#L266 Not sure if it actually fires for our case, but it looks like it does.

Sep 1 2017, 10:32 AM

Aug 31 2017

teemperor committed rL312222: [analyzer] Performance optimizations for the CloneChecker.
[analyzer] Performance optimizations for the CloneChecker
Aug 31 2017, 12:12 AM
teemperor closed D34182: [analyzer] Performance optimizations for the CloneChecker by committing rL312222: [analyzer] Performance optimizations for the CloneChecker.
Aug 31 2017, 12:11 AM

Aug 29 2017

teemperor accepted D37249: [Bash-autocomplete] Refactor autocomplete code into own function.

LGTM!

Aug 29 2017, 7:11 AM
teemperor committed rL311991: [modules] Add test for using declaration in classes..
[modules] Add test for using declaration in classes.
Aug 29 2017, 2:29 AM
teemperor closed D37180: [modules] Add test for using declaration in classes. by committing rL311991: [modules] Add test for using declaration in classes..
Aug 29 2017, 2:28 AM

Aug 28 2017

teemperor added inline comments to D37249: [Bash-autocomplete] Refactor autocomplete code into own function.
Aug 28 2017, 10:59 PM
teemperor updated the summary of D37180: [modules] Add test for using declaration in classes..
Aug 28 2017, 7:40 AM

Aug 27 2017

teemperor updated the summary of D37180: [modules] Add test for using declaration in classes..
Aug 27 2017, 6:13 AM

Aug 26 2017

teemperor created D37180: [modules] Add test for using declaration in classes..
Aug 26 2017, 6:31 AM

Aug 23 2017

teemperor accepted rL311569: [analyzer] Make StmtDataCollector customizable.
Aug 23 2017, 10:19 AM
teemperor accepted rL311544: Fix typos, remove unused private members of CommonOptionsParser, NFC.
Aug 23 2017, 3:55 AM
teemperor accepted D36664: [analyzer] Make StmtDataCollector customizable.

Sorry for the delay, was on vacation.

Aug 23 2017, 2:02 AM

Aug 22 2017

teemperor accepted rL311474: Test commit access..
Aug 22 2017, 10:43 AM
teemperor accepted D36782: [Bash-autocompletion] Add support for static analyzer flags.

Found one more minor comment typo. And could you do your changes to OptParserEmitter.cpp all in this patch? Because Rui/Me pointed out those things on this review, so this patch should also fix them IMHO :)

Aug 22 2017, 7:25 AM

Aug 17 2017

teemperor added a dependent revision for D36782: [Bash-autocompletion] Add support for static analyzer flags: D36820: [Bash-autocompletion] Add support for -std=.
Aug 17 2017, 12:01 AM
teemperor added a dependency for D36820: [Bash-autocompletion] Add support for -std=: D36782: [Bash-autocompletion] Add support for static analyzer flags.
Aug 17 2017, 12:01 AM

Aug 16 2017

teemperor added inline comments to D36782: [Bash-autocompletion] Add support for static analyzer flags.
Aug 16 2017, 2:48 AM
teemperor added a comment to D36782: [Bash-autocompletion] Add support for static analyzer flags.

That's a really nice approach to this problem, good job Yuka! See my inline comments for some minor remarks.

Aug 16 2017, 12:24 AM

Aug 15 2017

teemperor added a comment to D36664: [analyzer] Make StmtDataCollector customizable.

Very well done, I really like this patch! I added a few remarks mostly about the comments that need some small adjusting.

Aug 15 2017, 2:03 AM

Aug 10 2017

teemperor accepted D36567: [Bash-autocompletion] Add --autocomplete flag to 5.0 release notes.

LGTM, more publicity means that more shells will make use of it.

Aug 10 2017, 12:54 PM

Aug 3 2017

teemperor abandoned D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs..

I see, thanks for the information! If we don't need to support this in the shell-completion and we shouldn't report invalid arguments, then it seems this review is stuck here. I'll abandon as I don't see any other use case for this code.

Aug 3 2017, 2:07 PM

Aug 1 2017

teemperor accepted D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix.

E.g. If you add a flag that lands in between the results it breaks. Add -Wmajor-new-feature and the test goes red. Same with the flag results or changing the help test for -std=.

Aug 1 2017, 11:30 PM

Jul 31 2017

teemperor added a comment to D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs..

I like the directions of this patch.
In general, I am in favor of explicitly registering the options from user defined checkers.
But changing a config option will now break the command line compatibility, so I wonder how do we want to handle this:

  • Have a list of no-op configs that we accept but warn that it has been replaced/removed?
  • Just do not care and break compatibility?
  • Something else?
Jul 31 2017, 11:48 PM