- User Since
- Mar 23 2016, 8:38 AM (169 w, 1 h)
Fri, May 31
+1. I'm (obviously) in favor of this.
Tue, May 21
May 13 2019
May 10 2019
May 9 2019
If it's just about adding some commonly used GDB flags I'm fine with adding them to the normal LLDB flags. If the plan is to implement most/all of the flags GDB supports, then I would prefer having something like --gdb or lldb-gdb (which seems anyway necessary to resolve the conflicts with the current LLDB flags like -x, -b, -l, etc.).
Not sure if I like this change. We don't have single dash flags with multiple characters in LLDB, so this flag looks a bit out of place. And there is the bigger question if we really want to be compatible with the GDB flags (which are already incompatible with the flags LLDB is currently offering). If we really go this way then I would suggest we also add more commonly used GDB flags like --args.
May 6 2019
May 5 2019
May 3 2019
LGTM, seems consistent with the row above
Looks good now, thanks!
May 2 2019
You don't have to use arc, you can also just update the code via the "Update diff" button and upload a patch file. So it doesn't really matter how you organize your local git branch as long as you can produce a patch file from the changes. Phabricator takes care of making diffs between the patches you upload, so there is always a change history here.
Not sure how you invoke git clang-format, but I assume you specified the wrong commit range...
FYI, I still think there are some style issues there (e.g. the AppleObjCRuntimeV2.cpp change makes it longer than 80 chars) but I can just clang-format this before committing.
I think the best way to handle these errors in LLDB is to just log and then return some default value. That should make the current command print an error, which is better than terminating LLDB.
LGTM module some minor code style issues (You removed some virtuals but didn't fix the indentation of the parameters on the next line, see the inline comments for examples).
This has been landed as rC359338 but somehow Phabricator didn't close this. Closing this manually.
This has been merged as rLLDB359699 but somehow Phabriactor hasn't figured out yet that this needs to be closed. Closing this manually.
- Added documentation.
- Fixed more references to 'minion' pointed out in the review.
May 1 2019
As we're anyway throwing in reduced test cases, here is another version:
I just realized that you probably don't have commit access yet, so I'll commit this for you. Thanks for the patch!
Apr 30 2019
Apr 29 2019
I'll land this as it seems only the tests are subject to change and I want to also land the dependencies of this patch. Please let me know if you want any other changes changes to the test and thanks for the review!
I looked into this a bit further and I think the best way forward is to enable gmodules on Linux but exclude all tests that rely on system modules (i.e. std or libc) as that really seems to be a messy situation. I'll update the patch accordingly.
- Fixed m_sema documentation.
- Refactored test according to Gábor's feedback.
So a long-term fix for this would require at least reworking ho that debug information is generated.
- Add 'linux' to the list of platforms supporting gmodules.
Apr 28 2019
Yeah, I'm also just like 60% confident that this more readable/expressive.
Could you provide a test? There are some existing tests for Timer in lldb/unittests/Utility/TimerTest.cpp which you can extend. You can run/compile these tests via LIT_FILTER="TimerTest" make check-lldb.
Adding the SDK sysroot there would affect all paths (even user paths that are not in the sysroot) from what I can tell, not just /usr/include. I think the way we implemented this on Linux is via GetSystemIncludeDirectories, see D61240.
Apr 27 2019
I decided to go for a vector because otherwise the implementation in ObjectFileMachO gets a bit awkward. But I have no problem with doing a VersionTuple instead and adding some manual translation to version tuple in ObjectFileMachO.
- Added documentation on the return value.
Friendly ping @shafik
- Disable the variable filtering when during tab completion for now, as it seems our Clang lookup doesn't pull in external types which breaks the completion tests (and others too). This is only a temporary fix to unblock D59960.
- Some minor cleanup and documentation.