teemperor (Raphael Isemann)
TS@CERN

Projects

User does not belong to any projects.

User Details

User Since
Mar 23 2016, 8:38 AM (90 w, 5 h)

Recent Activity

Mon, Nov 27

teemperor added a comment to D39716: Explicitly set CMake policy CMP0068 to NEW to avoid warnings.

ping

Mon, Nov 27, 12:07 AM

Nov 8 2017

teemperor committed rL317675: Fixed link to bugzilla in the sidebar.
Fixed link to bugzilla in the sidebar
Nov 8 2017, 2:11 AM

Nov 7 2017

teemperor added reviewers for D39716: Explicitly set CMake policy CMP0068 to NEW to avoid warnings: smeenai, beanz.

Adding people that could review.

Nov 7 2017, 2:25 AM

Nov 6 2017

teemperor updated the summary of D39714: Move generation counter from External AST source to ASTContext.
Nov 6 2017, 11:19 PM
teemperor created D39714: Move generation counter from External AST source to ASTContext.
Nov 6 2017, 11:18 PM
teemperor committed rL317467: Fixed dead links in WritingAnLLVMPass.rst.
Fixed dead links in WritingAnLLVMPass.rst
Nov 6 2017, 1:52 AM

Oct 30 2017

teemperor updated the diff for D39416: [modules] Correctly overload getModule in the MultiplexExternalSemaSource.
  • Removed virtual keyword when we already have override.
Oct 30 2017, 5:48 AM
teemperor created D39416: [modules] Correctly overload getModule in the MultiplexExternalSemaSource.
Oct 30 2017, 5:47 AM

Sep 13 2017

teemperor created D37797: Fix crash in Sema when wrongly assuming VarDecl init is not value dependent..
Sep 13 2017, 3:03 AM

Sep 12 2017

teemperor committed rL313049: Use the VFS from the CompilerInvocation by default.
Use the VFS from the CompilerInvocation by default
Sep 12 2017, 9:56 AM
teemperor closed D37416: Use the VFS from the CompilerInvocation by default by committing rL313049: Use the VFS from the CompilerInvocation by default.
Sep 12 2017, 9:56 AM
teemperor updated the diff for D37416: Use the VFS from the CompilerInvocation by default.
  • Rebased with the correct diff...
Sep 12 2017, 6:42 AM
teemperor updated the diff for D37416: Use the VFS from the CompilerInvocation by default.
  • Rebased diff before merging.
Sep 12 2017, 3:05 AM
teemperor updated the summary of D37416: Use the VFS from the CompilerInvocation by default.
Sep 12 2017, 2:52 AM

Sep 10 2017

teemperor updated the diff for D37416: Use the VFS from the CompilerInvocation by default.
  • Moved code from FrontendAction.cpp into createFileManager()
Sep 10 2017, 6:59 AM
teemperor updated the diff for D37416: Use the VFS from the CompilerInvocation by default.
  • Added test case.
Sep 10 2017, 2:02 AM

Sep 7 2017

teemperor created D37557: Refactor RecursiveASTVisitor test for post-order traversal.
Sep 7 2017, 2:34 AM

Sep 6 2017

teemperor accepted D37383: [AST] Add TableGen for StmtDataCollectors.

@johannes The blocking reviewer is because it touches clone detection code :) Fine with me, I have some comments on things but nothing that affects this review. LGTM!

Sep 6 2017, 6:09 AM

Sep 5 2017

teemperor updated subscribers of D37475: Make MultiplexASTDeserializationListener part of the API [NFC].
Sep 5 2017, 6:58 AM
teemperor created D37475: Make MultiplexASTDeserializationListener part of the API [NFC].
Sep 5 2017, 6:57 AM
teemperor committed rL312533: [Bash-autocomplete] Fix crash when invoking --autocomplete without value..
[Bash-autocomplete] Fix crash when invoking --autocomplete without value.
Sep 5 2017, 5:42 AM
teemperor closed D37465: [Bash-autocomplete] Fix crash when invoking --autocomplete without value. by committing rL312533: [Bash-autocomplete] Fix crash when invoking --autocomplete without value..
Sep 5 2017, 5:42 AM
teemperor created D37465: [Bash-autocomplete] Fix crash when invoking --autocomplete without value..
Sep 5 2017, 3:58 AM

Sep 3 2017

teemperor committed rL312468: [analyzer] Increase minimum complexity filter of the CloneChecker..
[analyzer] Increase minimum complexity filter of the CloneChecker.
Sep 3 2017, 10:58 PM
teemperor closed D34178: [analyzer] Increase minimum complexity filter of the CloneChecker. by committing rL312468: [analyzer] Increase minimum complexity filter of the CloneChecker..
Sep 3 2017, 10:57 PM
teemperor updated the diff for D34178: [analyzer] Increase minimum complexity filter of the CloneChecker..
  • Rebased and updated patch before merging.
Sep 3 2017, 10:57 PM
teemperor committed rL312440: [analyzer] MinComplexityConstraint now early exits and only does one macro….
[analyzer] MinComplexityConstraint now early exits and only does one macro…
Sep 3 2017, 6:49 AM
teemperor closed D34361: [analyzer] MinComplexityConstraint now early exits and only does one macro stack lookup by committing rL312440: [analyzer] MinComplexityConstraint now early exits and only does one macro….
Sep 3 2017, 6:49 AM
teemperor updated the diff for D34361: [analyzer] MinComplexityConstraint now early exits and only does one macro stack lookup.
  • Rebased and fixed merge conflicts before merging.
Sep 3 2017, 6:44 AM
teemperor updated subscribers of D37416: Use the VFS from the CompilerInvocation by default.
Sep 3 2017, 6:14 AM

Sep 2 2017

teemperor created D37416: Use the VFS from the CompilerInvocation by default.
Sep 2 2017, 5:59 PM

Sep 1 2017

teemperor added a comment to D37383: [AST] Add TableGen for StmtDataCollectors.

@arphaman I suggested tablegen in D36664 because I remembered we had some CMake sanity check about not having an *.inc in our include dir: https://github.com/llvm-mirror/clang/blob/master/CMakeLists.txt#L266 Not sure if it actually fires for our case, but it looks like it does.

Sep 1 2017, 10:32 AM

Aug 31 2017

teemperor committed rL312222: [analyzer] Performance optimizations for the CloneChecker.
[analyzer] Performance optimizations for the CloneChecker
Aug 31 2017, 12:12 AM
teemperor closed D34182: [analyzer] Performance optimizations for the CloneChecker by committing rL312222: [analyzer] Performance optimizations for the CloneChecker.
Aug 31 2017, 12:11 AM

Aug 29 2017

teemperor accepted D37249: [Bash-autocomplete] Refactor autocomplete code into own function.

LGTM!

Aug 29 2017, 7:11 AM
teemperor committed rL311991: [modules] Add test for using declaration in classes..
[modules] Add test for using declaration in classes.
Aug 29 2017, 2:29 AM
teemperor closed D37180: [modules] Add test for using declaration in classes. by committing rL311991: [modules] Add test for using declaration in classes..
Aug 29 2017, 2:28 AM

Aug 28 2017

teemperor added inline comments to D37249: [Bash-autocomplete] Refactor autocomplete code into own function.
Aug 28 2017, 10:59 PM
teemperor updated the summary of D37180: [modules] Add test for using declaration in classes..
Aug 28 2017, 7:40 AM

Aug 27 2017

teemperor updated the summary of D37180: [modules] Add test for using declaration in classes..
Aug 27 2017, 6:13 AM

Aug 26 2017

teemperor created D37180: [modules] Add test for using declaration in classes..
Aug 26 2017, 6:31 AM

Aug 23 2017

teemperor accepted rL311569: [analyzer] Make StmtDataCollector customizable.
Aug 23 2017, 10:19 AM
teemperor accepted rL311544: Fix typos, remove unused private members of CommonOptionsParser, NFC.
Aug 23 2017, 3:55 AM
teemperor accepted D36664: [analyzer] Make StmtDataCollector customizable.

Sorry for the delay, was on vacation.

Aug 23 2017, 2:02 AM

Aug 22 2017

teemperor accepted rL311474: Test commit access..
Aug 22 2017, 10:43 AM
teemperor accepted D36782: [Bash-autocompletion] Add support for static analyzer flags.

Found one more minor comment typo. And could you do your changes to OptParserEmitter.cpp all in this patch? Because Rui/Me pointed out those things on this review, so this patch should also fix them IMHO :)

Aug 22 2017, 7:25 AM

Aug 17 2017

teemperor added a dependent revision for D36782: [Bash-autocompletion] Add support for static analyzer flags: D36820: [Bash-autocompletion] Add support for -std=.
Aug 17 2017, 12:01 AM
teemperor added a dependency for D36820: [Bash-autocompletion] Add support for -std=: D36782: [Bash-autocompletion] Add support for static analyzer flags.
Aug 17 2017, 12:01 AM

Aug 16 2017

teemperor added inline comments to D36782: [Bash-autocompletion] Add support for static analyzer flags.
Aug 16 2017, 2:48 AM
teemperor added a comment to D36782: [Bash-autocompletion] Add support for static analyzer flags.

That's a really nice approach to this problem, good job Yuka! See my inline comments for some minor remarks.

Aug 16 2017, 12:24 AM

Aug 15 2017

teemperor added a comment to D36664: [analyzer] Make StmtDataCollector customizable.

Very well done, I really like this patch! I added a few remarks mostly about the comments that need some small adjusting.

Aug 15 2017, 2:03 AM

Aug 10 2017

teemperor accepted D36567: [Bash-autocompletion] Add --autocomplete flag to 5.0 release notes.

LGTM, more publicity means that more shells will make use of it.

Aug 10 2017, 12:54 PM

Aug 3 2017

teemperor abandoned D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs..

I see, thanks for the information! If we don't need to support this in the shell-completion and we shouldn't report invalid arguments, then it seems this review is stuck here. I'll abandon as I don't see any other use case for this code.

Aug 3 2017, 2:07 PM

Aug 1 2017

teemperor accepted D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix.

E.g. If you add a flag that lands in between the results it breaks. Add -Wmajor-new-feature and the test goes red. Same with the flag results or changing the help test for -std=.

Aug 1 2017, 11:30 PM

Jul 31 2017

teemperor added a comment to D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs..

I like the directions of this patch.
In general, I am in favor of explicitly registering the options from user defined checkers.
But changing a config option will now break the command line compatibility, so I wonder how do we want to handle this:

  • Have a list of no-op configs that we accept but warn that it has been replaced/removed?
  • Just do not care and break compatibility?
  • Something else?
Jul 31 2017, 11:48 PM
teemperor updated subscribers of D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs..
Jul 31 2017, 2:01 AM
teemperor updated the diff for D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs..
  • Remove some unneeded includes
Jul 31 2017, 2:01 AM

Jul 30 2017

teemperor added a comment to D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs..

I'm open to suggestions how we should handle user-provided checkers that maybe come with their own configs. Should we add that if we have a custom checker in the registry, that we disable this check to keep backwards compability? Or do we demand users to register their own configs in the registry?

Jul 30 2017, 1:58 PM
teemperor created D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs..
Jul 30 2017, 1:49 PM
teemperor updated the diff for D34182: [analyzer] Performance optimizations for the CloneChecker.

(Fixed diff)

Jul 30 2017, 12:34 PM
teemperor updated the diff for D34182: [analyzer] Performance optimizations for the CloneChecker.
  • Updated according to Artem's comments.
Jul 30 2017, 12:30 PM

Jul 25 2017

teemperor added a comment to D34260: [StaticAnalyzer] Completely unrolling specific loops with known bound option .

If you can't reproduce, you should try running a debug build through valgrind. It points out this issue:

Jul 25 2017, 11:17 PM

Jul 22 2017

teemperor accepted D35759: [Bash-autocompletion] Show HelpText with possible flags.

LGTM.

Jul 22 2017, 11:50 AM
teemperor accepted D35762: [Bash-autocompletion] Fixed typo and add '-' after -Wno.

Thanks for the quick fix, LGTM!

Jul 22 2017, 5:23 AM

Jul 18 2017

teemperor committed rL308340: Add GCC's noexcept-type alias for c++1z-compat-mangling.
Add GCC's noexcept-type alias for c++1z-compat-mangling
Jul 18 2017, 11:53 AM
teemperor closed D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling.
Jul 18 2017, 11:53 AM
teemperor committed rL308333: Don't set TUScope to null when generating a module in incremental processing….
Don't set TUScope to null when generating a module in incremental processing…
Jul 18 2017, 11:25 AM
teemperor closed D35536: Don't set TUScope to null when generating a module in incremental processing mode..
Jul 18 2017, 11:25 AM
teemperor updated the summary of D35536: Don't set TUScope to null when generating a module in incremental processing mode..
Jul 18 2017, 5:04 AM
teemperor updated the diff for D35536: Don't set TUScope to null when generating a module in incremental processing mode..
Jul 18 2017, 4:55 AM
teemperor created D35536: Don't set TUScope to null when generating a module in incremental processing mode..
Jul 18 2017, 3:05 AM
teemperor added a comment to D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling.

ping. Any objections to adding this GCC alias?

Jul 18 2017, 12:58 AM

Jul 15 2017

teemperor accepted D35447: [Bash-autocompletion] Add support for -W<warning> and -Wno<warning>.

I have a last request in my inline comment regarding the documentation, otherwise this is good to go. Nice work!

Jul 15 2017, 12:13 PM
teemperor added a comment to D35447: [Bash-autocompletion] Add support for -W<warning> and -Wno<warning>.

@yamaguchi yes, the reason why we have to treat the -W... flags specially should be documented (as they're not in the OptTable as you said). E.g. something like // We have to query the -W flags manually as they're not in the OptTable. and then maybe a TODO: Find a good way to add them to OptTable instead and them remove this code..

Jul 15 2017, 2:25 AM
teemperor requested changes to D35447: [Bash-autocompletion] Add support for -W<warning> and -Wno<warning>.

It seems the code doesn't compile in clang because on your platform std::vector is implicitly included by some header, on clang+Arch however it isn`t (see the error at the end of https://teemperor.de/ccir/D35447).

Jul 15 2017, 12:34 AM

Jul 14 2017

teemperor created D35407: Add unreachable when we run out of scopes during lookup.
Jul 14 2017, 3:13 AM

Jul 9 2017

teemperor committed rL307509: [analyzer] Faster hashing of subsequences in CompoundStmts..
[analyzer] Faster hashing of subsequences in CompoundStmts.
Jul 9 2017, 2:15 PM
teemperor closed D34364: [analyzer] Faster hashing of subsequences in CompoundStmts..
Jul 9 2017, 1:41 PM
teemperor added a comment to D34329: [clang-diff] Initial implementation..

@johannes D34880 has landed, so feel free to propose patches to the StmtDataCollector API that would help you (e.g. to support identifiers). You can see examples how to use it in the CloneDetection.cpp (once for storing data in a FoldingetSetNodeID and once for directly hashing the data with MD5).

Jul 9 2017, 9:21 AM
teemperor committed rL307501: [analyzer] Make StmtDataCollector part of the CloneDetection API.
[analyzer] Make StmtDataCollector part of the CloneDetection API
Jul 9 2017, 8:57 AM
teemperor closed D34880: [analyzer] Make StmtDataCollector part of the CloneDetection API.
Jul 9 2017, 8:56 AM

Jul 2 2017

teemperor added a comment to D34880: [analyzer] Make StmtDataCollector part of the CloneDetection API.

Yeah, we should move it, but it should land somewhere in a header in /AST/ so that for example the StmtProfiler could make use of this. I'm open for suggestions here :)

Jul 2 2017, 4:55 AM

Jul 1 2017

teemperor accepted D34930: [Bash-autocompletion] Show flags which has HelpText or GroupID.

For the record, one can get a (maybe incomplete) list of options that are without completion via: curl "https://teemperor.de/pub/clang_flags.txt" | grep -v HelpText | grep -v Group.
The only options I can see that I would miss if they would disappear are the ones who are clearly meant to be public but just lack the HelpText (like our beloved sysroot, which is a public GCC flag). So I think this patch can go forward and someone will have to add a HelpText for those flags in the future.

Jul 1 2017, 11:40 PM
teemperor accepted D34924: [Bash-autocompletion] Add support for older bash version..

LGTM, everything still works in the latest bash on Linux.

Jul 1 2017, 10:16 AM
teemperor added a comment to D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified.

I'm not sure what you refer to by I just saw we actually have the completion code in the Driver. We are already auto completing both cc1 options and driver options, right?

Jul 1 2017, 12:39 AM
teemperor accepted D34595: Changed Opts.EABIVersion type string to llvm::EABI enum class .

LGTM.

Jul 1 2017, 12:27 AM

Jun 30 2017

teemperor updated subscribers of D34361: [analyzer] MinComplexityConstraint now early exits and only does one macro stack lookup.
Jun 30 2017, 8:21 AM
teemperor updated subscribers of D34364: [analyzer] Faster hashing of subsequences in CompoundStmts..
Jun 30 2017, 8:21 AM
teemperor updated subscribers of D34880: [analyzer] Make StmtDataCollector part of the CloneDetection API.
Jun 30 2017, 8:20 AM
teemperor added a comment to D34329: [clang-diff] Initial implementation..

Yes, it does indeed skip identifiers and literals for this reason :). It was planned to make this template more configurable for use cases like yours, so I'm totally fine with adding configuration parameters. I just opened D34880 where I make this template public as a first step.

Jun 30 2017, 7:01 AM
teemperor created D34880: [analyzer] Make StmtDataCollector part of the CloneDetection API.
Jun 30 2017, 7:00 AM
teemperor accepted rL306555: [Bash-autocompletion] Check clang version in Bash.
Jun 30 2017, 4:59 AM
teemperor added a comment to D34329: [clang-diff] Initial implementation..

I didn't have time to have a close look at this patch, but it seems you're interested in the specific TU-independent data of a Stmt to compare them. So if you are interested in such data and don't want to write your own function to collect it for each Stmt subclass, there is the StmtDataCollector in the CloneDetection.cpp here and a example how to use it is here.

Jun 30 2017, 4:33 AM

Jun 29 2017

teemperor added a comment to D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified.

Two thought from me on this:

Jun 29 2017, 6:48 AM

Jun 25 2017

teemperor accepted D34607: [Bash-autocompletion] Check clang version in Bash.

Works as intended, good job!

Jun 25 2017, 10:50 PM

Jun 24 2017

teemperor accepted D34594: [GSoC] Delete space after flags which has '=' prefix.
Jun 24 2017, 9:17 AM

Jun 22 2017

teemperor removed 1 auditor(s) for rL306016: Updating branches/google/stable to r305862: teemperor.
Jun 22 2017, 10:20 AM
teemperor removed 1 auditor(s) for rL306015: Creating tags/google/stable/2017-06-22 from r305862: teemperor.
Jun 22 2017, 10:19 AM

Jun 21 2017

teemperor added a comment to D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling.

@ahatanak I think we can leave the more expressive clang name for this warning and just add the bit cryptic GCC name for compability. But I don't have a strong opinion on this.

Jun 21 2017, 10:56 AM
teemperor created D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling.
Jun 21 2017, 3:31 AM