Page MenuHomePhabricator

teemperor (Raphael Isemann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 23 2016, 8:38 AM (160 w, 6 d)

Recent Activity

Tue, Apr 16

teemperor updated the summary of D60655: Fix typo in ArmUnwindInfo::GetUnwindPlan.
Tue, Apr 16, 1:09 AM · Restricted Project, Restricted Project
teemperor committed rGbef588ce11ef: Fix typo in ArmUnwindInfo::GetUnwindPlan (authored by teemperor).
Fix typo in ArmUnwindInfo::GetUnwindPlan
Tue, Apr 16, 1:08 AM
teemperor committed rLLDB358479: Fix typo in ArmUnwindInfo::GetUnwindPlan.
Fix typo in ArmUnwindInfo::GetUnwindPlan
Tue, Apr 16, 1:08 AM
teemperor committed rL358479: Fix typo in ArmUnwindInfo::GetUnwindPlan.
Fix typo in ArmUnwindInfo::GetUnwindPlan
Tue, Apr 16, 1:08 AM
teemperor closed D60655: Fix typo in ArmUnwindInfo::GetUnwindPlan.
Tue, Apr 16, 1:08 AM · Restricted Project, Restricted Project
teemperor committed rG376230c9ef17: Correctly check if a warning message lacks a trailing new line (authored by teemperor).
Correctly check if a warning message lacks a trailing new line
Tue, Apr 16, 12:47 AM
teemperor committed rLLDB358477: Correctly check if a warning message lacks a trailing new line.
Correctly check if a warning message lacks a trailing new line
Tue, Apr 16, 12:47 AM
teemperor committed rL358477: Correctly check if a warning message lacks a trailing new line.
Correctly check if a warning message lacks a trailing new line
Tue, Apr 16, 12:47 AM
teemperor closed D60653: Correctly check if a warning message lacks a trailing new line.
Tue, Apr 16, 12:47 AM · Restricted Project, Restricted Project
teemperor updated the diff for D60667: Allow direct comparison of ConstString against StringRef.
  • Made empty/nullptr check more readable.
  • Removed some uses of the new comparison operator for cases where we don't have a literal to compare against (which makes it hard to estimate if this is really better).
  • Reworded documentation so that the length of the string doesn't really matter getting a performance benefit, only the fact that whether ConstString we pass is temporary or not.
Tue, Apr 16, 12:45 AM · Restricted Project
teemperor added a comment to D60667: Allow direct comparison of ConstString against StringRef.

I, too, have some concern that this could have unintended side effects. To make the temporary StringRefs from the zero-terminated strings requires a strlen call each time. So we're making two passes over a string each time (once to measure and once to compare). Granted, these are mostly very short.

Tue, Apr 16, 12:42 AM · Restricted Project

Mon, Apr 15

teemperor added a comment to D60654: Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift.

I don't think I can provide a test for this because I don't really know the code so well (and generating an UNPREDICTABLE seems tricky too). I'll leave this up for a bit to see if someone comes up with a test (or I'll have time to dig into the code) and then commit.

Mon, Apr 15, 5:11 AM · Restricted Project

Sun, Apr 14

teemperor committed rG12886f04eae9: Prevent unnecessary conversion from StringRef to C-string [NFC] (authored by teemperor).
Prevent unnecessary conversion from StringRef to C-string [NFC]
Sun, Apr 14, 7:02 AM
teemperor committed rLLDB358357: Prevent unnecessary conversion from StringRef to C-string [NFC].
Prevent unnecessary conversion from StringRef to C-string [NFC]
Sun, Apr 14, 7:02 AM
teemperor committed rL358357: Prevent unnecessary conversion from StringRef to C-string [NFC].
Prevent unnecessary conversion from StringRef to C-string [NFC]
Sun, Apr 14, 7:02 AM
teemperor created D60667: Allow direct comparison of ConstString against StringRef.
Sun, Apr 14, 6:32 AM · Restricted Project

Sat, Apr 13

teemperor added a comment to D60655: Fix typo in ArmUnwindInfo::GetUnwindPlan.

Don't have the test for this and probably can't write one for it (as I don't have access to an ARM device for testing and don't really know the code so well). If anyone feels like providing a test, feel free to link it to this revision.

Sat, Apr 13, 12:40 PM · Restricted Project, Restricted Project
teemperor created D60655: Fix typo in ArmUnwindInfo::GetUnwindPlan.
Sat, Apr 13, 12:37 PM · Restricted Project, Restricted Project
teemperor created D60654: Fix UNPREDICTABLE check in EmulateInstructionARM::EmulateADDRegShift.
Sat, Apr 13, 11:43 AM · Restricted Project
teemperor created D60653: Correctly check if a warning message lacks a trailing new line.
Sat, Apr 13, 10:26 AM · Restricted Project, Restricted Project

Fri, Apr 12

teemperor updated the diff for D59537: Instantiate 'std' templates explicitly in the expression evaluator.
  • Added more documentation.
Fri, Apr 12, 8:32 AM · Restricted Project, Restricted Project
teemperor added a comment to D60410: PDBFPO: Improvements to the AST visitor.

I believe this revision introduced a warning when compiling with Clang:

 98% [4004/4047] Building CXX object tool....dir/PdbFPOProgramToDWARFExpression.cpp.o
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:161:7: warning: '(anonymous namespace)::FPOProgramASTVisitor<void>' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
class FPOProgramASTVisitor {
      ^
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:190:51: note: in instantiation of template class '(anonymous namespace)::FPOProgramASTVisitor<void>' requested here
class FPOProgramASTVisitorMergeDependent : public FPOProgramASTVisitor<> {
                                                  ^
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:190:7: warning: '(anonymous namespace)::FPOProgramASTVisitorMergeDependent' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
class FPOProgramASTVisitorMergeDependent : public FPOProgramASTVisitor<> {
      ^
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:161:7: warning: '(anonymous namespace)::FPOProgramASTVisitor<bool>' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
class FPOProgramASTVisitor {
      ^
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:232:14: note: in instantiation of template class '(anonymous namespace)::FPOProgramASTVisitor<bool>' requested here
    : public FPOProgramASTVisitor<bool> {
             ^
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:231:7: warning: '(anonymous namespace)::FPOProgramASTVisitorResolveRegisterRefs' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
class FPOProgramASTVisitorResolveRegisterRefs
      ^
/home/teemperor/llvm/side/llvm-project/lldb/source/Plugins/SymbolFile/NativePDB/PdbFPOProgramToDWARFExpression.cpp:310:7: warning: '(anonymous namespace)::FPOProgramASTVisitorDWARFCodegen' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
class FPOProgramASTVisitorDWARFCodegen : public FPOProgramASTVisitor<> {
      ^
5 warnings generated.
Fri, Apr 12, 6:32 AM · Restricted Project

Thu, Apr 11

teemperor requested changes to D59960: Fix for ambiguous lookup in expressions between local variable and namespace.
Thu, Apr 11, 7:12 AM

Wed, Apr 10

teemperor added a comment to D60508: [NFC] Remove ASCII lines from comments.

LGTM. Thanks for doing this! These lines are really frustrating to maintain when writing documentation. Also this should bring us yet again a bit closer to the LLVM style, so +1 for that.

Wed, Apr 10, 5:53 AM · Restricted Project

Tue, Apr 9

teemperor added a comment to D59537: Instantiate 'std' templates explicitly in the expression evaluator.

Thanks for the review!

Tue, Apr 9, 9:41 AM · Restricted Project, Restricted Project
teemperor committed rGfa26c20eba9b: Fixed comment as pointed out by post-commit review of D59845 (authored by teemperor).
Fixed comment as pointed out by post-commit review of D59845
Tue, Apr 9, 7:18 AM
teemperor committed rL358006: Fixed comment as pointed out by post-commit review of D59845.
Fixed comment as pointed out by post-commit review of D59845
Tue, Apr 9, 7:17 AM
teemperor committed rC358006: Fixed comment as pointed out by post-commit review of D59845.
Fixed comment as pointed out by post-commit review of D59845
Tue, Apr 9, 7:17 AM

Thu, Mar 28

teemperor updated the diff for D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..

Ah, I get it now. Fixed!

Thu, Mar 28, 2:58 AM · Restricted Project
teemperor added inline comments to D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..
Thu, Mar 28, 2:46 AM · Restricted Project
teemperor updated the diff for D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..
  • Addressed (most of) Aleksei's comments.
Thu, Mar 28, 2:46 AM · Restricted Project

Wed, Mar 27

teemperor added a comment to D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..

Well, I still don't understand how LLDB synthesis the AST.
So you have a C++ module in a .pcm file. This means you could create an AST from that with ASTReader from it's .clang_ast section, right? In that case the AST should be complete with all type information. If this was the case then I don't see why it is not possible to use clang::ASTImporter to import templates and specializations, since we do exactly that in CTU.

Or do you guys create the AST from the debug info, from the .debug_info section of .pcm module file? And this is why AST is incomplete? I've got this from https://youtu.be/EgkZ8PTNSHQ?list=PL85Cf-ok7HpppFWlp2wX_-A1dkyFVlaEB&t=1565
If this is the case, then comes my naiive quiestion: Why don't you use the ASTReader?

There are no C++ modules involved in our use case beside the generic std module. No user-written code is read from a module and we don't have any PCM file beside the std module we build for the expression evaluator.

We use the ASTReader to directly read the std module contents into the expression evaluation ASTContext, but this doesn't give us the decls for the instantiations the user has made (e.g. std::vector<Foo>). We only have these user instantiations in the 'normal' debug info where we have a rather minimal AST (again, no modules are not involved in building this debug info AST). The InternalImport in the LLDB patch just stitches the module AST and the debug info AST together when we import something that we also have (in better quality from the C++ module) in the target ASTContext.

Thank you for the explanation.
Now I understand you directly create specializations from the std module and intercept the import to avoid importing broken specializations from the debug info, this makes sense.

Really, just one last question to see the whole picture: If clang::ASTImporter were capable of handling a specialization/instantiation with missing info then we could use that. So the reason for this interception is that clang::ASTImporter::VisitClassTemplateSpecializationDecl cannot handle the specialization it receives because that or its dependent nodes has too many missing data, right?

Wed, Mar 27, 9:49 AM · Restricted Project

Mar 22 2019

teemperor updated the diff for D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..
  • Removed unused functions.
  • Fixed two comments that I missed to update.
Mar 22 2019, 2:09 PM · Restricted Project
teemperor updated the diff for D59537: Instantiate 'std' templates explicitly in the expression evaluator.
  • Removed dump() that was left in there from some debugging.
  • Changed the second Import call I missed to Import_New
  • No longer ignoring the Errors in Expected when importing template arguments.
Mar 22 2019, 7:00 AM · Restricted Project, Restricted Project
teemperor added a comment to D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..

Well, I still don't understand how LLDB synthesis the AST.
So you have a C++ module in a .pcm file. This means you could create an AST from that with ASTReader from it's .clang_ast section, right? In that case the AST should be complete with all type information. If this was the case then I don't see why it is not possible to use clang::ASTImporter to import templates and specializations, since we do exactly that in CTU.

Or do you guys create the AST from the debug info, from the .debug_info section of .pcm module file? And this is why AST is incomplete? I've got this from https://youtu.be/EgkZ8PTNSHQ?list=PL85Cf-ok7HpppFWlp2wX_-A1dkyFVlaEB&t=1565
If this is the case, then comes my naiive quiestion: Why don't you use the ASTReader?

Mar 22 2019, 6:28 AM · Restricted Project
teemperor updated the diff for D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..
  • Addressed feedback.
Mar 22 2019, 4:49 AM · Restricted Project

Mar 21 2019

teemperor updated the diff for D59537: Instantiate 'std' templates explicitly in the expression evaluator.
  • Added more tests (contents from debug info for containers, vectors of vectors)
  • Import -> Import_New
  • Rebased on top of the updated parent commit, which means the StdModuleHandler is now much simpler.
Mar 21 2019, 1:36 PM · Restricted Project, Restricted Project
teemperor added inline comments to D59537: Instantiate 'std' templates explicitly in the expression evaluator.
Mar 21 2019, 1:35 PM · Restricted Project, Restricted Project
teemperor updated the diff for D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..

So I replaced the whole Strategy/Shim thing with a simple ImportInternal method that we can overwrite and is also no longer public. That also gets rid of all the boilerplate code from the first patches and also makes the follow-up LLDB patch nicer.

Mar 21 2019, 1:15 PM · Restricted Project

Mar 20 2019

teemperor committed rG5e3a7698e80f: Remove the unused return value in ASTImporter::Imported [NFC] (authored by teemperor).
Remove the unused return value in ASTImporter::Imported [NFC]
Mar 20 2019, 12:00 PM
teemperor committed rC356592: Remove the unused return value in ASTImporter::Imported [NFC].
Remove the unused return value in ASTImporter::Imported [NFC]
Mar 20 2019, 11:59 AM
teemperor committed rL356592: Remove the unused return value in ASTImporter::Imported [NFC].
Remove the unused return value in ASTImporter::Imported [NFC]
Mar 20 2019, 11:59 AM
teemperor committed rLLDB356592: Remove the unused return value in ASTImporter::Imported [NFC].
Remove the unused return value in ASTImporter::Imported [NFC]
Mar 20 2019, 11:59 AM
teemperor closed D59595: Remove the unused return value in ASTImporter::Imported [NFC].
Mar 20 2019, 11:59 AM · Restricted Project, Restricted Project
teemperor created D59595: Remove the unused return value in ASTImporter::Imported [NFC].
Mar 20 2019, 4:20 AM · Restricted Project, Restricted Project

Mar 19 2019

teemperor planned changes to D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..

I think we could also refactor the strategy into a PreImport call. That way we don't break all the user-code out there and it seems less intrusive to the ASTImporter code. I'll update the patch.

Mar 19 2019, 2:50 AM · Restricted Project
teemperor added a parent revision for D59537: Instantiate 'std' templates explicitly in the expression evaluator: D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..
Mar 19 2019, 2:36 AM · Restricted Project, Restricted Project
teemperor created D59537: Instantiate 'std' templates explicitly in the expression evaluator.
Mar 19 2019, 2:36 AM · Restricted Project, Restricted Project
teemperor added a child revision for D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior.: D59537: Instantiate 'std' templates explicitly in the expression evaluator.
Mar 19 2019, 2:36 AM · Restricted Project
teemperor updated the diff for D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..

Thanks for the quick review! I changed the code to also update the internal ASTImporter state like with a normal decl.

Mar 19 2019, 1:13 AM · Restricted Project

Mar 18 2019

teemperor created D59485: [ASTImporter] Add an ImportInternal method to allow customizing Import behavior..
Mar 18 2019, 5:42 AM · Restricted Project

Mar 14 2019

teemperor committed rGd63c1dbd4b1f: Safer casting in ClangExpressionParser code completion (authored by teemperor).
Safer casting in ClangExpressionParser code completion
Mar 14 2019, 10:40 AM
teemperor committed rL356174: Safer casting in ClangExpressionParser code completion.
Safer casting in ClangExpressionParser code completion
Mar 14 2019, 10:38 AM
teemperor committed rLLDB356174: Safer casting in ClangExpressionParser code completion.
Safer casting in ClangExpressionParser code completion
Mar 14 2019, 10:38 AM
teemperor closed D59359: Safer casting in ClangExpressionParser code completion.
Mar 14 2019, 10:38 AM · Restricted Project
teemperor added a comment to rG087968716c3e: Sync with upstream.

Wait, do I understand correctly that this is a commit from your personal github repo, but somehow phab finds it and thinks it is in the official LLVM repo?

Mar 14 2019, 8:01 AM
teemperor updated the diff for D59359: Safer casting in ClangExpressionParser code completion.
  • Changed to llvm::cast (even though the assert message is a bit generic now).
Mar 14 2019, 6:39 AM · Restricted Project
teemperor created D59359: Safer casting in ClangExpressionParser code completion.
Mar 14 2019, 5:38 AM · Restricted Project

Mar 12 2019

teemperor committed rG6c0bbfc0c94b: Add ability to import std module into expression parser to improve C++ debugging (authored by teemperor).
Add ability to import std module into expression parser to improve C++ debugging
Mar 12 2019, 10:10 AM
teemperor committed rL355939: Add ability to import std module into expression parser to improve C++ debugging.
Add ability to import std module into expression parser to improve C++ debugging
Mar 12 2019, 10:10 AM
teemperor committed rLLDB355939: Add ability to import std module into expression parser to improve C++ debugging.
Add ability to import std module into expression parser to improve C++ debugging
Mar 12 2019, 10:10 AM
teemperor closed D58125: Add ability to import std module into expression parser to improve C++ debugging.
Mar 12 2019, 10:10 AM · Restricted Project, Restricted Project, Restricted Project
teemperor updated the diff for D58125: Add ability to import std module into expression parser to improve C++ debugging.
  • Rebased patch.
  • Modernized for loops in ASTUtils.
Mar 12 2019, 10:04 AM · Restricted Project, Restricted Project, Restricted Project
teemperor committed rGa946997c2482: Correctly look up declarations in inline namespaces (authored by teemperor).
Correctly look up declarations in inline namespaces
Mar 12 2019, 12:45 AM
teemperor committed rL355897: Correctly look up declarations in inline namespaces.
Correctly look up declarations in inline namespaces
Mar 12 2019, 12:44 AM
teemperor committed rLLDB355897: Correctly look up declarations in inline namespaces.
Correctly look up declarations in inline namespaces
Mar 12 2019, 12:44 AM
teemperor closed D59198: Correctly look up declarations in inline namespaces.
Mar 12 2019, 12:44 AM · Restricted Project, Restricted Project
teemperor committed rG21347b29013b: Fix git-llvm crashing when trying to remove directory while cleaning (authored by teemperor).
Fix git-llvm crashing when trying to remove directory while cleaning
Mar 12 2019, 12:40 AM
teemperor committed rL355896: Fix git-llvm crashing when trying to remove directory while cleaning.
Fix git-llvm crashing when trying to remove directory while cleaning
Mar 12 2019, 12:40 AM
teemperor closed D59236: Fix git-llvm crashing when trying to remove directory while cleaning.
Mar 12 2019, 12:40 AM · Restricted Project
teemperor updated the diff for D59236: Fix git-llvm crashing when trying to remove directory while cleaning.
  • Added safety check that we don't delete directories or files outside the llvm staging dir.
Mar 12 2019, 12:07 AM · Restricted Project

Mar 11 2019

teemperor created D59236: Fix git-llvm crashing when trying to remove directory while cleaning.
Mar 11 2019, 4:06 PM · Restricted Project
teemperor added inline comments to D58125: Add ability to import std module into expression parser to improve C++ debugging.
Mar 11 2019, 10:25 AM · Restricted Project, Restricted Project, Restricted Project
teemperor updated the diff for D59198: Correctly look up declarations in inline namespaces.
  • Addressed Adrian's comments.
Mar 11 2019, 9:47 AM · Restricted Project, Restricted Project
teemperor updated the diff for D58125: Add ability to import std module into expression parser to improve C++ debugging.
  • Addressed Pavel's comments.
Mar 11 2019, 2:48 AM · Restricted Project, Restricted Project, Restricted Project

Mar 10 2019

teemperor created D59198: Correctly look up declarations in inline namespaces.
Mar 10 2019, 4:50 PM · Restricted Project, Restricted Project

Mar 9 2019

teemperor updated the diff for D58125: Add ability to import std module into expression parser to improve C++ debugging.
  • Addressed Pavel's comments (thanks!).
  • Reworked test setup code (thanks Adrian!)
  • Rebased the patch.
Mar 9 2019, 2:56 PM · Restricted Project, Restricted Project, Restricted Project

Mar 6 2019

teemperor committed rGa4a167fb759d: Remove redundant second os.path.join call [NFC] (authored by teemperor).
Remove redundant second os.path.join call [NFC]
Mar 6 2019, 12:53 PM
teemperor committed rLLDB355548: Remove redundant second os.path.join call [NFC].
Remove redundant second os.path.join call [NFC]
Mar 6 2019, 12:52 PM
teemperor committed rL355548: Remove redundant second os.path.join call [NFC].
Remove redundant second os.path.join call [NFC]
Mar 6 2019, 12:52 PM

Mar 4 2019

teemperor added inline comments to D58125: Add ability to import std module into expression parser to improve C++ debugging.
Mar 4 2019, 12:34 PM · Restricted Project, Restricted Project, Restricted Project
teemperor added inline comments to D58125: Add ability to import std module into expression parser to improve C++ debugging.
Mar 4 2019, 10:59 AM · Restricted Project, Restricted Project, Restricted Project
teemperor added inline comments to D58125: Add ability to import std module into expression parser to improve C++ debugging.
Mar 4 2019, 10:37 AM · Restricted Project, Restricted Project, Restricted Project
teemperor updated the diff for D58125: Add ability to import std module into expression parser to improve C++ debugging.
  • Refactored build flags.
  • Fixed doxygen comment.
Mar 4 2019, 10:04 AM · Restricted Project, Restricted Project, Restricted Project

Mar 3 2019

teemperor updated the diff for D58125: Add ability to import std module into expression parser to improve C++ debugging.
  • Remove libc++ dependency from sysroot test.
  • Small format fix for sysroot Makefile
Mar 3 2019, 9:32 AM · Restricted Project, Restricted Project, Restricted Project
teemperor updated the diff for D58125: Add ability to import std module into expression parser to improve C++ debugging.
  • Added sysroot test.
  • Moved build flags into MANDATORY_CXXMODULE_BUILD_FLAGS make variable.
Mar 3 2019, 8:33 AM · Restricted Project, Restricted Project, Restricted Project

Mar 1 2019

teemperor accepted D58743: Handle built-in when importing SourceLocation and FileID .

LGTM, thanks!

Mar 1 2019, 2:44 PM · Restricted Project

Feb 28 2019

teemperor accepted D58793: [CMake] Make liblldb depend on clang-headers.

LGTM.

Feb 28 2019, 1:34 PM · Restricted Project

Feb 27 2019

teemperor added inline comments to D58748: [ExpressionParser] Test GetClangResourceDir.
Feb 27 2019, 11:02 PM · Restricted Project
teemperor requested changes to D58743: Handle built-in when importing SourceLocation and FileID .

I think the idea of the patch is right. Not sure tough if having Import take a second parameter is consistent with the other Import functions (and if that even matters).

Feb 27 2019, 3:54 PM · Restricted Project
teemperor committed rL354966: Moved the Clang autocompletion project to 2019..
Moved the Clang autocompletion project to 2019.
Feb 27 2019, 4:12 AM
teemperor committed rL354965: Cleanup open projects ToC.
Cleanup open projects ToC
Feb 27 2019, 3:56 AM
teemperor committed rL354964: Added ASTImporter fuzzer to ToC..
Added ASTImporter fuzzer to ToC.
Feb 27 2019, 3:56 AM

Feb 25 2019

teemperor added a comment to D58339: Changes for running LLDB test suite for Swift on PowerPC64LE.

That should be the right repo: https://github.com/apple/swift-lldb

Feb 25 2019, 7:05 AM · Restricted Project

Feb 17 2019

teemperor added inline comments to D58125: Add ability to import std module into expression parser to improve C++ debugging.
Feb 17 2019, 4:32 AM · Restricted Project, Restricted Project, Restricted Project

Feb 16 2019

teemperor committed rG913f07af6e46: Fix TestDataFormatterLibcxxListLoop.py test (authored by teemperor).
Fix TestDataFormatterLibcxxListLoop.py test
Feb 16 2019, 4:14 AM
teemperor committed rLLDB354202: Fix TestDataFormatterLibcxxListLoop.py test.
Fix TestDataFormatterLibcxxListLoop.py test
Feb 16 2019, 4:13 AM
teemperor committed rL354202: Fix TestDataFormatterLibcxxListLoop.py test.
Fix TestDataFormatterLibcxxListLoop.py test
Feb 16 2019, 4:13 AM
teemperor closed D58273: Fix TestDataFormatterLibcxxListLoop.py test.
Feb 16 2019, 4:13 AM · Restricted Project, Restricted Project

Feb 15 2019

teemperor added a comment to D58125: Add ability to import std module into expression parser to improve C++ debugging.

@labath Thanks for the hint with the sysroot, but I'm not really sure what's the best way to test this. Making a whole fake sysroot that can be used to compile a std module seems overkill, and not sure if symlinking or so is a good approach either. I'm open to suggestions.

Feb 15 2019, 8:49 AM · Restricted Project, Restricted Project, Restricted Project