Page MenuHomePhabricator

teemperor (Raphael Isemann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 23 2016, 8:38 AM (235 w, 4 d)

Recent Activity

Today

teemperor added a comment to D88123: Add the ability to write 'target stop-hooks' in Python.

This also doesn't work on my macOS system:

FAIL: LLDB (/Users/teemperor/1llvm/rel/bin/clang-x86_64) :: test_stop_hooks_scripted_return_false (TestStopHookScripted.TestStopHooks)
======================================================================
FAIL: test_stop_hooks_scripted_return_false (TestStopHookScripted.TestStopHooks)
   Test that the returning False from a stop hook works
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/teemperor/1llvm/llvm-project/lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py", line 54, in test_stop_hooks_scripted_return_false
    self.do_test_auto_continue(True)
  File "/Users/teemperor/1llvm/llvm-project/lldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py", line 91, in do_test_auto_continue
    self.assertEqual("main", func_name, "Didn't stop at the expected function.")
AssertionError: 'main' != 'step_out_of_me'
- main+ step_out_of_me : Didn't stop at the expected function.
Config=x86_64-/Users/teemperor/1llvm/rel/bin/clang
----------------------------------------------------------------------
Sun, Sep 27, 3:39 AM · Restricted Project
teemperor committed rGe779427757f2: Fix MIPS and MIPS64 ABI to use ConstString in their register info arrays. (authored by tatsuo).
Fix MIPS and MIPS64 ABI to use ConstString in their register info arrays.
Sun, Sep 27, 3:37 AM
teemperor closed D88375: Fix MIPS and MIPS64 ABI to use ConstString in thier register info arrays..
Sun, Sep 27, 3:37 AM · Restricted Project
teemperor added a comment to D88375: Fix MIPS and MIPS64 ABI to use ConstString in thier register info arrays..

Done. Thanks for the patch!

Sun, Sep 27, 3:36 AM · Restricted Project
teemperor accepted D88375: Fix MIPS and MIPS64 ABI to use ConstString in thier register info arrays..

To clarify the description a bit: RegInfoBasedABI::GetRegisterInfoByName is comparing the name/alt_name by doing a const char * pointer value comparison. That only works if both strings that are compared are coming from a ConstString. Since b0060c3a7868ef026d95d0cf8a076791ef74f474 GetRegisterInfoByName is checking with an assert that both C strings came from a ConstString (which is failing as these ABI implementation changed here are lacking the ConstString'ification code).

Sun, Sep 27, 3:14 AM · Restricted Project

Fri, Sep 25

teemperor added a comment to D88302: [lldb] Remove nothreadallow from SWIG's __str__ wrappers to work around a Python>=3.7 crash.

If anyone knows another SB object where calling str on it would execute a Python script (and that is simpler than an synthetic child provider), then let me know.

Fri, Sep 25, 7:22 AM
teemperor requested review of D88302: [lldb] Remove nothreadallow from SWIG's __str__ wrappers to work around a Python>=3.7 crash.
Fri, Sep 25, 7:21 AM
teemperor requested review of D88289: [lldb][NFC] Fix some invalid escapes sequences in Python strings.
Fri, Sep 25, 3:01 AM · Restricted Project

Wed, Sep 23

teemperor accepted D88119: [lldb] Remove lldb-perf remenant.
Wed, Sep 23, 3:06 AM · Restricted Project
teemperor added a reverting change for rGfdc41e11f968: [libc++] Implement LWG1203: rGe46c1def5233: Revert "[libc++] Implement LWG1203".
Wed, Sep 23, 1:16 AM
teemperor committed rGe46c1def5233: Revert "[libc++] Implement LWG1203" (authored by teemperor).
Revert "[libc++] Implement LWG1203"
Wed, Sep 23, 1:16 AM
teemperor added a comment to D83038: [clang] Add an option for hiding line numbers in diagnostics.

@MaskRay is this ready to land? (This is technically in the 'accepted' state so this review probably disappeared from everyone's review queue, hence my ping)

Wed, Sep 23, 12:04 AM

Tue, Sep 22

teemperor added a reverting change for rG7518006d75ac: [lldb] XFAIL TestMemoryHistory on Linux: rGef7d22a98683: Revert "[lldb] XFAIL TestMemoryHistory on Linux".
Tue, Sep 22, 12:15 PM
teemperor committed rGef7d22a98683: Revert "[lldb] XFAIL TestMemoryHistory on Linux" (authored by teemperor).
Revert "[lldb] XFAIL TestMemoryHistory on Linux"
Tue, Sep 22, 12:15 PM
teemperor committed rGb5e49e91cb90: [lldb] Ignore certain Clang type sugar when creating the type name (authored by teemperor).
[lldb] Ignore certain Clang type sugar when creating the type name
Tue, Sep 22, 4:38 AM
teemperor closed D87481: [lldb] Ignore certain Clang type sugar when creating the type name.
Tue, Sep 22, 4:38 AM · Restricted Project
teemperor updated the diff for D87481: [lldb] Ignore certain Clang type sugar when creating the type name.
  • Don't use a typedef in the formatter test case (which already has a special code path) but just a struct.
Tue, Sep 22, 3:40 AM · Restricted Project

Mon, Sep 21

teemperor committed rG7c4575e15f06: [ASTImporter] Refactor IsStructurallyEquivalent's Decl overloads to be more… (authored by teemperor).
[ASTImporter] Refactor IsStructurallyEquivalent's Decl overloads to be more…
Mon, Sep 21, 7:41 AM
teemperor closed D87619: [ASTImporter] Refactor IsStructurallyEquivalent's Decl overloads to be more consistent.
Mon, Sep 21, 7:41 AM · Restricted Project

Wed, Sep 16

teemperor added inline comments to D87619: [ASTImporter] Refactor IsStructurallyEquivalent's Decl overloads to be more consistent.
Wed, Sep 16, 12:37 PM · Restricted Project

Tue, Sep 15

teemperor added a comment to D87619: [ASTImporter] Refactor IsStructurallyEquivalent's Decl overloads to be more consistent.

Thank you! This is a great simplification of the code and it is much cleaner this way, nice work!
I queued a CTU build, just to verify nothing will be break:
#1​71​9 at http://codechecker-buildbot.eastus.cloudapp.azure.com:8080/job/ctu_pipeline_clang-master-monorepo/

Tue, Sep 15, 2:03 AM · Restricted Project

Mon, Sep 14

teemperor updated the diff for D87619: [ASTImporter] Refactor IsStructurallyEquivalent's Decl overloads to be more consistent.
  • Removed an unrelated change.
Mon, Sep 14, 9:58 AM · Restricted Project
teemperor requested review of D87619: [ASTImporter] Refactor IsStructurallyEquivalent's Decl overloads to be more consistent.
Mon, Sep 14, 9:57 AM · Restricted Project
teemperor planned changes to D87481: [lldb] Ignore certain Clang type sugar when creating the type name.

This makes sense, thanks!

Since your main motivation is formatter selection, you might want to consider adding a formatting test, too. To be precise, I see that you have a formatting test for typedef already, but that one would pass even without your change (as far as I can see). I mean a formatting test for the case described in your patch summary, that one should fail without your patch.

Mon, Sep 14, 9:38 AM · Restricted Project

Sun, Sep 13

teemperor committed rGc0bcd11068fc: [ASTImporter] Add basic support for comparing Stmts and compare function bodies (authored by teemperor).
[ASTImporter] Add basic support for comparing Stmts and compare function bodies
Sun, Sep 13, 9:25 AM
teemperor closed D87444: [ASTImporter] Add basic support for comparing Stmts and compare function bodies.
Sun, Sep 13, 9:25 AM · Restricted Project

Fri, Sep 11

teemperor updated the diff for D87444: [ASTImporter] Add basic support for comparing Stmts and compare function bodies.
  • Added early-exit in CallExpr comparison.
  • Added an unreachable to fix a missing return warning.
Fri, Sep 11, 11:44 AM · Restricted Project
teemperor added a comment to D87444: [ASTImporter] Add basic support for comparing Stmts and compare function bodies.

Thanks for the quick review!

Fri, Sep 11, 3:20 AM · Restricted Project
teemperor updated the diff for D87444: [ASTImporter] Add basic support for comparing Stmts and compare function bodies.
  • Remove FunctionDecl body comparison workaround.
  • Add makeStmt and makeWrappedStmt with AST matcher parameters.
Fri, Sep 11, 3:10 AM · Restricted Project

Thu, Sep 10

teemperor requested review of D87481: [lldb] Ignore certain Clang type sugar when creating the type name.
Thu, Sep 10, 1:55 PM · Restricted Project
teemperor requested review of D87444: [ASTImporter] Add basic support for comparing Stmts and compare function bodies.
Thu, Sep 10, 2:52 AM · Restricted Project

Wed, Sep 9

teemperor added a comment to D87327: [debugserver] Extract function for default launch flavor.

@teemperor I'm not sure what these build errors mean, for example https://reviews.llvm.org/B70998. Also there's the linux build failure, but that's not relevant for debugserver, right?

Wed, Sep 9, 11:30 AM · Restricted Project
teemperor resigned from D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect.

Thanks!

Wed, Sep 9, 10:52 AM · Restricted Project, Restricted Project
teemperor updated subscribers of D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect.
Wed, Sep 9, 10:51 AM · Restricted Project, Restricted Project
teemperor requested changes to D87389: [flang][openacc] Lower clauses on loop construct to OpenACC dialect.
Wed, Sep 9, 10:28 AM · Restricted Project, Restricted Project
teemperor committed rGb85222520f86: [lldb] Enable std::pair in CxxModuleHandler (authored by teemperor).
[lldb] Enable std::pair in CxxModuleHandler
Wed, Sep 9, 1:50 AM
teemperor closed D85141: [lldb] Enable std::pair in CxxModuleHandler.
Wed, Sep 9, 1:50 AM · Restricted Project, Restricted Project
teemperor committed rG7866b9140569: [lldb] Fix a crash when the ASTImporter is giving us two Imported callbacks for… (authored by teemperor).
[lldb] Fix a crash when the ASTImporter is giving us two Imported callbacks for…
Wed, Sep 9, 1:32 AM
teemperor added a reverting change for D72495: [lldb] Make CompleteTagDeclsScope completion order deterministic: rG7866b9140569: [lldb] Fix a crash when the ASTImporter is giving us two Imported callbacks for….
Wed, Sep 9, 1:32 AM · Restricted Project
teemperor closed D85648: [lldb] Fix a crash when the ASTImporter is giving us two Imported callbacks for the same target decl.
Wed, Sep 9, 1:32 AM · Restricted Project
teemperor added a comment to D85648: [lldb] Fix a crash when the ASTImporter is giving us two Imported callbacks for the same target decl.
  • Clarify that this isn't just a direct revert, but reverts by establishing a set again instead of just a plain vector (Thanks Shafik!)
Wed, Sep 9, 1:16 AM · Restricted Project
teemperor updated the summary of D85648: [lldb] Fix a crash when the ASTImporter is giving us two Imported callbacks for the same target decl.
Wed, Sep 9, 1:15 AM · Restricted Project
teemperor added a comment to D85648: [lldb] Fix a crash when the ASTImporter is giving us two Imported callbacks for the same target decl.

LGTM, it is sad we lose the deterministic ordering though. Would it be efficient enough to use a vector but keep the set to prevent duplicates?

Wed, Sep 9, 1:14 AM · Restricted Project
teemperor committed rG32c8da41dc0c: [lldb] Don't infinite loop in SemaSourceWithPriorities::CompleteType when… (authored by teemperor).
[lldb] Don't infinite loop in SemaSourceWithPriorities::CompleteType when…
Wed, Sep 9, 1:06 AM
teemperor closed D87289: [lldb] Don't infinite loop in SemaSourceWithPriorities::CompleteType when trying to complete a forward decl.
Wed, Sep 9, 1:06 AM · Restricted Project
teemperor committed rG4e4a3feecdb6: [lldb][doc] Mention python3-dev instead of python2.7-dev in build docs (authored by teemperor).
[lldb][doc] Mention python3-dev instead of python2.7-dev in build docs
Wed, Sep 9, 12:32 AM
teemperor accepted D87345: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS.
Wed, Sep 9, 12:14 AM · Restricted Project
teemperor added a comment to D87345: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS.

LGTM.

Wed, Sep 9, 12:14 AM · Restricted Project
teemperor accepted D87327: [debugserver] Extract function for default launch flavor.

LGTM, thanks for the cleanup! (And also having the second list of comments no longer always stating 'SpringBoard' is even better).

Wed, Sep 9, 12:10 AM · Restricted Project

Tue, Sep 8

teemperor updated the diff for D87289: [lldb] Don't infinite loop in SemaSourceWithPriorities::CompleteType when trying to complete a forward decl.
  • Upload correct diff.
Tue, Sep 8, 8:20 AM · Restricted Project
teemperor requested review of D87289: [lldb] Don't infinite loop in SemaSourceWithPriorities::CompleteType when trying to complete a forward decl.
Tue, Sep 8, 8:19 AM · Restricted Project
teemperor set the repository for D87281: [lldb] Add a C language REPL to test LLDB's REPL infrastructure to rLLDB LLDB.
Tue, Sep 8, 7:30 AM · Restricted Project
teemperor updated the diff for D87281: [lldb] Add a C language REPL to test LLDB's REPL infrastructure.
  • Retry uploading diff.
Tue, Sep 8, 7:12 AM · Restricted Project
teemperor updated the diff for D87281: [lldb] Add a C language REPL to test LLDB's REPL infrastructure.
  • Added comments to unimplemented functions.
  • Changed repl source file name.
Tue, Sep 8, 7:09 AM · Restricted Project
teemperor updated subscribers of D87243: [cmake] Centralize LLVM_ENABLE_WARNINGS option.
Tue, Sep 8, 6:57 AM · Restricted Project, Restricted Project, Restricted Project
teemperor added a comment to D87281: [lldb] Add a C language REPL to test LLDB's REPL infrastructure.

(And I'm aware there are a lot more tests needed to test all the REPL code that had no tests so far. I'll see what's missing once this his the coverage bot and then I'll make put reviews up for that).

Tue, Sep 8, 5:29 AM · Restricted Project
teemperor requested review of D87281: [lldb] Add a C language REPL to test LLDB's REPL infrastructure.
Tue, Sep 8, 5:26 AM · Restricted Project
teemperor added a comment to D86344: [FileCheck] Move FileCheck implementation out of LLVMSupport into its own library.

Somewhat minor post-commit thought, but we now have both a library FileCheck and an executable binary FileCheck (not to mention the existing confusion of having two FileCheck.cpp files).

Might be nice to think about a naming scheme that would reduce these collisions?

Tue, Sep 8, 1:43 AM · Restricted Project
teemperor updated the summary of D83038: [clang] Add an option for hiding line numbers in diagnostics.
Tue, Sep 8, 12:52 AM
teemperor updated the diff for D83038: [clang] Add an option for hiding line numbers in diagnostics.
  • Fix typo and argument comments (thanks MaskRay !)
Tue, Sep 8, 12:52 AM

Mon, Sep 7

teemperor updated the diff for D83038: [clang] Add an option for hiding line numbers in diagnostics.
  • Removed driver arg and now tested via a unit test.
Mon, Sep 7, 7:59 AM
teemperor added a reverting change for rG0478720157f6: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further…: rG23f700c785a1: Revert "[clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further….
Mon, Sep 7, 5:51 AM
teemperor committed rG23f700c785a1: Revert "[clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further… (authored by teemperor).
Revert "[clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further…
Mon, Sep 7, 5:51 AM
teemperor added a reverting change for D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations.: rG23f700c785a1: Revert "[clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further….
Mon, Sep 7, 5:51 AM · Restricted Project
teemperor reopened D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations..

And what if deserialization is forced?

Mon, Sep 7, 5:49 AM · Restricted Project
teemperor committed rG0478720157f6: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further… (authored by teemperor).
[clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further…
Mon, Sep 7, 3:32 AM
teemperor closed D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations..
Mon, Sep 7, 3:32 AM · Restricted Project
teemperor added a comment to D85141: [lldb] Enable std::pair in CxxModuleHandler.

Do we understand how to fix the crash in the case where we get a pair back? I am not sure how frequent the use case is.

Mon, Sep 7, 1:49 AM · Restricted Project, Restricted Project
teemperor committed rGa98b126696ef: Add BinaryFormat/ELFRelocs/CSKY.def to LLVM modulemap (authored by teemperor).
Add BinaryFormat/ELFRelocs/CSKY.def to LLVM modulemap
Mon, Sep 7, 1:15 AM

Fri, Sep 4

teemperor added a comment to D83038: [clang] Add an option for hiding line numbers in diagnostics.

Isn't DiagOpts->ShowLine sufficient? I don't think clang command line users will specify -fno-show-line...

Fri, Sep 4, 2:38 PM
teemperor added a comment to D86996: [lldb] Add -l/--language option to script command.

I have to agree with @kastiglione that this isn't very intuitive. I doubt that more than a handful of users are aware that "raw commands" are a thing, so I think this inconsistency is for once in favor of the user. LLDB commands are anyway not meant to be stable, so we can just fix this if this ever turns out to be a real issue.

Fri, Sep 4, 5:06 AM · Restricted Project, Restricted Project
teemperor committed rG101f37a1b330: [lldb][NFC] Rewrite CPP11EnumTypes test to make it faster (authored by teemperor).
[lldb][NFC] Rewrite CPP11EnumTypes test to make it faster
Fri, Sep 4, 4:46 AM
teemperor added reviewers for D87133: Fix all the CMake code that can only handle -stdlib= but not --stdlib=: ldionne, phosek.
Fri, Sep 4, 3:32 AM
teemperor requested review of D87133: Fix all the CMake code that can only handle -stdlib= but not --stdlib=.
Fri, Sep 4, 3:31 AM
teemperor committed rGf9ad112770ec: [lldb] Speed up TestValueObjectRecursion by making it a no_debug_info_test (authored by teemperor).
[lldb] Speed up TestValueObjectRecursion by making it a no_debug_info_test
Fri, Sep 4, 2:29 AM
teemperor added inline comments to D83038: [clang] Add an option for hiding line numbers in diagnostics.
Fri, Sep 4, 1:33 AM
teemperor updated the diff for D83038: [clang] Add an option for hiding line numbers in diagnostics.
  • Fixed formatting in switch-case
  • Fixed formatting in DiagnosticOptions.def
Fri, Sep 4, 1:18 AM
teemperor added a comment to D86106: [lldb] avoid assert in threadsanitizer tests on linux.

Sorry, I totally didn't see this patch (I also only added Fred as a reviewer as he added the assert, so there weren't even any shared reviewers who could have pointed this out).

Fri, Sep 4, 12:51 AM · Restricted Project
teemperor added a reverting change for rGf369d51896e1: [lldb] avoid assert in threadsanitizer tests on linux: rGbdc4c0bc5c5e: Revert "[lldb] avoid assert in threadsanitizer tests on linux".
Fri, Sep 4, 12:32 AM
teemperor committed rGbdc4c0bc5c5e: Revert "[lldb] avoid assert in threadsanitizer tests on linux" (authored by teemperor).
Revert "[lldb] avoid assert in threadsanitizer tests on linux"
Fri, Sep 4, 12:32 AM

Thu, Sep 3

teemperor updated the diff for D80878: [clang] Prevent that Decl::dump on a CXXRecordDecl deserialises further declarations..
  • rename to maybe_constexpr
  • Update some dump output tests
Thu, Sep 3, 7:15 AM · Restricted Project
teemperor added a comment to D86937: Adding GDB PrettyPrinter for mlir::Identifier..

This is breaking the Green Dragon bot: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/23667/console

Thu, Sep 3, 2:32 AM · Restricted Project
teemperor accepted D87076: [lldb/Interpreter] Fix language detection for the REPL InitFile.

This patch sparks joy, but the fact that this all is dead code without Swift doesn't spark joy. But as it's up to me to revive this code and the downstream Swift test looks fine, I'll sign this off. Thanks!

Thu, Sep 3, 1:48 AM · Restricted Project
teemperor committed rG5b354d204d09: [lldb] Make symbol list output from `image dump symtab` not depend on internal… (authored by teemperor).
[lldb] Make symbol list output from `image dump symtab` not depend on internal…
Thu, Sep 3, 1:28 AM
teemperor closed D87036: [lldb] Make symbol list output from `image dump symtab` not depend on internal ordering of DenseMap.
Thu, Sep 3, 1:28 AM · Restricted Project
teemperor added a comment to D87036: [lldb] Make symbol list output from `image dump symtab` not depend on internal ordering of DenseMap.

Looks good.

This should also avoid changing the test all the time when someone touches one of the symbols (as in D68533 )

AFAICT, that patch modified the test because it actually introduced a new symbol -- the order of the existing symbols was not changed.

Thu, Sep 3, 1:24 AM · Restricted Project
teemperor committed rGe123959e9471: [lldb] Remove debugserver specific string from TestAbortExitCode check (authored by teemperor).
[lldb] Remove debugserver specific string from TestAbortExitCode check
Thu, Sep 3, 1:04 AM
teemperor committed rG9124fa592098: Fix broken HUGE_VALF macro in llvm-c/DataTypes.h (authored by teemperor).
Fix broken HUGE_VALF macro in llvm-c/DataTypes.h
Thu, Sep 3, 12:51 AM
teemperor closed D83761: Fix broken HUGE_VALF macro in llvm-c/DataTypes.h.
Thu, Sep 3, 12:50 AM · Restricted Project
teemperor committed rGf0699d910914: [debugserver] Fix that debugserver's stop reply packets always return signal… (authored by teemperor).
[debugserver] Fix that debugserver's stop reply packets always return signal…
Thu, Sep 3, 12:47 AM
teemperor closed D86336: [debugserver] Fix that debugserver's stop reply packets always return signal code 0.
Thu, Sep 3, 12:47 AM · Restricted Project

Wed, Sep 2

teemperor added a comment to D85993: [lldb] Set the access property on member function decls.

Dwarf parser uses TypeSystemClang::AddMethodToCXXRecordType instead of this function to create methods (which is why there are no assertions like this when using dwarf). Maybe it would be better to change the pdb parser to use that function instead (as it allows the user to specify not only accessibility, but also other potentially useful properties of the created method -- static, virtual, etc.).

The NativePDB AST parser also uses AddMethodToCXXRecordType. It's in udtcompleter.cpp.

But the bug is triggered while the plugin is trying to synthesize the function declaration during a ResolveSymbolContext call. It looks like the DWARF implementation of ResolveSymbolContext relies on its AST parser, but the NativePDB one does not. I'm trying to figure out how to do that.

Also note that AddMethodToCXXRecordType just sets whatever access type it's asked to set. Before calling AddMethodToCXXRecordType, the DWARF parser has this gem:

// Neither GCC 4.2 nor clang++ currently set a valid
// accessibility in the DWARF for C++ methods...
// Default to public for now...
if (attrs.accessibility == eAccessNone)
  attrs.accessibility = eAccessPublic;

That bit of logic is what prevents the assertion from failing for DWARF. I'll can make the NativePDB AST parser do the same thing.

But that won't fix the bug, since the NativePDB AST parser isn't involved (at least, my breakpoints in the parser never hit during the course of the test). In the mean time, I'll try to figure out how to get the NativePDB plugin's ResolveSymbolContext implementation to use AddMethodToCXXRecord.

Wed, Sep 2, 11:50 PM
teemperor added a comment to D86290: Move all fields of '-cc1' option related classes into def file databases.

Just to also jump in on the thread: This broke the modules builds. I fixed that in https://reviews.llvm.org/rGe0e7eb2e2648aee83caf2ecfe2972ce2f653d306 so please recommit that patch or merge it into this revision before relanding. Thanks!

Wed, Sep 2, 10:45 PM · Restricted Project
teemperor committed rGe0e7eb2e2648: [clang] Add missing .def files to Clang's modulemap (authored by teemperor).
[clang] Add missing .def files to Clang's modulemap
Wed, Sep 2, 11:42 AM
teemperor added inline comments to D86953: [lldb] Refactor the tab completion test utilities and document found bugs.
Wed, Sep 2, 9:54 AM
teemperor accepted D86996: [lldb] Add -l/--language option to script command.

LGTM

Wed, Sep 2, 9:28 AM · Restricted Project, Restricted Project
teemperor updated the diff for D86953: [lldb] Refactor the tab completion test utilities and document found bugs.
  • Make the assert_completions_contains remove an element after it was found (to prevent finding the same element twice).
  • Removed special assert for negative return codes.
Wed, Sep 2, 9:23 AM
teemperor added a comment to D87036: [lldb] Make symbol list output from `image dump symtab` not depend on internal ordering of DenseMap.

This should also avoid changing the test all the time when someone touches one of the symbols (as in D68533 )

Wed, Sep 2, 8:48 AM · Restricted Project
teemperor requested review of D87036: [lldb] Make symbol list output from `image dump symtab` not depend on internal ordering of DenseMap.
Wed, Sep 2, 8:47 AM · Restricted Project
teemperor updated the summary of D86336: [debugserver] Fix that debugserver's stop reply packets always return signal code 0.
Wed, Sep 2, 1:38 AM · Restricted Project