teemperor (Raphael Isemann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 23 2016, 8:38 AM (73 w, 4 d)

Recent Activity

Thu, Aug 17

teemperor added a dependent revision for D36782: [Bash-autocompletion] Add support for static analyzer flags: D36820: [Bash-autocompletion] Add support for -std=.
Thu, Aug 17, 12:01 AM
teemperor added a dependency for D36820: [Bash-autocompletion] Add support for -std=: D36782: [Bash-autocompletion] Add support for static analyzer flags.
Thu, Aug 17, 12:01 AM

Wed, Aug 16

teemperor added inline comments to D36782: [Bash-autocompletion] Add support for static analyzer flags.
Wed, Aug 16, 2:48 AM
teemperor added a comment to D36782: [Bash-autocompletion] Add support for static analyzer flags.

That's a really nice approach to this problem, good job Yuka! See my inline comments for some minor remarks.

Wed, Aug 16, 12:24 AM

Tue, Aug 15

teemperor added a comment to D36664: [analyzer] Make StmtDataCollector customizable.

Very well done, I really like this patch! I added a few remarks mostly about the comments that need some small adjusting.

Tue, Aug 15, 2:03 AM

Thu, Aug 10

teemperor accepted D36567: [Bash-autocompletion] Add --autocomplete flag to 5.0 release notes.

LGTM, more publicity means that more shells will make use of it.

Thu, Aug 10, 12:54 PM

Thu, Aug 3

teemperor abandoned D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs..

I see, thanks for the information! If we don't need to support this in the shell-completion and we shouldn't report invalid arguments, then it seems this review is stuck here. I'll abandon as I don't see any other use case for this code.

Thu, Aug 3, 2:07 PM

Tue, Aug 1

teemperor accepted D36209: [Bash-autocompletion] Add comment to test so that it is easier to fix.

E.g. If you add a flag that lands in between the results it breaks. Add -Wmajor-new-feature and the test goes red. Same with the flag results or changing the help test for -std=.

Tue, Aug 1, 11:30 PM

Mon, Jul 31

teemperor added a comment to D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs..

I like the directions of this patch.
In general, I am in favor of explicitly registering the options from user defined checkers.
But changing a config option will now break the command line compatibility, so I wonder how do we want to handle this:

  • Have a list of no-op configs that we accept but warn that it has been replaced/removed?
  • Just do not care and break compatibility?
  • Something else?
Mon, Jul 31, 11:48 PM
teemperor updated subscribers of D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs..
Mon, Jul 31, 2:01 AM
teemperor updated the diff for D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs..
  • Remove some unneeded includes
Mon, Jul 31, 2:01 AM

Sun, Jul 30

teemperor added a comment to D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs..

I'm open to suggestions how we should handle user-provided checkers that maybe come with their own configs. Should we add that if we have a custom checker in the registry, that we disable this check to keep backwards compability? Or do we demand users to register their own configs in the registry?

Sun, Jul 30, 1:58 PM
teemperor created D36067: [analyzer] Create infrastructure for organizing and declaring analyzer configs..
Sun, Jul 30, 1:49 PM
teemperor updated the diff for D34182: [analyzer] Performance optimizations for the CloneChecker.

(Fixed diff)

Sun, Jul 30, 12:34 PM
teemperor updated the diff for D34182: [analyzer] Performance optimizations for the CloneChecker.
  • Updated according to Artem's comments.
Sun, Jul 30, 12:30 PM

Tue, Jul 25

teemperor added a comment to D34260: [StaticAnalyzer] Completely unrolling specific loops with known bound option .

If you can't reproduce, you should try running a debug build through valgrind. It points out this issue:

Tue, Jul 25, 11:17 PM

Sat, Jul 22

teemperor accepted D35759: [Bash-autocompletion] Show HelpText with possible flags.

LGTM.

Sat, Jul 22, 11:50 AM
teemperor accepted D35762: [Bash-autocompletion] Fixed typo and add '-' after -Wno.

Thanks for the quick fix, LGTM!

Sat, Jul 22, 5:23 AM

Jul 18 2017

teemperor committed rL308340: Add GCC's noexcept-type alias for c++1z-compat-mangling.
Add GCC's noexcept-type alias for c++1z-compat-mangling
Jul 18 2017, 11:53 AM
teemperor closed D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling.
Jul 18 2017, 11:53 AM
teemperor committed rL308333: Don't set TUScope to null when generating a module in incremental processing….
Don't set TUScope to null when generating a module in incremental processing…
Jul 18 2017, 11:25 AM
teemperor closed D35536: Don't set TUScope to null when generating a module in incremental processing mode..
Jul 18 2017, 11:25 AM
teemperor updated the summary of D35536: Don't set TUScope to null when generating a module in incremental processing mode..
Jul 18 2017, 5:04 AM
teemperor updated the diff for D35536: Don't set TUScope to null when generating a module in incremental processing mode..
Jul 18 2017, 4:55 AM
teemperor created D35536: Don't set TUScope to null when generating a module in incremental processing mode..
Jul 18 2017, 3:05 AM
teemperor added a comment to D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling.

ping. Any objections to adding this GCC alias?

Jul 18 2017, 12:58 AM

Jul 15 2017

teemperor accepted D35447: [Bash-autocompletion] Add support for -W<warning> and -Wno<warning>.

I have a last request in my inline comment regarding the documentation, otherwise this is good to go. Nice work!

Jul 15 2017, 12:13 PM
teemperor added a comment to D35447: [Bash-autocompletion] Add support for -W<warning> and -Wno<warning>.

@yamaguchi yes, the reason why we have to treat the -W... flags specially should be documented (as they're not in the OptTable as you said). E.g. something like // We have to query the -W flags manually as they're not in the OptTable. and then maybe a TODO: Find a good way to add them to OptTable instead and them remove this code..

Jul 15 2017, 2:25 AM
teemperor requested changes to D35447: [Bash-autocompletion] Add support for -W<warning> and -Wno<warning>.

It seems the code doesn't compile in clang because on your platform std::vector is implicitly included by some header, on clang+Arch however it isn`t (see the error at the end of https://teemperor.de/ccir/D35447).

Jul 15 2017, 12:34 AM

Jul 14 2017

teemperor created D35407: Add unreachable when we run out of scopes during lookup.
Jul 14 2017, 3:13 AM

Jul 9 2017

teemperor committed rL307509: [analyzer] Faster hashing of subsequences in CompoundStmts..
[analyzer] Faster hashing of subsequences in CompoundStmts.
Jul 9 2017, 2:15 PM
teemperor closed D34364: [analyzer] Faster hashing of subsequences in CompoundStmts..
Jul 9 2017, 1:41 PM
teemperor added a comment to D34329: [clang-diff] Initial implementation..

@johannes D34880 has landed, so feel free to propose patches to the StmtDataCollector API that would help you (e.g. to support identifiers). You can see examples how to use it in the CloneDetection.cpp (once for storing data in a FoldingetSetNodeID and once for directly hashing the data with MD5).

Jul 9 2017, 9:21 AM
teemperor committed rL307501: [analyzer] Make StmtDataCollector part of the CloneDetection API.
[analyzer] Make StmtDataCollector part of the CloneDetection API
Jul 9 2017, 8:57 AM
teemperor closed D34880: [analyzer] Make StmtDataCollector part of the CloneDetection API.
Jul 9 2017, 8:56 AM

Jul 2 2017

teemperor added a comment to D34880: [analyzer] Make StmtDataCollector part of the CloneDetection API.

Yeah, we should move it, but it should land somewhere in a header in /AST/ so that for example the StmtProfiler could make use of this. I'm open for suggestions here :)

Jul 2 2017, 4:55 AM

Jul 1 2017

teemperor accepted D34930: [Bash-autocompletion] Show flags which has HelpText or GroupID.

For the record, one can get a (maybe incomplete) list of options that are without completion via: curl "https://teemperor.de/pub/clang_flags.txt" | grep -v HelpText | grep -v Group.
The only options I can see that I would miss if they would disappear are the ones who are clearly meant to be public but just lack the HelpText (like our beloved sysroot, which is a public GCC flag). So I think this patch can go forward and someone will have to add a HelpText for those flags in the future.

Jul 1 2017, 11:40 PM
teemperor accepted D34924: [Bash-autocompletion] Add support for older bash version..

LGTM, everything still works in the latest bash on Linux.

Jul 1 2017, 10:16 AM
teemperor added a comment to D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified.

I'm not sure what you refer to by I just saw we actually have the completion code in the Driver. We are already auto completing both cc1 options and driver options, right?

Jul 1 2017, 12:39 AM
teemperor accepted D34595: Changed Opts.EABIVersion type string to llvm::EABI enum class .

LGTM.

Jul 1 2017, 12:27 AM

Jun 30 2017

teemperor updated subscribers of D34361: [analyzer] MinComplexityConstraint now early exits and only does one macro stack lookup.
Jun 30 2017, 8:21 AM
teemperor updated subscribers of D34364: [analyzer] Faster hashing of subsequences in CompoundStmts..
Jun 30 2017, 8:21 AM
teemperor updated subscribers of D34880: [analyzer] Make StmtDataCollector part of the CloneDetection API.
Jun 30 2017, 8:20 AM
teemperor added a comment to D34329: [clang-diff] Initial implementation..

Yes, it does indeed skip identifiers and literals for this reason :). It was planned to make this template more configurable for use cases like yours, so I'm totally fine with adding configuration parameters. I just opened D34880 where I make this template public as a first step.

Jun 30 2017, 7:01 AM
teemperor created D34880: [analyzer] Make StmtDataCollector part of the CloneDetection API.
Jun 30 2017, 7:00 AM
teemperor accepted rL306555: [Bash-autocompletion] Check clang version in Bash.
Jun 30 2017, 4:59 AM
teemperor added a comment to D34329: [clang-diff] Initial implementation..

I didn't have time to have a close look at this patch, but it seems you're interested in the specific TU-independent data of a Stmt to compare them. So if you are interested in such data and don't want to write your own function to collect it for each Stmt subclass, there is the StmtDataCollector in the CloneDetection.cpp here and a example how to use it is here.

Jun 30 2017, 4:33 AM

Jun 29 2017

teemperor added a comment to D34770: [Bash-autocompletion] Auto complete cc1 options if -cc1 is specified.

Two thought from me on this:

Jun 29 2017, 6:48 AM

Jun 25 2017

teemperor accepted D34607: [Bash-autocompletion] Check clang version in Bash.

Works as intended, good job!

Jun 25 2017, 10:50 PM

Jun 24 2017

teemperor accepted D34594: [GSoC] Delete space after flags which has '=' prefix.
Jun 24 2017, 9:17 AM

Jun 22 2017

teemperor removed 1 auditor(s) for rL306016: Updating branches/google/stable to r305862: teemperor.
Jun 22 2017, 10:20 AM
teemperor removed 1 auditor(s) for rL306015: Creating tags/google/stable/2017-06-22 from r305862: teemperor.
Jun 22 2017, 10:19 AM

Jun 21 2017

teemperor added a comment to D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling.

@ahatanak I think we can leave the more expressive clang name for this warning and just add the bit cryptic GCC name for compability. But I don't have a strong opinion on this.

Jun 21 2017, 10:56 AM
teemperor created D34439: Add GCC's noexcept-type alias for c++1z-compat-mangling.
Jun 21 2017, 3:31 AM

Jun 20 2017

teemperor committed rL305878: Changed wording in comment.
Changed wording in comment
Jun 20 2017, 10:42 PM

Jun 19 2017

teemperor accepted D34353: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler to filter auto generated files.

LGTM, thanks!

Jun 19 2017, 2:16 PM
teemperor created D34364: [analyzer] Faster hashing of subsequences in CompoundStmts..
Jun 19 2017, 2:03 PM
teemperor created D34361: [analyzer] MinComplexityConstraint now early exits and only does one macro stack lookup.
Jun 19 2017, 12:48 PM
teemperor added inline comments to D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler.
Jun 19 2017, 3:14 AM
teemperor accepted D33383: [GSoC] Flag value completion for clang.

LGTM.

Jun 19 2017, 3:06 AM

Jun 18 2017

teemperor accepted D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler.

LGTM, thanks for the patch!

Jun 18 2017, 2:21 PM

Jun 16 2017

teemperor accepted D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler.

Please check the last inline comment and then feel free to commit it with the suggested fix. And I wanted to wait for review on the other performance patches, so you can push this now.

Jun 16 2017, 3:18 AM
teemperor added a comment to D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler.

See my inline comments about technical changes, but otherwise this looks ready to land. Please update and I'll give green light ASAP. Thanks!

Jun 16 2017, 1:27 AM

Jun 15 2017

teemperor updated the diff for D34182: [analyzer] Performance optimizations for the CloneChecker.
  • made saveHash static.
Jun 15 2017, 11:31 AM
teemperor requested changes to D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler.

Sorry for the delay, we got stuck because hard coding a certain file pattern into the clang source code doesn't seem to be a optimal solution (e.g. every user that has a different set of generated files needs to patch clang to hide his specific reports). I would prefer if we could get this into a variable that the user can change dynamically.

Jun 15 2017, 2:53 AM

Jun 14 2017

teemperor added a comment to D32646: Fix a bug that -Wmissing-braces fires on system headers.

Everything beside this last test case seems to be handled. And from what I remember there was a longer discussion how to properly handle this case and so this review got stuck.

Jun 14 2017, 2:37 AM
teemperor accepted D32341: Fix a bug that warnings generated with -M or -MM flags.

LGTM, good job! (Sorry for the delay, I think I got interrupted here by the GSoC start...)

Jun 14 2017, 2:11 AM
teemperor added inline comments to D34182: [analyzer] Performance optimizations for the CloneChecker.
Jun 14 2017, 1:36 AM

Jun 13 2017

teemperor created D34182: [analyzer] Performance optimizations for the CloneChecker.
Jun 13 2017, 3:50 PM
teemperor updated subscribers of D34178: [analyzer] Increase minimum complexity filter of the CloneChecker..
Jun 13 2017, 3:28 PM
teemperor created D34178: [analyzer] Increase minimum complexity filter of the CloneChecker..
Jun 13 2017, 3:23 PM

Jun 12 2017

teemperor added reviewers for D33383: [GSoC] Flag value completion for clang: ruiu, rsmith.
Jun 12 2017, 2:24 AM

Jun 8 2017

teemperor updated the diff for D33366: Fix that global delete operator get's assigned to a submodule..
  • Just unconditionally calling setHidden now.
Jun 8 2017, 3:33 AM
teemperor added a reviewer for D34022: Repair 2010-05-31-palignr.c test: echristo.
Jun 8 2017, 1:08 AM
teemperor created D34022: Repair 2010-05-31-palignr.c test.
Jun 8 2017, 1:08 AM

May 22 2017

teemperor added a comment to D33383: [GSoC] Flag value completion for clang.

Good progress and good catch with also checking lld :)

May 22 2017, 5:25 AM
teemperor updated the diff for D33366: Fix that global delete operator get's assigned to a submodule..
  • Now unhiding/unowning the created functions like Richard suggested.
  • Extended the test case to stress test the lookup with the new visibility settings.
May 22 2017, 2:54 AM

May 19 2017

teemperor added a comment to D33366: Fix that global delete operator get's assigned to a submodule..

I'm not 100% sure if that's the right fix, but I didn't see a obvious way to declare the new/delete outside the current submodule. Maybe Richard knows a better way :)

May 19 2017, 1:36 PM
teemperor created D33366: Fix that global delete operator get's assigned to a submodule..
May 19 2017, 1:35 PM

May 17 2017

teemperor added a comment to D33237: [GSoC] Shell autocompletion for clang.

Because the small follow up patch is relevant for the review of this one. If people disagree with the plan there to extend Options.td or OptTable for this feature (and due to the limitations of Options.td in regards to dynamic arguments, this is already controversial), then we have to completely revisit this code which assumes we can do everything in OptTable. I fully agree with incremental development in tree, but for those first two patches I don't see "consensus on the end goal to define the first increment" yet (to quote the LLVM dev policy on this). Sorry, I should have mentioned this fact in the previous mail, but typing on the smartphone is cumbersome.

May 17 2017, 11:49 AM
teemperor added a comment to D33237: [GSoC] Shell autocompletion for clang.

@ruiu We wanted to push this patch with the follow-up one about the argument completion, so no need to do this now :).

May 17 2017, 10:48 AM

May 9 2017

teemperor planned changes to D33004: getIdentifierInfo now updates the returned information by default.

Work in progress patch. We probably also need to update a few other places where we call this.

May 9 2017, 8:23 AM
teemperor created D33004: getIdentifierInfo now updates the returned information by default.
May 9 2017, 8:22 AM

Apr 25 2017

teemperor created D32499: Further delay calling DeclMustBeEmitted until it's safe..
Apr 25 2017, 11:10 AM
teemperor updated the diff for D32486: Cleanup pragma handlers after DoPrintPreprocessedInput.
  • Now using unique_ptr instead of raw pointers.
Apr 25 2017, 7:48 AM
teemperor created D32486: Cleanup pragma handlers after DoPrintPreprocessedInput.
Apr 25 2017, 7:05 AM

Apr 23 2017

teemperor requested changes to D32341: Fix a bug that warnings generated with -M or -MM flags.

This also disables warnings for -MD and -MMD which shouldn't happen as we're actually compiling code here and are probably compiling a project. E.g. for people that use this mode to create dependency files while initially building (to figure out when to rebuild each object), this will effectively force -w to the whole build process which is not good.

Apr 23 2017, 2:47 PM

Apr 21 2017

teemperor added a comment to D32342: Changed llvm/CMakeLists.txt and added relative path to llvm doxygen.

I think most of the changes are just necessary because we replaced LLVM_MAIN_SRC_DIR with CMAKE_SOURCE_DIR (all the added ../ and removed docs). On the other hand this is now in sync with the way the the clang doxygen.cfg is structured and it fixes the include paths, so I think this looks reasonable.

Apr 21 2017, 4:52 AM

Apr 19 2017

teemperor closed D31591: Fix a bug which access nullptr and cause segmentation fault.
Apr 19 2017, 2:59 AM
teemperor accepted D31591: Fix a bug which access nullptr and cause segmentation fault.
Apr 19 2017, 2:59 AM

Apr 17 2017

teemperor added inline comments to D32113: Add path from clang to doxygen document include header.
Apr 17 2017, 6:33 AM
teemperor added a comment to D32113: Add path from clang to doxygen document include header.

Woops, my bad, seems like I tested just before you fixed it.

Apr 17 2017, 3:17 AM

Apr 16 2017

teemperor added a comment to D32113: Add path from clang to doxygen document include header.

@yamaguchi Did you test the latest revision of this patch and get the desired output paths? I just tested it and it seems on my system doxygen can't handle the @abs_srcdir@/../.

Apr 16 2017, 11:51 AM
teemperor updated subscribers of D32113: Add path from clang to doxygen document include header.
Apr 16 2017, 11:47 AM

Apr 11 2017

teemperor updated the diff for D30793: [modules] Delay calling DeclMustBeEmitted until it's safe.
  • Readded the missing tests to get the final diff.
Apr 11 2017, 11:09 AM

Apr 10 2017

teemperor updated the diff for D30793: [modules] Delay calling DeclMustBeEmitted until it's safe.
  • Fixed compilation error in the cleaned up version (removed two lines too much...)
Apr 10 2017, 2:14 AM

Apr 6 2017

teemperor added a comment to D23418: [analyzer] Added a reusable constraint system to the CloneDetector.

I think for range loops work differently:

Apr 6 2017, 4:51 AM
teemperor added inline comments to D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler.
Apr 6 2017, 3:23 AM
teemperor added inline comments to D23418: [analyzer] Added a reusable constraint system to the CloneDetector.
Apr 6 2017, 2:47 AM
teemperor updated the diff for D23418: [analyzer] Added a reusable constraint system to the CloneDetector.
  • Renamed variable from 'S' to 'Child' to make the buildbots happy (and because it's more expressive)
  • Fixed the name of the unit test.
Apr 6 2017, 2:44 AM