Page MenuHomePhabricator

teemperor (Raphael Isemann)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 23 2016, 8:38 AM (152 w, 9 h)

Recent Activity

Sun, Feb 17

teemperor added inline comments to D58125: Add ability to import std module into expression parser to improve C++ debugging.
Sun, Feb 17, 4:32 AM · Restricted Project, Restricted Project

Sat, Feb 16

teemperor committed rG913f07af6e46: Fix TestDataFormatterLibcxxListLoop.py test (authored by teemperor).
Fix TestDataFormatterLibcxxListLoop.py test
Sat, Feb 16, 4:14 AM
teemperor committed rLLDB354202: Fix TestDataFormatterLibcxxListLoop.py test.
Fix TestDataFormatterLibcxxListLoop.py test
Sat, Feb 16, 4:13 AM
teemperor committed rL354202: Fix TestDataFormatterLibcxxListLoop.py test.
Fix TestDataFormatterLibcxxListLoop.py test
Sat, Feb 16, 4:13 AM
teemperor closed D58273: Fix TestDataFormatterLibcxxListLoop.py test.
Sat, Feb 16, 4:13 AM · Restricted Project, Restricted Project

Fri, Feb 15

teemperor added a comment to D58125: Add ability to import std module into expression parser to improve C++ debugging.

@labath Thanks for the hint with the sysroot, but I'm not really sure what's the best way to test this. Making a whole fake sysroot that can be used to compile a std module seems overkill, and not sure if symlinking or so is a good approach either. I'm open to suggestions.

Fri, Feb 15, 8:49 AM · Restricted Project, Restricted Project
teemperor updated the diff for D58125: Add ability to import std module into expression parser to improve C++ debugging.
  • Rebase on top of Adrian's patch (Thanks!)
  • Addressed the feedback from Shafik/Pavel.
Fri, Feb 15, 8:44 AM · Restricted Project, Restricted Project
teemperor updated the diff for D58273: Fix TestDataFormatterLibcxxListLoop.py test.
  • Added #ifdef for 3.8 release.
Fri, Feb 15, 4:21 AM · Restricted Project, Restricted Project
teemperor closed D57956: [www] Add ASTImporter fuzzer project..

landed in llvm-svn: 354043

Fri, Feb 15, 4:21 AM
teemperor added a comment to D58273: Fix TestDataFormatterLibcxxListLoop.py test.

We could also check the libc++ version via _LIBCPP_VERSION and just keep the old code around behind an ifdef?

Fri, Feb 15, 1:53 AM · Restricted Project, Restricted Project
teemperor created D58273: Fix TestDataFormatterLibcxxListLoop.py test.
Fri, Feb 15, 1:20 AM · Restricted Project, Restricted Project

Thu, Feb 14

teemperor committed rL354043: Add open project for ASTImporter fuzzer.
Add open project for ASTImporter fuzzer
Thu, Feb 14, 10:34 AM
teemperor committed rGa2a6acf3f0cf: Don't source local .lldbinit in the test suite (authored by teemperor).
Don't source local .lldbinit in the test suite
Thu, Feb 14, 9:39 AM
teemperor committed rL354038: Don't source local .lldbinit in the test suite.
Don't source local .lldbinit in the test suite
Thu, Feb 14, 9:39 AM
teemperor committed rLLDB354038: Don't source local .lldbinit in the test suite.
Don't source local .lldbinit in the test suite
Thu, Feb 14, 9:38 AM
teemperor closed D58235: Don't source local .lldbinit in the test suite.
Thu, Feb 14, 9:38 AM · Restricted Project
teemperor updated the diff for D58235: Don't source local .lldbinit in the test suite.

Ah yes, that also explains why the test suit failed. Fixed and the test now passes, thanks!

Thu, Feb 14, 8:33 AM · Restricted Project
teemperor created D58235: Don't source local .lldbinit in the test suite.
Thu, Feb 14, 6:51 AM · Restricted Project
teemperor accepted D58222: [ClangExpressionParser] Reuse the FileManager from the compiler instance..

LGTM.

Thu, Feb 14, 1:31 AM · Restricted Project

Tue, Feb 12

teemperor updated subscribers of D57956: [www] Add ASTImporter fuzzer project..
Tue, Feb 12, 1:54 PM
teemperor accepted D58090: Deserialize Clang module search path from DWARF.

+1. That's a cleaner version of what I had to do in D58125, so feel free to commit when done. The code is similar enough that rebasing my patch on top shouldn't take too much time.

Tue, Feb 12, 8:28 AM · Restricted Project
teemperor updated the diff for D58125: Add ability to import std module into expression parser to improve C++ debugging.
  • Cleaned up setup method.
Tue, Feb 12, 8:15 AM · Restricted Project, Restricted Project
teemperor planned changes to D58125: Add ability to import std module into expression parser to improve C++ debugging.

All the changes regarding extracting module include paths are probably superseded by Adrian's patch (which does the same thing nicer). So all the code related to GetModuleIncludes will be removed from this patch most likely.

Tue, Feb 12, 8:06 AM · Restricted Project, Restricted Project
teemperor created D58125: Add ability to import std module into expression parser to improve C++ debugging.
Tue, Feb 12, 8:06 AM · Restricted Project, Restricted Project

Mon, Feb 11

teemperor committed rGf75a9dc1a2bf: Fixed function name in log statement (authored by teemperor).
Fixed function name in log statement
Mon, Feb 11, 1:47 PM
teemperor committed rL353753: Fixed function name in log statement.
Fixed function name in log statement
Mon, Feb 11, 1:46 PM
teemperor committed rLLDB353753: Fixed function name in log statement.
Fixed function name in log statement
Mon, Feb 11, 1:46 PM

Sun, Feb 10

teemperor committed rGd1307ec4ccb1: Fix x86 return pattern detection (authored by teemperor).
Fix x86 return pattern detection
Sun, Feb 10, 7:42 AM
teemperor committed rL353643: Fix x86 return pattern detection.
Fix x86 return pattern detection
Sun, Feb 10, 7:41 AM
teemperor committed rLLDB353643: Fix x86 return pattern detection.
Fix x86 return pattern detection
Sun, Feb 10, 7:41 AM
teemperor closed D57928: Fix x86 return pattern detection.
Sun, Feb 10, 7:41 AM · Restricted Project
teemperor committed rLLDB353642: lldb: Fix compilation on OpenBSD.
lldb: Fix compilation on OpenBSD
Sun, Feb 10, 7:25 AM
teemperor committed rGada705a5d2ee: lldb: Fix compilation on OpenBSD (authored by teemperor).
lldb: Fix compilation on OpenBSD
Sun, Feb 10, 7:24 AM
teemperor committed rL353642: lldb: Fix compilation on OpenBSD.
lldb: Fix compilation on OpenBSD
Sun, Feb 10, 7:23 AM
teemperor closed D57907: lldb: Fix compilation on OpenBSD.
Sun, Feb 10, 7:23 AM · Restricted Project, Restricted Project
teemperor added a comment to D57956: [www] Add ASTImporter fuzzer project..

@JDevlieghere I think this is the LLVM homepage (not LLDB), so I believe there is no RST file to edit?

Sun, Feb 10, 5:23 AM

Fri, Feb 8

teemperor updated subscribers of D57956: [www] Add ASTImporter fuzzer project..

Just trying to get some early feedback before I subscribe the mailing list. Also let me know if someone here also wants to mentor for this project and I'll add you.

Fri, Feb 8, 8:48 AM
teemperor created D57956: [www] Add ASTImporter fuzzer project..
Fri, Feb 8, 8:45 AM
teemperor committed rL353519: Remove completed project.
Remove completed project
Fri, Feb 8, 6:26 AM

Thu, Feb 7

teemperor created D57880: Add assert for 'bad' code path in GetUniqueNamespaceDeclaration.
Thu, Feb 7, 1:57 AM · Restricted Project
teemperor committed rLLDB353381: Fix documentation formatting for ShellExpandArguments.
Fix documentation formatting for ShellExpandArguments
Thu, Feb 7, 1:48 AM
teemperor committed rG5911a10946b3: Fix documentation formatting for ShellExpandArguments (authored by teemperor).
Fix documentation formatting for ShellExpandArguments
Thu, Feb 7, 1:48 AM
teemperor committed rL353381: Fix documentation formatting for ShellExpandArguments.
Fix documentation formatting for ShellExpandArguments
Thu, Feb 7, 1:47 AM

Wed, Feb 6

teemperor resigned from D57850: [analyzer] Emit an error rather than assert on invalid checker option input.

LGTM for the CloneChecker changes.

Wed, Feb 6, 2:51 PM · Restricted Project

Mon, Feb 4

teemperor abandoned D57678: Read include directories from SymbolFile.
Mon, Feb 4, 1:23 PM
teemperor created D57678: Read include directories from SymbolFile.
Mon, Feb 4, 3:37 AM

Tue, Jan 29

teemperor accepted D57363: Fix handling of CreateTemplateParameterList when there is an empty pack.

LGTM, thanks for the patch!

Tue, Jan 29, 2:35 PM
teemperor added inline comments to D57363: Fix handling of CreateTemplateParameterList when there is an empty pack.
Tue, Jan 29, 10:01 AM

Mon, Jan 28

teemperor accepted D56936: Fix handling of overriden methods during ASTImport.

LGTM, thanks!

Mon, Jan 28, 11:53 AM

Fri, Jan 25

teemperor committed rLLDB352249: Simplify LangOpts initalization in ClangExpressionParser [NFC].
Simplify LangOpts initalization in ClangExpressionParser [NFC]
Fri, Jan 25, 2:42 PM
teemperor committed rL352249: Simplify LangOpts initalization in ClangExpressionParser [NFC].
Simplify LangOpts initalization in ClangExpressionParser [NFC]
Fri, Jan 25, 2:42 PM
teemperor closed D57222: Simplify LangOpts initalization in ClangExpressionParser [NFC].
Fri, Jan 25, 2:41 PM
teemperor created D57222: Simplify LangOpts initalization in ClangExpressionParser [NFC].
Fri, Jan 25, 2:47 AM
teemperor committed rLLDB352180: Fix typo in ClangModulesDeclVendor [NFC].
Fix typo in ClangModulesDeclVendor [NFC]
Fri, Jan 25, 1:29 AM
teemperor committed rL352180: Fix typo in ClangModulesDeclVendor [NFC].
Fix typo in ClangModulesDeclVendor [NFC]
Fri, Jan 25, 1:29 AM
teemperor committed rLLDB352175: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication.
Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication
Fri, Jan 25, 12:22 AM
teemperor committed rL352175: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication.
Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication
Fri, Jan 25, 12:22 AM
teemperor closed D57011: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication.
Fri, Jan 25, 12:22 AM

Thu, Jan 24

teemperor updated the diff for D57011: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication.
  • Added missing include.
Thu, Jan 24, 1:29 AM

Tue, Jan 22

teemperor abandoned D43871: [modules] No longer include stdlib.h from mm_malloc.h..

So, the idea of going back to the headers and see if we can potentially remove mm_malloc from the modulemap didn't work out (mostly because a lot of headers include it indirectly).

Tue, Jan 22, 1:38 PM
teemperor committed rL351849: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl.
[ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl
Tue, Jan 22, 10:00 AM
teemperor committed rC351849: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl.
[ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl
Tue, Jan 22, 10:00 AM
teemperor closed D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl.
Tue, Jan 22, 9:59 AM

Jan 21 2019

teemperor updated the diff for D57011: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication.
  • Moved define to Xcode's Config.h (Thanks Pavel!)
Jan 21 2019, 8:16 AM
teemperor added inline comments to D57011: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication.
Jan 21 2019, 6:49 AM
teemperor added a comment to D57011: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication.

I currently don't have access to a macOS machine and this only affects macOS, so I would appreciate if someone could check if this still compiles/works as intended. Otherwise I can also just commit it and watch the macOS bots.

Jan 21 2019, 4:13 AM
teemperor created D57011: Refactor HAVE_LIBCOMPRESSION and related code in GDBRemoteCommunication.
Jan 21 2019, 4:11 AM
teemperor resigned from D55424: [analyzer] Supply all checkers with a shouldRegister function.
Jan 21 2019, 3:02 AM
teemperor committed rL351739: [ASTImporter] Add test for importing anonymous namespaces..
[ASTImporter] Add test for importing anonymous namespaces.
Jan 21 2019, 2:17 AM
teemperor committed rC351739: [ASTImporter] Add test for importing anonymous namespaces..
[ASTImporter] Add test for importing anonymous namespaces.
Jan 21 2019, 2:16 AM
teemperor closed D51178: [ASTImporter] Add test for importing anonymous namespaces..
Jan 21 2019, 2:16 AM
teemperor updated the diff for D51178: [ASTImporter] Add test for importing anonymous namespaces..
  • Added a comment that the using directives are created by Sema.
Jan 21 2019, 2:09 AM

Jan 20 2019

teemperor updated the diff for D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl.
  • Moved code into the VisitFunctionDecl function.
Jan 20 2019, 3:00 PM

Jan 15 2019

teemperor added a comment to D56688: Make CompilerType::getBitSize() / getByteSize() return an optional result. (NFC).

+1. Especially since our assumption that everything related to C++ is of non-zero size is also not entirely correct. Empty structs for example are actually size 0 for Clang until we reach code gen where we set their size to 1. That's why we have this bug where we can't call functions that return an empty struct.

Jan 15 2019, 5:19 AM

Jan 13 2019

teemperor added a comment to D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl.

Didn't really upstream any non-trivial ASTImporter patches yet, so please point out any style errors.

Jan 13 2019, 2:08 PM
teemperor created D56651: [ASTImporter] Fix importing OperatorDelete from CXXConstructorDecl.
Jan 13 2019, 2:07 PM

Jan 9 2019

teemperor added inline comments to D55142: Minidump debugging using the native PDB reader.
Jan 9 2019, 2:23 AM · Restricted Project

Jan 8 2019

teemperor committed rLLDB350675: Fix unused private field warning..
Fix unused private field warning.
Jan 8 2019, 2:58 PM
teemperor committed rL350675: Fix unused private field warning..
Fix unused private field warning.
Jan 8 2019, 2:58 PM
teemperor closed D56458: Fix unused private field warning..
Jan 8 2019, 2:58 PM
teemperor created D56458: Fix unused private field warning..
Jan 8 2019, 2:54 PM

Dec 11 2018

teemperor added a comment to D43871: [modules] No longer include stdlib.h from mm_malloc.h..

@joerg Yeah, we saw the commit explaining why the original fwd declaration patch was reverted. However, from what I can see, we only have three ways to fix the cyclic dependency between glibc and Clang's internal module:

Dec 11 2018, 10:45 AM

Dec 10 2018

teemperor committed rL348755: Misc typos fixes in ./lib folder.
Misc typos fixes in ./lib folder
Dec 10 2018, 4:41 AM
teemperor committed rC348755: Misc typos fixes in ./lib folder.
Misc typos fixes in ./lib folder
Dec 10 2018, 4:41 AM
teemperor closed D55475: Misc typos fixes in ./lib folder.
Dec 10 2018, 4:41 AM

Dec 9 2018

teemperor accepted D55475: Misc typos fixes in ./lib folder.

This looks all good to me and from what see this was requested in a previous review (D44188). Do you need someone to commit this or did you receive commit access?

Dec 9 2018, 6:34 AM

Dec 8 2018

teemperor resigned from D55475: Misc typos fixes in ./lib folder.
Dec 8 2018, 6:58 AM

Dec 6 2018

teemperor accepted D55361: Move Broadcaster+Listener+Event combo from Core into Utility.
Dec 6 2018, 10:01 AM
teemperor added a comment to D55361: Move Broadcaster+Listener+Event combo from Core into Utility.

LGTM modulo the unrelated clang-format changes. Feel free to commit them separately (even though the m_event_names fix looks a bit strange).

Dec 6 2018, 10:00 AM

Nov 29 2018

teemperor committed rC347863: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger.
Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger
Nov 29 2018, 5:54 AM
teemperor committed rL347863: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger.
Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger
Nov 29 2018, 5:53 AM
teemperor closed D54898: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger.
Nov 29 2018, 5:53 AM · Restricted Project

Nov 26 2018

teemperor created D54898: Set MustBuildLookupTable on PrimaryContext in ExternalASTMerger.
Nov 26 2018, 7:28 AM · Restricted Project

Nov 11 2018

teemperor added a comment to D54385: Remove comments after header includes..

Do we also want to get rid of the // C Includes comments that are in some files? LLVM isn't using them either and just removing lines doesn't make git blame more complicated.

Nov 11 2018, 12:05 AM · Restricted Project

Nov 10 2018

teemperor accepted D54335: [CMake] Fix: add_host_subdirectory source/Host/macosx.

LGTM, sorry for that!

Nov 10 2018, 1:36 AM

Nov 4 2018

teemperor added a comment to D54072: Add a command to dump a module's clang ast..

Yeah it uses the color settings of the diagnostic engine which are probably set to false in LLDB. I think activating colors there should fix the issue.

Nov 4 2018, 6:35 AM
teemperor added a comment to D54072: Add a command to dump a module's clang ast..

I think Pavel's point is to call the dump overload which allows specifying our own custom raw_ostream: https://clang.llvm.org/doxygen/classclang_1_1Decl.html#a278b3b87b6f9d3b20ed566a8684341a6 And our raw_ostream is configured by LLDB to correctly choose if we want color or not.

Nov 4 2018, 6:25 AM

Nov 2 2018

teemperor added a comment to D54059: Remove Java debugger plugin.

Minor detail: The revision title only mentions Java, but this revision removes both Go and Java.

Nov 2 2018, 5:09 PM · Restricted Project
teemperor added a comment to D54003: Refactor ClangASTContext::AddEnumerationValueToEnumerationType() to remove redundant parameter which can be calculated from other parameter.

This looks nice, just added some minor comments below. Otherwise LGTM after Davide's point is addressed.

Nov 2 2018, 2:35 PM

Oct 24 2018

teemperor accepted D52651: Add functionality to export settings.

Woops, I wanted to accept in my previous comment.

Oct 24 2018, 4:24 PM · Restricted Project