This is an archive of the discontinued LLVM Phabricator instance.

[release][docs] Update contributions to LLVM 11 for SVE.
AbandonedPublic

Authored by fpetrogalli on Aug 14 2020, 9:36 AM.

Details

Diff Detail

Event Timeline

fpetrogalli created this revision.Aug 14 2020, 9:36 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 14 2020, 9:36 AM
fpetrogalli requested review of this revision.Aug 14 2020, 9:36 AM

Added context to the diff.

tschuett added inline comments.Aug 14 2020, 10:06 AM
llvm/docs/ReleaseNotes.rst
162

Nit: indentation?

Fix indentation of the code exmaple.

fpetrogalli marked an inline comment as done.Aug 14 2020, 12:28 PM
david-arm added inline comments.Aug 17 2020, 8:40 AM
llvm/docs/ReleaseNotes.rst
70

I think this should probably be "associated with a ..."

84

Perhaps this should be "now support two distinct ... and ... vector types, ..." ?

117

"Clang adds support for the ..." perhaps?

fpetrogalli marked 3 inline comments as done.

Thank you for the review @david-arm.

I have addressed all your comments, and I also have removed the
additional unit tests that was checking that the example in the docs
was working. I have decided to do so because I don't want to deal with
the intricacies of making sure that the use of #include <arm_sve.h>
when running the test on x86 hardware is correctly handled (for
reference, see failure at
https://reviews.llvm.org/harbormaster/unit/view/160088/). All the code
generation needed by the example in the release note is unit-tested in
the SVE ACLE tests, so the unit test for the example is not really
necessary.

paulwalker-arm accepted this revision.Aug 18 2020, 8:24 AM
This revision is now accepted and ready to land.Aug 18 2020, 8:24 AM
david-arm resigned from this revision.Feb 9 2021, 6:48 AM
paulwalker-arm resigned from this revision.Feb 25 2021, 9:27 AM
This revision now requires review to proceed.Feb 25 2021, 9:27 AM
fpetrogalli abandoned this revision.Jan 17 2023, 12:41 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2023, 12:41 AM