This is an archive of the discontinued LLVM Phabricator instance.

[flang][openmp] Required clauses are allowed
ClosedPublic

Authored by clementval on Jul 22 2020, 12:15 PM.

Details

Summary

This patch fix a problem where clause needed to be in the allowed set even
they were in the required set. A required clause is allowed obvisouly. This allow
to remove the duplicate in OMP.td

Diff Detail

Event Timeline

clementval created this revision.Jul 22 2020, 12:15 PM
llvm/include/llvm/Frontend/OpenMP/OMP.td
425

Is requiredClause missing here?

clementval added inline comments.Jul 22 2020, 1:19 PM
llvm/include/llvm/Frontend/OpenMP/OMP.td
425

Well it is not mandatory but looks like that map is required for target enter data so it should be moved from allowedClauses to requiredClauses. I will update the patch to include this change as well.

Update clauses for target enter data as per review comment

This revision is now accepted and ready to land.Jul 22 2020, 1:27 PM
clementval marked 2 inline comments as done.Jul 22 2020, 1:33 PM
This revision was automatically updated to reflect the committed changes.