Page MenuHomePhabricator
People ichoyjx

ichoyjx (Brian Yang)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 19 2020, 12:15 PM (161 w, 4 d)

Recent Activity
View All

Aug 5 2020

ichoyjx accepted D85104: [flang][NFC] Unify OpenMP and OpenACC structure checker.
Aug 5 2020, 10:50 AM · Restricted Project, Restricted Project

Jul 28 2020

ichoyjx accepted D84768: [flang][NFC] Extract name resolution for OpenACC & OpenMP into new file.

I called ResolveDesignator just in case the designator is not resolved before doing further checks. I agree with Tim that we can assume it is until we find a case where it’s not.

Jul 28 2020, 4:25 PM · Restricted Project, Restricted Project

Jul 22 2020

ichoyjx accepted D84195: [flang][openacc] Skeleton for OpenACC construct lowering.
Jul 22 2020, 12:39 PM · Restricted Project, Restricted Project

Jul 21 2020

ichoyjx added inline comments to D84195: [flang][openacc] Skeleton for OpenACC construct lowering.
Jul 21 2020, 4:17 PM · Restricted Project, Restricted Project
ichoyjx accepted D83998: [flang][openacc] Basic name resolution infrastructure for OpenACC construct.
Jul 21 2020, 10:59 AM · Restricted Project, Restricted Project

Jul 20 2020

ichoyjx requested changes to D83998: [flang][openacc] Basic name resolution infrastructure for OpenACC construct.

Nice work on unifying two programming models' base attribute visitor. I am surprised that they could share most of the utils.

Jul 20 2020, 9:16 PM · Restricted Project, Restricted Project

Jul 10 2020

ichoyjx accepted D83326: [flang][openmp] Check clauses allowed semantic with tablegen generated map.

Thanks for the Nowait changes.

Jul 10 2020, 5:10 PM · Restricted Project

Jul 9 2020

ichoyjx added inline comments to D83326: [flang][openmp] Check clauses allowed semantic with tablegen generated map.
Jul 9 2020, 9:58 PM · Restricted Project

Jul 1 2020

ichoyjx accepted D82906: [flang][openmp] Use common Directive and Clause enum from llvm/Frontend.

It took me a while to go through the changes. The merge with tablegen looks very nice!

Jul 1 2020, 12:26 PM · Restricted Project, Restricted Project, Restricted Project

Apr 9 2020

ichoyjx accepted D77821: [Flang][OpenMP] Avoid abort when collapse clause value is negative.
Apr 9 2020, 2:57 PM · Restricted Project, Restricted Project
ichoyjx added a comment to D77821: [Flang][OpenMP] Avoid abort when collapse clause value is negative.
In D77821#1972684, @jdoerfert wrote:

Why is this not caught by the parser? I mean, this seems a lot of code to accommodate negative values and some conditions to not trip over them even though they are never allowed/useful.

Apr 9 2020, 2:57 PM · Restricted Project, Restricted Project
ichoyjx committed rG2839cb3835c5: [flang] Throw error in case of missing listed test (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] Throw error in case of missing listed test
Apr 9 2020, 12:17 PM
ichoyjx committed rG004a4c577b34: [flang] [OpenMP] Test Infra update to support OpenMP symbol tests (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] Test Infra update to support OpenMP symbol tests
Apr 9 2020, 12:17 PM
ichoyjx committed rGeeda3041605b: [flang] [OpenMP] address more comments (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] address more comments
Apr 9 2020, 12:17 PM
ichoyjx committed rG8143b8980de5: [flang] [OpenMP] adjust for PR#753 `OmpObject` parse tree change (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] adjust for PR#753 `OmpObject` parse tree change
Apr 9 2020, 12:17 PM
ichoyjx committed rG0554d39d74e8: [flang] [OpenMP] Implement no-multiple-appearance rule for DSA Clauses (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] Implement no-multiple-appearance rule for DSA Clauses
Apr 9 2020, 12:16 PM
ichoyjx committed rGdf51352d72f4: [flang] [OpenMP] avoid creating new symbol for common block (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] avoid creating new symbol for common block
Apr 9 2020, 12:16 PM
ichoyjx committed rG4ca8c5dc5c64: [flang] [OpenMP] OmpVisitor framework for Name Resolution (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] OmpVisitor framework for Name Resolution
Apr 9 2020, 12:16 PM
ichoyjx committed rGf3961579acc3: [flang] [OpenMP] add common block example (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] add common block example
Apr 9 2020, 12:16 PM
ichoyjx committed rGbb1127efb689: [flang] [OpenMP] Simplify `OmpObject` with `std::variant` (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] Simplify `OmpObject` with `std::variant`
Apr 9 2020, 12:06 PM
ichoyjx committed rG5676797c2aa4: [flang] Improve flag dumping for -funparse-with-symbols (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] Improve flag dumping for -funparse-with-symbols
Apr 9 2020, 12:02 PM
ichoyjx committed rGdb25a52fe754: [flang] [OpenMP] formalize `DEFAULTMAP` clause (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] formalize `DEFAULTMAP` clause
Apr 9 2020, 11:54 AM
ichoyjx committed rGd7443b5ad2e4: [flang] Add missing include for unordered_map (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] Add missing include for unordered_map
Apr 9 2020, 11:49 AM
ichoyjx committed rGbc52fc19222d: [flang] [OpenMP] extend `IF` clause to accept modifier on composite/combined… (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] extend `IF` clause to accept modifier on composite/combined…
Apr 9 2020, 11:48 AM
ichoyjx committed rG5c543da53ac2: [flang] [OpenMP] add structural checks for `TASKLOOP SIMD` (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] add structural checks for `TASKLOOP SIMD`
Apr 9 2020, 11:48 AM
ichoyjx committed rGd1bbccf1d565: [flang] [OpenMP] update `declare simd` directive with exclusive set (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] update `declare simd` directive with exclusive set
Apr 9 2020, 11:48 AM
ichoyjx committed rGe902c1d6b7d0: [flang] [OpenMP] enable check for `IF` clause modifier (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] enable check for `IF` clause modifier
Apr 9 2020, 11:48 AM
ichoyjx committed rGc4fa8b867e70: [flang] [OpenMP] Add structural checks for `TASK` (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] Add structural checks for `TASK`
Apr 9 2020, 11:48 AM
ichoyjx committed rG77ed1df8a796: [flang] [OpenMP] fix type for `Final` clause (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] fix type for `Final` clause
Apr 9 2020, 11:47 AM
ichoyjx committed rG658cf65249d6: [flang] [OpenMP] Expand full sets for `do`, `simd`, and `do simd` (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] Expand full sets for `do`, `simd`, and `do simd`
Apr 9 2020, 11:47 AM
ichoyjx committed rG23a7f387417f: [flang] [OpenMP] flang-compiler/f18#691 Update on Tim and Varun's review (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] flang-compiler/f18#691 Update on Tim and Varun's review
Apr 9 2020, 11:44 AM
ichoyjx committed rGf6273d719465: [flang] [OpenMP] structural checks for `PARALLEL SECTIONS` (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] structural checks for `PARALLEL SECTIONS`
Apr 9 2020, 11:44 AM
ichoyjx committed rGffb88549cb17: [flang] [OpenMP] add Begin and End Directive matching check (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] add Begin and End Directive matching check
Apr 9 2020, 11:44 AM
ichoyjx committed rG0a85616b071d: [flang] [OpenMP] update validity check for `OmpNowait`. (authored by Jinxin Yang <jinxiny@nvidia.com>).
[flang] [OpenMP] update validity check for `OmpNowait`.
Apr 9 2020, 11:43 AM