Page MenuHomePhabricator

richard.barton.arm (Richard Barton)
Principal Engineer - Arm

Projects

User does not belong to any projects.

User Details

User Since
Oct 3 2013, 2:16 AM (367 w, 5 d)

Recent Activity

Sep 16 2020

richard.barton.arm closed D87226: [flang] Convert release notes to markdown.

Looks like I committed this without the link text as 69230e7

Sep 16 2020, 10:33 AM · Restricted Project
richard.barton.arm added a comment to D87270: [Flang] Add GettingInvolved documentation page and sidebar..

Sorry @sameeranjoshi - you are right, the changes look good.

Sep 16 2020, 10:17 AM · Restricted Project
richard.barton.arm added a comment to D87270: [Flang] Add GettingInvolved documentation page and sidebar..

@sameeranjoshi I see this merged but I don't see any changes to the sidebar in my local build.

Sep 16 2020, 12:30 AM · Restricted Project
richard.barton.arm added a comment to D87714: [flang] Fix docs build.

Gone for the merge.

Sep 16 2020, 12:28 AM · Restricted Project
richard.barton.arm committed rGaf56be339f8c: [flang] Fix docs build (authored by richard.barton.arm).
[flang] Fix docs build
Sep 16 2020, 12:19 AM
richard.barton.arm closed D87714: [flang] Fix docs build.
Sep 16 2020, 12:19 AM · Restricted Project

Sep 15 2020

richard.barton.arm added a comment to D87242: [flang] Add new documentation main page.

Hi @hans thanks for giving it a try. I think it is fair enough that you don't try to fix it yourself.

Sep 15 2020, 12:05 PM · Restricted Project
richard.barton.arm requested review of D87714: [flang] Fix docs build.
Sep 15 2020, 12:01 PM · Restricted Project
richard.barton.arm accepted D87270: [Flang] Add GettingInvolved documentation page and sidebar..

LGTM - thanks for this.

Sep 15 2020, 5:27 AM · Restricted Project

Sep 14 2020

richard.barton.arm requested changes to D87270: [Flang] Add GettingInvolved documentation page and sidebar..
Sep 14 2020, 1:00 AM · Restricted Project

Sep 11 2020

richard.barton.arm added a comment to D87505: [flang] Fix build issue with BUILD_SHARED_LIBS=ON.

NP. We need to hurry up and get that buildbot into stable. We are upgrading the machine it runs on so it doesn't take 4 hours to build+make check! Hoping to have it up next week.

Sep 11 2020, 8:21 AM · Restricted Project
richard.barton.arm committed rGd2c69c2f4947: [flang] Fix build issue with BUILD_SHARED_LIBS=ON (authored by richard.barton.arm).
[flang] Fix build issue with BUILD_SHARED_LIBS=ON
Sep 11 2020, 8:14 AM
richard.barton.arm closed D87505: [flang] Fix build issue with BUILD_SHARED_LIBS=ON.
Sep 11 2020, 8:14 AM · Restricted Project
richard.barton.arm requested changes to D87270: [Flang] Add GettingInvolved documentation page and sidebar..

Nice one - a good addition to the docs, IMO.

Sep 11 2020, 8:11 AM · Restricted Project
richard.barton.arm committed rG271a7bb144d3: [flang] Add new documentation main page (authored by richard.barton.arm).
[flang] Add new documentation main page
Sep 11 2020, 6:22 AM
richard.barton.arm closed D87242: [flang] Add new documentation main page.
Sep 11 2020, 6:22 AM · Restricted Project
richard.barton.arm added a comment to D87242: [flang] Add new documentation main page.

@sameeranjoshi you happy to "accept this revision" :-) ?

Sep 11 2020, 5:58 AM · Restricted Project
richard.barton.arm updated the diff for D87242: [flang] Add new documentation main page.

I don't see a difference in the two for style. Both seem to have previous | next | index links in the top (and bottom) bars, as well as the indexsidebar as you point out. The indexsidebar seems to be a standard default from sphinx. LLVM uses a special one in llvm/docs/_templates/indexsidebar.html which does not have the previous/next topic links and instead has the permalinks to other articles.

I was talking about having the Table Of Contents which is in right pane to be in the center of page the way LLVM has.
Also when D87226 would be applied, it would remove the TOC and will add other contents there.

Sep 11 2020, 4:43 AM · Restricted Project
richard.barton.arm added a comment to D87341: [flang] Fix check for distinguishable operators/assignments.

I've posted what I think is the fix over on https://reviews.llvm.org/D87505

Sep 11 2020, 4:15 AM · Restricted Project, Restricted Project
richard.barton.arm requested review of D87505: [flang] Fix build issue with BUILD_SHARED_LIBS=ON.
Sep 11 2020, 4:15 AM · Restricted Project
richard.barton.arm added a comment to D87341: [flang] Fix check for distinguishable operators/assignments.

This commit missed adding a dependency from libFortranEvaluate and libFortranSemantics. Adding it back in introduces a circular dependency and so breaks shared library builds.

Sep 11 2020, 12:48 AM · Restricted Project, Restricted Project
richard.barton.arm accepted D86089: [flang][driver]Add experimental flang driver and frontend with help screen.

LGTM

Sep 11 2020, 12:19 AM · Restricted Project, Restricted Project, Restricted Project

Sep 10 2020

richard.barton.arm updated the diff for D87242: [flang] Add new documentation main page.

Rebasing over the top of the license header restoration.

Sep 10 2020, 12:01 PM · Restricted Project
richard.barton.arm added a comment to D87242: [flang] Add new documentation main page.

The TOC tree is displayed in the right indexsidebar, if it could be displayed at the top (see http://llvm.org/docs/CMake.html for reference) of individual pages that would be better and it would help reader initially to navigate to the internal section in the respective page.
Further I went on to apply D87226(contains a fixed side bar index links ) and the TOC disappears probably due to above mentioned issue.

Sep 10 2020, 11:58 AM · Restricted Project
richard.barton.arm accepted D86089: [flang][driver]Add experimental flang driver and frontend with help screen.

This LGTM. I think all the previous comments from other reviewers and me have been dealt with so I am happy to accept this revision based on the reviews so far.

Sep 10 2020, 4:14 AM · Restricted Project, Restricted Project, Restricted Project

Sep 8 2020

richard.barton.arm updated the diff for D87242: [flang] Add new documentation main page.

New version that uses recommonmark's AutoStructify plugin to re-write
the index page in markdown with toctrees in embedded rst blocks.

Sep 8 2020, 2:50 AM · Restricted Project
richard.barton.arm added a comment to D87242: [flang] Add new documentation main page.

I have a GettingInvolved.md can you include it as well if it makes sense to add it with this patch and the original authors agree.
Most of the content comes from mailing list meeting minutes from Gary(Thanks @gak).

Sep 8 2020, 12:57 AM · Restricted Project
richard.barton.arm committed rG69230e75f120: [flang] Convert release notes to markdown (authored by richard.barton.arm).
[flang] Convert release notes to markdown
Sep 8 2020, 12:48 AM
richard.barton.arm added inline comments to D87226: [flang] Convert release notes to markdown.
Sep 8 2020, 12:46 AM · Restricted Project

Sep 7 2020

richard.barton.arm requested review of D87242: [flang] Add new documentation main page.
Sep 7 2020, 8:51 AM · Restricted Project
richard.barton.arm committed rG7e5dab5fca4b: [flang] Spelling and format edits to README.txt. NFC. (authored by richard.barton.arm).
[flang] Spelling and format edits to README.txt. NFC.
Sep 7 2020, 8:49 AM
richard.barton.arm committed rG2e1827271cb1: [flang] Fix link to old repo location in doxygen mainpage. NFC. (authored by richard.barton.arm).
[flang] Fix link to old repo location in doxygen mainpage. NFC.
Sep 7 2020, 8:43 AM
richard.barton.arm requested review of D87226: [flang] Convert release notes to markdown.
Sep 7 2020, 1:14 AM · Restricted Project

Sep 4 2020

richard.barton.arm added a comment to D86089: [flang][driver]Add experimental flang driver and frontend with help screen.

Another random thought that just came to me: what does the new driver do when you invoke it with no input files or options? I could imagine a few sensible outcomes (error: no input (clang and gcc/gfortran behaviour), print version and exit, print help and exit, etc.) and I don't have a strong preference over which we chose here but I think there should be a test for it in test/Driver

Sep 4 2020, 3:25 AM · Restricted Project, Restricted Project, Restricted Project

Sep 2 2020

richard.barton.arm requested changes to D86089: [flang][driver]Add experimental flang driver and frontend with help screen.

Requesting changes mostly because of the exit status issue on the Driver tests.

Sep 2 2020, 11:01 AM · Restricted Project, Restricted Project, Restricted Project

Sep 1 2020

richard.barton.arm added a comment to D84334: [flang] Version information in flang/f18.

I have tested this works well on an out of tree build (as it broke it before) so have no reservations about pushing the change again on @coti 's behalf.

Sep 1 2020, 11:07 AM · Restricted Project, Restricted Project
richard.barton.arm committed rGb11c52781635: [flang] Version information in flang/f18 (authored by coti).
[flang] Version information in flang/f18
Sep 1 2020, 11:06 AM
richard.barton.arm closed D84334: [flang] Version information in flang/f18.
Sep 1 2020, 11:06 AM · Restricted Project, Restricted Project

Aug 25 2020

richard.barton.arm accepted D84334: [flang] Version information in flang/f18.

This is working well for me in an in-tree build.

Aug 25 2020, 6:37 AM · Restricted Project, Restricted Project

Aug 24 2020

richard.barton.arm added a comment to D84334: [flang] Version information in flang/f18.

@coti the reason for the build failure is because you have removed both of the duplicate definitions of include in flang/tools/f18/CMakeLists.txt. This causes CMake not to be able to find the right files when it creates the builtin module files. One of these needs to be restored in your patch for the build to work as before.

Aug 24 2020, 8:17 AM · Restricted Project, Restricted Project

Aug 21 2020

richard.barton.arm added inline comments to D86089: [flang][driver]Add experimental flang driver and frontend with help screen.
Aug 21 2020, 10:34 AM · Restricted Project, Restricted Project, Restricted Project

Aug 20 2020

richard.barton.arm requested changes to D86089: [flang][driver]Add experimental flang driver and frontend with help screen.

A few specific comments to address here as well as the pre-commit linting ones.

Aug 20 2020, 7:14 AM · Restricted Project, Restricted Project, Restricted Project

Aug 17 2020

richard.barton.arm added a comment to D84334: [flang] Version information in flang/f18.

Steve's patch works for me (cmake 3.17). @coti , your error message looks like what would happen if you replaced both definitions of {{include}} with the {{target_include_directories}} call. {{include}} is set up to the location of pre-built modules and is used in the compilation of said modules and then pre-processed into the flang.sh script. You still need that as well as setting {{target_include_directories}} to tell CMake where f18_version.h is when building f18.cpp.

Aug 17 2020, 3:30 AM · Restricted Project, Restricted Project

Aug 12 2020

richard.barton.arm added a comment to D84334: [flang] Version information in flang/f18.

@coti - I've had another look and I think your new test is stumbling across an existing bug. If you play around with the existing __F18* macros, you can see that they are not being applied correctly in the code:

Aug 12 2020, 8:52 AM · Restricted Project, Restricted Project
richard.barton.arm requested changes to D85828: [Flang] Move mark down documentation(md) files to reStructuredText(rst) file format..

I still see a few mentions of the old documentation dir location in the codebase:

Aug 12 2020, 6:14 AM · Restricted Project

Aug 11 2020

richard.barton.arm added a comment to D84334: [flang] Version information in flang/f18.

I have reverted the patch

Aug 11 2020, 12:44 AM · Restricted Project, Restricted Project
richard.barton.arm committed rG0057532e3f45: Revert "[flang] Version information in flang/f18" (authored by richard.barton.arm).
Revert "[flang] Version information in flang/f18"
Aug 11 2020, 12:43 AM

Aug 10 2020

richard.barton.arm accepted D85470: [Flang] Fix release blocker issue #46931 related to documentation. .
Aug 10 2020, 10:22 AM · Restricted Project
richard.barton.arm requested changes to D85470: [Flang] Fix release blocker issue #46931 related to documentation. .

These changes build for me and I get a .html version of the flang release notes in the docs directory in the build. It is a shame there is not more content there and I suppose we'll need to convert the docs in /documentation over to .rst format to get them included in this set.

Aug 10 2020, 10:22 AM · Restricted Project
richard.barton.arm added a reviewer for D84864: [flang] Add release notes for LLVM 11 release: richard.barton.arm.
Aug 10 2020, 10:13 AM · Restricted Project
richard.barton.arm committed rG89a9db438f85: [flang] Version information in flang/f18 (authored by coti).
[flang] Version information in flang/f18
Aug 10 2020, 8:18 AM
richard.barton.arm closed D84334: [flang] Version information in flang/f18.
Aug 10 2020, 8:18 AM · Restricted Project, Restricted Project
richard.barton.arm added a comment to D84334: [flang] Version information in flang/f18.

Please can you send me your email address offline for the commit log?

Aug 10 2020, 6:17 AM · Restricted Project, Restricted Project
richard.barton.arm added a comment to D84334: [flang] Version information in flang/f18.

I'm afraid arcanist does not apply the patch well. It does not like the new file creation. I'm not sure how you are creating this diff, but are you able to re-upload a diff created with diff -Naur to handle the new files correctly?

Aug 10 2020, 1:50 AM · Restricted Project, Restricted Project

Aug 7 2020

richard.barton.arm added a comment to D84334: [flang] Version information in flang/f18.

I'm afraid that still doesn't work. My master is on 7d0f691.

Aug 7 2020, 10:18 AM · Restricted Project, Restricted Project
richard.barton.arm added a comment to D85470: [Flang] Fix release blocker issue #46931 related to documentation. .

Regarding the release note contents. My original review proposing these did not get any strong objections so I propose that once we are all happy with the code that this initial version of the release notes be committed alongside. I will make a follow up review with any further edits to it before release.

Aug 7 2020, 9:47 AM · Restricted Project
richard.barton.arm added a comment to D84334: [flang] Version information in flang/f18.

It needs rebasing - please can you do this then I will commit it on your behalf?

Aug 7 2020, 9:43 AM · Restricted Project, Restricted Project
richard.barton.arm added a comment to D84334: [flang] Version information in flang/f18.

Do you have commit access @coti ?

Aug 7 2020, 9:04 AM · Restricted Project, Restricted Project
richard.barton.arm abandoned D84867: [flang] Add placeholder ReleaseNotes file.

Abandoning the changes in favour of https://reviews.llvm.org/D85470

Aug 7 2020, 5:25 AM · Restricted Project
richard.barton.arm abandoned D84864: [flang] Add release notes for LLVM 11 release.

Super - thanks @sameeranjoshi for taking this forward. I'll close this patch and we can do the rest of the work on D85470

Aug 7 2020, 5:20 AM · Restricted Project

Aug 5 2020

richard.barton.arm accepted D84334: [flang] Version information in flang/f18.

Thanks for adding the tests. IMO, the regex approach in the test is just fine.

Aug 5 2020, 12:16 AM · Restricted Project, Restricted Project

Aug 4 2020

richard.barton.arm added a comment to D84334: [flang] Version information in flang/f18.

The preprocessing tests are being executed now so that would be a good place to add a test.

Aug 4 2020, 10:56 AM · Restricted Project, Restricted Project
richard.barton.arm requested changes to D84334: [flang] Version information in flang/f18.

Looking good. Please can you add some tests?

  • For --version, there already is one for the version screen in flang/test/Driver that could be updated to capture the version number also and run multiple times to test the synonyms.
    • Testing {{\-v}} when it means verbose is hard so suggest not doing that. We need {{-###}} really to test the driver more, which is outside the scope of your change.
  • For the macros, I think the flang/test/Preprocessing" directory would be the best place but that directory is full of non-tests (which we need to delete really) so we can't add a real test there at the moment. Perhaps add a new test to flang/test/Driver for now that runs flang with -E and checks the substitutions work.
Aug 4 2020, 4:41 AM · Restricted Project, Restricted Project

Jul 31 2020

richard.barton.arm committed rGb068d19a151d: [flang] Add details to --help screen on default behaviour (authored by richard.barton.arm).
[flang] Add details to --help screen on default behaviour
Jul 31 2020, 9:03 AM
richard.barton.arm committed rG30e45f339eb0: [flang] Add -h as a synonym for help (authored by richard.barton.arm).
[flang] Add -h as a synonym for help
Jul 31 2020, 9:03 AM
richard.barton.arm committed rGdd5ea5674b86: [flang] Make interactive behaviour more obvious (authored by richard.barton.arm).
[flang] Make interactive behaviour more obvious
Jul 31 2020, 9:03 AM
richard.barton.arm closed D84857: [flang] Add -h as a synonym for help.
Jul 31 2020, 9:03 AM · Restricted Project
richard.barton.arm closed D84856: [flang] Add details to --help screen on default behaviour.
Jul 31 2020, 9:03 AM · Restricted Project
richard.barton.arm closed D84855: [flang] Make interactive behaviour more obvious.
Jul 31 2020, 9:03 AM · Restricted Project
richard.barton.arm updated the diff for D84855: [flang] Make interactive behaviour more obvious.

Fix clang-format error.

Jul 31 2020, 6:08 AM · Restricted Project
richard.barton.arm added a reviewer for D84864: [flang] Add release notes for LLVM 11 release: hans.
Jul 31 2020, 6:00 AM · Restricted Project
richard.barton.arm added a reviewer for D84867: [flang] Add placeholder ReleaseNotes file: hans.
Jul 31 2020, 6:00 AM · Restricted Project

Jul 30 2020

richard.barton.arm added a comment to D84334: [flang] Version information in flang/f18.

I don't think it is safe to assume that LLVM Flang will always be the same as classic Flang for all of the same behaviors that CMake cares about. I think we should be considering LLVM Flang as a new compiler rather than as a different version of classic Flang. I think that means we need to make a change in CMake to add support for LLVM Flang as a new compiler.

Jul 30 2020, 12:15 AM · Restricted Project, Restricted Project

Jul 29 2020

richard.barton.arm requested review of D84867: [flang] Add placeholder ReleaseNotes file.
Jul 29 2020, 9:20 AM · Restricted Project
richard.barton.arm requested review of D84864: [flang] Add release notes for LLVM 11 release.
Jul 29 2020, 9:09 AM · Restricted Project
richard.barton.arm requested review of D84857: [flang] Add -h as a synonym for help.
Jul 29 2020, 8:38 AM · Restricted Project
richard.barton.arm requested review of D84856: [flang] Add details to --help screen on default behaviour.
Jul 29 2020, 8:37 AM · Restricted Project
richard.barton.arm requested review of D84855: [flang] Make interactive behaviour more obvious.
Jul 29 2020, 8:36 AM · Restricted Project
richard.barton.arm abandoned D84853: [flang] Make interactive behaviour more obvious.

I wanted to push this as a patch series.

Jul 29 2020, 8:28 AM · Restricted Project
richard.barton.arm abandoned D84851: [flang] Add -h as a synonym for help.

I wanted to push this as a patch series.

Jul 29 2020, 8:28 AM · Restricted Project, Restricted Project
richard.barton.arm requested review of D84853: [flang] Make interactive behaviour more obvious.
Jul 29 2020, 8:16 AM · Restricted Project
richard.barton.arm added a project to D84851: [flang] Add -h as a synonym for help: Restricted Project.
Jul 29 2020, 8:04 AM · Restricted Project, Restricted Project
richard.barton.arm requested review of D84851: [flang] Add -h as a synonym for help.
Jul 29 2020, 8:03 AM · Restricted Project, Restricted Project

Jul 28 2020

richard.barton.arm added a comment to D84334: [flang] Version information in flang/f18.

Although LLVM flang is the spiritual successor to classic flang, I don't think we are specifically aiming for any sort of compatibility between the two compilers, for example on option names, feature support, language support, processor defined behavior, 'bug compatibility', etc. so in this sense the two are completely different compilers. I think it unlikely that a user of classic flang that has conditionalized some code on __FLANG due to some quirk of classic flang or some bug in classic flang that they are working around will necessarily need or want to run the same code for LLVM flang for the same reason. I think this would steer us strongly away from supporting __FLANG in LLVM flang to indicate that it and classic flang are connected in this way.

Jul 28 2020, 1:33 AM · Restricted Project, Restricted Project

Jul 14 2020

richard.barton.arm committed rGf4476b72fb13: [lit] Prevent hang when lit sees non-ASCII characters (authored by richard.barton.arm).
[lit] Prevent hang when lit sees non-ASCII characters
Jul 14 2020, 10:41 AM
richard.barton.arm closed D82754: [lit] Prevent hang when lit sees non-ASCII characters.
Jul 14 2020, 10:41 AM · Restricted Project
richard.barton.arm accepted D83488: [flang] Change the default F18_FC to gfortran.

LGTM - thanks for doing this one for splitting the patch!

Jul 14 2020, 10:36 AM · Restricted Project, Restricted Project
richard.barton.arm added inline comments to D82754: [lit] Prevent hang when lit sees non-ASCII characters.
Jul 14 2020, 10:29 AM · Restricted Project
richard.barton.arm updated the diff for D82754: [lit] Prevent hang when lit sees non-ASCII characters.

Actually delete the previous new test (rebasing issues - sorry)

Jul 14 2020, 10:27 AM · Restricted Project
richard.barton.arm updated the diff for D82754: [lit] Prevent hang when lit sees non-ASCII characters.

Updated version taking into account review comments on test and comment.

Jul 14 2020, 10:25 AM · Restricted Project

Jul 13 2020

richard.barton.arm accepted D83687: [flang] Extended the flang driver options to include gfortran equivalents to pgf90 specific options..

Timezones are not helping here - I need to clock off for the day. I think revision 1 + revision 2 are correct when combined.

Jul 13 2020, 11:10 AM · Restricted Project, Restricted Project
richard.barton.arm added a comment to D83687: [flang] Extended the flang driver options to include gfortran equivalents to pgf90 specific options..

Looks like you needed to squash this into the preivous revision of this patch before submitting? I only see the -fopenmp change now.

Jul 13 2020, 11:01 AM · Restricted Project, Restricted Project
richard.barton.arm requested changes to D83488: [flang] Change the default F18_FC to gfortran.

Request one change to OpenMP handling, but the rest looks fine.

Jul 13 2020, 10:18 AM · Restricted Project, Restricted Project
richard.barton.arm accepted D83687: [flang] Extended the flang driver options to include gfortran equivalents to pgf90 specific options..

This LGTM and was reviewed already under D83488. Happy to approve.

Jul 13 2020, 10:12 AM · Restricted Project, Restricted Project

Jul 10 2020

richard.barton.arm added a comment to D83488: [flang] Change the default F18_FC to gfortran.

Thanks for picking up the work on this one @AlexisPerry!

Jul 10 2020, 6:26 AM · Restricted Project, Restricted Project

Jul 8 2020

richard.barton.arm added a comment to D77815: [flang] Fix setting mxcsr on MSVC.

+1 on @ro 's suggestion.

Jul 8 2020, 1:18 AM · Restricted Project, Restricted Project

Jul 7 2020

Herald added a project to D83320: Hand port modfile01.f90 from test_modfile.sh to FileCheck: Restricted Project.
Jul 7 2020, 9:22 AM · Restricted Project
richard.barton.arm updated the diff for D82754: [lit] Prevent hang when lit sees non-ASCII characters.

Arg - finger trouble using arc!

Jul 7 2020, 9:14 AM · Restricted Project
richard.barton.arm updated the diff for D82754: [lit] Prevent hang when lit sees non-ASCII characters.

Add test and comment.

Jul 7 2020, 9:09 AM · Restricted Project
richard.barton.arm added a comment to D82754: [lit] Prevent hang when lit sees non-ASCII characters.

By "passes", I think you're saying that it doesn't reproduce the error. Right?

Jul 7 2020, 9:08 AM · Restricted Project