Page MenuHomePhabricator

[X86][FPEnv] Lowering of {get,set,reset}_fpenv
Needs ReviewPublic

Authored by sepavloff on Jun 15 2020, 3:13 AM.

Details

Summary

The change implements lowering of get_fpenv, set_fpenv and
reset_fpenv.

Diff Detail

Unit TestsFailed

TimeTest
10,140 mslinux > libomp.env::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test -I /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/src -L /mnt/disks/ssd0/agent/llvm-project/build/lib -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/env/kmp_set_dispatch_buf.c -o /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/env/Output/kmp_set_dispatch_buf.c.tmp -lm -latomic && env KMP_DISP_NUM_BUFFERS=0 /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/env/Output/kmp_set_dispatch_buf.c.tmp
1,450 mslinux > libomp.worksharing/for::Unknown Unit Message ("")
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test -I /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/src -L /mnt/disks/ssd0/agent/llvm-project/build/lib -I /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/ompt /mnt/disks/ssd0/agent/llvm-project/openmp/runtime/test/worksharing/for/kmp_set_dispatch_buf.c -o /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/worksharing/for/Output/kmp_set_dispatch_buf.c.tmp -lm -latomic && /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/test/worksharing/for/Output/kmp_set_dispatch_buf.c.tmp 7

Event Timeline

sepavloff created this revision.Jun 15 2020, 3:13 AM
Herald added a project: Restricted Project. · View Herald Transcript
sepavloff updated this revision to Diff 270701.Jun 15 2020, 3:20 AM

Fixed formatting issues

craig.topper added inline comments.Jun 15 2020, 12:21 PM
llvm/lib/Target/X86/X86SelectionDAGInfo.cpp
390

Windows defaults to 53 bit precision.

sepavloff updated this revision to Diff 272365.Jun 22 2020, 2:59 AM

Updated patch after update of dependency

sepavloff marked 2 inline comments as done.Jun 22 2020, 3:02 AM
sepavloff added inline comments.
llvm/lib/Target/X86/X86SelectionDAGInfo.cpp
390

Fixed.

kpn added a subscriber: kpn.Jun 23 2020, 12:34 PM
sepavloff marked an inline comment as done.

Updated patch

  • Remove changes related to fix for mayLoad/mayStore properties, the relevant changes are already in master,
  • Removed lowering of ISD::GET_FPENV and friends. This operation is useless as lowering of FPEnv intrinsics is made when constructing DAG.