This is an archive of the discontinued LLVM Phabricator instance.

[OPENMP50]Add initial support for 'affinity' clause.
ClosedPublic

Authored by ABataev on May 18 2020, 11:38 AM.

Details

Summary

Added parsing/sema/serialization support for affinity clause in task
directives.

Diff Detail

Event Timeline

ABataev created this revision.May 18 2020, 11:38 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 18 2020, 11:38 AM
jdoerfert accepted this revision.May 18 2020, 2:18 PM

LGTM with minor comments.

clang/lib/Parse/ParseOpenMP.cpp
3458

Please make this a conditional. Having a 5 line expression with ternary and comma operator is hard to read.

clang/lib/Sema/SemaOpenMP.cpp
18836

I you can, reuse SimpleExpr here and above.

This revision is now accepted and ready to land.May 18 2020, 2:18 PM
This revision was automatically updated to reflect the committed changes.