This upgrade should be friction-less because we've already been ensuring
that CMake >= 3.13.4 is used.
This is part of the effort discussed on llvm-dev here:
http://lists.llvm.org/pipermail/llvm-dev/2020-April/140578.html
Paths
| Differential D78648
[CMake] Bump CMake minimum version to 3.13.4 ClosedPublic Authored by ldionne on Apr 22 2020, 8:26 AM.
Details
Summary This upgrade should be friction-less because we've already been ensuring This is part of the effort discussed on llvm-dev here: http://lists.llvm.org/pipermail/llvm-dev/2020-April/140578.html
Diff Detail
Event TimelineHerald added projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project. · View Herald Transcript Herald added subscribers: libcxx-commits, openmp-commits, lldb-commits and 21 others. · View Herald Transcript ldionne added a parent revision: D78646: [CMake] Enforce the minimum CMake version to be at least 3.13.4.Apr 22 2020, 8:28 AM Comment Actions This review is for the upcoming CMake upgrade once we branch off the LLVM 11 release branch. I won't apply it until after the branch has been created, which is around July. ldionne accepted this revision as: Restricted Project, Restricted Project, Restricted Project.Apr 22 2020, 8:32 AM Comment Actions With the newer minimum CMake version, we can eliminate a bunch of the policy settings as well, but that can be a follow-up (especially given this isn't gonna ship for a few months). (Another followup would be to add a max version to our cmake_minimum_required, to streamline policy settings even further. See https://cmake.org/cmake/help/latest/command/cmake_policy.html for details.)
This revision is now accepted and ready to land.Apr 23 2020, 1:35 PM Comment Actions Okay, the previous patch has landed and no issues have come up, so I'm going to move forward with this patch now. Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 22 2020, 11:24 AM Closed by commit rGafa1afd4108d: [CMake] Bump CMake minimum version to 3.13.4 (authored by ldionne). · Explain WhyJul 22 2020, 11:25 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 279895 clang/CMakeLists.txt
clang/tools/scan-build-py/tests/functional/exec/CMakeLists.txt
compiler-rt/CMakeLists.txt
compiler-rt/cmake/Modules/CustomLibcxx/CMakeLists.txt
compiler-rt/lib/builtins/CMakeLists.txt
flang/CMakeLists.txt
libclc/CMakeLists.txt
libcxx/CMakeLists.txt
libcxx/utils/ci/runtimes/CMakeLists.txt
libcxxabi/CMakeLists.txt
libunwind/CMakeLists.txt
lld/CMakeLists.txt
lldb/CMakeLists.txt
lldb/tools/debugserver/CMakeLists.txt
llvm/CMakeLists.txt
llvm/docs/CMake.rst
llvm/docs/CMakePrimer.rst
llvm/docs/GettingStarted.rst
llvm/runtimes/CMakeLists.txt
llvm/utils/benchmark/CMakeLists.txt
mlir/examples/standalone/CMakeLists.txt
openmp/CMakeLists.txt
openmp/cmake/DetectTestCompiler/CMakeLists.txt
openmp/runtime/cmake/LibompCheckLinkerFlag.cmake
parallel-libs/CMakeLists.txt
parallel-libs/acxxel/CMakeLists.txt
polly/CMakeLists.txt
pstl/CMakeLists.txt
|
Is the higher minimum here for future-proofing?